@sillsdev/docu-notion 0.14.0-alpha.2 → 0.14.0-alpha.4

package/dist/MakeImagePersistencePlan.d.ts

@@ -1,2 +1,3 @@
 import { ImageSet } from "./images";
 export declare function makeImagePersistencePlan(imageSet: ImageSet, imageOutputRootPath: string, imagePrefix: string): void;
+export declare function hashOfString(s: string): number;

package/dist/MakeImagePersistencePlan.js

@@ -23,21 +23,21 @@ var __importStar = (this && this.__importStar) || function (mod) {
     return result;
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.makeImagePersistencePlan = void 0;
+exports.hashOfString = exports.makeImagePersistencePlan = void 0;
 const Path = __importStar(require("path"));
 const log_1 = require("./log");
 const process_1 = require("process");
 function makeImagePersistencePlan(imageSet, imageOutputRootPath, imagePrefix) {
-    var _a;
+    var _a, _b;
     if ((_a = imageSet.fileType) === null || _a === void 0 ? void 0 : _a.ext) {
         // Since most images come from pasting screenshots, there isn't normally a filename. That's fine, we just make a hash of the url
         // Images that are stored by notion come to us with a complex url that changes over time, so we pick out the UUID that doesn't change. Example:
         //    https://s3.us-west-2.amazonaws.com/secure.notion-static.com/d1058f46-4d2f-4292-8388-4ad393383439/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20220516%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20220516T233630Z&X-Amz-Expires=3600&X-Amz-Signature=f215704094fcc884d37073b0b108cf6d1c9da9b7d57a898da38bc30c30b4c4b5&X-Amz-SignedHeaders=host&x-id=GetObject
-        let thingToHash = imageSet.primaryUrl;
-        const m = /.*secure\.notion-static\.com\/(.*)\//gm.exec(imageSet.primaryUrl);
-        if (m && m.length > 1) {
-            thingToHash = m[1];
-        }
+        // But around Sept 2023, they changed the url to be something like:
+        //    https://prod-files-secure.s3.us-west-2.amazonaws.com/d9a2b712-cf69-4bd6-9d65-87a4ceeacca2/d1bcdc8c-b065-4e40-9a11-392aabeb220e/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20230915%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20230915T161258Z&X-Amz-Expires=3600&X-Amz-Signature=28fca48e65fba86d539c3c4b7676fce1fa0857aa194f7b33dd4a468ecca6ab24&X-Amz-SignedHeaders=host&x-id=GetObject
+        // The thing we want is the last UUID before the ?
+        const urlBeforeQuery = imageSet.primaryUrl.split("?")[0];
+        const thingToHash = (_b = findLastUuid(urlBeforeQuery)) !== null && _b !== void 0 ? _b : urlBeforeQuery;
         const hash = hashOfString(thingToHash);
         imageSet.outputFileName = `${hash}.${imageSet.fileType.ext}`;
         imageSet.primaryFileOutputPath = Path.posix.join((imageOutputRootPath === null || imageOutputRootPath === void 0 ? void 0 : imageOutputRootPath.length) > 0
@@ -58,9 +58,18 @@ function makeImagePersistencePlan(imageSet, imageOutputRootPath, imagePrefix) {
     }
 }
 exports.makeImagePersistencePlan = makeImagePersistencePlan;
+function findLastUuid(url) {
+    // Regex for a UUID surrounded by slashes
+    const uuidPattern = /(?<=\/)[0-9a-f]{8}-[0-9a-f]{4}-[0-5][0-9a-f]{3}-[089ab][0-9a-f]{3}-[0-9a-f]{12}(?=\/)/gi;
+    // Find all UUIDs
+    const uuids = url.match(uuidPattern);
+    // Return the last UUID if any exist, else return null
+    return uuids ? uuids[uuids.length - 1].trim() : null;
+}
 function hashOfString(s) {
     let hash = 0;
     for (let i = 0; i < s.length; ++i)
         hash = Math.imul(31, hash) + s.charCodeAt(i);
     return Math.abs(hash);
 }
+exports.hashOfString = hashOfString;

package/dist/config/default.docunotion.config.js

@@ -8,7 +8,6 @@ const ColumnListTransformer_1 = require("../plugins/ColumnListTransformer");
 const ColumnTransformer_1 = require("../plugins/ColumnTransformer");
 const EscapeHtmlBlockModifier_1 = require("../plugins/EscapeHtmlBlockModifier");
 const HeadingTransformer_1 = require("../plugins/HeadingTransformer");
-const NumberedListTransformer_1 = require("../plugins/NumberedListTransformer");
 const TableTransformer_1 = require("../plugins/TableTransformer");
 const VideoTransformer_1 = require("../plugins/VideoTransformer");
 const externalLinks_1 = require("../plugins/externalLinks");
@@ -24,7 +23,6 @@ const defaultConfig = {
         images_1.standardImageTransformer,
         CalloutTransformer_1.standardCalloutTransformer,
         TableTransformer_1.standardTableTransformer,
-        NumberedListTransformer_1.standardNumberedListTransformer,
         VideoTransformer_1.standardVideoTransformer,
         // Link modifiers, which are special because they can read metadata from all the pages in order to figure out the correct url
         internalLinks_1.standardInternalLinkConversion,

package/dist/makeImagePersistencePlan.spec.js

@@ -9,9 +9,10 @@ test("primary file with explicit file output path and prefix", () => {
         fileType: { ext: "png", mime: "image/png" },
     };
     (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "./static/notion_imgs", "/notion_imgs");
-    expect(imageSet.outputFileName).toBe("463556435.png");
-    expect(imageSet.primaryFileOutputPath).toBe("static/notion_imgs/463556435.png");
-    expect(imageSet.filePathToUseInMarkdown).toBe("/notion_imgs/463556435.png");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("https://s3.us-west-2.amazonaws.com/primaryImage");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
+    expect(imageSet.primaryFileOutputPath).toBe(`static/notion_imgs/${expectedHash}.png`);
+    expect(imageSet.filePathToUseInMarkdown).toBe(`/notion_imgs/${expectedHash}.png`);
 });
 test("primary file with defaults for image output path and prefix", () => {
     const imageSet = {
@@ -21,10 +22,31 @@ test("primary file with defaults for image output path and prefix", () => {
         fileType: { ext: "png", mime: "image/png" },
     };
     (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "", "");
-    expect(imageSet.outputFileName).toBe("463556435.png");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("https://s3.us-west-2.amazonaws.com/primaryImage");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
     // the default behavior is to put the image next to the markdown file
-    expect(imageSet.primaryFileOutputPath).toBe("/pathToParentSomewhere/463556435.png");
-    expect(imageSet.filePathToUseInMarkdown).toBe("./463556435.png");
+    expect(imageSet.primaryFileOutputPath).toBe(`/pathToParentSomewhere/${expectedHash}.png`);
+    expect(imageSet.filePathToUseInMarkdown).toBe(`./${expectedHash}.png`);
+});
+test("properly extract UUID from old-style notion image url", () => {
+    const imageSet = {
+        primaryUrl: "https://s3.us-west-2.amazonaws.com/secure.notion-static.com/e1058f46-4d2f-4292-8388-4ad393383439/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20220516%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20220516T233630Z&X-Amz-Expires=3600&X-Amz-Signature=f215704094fcc884d37073b0b108cf6d1c9da9b7d57a898da38bc30c30b4c4b5&X-Amz-SignedHeaders=host&x-id=GetObject",
+        localizedUrls: [],
+        fileType: { ext: "png", mime: "image/png" },
+    };
+    (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "./static/notion_imgs", "/notion_imgs");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("e1058f46-4d2f-4292-8388-4ad393383439");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
+});
+test("properly extract UUID from new-style (Sept 2023) notion image url", () => {
+    const imageSet = {
+        primaryUrl: "https://prod-files-secure.s3.us-west-2.amazonaws.com/d9a2b712-cf69-4bd6-9d65-87a4ceeacca2/d1bcdc8c-b065-4e40-9a11-392aabeb220e/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20230915%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20230915T161258Z&X-Amz-Expires=3600&X-Amz-Signature=28fca48e65fba86d539c3c4b7676fce1fa0857aa194f7b33dd4a468ecca6ab24&X-Amz-SignedHeaders=host&x-id=GetObject",
+        localizedUrls: [],
+        fileType: { ext: "png", mime: "image/png" },
+    };
+    (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "./static/notion_imgs", "/notion_imgs");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("d1bcdc8c-b065-4e40-9a11-392aabeb220e");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
 });
 // In order to make image fallback work with other languages, we have to have
 // a file for each image, in each Docusaurus language directory. This is true

package/dist/plugins/ColumnTransformer.js

@@ -28,13 +28,11 @@ function notionColumnToMarkdown(notionToMarkdown, getBlockChildren, block) {
         const { id, has_children } = block; // "any" because the notion api type system is complex with a union that don't know how to help TS to cope with
         if (!has_children)
             return "";
-        const children = yield getBlockChildren(id);
-        const childrenPromises = children.map((column) => __awaiter(this, void 0, void 0, function* () { return yield notionToMarkdown.blockToMarkdown(column); }));
-        const childrenStrings = yield Promise.all(childrenPromises);
+        const columnChildren = yield getBlockChildren(id);
+        const childrenMdBlocksArray = yield Promise.all(columnChildren.map((child) => __awaiter(this, void 0, void 0, function* () { return yield notionToMarkdown.blocksToMarkdown([child]); })));
+        const childrenMarkdown = childrenMdBlocksArray.map(mdBlockArray => notionToMarkdown.toMarkdownString(mdBlockArray).parent);
         const columnWidth = yield getColumnWidth(block);
-        // note: it would look better in the markup with \n, but that
-        // causes notion-to-md to give us ":::A" instead of \n for some reason.
-        return (`<div class='notion-column' style={{width: '${columnWidth}'}}>\n\n${childrenStrings.join("\n\n")}\n\n</div>` +
+        return (`<div class='notion-column' style={{width: '${columnWidth}'}}>\n\n${childrenMarkdown.join("\n")}\n</div>` +
             // Spacer between columns. CSS takes care of hiding this for the last column
             // and when the screen is too narrow for multiple columns.
             `<div className='notion-spacer'></div>`);

package/dist/plugins/ColumnTransformer.spec.js

@@ -0,0 +1,118 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const pluginTestRun_1 = require("./pluginTestRun");
+const ColumnTransformer_1 = require("./ColumnTransformer");
+// Even though we can set up most tests with our own children
+// so that we aren't relying on real data from Notion,
+// we can't prevent the notion-to-md library from making an API call
+// every time it processes a block with has_children:true.
+// So for these tests with children, we need any valid API key.
+const runTestsWhichRequireAnyValidApiKey = !!process.env.DOCU_NOTION_INTEGRATION_TOKEN;
+// To test grandchildren, we can't get around notion-to-md making an API call
+// to get real children. So we need a specific notion record.
+// For that reason, we don't try to run these tests unless the user changes this flag.
+// But it is an important test; grandchildren in columns were broken.
+// See https://github.com/sillsdev/docu-notion/issues/70.
+const runManualTestsWhichRequireSpecificNotionRecords = false;
+const columnBlock = {
+    object: "block",
+    id: "e6d2d7b7-b1ed-464a-86d2-bb5f6be78a03",
+    has_children: true,
+    type: "column",
+    column: {},
+};
+function getResults(children) {
+    return __awaiter(this, void 0, void 0, function* () {
+        return yield (0, pluginTestRun_1.blocksToMarkdown)({ plugins: [ColumnTransformer_1.standardColumnTransformer] }, [columnBlock], undefined, children, process.env.DOCU_NOTION_INTEGRATION_TOKEN);
+    });
+}
+const columnWrapperStart = "<div class='notion-column' style=\\{\\{width: '.*?'\\}\\}>\\n\\n";
+const columnWrapperEnd = "\\n\\n<\\/div><div className='notion-spacer'><\\/div>";
+if (runTestsWhichRequireAnyValidApiKey) {
+    columnBlock.has_children = true;
+    test("requires API key - column with paragraph", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([getTestParagraphBlock()]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?my paragraph\\s*?${columnWrapperEnd}`));
+    }), 20000);
+    test("requires API key - column with two paragraphs", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([
+            getTestParagraphBlock(1),
+            getTestParagraphBlock(2),
+        ]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?my paragraph 1\\s+?my paragraph 2\\s*?${columnWrapperEnd}`));
+    }), 20000);
+    test("requires API key - column with numbered list", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([
+            getNumberedListItemBlock(1),
+            getNumberedListItemBlock(2),
+        ]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?1\\. Numbered list item 1\\s+?2\\. Numbered list item 2\\s*?${columnWrapperEnd}`, "s"));
+    }), 20000);
+    if (runManualTestsWhichRequireSpecificNotionRecords) {
+        test("manual test - requires specific notion record and API key - column with numbered list with sublist", () => __awaiter(void 0, void 0, void 0, function* () {
+            const realNumberedListBlock = getNumberedListItemBlock(1);
+            realNumberedListBlock.id = "ca08d14b-9b70-4f6f-9d17-9fd74b57afeb";
+            realNumberedListBlock.has_children = true;
+            const results = yield getResults([realNumberedListBlock]);
+            expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?1\\. Numbered list item 1\\s+?- unordered sub-bullet\\s*?${columnWrapperEnd}`, "s"));
+        }), 20000);
+    }
+}
+else {
+    // This test prevents an error when runTestsWhichRequireAnyValidApiKey is false
+    // due to having a test suite with no tests.
+    test("no column transformer tests were run because there is no API key provided", () => {
+        expect(true).toBe(true);
+    });
+}
+function getNumberedListItemBlock(identifier) {
+    const content = identifier
+        ? `Numbered list item ${identifier}`
+        : `Numbered list item`;
+    return {
+        object: "block",
+        type: "numbered_list_item",
+        numbered_list_item: {
+            rich_text: [
+                {
+                    type: "text",
+                    text: { content: content },
+                    annotations: {
+                        code: false,
+                    },
+                    plain_text: content,
+                },
+            ],
+        },
+    };
+}
+function getTestParagraphBlock(identifier) {
+    const content = identifier ? `my paragraph ${identifier}` : `my paragraph`;
+    return {
+        object: "block",
+        type: "paragraph",
+        paragraph: {
+            rich_text: [
+                {
+                    type: "text",
+                    text: {
+                        content: content,
+                    },
+                    annotations: {
+                        code: false,
+                    },
+                    plain_text: content,
+                },
+            ],
+        },
+    };
+}

package/dist/plugins/internalLinks.spec.js

@@ -14,7 +14,6 @@ const pluginTestRun_1 = require("./pluginTestRun");
 const CalloutTransformer_1 = require("./CalloutTransformer");
 const externalLinks_1 = require("./externalLinks");
 const internalLinks_1 = require("./internalLinks");
-const NumberedListTransformer_1 = require("./NumberedListTransformer");
 test("urls that show up as raw text get left that way", () => __awaiter(void 0, void 0, void 0, function* () {
     const results = yield getMarkdown({
         type: "paragraph",
@@ -523,7 +522,6 @@ function getMarkdown(block, targetPage) {
         const config = {
             plugins: [
                 CalloutTransformer_1.standardCalloutTransformer,
-                NumberedListTransformer_1.standardNumberedListTransformer,
                 internalLinks_1.standardInternalLinkConversion,
                 externalLinks_1.standardExternalLinkConversion,
             ],

package/dist/plugins/pluginTestRun.d.ts

@@ -1,7 +1,7 @@
 import { NotionPage } from "../NotionPage";
 import { IDocuNotionConfig } from "../config/configuration";
 import { NotionBlock } from "../types";
-export declare function blocksToMarkdown(config: IDocuNotionConfig, blocks: NotionBlock[], pages?: NotionPage[]): Promise<string>;
+export declare function blocksToMarkdown(config: IDocuNotionConfig, blocks: NotionBlock[], pages?: NotionPage[], children?: NotionBlock[], validApiKey?: string): Promise<string>;
 export declare function makeSamplePageObject(options: {
     slug?: string;
     name?: string;

package/dist/plugins/pluginTestRun.js

@@ -16,9 +16,17 @@ const HierarchicalNamedLayoutStrategy_1 = require("../HierarchicalNamedLayoutStr
 const NotionPage_1 = require("../NotionPage");
 const transform_1 = require("../transform");
 const internalLinks_1 = require("./internalLinks");
-function blocksToMarkdown(config, blocks, pages) {
+const pull_1 = require("../pull");
+function blocksToMarkdown(config, blocks, pages, 
+// Notes on children:
+//   - These children will apply to each block in blocks. (could enhance but not needed yet)
+//   - If you are passing in children, it is probably because your parent block has has_children=true.
+//     In that case, notion-to-md will make an API call... you'll need to set any validApiKey.
+children, validApiKey) {
     return __awaiter(this, void 0, void 0, function* () {
-        const notionClient = new client_1.Client({ auth: "unused" });
+        const notionClient = new client_1.Client({
+            auth: validApiKey || "unused",
+        });
         const notionToMD = new notion_to_md_1.NotionToMarkdown({
             notionClient,
         });
@@ -28,12 +36,12 @@ function blocksToMarkdown(config, blocks, pages) {
         // }
         const docunotionContext = {
             notionToMarkdown: notionToMD,
-            // TODO when does this actually need to do get some children?
-            // We can add a children argument to this method, but for the tests
-            // I have so far, it's not needed.
             getBlockChildren: (id) => {
+                // We call numberChildrenIfNumberedList here because the real getBlockChildren does
+                if (children)
+                    (0, pull_1.numberChildrenIfNumberedList)(children);
                 return new Promise((resolve, reject) => {
-                    resolve([]);
+                    resolve(children !== null && children !== void 0 ? children : []);
                 });
             },
             convertNotionLinkToLocalDocusaurusLink: (url) => {

package/dist/pull.d.ts

@@ -1,4 +1,5 @@
 import { Client } from "@notionhq/client";
+import { ListBlockChildrenResponseResults } from "notion-to-md/build/types";
 export type DocuNotionOptions = {
     notionToken: string;
     rootPage: string;
@@ -11,3 +12,4 @@ export type DocuNotionOptions = {
 export declare function notionPull(options: DocuNotionOptions): Promise<void>;
 export declare function executeWithRateLimitAndRetries<T>(label: string, asyncFunction: () => Promise<T>): Promise<T>;
 export declare function initNotionClient(notionToken: string): Client;
+export declare function numberChildrenIfNumberedList(blocks: ListBlockChildrenResponseResults): void;

package/dist/pull.js

@@ -32,7 +32,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.initNotionClient = exports.executeWithRateLimitAndRetries = exports.notionPull = void 0;
+exports.numberChildrenIfNumberedList = exports.initNotionClient = exports.executeWithRateLimitAndRetries = exports.notionPull = void 0;
 const fs = __importStar(require("fs-extra"));
 const notion_to_md_1 = require("notion-to-md");
 const HierarchicalNamedLayoutStrategy_1 = require("./HierarchicalNamedLayoutStrategy");
@@ -265,7 +265,9 @@ function getBlockChildren(id) {
             (0, log_1.error)(`The Notion API returned some blocks that were not full blocks. docu-notion does not handle this yet. Please report it.`);
             (0, process_1.exit)(1);
         }
-        return (_b = overallResult === null || overallResult === void 0 ? void 0 : overallResult.results) !== null && _b !== void 0 ? _b : [];
+        const result = (_b = overallResult === null || overallResult === void 0 ? void 0 : overallResult.results) !== null && _b !== void 0 ? _b : [];
+        numberChildrenIfNumberedList(result);
+        return result;
     });
 }
 function initNotionClient(notionToken) {
@@ -288,3 +290,20 @@ function fromPageId(context, pageId, order, foundDirectlyInOutline) {
         });
     });
 }
+// This function is copied (and renamed from modifyNumberedListObject) from notion-to-md.
+// They always run it on the results of their getBlockChildren.
+// When we use our own getBlockChildren, we need to run it too.
+function numberChildrenIfNumberedList(blocks) {
+    let numberedListIndex = 0;
+    for (const block of blocks) {
+        if ("type" in block && block.type === "numbered_list_item") {
+            // add numbers
+            // @ts-ignore
+            block.numbered_list_item.number = ++numberedListIndex;
+        }
+        else {
+            numberedListIndex = 0;
+        }
+    }
+}
+exports.numberChildrenIfNumberedList = numberChildrenIfNumberedList;

package/dist/transform.js

@@ -128,7 +128,7 @@ function doTransformsOnMarkdown(context, config, input) {
 function doNotionToMarkdown(docunotionContext, blocks) {
     return __awaiter(this, void 0, void 0, function* () {
         const mdBlocks = yield docunotionContext.notionToMarkdown.blocksToMarkdown(blocks);
-        const markdown = docunotionContext.notionToMarkdown.toMarkdownString(mdBlocks);
+        const markdown = docunotionContext.notionToMarkdown.toMarkdownString(mdBlocks).parent || "";
         return markdown;
     });
 }

package/package.json

@@ -35,7 +35,7 @@
     "markdown-table": "^2.0.0",
     "node-fetch": "2.6.6",
     "notion-client": "^4",
-    "notion-to-md": "2.5.5",
+    "notion-to-md": "3.1.1",
     "path": "^0.12.7",
     "ts-node": "^10.2.1",
     "sanitize-filename": "^1.6.3"
@@ -90,5 +90,5 @@
   "volta": {
     "node": "18.16.0"
   },
-  "version": "0.14.0-alpha.2"
+  "version": "0.14.0-alpha.4"
 }

package/dist/plugins/NumberedListTransformer.d.ts

@@ -1,2 +0,0 @@
-import { IPlugin } from "./pluginTypes";
-export declare const standardNumberedListTransformer: IPlugin;

package/dist/plugins/NumberedListTransformer.js

@@ -1,55 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.standardNumberedListTransformer = void 0;
-// This is mostly what notion-to-markdown would normally do with a block of type
-// numbered_list_item. A patch is documented at the end.
-function numberedListTransformer(notionToMarkdown, block) {
-    var _a, _b, _c;
-    //console.log("got numbered list block " + JSON.stringify(block));
-    // In this case typescript is not able to index the types properly, hence ignoring the error
-    // @ts-ignore
-    const blockContent = 
-    // @ts-ignore
-    ((_a = block.numbered_list_item) === null || _a === void 0 ? void 0 : _a.text) || ((_b = block.numbered_list_item) === null || _b === void 0 ? void 0 : _b.rich_text) || [];
-    let parsedData = "";
-    blockContent.map((content) => {
-        const annotations = content.annotations;
-        let plain_text = content.plain_text;
-        plain_text = notionToMarkdown.annotatePlainText(plain_text, annotations);
-        if (content["href"]) {
-            plain_text = `[${plain_text}](${content["href"]})`;
-        }
-        parsedData += plain_text;
-    });
-    // There is code in notion-to-md which attempts to set an incrementing number
-    // on each of these. Somehow it fails; in my testing, block.numbered_list_item never
-    // has a field 'number'. But we don't actually need incrementing numbers;
-    // markdown will do the numbering if we just make something that looks like
-    // a member of a numbered list by starting with number followed by period and space.
-    // I'm keeping the original code in case notion-to-md gets fixed and there is actually
-    // some reason to use incrementing numbers (it would at least make the markdown more
-    // human-readable); but this at least works.
-    // A problem is that in notion, a numbered list may continue after some intermediate
-    // content. To achieve this in markdown, we'd need to indent the intermediate content
-    // by a tab. Not only is it difficult to do this, but there appears to be no way to
-    // know whether we should. The data we get from notion doesn't include the item number,
-    // and its parent is the page rather than a particular list. So there is no way I can
-    // see to distinguish a list continuation from a new list. The code here will leave
-    // it up to markdown to decide whether to start a new list; I believe it will do so
-    // if it sees any intervening lines that are not list items.
-    let num = (_c = block.numbered_list_item) === null || _c === void 0 ? void 0 : _c.number;
-    //console.log("got number " + num?.toString());
-    if (!num) {
-        num = 1;
-    }
-    return Promise.resolve(`${num}. ${parsedData.trim()}`);
-}
-exports.standardNumberedListTransformer = {
-    name: "standardNumberedListTransformer",
-    notionToMarkdownTransforms: [
-        {
-            type: "numbered_list_item",
-            getStringFromBlock: (context, block) => numberedListTransformer(context.notionToMarkdown, block),
-        },
-    ],
-};

package/dist/plugins/NumberedListTransformer.spec.js

@@ -1,86 +0,0 @@
-"use strict";
-var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
-    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
-    return new (P || (P = Promise))(function (resolve, reject) {
-        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
-        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
-        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
-        step((generator = generator.apply(thisArg, _arguments || [])).next());
-    });
-};
-Object.defineProperty(exports, "__esModule", { value: true });
-const pluginTestRun_1 = require("./pluginTestRun");
-const NumberedListTransformer_1 = require("./NumberedListTransformer");
-let block;
-beforeEach(() => {
-    block = {
-        has_children: false,
-        archived: false,
-        type: "callout",
-        callout: {
-            rich_text: [
-                {
-                    type: "text",
-                    text: { content: "This is information callout", link: null },
-                    annotations: {
-                        bold: false,
-                        italic: false,
-                        strikethrough: false,
-                        underline: false,
-                        code: false,
-                        color: "default",
-                    },
-                    plain_text: "This is the callout",
-                    href: null,
-                },
-            ],
-            icon: { type: "emoji", emoji: "ℹ️" },
-            color: "gray_background",
-        },
-    };
-});
-test("external link inside numbered list, italic preserved", () => __awaiter(void 0, void 0, void 0, function* () {
-    const config = { plugins: [NumberedListTransformer_1.standardNumberedListTransformer] };
-    const results = yield (0, pluginTestRun_1.blocksToMarkdown)(config, [
-        {
-            type: "numbered_list_item",
-            numbered_list_item: {
-                rich_text: [
-                    {
-                        type: "text",
-                        text: { content: "link ", link: null },
-                        annotations: {
-                            bold: false,
-                            italic: false,
-                            strikethrough: false,
-                            underline: false,
-                            code: false,
-                            color: "default",
-                        },
-                        plain_text: "link ",
-                        href: null,
-                    },
-                    {
-                        type: "text",
-                        text: {
-                            content: "github",
-                            link: { url: "https://github.com" },
-                        },
-                        annotations: {
-                            bold: false,
-                            italic: true,
-                            strikethrough: false,
-                            underline: false,
-                            code: false,
-                            color: "default",
-                        },
-                        plain_text: "github",
-                        href: "https://github.com",
-                    },
-                ],
-                color: "default",
-            },
-        },
-    ]);
-    expect(results.trim()).toBe(`1. link [_github_](https://github.com)`);
-}));