@sillsdev/docu-notion 0.14.0-alpha.1 → 0.14.0-alpha.10

package/README.md

@@ -10,6 +10,8 @@ Example Site: https://sillsdev.github.io/docu-notion-sample-site/
 
 First, prepare your markdown-based static file system like [Docusaurus](https://docusaurus.io/). For a shortcut with github actions, search, and deployment to github pages, you can just copy [this template](https://github.com/sillsdev/docu-notion-sample-site).
 
+If you do not use the above sample, you will need to manually add [notion-styles.css](src/css/notion-styles.css) to your site. This enables multi-column layouts and another other special styling that we need to make the output of docu-notion look right.
+
 ## 2. In Notion, duplicate the docu-notion template
 
 Go to [this template page](https://hattonjohn.notion.site/Documentation-Template-Docusaurus-0e998b32da3c47edad0f62a25b49818c). Duplicate it into your own workspace.
@@ -17,13 +19,13 @@ You can name it anything you like, e.g. "Documentation Root".
 
 ## 3. Create a Notion Integration
 
-In order for docu-notion to read your site via Notion's API, you need to create what Notion calls an "integration". Follow [these instructions](https://developers.notion.com/docs/getting-started) to make an integration and get your token. Limit your integration to "READ" access.
+In order for docu-notion to read your site via Notion's API, you need to create what Notion calls an "integration". Follow [these instructions](https://developers.notion.com/docs/getting-started) to make an integration and get your token. Remember to limit your integration to "READ" access.
 
-## 4. "Invite" your Notion Integration to read you page
+## 4. Connect your Integration
 
-In Notion, click "Share" on the root of your documentation and "invite" your integration to it.
+Go to the page that will be the root of your site. This page should have, as direct children, your "Outline" (required) and "Database" (optional) pages. Follow [these instructions](https://developers.notion.com/docs/create-a-notion-integration#give-your-integration-page-permissions).
 
-![image](https://user-images.githubusercontent.com/8448/168930238-1dcf46df-a690-4839-bf4c-c63157f104d8.png)
+<img width="318" alt="image" src="https://github.com/sillsdev/docu-notion/assets/8448/810c6dca-f9ab-4370-93b4-dc1479332af7">
 
 ## 5. Add your pages under your Outline page.
 
@@ -35,7 +37,7 @@ First, determine the id of your root page by clicking "Share" and looking at the
 https://www.notion.so/hattonjohn/My-Docs-0456aa5842946bdbea3a4f37c97a0e5
 means that the id is "0456aa5842946PRETEND4f37c97a0e5".
 
-Determine where you want the markdown files and images to land. The following works well for Docusaurus instances:
+Try it out:
 
 ```
 npx @sillsdev/docu-notion -n secret_PRETEND123456789PRETEND123456789PRETEND6789 -r 0456aa5842946PRETEND4f37c97a0e5"

package/dist/MakeImagePersistencePlan.d.ts

@@ -1,2 +1,3 @@
 import { ImageSet } from "./images";
 export declare function makeImagePersistencePlan(imageSet: ImageSet, imageOutputRootPath: string, imagePrefix: string): void;
+export declare function hashOfString(s: string): number;

package/dist/MakeImagePersistencePlan.js

@@ -23,21 +23,21 @@ var __importStar = (this && this.__importStar) || function (mod) {
     return result;
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.makeImagePersistencePlan = void 0;
+exports.hashOfString = exports.makeImagePersistencePlan = void 0;
 const Path = __importStar(require("path"));
 const log_1 = require("./log");
 const process_1 = require("process");
 function makeImagePersistencePlan(imageSet, imageOutputRootPath, imagePrefix) {
-    var _a;
+    var _a, _b;
     if ((_a = imageSet.fileType) === null || _a === void 0 ? void 0 : _a.ext) {
         // Since most images come from pasting screenshots, there isn't normally a filename. That's fine, we just make a hash of the url
         // Images that are stored by notion come to us with a complex url that changes over time, so we pick out the UUID that doesn't change. Example:
         //    https://s3.us-west-2.amazonaws.com/secure.notion-static.com/d1058f46-4d2f-4292-8388-4ad393383439/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20220516%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20220516T233630Z&X-Amz-Expires=3600&X-Amz-Signature=f215704094fcc884d37073b0b108cf6d1c9da9b7d57a898da38bc30c30b4c4b5&X-Amz-SignedHeaders=host&x-id=GetObject
-        let thingToHash = imageSet.primaryUrl;
-        const m = /.*secure\.notion-static\.com\/(.*)\//gm.exec(imageSet.primaryUrl);
-        if (m && m.length > 1) {
-            thingToHash = m[1];
-        }
+        // But around Sept 2023, they changed the url to be something like:
+        //    https://prod-files-secure.s3.us-west-2.amazonaws.com/d9a2b712-cf69-4bd6-9d65-87a4ceeacca2/d1bcdc8c-b065-4e40-9a11-392aabeb220e/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20230915%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20230915T161258Z&X-Amz-Expires=3600&X-Amz-Signature=28fca48e65fba86d539c3c4b7676fce1fa0857aa194f7b33dd4a468ecca6ab24&X-Amz-SignedHeaders=host&x-id=GetObject
+        // The thing we want is the last UUID before the ?
+        const urlBeforeQuery = imageSet.primaryUrl.split("?")[0];
+        const thingToHash = (_b = findLastUuid(urlBeforeQuery)) !== null && _b !== void 0 ? _b : urlBeforeQuery;
         const hash = hashOfString(thingToHash);
         imageSet.outputFileName = `${hash}.${imageSet.fileType.ext}`;
         imageSet.primaryFileOutputPath = Path.posix.join((imageOutputRootPath === null || imageOutputRootPath === void 0 ? void 0 : imageOutputRootPath.length) > 0
@@ -58,9 +58,18 @@ function makeImagePersistencePlan(imageSet, imageOutputRootPath, imagePrefix) {
     }
 }
 exports.makeImagePersistencePlan = makeImagePersistencePlan;
+function findLastUuid(url) {
+    // Regex for a UUID surrounded by slashes
+    const uuidPattern = /(?<=\/)[0-9a-f]{8}-[0-9a-f]{4}-[0-5][0-9a-f]{3}-[089ab][0-9a-f]{3}-[0-9a-f]{12}(?=\/)/gi;
+    // Find all UUIDs
+    const uuids = url.match(uuidPattern);
+    // Return the last UUID if any exist, else return null
+    return uuids ? uuids[uuids.length - 1].trim() : null;
+}
 function hashOfString(s) {
     let hash = 0;
     for (let i = 0; i < s.length; ++i)
         hash = Math.imul(31, hash) + s.charCodeAt(i);
     return Math.abs(hash);
 }
+exports.hashOfString = hashOfString;

package/dist/config/default.docunotion.config.js

@@ -8,7 +8,6 @@ const ColumnListTransformer_1 = require("../plugins/ColumnListTransformer");
 const ColumnTransformer_1 = require("../plugins/ColumnTransformer");
 const EscapeHtmlBlockModifier_1 = require("../plugins/EscapeHtmlBlockModifier");
 const HeadingTransformer_1 = require("../plugins/HeadingTransformer");
-const NumberedListTransformer_1 = require("../plugins/NumberedListTransformer");
 const TableTransformer_1 = require("../plugins/TableTransformer");
 const VideoTransformer_1 = require("../plugins/VideoTransformer");
 const externalLinks_1 = require("../plugins/externalLinks");
@@ -24,7 +23,6 @@ const defaultConfig = {
         images_1.standardImageTransformer,
         CalloutTransformer_1.standardCalloutTransformer,
         TableTransformer_1.standardTableTransformer,
-        NumberedListTransformer_1.standardNumberedListTransformer,
         VideoTransformer_1.standardVideoTransformer,
         // Link modifiers, which are special because they can read metadata from all the pages in order to figure out the correct url
         internalLinks_1.standardInternalLinkConversion,

package/dist/{notion-styles.css → docu-notion-styles.css}

@@ -1,58 +1,60 @@
-/* Note, I haven't figure out how a Docusaurus app can actually include this, yet.
-  So currently this has to be duplicated by the client.
-*/
-
-/* Copied from
-    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L934
-    and
-    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L1063
-*/
-.notion-column {
-  display: flex;
-  flex-direction: column;
-  padding-top: 12px;
-  padding-bottom: 12px;
-}
-
-.notion-column > *:first-child {
-  margin-top: 0;
-  margin-left: 0;
-  margin-right: 0;
-}
-
-.notion-column > *:last-child {
-  margin-left: 0;
-  margin-right: 0;
-  margin-bottom: 0;
-}
-
-.notion-row {
-  display: flex;
-  overflow: hidden;
-  width: 100%;
-  max-width: 100%;
-}
-
-@media (max-width: 640px) {
-  .notion-row {
-    flex-direction: column;
-  }
-
-  .notion-row .notion-column {
-    width: 100% !important;
-  }
-
-  .notion-row .notion-spacer {
-    display: none;
-  }
-}
-
-.notion-spacer {
-  /* This matches the value in ColumnTransformer.ts */
-  width: calc(min(32px, 4vw));
-}
-
-.notion-spacer:last-child {
-  display: none;
-}
-/* End copied from NotionX */
+/* This should be added to the docusaurus.config.js in order to show some notion things correctly.
+See the option: --css-output-directory 
+See the docusaurus docs: https://docusaurus.io/docs/styling-layout
+See the use in the docu-notion-sample-site: https://github.com/sillsdev/docu-notion-sample-site/blob/main/docusaurus.config.js
+*/
+
+/* Copied from
+    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L934
+    and
+    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L1063
+*/
+.notion-column {
+  display: flex;
+  flex-direction: column;
+  padding-top: 12px;
+  padding-bottom: 12px;
+}
+
+.notion-column > *:first-child {
+  margin-top: 0;
+  margin-left: 0;
+  margin-right: 0;
+}
+
+.notion-column > *:last-child {
+  margin-left: 0;
+  margin-right: 0;
+  margin-bottom: 0;
+}
+
+.notion-row {
+  display: flex;
+  overflow: hidden;
+  width: 100%;
+  max-width: 100%;
+}
+
+@media (max-width: 640px) {
+  .notion-row {
+    flex-direction: column;
+  }
+
+  .notion-row .notion-column {
+    width: 100% !important;
+  }
+
+  .notion-row .notion-spacer {
+    display: none;
+  }
+}
+
+.notion-spacer {
+  /* This matches the value in ColumnTransformer.ts */
+  width: calc(min(32px, 4vw));
+}
+
+.notion-spacer:last-child {
+  display: none;
+}
+/* End copied from NotionX */

package/dist/latex.spec.js

@@ -0,0 +1,97 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const notion_to_md_1 = require("notion-to-md");
+const HierarchicalNamedLayoutStrategy_1 = require("./HierarchicalNamedLayoutStrategy");
+const transform_1 = require("./transform");
+const internalLinks_1 = require("./plugins/internalLinks");
+const pull_1 = require("./pull");
+const default_docunotion_config_1 = __importDefault(require("./config/default.docunotion.config"));
+test("Latex Rendering", () => __awaiter(void 0, void 0, void 0, function* () {
+    const pages = new Array();
+    const counts = {
+        output_normally: 0,
+        skipped_because_empty: 0,
+        skipped_because_status: 0,
+        skipped_because_level_cannot_have_content: 0,
+    };
+    const notionClient = (0, pull_1.initNotionClient)("");
+    const layoutStrategy = new HierarchicalNamedLayoutStrategy_1.HierarchicalNamedLayoutStrategy();
+    const config = default_docunotion_config_1.default;
+    const context = {
+        getBlockChildren: (id) => {
+            return new Promise(resolve => resolve(new Array()));
+        },
+        directoryContainingMarkdown: "",
+        relativeFilePathToFolderContainingPage: "",
+        layoutStrategy: layoutStrategy,
+        notionToMarkdown: new notion_to_md_1.NotionToMarkdown({ notionClient }),
+        options: {
+            notionToken: "",
+            rootPage: "",
+            locales: [""],
+            markdownOutputPath: "",
+            imgOutputPath: "",
+            imgPrefixInMarkdown: "",
+            statusTag: "",
+        },
+        pages: pages,
+        counts: counts,
+        imports: [],
+        convertNotionLinkToLocalDocusaurusLink: (url) => (0, internalLinks_1.convertInternalUrl)(context, url),
+    };
+    const blocks = [
+        {
+            object: "block",
+            id: "169e1c47-6706-4518-adca-73086b2738ac",
+            parent: {
+                type: "page_id",
+                page_id: "2acc11a4-82a9-4759-b429-fa011c164888",
+            },
+            created_time: "2023-08-18T15:51:00.000Z",
+            last_edited_time: "2023-08-18T15:51:00.000Z",
+            created_by: {
+                object: "user",
+                id: "af5c163e-82b1-49d1-9f1c-539907bb9fb9",
+            },
+            last_edited_by: {
+                object: "user",
+                id: "af5c163e-82b1-49d1-9f1c-539907bb9fb9",
+            },
+            has_children: false,
+            archived: false,
+            type: "paragraph",
+            paragraph: {
+                rich_text: [
+                    {
+                        type: "equation",
+                        equation: { expression: "x" },
+                        annotations: {
+                            bold: false,
+                            italic: false,
+                            strikethrough: false,
+                            underline: false,
+                            code: false,
+                            color: "default",
+                        },
+                        plain_text: "x",
+                        href: null,
+                    },
+                ],
+                color: "default",
+            },
+        },
+    ];
+    expect(yield (0, transform_1.getMarkdownFromNotionBlocks)(context, config, blocks)).toContain("$x$");
+}));

package/dist/makeImagePersistencePlan.spec.js

@@ -9,9 +9,10 @@ test("primary file with explicit file output path and prefix", () => {
         fileType: { ext: "png", mime: "image/png" },
     };
     (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "./static/notion_imgs", "/notion_imgs");
-    expect(imageSet.outputFileName).toBe("463556435.png");
-    expect(imageSet.primaryFileOutputPath).toBe("static/notion_imgs/463556435.png");
-    expect(imageSet.filePathToUseInMarkdown).toBe("/notion_imgs/463556435.png");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("https://s3.us-west-2.amazonaws.com/primaryImage");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
+    expect(imageSet.primaryFileOutputPath).toBe(`static/notion_imgs/${expectedHash}.png`);
+    expect(imageSet.filePathToUseInMarkdown).toBe(`/notion_imgs/${expectedHash}.png`);
 });
 test("primary file with defaults for image output path and prefix", () => {
     const imageSet = {
@@ -21,10 +22,31 @@ test("primary file with defaults for image output path and prefix", () => {
         fileType: { ext: "png", mime: "image/png" },
     };
     (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "", "");
-    expect(imageSet.outputFileName).toBe("463556435.png");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("https://s3.us-west-2.amazonaws.com/primaryImage");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
     // the default behavior is to put the image next to the markdown file
-    expect(imageSet.primaryFileOutputPath).toBe("/pathToParentSomewhere/463556435.png");
-    expect(imageSet.filePathToUseInMarkdown).toBe("./463556435.png");
+    expect(imageSet.primaryFileOutputPath).toBe(`/pathToParentSomewhere/${expectedHash}.png`);
+    expect(imageSet.filePathToUseInMarkdown).toBe(`./${expectedHash}.png`);
+});
+test("properly extract UUID from old-style notion image url", () => {
+    const imageSet = {
+        primaryUrl: "https://s3.us-west-2.amazonaws.com/secure.notion-static.com/e1058f46-4d2f-4292-8388-4ad393383439/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20220516%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20220516T233630Z&X-Amz-Expires=3600&X-Amz-Signature=f215704094fcc884d37073b0b108cf6d1c9da9b7d57a898da38bc30c30b4c4b5&X-Amz-SignedHeaders=host&x-id=GetObject",
+        localizedUrls: [],
+        fileType: { ext: "png", mime: "image/png" },
+    };
+    (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "./static/notion_imgs", "/notion_imgs");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("e1058f46-4d2f-4292-8388-4ad393383439");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
+});
+test("properly extract UUID from new-style (Sept 2023) notion image url", () => {
+    const imageSet = {
+        primaryUrl: "https://prod-files-secure.s3.us-west-2.amazonaws.com/d9a2b712-cf69-4bd6-9d65-87a4ceeacca2/d1bcdc8c-b065-4e40-9a11-392aabeb220e/Untitled.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20230915%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20230915T161258Z&X-Amz-Expires=3600&X-Amz-Signature=28fca48e65fba86d539c3c4b7676fce1fa0857aa194f7b33dd4a468ecca6ab24&X-Amz-SignedHeaders=host&x-id=GetObject",
+        localizedUrls: [],
+        fileType: { ext: "png", mime: "image/png" },
+    };
+    (0, MakeImagePersistencePlan_1.makeImagePersistencePlan)(imageSet, "./static/notion_imgs", "/notion_imgs");
+    const expectedHash = (0, MakeImagePersistencePlan_1.hashOfString)("d1bcdc8c-b065-4e40-9a11-392aabeb220e");
+    expect(imageSet.outputFileName).toBe(`${expectedHash}.png`);
 });
 // In order to make image fallback work with other languages, we have to have
 // a file for each image, in each Docusaurus language directory. This is true

package/dist/plugins/ColumnTransformer.js

@@ -28,16 +28,14 @@ function notionColumnToMarkdown(notionToMarkdown, getBlockChildren, block) {
         const { id, has_children } = block; // "any" because the notion api type system is complex with a union that don't know how to help TS to cope with
         if (!has_children)
             return "";
-        const children = yield getBlockChildren(id);
-        const childrenPromises = children.map((column) => __awaiter(this, void 0, void 0, function* () { return yield notionToMarkdown.blockToMarkdown(column); }));
-        const childrenStrings = yield Promise.all(childrenPromises);
+        const columnChildren = yield getBlockChildren(id);
+        const childrenMdBlocksArray = yield Promise.all(columnChildren.map((child) => __awaiter(this, void 0, void 0, function* () { return yield notionToMarkdown.blocksToMarkdown([child]); })));
+        const childrenMarkdown = childrenMdBlocksArray.map(mdBlockArray => notionToMarkdown.toMarkdownString(mdBlockArray).parent);
         const columnWidth = yield getColumnWidth(block);
-        // note: it would look better in the markup with \n, but that
-        // causes notion-to-md to give us ":::A" instead of \n for some reason.
-        return (`<div class='notion-column' style={{width: '${columnWidth}'}}>\n\n${childrenStrings.join("\n\n")}\n\n</div>` +
+        return (`<div class='notion-column' style={{width: '${columnWidth}'}}>\n\n${childrenMarkdown.join("\n")}\n</div>` +
             // Spacer between columns. CSS takes care of hiding this for the last column
             // and when the screen is too narrow for multiple columns.
-            `<div className='notion-spacer' />`);
+            `<div className='notion-spacer'></div>`);
     });
 }
 // The official API doesn't give us access to the format information, including column_ratio.

package/dist/plugins/ColumnTransformer.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/plugins/ColumnTransformer.spec.js

@@ -0,0 +1,118 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const pluginTestRun_1 = require("./pluginTestRun");
+const ColumnTransformer_1 = require("./ColumnTransformer");
+// Even though we can set up most tests with our own children
+// so that we aren't relying on real data from Notion,
+// we can't prevent the notion-to-md library from making an API call
+// every time it processes a block with has_children:true.
+// So for these tests with children, we need any valid API key.
+const runTestsWhichRequireAnyValidApiKey = !!process.env.DOCU_NOTION_INTEGRATION_TOKEN;
+// To test grandchildren, we can't get around notion-to-md making an API call
+// to get real children. So we need a specific notion record.
+// For that reason, we don't try to run these tests unless the user changes this flag.
+// But it is an important test; grandchildren in columns were broken.
+// See https://github.com/sillsdev/docu-notion/issues/70.
+const runManualTestsWhichRequireSpecificNotionRecords = false;
+const columnBlock = {
+    object: "block",
+    id: "e6d2d7b7-b1ed-464a-86d2-bb5f6be78a03",
+    has_children: true,
+    type: "column",
+    column: {},
+};
+function getResults(children) {
+    return __awaiter(this, void 0, void 0, function* () {
+        return yield (0, pluginTestRun_1.blocksToMarkdown)({ plugins: [ColumnTransformer_1.standardColumnTransformer] }, [columnBlock], undefined, children, process.env.DOCU_NOTION_INTEGRATION_TOKEN);
+    });
+}
+const columnWrapperStart = "<div class='notion-column' style=\\{\\{width: '.*?'\\}\\}>\\n\\n";
+const columnWrapperEnd = "\\n\\n<\\/div><div className='notion-spacer'><\\/div>";
+if (runTestsWhichRequireAnyValidApiKey) {
+    columnBlock.has_children = true;
+    test("requires API key - column with paragraph", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([getTestParagraphBlock()]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?my paragraph\\s*?${columnWrapperEnd}`));
+    }), 20000);
+    test("requires API key - column with two paragraphs", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([
+            getTestParagraphBlock(1),
+            getTestParagraphBlock(2),
+        ]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?my paragraph 1\\s+?my paragraph 2\\s*?${columnWrapperEnd}`));
+    }), 20000);
+    test("requires API key - column with numbered list", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([
+            getNumberedListItemBlock(1),
+            getNumberedListItemBlock(2),
+        ]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?1\\. Numbered list item 1\\s+?2\\. Numbered list item 2\\s*?${columnWrapperEnd}`, "s"));
+    }), 20000);
+    if (runManualTestsWhichRequireSpecificNotionRecords) {
+        test("manual test - requires specific notion record and API key - column with numbered list with sublist", () => __awaiter(void 0, void 0, void 0, function* () {
+            const realNumberedListBlock = getNumberedListItemBlock(1);
+            realNumberedListBlock.id = "ca08d14b-9b70-4f6f-9d17-9fd74b57afeb";
+            realNumberedListBlock.has_children = true;
+            const results = yield getResults([realNumberedListBlock]);
+            expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?1\\. Numbered list item 1\\s+?- unordered sub-bullet\\s*?${columnWrapperEnd}`, "s"));
+        }), 20000);
+    }
+}
+else {
+    // This test prevents an error when runTestsWhichRequireAnyValidApiKey is false
+    // due to having a test suite with no tests.
+    test("no column transformer tests were run because there is no API key provided", () => {
+        expect(true).toBe(true);
+    });
+}
+function getNumberedListItemBlock(identifier) {
+    const content = identifier
+        ? `Numbered list item ${identifier}`
+        : `Numbered list item`;
+    return {
+        object: "block",
+        type: "numbered_list_item",
+        numbered_list_item: {
+            rich_text: [
+                {
+                    type: "text",
+                    text: { content: content },
+                    annotations: {
+                        code: false,
+                    },
+                    plain_text: content,
+                },
+            ],
+        },
+    };
+}
+function getTestParagraphBlock(identifier) {
+    const content = identifier ? `my paragraph ${identifier}` : `my paragraph`;
+    return {
+        object: "block",
+        type: "paragraph",
+        paragraph: {
+            rich_text: [
+                {
+                    type: "text",
+                    text: {
+                        content: content,
+                    },
+                    annotations: {
+                        code: false,
+                    },
+                    plain_text: content,
+                },
+            ],
+        },
+    };
+}

package/dist/plugins/embedTweaks.js

@@ -7,7 +7,7 @@ exports.gifEmbed = {
         {
             // I once saw a gif coming from Notion that wasn't a full
             // url, which wouldn't work, hence the "http" requirement
-            regex: /\[.*\]\((http.*(\.(gif|GIF)))\)/,
+            regex: /\[.*?\]\((http.*?(\.(gif|GIF)))\)/,
             replacementPattern: `![]($1)`,
         },
     ],
@@ -16,7 +16,7 @@ exports.imgurGifEmbed = {
     name: "imgur",
     regexMarkdownModifications: [
         {
-            regex: /\[.*\]\((.*imgur\.com\/.*)\)/,
+            regex: /\[.*?\]\((.*?imgur\.com\/.*?)\)/,
             // imgur links to gifs need a .gif at the end, but the url they give you doesn't have one.
             replacementPattern: `![]($1.gif)`,
         },

package/dist/plugins/internalLinks.spec.js

@@ -14,7 +14,6 @@ const pluginTestRun_1 = require("./pluginTestRun");
 const CalloutTransformer_1 = require("./CalloutTransformer");
 const externalLinks_1 = require("./externalLinks");
 const internalLinks_1 = require("./internalLinks");
-const NumberedListTransformer_1 = require("./NumberedListTransformer");
 test("urls that show up as raw text get left that way", () => __awaiter(void 0, void 0, void 0, function* () {
     const results = yield getMarkdown({
         type: "paragraph",
@@ -523,7 +522,6 @@ function getMarkdown(block, targetPage) {
         const config = {
             plugins: [
                 CalloutTransformer_1.standardCalloutTransformer,
-                NumberedListTransformer_1.standardNumberedListTransformer,
                 internalLinks_1.standardInternalLinkConversion,
                 externalLinks_1.standardExternalLinkConversion,
             ],

package/dist/plugins/pluginTestRun.d.ts

@@ -1,7 +1,7 @@
 import { NotionPage } from "../NotionPage";
 import { IDocuNotionConfig } from "../config/configuration";
 import { NotionBlock } from "../types";
-export declare function blocksToMarkdown(config: IDocuNotionConfig, blocks: NotionBlock[], pages?: NotionPage[]): Promise<string>;
+export declare function blocksToMarkdown(config: IDocuNotionConfig, blocks: NotionBlock[], pages?: NotionPage[], children?: NotionBlock[], validApiKey?: string): Promise<string>;
 export declare function makeSamplePageObject(options: {
     slug?: string;
     name?: string;

package/dist/plugins/pluginTestRun.js

@@ -16,9 +16,17 @@ const HierarchicalNamedLayoutStrategy_1 = require("../HierarchicalNamedLayoutStr
 const NotionPage_1 = require("../NotionPage");
 const transform_1 = require("../transform");
 const internalLinks_1 = require("./internalLinks");
-function blocksToMarkdown(config, blocks, pages) {
+const pull_1 = require("../pull");
+function blocksToMarkdown(config, blocks, pages, 
+// Notes on children:
+//   - These children will apply to each block in blocks. (could enhance but not needed yet)
+//   - If you are passing in children, it is probably because your parent block has has_children=true.
+//     In that case, notion-to-md will make an API call... you'll need to set any validApiKey.
+children, validApiKey) {
     return __awaiter(this, void 0, void 0, function* () {
-        const notionClient = new client_1.Client({ auth: "unused" });
+        const notionClient = new client_1.Client({
+            auth: validApiKey || "unused",
+        });
         const notionToMD = new notion_to_md_1.NotionToMarkdown({
             notionClient,
         });
@@ -28,12 +36,12 @@ function blocksToMarkdown(config, blocks, pages) {
         // }
         const docunotionContext = {
             notionToMarkdown: notionToMD,
-            // TODO when does this actually need to do get some children?
-            // We can add a children argument to this method, but for the tests
-            // I have so far, it's not needed.
             getBlockChildren: (id) => {
+                // We call numberChildrenIfNumberedList here because the real getBlockChildren does
+                if (children)
+                    (0, pull_1.numberChildrenIfNumberedList)(children);
                 return new Promise((resolve, reject) => {
-                    resolve([]);
+                    resolve(children !== null && children !== void 0 ? children : []);
                 });
             },
             convertNotionLinkToLocalDocusaurusLink: (url) => {

package/dist/pull.d.ts

@@ -1,4 +1,5 @@
 import { Client } from "@notionhq/client";
+import { ListBlockChildrenResponseResults } from "notion-to-md/build/types";
 export type DocuNotionOptions = {
     notionToken: string;
     rootPage: string;
@@ -11,3 +12,4 @@ export type DocuNotionOptions = {
 export declare function notionPull(options: DocuNotionOptions): Promise<void>;
 export declare function executeWithRateLimitAndRetries<T>(label: string, asyncFunction: () => Promise<T>): Promise<T>;
 export declare function initNotionClient(notionToken: string): Client;
+export declare function numberChildrenIfNumberedList(blocks: ListBlockChildrenResponseResults): void;

package/dist/pull.js

@@ -32,7 +32,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.initNotionClient = exports.executeWithRateLimitAndRetries = exports.notionPull = void 0;
+exports.numberChildrenIfNumberedList = exports.initNotionClient = exports.executeWithRateLimitAndRetries = exports.notionPull = void 0;
 const fs = __importStar(require("fs-extra"));
 const notion_to_md_1 = require("notion-to-md");
 const HierarchicalNamedLayoutStrategy_1 = require("./HierarchicalNamedLayoutStrategy");
@@ -62,7 +62,7 @@ function notionPull(options) {
         const optionsForLogging = Object.assign({}, options);
         // Just show the first few letters of the notion token, which start with "secret" anyhow.
         optionsForLogging.notionToken =
-            optionsForLogging.notionToken.substring(0, 3) + "...";
+            optionsForLogging.notionToken.substring(0, 10) + "...";
         const config = yield (0, configuration_1.loadConfigAsync)();
         (0, log_1.verbose)(`Options:${JSON.stringify(optionsForLogging, null, 2)}`);
         yield (0, images_1.initImageHandling)(options.imgPrefixInMarkdown || options.imgOutputPath || "", options.imgOutputPath || "", options.locales);
@@ -73,6 +73,16 @@ function notionPull(options) {
         layoutStrategy.setRootDirectoryForMarkdown(options.markdownOutputPath.replace(/\/+$/, "") // trim any trailing slash
         );
         (0, log_1.info)("Connecting to Notion...");
+        // Do a  quick test to see if we can connect to the root so that we can give a better error than just a generic "could not find page" one.
+        try {
+            yield executeWithRateLimitAndRetries("retrieving root page", () => __awaiter(this, void 0, void 0, function* () {
+                yield notionClient.pages.retrieve({ page_id: options.rootPage });
+            }));
+        }
+        catch (e) {
+            (0, log_1.error)(`docu-notion could not retrieve the root page from Notion. \r\na) Check that the root page id really is "${options.rootPage}".\r\nb) Check that your Notion API token (the "Integration Secret") is correct. It starts with "${optionsForLogging.notionToken}".\r\nc) Check that your root page includes your "integration" in its "connections".\r\nThis internal error message may help:\r\n    ${e.message}`);
+            (0, process_1.exit)(1);
+        }
         (0, log_1.group)("Stage 1: walk children of the page named 'Outline', looking for pages...");
         yield getPagesRecursively(options, "", options.rootPage, 0, true);
         (0, log_1.logDebug)("getPagesRecursively", JSON.stringify(pages, null, 2));
@@ -213,9 +223,11 @@ function executeWithRateLimitAndRetries(label, asyncFunction) {
                     e.message.includes("timeout") ||
                     e.message.includes("Timeout") ||
                     e.message.includes("limit") ||
-                    e.message.includes("Limit")) {
+                    e.message.includes("Limit") ||
+                    (e === null || e === void 0 ? void 0 : e.code) === "notionhq_client_response_error" ||
+                    (e === null || e === void 0 ? void 0 : e.code) === "service_unavailable") {
                     const secondsToWait = i + 1;
-                    (0, log_1.info)(`While doing "${label}", got error "${e.message}". Will retry after  ${secondsToWait}s...`);
+                    (0, log_1.warning)(`While doing "${label}", got error "${e.message}". Will retry after ${secondsToWait}s...`);
                     yield new Promise(resolve => setTimeout(resolve, 1000 * secondsToWait));
                 }
                 else {
@@ -265,7 +277,9 @@ function getBlockChildren(id) {
             (0, log_1.error)(`The Notion API returned some blocks that were not full blocks. docu-notion does not handle this yet. Please report it.`);
             (0, process_1.exit)(1);
         }
-        return (_b = overallResult === null || overallResult === void 0 ? void 0 : overallResult.results) !== null && _b !== void 0 ? _b : [];
+        const result = (_b = overallResult === null || overallResult === void 0 ? void 0 : overallResult.results) !== null && _b !== void 0 ? _b : [];
+        numberChildrenIfNumberedList(result);
+        return result;
     });
 }
 function initNotionClient(notionToken) {
@@ -288,3 +302,20 @@ function fromPageId(context, pageId, order, foundDirectlyInOutline) {
         });
     });
 }
+// This function is copied (and renamed from modifyNumberedListObject) from notion-to-md.
+// They always run it on the results of their getBlockChildren.
+// When we use our own getBlockChildren, we need to run it too.
+function numberChildrenIfNumberedList(blocks) {
+    let numberedListIndex = 0;
+    for (const block of blocks) {
+        if ("type" in block && block.type === "numbered_list_item") {
+            // add numbers
+            // @ts-ignore
+            block.numbered_list_item.number = ++numberedListIndex;
+        }
+        else {
+            numberedListIndex = 0;
+        }
+    }
+}
+exports.numberChildrenIfNumberedList = numberChildrenIfNumberedList;

package/dist/run.d.ts

@@ -1 +1 @@
-export declare function run(): void;
+export declare function run(): Promise<void>;

package/dist/run.js

@@ -1,33 +1,86 @@
 "use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.run = void 0;
+const fs = __importStar(require("fs-extra"));
 const commander_1 = require("commander");
 const log_1 = require("./log");
 const pull_1 = require("./pull");
+const path_1 = __importDefault(require("path"));
 function run() {
-    const pkg = require("../package.json");
-    // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
-    console.log(`docu-notion version ${pkg.version}`);
-    commander_1.program.name("docu-notion").description("");
-    commander_1.program.usage("-n <token> -r <root> [options]");
-    commander_1.program
-        .requiredOption("-n, --notion-token <string>", "notion api token, which looks like secret_3bc1b50XFYb15123RHF243x43450XFY33250XFYa343")
-        .requiredOption("-r, --root-page <string>", "The 31 character ID of the page which is the root of your docs page in notion. The code will look like 9120ec9960244ead80fa2ef4bc1bba25. This page must have a child page named 'Outline'")
-        .option("-m, --markdown-output-path  <string>", "Root of the hierarchy for md files. WARNING: node-pull-mdx will delete files from this directory. Note also that if it finds localized images, it will create an i18n/ directory as a sibling.", "./docs")
-        .option("-t, --status-tag  <string>", "Database pages without a Notion page property 'status' matching this will be ignored. Use '*' to ignore status altogether.", "Publish")
-        .option("--locales  <codes>", "Comma-separated list of iso 639-2 codes, the same list as in docusaurus.config.js, minus the primary (i.e. 'en'). This is needed for image localization.", parseLocales, [])
-        .addOption(new commander_1.Option("-l, --log-level <level>", "Log level").choices([
-        "info",
-        "verbose",
-        "debug",
-    ]))
-        .option("-i, --img-output-path  <string>", "Path to directory where images will be stored. If this is not included, images will be placed in the same directory as the document that uses them, which then allows for localization of screenshots.")
-        .option("-p, --img-prefix-in-markdown <string>", "When referencing an image from markdown, prefix with this path instead of the full img-output-path. Should be used only in conjunction with --img-output-path.");
-    commander_1.program.showHelpAfterError();
-    commander_1.program.parse();
-    (0, log_1.setLogLevel)(commander_1.program.opts().logLevel);
-    console.log(JSON.stringify(commander_1.program.opts));
-    (0, pull_1.notionPull)(commander_1.program.opts()).then(() => console.log("docu-notion Finished."));
+    return __awaiter(this, void 0, void 0, function* () {
+        const pkg = require("../package.json");
+        // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
+        console.log(`docu-notion version ${pkg.version}`);
+        commander_1.program.name("docu-notion").description("");
+        commander_1.program.usage("-n <token> -r <root> [options]");
+        commander_1.program
+            .requiredOption("-n, --notion-token <string>", "notion api token, which looks like secret_3bc1b50XFYb15123RHF243x43450XFY33250XFYa343")
+            .requiredOption("-r, --root-page <string>", "The 31 character ID of the page which is the root of your docs page in notion. The code will look like 9120ec9960244ead80fa2ef4bc1bba25. This page must have a child page named 'Outline'")
+            .option("-m, --markdown-output-path  <string>", "Root of the hierarchy for md files. WARNING: docu-notion will delete files from this directory. Note also that if it finds localized images, it will create an i18n/ directory as a sibling.", "./docs")
+            .option("--css-output-directory  <string>", "docu-notion has a docu-notion-styles.css file that you will need to use to get things like notion columns to look right. This option specifies where that file should be copied to.", "./css")
+            .option("-t, --status-tag  <string>", "Database pages without a Notion page property 'status' matching this will be ignored. Use '*' to ignore status altogether.", "Publish")
+            .option("--locales  <codes>", "Comma-separated list of iso 639-2 codes, the same list as in docusaurus.config.js, minus the primary (i.e. 'en'). This is needed for image localization.", parseLocales, [])
+            .addOption(new commander_1.Option("-l, --log-level <level>", "Log level").choices([
+            "info",
+            "verbose",
+            "debug",
+        ]))
+            .option("-i, --img-output-path  <string>", "Path to directory where images will be stored. If this is not included, images will be placed in the same directory as the document that uses them, which then allows for localization of screenshots.")
+            .option("-p, --img-prefix-in-markdown <string>", "When referencing an image from markdown, prefix with this path instead of the full img-output-path. Should be used only in conjunction with --img-output-path.");
+        commander_1.program.showHelpAfterError();
+        commander_1.program.parse();
+        (0, log_1.setLogLevel)(commander_1.program.opts().logLevel);
+        console.log(JSON.stringify(commander_1.program.opts()));
+        // copy in the this version of the css needed to make columns (and maybe other things?) work
+        let pathToCss = "";
+        try {
+            pathToCss = require.resolve("@sillsdev/docu-notion/dist/docu-notion-styles.css");
+        }
+        catch (e) {
+            // when testing from the docu-notion project itself:
+            pathToCss = "./src/css/docu-notion-styles.css";
+        }
+        // make any missing parts of the path exist
+        fs.ensureDirSync(commander_1.program.opts().cssOutputDirectory);
+        fs.copyFileSync(pathToCss, path_1.default.join(commander_1.program.opts().cssOutputDirectory, "docu-notion-styles.css"));
+        // pull and convert
+        yield (0, pull_1.notionPull)(commander_1.program.opts()).then(() => console.log("docu-notion Finished."));
+    });
 }
 exports.run = run;
 function parseLocales(value) {

package/dist/transform.js

@@ -15,6 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getMarkdownFromNotionBlocks = exports.getMarkdownForPage = void 0;
 const chalk_1 = __importDefault(require("chalk"));
 const log_1 = require("./log");
+const pull_1 = require("./pull");
 function getMarkdownForPage(config, context, page) {
     return __awaiter(this, void 0, void 0, function* () {
         (0, log_1.info)(`Reading & converting page ${page.layoutContext}/${page.nameOrTitle} (${chalk_1.default.blue(page.hasExplicitSlug
@@ -127,8 +128,18 @@ function doTransformsOnMarkdown(context, config, input) {
 }
 function doNotionToMarkdown(docunotionContext, blocks) {
     return __awaiter(this, void 0, void 0, function* () {
-        const mdBlocks = yield docunotionContext.notionToMarkdown.blocksToMarkdown(blocks);
-        const markdown = docunotionContext.notionToMarkdown.toMarkdownString(mdBlocks);
+        let mdBlocks;
+        yield (0, pull_1.executeWithRateLimitAndRetries)("notionToMarkdown.blocksToMarkdown", () => __awaiter(this, void 0, void 0, function* () {
+            mdBlocks = yield docunotionContext.notionToMarkdown.blocksToMarkdown(
+            // We need to provide a copy of blocks.
+            // Calling blocksToMarkdown can modify the values in the blocks. If it does, and then
+            // we have to retry, we end up retrying with the modified values, which
+            // causes various issues (like using the transformed image url instead of the original one).
+            // Note, currently, we don't do anything else with blocks after this.
+            // If that changes, we'll need to figure out a more sophisticated approach.
+            JSON.parse(JSON.stringify(blocks)));
+        }));
+        const markdown = docunotionContext.notionToMarkdown.toMarkdownString(mdBlocks).parent || "";
         return markdown;
     });
 }

package/package.json

@@ -11,8 +11,9 @@
     "// typescript check": "",
     "tsc": "tsc",
     "// test out with a private sample notion db": "",
-    "large-site-test": "npm run ts -- -n $SIL_BLOOM_DOCS_NOTION_TOKEN -r $SIL_BLOOM_DOCS_NOTION_ROOT_PAGE  --locales en,fr",
+    "large-site-test": "npm run ts -- -n $SIL_BLOOM_DOCS_NOTION_TOKEN -r $SIL_BLOOM_DOCS_NOTION_ROOT_PAGE  --locales en,fr   --log-level debug",
     "pull-test-tagged": "npm run ts -- -n $DOCU_NOTION_INTEGRATION_TOKEN -r $DOCU_NOTION_TEST_ROOT_PAGE_ID  --log-level debug --status-tag test",
+    "pull-test-css": "npm run ts -- --css-output-directory ./test/css -n $DOCU_NOTION_INTEGRATION_TOKEN -r $DOCU_NOTION_TEST_ROOT_PAGE_ID  --log-level debug --status-tag test",
     "pull-sample-site": "npm run ts -- -n $DOCU_NOTION_INTEGRATION_TOKEN -r $DOCU_NOTION_SAMPLE_ROOT_PAGE  --log-level debug",
     "// test with a semi-stable/public site:": "",
     "pull-sample": "npm run ts -- -n $DOCU_NOTION_INTEGRATION_TOKEN -r $DOCU_NOTION_SAMPLE_ROOT_PAGE -m ./sample --locales en,es,fr,de --log-level verbose",
@@ -35,7 +36,7 @@
     "markdown-table": "^2.0.0",
     "node-fetch": "2.6.6",
     "notion-client": "^4",
-    "notion-to-md": "2.5.5",
+    "notion-to-md": "3.1.1",
     "path": "^0.12.7",
     "ts-node": "^10.2.1",
     "sanitize-filename": "^1.6.3"
@@ -90,5 +91,5 @@
   "volta": {
     "node": "18.16.0"
   },
-  "version": "0.14.0-alpha.1"
+  "version": "0.14.0-alpha.10"
 }

package/dist/plugins/NumberedListTransformer.d.ts

@@ -1,2 +0,0 @@
-import { IPlugin } from "./pluginTypes";
-export declare const standardNumberedListTransformer: IPlugin;

package/dist/plugins/NumberedListTransformer.js

@@ -1,55 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.standardNumberedListTransformer = void 0;
-// This is mostly what notion-to-markdown would normally do with a block of type
-// numbered_list_item. A patch is documented at the end.
-function numberedListTransformer(notionToMarkdown, block) {
-    var _a, _b, _c;
-    //console.log("got numbered list block " + JSON.stringify(block));
-    // In this case typescript is not able to index the types properly, hence ignoring the error
-    // @ts-ignore
-    const blockContent = 
-    // @ts-ignore
-    ((_a = block.numbered_list_item) === null || _a === void 0 ? void 0 : _a.text) || ((_b = block.numbered_list_item) === null || _b === void 0 ? void 0 : _b.rich_text) || [];
-    let parsedData = "";
-    blockContent.map((content) => {
-        const annotations = content.annotations;
-        let plain_text = content.plain_text;
-        plain_text = notionToMarkdown.annotatePlainText(plain_text, annotations);
-        if (content["href"]) {
-            plain_text = `[${plain_text}](${content["href"]})`;
-        }
-        parsedData += plain_text;
-    });
-    // There is code in notion-to-md which attempts to set an incrementing number
-    // on each of these. Somehow it fails; in my testing, block.numbered_list_item never
-    // has a field 'number'. But we don't actually need incrementing numbers;
-    // markdown will do the numbering if we just make something that looks like
-    // a member of a numbered list by starting with number followed by period and space.
-    // I'm keeping the original code in case notion-to-md gets fixed and there is actually
-    // some reason to use incrementing numbers (it would at least make the markdown more
-    // human-readable); but this at least works.
-    // A problem is that in notion, a numbered list may continue after some intermediate
-    // content. To achieve this in markdown, we'd need to indent the intermediate content
-    // by a tab. Not only is it difficult to do this, but there appears to be no way to
-    // know whether we should. The data we get from notion doesn't include the item number,
-    // and its parent is the page rather than a particular list. So there is no way I can
-    // see to distinguish a list continuation from a new list. The code here will leave
-    // it up to markdown to decide whether to start a new list; I believe it will do so
-    // if it sees any intervening lines that are not list items.
-    let num = (_c = block.numbered_list_item) === null || _c === void 0 ? void 0 : _c.number;
-    //console.log("got number " + num?.toString());
-    if (!num) {
-        num = 1;
-    }
-    return Promise.resolve(`${num}. ${parsedData.trim()}`);
-}
-exports.standardNumberedListTransformer = {
-    name: "standardNumberedListTransformer",
-    notionToMarkdownTransforms: [
-        {
-            type: "numbered_list_item",
-            getStringFromBlock: (context, block) => numberedListTransformer(context.notionToMarkdown, block),
-        },
-    ],
-};

package/dist/plugins/NumberedListTransformer.spec.js

@@ -1,86 +0,0 @@
-"use strict";
-var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
-    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
-    return new (P || (P = Promise))(function (resolve, reject) {
-        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
-        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
-        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
-        step((generator = generator.apply(thisArg, _arguments || [])).next());
-    });
-};
-Object.defineProperty(exports, "__esModule", { value: true });
-const pluginTestRun_1 = require("./pluginTestRun");
-const NumberedListTransformer_1 = require("./NumberedListTransformer");
-let block;
-beforeEach(() => {
-    block = {
-        has_children: false,
-        archived: false,
-        type: "callout",
-        callout: {
-            rich_text: [
-                {
-                    type: "text",
-                    text: { content: "This is information callout", link: null },
-                    annotations: {
-                        bold: false,
-                        italic: false,
-                        strikethrough: false,
-                        underline: false,
-                        code: false,
-                        color: "default",
-                    },
-                    plain_text: "This is the callout",
-                    href: null,
-                },
-            ],
-            icon: { type: "emoji", emoji: "ℹ️" },
-            color: "gray_background",
-        },
-    };
-});
-test("external link inside numbered list, italic preserved", () => __awaiter(void 0, void 0, void 0, function* () {
-    const config = { plugins: [NumberedListTransformer_1.standardNumberedListTransformer] };
-    const results = yield (0, pluginTestRun_1.blocksToMarkdown)(config, [
-        {
-            type: "numbered_list_item",
-            numbered_list_item: {
-                rich_text: [
-                    {
-                        type: "text",
-                        text: { content: "link ", link: null },
-                        annotations: {
-                            bold: false,
-                            italic: false,
-                            strikethrough: false,
-                            underline: false,
-                            code: false,
-                            color: "default",
-                        },
-                        plain_text: "link ",
-                        href: null,
-                    },
-                    {
-                        type: "text",
-                        text: {
-                            content: "github",
-                            link: { url: "https://github.com" },
-                        },
-                        annotations: {
-                            bold: false,
-                            italic: true,
-                            strikethrough: false,
-                            underline: false,
-                            code: false,
-                            color: "default",
-                        },
-                        plain_text: "github",
-                        href: "https://github.com",
-                    },
-                ],
-                color: "default",
-            },
-        },
-    ]);
-    expect(results.trim()).toBe(`1. link [_github_](https://github.com)`);
-}));