@sillsdev/docu-notion 0.13.4 → 0.14.0-alpha.10

package/README.md

@@ -10,6 +10,8 @@ Example Site: https://sillsdev.github.io/docu-notion-sample-site/
 
 First, prepare your markdown-based static file system like [Docusaurus](https://docusaurus.io/). For a shortcut with github actions, search, and deployment to github pages, you can just copy [this template](https://github.com/sillsdev/docu-notion-sample-site).
 
+If you do not use the above sample, you will need to manually add [notion-styles.css](src/css/notion-styles.css) to your site. This enables multi-column layouts and another other special styling that we need to make the output of docu-notion look right.
+
 ## 2. In Notion, duplicate the docu-notion template
 
 Go to [this template page](https://hattonjohn.notion.site/Documentation-Template-Docusaurus-0e998b32da3c47edad0f62a25b49818c). Duplicate it into your own workspace.
@@ -17,13 +19,13 @@ You can name it anything you like, e.g. "Documentation Root".
 
 ## 3. Create a Notion Integration
 
-In order for docu-notion to read your site via Notion's API, you need to create what Notion calls an "integration". Follow [these instructions](https://developers.notion.com/docs/getting-started) to make an integration and get your token. Limit your integration to "READ" access.
+In order for docu-notion to read your site via Notion's API, you need to create what Notion calls an "integration". Follow [these instructions](https://developers.notion.com/docs/getting-started) to make an integration and get your token. Remember to limit your integration to "READ" access.
 
-## 4. "Invite" your Notion Integration to read you page
+## 4. Connect your Integration
 
-In Notion, click "Share" on the root of your documentation and "invite" your integration to it.
+Go to the page that will be the root of your site. This page should have, as direct children, your "Outline" (required) and "Database" (optional) pages. Follow [these instructions](https://developers.notion.com/docs/create-a-notion-integration#give-your-integration-page-permissions).
 
-![image](https://user-images.githubusercontent.com/8448/168930238-1dcf46df-a690-4839-bf4c-c63157f104d8.png)
+<img width="318" alt="image" src="https://github.com/sillsdev/docu-notion/assets/8448/810c6dca-f9ab-4370-93b4-dc1479332af7">
 
 ## 5. Add your pages under your Outline page.
 
@@ -35,7 +37,7 @@ First, determine the id of your root page by clicking "Share" and looking at the
 https://www.notion.so/hattonjohn/My-Docs-0456aa5842946bdbea3a4f37c97a0e5
 means that the id is "0456aa5842946PRETEND4f37c97a0e5".
 
-Determine where you want the markdown files and images to land. The following works well for Docusaurus instances:
+Try it out:
 
 ```
 npx @sillsdev/docu-notion -n secret_PRETEND123456789PRETEND123456789PRETEND6789 -r 0456aa5842946PRETEND4f37c97a0e5"

package/dist/config/default.docunotion.config.js

@@ -8,8 +8,8 @@ const ColumnListTransformer_1 = require("../plugins/ColumnListTransformer");
 const ColumnTransformer_1 = require("../plugins/ColumnTransformer");
 const EscapeHtmlBlockModifier_1 = require("../plugins/EscapeHtmlBlockModifier");
 const HeadingTransformer_1 = require("../plugins/HeadingTransformer");
-const NumberedListTransformer_1 = require("../plugins/NumberedListTransformer");
 const TableTransformer_1 = require("../plugins/TableTransformer");
+const VideoTransformer_1 = require("../plugins/VideoTransformer");
 const externalLinks_1 = require("../plugins/externalLinks");
 const defaultConfig = {
     plugins: [
@@ -23,15 +23,13 @@ const defaultConfig = {
         images_1.standardImageTransformer,
         CalloutTransformer_1.standardCalloutTransformer,
         TableTransformer_1.standardTableTransformer,
-        NumberedListTransformer_1.standardNumberedListTransformer,
+        VideoTransformer_1.standardVideoTransformer,
         // Link modifiers, which are special because they can read metadata from all the pages in order to figure out the correct url
         internalLinks_1.standardInternalLinkConversion,
         externalLinks_1.standardExternalLinkConversion,
         // Regexps plus javascript `import`s that operate on the Markdown output
         embedTweaks_1.imgurGifEmbed,
         embedTweaks_1.gifEmbed,
-        embedTweaks_1.youtubeEmbed,
-        embedTweaks_1.vimeoEmbed,
     ],
 };
 exports.default = defaultConfig;

package/dist/{notion-styles.css → docu-notion-styles.css}

@@ -1,58 +1,60 @@
-/* Note, I haven't figure out how a Docusaurus app can actually include this, yet.
-  So currently this has to be duplicated by the client.
-*/
-
-/* Copied from
-    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L934
-    and
-    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L1063
-*/
-.notion-column {
-  display: flex;
-  flex-direction: column;
-  padding-top: 12px;
-  padding-bottom: 12px;
-}
-
-.notion-column > *:first-child {
-  margin-top: 0;
-  margin-left: 0;
-  margin-right: 0;
-}
-
-.notion-column > *:last-child {
-  margin-left: 0;
-  margin-right: 0;
-  margin-bottom: 0;
-}
-
-.notion-row {
-  display: flex;
-  overflow: hidden;
-  width: 100%;
-  max-width: 100%;
-}
-
-@media (max-width: 640px) {
-  .notion-row {
-    flex-direction: column;
-  }
-
-  .notion-row .notion-column {
-    width: 100% !important;
-  }
-
-  .notion-row .notion-spacer {
-    display: none;
-  }
-}
-
-.notion-spacer {
-  /* This matches the value in ColumnTransformer.ts */
-  width: calc(min(32px, 4vw));
-}
-
-.notion-spacer:last-child {
-  display: none;
-}
-/* End copied from NotionX */
+/* This should be added to the docusaurus.config.js in order to show some notion things correctly.
+See the option: --css-output-directory 
+See the docusaurus docs: https://docusaurus.io/docs/styling-layout
+See the use in the docu-notion-sample-site: https://github.com/sillsdev/docu-notion-sample-site/blob/main/docusaurus.config.js
+*/
+
+/* Copied from
+    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L934
+    and
+    https://github1s.com/NotionX/react-notion-x/blob/master/packages/react-notion-x/src/styles.css#L1063
+*/
+.notion-column {
+  display: flex;
+  flex-direction: column;
+  padding-top: 12px;
+  padding-bottom: 12px;
+}
+
+.notion-column > *:first-child {
+  margin-top: 0;
+  margin-left: 0;
+  margin-right: 0;
+}
+
+.notion-column > *:last-child {
+  margin-left: 0;
+  margin-right: 0;
+  margin-bottom: 0;
+}
+
+.notion-row {
+  display: flex;
+  overflow: hidden;
+  width: 100%;
+  max-width: 100%;
+}
+
+@media (max-width: 640px) {
+  .notion-row {
+    flex-direction: column;
+  }
+
+  .notion-row .notion-column {
+    width: 100% !important;
+  }
+
+  .notion-row .notion-spacer {
+    display: none;
+  }
+}
+
+.notion-spacer {
+  /* This matches the value in ColumnTransformer.ts */
+  width: calc(min(32px, 4vw));
+}
+
+.notion-spacer:last-child {
+  display: none;
+}
+/* End copied from NotionX */

package/dist/latex.spec.js

@@ -0,0 +1,97 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const notion_to_md_1 = require("notion-to-md");
+const HierarchicalNamedLayoutStrategy_1 = require("./HierarchicalNamedLayoutStrategy");
+const transform_1 = require("./transform");
+const internalLinks_1 = require("./plugins/internalLinks");
+const pull_1 = require("./pull");
+const default_docunotion_config_1 = __importDefault(require("./config/default.docunotion.config"));
+test("Latex Rendering", () => __awaiter(void 0, void 0, void 0, function* () {
+    const pages = new Array();
+    const counts = {
+        output_normally: 0,
+        skipped_because_empty: 0,
+        skipped_because_status: 0,
+        skipped_because_level_cannot_have_content: 0,
+    };
+    const notionClient = (0, pull_1.initNotionClient)("");
+    const layoutStrategy = new HierarchicalNamedLayoutStrategy_1.HierarchicalNamedLayoutStrategy();
+    const config = default_docunotion_config_1.default;
+    const context = {
+        getBlockChildren: (id) => {
+            return new Promise(resolve => resolve(new Array()));
+        },
+        directoryContainingMarkdown: "",
+        relativeFilePathToFolderContainingPage: "",
+        layoutStrategy: layoutStrategy,
+        notionToMarkdown: new notion_to_md_1.NotionToMarkdown({ notionClient }),
+        options: {
+            notionToken: "",
+            rootPage: "",
+            locales: [""],
+            markdownOutputPath: "",
+            imgOutputPath: "",
+            imgPrefixInMarkdown: "",
+            statusTag: "",
+        },
+        pages: pages,
+        counts: counts,
+        imports: [],
+        convertNotionLinkToLocalDocusaurusLink: (url) => (0, internalLinks_1.convertInternalUrl)(context, url),
+    };
+    const blocks = [
+        {
+            object: "block",
+            id: "169e1c47-6706-4518-adca-73086b2738ac",
+            parent: {
+                type: "page_id",
+                page_id: "2acc11a4-82a9-4759-b429-fa011c164888",
+            },
+            created_time: "2023-08-18T15:51:00.000Z",
+            last_edited_time: "2023-08-18T15:51:00.000Z",
+            created_by: {
+                object: "user",
+                id: "af5c163e-82b1-49d1-9f1c-539907bb9fb9",
+            },
+            last_edited_by: {
+                object: "user",
+                id: "af5c163e-82b1-49d1-9f1c-539907bb9fb9",
+            },
+            has_children: false,
+            archived: false,
+            type: "paragraph",
+            paragraph: {
+                rich_text: [
+                    {
+                        type: "equation",
+                        equation: { expression: "x" },
+                        annotations: {
+                            bold: false,
+                            italic: false,
+                            strikethrough: false,
+                            underline: false,
+                            code: false,
+                            color: "default",
+                        },
+                        plain_text: "x",
+                        href: null,
+                    },
+                ],
+                color: "default",
+            },
+        },
+    ];
+    expect(yield (0, transform_1.getMarkdownFromNotionBlocks)(context, config, blocks)).toContain("$x$");
+}));

package/dist/plugins/ColumnTransformer.js

@@ -28,16 +28,14 @@ function notionColumnToMarkdown(notionToMarkdown, getBlockChildren, block) {
         const { id, has_children } = block; // "any" because the notion api type system is complex with a union that don't know how to help TS to cope with
         if (!has_children)
             return "";
-        const children = yield getBlockChildren(id);
-        const childrenPromises = children.map((column) => __awaiter(this, void 0, void 0, function* () { return yield notionToMarkdown.blockToMarkdown(column); }));
-        const childrenStrings = yield Promise.all(childrenPromises);
+        const columnChildren = yield getBlockChildren(id);
+        const childrenMdBlocksArray = yield Promise.all(columnChildren.map((child) => __awaiter(this, void 0, void 0, function* () { return yield notionToMarkdown.blocksToMarkdown([child]); })));
+        const childrenMarkdown = childrenMdBlocksArray.map(mdBlockArray => notionToMarkdown.toMarkdownString(mdBlockArray).parent);
         const columnWidth = yield getColumnWidth(block);
-        // note: it would look better in the markup with \n, but that
-        // causes notion-to-md to give us ":::A" instead of \n for some reason.
-        return (`<div class='notion-column' style={{width: '${columnWidth}'}}>\n\n${childrenStrings.join("\n\n")}\n\n</div>` +
+        return (`<div class='notion-column' style={{width: '${columnWidth}'}}>\n\n${childrenMarkdown.join("\n")}\n</div>` +
             // Spacer between columns. CSS takes care of hiding this for the last column
             // and when the screen is too narrow for multiple columns.
-            `<div className='notion-spacer' />`);
+            `<div className='notion-spacer'></div>`);
     });
 }
 // The official API doesn't give us access to the format information, including column_ratio.

package/dist/plugins/ColumnTransformer.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/plugins/ColumnTransformer.spec.js

@@ -0,0 +1,118 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const pluginTestRun_1 = require("./pluginTestRun");
+const ColumnTransformer_1 = require("./ColumnTransformer");
+// Even though we can set up most tests with our own children
+// so that we aren't relying on real data from Notion,
+// we can't prevent the notion-to-md library from making an API call
+// every time it processes a block with has_children:true.
+// So for these tests with children, we need any valid API key.
+const runTestsWhichRequireAnyValidApiKey = !!process.env.DOCU_NOTION_INTEGRATION_TOKEN;
+// To test grandchildren, we can't get around notion-to-md making an API call
+// to get real children. So we need a specific notion record.
+// For that reason, we don't try to run these tests unless the user changes this flag.
+// But it is an important test; grandchildren in columns were broken.
+// See https://github.com/sillsdev/docu-notion/issues/70.
+const runManualTestsWhichRequireSpecificNotionRecords = false;
+const columnBlock = {
+    object: "block",
+    id: "e6d2d7b7-b1ed-464a-86d2-bb5f6be78a03",
+    has_children: true,
+    type: "column",
+    column: {},
+};
+function getResults(children) {
+    return __awaiter(this, void 0, void 0, function* () {
+        return yield (0, pluginTestRun_1.blocksToMarkdown)({ plugins: [ColumnTransformer_1.standardColumnTransformer] }, [columnBlock], undefined, children, process.env.DOCU_NOTION_INTEGRATION_TOKEN);
+    });
+}
+const columnWrapperStart = "<div class='notion-column' style=\\{\\{width: '.*?'\\}\\}>\\n\\n";
+const columnWrapperEnd = "\\n\\n<\\/div><div className='notion-spacer'><\\/div>";
+if (runTestsWhichRequireAnyValidApiKey) {
+    columnBlock.has_children = true;
+    test("requires API key - column with paragraph", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([getTestParagraphBlock()]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?my paragraph\\s*?${columnWrapperEnd}`));
+    }), 20000);
+    test("requires API key - column with two paragraphs", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([
+            getTestParagraphBlock(1),
+            getTestParagraphBlock(2),
+        ]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?my paragraph 1\\s+?my paragraph 2\\s*?${columnWrapperEnd}`));
+    }), 20000);
+    test("requires API key - column with numbered list", () => __awaiter(void 0, void 0, void 0, function* () {
+        const results = yield getResults([
+            getNumberedListItemBlock(1),
+            getNumberedListItemBlock(2),
+        ]);
+        expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?1\\. Numbered list item 1\\s+?2\\. Numbered list item 2\\s*?${columnWrapperEnd}`, "s"));
+    }), 20000);
+    if (runManualTestsWhichRequireSpecificNotionRecords) {
+        test("manual test - requires specific notion record and API key - column with numbered list with sublist", () => __awaiter(void 0, void 0, void 0, function* () {
+            const realNumberedListBlock = getNumberedListItemBlock(1);
+            realNumberedListBlock.id = "ca08d14b-9b70-4f6f-9d17-9fd74b57afeb";
+            realNumberedListBlock.has_children = true;
+            const results = yield getResults([realNumberedListBlock]);
+            expect(results).toMatch(new RegExp(`${columnWrapperStart}\\s*?1\\. Numbered list item 1\\s+?- unordered sub-bullet\\s*?${columnWrapperEnd}`, "s"));
+        }), 20000);
+    }
+}
+else {
+    // This test prevents an error when runTestsWhichRequireAnyValidApiKey is false
+    // due to having a test suite with no tests.
+    test("no column transformer tests were run because there is no API key provided", () => {
+        expect(true).toBe(true);
+    });
+}
+function getNumberedListItemBlock(identifier) {
+    const content = identifier
+        ? `Numbered list item ${identifier}`
+        : `Numbered list item`;
+    return {
+        object: "block",
+        type: "numbered_list_item",
+        numbered_list_item: {
+            rich_text: [
+                {
+                    type: "text",
+                    text: { content: content },
+                    annotations: {
+                        code: false,
+                    },
+                    plain_text: content,
+                },
+            ],
+        },
+    };
+}
+function getTestParagraphBlock(identifier) {
+    const content = identifier ? `my paragraph ${identifier}` : `my paragraph`;
+    return {
+        object: "block",
+        type: "paragraph",
+        paragraph: {
+            rich_text: [
+                {
+                    type: "text",
+                    text: {
+                        content: content,
+                    },
+                    annotations: {
+                        code: false,
+                    },
+                    plain_text: content,
+                },
+            ],
+        },
+    };
+}

package/dist/plugins/VideoTransformer.d.ts

@@ -0,0 +1,2 @@
+import { IPlugin } from "./pluginTypes";
+export declare const standardVideoTransformer: IPlugin;

package/dist/plugins/VideoTransformer.js

@@ -0,0 +1,33 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.standardVideoTransformer = void 0;
+const log_1 = require("../log");
+exports.standardVideoTransformer = {
+    name: "video",
+    notionToMarkdownTransforms: [
+        {
+            type: "video",
+            getStringFromBlock: (context, block) => {
+                const video = block.video;
+                let url = "";
+                switch (video.type) {
+                    case "external":
+                        url = video.external.url;
+                        break;
+                    case "file":
+                        url = video.file.url;
+                        break;
+                    default:
+                        // video.type can only be "external" or "file" as of the writing of this code, so typescript
+                        // isn't happy trying to turn video.type into a string. But this default in our switch is
+                        // just attempting some future-proofing. Thus the strange typing/stringifying below.
+                        (0, log_1.warning)(`[standardVideoTransformer] Found Notion "video" block with type ${JSON.stringify(video.type)}. The best docu-notion can do for now is ignore it.`);
+                        return "";
+                        break;
+                }
+                context.imports.push(`import ReactPlayer from "react-player";`);
+                return `<ReactPlayer controls url="${url}" />`;
+            },
+        },
+    ],
+};

package/dist/plugins/VideoTransformer.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/plugins/VideoTransformer.spec.js

@@ -0,0 +1,112 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const log_1 = require("../log");
+const VideoTransformer_1 = require("./VideoTransformer");
+const pluginTestRun_1 = require("./pluginTestRun");
+test("youtube embedded", () => __awaiter(void 0, void 0, void 0, function* () {
+    const config = { plugins: [VideoTransformer_1.standardVideoTransformer] };
+    const result = yield (0, pluginTestRun_1.blocksToMarkdown)(config, [
+        {
+            object: "block",
+            type: "video",
+            video: {
+                caption: [
+                    {
+                        type: "text",
+                        text: {
+                            content: "A video about editing in Notion",
+                            link: null,
+                        },
+                        plain_text: "A video about editing in Notion",
+                        href: null,
+                    },
+                ],
+                type: "external",
+                external: { url: "https://www.youtube.com/watch?v=FXIrojSK3Jo" },
+            },
+        },
+    ]);
+    expect(result).toContain(`import ReactPlayer from "react-player";`);
+    expect(result).toContain(`<ReactPlayer controls url="https://www.youtube.com/watch?v=FXIrojSK3Jo" />`);
+}));
+test("vimeo embedded", () => __awaiter(void 0, void 0, void 0, function* () {
+    (0, log_1.setLogLevel)("verbose");
+    const config = { plugins: [VideoTransformer_1.standardVideoTransformer] };
+    const result = yield (0, pluginTestRun_1.blocksToMarkdown)(config, [
+        {
+            object: "block",
+            type: "video",
+            video: {
+                caption: [],
+                type: "external",
+                external: { url: "https://vimeo.com/4613611xx" },
+            },
+        },
+    ]);
+    expect(result).toContain(`import ReactPlayer from "react-player";`);
+    expect(result).toContain(`<ReactPlayer controls url="https://vimeo.com/4613611xx" />`);
+}));
+test("video link, not embedded", () => __awaiter(void 0, void 0, void 0, function* () {
+    (0, log_1.setLogLevel)("verbose");
+    const config = { plugins: [VideoTransformer_1.standardVideoTransformer] };
+    const result = yield (0, pluginTestRun_1.blocksToMarkdown)(config, [
+        {
+            object: "block",
+            type: "paragraph",
+            paragraph: {
+                rich_text: [
+                    {
+                        type: "text",
+                        text: {
+                            content: "https://vimeo.com/4613611xx",
+                            link: {
+                                url: "https://vimeo.com/4613611xx",
+                            },
+                        },
+                        annotations: {
+                            code: false,
+                        },
+                        plain_text: "https://vimeo.com/4613611xx",
+                        href: "https://vimeo.com/4613611xx",
+                    },
+                ],
+                color: "default",
+            },
+        },
+    ]);
+    expect(result).toContain("[https://vimeo.com/4613611xx](https://vimeo.com/4613611xx)");
+    expect(result).not.toContain(`import`);
+}));
+test("direct upload to to Notion (embedded)", () => __awaiter(void 0, void 0, void 0, function* () {
+    (0, log_1.setLogLevel)("verbose");
+    const config = { plugins: [VideoTransformer_1.standardVideoTransformer] };
+    const result = yield (0, pluginTestRun_1.blocksToMarkdown)(config, [
+        {
+            object: "block",
+            id: "12f7db3b-4412-4be9-a3f7-6ac423fee94a",
+            parent: {
+                type: "page_id",
+                page_id: "edaffeb2-ece8-4d44-976f-351e6b5757bb",
+            },
+            type: "video",
+            video: {
+                caption: [],
+                type: "file",
+                file: {
+                    url: "https://s3.us-west-2.amazonaws.com/secure.notion-static.com/f6bc4746-011e-2124-86ca-ed4337d70891/people_fre_motionAsset_p3.mp4?X-Blah-blah",
+                },
+            },
+        },
+    ]);
+    expect(result).toContain(`import ReactPlayer from "react-player";`);
+    expect(result).toContain(`<ReactPlayer controls url="https://s3.us-west-2.amazonaws.com/secure.notion-static.com/f6bc4746-011e-2124-86ca-ed4337d70891/people_fre_motionAsset_p3.mp4?X-Blah-blah" />`);
+}));

package/dist/plugins/embedTweaks.d.ts

@@ -1,5 +1,3 @@
 import { IPlugin } from "./pluginTypes";
 export declare const gifEmbed: IPlugin;
 export declare const imgurGifEmbed: IPlugin;
-export declare const youtubeEmbed: IPlugin;
-export declare const vimeoEmbed: IPlugin;

package/dist/plugins/embedTweaks.js

@@ -1,13 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.vimeoEmbed = exports.youtubeEmbed = exports.imgurGifEmbed = exports.gifEmbed = void 0;
+exports.imgurGifEmbed = exports.gifEmbed = void 0;
 exports.gifEmbed = {
     name: "gif",
     regexMarkdownModifications: [
         {
             // I once saw a gif coming from Notion that wasn't a full
             // url, which wouldn't work, hence the "http" requirement
-            regex: /\[.*\]\((http.*(\.(gif|GIF)))\)/,
+            regex: /\[.*?\]\((http.*?(\.(gif|GIF)))\)/,
             replacementPattern: `![]($1)`,
         },
     ],
@@ -16,31 +16,9 @@ exports.imgurGifEmbed = {
     name: "imgur",
     regexMarkdownModifications: [
         {
-            regex: /\[.*\]\((.*imgur\.com\/.*)\)/,
+            regex: /\[.*?\]\((.*?imgur\.com\/.*?)\)/,
             // imgur links to gifs need a .gif at the end, but the url they give you doesn't have one.
             replacementPattern: `![]($1.gif)`,
         },
     ],
 };
-exports.youtubeEmbed = {
-    name: "youtube",
-    regexMarkdownModifications: [
-        {
-            regex: /\[.*\]\((.*youtube\.com\/watch.*)\)/,
-            imports: [`import ReactPlayer from "react-player";`],
-            replacementPattern: `<ReactPlayer controls url="$1" />`,
-        },
-    ],
-};
-exports.vimeoEmbed = {
-    name: "vimeo",
-    regexMarkdownModifications: [
-        {
-            regex: /\[.*\]\((https:\/\/.*vimeo.*)\)/,
-            // we use to have the following, but the above should handle both the player an not-player urls.
-            //regex: /\[.*\]\((.*player\.vimeo.*)\)/gm, // player.vimeo
-            imports: [`import ReactPlayer from "react-player";`],
-            replacementPattern: `<ReactPlayer controls url="$1" />`,
-        },
-    ],
-};