@silexpert/core 2.0.123-beta.0 → 2.0.124

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@silexpert/core",
-  "version": "2.0.123-beta.0",
+  "version": "2.0.124",
   "description": "Silex Core perform HTTP Request and object binding. Silex core helps developers to retrieve and return formatted object",
   "keywords": [
     "accounting",

package/ts/api/resources/Mfa.ts

@@ -14,12 +14,16 @@ export class UserMfa extends Resource {
     return this.axios.$post('/mfa/disable', { userId });
   }
 
-  verifyCode(userId: number, code: string): Promise<{ success: boolean; token?: string }> {
-    return this.axios.$post('/mfa/verify/code', { userId, code });
+  verifyCode(userId: number, code: string, mfaChallengeToken?: string): Promise<{ success: boolean; token?: string }> {
+    return this.axios.$post('/mfa/verify/code', { userId, code, mfaChallengeToken });
   }
 
-  verifyRecoveryCode(userId: number, recoveryCode: string): Promise<{ success: boolean; token?: string }> {
-    return this.axios.$post('/mfa/verify/recovery-code', { userId, recoveryCode });
+  verifyRecoveryCode(
+    userId: number,
+    recoveryCode: string,
+    mfaChallengeToken?: string,
+  ): Promise<{ success: boolean; token?: string }> {
+    return this.axios.$post('/mfa/verify/recovery-code', { userId, recoveryCode, mfaChallengeToken });
   }
 
   isMfaEnabled(userId?: number): Promise<{ isEnabled: boolean }> {

package/ts/api/resources/zendesk/Ticket.ts

@@ -1,16 +1,17 @@
 import {
+  CountUnreadZendeskTickets,
+  CountUnreadZendeskTicketsResponse,
   CreateZendeskTicket,
   UpdateZendeskTicket,
   ListZendeskTickets,
-  TicketZendeskResponse,
-  SearchZendeskResponse,
+  ListZendeskTicketsResponse,
   TicketFormEnriched,
   TicketZendesk,
 } from '../../../index.js';
 import { Resource } from '../../Resource.js';
 
 export class ZendeskTicket extends Resource {
-  getPaginate(query: ListZendeskTickets): Promise<TicketZendeskResponse | SearchZendeskResponse> {
+  getPaginate(query: ListZendeskTickets): Promise<ListZendeskTicketsResponse> {
     return this.axios.$get('connectors/zendesk/tickets', { params: query });
   }
 
@@ -18,6 +19,10 @@ export class ZendeskTicket extends Resource {
     return this.axios.$get('connectors/zendesk/tickets/forms');
   }
 
+  getUnreadCount(query: CountUnreadZendeskTickets): Promise<CountUnreadZendeskTicketsResponse> {
+    return this.axios.$get('connectors/zendesk/tickets/unread-count', { params: query });
+  }
+
   get(id: number): Promise<TicketZendesk> {
     return this.axios.$get(`connectors/zendesk/tickets/${id}`);
   }
@@ -43,6 +48,10 @@ export class ZendeskTicket extends Resource {
     return this.axios.$put(`connectors/zendesk/tickets/${id}`, data);
   }
 
+  markAsRead(id: number): Promise<void> {
+    return this.axios.$put(`connectors/zendesk/tickets/${id}/read`);
+  }
+
   delete(id: number): Promise<void> {
     return this.axios.$delete(`connectors/zendesk/tickets/${id}`);
   }

package/ts/types/Enum/PrestationType.ts

@@ -230,7 +230,6 @@ export const allPrestationsWithBrochure = [
   PrestationType.COMPTA_POURCENTAGE_PREMIUM,
   PrestationType.COMPTA_POURCENTAGE_EXPRESS,
   PrestationType.COMPTA_POURCENTAGE_PREMIUM_EXPRESS,
-  PrestationType.BILAN_PREVISIONNEL,
   PrestationType.EXCEPTIONNEL,
   PrestationType.DECLARATION_IR,
 ];
@@ -276,6 +275,7 @@ export const allPrestations2025WithCGV = [
   PrestationType.ATTESTATION_MASSE_SALARIALE,
   PrestationType.ATTESTATION_1,
   PrestationType.ATTESTATION_NON_REMUNERATION_RECURRENTE,
+  PrestationType.BILAN_PREVISIONNEL,
 ];
 
 export const ClementineSubscriptionAccountancyExpertPrestations: PrestationType[] = [

package/ts/types/Enum/Zendesk.ts

@@ -125,3 +125,31 @@ export const ZendeskTicketCategoryList: Array<{ id: ZendeskTicketCategoryEnum; l
   { id: ZendeskTicketCategoryEnum.RELANCE_BILAN, label: 'Relance bilan' },
   { id: ZendeskTicketCategoryEnum.SUPPORT_APPLICATION, label: 'Support application' },
 ];
+
+export type ZendeskTicketStatusGroup = 'information_required' | 'in_progress' | 'received' | 'resolved' | 'closed';
+
+export enum ZendeskTicketStatusGroupEnum {
+  INFORMATION_REQUIRED = 'information_required',
+  IN_PROGRESS = 'in_progress',
+  RECEIVED = 'received',
+  RESOLVED = 'resolved',
+  CLOSED = 'closed',
+}
+
+export const ZendeskTicketStatusGroupByStatus: Record<ZendeskTicketStatusEnum, ZendeskTicketStatusGroupEnum> = {
+  [ZendeskTicketStatusEnum.NEW]: ZendeskTicketStatusGroupEnum.RECEIVED,
+  [ZendeskTicketStatusEnum.OPEN]: ZendeskTicketStatusGroupEnum.IN_PROGRESS,
+  [ZendeskTicketStatusEnum.HOLD]: ZendeskTicketStatusGroupEnum.IN_PROGRESS,
+  [ZendeskTicketStatusEnum.PENDING]: ZendeskTicketStatusGroupEnum.INFORMATION_REQUIRED,
+  [ZendeskTicketStatusEnum.SOLVED]: ZendeskTicketStatusGroupEnum.RESOLVED,
+  [ZendeskTicketStatusEnum.CLOSED]: ZendeskTicketStatusGroupEnum.CLOSED,
+};
+
+// Display order of the support page: groups needing customer action come first.
+export const ZendeskTicketStatusGroupList: Array<{ id: ZendeskTicketStatusGroupEnum; label: string }> = [
+  { id: ZendeskTicketStatusGroupEnum.INFORMATION_REQUIRED, label: 'Information requise' },
+  { id: ZendeskTicketStatusGroupEnum.IN_PROGRESS, label: 'En cours' },
+  { id: ZendeskTicketStatusGroupEnum.RECEIVED, label: 'Demande reçue' },
+  { id: ZendeskTicketStatusGroupEnum.RESOLVED, label: 'Résolu' },
+  { id: ZendeskTicketStatusGroupEnum.CLOSED, label: 'Archivé' },
+];

package/ts/types/Interface/api/authentification/AuthenticationResponse.ts

@@ -9,6 +9,8 @@ export class IAuthenticationResponse {
   expiresAt?: Date;
   /** ID de l'utilisateur */
   userId?: number;
+  /** Jeton opaque de défi MFA lié à l'étape mot de passe */
+  mfaChallengeToken?: string;
   /** Message informatif */
   message?: string;
   /** Token JWT si authentification réussie */

package/ts/types/Interface/api/authentification/ReadAuthenticateCollaborater.ts

@@ -3,7 +3,14 @@ import { PrestationTypeDetail } from '../../../Enum/PrestationType.js';
 import { IUser } from '../../models/IUser.js';
 
 export class ReadAuthenticateCollaborater {
-  token: string;
+  /** JWT, absent tant que la vérification MFA n'est pas faite */
+  token?: string;
+  /** Vrai si un code MFA doit être vérifié via /mfa/verify/* avant d'obtenir le JWT */
+  requiresMfa?: boolean;
+  /** ID de l'utilisateur, à renvoyer avec le code MFA */
+  userId?: number;
+  /** Jeton opaque de défi MFA lié à l'étape mot de passe */
+  mfaChallengeToken?: string;
 }
 
 export class ReadConnectAs {

package/ts/types/Interface/api/mfa/VerifyCode.ts

@@ -1,4 +1,4 @@
-import { IsInt, IsNotEmpty, IsString, Length } from 'class-validator';
+import { IsInt, IsNotEmpty, IsOptional, IsString, Length } from 'class-validator';
 
 export class MfaVerifyCode {
   @IsNotEmpty()
@@ -8,4 +8,9 @@ export class MfaVerifyCode {
   @IsString()
   @Length(6, 6)
   code: string;
+
+  /** Optionnel le temps de la transition des anciennes versions de l'app mobile (SEC-04) */
+  @IsOptional()
+  @IsString()
+  mfaChallengeToken?: string;
 }

package/ts/types/Interface/api/mfa/VerifyRecoveryCode.ts

@@ -1,4 +1,4 @@
-import { IsInt, IsNotEmpty, IsString } from 'class-validator';
+import { IsInt, IsNotEmpty, IsOptional, IsString } from 'class-validator';
 
 export class MfaVerifyRecoveryCode {
   @IsNotEmpty()
@@ -8,4 +8,9 @@ export class MfaVerifyRecoveryCode {
   @IsString()
   @IsNotEmpty()
   recoveryCode: string;
+
+  /** Optionnel le temps de la transition des anciennes versions de l'app mobile (SEC-04) */
+  @IsOptional()
+  @IsString()
+  mfaChallengeToken?: string;
 }

package/ts/types/Interface/api/zendesk/QueryTicket.ts

@@ -10,6 +10,7 @@ import {
   Min,
   Max,
   IsDateString,
+  IsBoolean,
 } from 'class-validator';
 import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
 import {
@@ -21,9 +22,13 @@ import {
   ZendeskTicketPriorityEnum,
   type ZendeskTicketStatus,
   ZendeskTicketStatusEnum,
+  type ZendeskTicketStatusGroup,
+  ZendeskTicketStatusGroupEnum,
   type ZendeskTicketType,
   ZendeskTicketTypeEnum,
 } from '../../../../types/Enum/Zendesk.js';
+import { ToBoolean } from '../../../../utils/transforms/boolean.transform.js';
+import { ToStringArray } from '../../../../utils/transforms/array.transform.js';
 
 export class CreateZendeskTicket {
   @ApiProperty()
@@ -193,13 +198,36 @@ export class ListZendeskTickets {
   @IsDateString()
   endDate?: string;
 
+  /**
+   * @deprecated Tickets are now sorted by status group, unread state and last public message date.
+   * Only `sortOrder` is taken into account.
+   */
   @ApiPropertyOptional()
   @IsOptional()
   @IsString()
   sortBy?: string;
 
-  @ApiPropertyOptional()
+  @ApiPropertyOptional({ description: 'Order applied to the last public message date' })
   @IsOptional()
   @IsEnum(['asc', 'desc'])
   sortOrder?: 'asc' | 'desc';
+
+  @ApiPropertyOptional({ enum: ZendeskTicketStatusGroupEnum, isArray: true })
+  @IsOptional()
+  @ToStringArray()
+  @IsArray()
+  @IsEnum(ZendeskTicketStatusGroupEnum, { each: true })
+  statusGroups?: ZendeskTicketStatusGroup[];
+
+  @ApiPropertyOptional()
+  @IsOptional()
+  @ToBoolean()
+  @IsBoolean()
+  isUnread?: boolean;
+}
+
+export class CountUnreadZendeskTickets {
+  @ApiProperty()
+  @IsEnum(ZendeskTicketChannelEnum)
+  channel: ZendeskTicketChannel;
 }

package/ts/types/Interface/api/zendesk/ReadTicket.ts

@@ -2,8 +2,10 @@ import {
   ZendeskTicketChannel,
   ZendeskTicketPriority,
   ZendeskTicketStatus,
+  ZendeskTicketStatusGroup,
   ZendeskTicketType,
 } from '../../../Enum/Zendesk.js';
+import type { BasePaginate } from '../BasePaginate.js';
 
 export interface TicketZendesk {
   id: number;
@@ -22,6 +24,19 @@ export interface TicketZendesk {
   organizationId: number | null;
   createdAt: string;
   updatedAt: string;
+  // Read-tracking data, only computed on the paginated list
+  statusGroup?: ZendeskTicketStatusGroup;
+  isUnread?: boolean;
+  lastActivityAt?: string;
+}
+
+export interface ListZendeskTicketsResponse extends BasePaginate<TicketZendesk> {
+  // Unread tickets of the channel whatever the filters, to refresh the unread badge with the list.
+  unreadCount: number;
+}
+
+export interface CountUnreadZendeskTicketsResponse {
+  count: number;
 }
 
 export interface SearchZendeskResponse {

package/ts/types/Interface/models/IApiError.ts

@@ -8,6 +8,10 @@ export enum Code {
   // HTTP Error
   tokenFailure = 'token_authentication_failure',
   authenticationFailure = 'authentication_credentials_failure',
+  /** MFA challenge missing, expired, used or bound to another user: the user must log in again */
+  mfaChallengeInvalid = 'mfa_challenge_invalid',
+  /** Too many wrong MFA codes for the same challenge: the user must log in again */
+  mfaTooManyAttempts = 'mfa_too_many_attempts',
   notFound = 'resource_not_found',
   forbidden = 'forbidden',
   fileNotFound = 'file_not_found',
@@ -23,6 +27,7 @@ export enum Code {
   CONNECTION_ALREADY_EXIST = 'connection_already_exist',
   firstConnectionFromVpn = 'first_connection_from_vpn',
   ENTITY_ALREADY_EXIST = 'entity_already_exist',
+  tooManyRequest = 'too_many_requests',
 
   // Annotation Error
   failedCheckBalance = 'failed_check_balance',

package/ts/types/Interface/models/IZendeskTicketRead.ts

@@ -0,0 +1,15 @@
+import type { IUser } from './IUser.js';
+
+export interface IZendeskTicketRead {
+  id?: number;
+  idUser: number;
+  idTicket: number;
+  readAt?: Date | null;
+  // Activity snapshot of the Zendesk ticket, refreshed only when `ticketUpdatedAt` changes
+  ticketUpdatedAt?: Date | null;
+  lastPublicCommentAt?: Date | null;
+  lastSupportCommentAt?: Date | null;
+  createdAt?: Date;
+  updatedAt?: Date;
+  user?: IUser;
+}

package/ts/types/index.ts

@@ -290,6 +290,7 @@ export * from './Interface/models/IRevenueSnapshot.js';
 export * from './Interface/models/IEInvoicingEligibilityRequest.js';
 export * from './Interface/models/IUsersHistory.js';
 export * from './Interface/api/teamSystemSignature/index.js';
+export * from './Interface/models/IZendeskTicketRead.js';
 export * from './Interface/models/IEInvoicingKycAndMandate.js';
 export * from './Interface/models/IConnectorTracking.js';
 export * from './Interface/models/IEInvoicing.js';

package/ts/utils/commercialManagement/document.ts

@@ -31,6 +31,7 @@ import ejs from 'ejs';
 import 'dayjs/locale/fr.js';
 import { orderBy, groupBy, sumBy, round, uniq } from 'lodash-es';
 import sanitize from 'sanitize-html';
+import { isHtmlEmpty } from '../isHtml.js';
 
 type brandColorType = {
   primary: string;
@@ -89,7 +90,7 @@ export function generateCommercialDocument(
     paymentLink: payload.paymentLink ?? '#',
     idEstimateInvoiceType,
     title: payload.title ?? null,
-    cgv: payload.cgv ?? null,
+    cgv: isHtmlEmpty(payload.cgv) ? null : payload.cgv,
     // EJS `with` blocks throw a ReferenceError when a variable key is entirely absent from the data object, so seller
     // identity/address fields must always be defined even when the payload omits them.
     name: payload.name ?? null,
@@ -171,28 +172,85 @@ export function generateCommercialDocument(
     : payload?.settings?.freeInvoiceText;
 
   return {
-    header: ejs.render(commonTemplate.header, data),
-    body: ejs.render(bodyTemplate, {
-      ...data,
-      comment:
-        data.comment && typeof data.comment === 'string'
-          ? sanitize(data.comment?.replace(/\n/g, '<br/>'), { allowedTags: ['b', 'i', 'em', 'br', 'strong'] })
-          : null,
-      products: data.products.map((p) => ({
-        ...p,
+    header: ejs.render(commonTemplate.header, data, {}),
+    body: ejs.render(
+      bodyTemplate,
+      {
+        ...data,
+        cgv:
+          data.cgv && typeof data.cgv === 'string'
+            ? sanitize(data.cgv, {
+                allowedTags: [
+                  'b',
+                  'i',
+                  'em',
+                  'br',
+                  'strong',
+                  'p',
+                  'span',
+                  'li',
+                  'ul',
+                  'ol',
+                  'h1',
+                  'h2',
+                  'h3',
+                  'u',
+                  's',
+                  'a',
+                  'blockquote',
+                ],
+                allowedAttributes: {
+                  a: ['href', 'name', 'target', 'data-list'],
+                  li: ['data-list'],
+                  '*': ['class', 'style', 'dir'],
+                },
+                allowedClasses: {
+                  '*': [/^ql-/],
+                },
+                allowedStyles: {
+                  '*': {
+                    color: [/^[a-z]+$/i, /^#(?:[0-9a-f]{3}){1,2}$/i, /^rgb\(\s*\d+\s*,\s*\d+\s*,\s*\d+\s*\)$/i],
+                    'background-color': [
+                      /^[a-z]+$/i,
+                      /^#(?:[0-9a-f]{3}){1,2}$/i,
+                      /^rgb\(\s*\d+\s*,\s*\d+\s*,\s*\d+\s*\)$/i,
+                    ],
+                    'text-align': [/^left$/i, /^right$/i, /^center$/i, /^justify$/i],
+                    'white-space': [/^pre-wrap$/i],
+                  },
+                },
+              })
+            : null,
         comment:
-          p.comment && typeof p.comment === 'string'
-            ? sanitize(p.comment?.replace(/\n/g, '<br/>'), { allowedTags: ['b', 'i', 'em', 'br', 'strong'] })
+          data.comment && typeof data.comment === 'string'
+            ? sanitize(data.comment?.replace(/\n/g, '<br/>'), { allowedTags: ['b', 'i', 'em', 'br', 'strong'] })
             : null,
-        // @ts-expect-error
-        unitFormatted: internationalizationConsistency(locale, p.unitFormatted, 'unit'),
-      })),
-      vats: forcedVats ?? vats,
-    }),
-    footer: ejs.render(commonTemplate.footer, {
-      ...data,
-      freeText: documentFreeText ?? null,
-    }),
+        products: data.products.map((p) => ({
+          ...p,
+          comment:
+            p.comment && typeof p.comment === 'string'
+              ? sanitize(p.comment?.replace(/\n/g, '<br/>'), { allowedTags: ['b', 'i', 'em', 'br', 'strong'] })
+              : null,
+          // @ts-expect-error
+          unitFormatted: internationalizationConsistency(locale, p.unitFormatted, 'unit'),
+        })),
+        vats: forcedVats ?? vats,
+      },
+      {},
+    ),
+    footer: ejs.render(
+      commonTemplate.footer,
+      {
+        ...data,
+        freeText:
+          documentFreeText && typeof documentFreeText === 'string'
+            ? sanitize(documentFreeText?.replace(/\n/g, '<br/>'), {
+                allowedTags: ['b', 'i', 'em', 'br', 'strong', 'p'],
+              })
+            : null,
+      },
+      {},
+    ),
     data,
   };
 }
@@ -227,7 +285,7 @@ export function generateMailHeader(
   const mailTemplate = new CommercialDocumentMailHTML();
 
   return {
-    header: ejs.render(mailTemplate.header, data),
+    header: ejs.render(mailTemplate.header, data, {}),
   };
 }
 

package/ts/utils/commercialManagement/templates/body.ts

@@ -120,7 +120,7 @@ export const bodyTemplate = `<html class="pdf-content">
       <br/><%= languageTemplate.template.common.options.approval %> : <br/><br/><br/><br/>
     <% } %>
 
-    <% if (cgv && (settings && settings.invoiceCgv)) { %>
+    <% if (cgv && settings && settings.invoiceCgv) { %>
       <br><div style="page-break-after:always;"></div>
       <div id="WYSIWYG"><%- cgv %></div>
     <% } %>

package/ts/utils/commercialManagement/templates/common.ts

@@ -334,7 +334,7 @@ export class CommercialDocumentMailHTML {
   </style>
   <div style="background-color: <%= brandColors.primary50 %> !important; color: black; width: calc(100% - 48px); display: grid; border-radius: 16px; padding: 24px;">
     <div style="width: max-content; margin: auto; font-size: 16px; font-family: 'circular std', sans-serif; font-weight: 100; line-height: 140%; position: relative;">
-      <div style="color: black;"><span style="font-weight: 500;"><%- companyName %></span> <%= languageMail.mail.common.send %> 
+      <div style="color: black;"><span style="font-weight: 500;"><%= companyName %></span> <%= languageMail.mail.common.send %> 
       <% if(idEstimateInvoiceType) { %>
         <% if ([${EstimateInvoiceType.FACTURE}, ${EstimateInvoiceType.RESTE}].includes(idEstimateInvoiceType)) { %>
           <%= languageMail.mail.invoice.title %>
@@ -370,7 +370,7 @@ export class CommercialDocumentMailHTML {
             <% } else { %> 
               <%= languageMail.mail.default.subTitle %>
             <% } %>
-            <%- reference %>
+            <%= reference %>
           </div>
           <div style="; color: <%= brandColors.primary500 %>; font-size: 14px;">
             <%= languageMail.mail.common.dueDate %> : <%- dueDateFormatted %>

package/ts/utils/email.ts

@@ -366,25 +366,30 @@ export function generateSignature(params: any): string {
     user.calendlyUrl = calendlyUrl;
   }
 
-  return ejs.render(signatureTemplate, {
-    forceRole,
-    isFacturation: user.roles ? user.roles.some((r: any) => r.id === Role.FACTURATION) : false,
-    isDataOfficer: user.roles ? user.roles.some((r: any) => r.id === Role.DATA_OFFICER) : true,
-    brandName,
-    brandPostalAddress,
-    brandCity,
-    idTypeBrand,
-    commercialName,
-    iban,
-    bic,
-    hostS3,
-    user,
-    roleSignature,
-    mailSignature,
-    phoneSignature: commercialName !== 'Comptalib' && phoneSignature ? phoneSignature.replace(/\s+/gm, ' ') : null,
-    standardPhoneSignature: commercialName !== 'Comptalib' ? standardPhoneSignature.replace(/\s+/gm, ' ') : null,
-    horaires,
-    primaryColor,
-    supportMail,
-  });
+  return ejs.render(
+    signatureTemplate,
+    {
+      forceRole,
+      isFacturation: user.roles ? user.roles.some((r: any) => r.id === Role.FACTURATION) : false,
+      isDataOfficer: user.roles ? user.roles.some((r: any) => r.id === Role.DATA_OFFICER) : true,
+      brandName,
+      brandPostalAddress,
+      brandCity,
+      idTypeBrand,
+      commercialName,
+      iban,
+      bic,
+      hostS3,
+      user,
+      roleSignature,
+      mailSignature,
+      phoneSignature:
+        commercialName !== 'Comptalib' && phoneSignature ? phoneSignature.replace(/\s+/gm, ' ') : null,
+      standardPhoneSignature: commercialName !== 'Comptalib' ? standardPhoneSignature.replace(/\s+/gm, ' ') : null,
+      horaires,
+      primaryColor,
+      supportMail,
+    },
+    {},
+  );
 }

package/ts/utils/isHtml.ts

@@ -7,3 +7,17 @@ export function isHtml(text: string): boolean {
   const htmlRegex = /<([A-Za-z][A-Za-z0-9]*)\b[^>]*>(.*?)<\/\1>/i;
   return htmlRegex.test(text);
 }
+
+/**
+ * Verify if an HTML string is considered empty (e.g. "", "<p><br></p>", "<p>&nbsp;</p>", or empty tags with no visible text/image)
+ * @param html - The HTML string to verify
+ * @returns {boolean}
+ */
+export function isHtmlEmpty(html?: string | null): boolean {
+  if (!html) return true;
+  const textWithoutTags = html
+    .replace(/<(?!\/?img\b)[^>]*>/gi, '')
+    .replace(/&(?:nbsp|#160|#xa0);/gi, '')
+    .trim();
+  return textWithoutTags.length === 0;
+}

package/ts/utils/tests/document.spec.ts

@@ -1,5 +1,6 @@
 import { describe, expect, test } from 'vitest';
 import { generateCommercialDocument } from '../commercialManagement/document.js';
+import { isHtmlEmpty } from '../isHtml.js';
 import { EstimateInvoiceType } from '../../types/Enum/EstimateInvoice.js';
 import { CreateInvoiceDocument } from '../../types/Interface/api/commercialManagement/Create.js';
 import { DiscountType } from '../../types/Enum/CommercialManagement.js';
@@ -24,7 +25,7 @@ const payloadWithoutSellerAddress = {
   reference: '202609/94',
   capital: 0,
   isDraft: false,
-  cgv: '<p><br></p>',
+  cgv: '<p>Test avec une liste</p><ol><li data-list="bullet"><span class="ql-ui"></span>1</li><li data-list="bullet"><span class="ql-ui"></span>2</li></ol></p>',
   logoUrl: null,
   disableVat: false,
   nafCode: null,
@@ -94,7 +95,8 @@ describe('generateCommercialDocument', () => {
   test.each([true, false])(
     'should render CGV HTML only when invoiceCgv is enabled (%s)',
     (invoiceCgv: boolean): void => {
-      const cgv = '<p>Conditions de vente <strong>applicables</strong></p>';
+      const cgv =
+        '<p>Test avec une liste</p><ol><li data-list="bullet"><span class="ql-ui"></span>1</li><li data-list="bullet"><span class="ql-ui"></span>2</li></ol>';
       const payload: CreateInvoiceDocument = {
         ...payloadWithoutSellerAddress,
         cgv,
@@ -117,6 +119,23 @@ describe('generateCommercialDocument', () => {
     expect(result.body).not.toContain('<p>undefined</p>');
   });
 
+  test.each(['<p><br></p>', '<p><br/></p>', '<p></p>', '<p>&nbsp;</p>', '   '])(
+    'should not render CGV or page break when cgv contains empty HTML (%s)',
+    (emptyCgv: string): void => {
+      const payload: CreateInvoiceDocument = {
+        ...payloadWithoutSellerAddress,
+        cgv: emptyCgv,
+        settings: { invoiceCgv: true },
+      };
+
+      const result = generateCommercialDocument(EstimateInvoiceType.FACTURE, payload);
+
+      expect(result.data.cgv).toBeNull();
+      expect(result.body).not.toContain('page-break-after:always;');
+      expect(result.body).not.toContain('id="WYSIWYG"');
+    },
+  );
+
   test('should calculate VAT from rounded line totals after discounts and fractional quantities', () => {
     const payload = {
       ...payloadWithoutSellerAddress,
@@ -209,3 +228,24 @@ describe('generateCommercialDocument', () => {
     expect(result.data.totalTaxIncluded).toBe(-227);
   });
 });
+
+describe('isHtmlEmpty', () => {
+  test.each([
+    [undefined, true],
+    [null, true],
+    ['', true],
+    ['   ', true],
+    ['<p><br></p>', true],
+    ['<p><br/></p>', true],
+    ['<p></p>', true],
+    ['<p>&nbsp;</p>', true],
+    ['<p>&#160;</p>', true],
+    ['<p><br></p><p><br></p>', true],
+    ['<div><p><br></p></div>', true],
+    ['<p>Conditions Générales</p>', false],
+    ['<p><img src="test.png"></p>', false],
+    ['<img src="test.png" />', false],
+  ])('isHtmlEmpty(%j) should return %s', (input, expected) => {
+    expect(isHtmlEmpty(input as string)).toBe(expected);
+  });
+});

package/ts/utils/transforms/array.transform.ts

@@ -0,0 +1,35 @@
+import { Transform } from 'class-transformer';
+
+const valueToStringArray = (value: any) => {
+  if (value === null || value === undefined || value === '') {
+    return undefined;
+  }
+  if (Array.isArray(value)) {
+    return value.map((v) => String(v).trim());
+  }
+  return String(value)
+    .split(',')
+    .map((v) => v.trim())
+    .filter((v) => v !== '');
+};
+
+// Accepts repeated query params (`a=x&a=y`) as well as comma-separated values (`a=x,y`).
+const ToStringArray = () => {
+  const toPlain = Transform(
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return
+    ({ value }) => value,
+    {
+      toPlainOnly: true,
+    },
+  );
+  const toClass = (target: any, key: string) =>
+    Transform(({ obj }) => valueToStringArray(obj[key]), {
+      toClassOnly: true,
+    })(target, key);
+  return (target: any, key: string) => {
+    toPlain(target, key);
+    toClass(target, key);
+  };
+};
+
+export { ToStringArray };