@sigloch/contracts 3.2.0 → 4.0.0

package/dist/se/uc-quality-rules.js

@@ -111,13 +111,15 @@ export function uc06HasPrecondition(graph) {
 // Aggregated
 // ---------------------------------------------------------------------------
 export const UC_RULES = [
-    { id: 'UC-01', name: 'UC has requirements', severity: 'error', evaluate: uc01HasRequirements },
-    { id: 'UC-02', name: 'UC has actor', severity: 'error', evaluate: uc02HasActor },
-    { id: 'UC-03', name: 'UC has scenario', severity: 'warning', evaluate: uc03HasScenario },
-    { id: 'UC-04', name: 'UC has goal', severity: 'warning', evaluate: uc04GoalDefined },
-    { id: 'UC-05', name: 'UC has postcondition', severity: 'info', evaluate: uc05HasPostcondition },
-    { id: 'UC-06', name: 'UC has precondition', severity: 'info', evaluate: uc06HasPrecondition },
+    { id: 'UC-01', name: 'UC has requirements', severity: 'error', evaluate: uc01HasRequirements, domain: ['UC'] },
+    { id: 'UC-02', name: 'UC has actor', severity: 'error', evaluate: uc02HasActor, domain: ['UC'] },
+    { id: 'UC-03', name: 'UC has scenario', severity: 'warning', evaluate: uc03HasScenario, domain: ['UC'] },
+    { id: 'UC-04', name: 'UC has goal', severity: 'warning', evaluate: uc04GoalDefined, domain: ['UC'] },
+    { id: 'UC-05', name: 'UC has postcondition', severity: 'info', evaluate: uc05HasPostcondition, domain: ['UC'] },
+    { id: 'UC-06', name: 'UC has precondition', severity: 'info', evaluate: uc06HasPrecondition, domain: ['UC'] },
 ];
-export function evaluateUCRules(graph) {
-    return UC_RULES.flatMap(rule => rule.evaluate(graph));
+// CR-SM-236: `policy` wird durchgereicht, auch wo diese Familie heute keine Schwelle hat —
+// ein Sonderweg je Familie waere genau der zweite Pfad, den der Regelsatz verbietet.
+export function evaluateUCRules(graph, policy) {
+    return UC_RULES.flatMap(rule => rule.evaluate(graph, policy));
 }

package/dist/se/view-rules.d.ts

@@ -1,11 +1,7 @@
-/**
- * CR-184: View-related quality rules.
- * VR-01: TEST without testResult attribute (info).
- * CL-01: ACTOR without UCs in at least 2 distinct operatingModes (warning).
- */
 import type { OntologyGraph } from './ontology.js';
 import type { RuleViolation, RuleDefinition } from './rules.js';
+import type { MetricPolicy } from './policy.js';
 export declare function vr01TestNoResult(graph: OntologyGraph): RuleViolation[];
 export declare function cl01ConopsCompleteness(graph: OntologyGraph): RuleViolation[];
 export declare const VIEW_RULES: RuleDefinition[];
-export declare function evaluateViewRules(graph: OntologyGraph): RuleViolation[];
+export declare function evaluateViewRules(graph: OntologyGraph, policy: MetricPolicy): RuleViolation[];

package/dist/se/view-rules.js

@@ -1,15 +1,40 @@
+/**
+ * CR-184: View-related quality rules.
+ * VR-01: TEST with a testRefs entry that has no result (info).
+ * CL-01: ACTOR without UCs in at least 2 distinct operatingModes (warning).
+ */
+import { TestRefsSchema } from './ontology.js';
 // ---------------------------------------------------------------------------
-// VR-01: TEST without testResult
+// VR-01: ein testRefs-Eintrag ohne Ergebnis
+//
+// CR-SM-231b: liest das Ergebnis PRO EINTRAG statt am Knoten. Vorher hing `testResult` am
+// TEST-Knoten — bei n Eintraegen mehrdeutig: laeuft eine Abnahme als vitest UND playwright,
+// kann ein einzelnes Ergebnis nicht sagen, welcher Lauf gemeint ist. Die Meldung nennt jetzt
+// die Dateien ohne Ergebnis, nicht nur den Knoten.
+//
+// Ein TEST ohne gueltige Bindung faellt R-19 zur Last, nicht hier: sonst meldeten beide
+// Regeln denselben Sachverhalt (Presence/Resolution-Trennung).
 // ---------------------------------------------------------------------------
 export function vr01TestNoResult(graph) {
-    return graph.elements
-        .filter(e => e.type === 'TEST' && e.attributes?.['testResult'] == null)
-        .map(e => ({
-        rule_id: 'VR-01',
-        severity: 'info',
-        element_id: e.id,
-        message: `${e.id} has no testResult — assumed pending`,
-    }));
+    const violations = [];
+    for (const el of graph.elements) {
+        if (el.type !== 'TEST')
+            continue;
+        const parsed = TestRefsSchema.safeParse(el.attributes?.testRefs);
+        if (!parsed.success)
+            continue; // keine/ungueltige Bindung → R-19-Gebiet
+        const pending = parsed.data.filter(ref => ref.result === undefined);
+        if (pending.length === 0)
+            continue;
+        violations.push({
+            rule_id: 'VR-01',
+            severity: 'info',
+            element_id: el.id,
+            message: `${el.id} has ${pending.length} of ${parsed.data.length} testRefs entries without a result — assumed pending: ${pending.map(r => r.file).join(', ')}`,
+            fix_hint: 'Record the run outcome on the entry (result, ranAt, evidence) — a binding without a result is not evidence',
+        });
+    }
+    return violations;
 }
 // ---------------------------------------------------------------------------
 // CL-01: ACTOR without UCs in >= 2 distinct operatingModes
@@ -48,9 +73,11 @@ export function cl01ConopsCompleteness(graph) {
 // Aggregated array & convenience runner
 // ---------------------------------------------------------------------------
 export const VIEW_RULES = [
-    { id: 'VR-01', name: 'TestNoResult', severity: 'info', evaluate: vr01TestNoResult },
-    { id: 'CL-01', name: 'ConopsCompleteness', severity: 'warning', evaluate: cl01ConopsCompleteness },
+    { id: 'VR-01', name: 'TestNoResult', severity: 'info', evaluate: vr01TestNoResult, domain: ['TEST'] },
+    { id: 'CL-01', name: 'ConopsCompleteness', severity: 'warning', evaluate: cl01ConopsCompleteness, domain: ['ACTOR'] },
 ];
-export function evaluateViewRules(graph) {
-    return VIEW_RULES.flatMap(rule => rule.evaluate(graph));
+// CR-SM-236: `policy` wird durchgereicht, auch wo diese Familie heute keine Schwelle hat —
+// ein Sonderweg je Familie waere genau der zweite Pfad, den der Regelsatz verbietet.
+export function evaluateViewRules(graph, policy) {
+    return VIEW_RULES.flatMap(rule => rule.evaluate(graph, policy));
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sigloch/contracts",
-  "version": "3.2.0",
+  "version": "4.0.0",
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -28,6 +28,7 @@
     "prepublishOnly": "npm run build && npm run test"
   },
   "dependencies": {
+    "@sigloch/contracts": "^4.0.0",
     "zod": "^4.3.6"
   },
   "license": "MIT",