@sigil-dev/compiler 0.9.1 → 0.9.3

package/test/containsSignal.test.ts

@@ -1,288 +1,288 @@
-import { describe, expect, it } from "bun:test";
-import { parseExpression } from "@babel/parser";
-import type { Expression } from "@babel/types";
-import { containsSignal } from "../src/babel/jsx/utils";
-
-// Our containsSignal is so jank it needs a dedicated test suite.
-
-// ── helpers ──────────────────────────────────────────────────────────────────
-
-function parse(code: string): Expression {
-	return parseExpression(code, {
-		plugins: ["typescript", "jsx"],
-		strictMode: false,
-	}) as Expression;
-}
-
-/** Signals in scope for all tests */
-const SIG = new Set(["count", "name", "items", "user", "flag"]);
-
-function yes(code: string, msg?: string) {
-	it(msg ?? `contains signal: ${code}`, () => {
-		expect(containsSignal(parse(code), SIG)).toBe(true);
-	});
-}
-
-function no(code: string, msg?: string) {
-	it(msg ?? `no signal:       ${code}`, () => {
-		expect(containsSignal(parse(code), SIG)).toBe(false);
-	});
-}
-
-// ── Identifier ───────────────────────────────────────────────────────────────
-
-describe("Identifier", () => {
-	yes("count");
-	yes("name");
-	no("foo");
-	no("bar");
-	no("unrelated");
-});
-
-// ── CallExpression ───────────────────────────────────────────────────────────
-
-describe("CallExpression — callee", () => {
-	yes("count()");
-	yes("name()");
-	no("foo()");
-	no("Math.random()");
-});
-
-describe("CallExpression — arguments", () => {
-	yes("foo(count())");
-	yes("foo(bar, count())");
-	yes("foo(1, 2, count())");
-	yes("foo(name(), bar)");
-	no("foo(bar, baz)");
-	no("foo(1, 2, 3)");
-});
-
-describe("CallExpression — nested callee", () => {
-	yes("count()()"); // count is in SIG, callee of outer call
-	yes("foo(bar(count()))"); // signal buried in nested argument
-	no("foo(bar(baz()))");
-	no("getSignal()()"); // getSignal not in SIG — correctly false
-});
-
-// ── MemberExpression ─────────────────────────────────────────────────────────
-
-describe("MemberExpression", () => {
-	yes("count().value");
-	yes("count().nested.deep");
-	yes("name().length");
-	no("foo.bar");
-	no("obj.prop");
-	no("Math.PI");
-	no("foo.bar.baz");
-});
-
-// ── OptionalMemberExpression ─────────────────────────────────────────────────
-
-describe("OptionalMemberExpression", () => {
-	yes("count()?.value");
-	yes("count()?.foo?.bar");
-	yes("name()?.length");
-	no("foo?.bar");
-	no("obj?.prop");
-	no("foo?.bar?.baz");
-});
-
-// ── OptionalCallExpression ───────────────────────────────────────────────────
-
-describe("OptionalCallExpression", () => {
-	yes("count?.()");
-	yes("foo?.(count())");
-	yes("foo?.(bar, count())");
-	no("foo?.()");
-	no("foo?.(bar, baz)");
-});
-
-// ── BinaryExpression ─────────────────────────────────────────────────────────
-
-describe("BinaryExpression", () => {
-	yes("count() + 1");
-	yes("1 + count()");
-	yes("count() > 0");
-	yes("count() === name()");
-	yes("foo + count()");
-	no("1 + 2");
-	no("foo + bar");
-	no("'a' + 'b'");
-});
-
-// ── LogicalExpression ────────────────────────────────────────────────────────
-
-describe("LogicalExpression", () => {
-	yes("count() && foo");
-	yes("foo && count()");
-	yes("count() || name()");
-	yes("foo ?? count()");
-	no("foo && bar");
-	no("a || b");
-	no("null ?? 'default'");
-});
-
-// ── ConditionalExpression ────────────────────────────────────────────────────
-
-describe("ConditionalExpression", () => {
-	yes("count() ? 'a' : 'b'", "signal in test");
-	yes("foo ? count() : 'b'", "signal in consequent");
-	yes("foo ? 'a' : count()", "signal in alternate");
-	yes("count() ? name() : 'b'", "signal in test and consequent");
-	no("foo ? 'a' : 'b'");
-	no("true ? 1 : 0");
-});
-
-// ── UnaryExpression ──────────────────────────────────────────────────────────
-
-describe("UnaryExpression", () => {
-	yes("!count()");
-	yes("-count()");
-	yes("typeof count()");
-	no("!foo");
-	no("-1");
-	no("typeof foo");
-});
-
-// ── TemplateLiteral ──────────────────────────────────────────────────────────
-
-describe("TemplateLiteral", () => {
-	yes("`${count()}`");
-	yes("`hello ${name()}`");
-	yes("`${foo} ${count()}`");
-	yes("`${count()} and ${name()}`");
-	no("`hello world`");
-	no("`${foo}`");
-	no("`${foo} ${bar}`");
-});
-
-// ── ArrayExpression ──────────────────────────────────────────────────────────
-
-describe("ArrayExpression", () => {
-	yes("[count()]");
-	yes("[foo, count()]");
-	yes("[1, 2, count()]");
-	yes("[...count()]");
-	no("[]");
-	no("[1, 2, 3]");
-	no("[foo, bar]");
-	// sparse arrays have null holes
-	no("[,,,]", "sparse array holes");
-});
-
-// ── ObjectExpression ─────────────────────────────────────────────────────────
-
-describe("ObjectExpression", () => {
-	yes("({ a: count() })");
-	yes("({ a: foo, b: count() })");
-	yes("({ ...count() })");
-	yes("({ [name()]: 'val' })", "computed key with signal");
-	no("({})");
-	no("({ a: 1 })");
-	no("({ a: foo, b: bar })");
-	no("({ ...foo })");
-});
-
-// ── SequenceExpression ───────────────────────────────────────────────────────
-
-describe("SequenceExpression", () => {
-	yes("(foo, count())");
-	yes("(count(), foo)");
-	yes("(a, b, count())");
-	no("(a, b)");
-	no("(1, 2, 3)");
-});
-
-// ── AssignmentExpression ─────────────────────────────────────────────────────
-
-describe("AssignmentExpression", () => {
-	// only RHS matters for reactivity — LHS is where you're writing to
-	yes("x = count()");
-	yes("x += count()");
-	no("x = foo");
-	no("x = 1");
-});
-
-// ── SpreadElement ────────────────────────────────────────────────────────────
-
-describe("SpreadElement — inside array/call", () => {
-	yes("[...count()]");
-	yes("foo(...count())");
-	no("[...foo]");
-	no("foo(...bar)");
-});
-
-// ── ArrowFunctionExpression ──────────────────────────────────────────────────
-// signals inside a function body are captured at call time, not bind time —
-// making the attribute reactive would re-assign the handler on every signal change
-
-describe("ArrowFunctionExpression — must NOT traverse body", () => {
-	no("() => count()");
-	no("(x) => count() + x");
-	no("() => { return count(); }");
-	no("(e) => { count(); }");
-});
-
-// ── FunctionExpression ───────────────────────────────────────────────────────
-
-describe("FunctionExpression — must NOT traverse body", () => {
-	no("function() { return count(); }");
-	no("function handler() { count(); }");
-});
-
-// ── Literals (always false) ──────────────────────────────────────────────────
-
-describe("Literals", () => {
-	no("1");
-	no("'hello'");
-	no("true");
-	no("null");
-	no("/regex/");
-});
-
-// ── Deep nesting ─────────────────────────────────────────────────────────────
-
-describe("Deep nesting", () => {
-	yes("foo(bar(baz(count())))");
-	yes("a && b ? c + count() : d");
-	yes("`prefix_${foo ? count() : bar}`");
-	yes("[{ a: count() }]");
-	yes("({ arr: [1, count()] })");
-	yes("foo?.bar?.(count())");
-	no("foo(bar(baz(qux())))");
-	no("a && b ? c + d : e");
-});
-
-// ── Multiple signals ─────────────────────────────────────────────────────────
-
-describe("Multiple signals", () => {
-	yes("count() + name()");
-	yes("[count(), name(), items()]");
-	yes("user()?.profile ?? name()");
-	yes("flag() ? count() : name()");
-});
-
-// ── Non-signal identifiers that look similar ─────────────────────────────────
-
-describe("Near-miss identifiers", () => {
-	no("counter"); // not "count"
-	no("counted");
-	no("names"); // not "name"
-	no("userCount");
-	no("flagged");
-	no("itemsList");
-});
-
-// ── null/undefined safety ────────────────────────────────────────────────────
-
-describe("null/undefined guard", () => {
-	it("returns false for null input", () => {
-		expect(containsSignal(null as any, SIG)).toBe(false);
-	});
-	it("returns false for undefined input", () => {
-		expect(containsSignal(undefined as any, SIG)).toBe(false);
-	});
-	it("empty signal set never matches", () => {
-		expect(containsSignal(parse("count()"), new Set())).toBe(false);
-	});
-});
+import { describe, expect, it } from "bun:test";
+import { parseExpression } from "@babel/parser";
+import type { Expression } from "@babel/types";
+import { containsSignal } from "../src/babel/jsx/utils";
+
+// Our containsSignal is so jank it needs a dedicated test suite.
+
+// ── helpers ──────────────────────────────────────────────────────────────────
+
+function parse(code: string): Expression {
+	return parseExpression(code, {
+		plugins: ["typescript", "jsx"],
+		strictMode: false,
+	}) as Expression;
+}
+
+/** Signals in scope for all tests */
+const SIG = new Set(["count", "name", "items", "user", "flag"]);
+
+function yes(code: string, msg?: string) {
+	it(msg ?? `contains signal: ${code}`, () => {
+		expect(containsSignal(parse(code), SIG)).toBe(true);
+	});
+}
+
+function no(code: string, msg?: string) {
+	it(msg ?? `no signal:       ${code}`, () => {
+		expect(containsSignal(parse(code), SIG)).toBe(false);
+	});
+}
+
+// ── Identifier ───────────────────────────────────────────────────────────────
+
+describe("Identifier", () => {
+	yes("count");
+	yes("name");
+	no("foo");
+	no("bar");
+	no("unrelated");
+});
+
+// ── CallExpression ───────────────────────────────────────────────────────────
+
+describe("CallExpression — callee", () => {
+	yes("count()");
+	yes("name()");
+	no("foo()");
+	no("Math.random()");
+});
+
+describe("CallExpression — arguments", () => {
+	yes("foo(count())");
+	yes("foo(bar, count())");
+	yes("foo(1, 2, count())");
+	yes("foo(name(), bar)");
+	no("foo(bar, baz)");
+	no("foo(1, 2, 3)");
+});
+
+describe("CallExpression — nested callee", () => {
+	yes("count()()"); // count is in SIG, callee of outer call
+	yes("foo(bar(count()))"); // signal buried in nested argument
+	no("foo(bar(baz()))");
+	no("getSignal()()"); // getSignal not in SIG — correctly false
+});
+
+// ── MemberExpression ─────────────────────────────────────────────────────────
+
+describe("MemberExpression", () => {
+	yes("count().value");
+	yes("count().nested.deep");
+	yes("name().length");
+	no("foo.bar");
+	no("obj.prop");
+	no("Math.PI");
+	no("foo.bar.baz");
+});
+
+// ── OptionalMemberExpression ─────────────────────────────────────────────────
+
+describe("OptionalMemberExpression", () => {
+	yes("count()?.value");
+	yes("count()?.foo?.bar");
+	yes("name()?.length");
+	no("foo?.bar");
+	no("obj?.prop");
+	no("foo?.bar?.baz");
+});
+
+// ── OptionalCallExpression ───────────────────────────────────────────────────
+
+describe("OptionalCallExpression", () => {
+	yes("count?.()");
+	yes("foo?.(count())");
+	yes("foo?.(bar, count())");
+	no("foo?.()");
+	no("foo?.(bar, baz)");
+});
+
+// ── BinaryExpression ─────────────────────────────────────────────────────────
+
+describe("BinaryExpression", () => {
+	yes("count() + 1");
+	yes("1 + count()");
+	yes("count() > 0");
+	yes("count() === name()");
+	yes("foo + count()");
+	no("1 + 2");
+	no("foo + bar");
+	no("'a' + 'b'");
+});
+
+// ── LogicalExpression ────────────────────────────────────────────────────────
+
+describe("LogicalExpression", () => {
+	yes("count() && foo");
+	yes("foo && count()");
+	yes("count() || name()");
+	yes("foo ?? count()");
+	no("foo && bar");
+	no("a || b");
+	no("null ?? 'default'");
+});
+
+// ── ConditionalExpression ────────────────────────────────────────────────────
+
+describe("ConditionalExpression", () => {
+	yes("count() ? 'a' : 'b'", "signal in test");
+	yes("foo ? count() : 'b'", "signal in consequent");
+	yes("foo ? 'a' : count()", "signal in alternate");
+	yes("count() ? name() : 'b'", "signal in test and consequent");
+	no("foo ? 'a' : 'b'");
+	no("true ? 1 : 0");
+});
+
+// ── UnaryExpression ──────────────────────────────────────────────────────────
+
+describe("UnaryExpression", () => {
+	yes("!count()");
+	yes("-count()");
+	yes("typeof count()");
+	no("!foo");
+	no("-1");
+	no("typeof foo");
+});
+
+// ── TemplateLiteral ──────────────────────────────────────────────────────────
+
+describe("TemplateLiteral", () => {
+	yes("`${count()}`");
+	yes("`hello ${name()}`");
+	yes("`${foo} ${count()}`");
+	yes("`${count()} and ${name()}`");
+	no("`hello world`");
+	no("`${foo}`");
+	no("`${foo} ${bar}`");
+});
+
+// ── ArrayExpression ──────────────────────────────────────────────────────────
+
+describe("ArrayExpression", () => {
+	yes("[count()]");
+	yes("[foo, count()]");
+	yes("[1, 2, count()]");
+	yes("[...count()]");
+	no("[]");
+	no("[1, 2, 3]");
+	no("[foo, bar]");
+	// sparse arrays have null holes
+	no("[,,,]", "sparse array holes");
+});
+
+// ── ObjectExpression ─────────────────────────────────────────────────────────
+
+describe("ObjectExpression", () => {
+	yes("({ a: count() })");
+	yes("({ a: foo, b: count() })");
+	yes("({ ...count() })");
+	yes("({ [name()]: 'val' })", "computed key with signal");
+	no("({})");
+	no("({ a: 1 })");
+	no("({ a: foo, b: bar })");
+	no("({ ...foo })");
+});
+
+// ── SequenceExpression ───────────────────────────────────────────────────────
+
+describe("SequenceExpression", () => {
+	yes("(foo, count())");
+	yes("(count(), foo)");
+	yes("(a, b, count())");
+	no("(a, b)");
+	no("(1, 2, 3)");
+});
+
+// ── AssignmentExpression ─────────────────────────────────────────────────────
+
+describe("AssignmentExpression", () => {
+	// only RHS matters for reactivity — LHS is where you're writing to
+	yes("x = count()");
+	yes("x += count()");
+	no("x = foo");
+	no("x = 1");
+});
+
+// ── SpreadElement ────────────────────────────────────────────────────────────
+
+describe("SpreadElement — inside array/call", () => {
+	yes("[...count()]");
+	yes("foo(...count())");
+	no("[...foo]");
+	no("foo(...bar)");
+});
+
+// ── ArrowFunctionExpression ──────────────────────────────────────────────────
+// signals inside a function body are captured at call time, not bind time —
+// making the attribute reactive would re-assign the handler on every signal change
+
+describe("ArrowFunctionExpression — must NOT traverse body", () => {
+	no("() => count()");
+	no("(x) => count() + x");
+	no("() => { return count(); }");
+	no("(e) => { count(); }");
+});
+
+// ── FunctionExpression ───────────────────────────────────────────────────────
+
+describe("FunctionExpression — must NOT traverse body", () => {
+	no("function() { return count(); }");
+	no("function handler() { count(); }");
+});
+
+// ── Literals (always false) ──────────────────────────────────────────────────
+
+describe("Literals", () => {
+	no("1");
+	no("'hello'");
+	no("true");
+	no("null");
+	no("/regex/");
+});
+
+// ── Deep nesting ─────────────────────────────────────────────────────────────
+
+describe("Deep nesting", () => {
+	yes("foo(bar(baz(count())))");
+	yes("a && b ? c + count() : d");
+	yes("`prefix_${foo ? count() : bar}`");
+	yes("[{ a: count() }]");
+	yes("({ arr: [1, count()] })");
+	yes("foo?.bar?.(count())");
+	no("foo(bar(baz(qux())))");
+	no("a && b ? c + d : e");
+});
+
+// ── Multiple signals ─────────────────────────────────────────────────────────
+
+describe("Multiple signals", () => {
+	yes("count() + name()");
+	yes("[count(), name(), items()]");
+	yes("user()?.profile ?? name()");
+	yes("flag() ? count() : name()");
+});
+
+// ── Non-signal identifiers that look similar ─────────────────────────────────
+
+describe("Near-miss identifiers", () => {
+	no("counter"); // not "count"
+	no("counted");
+	no("names"); // not "name"
+	no("userCount");
+	no("flagged");
+	no("itemsList");
+});
+
+// ── null/undefined safety ────────────────────────────────────────────────────
+
+describe("null/undefined guard", () => {
+	it("returns false for null input", () => {
+		expect(containsSignal(null as any, SIG)).toBe(false);
+	});
+	it("returns false for undefined input", () => {
+		expect(containsSignal(undefined as any, SIG)).toBe(false);
+	});
+	it("empty signal set never matches", () => {
+		expect(containsSignal(parse("count()"), new Set())).toBe(false);
+	});
+});