@sig-net/midnight 0.26.0-rc.1 → 0.26.0-rc.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sig-net/midnight",
-  "version": "0.26.0-rc.1",
+  "version": "0.26.0-rc.2",
   "repository": {
     "type": "git",
     "url": "https://github.com/sig-net/midnight-integration",
@@ -49,7 +49,7 @@
     "@midnight-ntwrk/compact-runtime": "0.18.0-rc.1",
     "@midnight-ntwrk/midnight-js-types": "5.0.0-beta.6",
     "@noble/curves": "^2.2.0",
-    "@sig-net/midnight-serde": "^0.26.0-rc.1",
+    "@sig-net/midnight-serde": "^0.26.0-rc.2",
     "ethers": "^6.17.0"
   },
   "devDependencies": {

package/src/Signet.compact

@@ -8,10 +8,10 @@
 //                          Distributed MPC network to execute arbitrary transactions on foreign
 //                          blockchains.
 //    - Signet singleton: a single contract on the Midnight blockchain through which clients notify
-//                        the MPC of signature requests, and through which the MPC posts back
-//                        signatures and signed attestations of foreign executions. Each post is
-//                        emitted as a contract event (the execution outputs themselves travel off
-//                        chain).
+//                        the MPC of signature requests.
+//    - Signet responder: the contract through which the MPC posts back signatures and signed
+//                        attestations of foreign executions, each emitted as a contract event
+//                        (the execution outputs themselves travel off chain).
 //
 //  Usage:
 //   // Import this module at the start of a contract (resolved through node_modules via COMPACT_PATH):
@@ -30,7 +30,7 @@
 //    (executed, failed or unviable).
 //
 //  The V1 suffix marks the wire and hash-domain artefacts of protocol version 1 (the structs the
-//  ledger stores and the singleton emits, and the circuits that hash, verify or construct them).
+//  ledger stores and the signet contracts emit, and the circuits that hash, verify or construct them).
 //  Vocabulary shared across versions (RequestId, OutputKind, Signature, the enums, the transaction
 //  parameter structs, which TxParamType tags) and the version-tagged notification carry no suffix.
 //
@@ -42,13 +42,13 @@
 // 2. MPC polls the Signet singleton contract's events for SignBidirectionalEventNotifications and
 //    uses each one to look the declared SignBidirectionalEvent signature request up in the named
 //    client's own ledger. It generates the signature and posts a SignatureRespondedEvent (the requested
-//    signature) through the Signet singleton, which emits it as a contract event.
-// 3. Client polls the Signet singleton contract's SignatureRespondedEvent events, identifying the response
+//    signature) through the Signet responder, which emits it as a contract event.
+// 3. Client polls the Signet responder contract's SignatureRespondedEvent events, identifying the response
 //    associated with their request by RequestId. Clients validate the signature is correct by checking with
 //    the requested signing key. Then it broadcasts the signed txn to the target chain.
 // 4. MPC observes the txn's outcome in a final block on the target chain (executed, failed,
 //    or unviable when another request's transaction took its nonce) and posts a
-//    RespondBidirectionalEvent attestation through the Signet singleton, which emits it as a
+//    RespondBidirectionalEvent attestation through the Signet responder, which emits it as a
 //    contract event beside the request id.
 //    The client polls its request's posts and takes the first one that verifies over the request id,
 //    block height, output kind and output. The client obtains the execution output off chain (for EVM: the mined
@@ -322,10 +322,10 @@ module Signet {
   }
 
   // Counterpart to SignBidirectionalEvent: the MPC generated signature a request asked for.
-  // Posted by the MPC through the Signet singleton for clients to extract and build a
+  // Posted by the MPC through the Signet responder for clients to extract and build a
   // signed transaction from.
   export struct SignatureRespondedEventV1 {
-    // The request this signature answers. Routing data: the singleton emits it
+    // The request this signature answers. Routing data: the responder emits it
     // unverified, and a reader proves the signature against the request's own key.
     requestId: RequestId;
     // The requested signature over the transaction the request describes.
@@ -349,7 +349,7 @@ module Signet {
   // (verifyRespondBidirectionalAttestationV1), and the output checks against the
   // event's length and hash (verifyAttestedOutputV1). The signature
   // is the ONLY thing that distinguishes a genuine post from garbage: the
-  // singleton emits every post unverified.
+  // responder emits every post unverified.
   export struct RespondBidirectionalEventV1 {
     // The request this attestation answers. Signed into the digest: a verified
     // post settles exactly the request it names, so a client consumes this id
@@ -433,7 +433,8 @@ module Signet {
   // requestId, so a client MUST consume that request and no other. An s that
   // reduces to 0 mod the curve order aborts the circuit rather than returning
   // false, so sift candidate posts off chain first
-  // (verifyRespondBidirectionalAttestation).
+  // (verifyRespondBidirectionalAttestation). The identity point as
+  // mpcResponseKey always returns false.
   export pure circuit verifyRespondBidirectionalAttestationV1(
     respondBidirectionalEvent: RespondBidirectionalEventV1,
     mpcResponseKey: Secp256k1Point
@@ -446,7 +447,7 @@ module Signet {
       respondBidirectionalEvent.outputHash,
     );
 
-    return secp256k1EcdsaVerify(
+    const signatureVerifies = secp256k1EcdsaVerify(
       digest,
       Secp256k1EcdsaSignature {
         r: respondBidirectionalEvent.signature.bigR.x as Secp256k1Scalar,
@@ -454,6 +455,7 @@ module Signet {
       },
       mpcResponseKey
     );
+    return mpcResponseKey != default<Secp256k1Point> && signatureVerifies;
   }
 
   // Whether serializedOutput is the output an attestation declares: its width
@@ -478,7 +480,7 @@ module Signet {
   // against the event's length and hash) and the event's signature verifies
   // (verifyRespondBidirectionalAttestationV1, whose byte-order and abort
   // contract applies here too). Client contracts run this before consuming
-  // outputs, as the singleton emits responses unverified. The caller supplies
+  // outputs, as the responder emits responses unverified. The caller supplies
   // serializedOutput at its exact unpadded width.
   export pure circuit verifyRespondBidirectionalEventV1<#serializedOutputLength>(
     serializedOutput: Bytes<serializedOutputLength>,