@sienklogic/plan-build-run 2.47.0 → 2.48.0

package/plugins/pbr/skills/milestone/SKILL.md

@@ -784,58 +784,8 @@ Tags (complete only):
 
 ## Edge Cases
 
-### No ROADMAP.md exists
-- For `new`: Create one from scratch (this is a fresh start)
-- For others, display:
-```
-╔══════════════════════════════════════════════════════════════╗
-║  ERROR                                                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-No roadmap found.
-
-**To fix:** Run `/pbr:begin` or `/pbr:milestone new` first.
-```
-
-### Milestone has no phases
-Display:
-```
-╔══════════════════════════════════════════════════════════════╗
-║  ERROR                                                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-No phases found for this milestone.
-
-**To fix:**
-- For `complete`: Nothing to complete — add phases first.
-- For `audit`: Nothing to audit — build phases first.
-```
-
-### Audit finds no gaps
-- Status: PASSED
-- Skip the recommendations section
-- Suggest proceeding to complete
-
-### Version already exists (tag collision)
-Display:
-```
-╔══════════════════════════════════════════════════════════════╗
-║  ERROR                                                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-Git tag {version} already exists.
-
-**To fix:** Use a different version number (e.g., {version}.1).
-```
-Ask for alternative via AskUserQuestion.
-
-### Partially verified milestone
-- `complete` warns but allows proceeding with user confirmation
-- `audit` treats unverified phases as gaps
-
-### Large milestone (8+ phases)
-- `audit` may take longer due to integration checking
-- Warn: "This milestone has {count} phases. The audit may take a few minutes."
+For all edge case handling, see `skills/milestone/templates/edge-cases.md`.
+Key scenarios: no ROADMAP.md, no phases, no gaps found, version collision, partially verified, large milestone (8+ phases).
 
 ---
 

package/plugins/pbr/skills/milestone/templates/edge-cases.md

@@ -0,0 +1,54 @@
+# Milestone Edge Cases
+
+## No ROADMAP.md exists
+- For `new`: Create one from scratch (this is a fresh start)
+- For others, display:
+```
+╔══════════════════════════════════════════════════════════════╗
+║  ERROR                                                       ║
+╚══════════════════════════════════════════════════════════════╝
+
+No roadmap found.
+
+**To fix:** Run `/pbr:begin` or `/pbr:milestone new` first.
+```
+
+## Milestone has no phases
+Display:
+```
+╔══════════════════════════════════════════════════════════════╗
+║  ERROR                                                       ║
+╚══════════════════════════════════════════════════════════════╝
+
+No phases found for this milestone.
+
+**To fix:**
+- For `complete`: Nothing to complete — add phases first.
+- For `audit`: Nothing to audit — build phases first.
+```
+
+## Audit finds no gaps
+- Status: PASSED
+- Skip the recommendations section
+- Suggest proceeding to complete
+
+## Version already exists (tag collision)
+Display:
+```
+╔══════════════════════════════════════════════════════════════╗
+║  ERROR                                                       ║
+╚══════════════════════════════════════════════════════════════╝
+
+Git tag {version} already exists.
+
+**To fix:** Use a different version number (e.g., {version}.1).
+```
+Ask for alternative via AskUserQuestion.
+
+## Partially verified milestone
+- `complete` warns but allows proceeding with user confirmation
+- `audit` treats unverified phases as gaps
+
+## Large milestone (8+ phases)
+- `audit` may take longer due to integration checking
+- Warn: "This milestone has {count} phases. The audit may take a few minutes."

package/plugins/pbr/skills/plan/SKILL.md

@@ -256,13 +256,13 @@ After the researcher completes, check the Task() output for a completion marker:
 
 Before spawning the planner, scan `.planning/seeds/` for seeds whose trigger matches the current phase:
 
-1. Glob for `.planning/seeds/*.md`
-2. For each seed file, read its frontmatter and check the `trigger` field
-3. A seed matches if ANY of these are true:
-   - `trigger` equals the phase slug (e.g., `trigger: authentication`) — **preferred**
-   - `trigger` is a substring of the phase directory name (e.g., `trigger: auth` matches `03-authentication`)
-   - `trigger` equals the current phase number as integer (e.g., `trigger: 3`) — backward compatible but NOT recommended for new seeds (breaks with decimal phases like 3.1)
-   - `trigger` equals `*` (always matches)
+1. Run seed matcher CLI:
+   ```bash
+   node ${CLAUDE_PLUGIN_ROOT}/scripts/pbr-tools.js seeds match {phase-slug} {phase-number}
+   ```
+   Returns `{ matched: [{ name, description, trigger, path }] }`.
+2. If `matched` is empty: proceed silently.
+3. If `matched` is non-empty: present to user (see step 4 below).
 4. If matching seeds are found, present them to the user:
    ```
    Found {N} seeds related to Phase {NN}:
@@ -649,28 +649,10 @@ Read `skills/plan/templates/gap-closure-prompt.md.tmpl` and use it as the prompt
 ## Error Handling
 
 ### Phase not found
-If the specified phase doesn't exist in ROADMAP.md, display:
-```
-╔══════════════════════════════════════════════════════════════╗
-║  ERROR                                                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-Phase {N} not found in ROADMAP.md.
-
-**To fix:** Run `/pbr:status` to see available phases.
-```
+If the specified phase doesn't exist in ROADMAP.md, display a branded error box — see `skills/shared/error-reporting.md`, pattern: Phase not found.
 
 ### Missing prerequisites
-If REQUIREMENTS.md or ROADMAP.md don't exist, display:
-```
-╔══════════════════════════════════════════════════════════════╗
-║  ERROR                                                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-Project not initialized. Missing REQUIREMENTS.md or ROADMAP.md.
-
-**To fix:** Run `/pbr:begin` first.
-```
+If REQUIREMENTS.md or ROADMAP.md don't exist, display a branded error box — see `skills/shared/error-reporting.md`, pattern: Missing prerequisites.
 
 ### Research agent fails
 If the researcher Task() fails, display:
@@ -681,33 +663,10 @@ If the researcher Task() fails, display:
 Continue to the planning step.
 
 ### Planner agent fails
-If the planner Task() fails, display:
-```
-╔══════════════════════════════════════════════════════════════╗
-║  ERROR                                                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-Planner agent failed for Phase {N}.
-
-**To fix:**
-- Try again with `/pbr:plan {N} --skip-research`
-- Check `.planning/CONTEXT.md` for conflicting constraints
-```
+If the planner Task() fails, display a branded error box — see `skills/shared/error-reporting.md`, pattern: Planner agent failure.
 
 ### Checker loops forever
-After 3 revision iterations without passing, display:
-```
-╔══════════════════════════════════════════════════════════════╗
-║  ERROR                                                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-Plan checker failed to pass after 3 revision iterations for Phase {N}.
-
-**To fix:**
-- Review the remaining issues below and decide whether to proceed or revise manually
-- Run `/pbr:plan {N}` to restart planning from scratch
-```
-
+After 3 revision iterations without passing, display a branded error box — see `skills/shared/error-reporting.md`, pattern: Checker loops.
 Present remaining issues and ask user to decide: proceed or intervene.
 
 ---
@@ -732,44 +691,5 @@ Delete `.planning/.active-skill` if it exists. This must happen on all paths (su
 
 After planning completes, present:
 
-Use the branded stage banner from `references/ui-formatting.md`:
-
-```
-╔══════════════════════════════════════════════════════════════╗
-║  PLAN-BUILD-RUN ► PLANNING PHASE {N} ✓                       ║
-╚══════════════════════════════════════════════════════════════╝
-
-**Phase {N}: {name}** — {plan_count} plans created
-
-Plans:
-  {phase}-01: {name} (Wave 1, {task_count} tasks)
-  {phase}-02: {name} (Wave 1, {task_count} tasks)
-  {phase}-03: {name} (Wave 2, {task_count} tasks)
-
-Wave execution:
-  Wave 1: Plans 01, 02 (parallel)
-  Wave 2: Plan 03
-```
-
-Then use the "Next Up" routing block:
-```
-
-
-╔══════════════════════════════════════════════════════════════╗
-║  ▶ NEXT UP                                                   ║
-╚══════════════════════════════════════════════════════════════╝
-
-**Build Phase {N}** — execute these plans
-
-/pbr:build {N}
-
-<sub>/clear first → fresh context window</sub>
-
-
-
-**Also available:**
-- /pbr:plan {N} --assumptions — review assumptions first
-- /pbr:discuss {N} — talk through details before building
-
-
-```
+Use the branded stage banner and next-up block from `skills/plan/templates/completion-output.md.tmpl`.
+Fill in: `{N}` (phase number), `{phase-name}`, `{plan_count}`, `{plan_list_lines}` (one line per plan with wave and task count), `{wave_table_lines}` (one line per wave).

package/plugins/pbr/skills/plan/templates/completion-output.md.tmpl

@@ -0,0 +1,27 @@
+╔══════════════════════════════════════════════════════════════╗
+║  PLAN-BUILD-RUN ► PLANNING PHASE {N} ✓                       ║
+╚══════════════════════════════════════════════════════════════╝
+
+**Phase {N}: {phase-name}** — {plan_count} plans created
+
+Plans:
+{plan_list_lines}
+
+Wave execution:
+{wave_table_lines}
+
+---
+
+╔══════════════════════════════════════════════════════════════╗
+║  ▶ NEXT UP                                                   ║
+╚══════════════════════════════════════════════════════════════╝
+
+**Build Phase {N}** — execute these plans
+
+/pbr:build {N}
+
+<sub>/clear first → fresh context window</sub>
+
+**Also available:**
+- /pbr:plan {N} --assumptions — review assumptions first
+- /pbr:discuss {N} — talk through details before building

package/plugins/pbr/skills/shared/error-reporting.md

@@ -0,0 +1,59 @@
+# Error Reporting — Standard Format
+
+Use the branded error box for all blocking errors. Present the box, explain what happened, and give a specific fix action.
+
+## Error Box Format
+
+```
+╔══════════════════════════════════════════════════════════════╗
+║  ERROR                                                       ║
+╚══════════════════════════════════════════════════════════════╝
+
+{one-line description of what went wrong}
+
+**To fix:** {specific action the user should take}
+```
+
+## Warning Format (non-blocking)
+
+```
+⚠ {one-line warning}
+  {optional detail or suggestion}
+```
+Continue execution after showing a warning.
+
+## Common Error Patterns
+
+### Phase not found
+Message: "Phase {N} not found in ROADMAP.md."
+Fix: "Run `/pbr:status` to see available phases."
+
+### Missing prerequisites (no REQUIREMENTS.md or ROADMAP.md)
+Message: "Project not initialized. Missing REQUIREMENTS.md or ROADMAP.md."
+Fix: "Run `/pbr:begin` first."
+
+### No plans found for phase
+Message: "Phase {N} has no plans."
+Fix: "Run `/pbr:plan {N}` first."
+
+### Dependency phase not complete
+Message: "Phase {N} depends on Phase {M}, which is not complete."
+Fix: "Build Phase {M} first with `/pbr:build {M}`."
+
+### Planner agent failure
+Message: "Planner agent failed for Phase {N}."
+Fix: "Try again with `/pbr:plan {N} --skip-research`. Check `.planning/CONTEXT.md` for conflicting constraints."
+
+### Checker loops (3+ iterations without pass)
+Message: "Plan checker failed to pass after 3 revision iterations for Phase {N}."
+Fix: "Review the remaining issues below and decide whether to proceed or revise manually. Run `/pbr:plan {N}` to restart planning from scratch."
+After displaying: present remaining issues and ask user to decide (proceed or intervene).
+
+### Research agent failure
+Display as WARNING (non-blocking): "Research agent failed. Planning without phase-specific research. This may result in less accurate plans."
+Continue to the planning step.
+
+## Usage
+
+In skill files, replace repeated error box content with:
+"Display a branded error box — use the format from `skills/shared/error-reporting.md`, pattern: {pattern name}."