@sienklogic/plan-build-run 2.19.1 → 2.19.2

package/plugins/pbr/dist/check-plan-format.js

@@ -25,8 +25,6 @@ const fs = require('fs');
 const path = require('path');
 const { logHook } = require('./hook-logger');
 const { logEvent } = require('./event-logger');
-const { resolveConfig } = require('./lib/local-llm/health');
-const { classifyArtifact } = require('./lib/local-llm/operations/classify-artifact');
 
 // Import all validators from extracted module
 const {
@@ -49,20 +47,6 @@ const {
   validateContext
 } = require('./lib/format-validators');
 
-/**
- * Load and resolve the local_llm config block from .planning/config.json.
- * Returns a resolved config (always safe to use -- disabled by default on error).
- */
-function loadLocalLlmConfig() {
-  try {
-    const configPath = path.join(process.cwd(), '.planning', 'config.json');
-    const parsed = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    return resolveConfig(parsed.local_llm);
-  } catch (_e) {
-    return resolveConfig(undefined);
-  }
-}
-
 async function main() {
   let input = '';
 
@@ -119,22 +103,6 @@ async function main() {
         result.warnings.push(`Plan file "${basename}" uses non-standard naming. Expected format: PLAN-{NN}.md or PLAN.md. Phase-prefixed names (e.g., "10-02-PLAN.md") bypass some validation checks.`);
       }
 
-      // LLM advisory enrichment -- advisory only, never blocks
-      if ((isPlan || isSummary) && result.errors.length === 0) {
-        try {
-          const llmConfig = loadLocalLlmConfig();
-          const planningDir = path.join(process.cwd(), '.planning');
-          const fileType = isPlan ? 'PLAN' : 'SUMMARY';
-          const llmResult = await classifyArtifact(llmConfig, planningDir, content, fileType, data.session_id);
-          if (llmResult && llmResult.classification) {
-            const llmNote = `Local LLM: ${fileType} classified as "${llmResult.classification}" (confidence: ${(llmResult.confidence * 100).toFixed(0)}%)${llmResult.reason ? ' — ' + llmResult.reason : ''}`;
-            result.warnings.push(llmNote);
-          }
-        } catch (_llmErr) {
-          // Never propagate LLM errors
-        }
-      }
-
       const eventType = isPlan ? 'plan-validated' : isVerification ? 'verification-validated' : isRoadmap ? 'roadmap-validated' : isLearnings ? 'learnings-validated' : isConfig ? 'config-validated' : isResearch ? 'research-validated' : isContext ? 'context-validated' : 'summary-validated';
 
       // Detect Write vs Edit: Write = full creation/overwrite (likely first attempt)

package/plugins/pbr/dist/check-roadmap-sync.js

@@ -17,6 +17,7 @@ const fs = require('fs');
 const path = require('path');
 const { logHook } = require('./hook-logger');
 const { logEvent } = require('./event-logger');
+const { extractFrontmatter } = require('./lib/frontmatter');
 
 const LIFECYCLE_STATUSES = ['planned', 'built', 'partial', 'verified'];
 
@@ -197,29 +198,32 @@ function main() {
 
 /**
  * Extract current phase number and status from STATE.md.
- * Handles common formats:
- *   "**Phase**: 03 - slug-name"
- *   "Phase: 3"
- *   "Current phase: 03-slug-name"
- *   "**Status**: planned"
- *   "Phase status: built"
+ * Tries frontmatter first (v2), falls back to body regex (legacy).
+ * Delegates frontmatter parsing to canonical extractFrontmatter.
+ * Returns { phase, status } or null if unparseable.
  */
-function parseState(content) {
+const parseState = (content) => {
+  // Try frontmatter first (v2 format)
+  const fm = extractFrontmatter(content);
+  if (fm.current_phase && fm.status) {
+    return {
+      phase: normalizePhaseNum(String(fm.current_phase)),
+      status: fm.status.toLowerCase()
+    };
+  }
+  // Fallback: body regex for legacy formats
   const phaseMatch = content.match(
     /\*{0,2}(?:Current\s+)?Phase\*{0,2}:\s*(\d+(?:\.\d+)?)/i
   );
-
   const statusMatch = content.match(
     /\*{0,2}(?:Phase\s+)?Status\*{0,2}:\s*["']?(\w+)["']?/i
   );
-
   if (!phaseMatch || !statusMatch) return null;
-
   return {
     phase: normalizePhaseNum(phaseMatch[1]),
     status: statusMatch[1].toLowerCase()
   };
-}
+};
 
 /**
  * Find the status for a given phase in ROADMAP.md's Phase Overview table.

package/plugins/pbr/dist/check-subagent-output.js

@@ -21,8 +21,6 @@ const fs = require('fs');
 const path = require('path');
 const { logHook } = require('./hook-logger');
 const { KNOWN_AGENTS, sessionLoad } = require('./pbr-tools');
-const { resolveConfig } = require('./lib/local-llm/health');
-const { classifyError } = require('./lib/local-llm/operations/classify-error');
 const { resolveSessionPath } = require('./lib/core');
 const { logEvent } = require('./event-logger');
 const { recordOutcome } = require('./trust-tracker');
@@ -102,15 +100,6 @@ function readStdin() {
   return {};
 }
 
-function loadLocalLlmConfig(cwd) {
-  try {
-    const configPath = path.join(cwd, '.planning', 'config.json');
-    const parsed = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    return resolveConfig(parsed.local_llm);
-  } catch (_) {
-    return resolveConfig(undefined);
-  }
-}
 
 async function main() {
   const data = readStdin();
@@ -248,22 +237,8 @@ async function main() {
       agent_type: agentType,
       warnings: skillWarnings
     });
-    // LLM error classification -- advisory enrichment
-    let llmCategoryNote = '';
-    try {
-      const llmConfig = loadLocalLlmConfig(cwd);
-      const errorText = (data.tool_output || '').substring(0, 500);
-      if (errorText) {
-        const llmResult = await classifyError(llmConfig, planningDir, errorText, agentType, data.session_id);
-        if (llmResult && llmResult.category) {
-          llmCategoryNote = `\nLLM error category: ${llmResult.category} (confidence: ${(llmResult.confidence * 100).toFixed(0)}%)`;
-        }
-      }
-    } catch (_llmErr) {
-      // Never propagate
-    }
     const msg = `Warning: Agent ${agentType} completed but no ${outputSpec.description} was found.\nSkill-specific warnings:\n` +
-      skillWarnings.map(w => `- ${w}`).join('\n') + llmCategoryNote;
+      skillWarnings.map(w => `- ${w}`).join('\n');
     process.stdout.write(JSON.stringify({ additionalContext: msg }));
   } else if (genericMissing) {
     logHook('check-subagent-output', 'PostToolUse', 'warning', {
@@ -271,22 +246,8 @@ async function main() {
       expected: outputSpec.description,
       found: 'none'
     });
-    // LLM error classification -- advisory enrichment
-    let llmCategoryNote = '';
-    try {
-      const llmConfig = loadLocalLlmConfig(cwd);
-      const errorText = (data.tool_output || '').substring(0, 500);
-      if (errorText) {
-        const llmResult = await classifyError(llmConfig, planningDir, errorText, agentType, data.session_id);
-        if (llmResult && llmResult.category) {
-          llmCategoryNote = `\nLLM error category: ${llmResult.category} (confidence: ${(llmResult.confidence * 100).toFixed(0)}%)`;
-        }
-      }
-    } catch (_llmErr) {
-      // Never propagate
-    }
     const output = {
-      additionalContext: `[WARN] Agent ${agentType} completed but no ${outputSpec.description} was found. Likely causes: (1) agent hit an error mid-run, (2) wrong working directory. To fix: re-run the parent skill — the executor gate will block until the output is present. Check the Task() output above for error details.` + llmCategoryNote
+      additionalContext: `[WARN] Agent ${agentType} completed but no ${outputSpec.description} was found. Likely causes: (1) agent hit an error mid-run, (2) wrong working directory. To fix: re-run the parent skill — the executor gate will block until the output is present. Check the Task() output above for error details.`
     };
     process.stdout.write(JSON.stringify(output));
   } else if (skillWarnings.length > 0) {
@@ -412,32 +373,15 @@ async function handleHttp(reqBody) {
     }
   }
 
-  // LLM classification helper (advisory, never throws)
-  async function getLlmNote() {
-    try {
-      const cwd = process.env.PBR_PROJECT_ROOT || process.cwd();
-      const llmConfig = loadLocalLlmConfig(cwd);
-      const errorText = (data.tool_output || '').substring(0, 500);
-      if (!errorText) return '';
-      const llmResult = await classifyError(llmConfig, planningDir, errorText, agentType, data.session_id);
-      if (llmResult && llmResult.category) {
-        return `\nLLM error category: ${llmResult.category} (confidence: ${(llmResult.confidence * 100).toFixed(0)}%)`;
-      }
-    } catch (_e) { /* never propagate */ }
-    return '';
-  }
-
   if (genericMissing && skillWarnings.length > 0) {
     logHook('check-subagent-output', 'PostToolUse', 'skill-warning', { skill: activeSkill, agent_type: agentType, warnings: skillWarnings });
-    const llmCategoryNote = await getLlmNote();
     const msg = `Warning: Agent ${agentType} completed but no ${outputSpec.description} was found.\nSkill-specific warnings:\n` +
-      skillWarnings.map(w => `- ${w}`).join('\n') + llmCategoryNote;
+      skillWarnings.map(w => `- ${w}`).join('\n');
     return { additionalContext: msg };
   } else if (genericMissing) {
     logHook('check-subagent-output', 'PostToolUse', 'warning', { agent_type: agentType, expected: outputSpec.description, found: 'none' });
-    const llmCategoryNote = await getLlmNote();
     return {
-      additionalContext: `[WARN] Agent ${agentType} completed but no ${outputSpec.description} was found. Likely causes: (1) agent hit an error mid-run, (2) wrong working directory. To fix: re-run the parent skill — the executor gate will block until the output is present. Check the Task() output above for error details.` + llmCategoryNote
+      additionalContext: `[WARN] Agent ${agentType} completed but no ${outputSpec.description} was found. Likely causes: (1) agent hit an error mid-run, (2) wrong working directory. To fix: re-run the parent skill — the executor gate will block until the output is present. Check the Task() output above for error details.`
     };
   } else if (skillWarnings.length > 0) {
     logHook('check-subagent-output', 'PostToolUse', 'skill-warning', { skill: activeSkill, agent_type: agentType, warnings: skillWarnings });

package/plugins/pbr/dist/check-summary-gate.js

@@ -27,24 +27,13 @@
 const fs = require('fs');
 const path = require('path');
 const { logHook } = require('./hook-logger');
+const { extractFrontmatter } = require('./lib/frontmatter');
 
 // Statuses that indicate a phase has been executed
 const ADVANCED_STATUSES = ['built', 'verified', 'complete'];
 
-/**
- * Extract YAML frontmatter values from markdown content.
- * Returns an object with parsed key-value pairs.
- */
-function parseFrontmatter(content) {
-  const match = content.match(/^---\r?\n([\s\S]*?)\r?\n---/);
-  if (!match) return {};
-  const result = {};
-  for (const line of match[1].split(/\r?\n/)) {
-    const kv = line.match(/^(\w[\w_]*):\s*"?([^"\r\n]*)"?$/);
-    if (kv) result[kv[1]] = kv[2].trim();
-  }
-  return result;
-}
+// Re-export extractFrontmatter as parseFrontmatter for backward compat (tests import it)
+const parseFrontmatter = extractFrontmatter;
 
 /**
  * Check if a SUMMARY file exists for the given phase directory.

package/plugins/pbr/dist/feedback-loop.js

@@ -20,36 +20,19 @@
 
 const fs = require('fs');
 const path = require('path');
+const { extractFrontmatter } = require('./lib/frontmatter');
 
 /**
- * Parse YAML-ish frontmatter from markdown content.
- * Lightweight parser — no dependency on pbr-tools to avoid circular deps.
+ * Parse frontmatter and body from markdown content.
+ * Delegates YAML parsing to canonical extractFrontmatter.
  * @param {string} content - Full file content
  * @returns {{ frontmatter: object, body: string }}
  */
-function parseFrontmatter(content) {
-  const match = content.match(/^---\r?\n([\s\S]*?)\r?\n---/);
-  if (!match) return { frontmatter: {}, body: content };
-
-  const fm = {};
-  const lines = match[1].split(/\r?\n/);
-  for (const line of lines) {
-    const kvMatch = line.match(/^(\w[\w_]*):\s*(.+)/);
-    if (kvMatch) {
-      const key = kvMatch[1];
-      let val = kvMatch[2].trim();
-      // Parse numbers
-      if (/^\d+$/.test(val)) val = parseInt(val, 10);
-      // Strip quotes
-      if (typeof val === 'string' && val.startsWith('"') && val.endsWith('"')) {
-        val = val.slice(1, -1);
-      }
-      fm[key] = val;
-    }
-  }
-
-  const body = content.slice(match[0].length).trim();
-  return { frontmatter: fm, body };
+function extractFrontmatterWithBody(content) {
+  const frontmatter = extractFrontmatter(content);
+  const match = content.match(/^---\r?\n[\s\S]*?\r?\n---/);
+  const body = match ? content.slice(match[0].length).trim() : content;
+  return { frontmatter, body };
 }
 
 /**
@@ -69,7 +52,7 @@ function extractFeedback(phaseDir) {
     return null;
   }
 
-  const { frontmatter, body } = parseFrontmatter(content);
+  const { frontmatter, body } = extractFrontmatterWithBody(content);
 
   const status = frontmatter.status;
   if (!status) return null;
@@ -77,9 +60,9 @@ function extractFeedback(phaseDir) {
   // No feedback needed if verification passed
   if (status === 'passed' || status === 'all_passed') return null;
 
-  const attempt = typeof frontmatter.attempt === 'number' ? frontmatter.attempt : 1;
-  const passed = typeof frontmatter.must_haves_passed === 'number' ? frontmatter.must_haves_passed : 0;
-  const total = typeof frontmatter.must_haves_total === 'number' ? frontmatter.must_haves_total : 1;
+  const attempt = frontmatter.attempt ? parseInt(frontmatter.attempt, 10) || 1 : 1;
+  const passed = frontmatter.must_haves_passed ? parseInt(frontmatter.must_haves_passed, 10) || 0 : 0;
+  const total = frontmatter.must_haves_total ? parseInt(frontmatter.must_haves_total, 10) || 1 : 1;
   const pass_rate = total > 0 ? passed / total : 0;
 
   // Parse gap sections from body

package/plugins/pbr/dist/hook-server.js

@@ -89,15 +89,23 @@ function readEventLogTail(logFile, maxLines) {
   if (maxLines === undefined) maxLines = 500;
   try {
     if (!fs.existsSync(logFile)) return [];
-    const content = fs.readFileSync(logFile, 'utf8');
-    const lines = content.split('\n').filter(l => l.trim().length > 0);
+    const stat = fs.statSync(logFile);
+    if (stat.size === 0) return [];
+    // Read only the last chunk instead of the entire file
+    const CHUNK_SIZE = 64 * 1024; // 64KB should hold 500+ lines
+    const start = Math.max(0, stat.size - CHUNK_SIZE);
+    const fd = fs.openSync(logFile, 'r');
+    const buffer = Buffer.alloc(Math.min(CHUNK_SIZE, stat.size));
+    fs.readSync(fd, buffer, 0, buffer.length, start);
+    fs.closeSync(fd);
+    const lines = buffer.toString('utf8').split('\n').filter(l => l.trim().length > 0);
     const tail = lines.slice(-maxLines);
     const events = [];
     for (const line of tail) {
       try {
         events.push(JSON.parse(line));
       } catch (_e) {
-        // Skip malformed lines
+        // Skip malformed lines (including partial first line from mid-file read)
       }
     }
     return events;
@@ -106,6 +114,23 @@ function readEventLogTail(logFile, maxLines) {
   }
 }
 
+/**
+ * Rotate the event log if it exceeds 2MB — truncate to last 1000 lines.
+ * Called once at server startup to prevent unbounded log growth.
+ */
+function rotateEventLog(planningDir) {
+  if (!planningDir) return;
+  const logFile = path.join(planningDir, '.hook-events.jsonl');
+  try {
+    const stat = fs.statSync(logFile);
+    if (stat.size > 2 * 1024 * 1024) { // 2MB
+      const content = fs.readFileSync(logFile, 'utf8');
+      const lines = content.split('\n').filter(l => l.trim().length > 0);
+      fs.writeFileSync(logFile, lines.slice(-1000).join('\n') + '\n');
+    }
+  } catch (_e) { /* best-effort — file may not exist yet */ }
+}
+
 /** Append a JSON event object as a single line to .planning/.hook-events.jsonl */
 function appendEvent(planningDir, eventObj) {
   if (!planningDir) return;
@@ -176,6 +201,30 @@ function mergeContext(...fns) {
   };
 }
 
+// ---------------------------------------------------------------------------
+// PreToolUse response translation
+// ---------------------------------------------------------------------------
+
+/**
+ * Translate PreToolUse block responses into Claude Code's hookSpecificOutput format.
+ * Handlers return { decision: 'block', reason: '...' } but Claude Code expects
+ * { hookSpecificOutput: { hookEventName, permissionDecision, permissionDecisionReason } }.
+ */
+function translatePreToolUseResponse(event, result) {
+  if (!result || event !== 'PreToolUse') return result;
+  if (result.decision === 'block' && result.reason) {
+    return {
+      hookSpecificOutput: {
+        hookEventName: 'PreToolUse',
+        permissionDecision: 'deny',
+        permissionDecisionReason: result.reason
+      }
+    };
+  }
+  // Allow decisions or non-blocking results pass through unchanged
+  return result;
+}
+
 // ---------------------------------------------------------------------------
 // Handler routing table (dynamic Map populated by register/initRoutes)
 // ---------------------------------------------------------------------------
@@ -377,7 +426,7 @@ function createServer(planningDir) {
       }
       const duration_ms = Date.now() - dispatchStart;
       appendEvent(planningDir, { ts: new Date().toISOString(), type: 'dispatch', event, tool, hook: `${event}:${tool}`, duration_ms, transport: 'http' });
-      let finalResult = dispatchResult || {};
+      let finalResult = translatePreToolUseResponse(event, dispatchResult) || {};
       if (duration_ms >= 100) {
         const alertMsg = `HOOK PERFORMANCE ALERT: ${event}:${tool} took ${duration_ms}ms (threshold: 100ms). Check handler for blocking I/O.`;
         if (finalResult.additionalContext) {
@@ -431,7 +480,7 @@ function createServer(planningDir) {
       }
       const legacyDurationMs = Date.now() - legacyDispatchStart;
       appendEvent(planningDir, { ts: new Date().toISOString(), type: 'dispatch', event, tool, hook: `${event}:${tool}`, duration_ms: legacyDurationMs, transport: 'http' });
-      let legacyFinalResult = legacyDispatchResult || {};
+      let legacyFinalResult = translatePreToolUseResponse(event, legacyDispatchResult) || {};
       if (legacyDurationMs >= 100) {
         const alertMsg = `HOOK PERFORMANCE ALERT: ${event}:${tool} took ${legacyDurationMs}ms (threshold: 100ms). Check handler for blocking I/O.`;
         if (legacyFinalResult.additionalContext) {
@@ -573,6 +622,9 @@ function main() {
     cache.config = configLoad(planningDir);
   } catch (_e) { /* best-effort */ }
 
+  // Rotate event log if oversized (before any new events are appended)
+  rotateEventLog(planningDir);
+
   initRoutes();
 
   const server = createServer(planningDir);
@@ -601,6 +653,6 @@ function main() {
   process.on('SIGINT', shutdown);
 }
 
-module.exports = { createServer, appendEvent, readEventLogTail, mergeContext, lazyHandler, resolveHandler, register, initRoutes, triggerShutdown, tryNextPort, normalizeMsysPath, DEFAULT_PORT };
+module.exports = { createServer, appendEvent, readEventLogTail, rotateEventLog, mergeContext, lazyHandler, resolveHandler, register, initRoutes, triggerShutdown, tryNextPort, normalizeMsysPath, translatePreToolUseResponse, DEFAULT_PORT };
 
 if (require.main === module || process.argv[1] === __filename) { main(); }

package/plugins/pbr/dist/milestone-learnings.js

@@ -19,61 +19,11 @@ const fs = require('fs');
 const path = require('path');
 const { logHook } = require('./hook-logger');
 const { learningsIngest, copyToGlobal } = require('./lib/learnings');
+const { extractFrontmatter } = require('./lib/frontmatter');
 
 // --- Helpers ---
 
-/**
- * Parse YAML frontmatter from a markdown file.
- * Returns an object with string/array field values, or null if no frontmatter.
- * Only handles simple YAML: scalar strings and dash-list arrays.
- * @param {string} content
- * @returns {object|null}
- */
-function parseFrontmatter(content) {
-  // Normalize line endings
-  const normalized = content.replace(/\r\n/g, '\n');
-  const match = normalized.match(/^---\n([\s\S]*?)\n---/);
-  if (!match) return null;
-
-  const yaml = match[1];
-  const result = {};
-  const lines = yaml.split('\n');
-  let currentKey = null;
-
-  for (const line of lines) {
-    // List item (must check before key match so "  - item" doesn't match as key)
-    const listMatch = line.match(/^\s+-\s+"?([^"]+?)"?\s*$/);
-    if (listMatch) {
-      if (currentKey !== null) {
-        if (!Array.isArray(result[currentKey])) {
-          result[currentKey] = [];
-        }
-        result[currentKey].push(listMatch[1].trim());
-      }
-      continue;
-    }
-
-    // Key: value pair
-    const kvMatch = line.match(/^(\w[\w_-]*):\s*(.*)/);
-    if (kvMatch) {
-      currentKey = kvMatch[1];
-      const rawVal = kvMatch[2].trim();
-
-      if (rawVal === '' || rawVal === '[]') {
-        // Empty scalar or empty inline array — may be followed by list items
-        result[currentKey] = [];
-      } else if (rawVal.startsWith('[')) {
-        // Inline array (basic): [a, b]
-        const inner = rawVal.slice(1, rawVal.lastIndexOf(']'));
-        result[currentKey] = inner.split(',').map(s => s.trim().replace(/^["']|["']$/g, '')).filter(Boolean);
-      } else {
-        result[currentKey] = rawVal.replace(/^["']|["']$/g, '');
-      }
-    }
-  }
-
-  return result;
-}
+// parseFrontmatter replaced by extractFrontmatter from lib/frontmatter.js
 
 /**
  * Extract learning entries from a SUMMARY.md file's frontmatter.
@@ -82,8 +32,8 @@ function parseFrontmatter(content) {
  * @returns {object[]} array of raw learning entry objects
  */
 function extractLearningsFromSummary(summaryContent, sourceProject) {
-  const fm = parseFrontmatter(summaryContent);
-  if (!fm) return [];
+  const fm = extractFrontmatter(summaryContent);
+  if (!fm || Object.keys(fm).length === 0) return [];
 
   const entries = [];
 
@@ -476,7 +426,7 @@ async function main() {
         if (!fs.existsSync(verPath)) continue;
         try {
           const verContent = fs.readFileSync(verPath, 'utf8');
-          const fm = parseFrontmatter(verContent);
+          const fm = extractFrontmatter(verContent);
           if (!fm) continue;
           // Extract gaps from frontmatter
           const gaps = Array.isArray(fm.gaps) ? fm.gaps : [];
@@ -566,4 +516,4 @@ if (require.main === module || process.argv[1] === __filename) {
   });
 }
 
-module.exports = { extractLearningsFromSummary, findSummaryFiles, parseFrontmatter, aggregateToKnowledge, countExistingRows, itemExists, insertTableRow, KNOWLEDGE_TEMPLATE };
+module.exports = { extractLearningsFromSummary, findSummaryFiles, extractFrontmatter, aggregateToKnowledge, countExistingRows, itemExists, insertTableRow, KNOWLEDGE_TEMPLATE };