@sienklogic/plan-build-run 2.19.0 → 2.19.2

package/plugins/pbr/scripts/test/config.test.js

@@ -0,0 +1,126 @@
+/**
+ * Unit tests for lib/config.js — Config loading, validation, and depth profiles.
+ */
+
+const { describe, it, afterEach } = require('node:test');
+const assert = require('node:assert');
+const fs = require('fs');
+const path = require('path');
+const os = require('os');
+const { configLoad, configClearCache, resolveDepthProfile, mergeUserDefaults, DEPTH_PROFILE_DEFAULTS } = require('../lib/config');
+
+afterEach(() => {
+  configClearCache();
+});
+
+describe('configLoad', () => {
+  it('returns null when config.json is missing', () => {
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'config-test-'));
+    const result = configLoad(tmpDir);
+    assert.strictEqual(result, null);
+    fs.rmSync(tmpDir, { recursive: true });
+  });
+
+  it('returns parsed config when config.json exists', () => {
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'config-test-'));
+    const config = { mode: 'autonomous', depth: 'standard' };
+    fs.writeFileSync(path.join(tmpDir, 'config.json'), JSON.stringify(config), 'utf8');
+
+    const result = configLoad(tmpDir);
+    assert.strictEqual(result.mode, 'autonomous');
+    assert.strictEqual(result.depth, 'standard');
+
+    fs.rmSync(tmpDir, { recursive: true });
+  });
+
+  it('returns null for invalid JSON', () => {
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'config-test-'));
+    fs.writeFileSync(path.join(tmpDir, 'config.json'), '{ invalid json }', 'utf8');
+
+    const result = configLoad(tmpDir);
+    assert.strictEqual(result, null);
+
+    fs.rmSync(tmpDir, { recursive: true });
+  });
+
+  it('uses mtime-based caching', () => {
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'config-test-'));
+    fs.writeFileSync(path.join(tmpDir, 'config.json'), '{"mode":"interactive"}', 'utf8');
+
+    const result1 = configLoad(tmpDir);
+    const result2 = configLoad(tmpDir);
+    assert.strictEqual(result1, result2); // Same object reference (cached)
+
+    fs.rmSync(tmpDir, { recursive: true });
+  });
+});
+
+describe('resolveDepthProfile', () => {
+  it('returns standard defaults when config is null', () => {
+    const { depth, profile } = resolveDepthProfile(null);
+    assert.strictEqual(depth, 'standard');
+    assert.strictEqual(profile['features.research_phase'], true);
+  });
+
+  it('returns quick profile when depth is quick', () => {
+    const { depth, profile } = resolveDepthProfile({ depth: 'quick' });
+    assert.strictEqual(depth, 'quick');
+    assert.strictEqual(profile['features.research_phase'], false);
+    assert.strictEqual(profile['features.plan_checking'], false);
+  });
+
+  it('returns comprehensive profile when depth is comprehensive', () => {
+    const { depth, profile } = resolveDepthProfile({ depth: 'comprehensive' });
+    assert.strictEqual(depth, 'comprehensive');
+    assert.strictEqual(profile['features.inline_verify'], true);
+  });
+
+  it('merges user overrides from depth_profiles', () => {
+    const config = {
+      depth: 'standard',
+      depth_profiles: {
+        standard: { 'scan.mapper_count': 6 }
+      }
+    };
+    const { profile } = resolveDepthProfile(config);
+    assert.strictEqual(profile['scan.mapper_count'], 6);
+    // Other defaults preserved
+    assert.strictEqual(profile['features.research_phase'], true);
+  });
+});
+
+describe('mergeUserDefaults', () => {
+  it('uses user defaults when base key is missing', () => {
+    const base = { mode: 'interactive' };
+    const defaults = { mode: 'autonomous', depth: 'comprehensive' };
+    const merged = mergeUserDefaults(base, defaults);
+    assert.strictEqual(merged.mode, 'interactive'); // base wins
+    assert.strictEqual(merged.depth, 'comprehensive'); // from defaults
+  });
+
+  it('deep-merges nested objects', () => {
+    const base = { features: { research_phase: true } };
+    const defaults = { features: { plan_checking: true, research_phase: false } };
+    const merged = mergeUserDefaults(base, defaults);
+    assert.strictEqual(merged.features.research_phase, true); // base wins
+    assert.strictEqual(merged.features.plan_checking, true); // from defaults
+  });
+
+  it('returns base unchanged when defaults is null', () => {
+    const base = { mode: 'interactive' };
+    const merged = mergeUserDefaults(base, null);
+    assert.deepStrictEqual(merged, base);
+  });
+});
+
+describe('config paths use path.join', () => {
+  it('USER_DEFAULTS_PATH uses platform path separator', () => {
+    const { USER_DEFAULTS_PATH } = require('../lib/config');
+    // Should contain the platform-appropriate separator
+    assert.ok(USER_DEFAULTS_PATH.includes('pbr-defaults.json'));
+    // Should NOT contain a mix of forward and back slashes (unless on platform that uses them)
+    if (process.platform === 'win32') {
+      assert.ok(USER_DEFAULTS_PATH.includes('\\'));
+    }
+  });
+});

package/plugins/pbr/scripts/test/cross-platform.test.js

@@ -0,0 +1,131 @@
+/**
+ * Cross-platform tests — CRLF normalization, path construction, MSYS path regex.
+ */
+
+const { describe, it } = require('node:test');
+const assert = require('node:assert');
+const path = require('path');
+const { parseYamlFrontmatter } = require('../lib/core');
+const { parseStateMd } = require('../lib/state');
+const { parseRoadmapMd } = require('../lib/roadmap');
+
+// --- CRLF normalization ---
+
+describe('CRLF normalization', () => {
+  const FRONTMATTER_LF = '---\nversion: 2\ncurrent_phase: 5\nstatus: "built"\n---\n# Test';
+  const FRONTMATTER_CRLF = '---\r\nversion: 2\r\ncurrent_phase: 5\r\nstatus: "built"\r\n---\r\n# Test';
+
+  it('parseYamlFrontmatter: CRLF produces same result as LF', () => {
+    const lfResult = parseYamlFrontmatter(FRONTMATTER_LF);
+    const crlfResult = parseYamlFrontmatter(FRONTMATTER_CRLF);
+    assert.strictEqual(crlfResult.version, lfResult.version);
+    assert.strictEqual(crlfResult.current_phase, lfResult.current_phase);
+    assert.strictEqual(crlfResult.status, lfResult.status);
+  });
+
+  it('parseStateMd: CRLF produces same result as LF', () => {
+    const STATE = '---\nversion: 2\ncurrent_phase: 3\nstatus: "building"\nprogress_percent: 50\nplans_complete: 2\nplans_total: 4\n---\n# State\nPhase: 3 of 8\nStatus: Building\nPlan: 2 of 4';
+    const lfResult = parseStateMd(STATE);
+    const crlfResult = parseStateMd(STATE.replace(/\n/g, '\r\n'));
+    assert.strictEqual(crlfResult.current_phase, lfResult.current_phase);
+    assert.strictEqual(crlfResult.status, lfResult.status);
+    assert.strictEqual(crlfResult.plans_complete, lfResult.plans_complete);
+  });
+
+  it('parseRoadmapMd: CRLF produces same result as LF', () => {
+    const ROADMAP = '# Roadmap\n\n## Phase Overview\n\n| Phase | Name | Goal |\n|---|---|---|\n| 01 | Setup | Init |\n| 02 | Build | Core |\n';
+    const lfResult = parseRoadmapMd(ROADMAP);
+    const crlfResult = parseRoadmapMd(ROADMAP.replace(/\n/g, '\r\n'));
+    assert.strictEqual(crlfResult.phases.length, lfResult.phases.length);
+    assert.strictEqual(crlfResult.phases[0].number, lfResult.phases[0].number);
+    assert.strictEqual(crlfResult.phases[1].name, lfResult.phases[1].name);
+  });
+
+  it('mixed line endings (\\r\\n and \\n) still parse correctly', () => {
+    // Simulate a file with inconsistent line endings
+    const mixed = '---\r\nversion: 2\ncurrent_phase: 7\r\nstatus: "planned"\n---\n# Test';
+    const result = parseYamlFrontmatter(mixed);
+    assert.strictEqual(result.version, 2);
+    assert.strictEqual(result.current_phase, 7);
+    assert.strictEqual(result.status, 'planned');
+  });
+});
+
+// --- Path construction ---
+
+describe('path construction', () => {
+  it('path.join produces valid paths on current platform', () => {
+    const result = path.join('plugins', 'pbr', 'scripts', 'lib', 'state.js');
+    assert.ok(result.includes('state.js'));
+    // No double separators
+    assert.ok(!result.includes('//'));
+    assert.ok(!result.includes('\\\\'));
+  });
+
+  it('path.join handles mixed separators', () => {
+    const result = path.join('plugins/pbr', 'scripts\\lib', 'core.js');
+    assert.ok(result.includes('core.js'));
+    assert.ok(result.includes('plugins'));
+  });
+
+  it('path.resolve produces absolute path', () => {
+    const result = path.resolve('plugins', 'pbr', 'scripts');
+    assert.ok(path.isAbsolute(result));
+  });
+});
+
+// --- MSYS path regex ---
+
+describe('MSYS path regex', () => {
+  // This is the regex from run-hook.js bootstrap pattern
+  const MSYS_REGEX = /^\/([a-zA-Z])\/(.*)/;
+
+  function fixMsysPath(p) {
+    if (!p) return p;
+    const match = p.match(MSYS_REGEX);
+    if (match) {
+      return match[1].toUpperCase() + ':\\' + match[2].replace(/\//g, '\\');
+    }
+    return p;
+  }
+
+  it('converts /d/Repos/foo to D:\\Repos\\foo', () => {
+    const result = fixMsysPath('/d/Repos/foo');
+    assert.strictEqual(result, 'D:\\Repos\\foo');
+  });
+
+  it('converts /D/Repos/foo to D:\\Repos\\foo (case insensitive drive)', () => {
+    const result = fixMsysPath('/D/Repos/foo');
+    assert.strictEqual(result, 'D:\\Repos\\foo');
+  });
+
+  it('converts /c/Users/test/project to C:\\Users\\test\\project', () => {
+    const result = fixMsysPath('/c/Users/test/project');
+    assert.strictEqual(result, 'C:\\Users\\test\\project');
+  });
+
+  it('leaves Windows-native paths unchanged', () => {
+    const result = fixMsysPath('D:\\Repos\\foo');
+    assert.strictEqual(result, 'D:\\Repos\\foo');
+  });
+
+  it('leaves relative paths unchanged', () => {
+    const result = fixMsysPath('plugins/pbr/scripts');
+    assert.strictEqual(result, 'plugins/pbr/scripts');
+  });
+
+  it('leaves Unix absolute paths with >1 char dir unchanged', () => {
+    const result = fixMsysPath('/usr/local/bin');
+    assert.strictEqual(result, '/usr/local/bin');
+  });
+
+  it('handles null/empty input', () => {
+    assert.strictEqual(fixMsysPath(null), null);
+    assert.strictEqual(fixMsysPath(''), '');
+  });
+
+  it('handles deep nested MSYS paths', () => {
+    const result = fixMsysPath('/e/Projects/my-app/plugins/pbr/scripts/lib');
+    assert.strictEqual(result, 'E:\\Projects\\my-app\\plugins\\pbr\\scripts\\lib');
+  });
+});

package/plugins/pbr/scripts/test/fixtures/config.json

@@ -0,0 +1,20 @@
+{
+  "mode": "interactive",
+  "depth": "standard",
+  "schema_version": 2,
+  "parallelization": {
+    "enabled": true,
+    "plan_level": false,
+    "max_concurrent_agents": 3
+  },
+  "git": {
+    "branching": "phase",
+    "auto_commit": true
+  },
+  "features": {
+    "research_phase": true,
+    "plan_checking": true,
+    "goal_verification": true,
+    "inline_verify": false
+  }
+}

package/plugins/pbr/scripts/test/fixtures/plan.md

@@ -0,0 +1,54 @@
+---
+phase: 01-foundation
+plan: 01
+type: execute
+wave: 1
+depends_on: []
+files_modified:
+  - src/core/setup.js
+  - src/core/config.js
+autonomous: true
+must_haves:
+  truths:
+    - "Core setup module exists and exports expected functions"
+  artifacts:
+    - path: "src/core/setup.js"
+      provides: "Project initialization logic"
+---
+
+<objective>
+Set up the core project structure with initialization and configuration modules.
+</objective>
+
+<context>
+@.planning/PROJECT.md
+@.planning/ROADMAP.md
+</context>
+
+<tasks>
+
+<task type="auto">
+  <name>Task 1: Create core setup module</name>
+  <files>src/core/setup.js</files>
+  <action>
+    Create src/core/setup.js with project initialization logic.
+  </action>
+  <verify>
+    <automated>node -e "require('./src/core/setup.js')"</automated>
+  </verify>
+  <done>
+    setup.js exists and can be required without errors.
+  </done>
+</task>
+
+</tasks>
+
+<verification>
+1. `node -e "require('./src/core/setup.js')"` -- module loads
+2. `node -e "require('./src/core/config.js')"` -- config loads
+</verification>
+
+<success_criteria>
+- Core setup module exists with initialization function
+- Config module exists with load/validate functions
+</success_criteria>

package/plugins/pbr/scripts/test/fixtures/project.md

@@ -0,0 +1,30 @@
+# Project: Fixture Test Project
+
+## What This Is
+
+A minimal PROJECT.md fixture for testing the PBR file format parsers. This file follows the Phase 5 consolidated format where CONTEXT.md is merged into the Context section.
+
+## Core Value
+
+Ensure PBR planning file formats remain stable across versions by providing canonical fixture examples that automated tests validate against production parsers.
+
+## Requirements Summary
+
+| Category | Count | Key Requirements |
+|----------|-------|-----------------|
+| Setup | 2 | SETUP-01, SETUP-02 |
+| Features | 2 | FEAT-01, FEAT-02 |
+| Testing | 1 | TEST-01 |
+
+## Context
+
+**Tech stack:** Node.js, CommonJS modules, node:test runner
+**Target users:** PBR plugin developers and contributors
+**Key constraint:** Zero external dependencies for core parsing
+
+## Key Decisions
+
+| Phase | Decision | Rationale |
+|-------|----------|-----------|
+| Phase 1 | Use built-in modules only | Zero-dependency operation |
+| Phase 2 | CommonJS over ESM | Plugin ecosystem compatibility |

package/plugins/pbr/scripts/test/fixtures/roadmap.md

@@ -0,0 +1,55 @@
+# Roadmap
+
+## Overview
+
+A minimal roadmap fixture with 2 phases for testing.
+
+## Phases
+
+- [x] Phase 1: Foundation
+- [ ] Phase 2: Features
+
+## Phase Details
+
+## Milestone: v1.0
+
+### Phase 1: Foundation
+
+**Goal:** Set up project structure and core utilities
+**Depends on:** None
+**Requirements:** SETUP-01, SETUP-02
+**Success Criteria:** All core modules exist and pass validation
+
+**Plans:**
+1. 01-01: Core setup
+2. 01-02: Config system
+
+### Phase 2: Features
+
+**Goal:** Implement primary feature set
+**Depends on:** Phase 1
+**Requirements:** FEAT-01, FEAT-02
+**Success Criteria:** Feature tests pass
+
+**Plans:**
+1. 02-01: Feature A
+2. 02-02: Feature B
+
+## Standing Disciplines
+
+- Review all changes before commit
+- Maintain test coverage
+
+## Phase Overview
+
+| Phase | Name | Goal | Plans | Wave | Status |
+|-------|------|------|-------|------|--------|
+| 01 | Foundation | Core setup | 2/2 | 1 | verified |
+| 02 | Features | Feature set | 0/2 | 2 | planned |
+
+## Progress
+
+| Phase | Plans Complete | Status | Completed |
+|-------|---------------|--------|-----------|
+| 1. Foundation | 2/2 | Complete | 2026-02-28 |
+| 2. Features | 0/2 | Pending | -- |

package/plugins/pbr/scripts/test/fixtures/state.md

@@ -0,0 +1,60 @@
+---
+gsd_state_version: 1.0
+version: 2
+milestone: v1.0
+milestone_name: milestone
+status: executing
+current_phase: 3
+phase_slug: 03-research-pipeline
+plans_total: 6
+plans_complete: 4
+progress_percent: 67
+stopped_at: Completed 03-01-PLAN.md
+last_updated: "2026-03-01"
+last_activity: 2026-03-01 -- Executed 03-01 research pipeline (2 tasks, 4 files)
+---
+
+# Project State
+
+## Project Reference
+
+See: .planning/PROJECT.md (updated 2026-03-01)
+
+**Core value:** Example project for fixture testing
+**Current focus:** Phase 3 - Research Pipeline
+
+## Current Position
+
+Phase: 3 of 6 (Research Pipeline)
+Plan: 4 of 6 executed (2 plans created)
+Status: Executing
+Last activity: 2026-03-01 -- Executed 03-01 research pipeline (2 tasks, 4 files)
+
+Progress: [█████████████░░░░░░░] 67%
+
+## Performance Metrics
+
+**Velocity:**
+- Total plans completed: 4
+- Average duration: 3 min
+
+## Accumulated Context
+
+### Decisions
+
+- [Roadmap]: 6-phase structure derived from requirements
+- [Phase 01]: Used built-in modules only for zero-dependency operation
+
+### Pending Todos
+
+None yet.
+
+### Blockers/Concerns
+
+None.
+
+## Session Continuity
+
+Last session: 2026-03-01T12:00:00.000Z
+Stopped at: Completed 03-01-PLAN.md
+Resume file: .planning/phases/03-research-pipeline/03-CONTEXT.md

package/plugins/pbr/scripts/test/fixtures/summary.md

@@ -0,0 +1,35 @@
+---
+phase: 01-foundation
+plan: 01
+status: complete
+duration: 4 min
+started: "2026-02-28T10:00:00Z"
+completed: "2026-02-28T10:04:00Z"
+tasks_completed: 2
+tasks_total: 2
+---
+
+# Phase 01 Plan 01: Core Setup Summary
+
+Core project initialization with setup and config modules using Node.js built-in libraries.
+
+## What Was Built
+
+- Project initialization module (src/core/setup.js)
+- Configuration loader with validation (src/core/config.js)
+
+## Features
+
+- **Setup module**: Creates .planning/ directory structure and initial files
+- **Config module**: Loads, validates, and caches config.json with mtime-based invalidation
+
+## Changes
+
+| File | Change |
+|------|--------|
+| src/core/setup.js | Created - initialization logic |
+| src/core/config.js | Created - config load/validate |
+
+## Deviations from Plan
+
+None - plan executed exactly as written.