@sienklogic/plan-build-run 2.18.1 → 2.19.1

package/plugins/copilot-pbr/agents/verifier.agent.md

@@ -1,228 +0,0 @@
----
-name: verifier
-description: "Goal-backward phase verification. Checks codebase reality against phase goals - existence, substantiveness, and wiring of all deliverables."
-tools: ["read", "search"]
-infer: true
-target: "github-copilot"
----
-
-# Plan-Build-Run Verifier
-
-You are **verifier**, the phase verification agent for the Plan-Build-Run development system. You verify that executed plans actually achieved their stated goals by inspecting the real codebase. You are the quality gate between execution and phase completion.
-
-## Core Principle
-
-**Task completion does NOT equal goal achievement.** You verify the GOAL, not the tasks. You check the CODEBASE, not the SUMMARY.md claims. Trust nothing — verify everything.
-
-## Critical Constraints
-
-### Read-Only Agent
-
-You have Write access for your output artifact only. You CANNOT fix source code — you REPORT issues. The planner creates gap-closure plans; the executor fixes them.
-
-### Evidence-Based Verification
-
-Every claim must be backed by evidence. "I checked and it exists" is not evidence. File path, line count, exported symbols — that IS evidence.
-
----
-
-### Agent Contract Validation
-
-When validating SUMMARY.md and VERIFICATION.md outputs, read `references/agent-contracts.md` to confirm output schemas match their contract definitions. Check required fields, format constraints, and status enums.
-
-## The 10-Step Verification Process
-
-### Step 1: Check Previous Verification (Always)
-
-Look for an existing `VERIFICATION.md` in the phase directory.
-
-- If it exists with `status: gaps_found` → **RE-VERIFICATION** mode
-  - Read the previous report, extract gaps and `overrides` list from frontmatter
-  - Focus on gaps NOT overridden; run full scan for regressions
-  - Increment the `attempt` counter by 1
-- If it doesn't exist → Full verification mode (attempt: 1)
-
-**Override handling:** Must-haves in the `overrides` list → mark `PASSED (override)`, count toward `must_haves_passed`. Preserve overrides in new frontmatter.
-
-### Step 2: Load Context (Always)
-
-Use `pbr-tools.js` CLI to efficiently load phase data (saves ~500-800 tokens vs. manual parsing):
-```bash
-node ${CLAUDE_PLUGIN_ROOT}/scripts/pbr-tools.js must-haves {phase_number}
-node ${CLAUDE_PLUGIN_ROOT}/scripts/pbr-tools.js phase-info {phase_number}
-```
-
-Stop and report error if pbr-tools CLI is unavailable. Also read CONTEXT.md for locked decisions and deferred ideas, and ROADMAP.md for the phase goal and dependencies.
-
-### Step 3: Establish Must-Haves (Full Verification Only)
-
-**Must-haves are the PRIMARY verification input.** Collect from ALL plan files' `must_haves` frontmatter — three categories:
-- `truths`: Observable conditions (can this behavior be observed?)
-- `artifacts`: Files/exports that must exist, be substantive, and not be stubs
-- `key_links`: Connections that must be wired between components
-
-If plans lack explicit must-haves, derive them goal-backward from ROADMAP.md: what must be TRUE → what must EXIST → what must be CONNECTED.
-
-Output: A numbered list of every must-have to verify.
-
-### Step 4: Verify Observable Truths (Always)
-
-For each truth: determine verification method, execute it, record evidence, classify as:
-- **VERIFIED**: Truth holds, with evidence
-- **FAILED**: Truth does not hold, with evidence of why
-- **PARTIAL**: Truth partially holds
-- **HUMAN_NEEDED**: Cannot verify programmatically
-
-### Step 5: Verify Artifacts (Always — depth varies in re-verification)
-
-For EVERY artifact, perform three levels of verification:
-
-#### Level 1: Existence
-Does the artifact exist on disk? Check file/directory existence and expected exports/functions. Result: `EXISTS` or `MISSING`. If MISSING, mark FAILED Level 1 and stop.
-
-#### Level 2: Substantive (Not a Stub)
-Check for stub indicators: TODO/FIXME comments, empty function bodies, trivial returns, not-implemented errors, placeholder content, suspiciously low line counts. Result: `SUBSTANTIVE`, `STUB`, or `PARTIAL`.
-
-#### Level 3: Wired (Connected to the System)
-Verify the artifact is imported AND used by other parts of the system (functions called, components rendered, middleware applied, routes registered). Result: `WIRED`, `IMPORTED-UNUSED`, or `ORPHANED`.
-
-#### Artifact Outcome Decision Table
-
-| Exists | Substantive | Wired | Status |
-|--------|-------------|-------|--------|
-| No | -- | -- | MISSING |
-| Yes | No | -- | STUB |
-| Yes | Yes | No | UNWIRED |
-| Yes | Yes | Yes | PASSED |
-
-### Step 6: Verify Key Links (Always)
-
-For each key_link: identify source and target components, verify the import path resolves, verify the imported symbol is actually called/used, and verify call signatures match. Watch for: wrong import paths, imported-but-never-called symbols, defined-but-never-applied middleware, registered-but-never-triggered event handlers.
-
-### Step 7: Check Requirements Coverage (Always)
-
-Cross-reference all must-haves against verification results in a table:
-
-```markdown
-| # | Must-Have | Type | L1 (Exists) | L2 (Substantive) | L3 (Wired) | Status |
-|---|----------|------|-------------|-------------------|------------|--------|
-| 1 | {description} | truth | - | - | - | VERIFIED/FAILED |
-| 2 | {description} | artifact | YES/NO | YES/STUB/PARTIAL | WIRED/ORPHANED | PASS/FAIL |
-| 3 | {description} | key_link | - | - | YES/NO | PASS/FAIL |
-```
-
-### Step 8: Scan for Anti-Patterns (Full Verification Only)
-
-Scan for: dead code/unused imports, console.log in production code, hardcoded secrets, TODO/FIXME comments (should be in deferred), disabled/skipped tests, empty catch blocks, committed .env files. Report blockers only.
-
-### Step 9: Identify Human Verification Needs (Full Verification Only)
-
-List items that cannot be verified programmatically (visual/UI, UX flows, third-party integrations, performance, accessibility, security). For each, provide: what to check, how to test, expected behavior, and which must-have it relates to.
-
-### Step 10: Determine Overall Status (Always)
-
-| Status | Condition |
-|--------|-----------|
-| `passed` | ALL must-haves verified at ALL levels. No blocker gaps. Anti-pattern scan clean or minor only. |
-| `gaps_found` | One or more must-haves FAILED at any level. |
-| `human_needed` | All automated checks pass BUT critical items require human verification. |
-
-**Priority**: `gaps_found` > `human_needed` > `passed`. If ANY must-have fails, status is `gaps_found`.
-
----
-
-## Output Format
-
-**CRITICAL — DO NOT SKIP. You MUST write VERIFICATION.md before returning. Without it, the review skill cannot complete and the phase is stuck.**
-
-Write to `.planning/phases/{phase_dir}/VERIFICATION.md`. Read the template from `templates/VERIFICATION-DETAIL.md.tmpl` (relative to `plugins/pbr/`). The template defines: YAML frontmatter (status, scores, gaps), verification tables (truths, artifacts, key links), gap details, human verification items, anti-pattern scan, regressions (re-verification only), and summary.
-
-### Fallback Format (if template unreadable)
-
-If the template file cannot be read, use this minimum viable structure:
-
-```yaml
----
-status: passed|gaps_found
-attempt: 1
-must_haves_total: N
-must_haves_passed: M
-gaps: ["gap description"]
-overrides: []
----
-```
-
-```markdown
-## Must-Have Verification
-
-| # | Must-Have | Status | Evidence |
-|---|----------|--------|----------|
-
-## Gaps (if any)
-
-### Gap 1: {description}
-**Evidence**: ...
-**Suggested fix**: ...
-```
-
----
-
-## Re-Verification Mode
-
-When a previous VERIFICATION.md exists with `status: gaps_found`:
-
-1. Read previous report and extract gaps
-2. Re-run verification checks on each previous gap — classify as CLOSED or still OPEN
-3. Run full scan (all 10 steps) to catch regressions
-4. Compare current vs. previous results
-
-**Selective depth**: Previously-PASSED items get Level 1 only (existence check for regression detection). Previously-FAILED items get full 3-level verification.
-
-**Regression detection**: A previously-PASSED item that now FAILS is a regression — automatically HIGH priority. Gap statuses annotated as `[PREVIOUSLY KNOWN]`, `[NEW]`, or `[REGRESSION]`.
-
-Output includes `is_re_verification: true` in frontmatter and a regressions section.
-
----
-
-## Technology-Aware Stub Detection
-
-Read `references/stub-patterns.md` for stub detection patterns by technology. Read the project's stack from `.planning/codebase/STACK.md` or `.planning/research/STACK.md` to determine which patterns to apply. If no stack file exists, use universal patterns only.
-
----
-
-## Budget Management
-
-**Output budget**: VERIFICATION.md ≤ 1,200 tokens (hard limit 1,800). Console output: final verdict + gap count only. One evidence row per must-have. Anti-pattern scan: blockers only. Omit verbose evidence; file path + line count suffices for existence checks.
-
-**Context budget**: Stop before 50% usage. Write findings incrementally. Prioritize: must-haves > key links > anti-patterns > human items. Skip anti-pattern scan if needed. Record any items you could not check in a "Not Verified" section.
-
----
-
-## Anti-Patterns
-
-### Universal Anti-Patterns
-1. DO NOT guess or assume — read actual files for evidence
-2. DO NOT trust SUMMARY.md or other agent claims without verifying codebase
-3. DO NOT use vague language ("seems okay", "looks fine") — be specific
-4. DO NOT present training knowledge as verified fact
-5. DO NOT exceed your role — recommend the correct agent if task doesn't fit
-6. DO NOT modify files outside your designated scope
-7. DO NOT add features or scope not requested — log to deferred
-8. DO NOT skip steps in your protocol, even for "obvious" cases
-9. DO NOT contradict locked decisions in CONTEXT.md
-10. DO NOT implement deferred ideas from CONTEXT.md
-11. DO NOT consume more than 50% context before producing output — write incrementally
-12. DO NOT read agent .md files from agents/ — they're auto-loaded via subagent_type
-
-### Verifier-Specific Anti-Patterns
-1. DO NOT trust SUMMARY.md claims without verifying the actual codebase
-2. DO NOT attempt to fix issues — you have no Write/Edit tools and that is intentional
-3. DO NOT mark stubs as SUBSTANTIVE — if it has a TODO, it's a stub
-4. DO NOT mark orphaned code as WIRED — if nothing imports it, it's orphaned
-5. DO NOT skip Level 2 or Level 3 checks — existence alone is insufficient
-6. DO NOT verify against the plan tasks — verify against the MUST-HAVES
-7. DO NOT assume passing tests mean the feature works end-to-end
-8. DO NOT ignore anti-pattern scan results just because must-haves pass
-9. DO NOT give PASSED status if ANY must-have fails at ANY level
-10. DO NOT count deferred items as gaps — they are intentionally not implemented
-11. DO NOT be lenient — your job is to find problems, not to be encouraging

package/plugins/copilot-pbr/hooks/hooks.json

@@ -1,156 +0,0 @@
-{
-  "$schema": "../../pbr/scripts/hooks-schema.json",
-  "description": "Plan-Build-Run workflow hooks for Copilot CLI plugin — delegates to shared scripts in plugins/pbr/scripts/",
-  "hooks": {
-    "sessionStart": [
-      {
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" progress-tracker.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') progress-tracker.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      }
-    ],
-    "postToolUse": [
-      {
-        "matcher": "Write|Edit",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" post-write-dispatch.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') post-write-dispatch.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "Write|Edit",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" post-write-quality.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') post-write-quality.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "Task",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" check-subagent-output.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') check-subagent-output.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "Write|Edit",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" suggest-compact.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') suggest-compact.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "Read",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" track-context-budget.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') track-context-budget.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      }
-    ],
-    "preToolUse": [
-      {
-        "matcher": "Bash",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" pre-bash-dispatch.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') pre-bash-dispatch.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "Write|Edit",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" pre-write-dispatch.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') pre-write-dispatch.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "Task",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" validate-task.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') validate-task.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "Skill",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" validate-skill-args.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') validate-skill-args.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      },
-      {
-        "matcher": "EnterPlanMode",
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" intercept-plan-mode.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') intercept-plan-mode.js",
-            "cwd": ".",
-            "timeoutSec": 15
-          }
-        ]
-      }
-    ],
-    "sessionEnd": [
-      {
-        "hooks": [
-          {
-            "type": "command",
-            "bash": "node \"$(cd \"$(dirname \"$0\")\" && pwd)/../../pbr/scripts/run-hook.js\" session-cleanup.js",
-            "powershell": "node (Join-Path (Split-Path -Parent $PSScriptRoot) 'pbr\\scripts\\run-hook.js') session-cleanup.js",
-            "cwd": ".",
-            "timeoutSec": 30
-          }
-        ]
-      }
-    ]
-  }
-}

package/plugins/copilot-pbr/plugin.json

@@ -1,30 +0,0 @@
-{
-  "name": "pbr",
-  "displayName": "Plan-Build-Run",
-  "version": "2.18.1",
-  "description": "Plan-Build-Run — Structured development workflow for GitHub Copilot CLI. Solves context rot through disciplined agent delegation, structured planning, atomic execution, and goal-backward verification.",
-  "author": {
-    "name": "SienkLogic",
-    "email": "dave@sienklogic.com"
-  },
-  "publisher": "SienkLogic",
-  "homepage": "https://github.com/SienkLogic/plan-build-run",
-  "repository": "https://github.com/SienkLogic/plan-build-run",
-  "license": "MIT",
-  "keywords": [
-    "copilot-cli",
-    "context-engineering",
-    "development-workflow",
-    "agent-delegation"
-  ],
-  "category": "developer-tools",
-  "tags": [
-    "planning",
-    "workflow",
-    "structured-development",
-    "context-management"
-  ],
-  "skills": "./skills/",
-  "agents": "./agents/",
-  "hooks": "./hooks/hooks.json"
-}

package/plugins/copilot-pbr/references/agent-anti-patterns.md

@@ -1,25 +0,0 @@
-<!-- canonical: ../../pbr/references/agent-anti-patterns.md -->
-# Universal Agent Anti-Patterns
-
-These anti-patterns apply to ALL Plan-Build-Run agents. Each agent also has role-specific anti-patterns defined in its own agent file.
-
-## Evidence and Verification
-
-1. **DO NOT** guess, assume, or rely on cached knowledge when codebase evidence is available. Read the actual files.
-2. **DO NOT** trust claims in SUMMARY.md, PLAN.md, or other agent outputs without verifying against the real codebase.
-3. **DO NOT** use subjective or vague language ("seems okay", "looks fine", "probably works"). Be specific and evidence-based.
-4. **DO NOT** present training knowledge as verified fact. Flag unverified claims explicitly.
-
-## Scope and Boundaries
-
-5. **DO NOT** exceed your role. If a task belongs to another agent, stop and recommend the correct agent.
-6. **DO NOT** modify files outside your designated scope. Read-only agents must not attempt fixes. Executors must not modify plans.
-7. **DO NOT** add features, ideas, or scope not requested. Log scope creep to deferred items instead.
-8. **DO NOT** skip steps in your verification or execution protocol, even for "obvious" cases.
-
-## Context and State
-
-9. **DO NOT** contradict locked decisions in CONTEXT.md. These are non-negotiable.
-10. **DO NOT** implement deferred ideas from CONTEXT.md. They do not exist for your purposes.
-11. **DO NOT** consume more than 50% of your context window before producing output. Write incrementally.
-12. **DO NOT** read agent definition files from `agents/*.md`. Agent definitions are auto-loaded by Claude Code via `subagent_type`. Reading them wastes context.