@sideboard-ai/core 0.1.81 → 0.1.84

package/dist/index.js

@@ -4,7 +4,7 @@ import {
   listWorkspaces,
   removeWorkspace,
   syncWorkspacesFromThreads
-} from "./chunk-K553XK7M.js";
+} from "./chunk-ODZ2ZOA4.js";
 import {
   BRIGHTSY_MCP_ALLOWED_TOOLS,
   CLAUDE_MODEL_CATALOG,
@@ -64,7 +64,7 @@ import {
   threadRequestsBrightsyMcp,
   totalTokens,
   writeInjectedMcpConfig
-} from "./chunk-XNECBC6T.js";
+} from "./chunk-R753UFSX.js";
 import {
   CLOUD_COORDINATOR_BUSY_REPLY,
   CLOUD_COORDINATOR_STOPPED_REPLY,
@@ -91,7 +91,7 @@ import {
   parseForceStopMessage,
   slackCoordinatorSourceRef,
   takenTeamSlugsForOrchestration
-} from "./chunk-6F2TQFJE.js";
+} from "./chunk-OIEFHOP7.js";
 import {
   COORDINATOR_TOOL_PLAYBOOK,
   SLACK_REPLY_FORMATTING,
@@ -100,7 +100,7 @@ import {
   enrichWorkspacesWithGithub,
   ensureGlobalCoordinatorCwd,
   formatWorkspaceInventory
-} from "./chunk-CQBQWX73.js";
+} from "./chunk-JPHG2KCC.js";
 import {
   brightsyConfigPath,
   brightsyMcpServerName,
@@ -134,7 +134,7 @@ import {
   parseCursorRunnerLine,
   pushTurnStderr,
   summarizeTurnStderr
-} from "./chunk-SEOICVGB.js";
+} from "./chunk-CBJSPTBG.js";
 import {
   caffeinateHoldPath,
   getCaffeinateHold,
@@ -165,6 +165,7 @@ import {
   formatGhLandError,
   formatGitAuthModeDirective,
   formatIpcInvokeError,
+  formatMergePrError,
   formatRateLimitResetHint,
   getPr,
   getPrChecks,
@@ -179,6 +180,7 @@ import {
   isGhRateLimitError,
   isInPrStack,
   isPlaceholderBranch,
+  isPrNotMergeableError,
   isSideboardScratchPath,
   listBranches,
   listPrs,
@@ -208,7 +210,7 @@ import {
   worktreeDisplayLabel,
   worktreeDisplayLabelForGroup,
   worktreeNameFromPath
-} from "./chunk-YVVXWWCC.js";
+} from "./chunk-XW47PL6A.js";
 import {
   ATTACHMENTS_DIR,
   LEGACY_ATTACHMENTS_DIR,
@@ -277,7 +279,10 @@ import {
   updateIntegrationsSettings,
   updateOpencodeSettings,
   writeSecureJson
-} from "./chunk-IFPN6TER.js";
+} from "./chunk-I3FRXL7J.js";
+import {
+  stripNestedElectronEnv
+} from "./chunk-5KLC2MWZ.js";
 import {
   writePrivateFile
 } from "./chunk-JT7R45JB.js";
@@ -357,7 +362,8 @@ function agentGitPrompt(action, opts) {
       return "Commit, push, and open a PR in the browser.";
     case "resolve-conflicts": {
       const base = opts?.prBase?.trim().replace(/^refs\/heads\//, "");
-      return base ? `Merge origin/${base} into this branch. Then push.` : "Fix merge conflicts.";
+      const named = base ? ` (${base})` : "";
+      return `Merge the remote branch${named} into your branch and resolve conflicts. Then, commit and push your changes.`;
     }
     case "merge":
       return "Merge PR.";
@@ -1310,9 +1316,9 @@ async function spawnAgentTurn(thread, input, onEvent) {
       `Cannot spawn ${thread.agent}: thread ${thread.id} has no worktreePath`
     );
   }
-  const { isGlobalThread: isGlobalThread2 } = await import("./global-workspace-DZM4ZFGU.js");
+  const { isGlobalThread: isGlobalThread2 } = await import("./global-workspace-73OAKD3C.js");
   if (isGlobalThread2(thread)) {
-    const { ensureGlobalCoordinatorCwd: ensureGlobalCoordinatorCwd2 } = await import("./coordinator-prompt-JQF72JKX.js");
+    const { ensureGlobalCoordinatorCwd: ensureGlobalCoordinatorCwd2 } = await import("./coordinator-prompt-RCTIIZ6C.js");
     ensureGlobalCoordinatorCwd2(
       isOrchestratorThread(thread) ? { orchestratorThreadId: thread.id } : void 0
     );
@@ -1511,7 +1517,7 @@ function formatWorktreeDirective(thread, opts) {
     '- "Fix CI: <name>." \u2192 investigate that failing check, fix it, commit, and push.'
   );
   lines.push(
-    '- "Update the branch." / "Fix merge conflicts." / "Merge origin/<base> into this branch. Then push." \u2192 sync with the PR base (merge or rebase), resolve conflicts carefully, commit, and push until the PR is mergeable.'
+    '- "Merge the remote branch (<base>) into your branch and resolve conflicts. Then, commit and push your changes." \u2192 fetch the PR base, merge it into this branch, resolve conflicts carefully, commit, and push until the PR is mergeable.'
   );
   lines.push(
     '- "Address review comments." \u2192 read PR review feedback, make the requested changes, commit, and push.'
@@ -1519,11 +1525,22 @@ function formatWorktreeDirective(thread, opts) {
   lines.push(
     '- "Merge PR." \u2192 merge this thread\'s open pull request on GitHub (this phrase is the explicit ask). If `gh stack view` shows a stack, use `gh stack merge`; otherwise `gh pr merge` (respect repo defaults / squash vs merge). Do not force-push main/master or merge locally into the main checkout.'
   );
+  lines.push("");
+  lines.push(formatProcessGuideDirective());
   return lines.join("\n");
 }
 function formatWorktreeReminder() {
   return "Sideboard worktree: stay in this cwd for all file and git work. Push and open PRs against origin, never upstream. Do not edit the main repo checkout.";
 }
+function formatProcessGuideDirective() {
+  return [
+    "Process guides (recurring work only):",
+    "- If `.claude/skills/graph-engineering/SKILL.md` exists, follow it (`/graph-engineering`) for migrations, ports, batch fixes, and other fan-out. Judge first; state on disk; grow the rulebook; do not patch around it.",
+    "- If this same shape of work will happen again, write `.claude/skills/<kebab-name>/SKILL.md` in this worktree (Claude Code project skill). Sideboard `/name`, Claude Code, and `attach` all load that path. Do not leave the method only in chat.",
+    "- Do not write new skills under `.sideboard/skills` \u2014 native agents do not scan it. Point Codex/OpenCode at the file from `AGENTS.md`. Optional: symlink `.cursor/skills/<name>` to the Claude skill.",
+    "- Skip a guide for a one-off. If a matching skill exists, follow it. Same miss twice \u2192 edit the skill (or `.sideboard/review.md`), do not patch around it."
+  ].join("\n");
+}
 function formatArtifactDirective() {
   return [
     "Sideboard side column (desktop UI):",
@@ -1541,9 +1558,22 @@ function formatArtifactDirective() {
     "Files / media browser (CMS file manager column):",
     "4) Call Sideboard MCP `present_files` with optional title, path, and datasource (brightsy|memory).",
     "   Opens the Files column for browse/upload/pick. Do NOT say a file manager UI is missing.",
-    "Never say artifacts, CMS UI, or the Files column are unavailable. Prefer present_schema for list/edit/publish; present_files for storage UI; html fences for standalone pages."
+    "Multiple-choice questions (any mode \u2014 not only Plan):",
+    "5) Call Sideboard MCP `ask_user` when the user should pick from predefined options (approach forks, requirements, which API). First write a short chat message that explains the decision and what each option means (tradeoffs, when to pick it). Include a description on every option. After calling, stop and wait for their next message with answers. Do not ask multiple-choice questions as plain chat bullets \u2014 use ask_user so Sideboard shows the composer picker.",
+    "Never say artifacts, CMS UI, or the Files column are unavailable. Prefer present_schema for list/edit/publish; present_files for storage UI; html fences for standalone pages; ask_user for predefined-option questions."
   ].join("\n");
 }
+function formatUiReminder() {
+  return [
+    "Sideboard side column (important):",
+    "There is no claude.ai Artifact tool here \u2014 that is normal.",
+    "HTML/SVG/markdown: ```html fence or MCP present_artifact.",
+    "CMS forms/tables: MCP present_schema (Brightsy resource_id or inline schema+schemaUi).",
+    "Files column: MCP present_files (brightsy account storage or memory).",
+    "Do not say artifacts/CMS UI are unavailable.",
+    "Multiple-choice questions: MCP ask_user (composer picker, any mode). Explain options in chat first, then wait for answers."
+  ].join(" ");
+}
 var FILES_BY_AGENT = {
   claude: [
     "CLAUDE.md",
@@ -1738,16 +1768,6 @@ async function captureLoginEnv() {
   cachedLoginEnv = { ...process.env };
   return { ...cachedLoginEnv };
 }
-var NESTED_ELECTRON_ENV_PREFIXES = ["ELECTRON_", "CHROME_"];
-function stripNestedElectronEnv(env) {
-  const out = { ...env };
-  for (const key of Object.keys(out)) {
-    if (NESTED_ELECTRON_ENV_PREFIXES.some((prefix) => key.startsWith(prefix))) {
-      delete out[key];
-    }
-  }
-  return out;
-}
 function buildWorkspaceScriptEnv(opts, baseEnv) {
   const env = stripNestedElectronEnv({
     ...baseEnv ?? process.env
@@ -3813,7 +3833,7 @@ async function createThread(input, _onSetupLine) {
   return readThread(thread.id) ?? thread;
 }
 async function listLinearIssues(agent, repoPath) {
-  const { getAdapter: getAdapter2 } = await import("./agents-UQ7D6U6L.js");
+  const { getAdapter: getAdapter2 } = await import("./agents-JFXM66QA.js");
   await requireAgent(agent, { requireLinear: true });
   const adapter = getAdapter2(agent);
   if (!adapter.listLinearIssues) {
@@ -4356,7 +4376,7 @@ async function adoptThread(input) {
     messages: input.messages ?? []
   });
   writeThread(thread);
-  const { ensureWorkspace: ensureWorkspace2 } = await import("./workspaces-QLRCOXAY.js");
+  const { ensureWorkspace: ensureWorkspace2 } = await import("./workspaces-SRITISKA.js");
   await ensureWorkspace2(repoPath);
   return thread;
 }
@@ -5489,6 +5509,10 @@ File: src/client/frontends/desktop/core/UserData.ts
 
 **Approve** \u2014 Diff is scoped, behavior looks correct, and there are no blocking issues. Safe to merge.
 </example>
+
+## Growing the rules
+
+If a blocking issue is a missing or ambiguous repo rule that will recur, say so and propose one sentence for \`.sideboard/review.md\` or a \`.claude/skills/<name>/SKILL.md\`. Do not only patch this diff when the same miss will happen again. New skills go under \`.claude/skills\` (Claude Code / attach) \u2014 not \`.sideboard/skills\`.
 `;
 
 // src/review/request-review.ts
@@ -5873,7 +5897,7 @@ var Orchestrator = class {
           orphans: orphans.map((o) => ({ path: o.path, repoPath: o.repoPath }))
         });
       }
-      const { autoCleanupOrphansEnabled: autoCleanupOrphansEnabled2 } = await import("./app-settings-6IOQYGBK.js");
+      const { autoCleanupOrphansEnabled: autoCleanupOrphansEnabled2 } = await import("./app-settings-K6RFCRF6.js");
       if (autoCleanupOrphansEnabled2() && shouldRunWorktreeCleanup() && orphans.length > 0) {
         await cleanupOrphanWorktrees({ repoPaths });
       }
@@ -6030,7 +6054,7 @@ var Orchestrator = class {
   }
   async finishCreateThread(threadId, prompt) {
     await this.runSetupAfterCreate(threadId);
-    const { autoRunAfterSetupEnabled: autoRunAfterSetupEnabled2 } = await import("./app-settings-6IOQYGBK.js");
+    const { autoRunAfterSetupEnabled: autoRunAfterSetupEnabled2 } = await import("./app-settings-K6RFCRF6.js");
     if (autoRunAfterSetupEnabled2()) {
       try {
         await this.startDev(threadId);
@@ -6272,14 +6296,7 @@ var Orchestrator = class {
         SLACK_REPLY_FORMATTING
       ].join("\n") : null
     ].filter(Boolean).join("\n") : null;
-    const artifactReminder = thread.agent !== "brightsy" ? [
-      "Sideboard side column (important):",
-      "There is no claude.ai Artifact tool here \u2014 that is normal.",
-      "HTML/SVG/markdown: ```html fence or MCP present_artifact.",
-      "CMS forms/tables: MCP present_schema (Brightsy resource_id or inline schema+schemaUi).",
-      "Files column: MCP present_files (brightsy account storage or memory).",
-      "Do not say artifacts/CMS UI are unavailable."
-    ].join(" ") : null;
+    const artifactReminder = thread.agent !== "brightsy" ? formatUiReminder() : null;
     const worktreeReminder = thread.agent !== "brightsy" && !isOrchestratorThread(thread) ? formatWorktreeReminder() : null;
     const slackReplyContext = formatSlackRepliesForTurn(
       pendingSlackExternalReplies(thread.messages)
@@ -6308,7 +6325,7 @@ var Orchestrator = class {
     }
     const isBrightsy = fresh.agent === "brightsy";
     const isOrchestration = isOrchestratorThread(fresh);
-    const { autoRenameBranchEnabled: autoRenameBranchEnabled2, getGithubGitAuthMode: getGithubGitAuthMode2 } = await import("./app-settings-6IOQYGBK.js");
+    const { autoRenameBranchEnabled: autoRenameBranchEnabled2, getGithubGitAuthMode: getGithubGitAuthMode2 } = await import("./app-settings-K6RFCRF6.js");
     const gitAuthMode = getGithubGitAuthMode2();
     const worktreeDirective = isBrightsy || isOrchestration ? null : formatWorktreeDirective(fresh, {
       githubSlug: await resolveGithubRepoSlug(fresh.worktreePath).catch(
@@ -6418,7 +6435,7 @@ var Orchestrator = class {
       }
       let lastStderr = summarizeTurnStderr(stderrTail);
       let detail = lastStderr || (exitCode !== 0 ? fallbackTurnFailDetail(assistantText) : "");
-      if (exitCode !== 0 && !assistantText && parts.length === 0 && !this.stoppedTurns.has(threadId) && looksLikeInvalidAgentSession(detail) && this.requireThread(threadId).sessionId && this.requireThread(threadId).agent !== "cursor" && this.requireThread(threadId).agent !== "brightsy") {
+      if (exitCode !== 0 && !assistantText && parts.length === 0 && !this.stoppedTurns.has(threadId) && looksLikeInvalidAgentSession(detail) && this.requireThread(threadId).sessionId && this.requireThread(threadId).agent !== "brightsy") {
         updateThread(threadId, { sessionId: null });
         pushTurnStderr(
           stderrTail,
@@ -6973,7 +6990,9 @@ var Orchestrator = class {
       reviewDecision: null,
       baseRefName: "",
       headRefName: "",
-      isInMergeQueue: false
+      isInMergeQueue: false,
+      mergeable: null,
+      mergeStateStatus: null
     };
     await this.persistPrMetaAndMaybeArchive(thread, metaLike);
     return { url: metaLike.url, state };
@@ -7023,7 +7042,7 @@ var Orchestrator = class {
         updateThread(thread.id, { title: meta.title });
       }
     }
-    const { autoArchiveOnMergeEnabled: autoArchiveOnMergeEnabled2 } = await import("./app-settings-6IOQYGBK.js");
+    const { autoArchiveOnMergeEnabled: autoArchiveOnMergeEnabled2 } = await import("./app-settings-K6RFCRF6.js");
     const latest = this.requireThread(thread.id);
     if (!shouldAutoArchiveOnPrMerge({
       previousPrState: prevState || null,
@@ -7311,7 +7330,7 @@ var Orchestrator = class {
     this.emit({ type: "status_changed", threadId: archived.id, status: "archived" });
     if (thread.repoPath && !isGlobalRepoPath(thread.repoPath)) {
       try {
-        const { ensureWorkspace: ensureWorkspace2 } = await import("./workspaces-QLRCOXAY.js");
+        const { ensureWorkspace: ensureWorkspace2 } = await import("./workspaces-SRITISKA.js");
         await ensureWorkspace2(thread.repoPath);
       } catch {
       }
@@ -7333,7 +7352,7 @@ var Orchestrator = class {
         await runArchiveScript(thread.repoPath, thread.worktreePath);
       } catch {
       }
-      const { deleteBranchOnPurgeEnabled: deleteBranchOnPurgeEnabled2 } = await import("./app-settings-6IOQYGBK.js");
+      const { deleteBranchOnPurgeEnabled: deleteBranchOnPurgeEnabled2 } = await import("./app-settings-K6RFCRF6.js");
       const deleteBranch = opts?.deleteBranch ?? deleteBranchOnPurgeEnabled2();
       await removeWorktree(thread.repoPath, thread.worktreePath, {
         deleteBranch: deleteBranch ? thread.branchName : void 0
@@ -7354,7 +7373,7 @@ var Orchestrator = class {
       return restored2;
     }
     if (!existsSync15(thread.worktreePath)) {
-      const { createThreadWorktree: createThreadWorktree2 } = await import("./worktree-5VLLFI5W.js");
+      const { createThreadWorktree: createThreadWorktree2 } = await import("./worktree-SGZVAWOQ.js");
       const { execa: execa6 } = await import("execa");
       const slug = thread.worktreePath.split("/").pop();
       const dest = thread.worktreePath;
@@ -7463,7 +7482,7 @@ async function startOrchestration(opts) {
     sourceRef: "default",
     ...createOpts
   }).catch(async () => {
-    const { resolveDefaultBranch: resolveDefaultBranch2, resolveRepoRoot: resolveRepoRoot2 } = await import("./worktree-5VLLFI5W.js");
+    const { resolveDefaultBranch: resolveDefaultBranch2, resolveRepoRoot: resolveRepoRoot2 } = await import("./worktree-SGZVAWOQ.js");
     const repo = await resolveRepoRoot2(repoPath);
     const def = await resolveDefaultBranch2(repo);
     return createThread({
@@ -8215,7 +8234,7 @@ function withTimeout(promise, ms, label) {
 async function startMcpServer() {
   const orch = getOrchestrator();
   try {
-    const { maxConcurrentAgents: maxConcurrentAgents2 } = await import("./app-settings-6IOQYGBK.js");
+    const { maxConcurrentAgents: maxConcurrentAgents2 } = await import("./app-settings-K6RFCRF6.js");
     orch.setMaxConcurrent(maxConcurrentAgents2());
   } catch {
   }
@@ -8320,7 +8339,7 @@ async function startMcpServer() {
   );
   server.tool(
     "ask_user",
-    "Ask the user clarifying multiple-choice questions in Sideboard\u2019s composer (plan mode). Before calling, write a short chat message explaining the decision and what each option means. Include a description on every option. Use for approach forks and requirements \u2014 not for \u201Cis the plan ready?\u201D. After calling, stop and wait for their next message with answers.",
+    "Ask the user clarifying multiple-choice questions in Sideboard\u2019s composer (any mode \u2014 not only Plan). Before calling, write a short chat message explaining the decision and what each option means. Include a description on every option. Use when the user should pick from predefined options (approach forks, requirements, which API) \u2014 not for \u201Cis the plan ready?\u201D. After calling, stop and wait for their next message with answers.",
     {
       questions: z3.array(
         z3.object({
@@ -8425,7 +8444,7 @@ async function startMcpServer() {
   registerLinearTools(server);
   if (sideboardMcpProfile() !== "worktree") {
     const { getCaffeinateHold: getCaffeinateHold2, setCaffeinateHold: setCaffeinateHold2 } = await import("./caffeinate-hold-EAZNWJBE.js");
-    const { resolveNewThreadOptions: resolveNewThreadOptions2, resolveThreadDefaults: resolveThreadDefaults2 } = await import("./app-settings-6IOQYGBK.js");
+    const { resolveNewThreadOptions: resolveNewThreadOptions2, resolveThreadDefaults: resolveThreadDefaults2 } = await import("./app-settings-K6RFCRF6.js");
     const accountDefaults = resolveThreadDefaults2();
     const accountDefaultsHint = `Account defaults: agent=${accountDefaults.agent}, model=${accountDefaults.model?.trim() || "Auto"}, effort=${accountDefaults.effort}`;
     server.tool(
@@ -11172,6 +11191,7 @@ export {
   REVIEW_REQUEST_NAME,
   REVIEW_REQUEST_PATH,
   REVIEW_REQUEST_PREFILL,
+  REVIEW_REQUEST_TEMPLATE,
   SIDEBOARD_FORCE_STOP,
   SIDEBOARD_MCP_ALLOWED_TOOLS,
   SIDEBOARD_MCP_PROFILE_ENV,
@@ -11320,9 +11340,11 @@ export {
   formatGhLandError,
   formatGitAuthModeDirective,
   formatIpcInvokeError,
+  formatMergePrError,
   formatMessagesAsTranscript,
   formatPlanQuestionAnswers,
   formatPlanQuestionsForChat,
+  formatProcessGuideDirective,
   formatRateLimitResetHint,
   formatRenameBranchDirective,
   formatSlackExternalReplyPrompt,
@@ -11330,6 +11352,7 @@ export {
   formatSlackRepliesForTurn,
   formatSlackSignedReply,
   formatTranscriptMarkdown,
+  formatUiReminder,
   formatWorkspaceInventory,
   formatWorktreeDirective,
   formatWorktreeReminder,
@@ -11404,6 +11427,7 @@ export {
   isOrchestratorThread,
   isPidAlive,
   isPlaceholderBranch,
+  isPrNotMergeableError,
   isPresentPlanToolName,
   isSessionQuotaLimit,
   isSideboardScratchPath,