@shuvi/eslint-plugin-shuvi 1.0.32 → 1.0.34

package/lib/index.js

@@ -5,7 +5,8 @@ module.exports = {
         'no-html-link-for-pages': require('./rules/no-html-link-for-pages').default,
         'no-typos-page': require('./rules/no-typos-page').default,
         'no-typos-custom-app': require('./rules/no-typos-custom-app').default,
-        'no-typos-custom-server': require('./rules/no-typos-custom-server').default
+        'no-typos-custom-server': require('./rules/no-typos-custom-server').default,
+        'no-export-loader-default-from-same-module': require('./rules/no-export-loader-default-from-same-module').default
     },
     configs: {
         recommended: {
@@ -16,7 +17,8 @@ module.exports = {
                 '@shuvi/shuvi/no-typos-page': 'error',
                 '@shuvi/shuvi/no-typos-custom-app': 'error',
                 '@shuvi/shuvi/no-typos-custom-server': 'error',
-                '@shuvi/shuvi/no-html-link-for-pages': 'error'
+                '@shuvi/shuvi/no-html-link-for-pages': 'error',
+                '@shuvi/shuvi/no-export-loader-default-from-same-module': 'error'
             }
         }
     }

package/lib/rules/no-export-loader-default-from-same-module.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("eslint").Rule.RuleModule;
+export default _default;

package/lib/rules/no-export-loader-default-from-same-module.js

@@ -0,0 +1,62 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const define_rule_1 = require("../utils/define-rule");
+const is_page_1 = require("../utils/is-page");
+const WHITELIST = ['loader', 'default'];
+exports.default = (0, define_rule_1.defineRule)({
+    meta: {
+        docs: {
+            description: `Prohibit exporting ${WHITELIST.join(',')} module from a single module, please export separately from different modules.`,
+            recommended: true
+        },
+        type: 'problem',
+        schema: []
+    },
+    create(context) {
+        const exported = {};
+        const nodes = new Set();
+        return {
+            ExportNamedDeclaration(node) {
+                const fileName = context.getFilename();
+                if (!fileName || !(0, is_page_1.isPage)(fileName)) {
+                    return;
+                }
+                if (!node.source) {
+                    return;
+                }
+                if (!node.specifiers || node.specifiers.length === 0) {
+                    return;
+                }
+                const sourceValue = node.source.value;
+                node.specifiers.forEach(specifier => {
+                    const name = specifier.exported.name;
+                    if (WHITELIST.includes(name)) {
+                        if (exported[name]) {
+                            context.report({
+                                node,
+                                message: `${name} duplicate export from ${sourceValue}`
+                            });
+                        }
+                        exported[name] = sourceValue;
+                        nodes.add(node);
+                    }
+                });
+            },
+            'Program:exit': function onExit() {
+                const sourceValues = Object.values(exported);
+                const length = sourceValues.length;
+                if (!length) {
+                    return;
+                }
+                if (new Set(sourceValues).size !== length) {
+                    nodes.forEach(node => {
+                        context.report({
+                            node,
+                            message: `Prohibit exporting ${WHITELIST.join(', ')} module from a single module, please export separately from different modules. https://shuvijs.github.io/shuvijs.org/docs/guides/Data%20Fetching#import-loader-from-other-modules`
+                        });
+                    });
+                }
+            }
+        };
+    }
+});

package/lib/rules/no-typos-page.js

@@ -2,8 +2,8 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const define_rule_1 = require("../utils/define-rule");
 const url_1 = require("../utils/url");
+const is_page_1 = require("../utils/is-page");
 const EXPORT_FUNCTIONS = ['loader'];
-const PAGEREG = /routes\/.*page\.(j|t)sx?$/;
 exports.default = (0, define_rule_1.defineRule)({
     meta: {
         docs: {
@@ -35,7 +35,7 @@ exports.default = (0, define_rule_1.defineRule)({
             ExportNamedDeclaration(node) {
                 var _a;
                 const fileName = context.getFilename();
-                if (!fileName || !PAGEREG.test(fileName)) {
+                if (!fileName || !(0, is_page_1.isPage)(fileName)) {
                     return;
                 }
                 const decl = node.declaration;

package/lib/utils/is-page.d.ts

@@ -0,0 +1 @@
+export declare function isPage(path: string): boolean;

package/lib/utils/is-page.js

@@ -0,0 +1,8 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.isPage = void 0;
+const PAGEREG = /routes\/.*page\.(j|t)sx?$/;
+function isPage(path) {
+    return PAGEREG.test(path);
+}
+exports.isPage = isPage;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shuvi/eslint-plugin-shuvi",
-  "version": "1.0.32",
+  "version": "1.0.34",
   "description": "ESLint plugin for Shuvi.",
   "main": "lib/index.js",
   "license": "MIT",
@@ -18,8 +18,8 @@
     "build": "tsc -p tsconfig.json"
   },
   "dependencies": {
-    "@shuvi/router": "1.0.32",
-    "@shuvi/platform-shared": "1.0.32"
+    "@shuvi/router": "1.0.34",
+    "@shuvi/platform-shared": "1.0.34"
   },
   "devDependencies": {
     "@types/eslint": "7.28.0",