@shrkcrft/impact-engine 0.1.0-alpha.22 → 0.1.0-alpha.24

package/dist/engine/analyzer.d.ts

@@ -1,3 +1,4 @@
+import { GraphQueryApi } from '@shrkcrft/graph';
 import { type IGraphImpactAnalysis } from '../schema/impact-analysis.js';
 export type IGraphImpactInput = {
     kind: 'files';
@@ -26,4 +27,58 @@ export interface IAnalyzeOptions {
  *     with a diagnostic, treated as zero-dependent
  */
 export declare function analyzeGraphImpact(input: IGraphImpactInput, options: IAnalyzeOptions): IGraphImpactAnalysis;
+/** Schema id for a {@link findDeletedOrphans} report. */
+export declare const DELETED_ORPHANS_SCHEMA: "sharkcraft.deleted-orphans/v1";
+/** A surviving file that still imports / references now-deleted code. */
+export interface IDeletedOrphan {
+    /** Graph node id of the surviving importer / caller file. */
+    id: string;
+    /** Project-relative path of the surviving file. */
+    path?: string;
+    /** Display label (basename / node label). */
+    label: string;
+    /** 1-based source line of the import statement / use site, when known. */
+    line?: number;
+    /** How the orphan still reaches the deleted code. */
+    via: 'import' | 'reference';
+    /** The deleted file path the orphan still points at. */
+    deletedFile: string;
+    /** When `via === 'reference'`, the deleted symbol that is still referenced. */
+    symbol?: string;
+}
+/** Result of a {@link findDeletedOrphans} query. */
+export interface IDeletedOrphanReport {
+    schema: typeof DELETED_ORPHANS_SCHEMA;
+    /** Deleted paths that resolved to a node in the current index snapshot. */
+    resolvedDeleted: readonly string[];
+    /** Deleted paths NOT in the index (already reindexed, or never indexed). */
+    unresolvedDeleted: readonly string[];
+    /** Surviving files that still import / reference the deleted files or their symbols. */
+    orphans: readonly IDeletedOrphan[];
+    /** Free-form diagnostics. */
+    diagnostics: readonly string[];
+}
+/**
+ * Reverse-of-impact query: given files DELETED in the working tree, find the
+ * surviving files — in the CURRENT index snapshot — that still import them or
+ * still reference a symbol they declared. Each such file is an orphaned
+ * importer whose build would break once the delete lands.
+ *
+ * Two edge classes are walked:
+ *   - `imports-file` into the deleted file → direct importers (this also
+ *     surfaces a barrel that `export … from` the deleted file).
+ *   - references/calls to symbols the deleted file declared → consumers that
+ *     reach the symbol through a package barrel re-export. The indexer already
+ *     rewrites those reference edges to the REAL declaring symbol id
+ *     (`resolveReExportedReferenceEdges`), so a cross-package consumer of a
+ *     re-exported deleted symbol is caught here, not just the barrel.
+ *
+ * Assumption: the graph is the pre-edit snapshot. A not-yet-reindexed delete
+ * still carries its inbound edges, so the deleted file node + its symbols are
+ * present and queryable. Once `shrk graph index` re-runs, those nodes vanish
+ * and `unresolvedDeleted` grows instead — surface a diagnostic, never throw.
+ * Importers that are themselves in the deleted set are excluded (they are
+ * going away too).
+ */
+export declare function findDeletedOrphans(graph: GraphQueryApi, deletedFiles: readonly string[]): IDeletedOrphanReport;
 //# sourceMappingURL=analyzer.d.ts.map

package/dist/engine/analyzer.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"analyzer.d.ts","sourceRoot":"","sources":["../../src/engine/analyzer.ts"],"names":[],"mappings":"AAYA,OAAO,EAIL,KAAK,oBAAoB,EAC1B,MAAM,8BAA8B,CAAC;AAGtC,MAAM,MAAM,iBAAiB,GACzB;IAAE,IAAI,EAAE,OAAO,CAAC;IAAC,KAAK,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,GAC3C;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,GACpC;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,GAAG,EAAE,MAAM,CAAA;CAAE,CAAC;AAEpC,MAAM,WAAW,eAAe;IAC9B,WAAW,EAAE,MAAM,CAAC;IACpB,qCAAqC;IACrC,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,+CAA+C;IAC/C,QAAQ,CAAC,EAAE,MAAM,CAAC;CACnB;AAED;;;;;;;;GAQG;AACH,wBAAgB,kBAAkB,CAChC,KAAK,EAAE,iBAAiB,EACxB,OAAO,EAAE,eAAe,GACvB,oBAAoB,CA+OtB"}
+{"version":3,"file":"analyzer.d.ts","sourceRoot":"","sources":["../../src/engine/analyzer.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,aAAa,EAId,MAAM,iBAAiB,CAAC;AAMzB,OAAO,EAIL,KAAK,oBAAoB,EAC1B,MAAM,8BAA8B,CAAC;AAGtC,MAAM,MAAM,iBAAiB,GACzB;IAAE,IAAI,EAAE,OAAO,CAAC;IAAC,KAAK,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,GAC3C;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,GACpC;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,GAAG,EAAE,MAAM,CAAA;CAAE,CAAC;AAEpC,MAAM,WAAW,eAAe;IAC9B,WAAW,EAAE,MAAM,CAAC;IACpB,qCAAqC;IACrC,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,+CAA+C;IAC/C,QAAQ,CAAC,EAAE,MAAM,CAAC;CACnB;AAED;;;;;;;;GAQG;AACH,wBAAgB,kBAAkB,CAChC,KAAK,EAAE,iBAAiB,EACxB,OAAO,EAAE,eAAe,GACvB,oBAAoB,CAsPtB;AA8FD,yDAAyD;AACzD,eAAO,MAAM,sBAAsB,EAAG,+BAAwC,CAAC;AAE/E,yEAAyE;AACzE,MAAM,WAAW,cAAc;IAC7B,6DAA6D;IAC7D,EAAE,EAAE,MAAM,CAAC;IACX,mDAAmD;IACnD,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,6CAA6C;IAC7C,KAAK,EAAE,MAAM,CAAC;IACd,0EAA0E;IAC1E,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,qDAAqD;IACrD,GAAG,EAAE,QAAQ,GAAG,WAAW,CAAC;IAC5B,wDAAwD;IACxD,WAAW,EAAE,MAAM,CAAC;IACpB,+EAA+E;IAC/E,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,oDAAoD;AACpD,MAAM,WAAW,oBAAoB;IACnC,MAAM,EAAE,OAAO,sBAAsB,CAAC;IACtC,2EAA2E;IAC3E,eAAe,EAAE,SAAS,MAAM,EAAE,CAAC;IACnC,4EAA4E;IAC5E,iBAAiB,EAAE,SAAS,MAAM,EAAE,CAAC;IACrC,wFAAwF;IACxF,OAAO,EAAE,SAAS,cAAc,EAAE,CAAC;IACnC,6BAA6B;IAC7B,WAAW,EAAE,SAAS,MAAM,EAAE,CAAC;CAChC;AAQD;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,wBAAgB,kBAAkB,CAChC,KAAK,EAAE,aAAa,EACpB,YAAY,EAAE,SAAS,MAAM,EAAE,GAC9B,oBAAoB,CA4EtB"}

package/dist/engine/analyzer.js

@@ -1,6 +1,6 @@
-import { execSync } from 'node:child_process';
 import { EdgeKind, GraphQueryApi, GraphStore, NodeKind, } from '@shrkcrft/graph';
 import { BridgeStore, RuleGraphQueryApi, } from '@shrkcrft/rule-graph';
+import { runGitLines } from '@shrkcrft/shared';
 import { GRAPH_IMPACT_SCHEMA, } from "../schema/impact-analysis.js";
 import { classifyRisk } from "./risk-score.js";
 /**
@@ -144,10 +144,17 @@ export function analyzeGraphImpact(input, options) {
             }
         }
     }
+    // True blast radius BEFORE the display cap. The displayed list is sliced to
+    // `limit`, but risk must reflect the uncapped caller-file count — otherwise a
+    // 5000-caller change and a 200-caller change score identically.
+    const callerFilesTotal = callerSet.size;
     const affectedCallerFiles = [...callerSet]
         .map((id) => toRef(api, id))
         .filter((r) => r !== undefined)
         .slice(0, limit);
+    if (callerFilesTotal > limit) {
+        truncations['callers'] = callerFilesTotal - limit;
+    }
     // Affected packages.
     const packagesSet = new Set();
     for (const id of reachable) {
@@ -241,7 +248,7 @@ export function analyzeGraphImpact(input, options) {
         rulesTouched: affectedRules.length,
         templatesTouched: affectedTemplates.length,
         publicApiTouched,
-        callerFilesCount: affectedCallerFiles.length,
+        callerFilesCount: callerFilesTotal,
     });
     const validationScope = deriveValidationScope({
         risk,
@@ -349,18 +356,115 @@ function missingGraphPayload(input, diagnostics) {
     };
 }
 function changedFilesSince(projectRoot, ref) {
-    try {
-        const raw = execSync(`git diff --name-only ${ref}`, {
-            cwd: projectRoot,
-            encoding: 'utf8',
-            stdio: ['ignore', 'pipe', 'ignore'],
-        });
-        return raw
-            .split('\n')
-            .map((s) => s.trim())
-            .filter((s) => s.length > 0);
-    }
-    catch {
-        return [];
+    // Shell-free + high-maxBuffer: a large changeset no longer ENOBUFS-crashes
+    // the gitref impact analysis. Failure → [] (caller degrades cleanly).
+    return runGitLines(projectRoot, ['diff', '--name-only', ref]).lines;
+}
+/** Schema id for a {@link findDeletedOrphans} report. */
+export const DELETED_ORPHANS_SCHEMA = 'sharkcraft.deleted-orphans/v1';
+/** Read the import-statement line carried on an `imports-file` edge. */
+function importEdgeLine(data) {
+    const v = data?.['line'];
+    return typeof v === 'number' && Number.isFinite(v) ? v : undefined;
+}
+/**
+ * Reverse-of-impact query: given files DELETED in the working tree, find the
+ * surviving files — in the CURRENT index snapshot — that still import them or
+ * still reference a symbol they declared. Each such file is an orphaned
+ * importer whose build would break once the delete lands.
+ *
+ * Two edge classes are walked:
+ *   - `imports-file` into the deleted file → direct importers (this also
+ *     surfaces a barrel that `export … from` the deleted file).
+ *   - references/calls to symbols the deleted file declared → consumers that
+ *     reach the symbol through a package barrel re-export. The indexer already
+ *     rewrites those reference edges to the REAL declaring symbol id
+ *     (`resolveReExportedReferenceEdges`), so a cross-package consumer of a
+ *     re-exported deleted symbol is caught here, not just the barrel.
+ *
+ * Assumption: the graph is the pre-edit snapshot. A not-yet-reindexed delete
+ * still carries its inbound edges, so the deleted file node + its symbols are
+ * present and queryable. Once `shrk graph index` re-runs, those nodes vanish
+ * and `unresolvedDeleted` grows instead — surface a diagnostic, never throw.
+ * Importers that are themselves in the deleted set are excluded (they are
+ * going away too).
+ */
+export function findDeletedOrphans(graph, deletedFiles) {
+    const deletedSet = new Set(deletedFiles);
+    const resolvedDeleted = [];
+    const unresolvedDeleted = [];
+    const diagnostics = [];
+    const orphans = [];
+    const seen = new Set();
+    const pushOrphan = (o) => {
+        const key = `${o.id}|${o.via}|${o.deletedFile}|${o.symbol ?? ''}`;
+        if (seen.has(key))
+            return;
+        seen.add(key);
+        orphans.push(o);
+    };
+    for (const rel of deletedFiles) {
+        const fileNode = graph.findFile(rel);
+        if (!fileNode) {
+            unresolvedDeleted.push(rel);
+            diagnostics.push(`deleted file not in index (already reindexed?): ${rel}`);
+            continue;
+        }
+        resolvedDeleted.push(rel);
+        // 1) Direct importers of the deleted file (incl. barrels re-exporting it).
+        const neighbours = graph.neighbours(fileNode.id);
+        if (neighbours) {
+            for (const inEdge of neighbours.in) {
+                if (inEdge.edge.kind !== EdgeKind.ImportsFile)
+                    continue;
+                const source = inEdge.source;
+                if (!('kind' in source))
+                    continue; // unresolved placeholder — no node
+                if (source.path && deletedSet.has(source.path))
+                    continue; // importer also deleted
+                pushOrphan({
+                    id: source.id,
+                    ...(source.path ? { path: source.path } : {}),
+                    label: source.label,
+                    ...(importEdgeLine(inEdge.edge.data) ? { line: importEdgeLine(inEdge.edge.data) } : {}),
+                    via: 'import',
+                    deletedFile: rel,
+                });
+            }
+        }
+        // 2) Surviving references/calls to symbols the deleted file declared.
+        for (const sym of graph.symbolsIn(fileNode.id)) {
+            for (const site of graph.referenceSitesOf(sym.id)) {
+                if (site.node.path && deletedSet.has(site.node.path))
+                    continue; // caller also deleted
+                pushOrphan({
+                    id: site.node.id,
+                    ...(site.node.path ? { path: site.node.path } : {}),
+                    label: site.node.label,
+                    ...(typeof site.line === 'number' ? { line: site.line } : {}),
+                    via: 'reference',
+                    deletedFile: rel,
+                    symbol: sym.label,
+                });
+            }
+        }
     }
+    orphans.sort((a, b) => {
+        const pa = a.path ?? a.id;
+        const pb = b.path ?? b.id;
+        if (pa !== pb)
+            return pa.localeCompare(pb);
+        if ((a.line ?? 0) !== (b.line ?? 0))
+            return (a.line ?? 0) - (b.line ?? 0);
+        if (a.via !== b.via)
+            return a.via.localeCompare(b.via);
+        return (a.symbol ?? '').localeCompare(b.symbol ?? '');
+    });
+    return {
+        schema: DELETED_ORPHANS_SCHEMA,
+        resolvedDeleted,
+        unresolvedDeleted,
+        orphans,
+        diagnostics,
+    };
 }

package/dist/engine/risk-score.d.ts

@@ -1,4 +1,4 @@
-import type { IGraphImpactAnalysis, RiskLevel } from '../schema/impact-analysis.js';
+import type { RiskLevel } from '../schema/impact-analysis.js';
 interface IRiskInputs {
     directCount: number;
     transitiveCount: number;
@@ -25,6 +25,4 @@ export declare function classifyRisk(input: IRiskInputs): {
 };
 /** Re-export so callers can read the (partial) inputs back for tests. */
 export type { IRiskInputs };
-/** Defensive constructor used by analyzer tests. */
-export declare function emptyImpactAnalysis(): Partial<IGraphImpactAnalysis>;
 //# sourceMappingURL=risk-score.d.ts.map

package/dist/engine/risk-score.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"risk-score.d.ts","sourceRoot":"","sources":["../../src/engine/risk-score.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,oBAAoB,EAAE,SAAS,EAAE,MAAM,8BAA8B,CAAC;AAEpF,UAAU,WAAW;IACnB,WAAW,EAAE,MAAM,CAAC;IACpB,eAAe,EAAE,MAAM,CAAC;IACxB,eAAe,EAAE,MAAM,CAAC;IACxB,YAAY,EAAE,MAAM,CAAC;IACrB,gBAAgB,EAAE,MAAM,CAAC;IACzB,gBAAgB,EAAE,OAAO,CAAC;IAC1B,gBAAgB,EAAE,MAAM,CAAC;CAC1B;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,WAAW,GAAG;IAAE,IAAI,EAAE,SAAS,CAAC;IAAC,OAAO,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,CA2ChG;AAED,yEAAyE;AACzE,YAAY,EAAE,WAAW,EAAE,CAAC;AAE5B,oDAAoD;AACpD,wBAAgB,mBAAmB,IAAI,OAAO,CAAC,oBAAoB,CAAC,CAOnE"}
+{"version":3,"file":"risk-score.d.ts","sourceRoot":"","sources":["../../src/engine/risk-score.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,8BAA8B,CAAC;AAE9D,UAAU,WAAW;IACnB,WAAW,EAAE,MAAM,CAAC;IACpB,eAAe,EAAE,MAAM,CAAC;IACxB,eAAe,EAAE,MAAM,CAAC;IACxB,YAAY,EAAE,MAAM,CAAC;IACrB,gBAAgB,EAAE,MAAM,CAAC;IACzB,gBAAgB,EAAE,OAAO,CAAC;IAC1B,gBAAgB,EAAE,MAAM,CAAC;CAC1B;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,WAAW,GAAG;IAAE,IAAI,EAAE,SAAS,CAAC;IAAC,OAAO,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,CA2ChG;AAED,yEAAyE;AACzE,YAAY,EAAE,WAAW,EAAE,CAAC"}

package/dist/engine/risk-score.js

@@ -55,12 +55,3 @@ export function classifyRisk(input) {
     const risk = score >= 8 ? 'critical' : score >= 5 ? 'high' : score >= 2 ? 'medium' : 'low';
     return { risk, reasons };
 }
-/** Defensive constructor used by analyzer tests. */
-export function emptyImpactAnalysis() {
-    return {
-        risk: 'low',
-        riskReasons: [],
-        truncations: {},
-        diagnostics: [],
-    };
-}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shrkcrft/impact-engine",
-  "version": "0.1.0-alpha.22",
+  "version": "0.1.0-alpha.24",
   "description": "SharkCraft impact engine: graph-backed change analysis. Combines code graph + rule-graph + symbol-reference edges into a v3 impact payload (affected files, symbols, rules, templates, tests, risk).",
   "license": "MIT",
   "author": "SharkCraft contributors",
@@ -44,9 +44,10 @@
     "typecheck": "tsc --noEmit -p tsconfig.json"
   },
   "dependencies": {
-    "@shrkcrft/core": "^0.1.0-alpha.22",
-    "@shrkcrft/graph": "^0.1.0-alpha.22",
-    "@shrkcrft/rule-graph": "^0.1.0-alpha.22"
+    "@shrkcrft/core": "^0.1.0-alpha.24",
+    "@shrkcrft/graph": "^0.1.0-alpha.24",
+    "@shrkcrft/rule-graph": "^0.1.0-alpha.24",
+    "@shrkcrft/shared": "^0.1.0-alpha.24"
   },
   "publishConfig": {
     "access": "public"