@shortlink-org/portolan 0.2.4 → 0.3.0

package/README.md

@@ -137,6 +137,29 @@ Each plugin describes its own options; `npm run schema` asks all of them and
 composes `schema/portolan.schema.json`, which editors complete against and `gen`
 checks before running anything.
 
+Non-fatal extractor diagnostics remain attached to their pipeline step. The
+Settings page groups repetitions by plugin, stable rule and severity, and shows
+the recommended next action. A reviewed limitation can be hidden from the
+active view without discarding it:
+
+```json
+{
+  "warningPolicies": [
+    {
+      "when": "plugin == 'openapi' && rule == 'openapi.missing-operation-id' && project == 'aviacore'",
+      "action": "suppress",
+      "reason": "The partner-owned contract cannot be changed in this repository."
+    }
+  ]
+}
+```
+
+The rule id is shown beside the warning. CEL expressions can read `plugin`,
+`rule`, `severity`, `project`, `phase`, `ref`, `message`, and the integer
+`count` for that rule in the step. Expressions are type-checked when the
+manifest is read, must return `bool`, and run during generation. A suppression
+requires a reason and remains available through the `suppressed` filter.
+
 ## Use it in your project
 
 Run the setup once from the root of a repository:

package/catalog/enum_test.go

@@ -0,0 +1,46 @@
+package catalog
+
+import (
+	"encoding/json"
+	"testing"
+)
+
+// An enum round-trips whole: the aggregate's list, the values with their
+// docs, the deprecation marks - and the proto side's numbers. The fixture is
+// literal rather than read from a catalog so that the test says exactly what
+// the mirror is expected to keep.
+func TestEnumRoundTrip(t *testing.T) {
+	raw := `{"id":"a","slug":"a","name":"A","readme":"","root":"A","entities":[],"valueObjects":[],"operations":[],"events":[],
+		"enums":[{"id":"shop.oms.order.status","slug":"status","name":"Status","doc":"Where an order is.","deprecated":true,
+		"values":[{"name":"placed","doc":"just in"},{"name":"legacy","doc":"","deprecated":true}]}]}`
+
+	var agg Aggregate
+	if err := json.Unmarshal([]byte(raw), &agg); err != nil {
+		t.Fatal(err)
+	}
+	if len(agg.Enums) != 1 || agg.Enums[0].ID != "shop.oms.order.status" || !agg.Enums[0].Deprecated {
+		t.Fatalf("enum not read: %+v", agg.Enums)
+	}
+	if got := agg.Enums[0].Values; len(got) != 2 || got[0].Name != "placed" || !got[1].Deprecated {
+		t.Fatalf("values not read: %+v", got)
+	}
+
+	out, err := json.Marshal(agg)
+	if err != nil {
+		t.Fatal(err)
+	}
+	var before, after any
+	_ = json.Unmarshal([]byte(raw), &before)
+	_ = json.Unmarshal(out, &after)
+	if diffs := compare("aggregate", normalize(before), normalize(after)); len(diffs) != 0 {
+		t.Fatalf("round trip lost something: %v", diffs)
+	}
+
+	var svc RpcService
+	if err := json.Unmarshal([]byte(`{"id":"shop.v1.OrderService","methods":[],"source":"","enums":[{"name":"Status","values":[{"name":"STATUS_UNSPECIFIED","number":0},{"name":"PLACED","number":1,"doc":"in"}]}]}`), &svc); err != nil {
+		t.Fatal(err)
+	}
+	if len(svc.Enums) != 1 || svc.Enums[0].Values[1].Number != 1 || svc.Enums[0].Values[0].Number != 0 {
+		t.Fatalf("proto enum not read: %+v", svc.Enums)
+	}
+}

package/catalog/evidence_test.go

@@ -0,0 +1,35 @@
+package catalog
+
+import (
+	"encoding/json"
+	"reflect"
+	"testing"
+)
+
+func TestRelationEvidenceSurvivesEverySupportedCarrier(t *testing.T) {
+	evidence := []RelationEvidence{{Kind: "binding", Rule: "provider-signature", Source: "di.go:14", Symbol: "Provide", Candidates: []string{"one", "two"}}}
+	before := struct {
+		Step     Step
+		Call     RpcCall
+		Table    Table
+		Persists Persists
+	}{
+		Step: Step{Evidence: evidence}, Call: RpcCall{Evidence: evidence},
+		Table: Table{Evidence: evidence}, Persists: Persists{Evidence: evidence},
+	}
+	raw, err := json.Marshal(before)
+	if err != nil {
+		t.Fatal(err)
+	}
+	after := before
+	after.Step.Evidence = nil
+	after.Call.Evidence = nil
+	after.Table.Evidence = nil
+	after.Persists.Evidence = nil
+	if err := json.Unmarshal(raw, &after); err != nil {
+		t.Fatal(err)
+	}
+	if !reflect.DeepEqual(before, after) {
+		t.Fatalf("evidence changed: %s", raw)
+	}
+}