@shortlink-org/portolan 0.2.2 → 0.2.4

package/src/catalog.test.ts

@@ -105,7 +105,7 @@ describe("validateCatalog", () => {
     if (!step) throw new Error("fixture has no steps");
     step.ref = "shop.oms.order.NoSuchEvent";
     expect(() => validateCatalog(bad)).toThrowError(
-      /resolves to neither an Event nor an RpcCall/,
+      /resolves to neither an Event, an RpcCall nor a method/,
     );
     step.status = "unresolved";
     expect(() => validateCatalog(bad)).not.toThrow();
@@ -895,6 +895,22 @@ describe("validateCatalog: interfaces and modules", () => {
     expect(() => validateCatalog(bad)).toThrow(/not in this catalog/);
   });
 
+  it("rejects a vendored interface naming a module nobody declared", () => {
+    const bad = clone();
+    const service = bad.contexts[0]?.services[0];
+    if (!service) throw new Error("nothing to break");
+    service.copies = [
+      {
+        id: "pricing.v1.Pricing",
+        methods: [{ name: "GetQuote" }],
+        source: "internal/pricing.proto",
+        module: "buf.build/acme/nowhere",
+      },
+    ];
+
+    expect(() => validateCatalog(bad)).toThrow(/not in this catalog/);
+  });
+
   it("rejects a module owned by something that is not a service", () => {
     const bad = withModule(clone());
     const module = bad.modules?.[0];
@@ -1061,7 +1077,10 @@ describe("validateCatalog: channels", () => {
   }
 
   it("accepts a service that declares what it says on the bus", () => {
-    expect(() => validateCatalog(speaking())).not.toThrow();
+    const good = speaking();
+    good.contexts[0]!.services[0]!.channels![0]!.messages[0]!.encoding = "msgpack";
+    good.contexts[0]!.services[0]!.channels![0]!.messages[0]!.contentType = "application/msgpack";
+    expect(() => validateCatalog(good)).not.toThrow();
   });
 
   // A service with no document is the normal case, and it is not a service
@@ -1114,6 +1133,14 @@ describe("validateCatalog: channels", () => {
 
     expect(() => validateCatalog(bad)).toThrow(/neither send nor receive/);
   });
+
+  it("rejects an explicitly empty message encoding", () => {
+    const bad = speaking();
+    const message = bad.contexts[0]!.services[0]!.channels![0]!.messages[0]!;
+    message.encoding = "";
+
+    expect(() => validateCatalog(bad)).toThrow(/empty encoding/);
+  });
 });
 
 // A system outside the estate with a contract sits at the root beside the