@shopware-ag/acceptance-test-suite 2.3.9 → 2.3.11

package/README.md

@@ -15,6 +15,7 @@ This test suite is an extension to [Playwright](https://playwright.dev/) to easi
 * [Actor Pattern](#actor-pattern)
 * [Data Fixtures](#data-fixtures)
 * [Code Contribution](#code-contribution)
+* [Best practices](#best-practices)
 
 ## Installation
 Start by creating your own [Playwright](https://playwright.dev/docs/intro) project.
@@ -374,4 +375,32 @@ If you create your own data fixtures make sure to import and merge them in your
 ## Code Contribution
 You can contribute to this project via its [official repository](https://github.com/shopware/acceptance-test-suite/) on GitHub.  
 
-This project uses [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/). Please make sure to form your commits accordingly to the spec.
+This project uses [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/). Please make sure to form your commits accordingly to the spec.
+
+## Best practices
+
+A good first read about this is the official [playwright best practices page](https://playwright.dev/docs/best-practices). It describes the most important practices which should also be followed when writing acceptance tests for Shopware.
+
+The most important part is [test isolation](https://playwright.dev/docs/best-practices#make-tests-as-isolated-as-possible) which helps to prevent flaky behavior and enables the test to be run in parallel and on systems with an unknown state.
+
+
+### Dos
+
+- use fixtures or the [`TestDataService`](./src/services/TestDataService.ts)
+- create all the data that is required for your test case. That includes sales channels, customers and users (the page fixtures handle most of the common use cases)
+- if you need specific settings for your test, set it explicitly for the user/customer/sales channel
+- directly jump to detail pages with the id of the entities you've created
+    - if that's no possible, use the search with a unique name to filter lists to just that single entity
+
+### Don'ts
+
+- do not expect lists/tables to only contain one item, leverage unique ids/names to open or find your entity instead
+- same with helper functions, do not except to only get item back from the API. Always a unique criteria to the API call
+- avoid unused fixtures: if you request a fixture but don't use any data from the fixture, the test or fixture should be refactored
+- do not depend on implicit configuration and existing data. Examples:
+    - rules
+    - flows
+    - categories
+- do not expect the shop to have the defaults en_GB and EUR
+- do not change global settings (sales channel is ok, because it's created by us)
+  - basically everything in Settings that is not specific to a sales channel (tax, search, etc.)

package/dist/index.d.mts

@@ -460,7 +460,7 @@ declare class TestDataService {
     /**
      * Will delete all entities created by the data service via sync API.
      */
-    cleanUp(): Promise<playwright_core.APIResponse>;
+    cleanUp(): Promise<playwright_core.APIResponse | null>;
     /**
      * Convert a JS date object into a date-time compatible string.
      *

package/dist/index.d.ts

@@ -460,7 +460,7 @@ declare class TestDataService {
     /**
      * Will delete all entities created by the data service via sync API.
      */
-    cleanUp(): Promise<playwright_core.APIResponse>;
+    cleanUp(): Promise<playwright_core.APIResponse | null>;
     /**
      * Convert a JS date object into a date-time compatible string.
      *

package/dist/index.mjs

@@ -689,20 +689,19 @@ const test$9 = test$d.extend({
                 }
                 `.trim()
     });
+    await expect(page.url()).toContain("login");
     await page.getByLabel(/Username|Email address/).fill(adminUser.username);
     await page.getByLabel("Password").fill(adminUser.password);
-    const configResponsePromise = page.waitForResponse("**/_info/config");
-    await page.getByRole("button", { name: "Log in" }).click();
-    const config = await (await configResponsePromise).json();
-    let lastPlugin;
+    const config = await (await AdminApiContext.get("./_info/config")).json();
+    const jsLoadingPromises = [];
     for (const i in config.bundles) {
       if (config.bundles[i]?.js && config.bundles[i]?.js?.length) {
-        lastPlugin = config.bundles[i];
+        const js = config?.bundles[i]?.js ?? [];
+        jsLoadingPromises.push(...js.map((url) => page.waitForResponse(url)));
       }
     }
-    if (lastPlugin) {
-      await Promise.all(lastPlugin.js.map((url) => page.waitForResponse(url)));
-    }
+    await page.getByRole("button", { name: "Log in" }).click();
+    await Promise.all(jsLoadingPromises);
     await use(page);
     await page.close();
     await context.close();
@@ -1401,7 +1400,7 @@ class TestDataService {
    */
   async cleanUp() {
     if (!this.shouldCleanUp) {
-      return Promise.reject();
+      return null;
     }
     const priorityDeleteOperations = {};
     const deleteOperations = {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shopware-ag/acceptance-test-suite",
-  "version": "2.3.9",
+  "version": "2.3.11",
   "description": "Shopware Acceptance Test Suite",
   "author": "shopware AG",
   "license": "MIT",