@shopify/shop-minis-react 0.9.0 → 0.10.0

package/eslint/rules/validate-manifest.cjs

@@ -122,10 +122,6 @@ module.exports = {
     messages: {
       missingScope:
         '{{source}} requires scope "{{scope}}" in src/manifest.json. Add "{{scope}}" to the "scopes" array.',
-      missingScopeProductCard:
-        'Component "ProductCard" requires scope "{{scope}}" in src/manifest.json. Add "{{scope}}" to the "scopes" array or set favoriteButtonDisabled to true on all ProductCard instances.',
-      missingScopeProductLink:
-        'Component "ProductLink" requires scope "{{scope}}" in src/manifest.json. Add "{{scope}}" to the "scopes" array or set hideFavoriteAction to true (or provide a customAction) on all ProductLink instances.',
       missingPermission:
         '{{reason}} requires permission "{{permission}}" in src/manifest.json. Add "{{permission}}" to the "permissions" array.',
       missingTrustedDomain:
@@ -149,9 +145,6 @@ module.exports = {
     const requiredPermissions = new Set()
     const requiredDomains = new Set()
     const fixedIssues = new Set()
-    // Track how components are actually used (e.g., with specific props)
-    const componentUsagePatterns = new Map()
-
     // Check module-level cache first to avoid repeated file I/O
     if (manifestPathCache && fs.existsSync(manifestPathCache)) {
       // Check if manifest.json has been modified (for IDE integration)
@@ -465,78 +458,6 @@ module.exports = {
         }
       },
 
-      // Track ProductCard and ProductLink usage with disabled favorite functionality
-      JSXElement(node) {
-        const elementName = node.openingElement.name.name
-
-        // Handle ProductCard with favoriteButtonDisabled prop
-        if (elementName === 'ProductCard') {
-          // Check if favoriteButtonDisabled prop is present and true
-          const favoriteDisabledProp = node.openingElement.attributes.find(
-            attr =>
-              attr.type === 'JSXAttribute' &&
-              attr.name?.name === 'favoriteButtonDisabled'
-          )
-
-          const isDisabled =
-            favoriteDisabledProp &&
-            // Shorthand syntax: <ProductCard favoriteButtonDisabled />
-            (favoriteDisabledProp.value === null ||
-              // Explicit true: <ProductCard favoriteButtonDisabled={true} />
-              (favoriteDisabledProp.value?.type === 'JSXExpressionContainer' &&
-                favoriteDisabledProp.value?.expression?.type === 'Literal' &&
-                favoriteDisabledProp.value?.expression?.value === true))
-
-          // Track usage pattern
-          const componentPath = 'commerce/product-card'
-          if (!componentUsagePatterns.has(componentPath)) {
-            componentUsagePatterns.set(componentPath, {
-              allDisabled: true,
-              hasUsage: true,
-            })
-          }
-          const pattern = componentUsagePatterns.get(componentPath)
-          pattern.allDisabled = pattern.allDisabled && isDisabled
-        }
-
-        // Handle ProductLink with hideFavoriteAction or customAction props
-        if (elementName === 'ProductLink') {
-          // Check if hideFavoriteAction prop is present and true
-          const hideFavoriteProp = node.openingElement.attributes.find(
-            attr =>
-              attr.type === 'JSXAttribute' &&
-              attr.name?.name === 'hideFavoriteAction'
-          )
-
-          // Check if customAction prop is present (replaces favorite action)
-          const customActionProp = node.openingElement.attributes.find(
-            attr =>
-              attr.type === 'JSXAttribute' && attr.name?.name === 'customAction'
-          )
-
-          const isFavoriteDisabled =
-            // hideFavoriteAction={true} or shorthand
-            (hideFavoriteProp &&
-              (hideFavoriteProp.value === null || // shorthand
-                (hideFavoriteProp.value?.type === 'JSXExpressionContainer' &&
-                  hideFavoriteProp.value?.expression?.type === 'Literal' &&
-                  hideFavoriteProp.value?.expression?.value === true))) ||
-            // customAction is provided (any truthy value replaces favorites)
-            customActionProp !== undefined
-
-          // Track usage pattern
-          const componentPath = 'commerce/product-link'
-          if (!componentUsagePatterns.has(componentPath)) {
-            componentUsagePatterns.set(componentPath, {
-              allDisabled: true,
-              hasUsage: true,
-            })
-          }
-          const pattern = componentUsagePatterns.get(componentPath)
-          pattern.allDisabled = pattern.allDisabled && isFavoriteDisabled
-        }
-      },
-
       // Check JSX attributes for external URLs
       JSXAttribute(node) {
         if (!node.value || node.value.type !== 'Literal') {
@@ -669,18 +590,6 @@ module.exports = {
         // Check scopes for components
         usedComponents.forEach(
           ({path: componentPath, name: componentName, node}) => {
-            // Special handling for components with conditional favorite functionality
-            if (
-              componentPath === 'commerce/product-card' ||
-              componentPath === 'commerce/product-link'
-            ) {
-              const usagePattern = componentUsagePatterns.get(componentPath)
-              // Skip scope requirement if all usages have favorites disabled
-              if (usagePattern?.hasUsage && usagePattern?.allDisabled) {
-                return // No scope required when favorite functionality is disabled
-              }
-            }
-
             const componentData = componentScopesMap[componentPath]
             if (
               !componentData ||
@@ -789,13 +698,7 @@ module.exports = {
               const sourceName = issue.hookName || issue.componentName
               const sourceType = issue.hookName ? 'Hook' : 'Component'
 
-              // Use custom message for ProductCard and ProductLink
-              let messageId = 'missingScope'
-              if (issue.componentName === 'ProductCard') {
-                messageId = 'missingScopeProductCard'
-              } else if (issue.componentName === 'ProductLink') {
-                messageId = 'missingScopeProductLink'
-              }
+              const messageId = 'missingScope'
 
               context.report({
                 loc: {line: 1, column: 0},

package/generated-hook-maps/component-scopes-map.json

@@ -1,18 +1 @@
-{
-  "commerce/product-card": {
-    "scopes": [
-      "product_list:write"
-    ],
-    "hooks": [
-      "useSavedProductsActions"
-    ]
-  },
-  "commerce/product-link": {
-    "scopes": [
-      "product_list:write"
-    ],
-    "hooks": [
-      "useSavedProductsActions"
-    ]
-  }
-}
+{}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@shopify/shop-minis-react",
   "license": "SEE LICENSE IN LICENSE.txt",
-  "version": "0.9.0",
+  "version": "0.10.0",
   "sideEffects": false,
   "type": "module",
   "engines": {