@shopify/shop-minis-react 0.4.5 → 0.4.6

package/eslint/rules/validate-manifest.cjs

@@ -221,32 +221,84 @@ module.exports = {
       },
 
       // Detect browser API usage for permissions
-      MemberExpression(node) {
-        const sourceCode = context.getSourceCode()
-        const code = sourceCode.getText(node)
+      MemberExpression() {
+        // This visitor is kept for potential future permission detection
+        // getUserMedia detection has been moved to CallExpression for better constraint analysis
+      },
 
-        // Check for camera/microphone API
+      // Detect network requests and event listeners
+      CallExpression(node) {
+        // Check for getUserMedia calls
         if (
-          code.includes('navigator.mediaDevices.getUserMedia') ||
-          code.includes('navigator.getUserMedia')
+          node.callee.type === 'MemberExpression' &&
+          node.callee.property.name === 'getUserMedia'
         ) {
-          // Need to check the constraints to determine if it's camera or microphone
-          // For now, we'll flag both as potentially needed
-          requiredPermissions.add({
-            permission: 'CAMERA',
-            reason: 'getUserMedia API usage',
-            node,
-          })
-          requiredPermissions.add({
-            permission: 'MICROPHONE',
-            reason: 'getUserMedia API usage',
-            node,
-          })
+          // Validate it's actually navigator.getUserMedia or navigator.mediaDevices.getUserMedia
+          const sourceCode = context.getSourceCode()
+          const calleeText = sourceCode.getText(node.callee)
+
+          if (
+            calleeText.includes('navigator.mediaDevices.getUserMedia') ||
+            calleeText.includes('navigator.getUserMedia')
+          ) {
+            // Get the constraints argument (first argument)
+            const constraints = node.arguments[0]
+
+            let needsCamera = true
+            let needsMicrophone = true
+
+            if (constraints && constraints.type === 'ObjectExpression') {
+              // Check if video is explicitly set to false
+              const videoProp = constraints.properties.find(
+                prop =>
+                  prop.type === 'Property' &&
+                  prop.key &&
+                  (prop.key.name === 'video' ||
+                    (prop.key.type === 'Literal' && prop.key.value === 'video'))
+              )
+              if (
+                videoProp &&
+                videoProp.value.type === 'Literal' &&
+                videoProp.value.value === false
+              ) {
+                needsCamera = false
+              }
+
+              // Check if audio is explicitly set to false
+              const audioProp = constraints.properties.find(
+                prop =>
+                  prop.type === 'Property' &&
+                  prop.key &&
+                  (prop.key.name === 'audio' ||
+                    (prop.key.type === 'Literal' && prop.key.value === 'audio'))
+              )
+              if (
+                audioProp &&
+                audioProp.value.type === 'Literal' &&
+                audioProp.value.value === false
+              ) {
+                needsMicrophone = false
+              }
+            }
+
+            if (needsCamera) {
+              requiredPermissions.add({
+                permission: 'CAMERA',
+                reason: 'getUserMedia API usage with video',
+                node,
+              })
+            }
+
+            if (needsMicrophone) {
+              requiredPermissions.add({
+                permission: 'MICROPHONE',
+                reason: 'getUserMedia API usage with audio',
+                node,
+              })
+            }
+          }
         }
-      },
 
-      // Detect network requests and event listeners
-      CallExpression(node) {
         if (!node.arguments[0]) {
           return
         }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@shopify/shop-minis-react",
   "license": "SEE LICENSE IN LICENSE.txt",
-  "version": "0.4.5",
+  "version": "0.4.6",
   "sideEffects": false,
   "type": "module",
   "engines": {