@shopify/react-native-skia 2.4.18 → 2.4.20

package/cpp/api/JsiSkImage.h

@@ -289,24 +289,33 @@ public:
                                               std::move(image)) {
     // Get the dispatcher for the current thread
     _dispatcher = Dispatcher::getDispatcher();
-    // Process any pending operations
+    // Process any pending operations (e.g. deletions of previous resources)
     _dispatcher->processQueue();
   }
 
+public:
   ~JsiSkImage() override {
-    // Queue deletion on the creation thread if needed
-    auto image = getObject();
-    if (image && _dispatcher) {
-      _dispatcher->run([image]() {
-        // Image will be deleted when this lambda is destroyed
-      });
+    if (!isDisposed()) {
+      // This JSI Object is being deleted from a GC, which might happen
+      // on a separate Thread. GPU resources (like SkImage) must be deleted
+      // on the same Thread they were created on, so in this case we schedule
+      // deletion to run on the Thread this Object was created on.
+      auto image = getObjectUnchecked();
+      if (image && _dispatcher) {
+        _dispatcher->run([image]() {
+          // Image will be deleted when this lambda is destroyed, on the
+          // original Thread.
+        });
+      }
+      releaseResources();
     }
-    // Clear the object to prevent base class destructor from deleting it
-    setObject(nullptr);
   }
 
   size_t getMemoryPressure() const override {
-    auto image = getObject();
+    if (isDisposed()) {
+      return 0;
+    }
+    auto image = getObjectUnchecked();
     if (image) {
       if (image->isTextureBacked()) {
         return image->textureSize();

package/cpp/api/JsiSkPicture.h

@@ -34,16 +34,22 @@ public:
     _dispatcher->processQueue();
   }
 
+public:
   ~JsiSkPicture() override {
-    // Queue deletion on the creation thread if needed
-    auto picture = getObject();
-    if (picture && _dispatcher) {
-      _dispatcher->run([picture]() {
-        // Picture will be deleted when this lambda is destroyed
-      });
+    if (!isDisposed()) {
+      // This JSI Object is being deleted from a GC, which might happen
+      // on a separate Thread. GPU resources (like SkPicture) must be deleted
+      // on the same Thread they were created on, so in this case we schedule
+      // deletion to run on the Thread this Object was created on.
+      auto picture = getObjectUnchecked();
+      if (picture && _dispatcher) {
+        _dispatcher->run([picture]() {
+          // Picture will be deleted when this lambda is destroyed, on the
+          // original Thread.
+        });
+      }
+      releaseResources();
     }
-    // Clear the object to prevent base class destructor from deleting it
-    setObject(nullptr);
   }
 
   JSI_HOST_FUNCTION(makeShader) {
@@ -91,7 +97,10 @@ public:
                        JSI_EXPORT_FUNC(JsiSkPicture, dispose))
 
   size_t getMemoryPressure() const override {
-    auto picture = getObject();
+    if (isDisposed()) {
+      return 0;
+    }
+    auto picture = getObjectUnchecked();
     if (!picture) {
       return 0;
     }

package/cpp/api/JsiSkSurface.h

@@ -45,16 +45,22 @@ public:
     _dispatcher->processQueue();
   }
 
+public:
   ~JsiSkSurface() override {
-    // Queue deletion on the creation thread if needed
-    auto surface = getObject();
-    if (surface && _dispatcher) {
-      _dispatcher->run([surface]() {
-        // Surface will be deleted when this lambda is destroyed
-      });
+    if (!isDisposed()) {
+      // This JSI Object is being deleted from a GC, which might happen
+      // on a separate Thread. GPU resources (like SkSurface) must be deleted
+      // on the same Thread they were created on, so in this case we schedule
+      // deletion to run on the Thread this Object was created on.
+      auto surface = getObjectUnchecked();
+      if (surface && _dispatcher) {
+        _dispatcher->run([surface]() {
+          // Surface will be deleted when this lambda is destroyed, on the
+          // original Thread.
+        });
+      }
+      releaseResources();
     }
-    // Clear the object to prevent base class destructor from deleting it
-    setObject(nullptr);
   }
 
   EXPORT_JSI_API_TYPENAME(JsiSkSurface, Surface)
@@ -117,7 +123,10 @@ public:
   }
 
   size_t getMemoryPressure() const override {
-    auto surface = getObject();
+    if (isDisposed()) {
+      return 0;
+    }
+    auto surface = getObjectUnchecked();
     if (!surface) {
       return 0;
     }

package/cpp/api/JsiVideo.h

@@ -49,6 +49,10 @@ public:
 
   JSI_HOST_FUNCTION(framerate) { return getObject()->framerate(); }
 
+  JSI_HOST_FUNCTION(currentTime) { return getObject()->currentTime(); }
+
+  JSI_HOST_FUNCTION(isPlaying) { return getObject()->isPlaying(); }
+
   JSI_HOST_FUNCTION(seek) {
     double timestamp = arguments[0].asNumber();
     getObject()->seek(timestamp);
@@ -86,12 +90,21 @@ public:
     return jsi::Value::undefined();
   }
 
+  JSI_HOST_FUNCTION(setLooping) {
+    auto looping = arguments[0].asBool();
+    getObject()->setLooping(looping);
+    return jsi::Value::undefined();
+  }
+
   JSI_EXPORT_FUNCTIONS(
       JSI_EXPORT_FUNC(JsiVideo, nextImage), JSI_EXPORT_FUNC(JsiVideo, duration),
-      JSI_EXPORT_FUNC(JsiVideo, framerate), JSI_EXPORT_FUNC(JsiVideo, seek),
+      JSI_EXPORT_FUNC(JsiVideo, framerate),
+      JSI_EXPORT_FUNC(JsiVideo, currentTime),
+      JSI_EXPORT_FUNC(JsiVideo, isPlaying), JSI_EXPORT_FUNC(JsiVideo, seek),
       JSI_EXPORT_FUNC(JsiVideo, rotation), JSI_EXPORT_FUNC(JsiVideo, size),
       JSI_EXPORT_FUNC(JsiVideo, play), JSI_EXPORT_FUNC(JsiVideo, pause),
-      JSI_EXPORT_FUNC(JsiVideo, setVolume), JSI_EXPORT_FUNC(JsiVideo, dispose))
+      JSI_EXPORT_FUNC(JsiVideo, setVolume),
+      JSI_EXPORT_FUNC(JsiVideo, setLooping), JSI_EXPORT_FUNC(JsiVideo, dispose))
 
   JsiVideo(std::shared_ptr<RNSkPlatformContext> context,
            std::shared_ptr<RNSkVideo> video)

package/cpp/api/recorder/Convertor.h

@@ -667,7 +667,8 @@ SkPath1DPathEffect::Style getPropertyValue(jsi::Runtime &runtime,
   throw std::runtime_error("Invalid prop value for Path1DEffectStyle received");
 }
 
-// Wrapper type for blend mode to avoid conflict with int template specialization
+// Wrapper type for blend mode to avoid conflict with int template
+// specialization
 struct BlendModeValue {
   int value;
   BlendModeValue(int v = 0) : value(v) {}
@@ -745,7 +746,8 @@ BlendModeValue getPropertyValue(jsi::Runtime &runtime, const jsi::Value &val) {
   throw std::runtime_error("Invalid prop value for BlendMode received");
 }
 
-// Keep SkBlendMode specialization for other usages (Shaders, ImageFilters, ColorFilters, Drawings)
+// Keep SkBlendMode specialization for other usages (Shaders, ImageFilters,
+// ColorFilters, Drawings)
 template <>
 SkBlendMode getPropertyValue(jsi::Runtime &runtime, const jsi::Value &val) {
   if (val.isString()) {

package/cpp/jsi2/EnumMapper.h

@@ -6,40 +6,55 @@
 namespace rnwgpu {
 
 namespace EnumMapper {
-  // Add these two methods in namespace "EnumMapper" to allow parsing a custom enum:
-  // 1. `static void convertJSUnionToEnum(const std::string& inUnion, Enum* outEnum)`
-  // 2. `static void convertEnumToJSUnion(Enum inEnum, std::string* outUnion)`
-
-  static std::runtime_error invalidUnion(const std::string& passedUnion) {
-    return std::runtime_error("Cannot convert JS Value to Enum: Invalid Union value passed! (\"" + std::string(passedUnion) + "\")");
-  }
-
-  template <typename T> static std::runtime_error invalidEnum(T passedEnum) {
-    return std::runtime_error("Cannot convert Enum to JS Value: Invalid Enum passed! (Value #" +
-                              std::to_string(static_cast<int>(passedEnum)) + ")");
-  }
-
-  // Trait to check if a convertJSUnionToEnum function for enum type T exists
-  template <typename T, typename = void> struct has_js_union_to_enum : std::false_type {};
-  template <typename T>
-  struct has_js_union_to_enum<T, std::void_t<decltype(convertJSUnionToEnum(std::declval<std::string>(), std::declval<T*>()))>>
-      : std::true_type {};
-
-  // Trait to check if a convertEnumToJSUnion function for enum type T exists
-  template <typename T, typename = void> struct has_enum_to_js_union : std::false_type {};
-  template <typename T>
-  struct has_enum_to_js_union<T, std::void_t<decltype(convertEnumToJSUnion(std::declval<T>(), std::declval<std::string*>()))>>
-      : std::true_type {};
-
-  template <typename TEnum> static void convertJSUnionToEnum(const std::string&, TEnum*) {
-    static_assert(has_js_union_to_enum<TEnum>::value,
-                  "Cannot convert a JS union to this enum type. Did you implement EnumMapper::convertJSUnionToEnum(...)?");
-  }
-
-  template <typename TEnum> static void convertEnumToJSUnion(TEnum, std::string*) {
-    static_assert(has_enum_to_js_union<TEnum>::value,
-                  "Cannot convert this enum type to a JS union. Did you implement EnumMapper::convertEnumToJSUnion(...)?");
-  }
+// Add these two methods in namespace "EnumMapper" to allow parsing a custom
+// enum:
+// 1. `static void convertJSUnionToEnum(const std::string& inUnion, Enum*
+// outEnum)`
+// 2. `static void convertEnumToJSUnion(Enum inEnum, std::string* outUnion)`
+
+static std::runtime_error invalidUnion(const std::string &passedUnion) {
+  return std::runtime_error(
+      "Cannot convert JS Value to Enum: Invalid Union value passed! (\"" +
+      std::string(passedUnion) + "\")");
+}
+
+template <typename T> static std::runtime_error invalidEnum(T passedEnum) {
+  return std::runtime_error(
+      "Cannot convert Enum to JS Value: Invalid Enum passed! (Value #" +
+      std::to_string(static_cast<int>(passedEnum)) + ")");
+}
+
+// Trait to check if a convertJSUnionToEnum function for enum type T exists
+template <typename T, typename = void>
+struct has_js_union_to_enum : std::false_type {};
+template <typename T>
+struct has_js_union_to_enum<
+    T, std::void_t<decltype(convertJSUnionToEnum(std::declval<std::string>(),
+                                                 std::declval<T *>()))>>
+    : std::true_type {};
+
+// Trait to check if a convertEnumToJSUnion function for enum type T exists
+template <typename T, typename = void>
+struct has_enum_to_js_union : std::false_type {};
+template <typename T>
+struct has_enum_to_js_union<
+    T, std::void_t<decltype(convertEnumToJSUnion(
+           std::declval<T>(), std::declval<std::string *>()))>>
+    : std::true_type {};
+
+template <typename TEnum>
+static void convertJSUnionToEnum(const std::string &, TEnum *) {
+  static_assert(has_js_union_to_enum<TEnum>::value,
+                "Cannot convert a JS union to this enum type. Did you "
+                "implement EnumMapper::convertJSUnionToEnum(...)?");
+}
+
+template <typename TEnum>
+static void convertEnumToJSUnion(TEnum, std::string *) {
+  static_assert(has_enum_to_js_union<TEnum>::value,
+                "Cannot convert this enum type to a JS union. Did you "
+                "implement EnumMapper::convertEnumToJSUnion(...)?");
+}
 } // namespace EnumMapper
 
 } // namespace rnwgpu