@shopify/react-native-skia 2.2.5 → 2.2.6

package/android/CMakeLists.txt

@@ -307,7 +307,7 @@ if(${REACT_NATIVE_VERSION} GREATER_EQUAL 80)
     target_compile_reactnative_options(${PACKAGE_NAME} PRIVATE)
 else()
   string(APPEND CMAKE_CXX_FLAGS
-         "  -fexceptions -frtti -std=c++${CMAKE_CXX_STANDARD} -Wall -Werror -Wunused-function -Wunused-private-field -Woverloaded-virtual -Wreorder-ctor -Wdelete-non-abstract-non-virtual-dtor -Wmismatched-tags -Wunused-variable -Wpessimizing-move -Wswitch -Wdeprecated-declarations")
+         "  -fexceptions -frtti -std=c++${CMAKE_CXX_STANDARD} -Wall -Werror -Wunused-function -Wunused-private-field -Woverloaded-virtual -Wreorder-ctor -Wdelete-non-abstract-non-virtual-dtor -Wmismatched-tags -Wunused-variable -Wpessimizing-move -Wswitch -Wdeprecated-declarations -Werror=deprecated-this-capture")
 endif()
 
 # Link

package/android/cpp/jni/JniPlatformContext.cpp

@@ -136,7 +136,7 @@ void JniPlatformContext::performStreamOperation(
   static auto method = javaPart_->getClass()->getMethod<jbyteArray(jstring)>(
       "getJniStreamFromSource");
 
-  auto loader = [=]() -> void {
+  auto loader = [=, this]() -> void {
     jni::ThreadScope ts;
     jstring jstr =
         (*jni::Environment::current()).NewStringUTF(sourceUri.c_str());

package/cpp/api/JsiSkImage.h

@@ -185,6 +185,9 @@ public:
   }
 
   JSI_HOST_FUNCTION(readPixels) {
+#if defined(SK_GRAPHITE)
+    throw std::runtime_error("Not implemented yet");
+#else
     int srcX = 0;
     int srcY = 0;
     if (count > 0 && !arguments[0].isUndefined()) {
@@ -217,16 +220,14 @@ public:
             .asObject(runtime)
             .getArrayBuffer(runtime);
     auto bfrPtr = reinterpret_cast<void *>(buffer.data(runtime));
-#if defined(SK_GRAPHITE)
-    throw std::runtime_error("Not implemented yet");
-#else
+
     auto grContext = getContext()->getDirectContext();
     if (!getObject()->readPixels(grContext, info, bfrPtr, bytesPerRow, srcX,
                                  srcY)) {
       return jsi::Value::null();
     }
-#endif
     return dest;
+#endif
   }
 
   JSI_HOST_FUNCTION(makeNonTextureImage) {

package/cpp/rnskia/RNSkPictureView.h

@@ -57,7 +57,7 @@ public:
 
 private:
   bool performDraw(std::shared_ptr<RNSkCanvasProvider> canvasProvider) {
-    return canvasProvider->renderToCanvas([=](SkCanvas *canvas) {
+    return canvasProvider->renderToCanvas([=, this](SkCanvas *canvas) {
       // Make sure to scale correctly
       auto pd = _platformContext->getPixelDensity();
       canvas->clear(SK_ColorTRANSPARENT);

package/package.json

@@ -8,7 +8,7 @@
     "setup-skia-web": "scripts/setup-canvaskit.js"
   },
   "title": "React Native Skia",
-  "version": "2.2.5",
+  "version": "2.2.6",
   "description": "High-performance React Native Graphics using Skia",
   "main": "lib/module/index.js",
   "react-native": "src/index.ts",