@shopify/react-native-skia 2.2.12 → 2.2.14

package/cpp/api/recorder/Drawings.h

@@ -337,7 +337,6 @@ public:
   }
 };
 
-// Add to Drawings.h after existing command structures
 struct BoxShadowCmdProps {
   float dx = 0;
   float dy = 0;
@@ -386,16 +385,17 @@ public:
     for (size_t i = 0; i < shadowCount; i++) {
       auto shadowObj =
           shadowsArray.getValueAtIndex(runtime, i).asObject(runtime);
-      BoxShadowCmdProps shadow;
-
-      convertProperty(runtime, shadowObj, "dx", shadow.dx, variables);
-      convertProperty(runtime, shadowObj, "dy", shadow.dy, variables);
-      convertProperty(runtime, shadowObj, "spread", shadow.spread, variables);
-      convertProperty(runtime, shadowObj, "blur", shadow.blur, variables);
-      convertProperty(runtime, shadowObj, "color", shadow.color, variables);
-      convertProperty(runtime, shadowObj, "inner", shadow.inner, variables);
-
-      shadows.push_back(shadow);
+      
+      // Create shadow directly in vector to avoid copy
+      shadows.emplace_back();
+      BoxShadowCmdProps &shadow = shadows.back();
+
+       convertProperty(runtime, shadowObj, "dx", shadow.dx, variables);
+       convertProperty(runtime, shadowObj, "dy", shadow.dy, variables);
+       convertProperty(runtime, shadowObj, "spread", shadow.spread, variables);
+       convertProperty(runtime, shadowObj, "blur", shadow.blur, variables);
+       convertProperty(runtime, shadowObj, "color", shadow.color, variables);
+       convertProperty(runtime, shadowObj, "inner", shadow.inner, variables);
     }
   }
 

package/cpp/jsi/JsiHostObject.h

@@ -47,7 +47,7 @@
  * Creates a JSI export function declaration
  */
 #define JSI_EXPORT_FUNC(CLASS, FUNCTION)                                       \
-  {#FUNCTION, (jsi::Value(JsiHostObject::*)(                                   \
+  {#FUNCTION, (jsi::Value (JsiHostObject::*)(                                  \
                   jsi::Runtime & runtime, const jsi::Value &thisValue,         \
                   const jsi::Value *arguments, size_t)) &                      \
                   CLASS::FUNCTION}
@@ -65,7 +65,7 @@
  * Creates a JSI export getter declaration
  */
 #define JSI_EXPORT_PROP_GET(CLASS, FUNCTION)                                   \
-  {#FUNCTION, (jsi::Value(JsiHostObject::*)(jsi::Runtime & runtime)) &         \
+  {#FUNCTION, (jsi::Value (JsiHostObject::*)(jsi::Runtime & runtime)) &        \
                   CLASS::STR_CAT(STR_GET, FUNCTION)}
 
 /**
@@ -83,7 +83,7 @@
  */
 #define JSI_EXPORT_PROP_SET(CLASS, FUNCTION)                                   \
   {#FUNCTION,                                                                  \
-   (void(JsiHostObject::*)(jsi::Runtime & runtime, const jsi::Value &)) &      \
+   (void (JsiHostObject::*)(jsi::Runtime & runtime, const jsi::Value &)) &     \
        CLASS::STR_CAT(STR_SET, FUNCTION)}
 
 /**

package/cpp/rnskia/RNSkJsiViewApi.h

@@ -105,10 +105,15 @@ public:
           if (name == "onSize" && isSharedValue(runtime, arguments[2])) {
             jsi::Object size(runtime);
             auto pd = _platformContext->getPixelDensity();
-            size.setProperty(runtime, "width",
-                             info->view->getScaledWidth() / pd);
-            size.setProperty(runtime, "height",
-                             info->view->getScaledHeight() / pd);
+            auto w = info->view != nullptr
+                         ? std::max(info->view->getScaledWidth(), 0)
+                         : 0;
+            auto h = info->view != nullptr
+                         ? std::max(info->view->getScaledHeight(), 0)
+                         : 0;
+
+            size.setProperty(runtime, "width", w / pd);
+            size.setProperty(runtime, "height", h / pd);
             arguments[2].asObject(runtime).setProperty(runtime, "value", size);
           } else {
             info->props.insert_or_assign(

package/package.json

@@ -8,7 +8,7 @@
     "setup-skia-web": "scripts/setup-canvaskit.js"
   },
   "title": "React Native Skia",
-  "version": "2.2.12",
+  "version": "2.2.14",
   "description": "High-performance React Native Graphics using Skia",
   "main": "lib/module/index.js",
   "react-native": "src/index.ts",