@shopify/react-native-skia 2.12.0-next.1 → 2.13.0

package/LICENSE.md

@@ -1,4 +1,5 @@
-Copyright 2021-present, Shopify Inc.
+Copyright 2026-present, William Candillon
+Copyright 2021-2026, Shopify Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

package/Package.swift

@@ -0,0 +1,117 @@
+// swift-tools-version: 6.0
+//
+// SwiftPM manifest for @shopify/react-native-skia. iOS, Ganesh.
+// Additive: the CocoaPods podspec remains the supported default.
+//
+// React Native 0.87+ references a library that ships its own Package.swift
+// through a symlink at <app>/ios/build/generated/autolinking/libs/<name>, and
+// resolves the relative paths below against that symlink. They are the same
+// for every standard app, because the symlink location is.
+
+import Foundation
+import PackageDescription
+
+// Skia's xcframeworks are ~200MB and are not carried in this package. They come
+// from the react-native-skia-apple-ios npm package, which @shopify/react-native-skia
+// depends on, so a checkout that has installed its dependencies builds offline.
+// Xcode passes the symlink as the package directory, hence resolvingSymlinks.
+let packageRoot = URL(fileURLWithPath: Context.packageDirectory)
+  .resolvingSymlinksInPath().path
+
+let binariesPath = [
+  "../../react-native-skia-apple-ios", // consumer: sibling in node_modules
+  "../../node_modules/react-native-skia-apple-ios", // this monorepo
+]
+.map { "\(packageRoot)/\($0)" }
+.first { FileManager.default.fileExists(atPath: "\($0)/Package.swift") }
+
+guard let binariesPath else {
+  // Reached when the package was skipped at install time (`--omit=optional`,
+  // or a non-Apple `os` filter), which SwiftPM would otherwise report as an
+  // unresolvable dependency path.
+  fatalError(
+    """
+    react-native-skia-apple-ios was not found next to @shopify/react-native-skia. \
+    It ships the prebuilt Skia binaries this package links against. Reinstall \
+    dependencies without --omit=optional, on macOS.
+    """)
+}
+
+let package = Package(
+  name: "ReactNativeSkia",
+  platforms: [.iOS(.v15)],
+  products: [
+    // Autolinking looks this name up verbatim; react-native.config.js pins it.
+    .library(name: "ReactNativeSkia", targets: ["ReactNativeSkia"])
+  ],
+  dependencies: [
+    .package(name: "React-GeneratedCode", path: "../../../ios"),
+    .package(name: "ReactNative", path: "../../../../xcframeworks"),
+    .package(path: binariesPath),
+  ],
+  targets: [
+    .target(
+      name: "ReactNativeSkia",
+      dependencies: [
+        .product(name: "ReactHeaders", package: "ReactNative"),
+        .product(name: "ReactNativeHeaders", package: "ReactNative"),
+        .product(name: "ReactNativeDependenciesHeaders", package: "ReactNative"),
+        .product(name: "ReactAppHeaders", package: "React-GeneratedCode"),
+        .product(name: "react-native-skia-apple-ios", package: "react-native-skia-apple-ios"),
+      ],
+      // apple/ and cpp/ have no common ancestor below the package root, and
+      // .headerSearchPath cannot escape the target path.
+      path: ".",
+      exclude: [
+        "cpp/rnskia/RNDawnWindowContext.cpp", // Graphite only
+        "cpp/rnskia/RNDawnInterop.cpp", // Graphite only
+      ],
+      // Explicit, so SwiftPM never walks node_modules, lib, android, or the
+      // headers-only cpp/skia — which carries x86 AVX skcms sources that
+      // cannot build for arm64.
+      sources: [
+        "apple",
+        "cpp/api",
+        "cpp/jsi",
+        "cpp/rnskia",
+        "cpp/utils",
+        // libskottie.a needs skjson and Apple builds no libskjson archive.
+        // CocoaPods compiles this via its cpp/**/*.cpp glob.
+        "cpp/skia/modules/jsonreader/SkJSONReader.cpp",
+      ],
+      cxxSettings: [
+        // Replaces the podspec's recursive cpp/** glob, which expands to 90.
+        .headerSearchPath("cpp"), // "api/…", "jsi/…", "utils/…"
+        .headerSearchPath("cpp/skia"), // "include/core/…", "modules/…", "src/…"
+        .headerSearchPath("cpp/rnskia"), // apple/ uses bare "RNSkView.h"
+        .headerSearchPath("cpp/utils"), // apple/ uses bare "RNSkLog.h"
+
+        // CocoaPods defines both project-wide for a New Architecture app; the
+        // SwiftPM path defines neither. Skia's own sources no longer gate on
+        // them, but React's headers do (RCT_REMOVE_LEGACY_ARCH hides the
+        // legacy bridge API), so mirror what CocoaPods does.
+        .define("RCT_NEW_ARCH_ENABLED", to: "1"),
+        .define("RCT_REMOVE_LEGACY_ARCH", to: "1"),
+
+        .define("SK_METAL", to: "1"),
+        .define("SK_GANESH", to: "1"),
+        .define("SK_IMAGE_READ_PIXELS_DISABLE_LEGACY_API", to: "1"),
+        .define("SK_DISABLE_LEGACY_SHAPER_FACTORY", to: "1"),
+
+        // React's prebuilt C++ ABI is NDEBUG-gated, and Skia derives
+        // SK_RELEASE from it. Omitting either breaks the Release link.
+        .define("DEBUG", .when(configuration: .debug)),
+        .define("NDEBUG", .when(configuration: .release)),
+      ],
+      linkerSettings: [
+        .linkedFramework("MetalKit"),
+        .linkedFramework("AVFoundation"),
+        .linkedFramework("AVKit"),
+        .linkedFramework("CoreMedia"),
+      ]
+    )
+  ],
+  // React Native's headers need C++20, and so does Skia m152: SkMathPriv.h
+  // calls std::countl_zero, std::countr_zero and std::popcount.
+  cxxLanguageStandard: .cxx20
+)

package/android/CMakeLists.txt

@@ -1,7 +1,6 @@
 project(RNSkia)
 cmake_minimum_required(VERSION 3.4.1)
 
-set (CMAKE_VERBOSE_MAKEFILE ON)
 set (CMAKE_CXX_STANDARD 20)
 
 # SKIA_LIBS_PATH is passed from Gradle (pointing at the prebuilt Skia binaries,
@@ -48,20 +47,7 @@ set (SKIA_SKSG_LIB "sksg")
 set (SKIA_JSONREADER_LIB "jsonreader")
 
 
-# Clear some variables
-unset(LIBRN_DIR CACHE)
-unset(libfbjni_link_DIRS CACHE)
-unset(libfbjni_include_DIRS CACHE)
-
-set(build_DIR ${CMAKE_SOURCE_DIR}/build)
-file(GLOB LIBRN_DIR "${PREBUILT_DIR}/${ANDROID_ABI}")
-file(GLOB libfbjni_link_DIRS "${build_DIR}/fbjni*.aar/jni/${ANDROID_ABI}")
-file(GLOB libfbjni_include_DIRS "${build_DIR}/fbjni-*-headers.jar/")
-
 message("-- ABI     : " ${ANDROID_ABI})
-message("-- PREBUILT: " ${PREBUILT_DIR})
-message("-- BUILD   : " ${build_DIR})
-message("-- LIBRN   : " ${LIBRN_DIR})
 
 link_directories(${SKIA_LIBS_PATH}/)
 
@@ -80,14 +66,6 @@ else()
     )
 endif()
 
-if(${REACT_NATIVE_VERSION} LESS 66)
-        file(
-                TO_CMAKE_PATH
-                "${NODE_MODULES_DIR}/react-native/ReactCommon/jsi/jsi/jsi.cpp"
-                INCLUDE_JSI_CPP
-        )
-endif()
-
 add_library(
         ${PACKAGE_NAME}
         SHARED
@@ -100,8 +78,7 @@ add_library(
         "${PROJECT_SOURCE_DIR}/cpp/rnskia-android/AHardwareBufferUtils.cpp"
         "${PROJECT_SOURCE_DIR}/cpp/rnskia-android/RNSkAndroidVideo.cpp"
 
-        "${PROJECT_SOURCE_DIR}/../cpp/jsi/RuntimeLifecycleMonitor.cpp"
-        "${PROJECT_SOURCE_DIR}/../cpp/jsi/RuntimeAwareCache.cpp"
+        "${PROJECT_SOURCE_DIR}/../cpp/jsi/JSICache.cpp"
         "${PROJECT_SOURCE_DIR}/../cpp/jsi/JsiPromises.cpp"
         "${PROJECT_SOURCE_DIR}/../cpp/jsi/Promise.cpp"
 
@@ -146,8 +123,6 @@ target_include_directories(
 
         # Shared JSI infrastructure (cpp/jsi) via prefix-qualified includes
         ../cpp
-
-        ${libfbjni_include_DIRS}
 )
 
 add_library(svg STATIC IMPORTED)
@@ -190,113 +165,9 @@ find_library(
 )
 message("-- LOG     : " ${LOG_LIB})
 
-if(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)
-    # We need to find packages since from RN 0.71 binaries are prebuilt
-    find_package(fbjni REQUIRED CONFIG)
-    find_package(ReactAndroid REQUIRED CONFIG)
-endif()
-
-unset(JSI_LIB CACHE)
-if(${REACT_NATIVE_VERSION} LESS 66)
-    # JSI lib didn't exist on RN 0.65 and before. Simply omit it.
-    set (JSI_LIB "")
-elseif(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)
-    # RN 0.71 distributes prebuilt binaries.
-    set (JSI_LIB ReactAndroid::jsi)
-else()
-    # RN 0.66 distributes libjsi.so, can be used instead of compiling jsi.cpp manually.
-    find_library(
-        JSI_LIB
-        jsi
-        PATHS ${LIBRN_DIR}
-        NO_CMAKE_FIND_ROOT_PATH
-    )
-endif()
-message("-- JSI     : " ${JSI_LIB})
-
-unset(REACT_LIB CACHE)
-if(${REACT_NATIVE_VERSION} GREATER_EQUAL 76)
-    # RN 0.76 packs react_nativemodule_core into ReactAndroid::reactnative
-    set (REACT_LIB ReactAndroid::reactnative)
-elseif(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)
-    # RN 0.71 distributes prebuilt binaries.
-    set (REACT_LIB ReactAndroid::react_nativemodule_core)
-    else()
-    find_library(
-            REACT_LIB
-            react_nativemodule_core
-            PATHS ${LIBRN_DIR}
-            NO_CMAKE_FIND_ROOT_PATH
-    )
-endif()
-message("-- REACT   : " ${REACT_LIB})
-
-unset(FBJNI_LIBRARY CACHE)
-if(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)
-    # RN 0.71 distributes prebuilt binaries.
-    set (FBJNI_LIBRARY fbjni::fbjni)
-else()
-    find_library(
-            FBJNI_LIBRARY
-            fbjni
-            PATHS ${libfbjni_link_DIRS}
-            NO_CMAKE_FIND_ROOT_PATH
-    )
-endif()
-message("-- FBJNI   : " ${FBJNI_LIBRARY})
-
-unset(REACTNATIVEJNI_LIB CACHE)
-if(${REACT_NATIVE_VERSION} GREATER_EQUAL 76)
-    # RN 0.76 doesn't have reactnativejni
-    # DO NOTHING, we'll not link these libraries
-elseif(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)
-    # RN 0.71 distributes prebuilt binaries.
-    set (REACTNATIVEJNI_LIB "ReactAndroid::reactnativejni")
-else()
-    find_library(
-            REACTNATIVEJNI_LIB
-            reactnativejni
-            PATHS ${LIBRN_DIR}
-            NO_CMAKE_FIND_ROOT_PATH
-    )
-endif()
-message("-- REACTNATIVEJNI   : " ${REACTNATIVEJNI_LIB})
-
-unset(RUNTIMEEXECUTOR_LIB CACHE)
-if(${REACT_NATIVE_VERSION} GREATER_EQUAL 76)
-    # RN 0.76 doesn't have runtimeexecutor
-    # DO NOTHING, we'll not link these libraries
-elseif(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)
-    # RN 0.71 distributes prebuilt binaries.
-    set (RUNTIMEEXECUTOR_LIB "ReactAndroid::runtimeexecutor")
-else()
-    find_library(
-            RUNTIMEEXECUTOR_LIB
-            runtimeexecutor
-            PATHS ${LIBRN_DIR}
-            NO_CMAKE_FIND_ROOT_PATH
-    )
-endif()
-message("-- RUNTIMEEXECUTOR   : " ${RUNTIMEEXECUTOR_LIB})
-
-unset(TURBOMODULES_LIB CACHE)
-if(${REACT_NATIVE_VERSION} GREATER_EQUAL 76)
-    # RN 0.76 doesn't have turbomodulejsijni
-    # DO NOTHING, we'll not link these libraries
-elseif(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)
-    # RN 0.71 distributes prebuilt binaries.
-    set (TURBOMODULES_LIB "ReactAndroid::turbomodulejsijni")
-else()
-    find_library(
-            TURBOMODULES_LIB
-            turbomodulejsijni
-            PATHS ${LIBRN_DIR}
-            NO_CMAKE_FIND_ROOT_PATH
-    )
-endif()
-message("-- TURBO   : " ${TURBOMODULES_LIB})
-
-add_definitions(-DREACT_NATIVE_VERSION=${REACT_NATIVE_VERSION})
+# React Native distributes prebuilt binaries via prefab.
+find_package(fbjni REQUIRED CONFIG)
+find_package(ReactAndroid REQUIRED CONFIG)
 
 # Set RN_SERIALIZABLE_STATE and C++ flags for React Native 0.81+
 if(${REACT_NATIVE_VERSION} GREATER_EQUAL 80)
@@ -308,50 +179,25 @@ else()
 endif()
 
 # Link
-if(${REACT_NATIVE_VERSION} GREATER_EQUAL 76)
-    set(COMMON_LIBS
-        ${LOG_LIB}
-        ${REACT_LIB}
-        ${FBJNI_LIBRARY}
-        ${JSI_LIB}
-        ${SKIA_SVG_LIB}
-        ${SKIA_SKSHAPER_LIB}
-        ${SKIA_SKPARAGRAPH_LIB}
-        ${SKIA_SKUNICODE_CORE_LIB}
-        ${SKIA_SKUNICODE_ICU_LIB}
-        ${SKIA_SKOTTIE_LIB}
-        ${SKIA_SKSG_LIB}
-        ${SKIA_JSONREADER_LIB}
-        ${SKIA_LIB}
-        -ljnigraphics
-        -lGLESv2
-        -lEGL
-        -landroid
-    )
-else()
-    set(COMMON_LIBS
-        ${LOG_LIB}
-        ${FBJNI_LIBRARY}
-        ${REACT_LIB}
-        ${JSI_LIB}
-        ${REACTNATIVEJNI_LIB}
-        ${RUNTIMEEXECUTOR_LIB}
-        ${TURBOMODULES_LIB}
-        ${SKIA_SVG_LIB}
-        ${SKIA_SKSHAPER_LIB}
-        ${SKIA_SKPARAGRAPH_LIB}
-        ${SKIA_SKUNICODE_CORE_LIB}
-        ${SKIA_SKUNICODE_ICU_LIB}
-        ${SKIA_SKOTTIE_LIB}
-        ${SKIA_SKSG_LIB}
-        ${SKIA_JSONREADER_LIB}
-        ${SKIA_LIB}
-        -ljnigraphics
-        -lGLESv2
-        -lEGL
-        -landroid
-    )
-endif()
+set(COMMON_LIBS
+    ${LOG_LIB}
+    ReactAndroid::reactnative
+    fbjni::fbjni
+    ReactAndroid::jsi
+    ${SKIA_SVG_LIB}
+    ${SKIA_SKSHAPER_LIB}
+    ${SKIA_SKPARAGRAPH_LIB}
+    ${SKIA_SKUNICODE_CORE_LIB}
+    ${SKIA_SKUNICODE_ICU_LIB}
+    ${SKIA_SKOTTIE_LIB}
+    ${SKIA_SKSG_LIB}
+    ${SKIA_JSONREADER_LIB}
+    ${SKIA_LIB}
+    -ljnigraphics
+    -lGLESv2
+    -lEGL
+    -landroid
+)
 
 if(SK_GRAPHITE)
     target_link_libraries(${PACKAGE_NAME}
@@ -361,8 +207,6 @@ if(SK_GRAPHITE)
 else()
     target_link_libraries(${PACKAGE_NAME}
         ${COMMON_LIBS}
-        -lGLESv2
-        -lEGL
     )
 endif()