@shopify/react-native-skia 0.1.224 → 0.1.225

package/cpp/api/JsiSkParagraphStyle.h

@@ -24,6 +24,7 @@ namespace RNSkia {
 namespace jsi = facebook::jsi;
 
 namespace para = skia::textlayout;
+
 /**
  Implementation of the ParagraphStyle object in JSI
  */
@@ -60,7 +61,7 @@ public:
 
     if (object.hasProperty(runtime, "disableHinting")) {
       auto propValue = object.getProperty(runtime, "disableHinting");
-      if (propValue.asBool()) {
+      if (asBool(runtime, propValue)) {
         retVal.turnHintingOff();
       }
     }
@@ -83,7 +84,7 @@ public:
     }
     if (object.hasProperty(runtime, "replaceTabCharacters")) {
       auto propValue = object.getProperty(runtime, "replaceTabCharacters");
-      retVal.setReplaceTabCharacters(propValue.asBool());
+      retVal.setReplaceTabCharacters(asBool(runtime, propValue));
     }
     if (object.hasProperty(runtime, "textAlign")) {
       auto propValue = object.getProperty(runtime, "textAlign");

package/cpp/api/JsiSkStrutStyle.h

@@ -20,6 +20,13 @@ namespace jsi = facebook::jsi;
 
 namespace para = skia::textlayout;
 
+bool asBool(jsi::Runtime &runtime, const jsi::Value &value) {
+  if (!value.isBool()) {
+    throw jsi::JSError(runtime, "Expected boolean value");
+  }
+  return value.getBool();
+}
+
 /**
  Implementation of the TextStyle object in JSI for the paragraph builder
  */
@@ -47,7 +54,7 @@ public:
 
     if (object.hasProperty(runtime, "strutEnabled")) {
       auto propValue = object.getProperty(runtime, "strutEnabled");
-      retVal.setStrutEnabled(propValue.asBool());
+      retVal.setStrutEnabled(asBool(runtime, propValue));
     }
     if (object.hasProperty(runtime, "fontFamilies")) {
       auto propValue = object.getProperty(runtime, "fontFamilies")
@@ -78,7 +85,7 @@ public:
     }
     if (object.hasProperty(runtime, "halfLeading")) {
       auto propValue = object.getProperty(runtime, "halfLeading");
-      retVal.setHalfLeading(propValue.asBool());
+      retVal.setHalfLeading(asBool(runtime, propValue));
     }
     if (object.hasProperty(runtime, "leading")) {
       auto propValue = object.getProperty(runtime, "leading");
@@ -86,7 +93,7 @@ public:
     }
     if (object.hasProperty(runtime, "forceStrutHeight")) {
       auto propValue = object.getProperty(runtime, "forceStrutHeight");
-      retVal.setForceStrutHeight(propValue.asBool());
+      retVal.setForceStrutHeight(asBool(runtime, propValue));
     }
 
     return retVal;

package/package.json

@@ -7,7 +7,7 @@
     "setup-skia-web": "./scripts/setup-canvaskit.js"
   },
   "title": "React Native Skia",
-  "version": "0.1.224",
+  "version": "0.1.225",
   "description": "High-performance React Native Graphics using Skia",
   "main": "lib/module/index.js",
   "files": [