npm - @shopify/react-native-skia - Versions diffs - 0.1.191 → 0.1.192 - Mend

@@ -26,6 +26,10 @@ export class JsiSkPaint extends HostObject<Paint, "Paint"> implements SkPaint {
     super(CanvasKit, ref, "Paint");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
   copy() {
     return new JsiSkPaint(this.CanvasKit, this.ref.copy());
   }

@@ -33,6 +33,10 @@ export class JsiSkPath extends HostObject<Path, "Path"> implements SkPath {
     super(CanvasKit, ref, "Path");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
   addPath(src: SkPath, matrix?: SkMatrix, extend = false) {
     const args = [
       JsiSkPath.fromValue(src),

@@ -11,4 +11,8 @@ export class JsiSkPathEffect
   constructor(CanvasKit: CanvasKit, ref: PathEffect) {
     super(CanvasKit, ref, "PathEffect");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
 }

@@ -22,6 +22,10 @@ export class JsiSkPicture
     super(CanvasKit, ref, "Picture");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
   makeShader(
     tmx: TileMode,
     tmy: TileMode,

@@ -16,6 +16,10 @@ export class JsiSkPictureRecorder
     super(CanvasKit, ref, "PictureRecorder");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
   beginRecording(bounds: SkRect) {
     return new JsiSkCanvas(
       this.CanvasKit,

@@ -19,6 +19,10 @@ export class JsiSkPoint
     super(CanvasKit, ref, "Point");
   }
+  dispose = () => {
+    // Float32Array
+  };
   get x() {
     return this.ref[0];
   }

@@ -9,6 +9,10 @@ export class JsiSkRRect
   extends BaseHostObject<RRect, "RRect">
   implements SkRRect
 {
+  dispose = () => {
+    // Float32Array
+  };
   static fromValue(CanvasKit: CanvasKit, rect: SkRRect) {
     if (rect instanceof JsiSkRect) {
       return rect.ref;

@@ -13,4 +13,8 @@ export class JsiSkRSXform
   constructor(CanvasKit: CanvasKit, ref: RSXform) {
     super(CanvasKit, ref, "RSXform");
   }
+  dispose = () => {
+    // Do nothing in the web implementation
+  };
 }

@@ -12,6 +12,10 @@ export class JsiSkRect extends BaseHostObject<Rect, "Rect"> implements SkRect {
     return CanvasKit.XYWHRect(rect.x, rect.y, rect.width, rect.height);
   }
+  dispose = () => {
+    // Float32Array
+  };
   constructor(CanvasKit: CanvasKit, ref: Rect) {
     super(CanvasKit, ref, "Rect");
   }

@@ -15,6 +15,10 @@ export class JsiSkRuntimeEffect
     super(CanvasKit, ref, "RuntimeEffect");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
   source() {
     return this.sksl;
   }

@@ -11,4 +11,8 @@ export class JsiSkShader
   constructor(CanvasKit: CanvasKit, ref: Shader) {
     super(CanvasKit, ref, "Shader");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
 }

@@ -15,6 +15,10 @@ export class JsiSkSurface
     super(CanvasKit, ref, "Surface");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
   flush() {
     this.ref.flush();
   }

@@ -11,4 +11,8 @@ export class JsiSkTextBlob
   constructor(CanvasKit: CanvasKit, ref: TextBlob) {
     super(CanvasKit, ref, "TextBlob");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
 }

@@ -26,7 +26,7 @@ export class JsiSkTypeface
     return false;
   }
-  dispose() {
+  dispose = () => {
     this.ref.delete();
-  }
+  };
 }

@@ -13,6 +13,10 @@ export class JsiSkVertices
     super(CanvasKit, ref, "Vertices");
   }
+  dispose = () => {
+    this.ref.delete();
+  };
   bounds() {
     return new JsiSkRect(this.CanvasKit, this.ref.bounds());
   }

@@ -16,6 +16,6 @@ export const useComputedValue = <R>(cb: () => R, values: unknown[]) => {
     // eslint-disable-next-line react-hooks/exhaustive-deps
     values
   );
-  useEffect(() => () => value.__invalidate(), [value]);
+  useEffect(() => () => value.dispose(), [value]);
   return value;
 };

@@ -11,7 +11,7 @@ export interface SkiaValue<T = number> {
   /**
    * Invalidates the value. Has different meaning depending on the type of the value.
    */
-  __invalidate: () => void;
+  dispose: () => void;
   /**
    * Field to make typechecking easier
    */

@@ -42,7 +42,7 @@ export class RNSkComputedValue<T> extends RNSkReadonlyValue<T> {
     this._unsubscribers = [];
   }
-  public __invalidate(): void {
+  public dispose(): void {
     this._unsubscribers.forEach((unsubscribe) => unsubscribe());
     this._unsubscribers = [];
   }

@@ -1,6 +1,7 @@
 import { Skia } from "../skia";
 import type { SkCanvas } from "../skia/types";
 import { JsiDrawingContext } from "../dom/types/DrawingContext";
+import { isValue } from "../renderer/processors/Animations/Animations";
 import { SkiaBaseWebView } from "./SkiaBaseWebView";
 import type { SkiaDomViewProps, TouchInfo } from "./types";
@@ -16,7 +17,11 @@ export class SkiaDomView extends SkiaBaseWebView<SkiaDomViewProps> {
     }
     if (this.props.onSize) {
       const { width, height } = this.getSize();
-      this.props.onSize.current = { width, height };
+      if (isValue(this.props.onSize)) {
+        this.props.onSize.current = { width, height };
+      } else {
+        this.props.onSize.value = { width, height };
+      }
     }
     if (this.props.root) {
       const ctx = new JsiDrawingContext(Skia, canvas);

@@ -9,6 +9,7 @@ import type {
   SkSize,
 } from "../skia/types";
 import type { SkiaMutableValue, SkiaValue } from "../values";
+import type { SharedValueType } from "../renderer/processors/Animations/Animations";
 export type DrawMode = "continuous" | "default";
@@ -97,7 +98,7 @@ export interface SkiaBaseViewProps extends ViewProps {
    * Pass an animated value to the onSize property to get updates when
    * the Skia view is resized.
    */
-  onSize?: SkiaMutableValue<SkSize>;
+  onSize?: SkiaMutableValue<SkSize> | SharedValueType<SkSize>;
 }
 export interface SkiaDrawViewProps extends SkiaBaseViewProps {

@shopify/react-native-skia 0.1.191 → 0.1.192