@shopify/react-native-skia 0.1.165 → 0.1.167

package/android/src/main/java/com/shopify/reactnative/skia/SkiaBaseView.java

@@ -7,21 +7,27 @@ import android.view.Surface;
 import android.view.TextureView;
 
 import com.facebook.jni.annotations.DoNotStrip;
+import com.facebook.react.uimanager.PointerEvents;
+import com.facebook.react.views.view.ReactViewGroup;
 
-public abstract class SkiaBaseView extends TextureView implements TextureView.SurfaceTextureListener {
+public abstract class SkiaBaseView extends ReactViewGroup implements TextureView.SurfaceTextureListener {
 
     @DoNotStrip
     private Surface mSurface;
+    private TextureView mTexture;
 
     public SkiaBaseView(Context context) {
         super(context);
-        setSurfaceTextureListener(this);
-        setOpaque(false);
+        mTexture = new TextureView(context);
+        mTexture.setSurfaceTextureListener(this);
+        mTexture.setOpaque(false);
+        addView(mTexture);
     }
 
     @Override
-    public void setBackgroundColor(int color) {
-        // Texture view does not support setting the background color.
+    protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
+        super.onLayout(changed, left, top, right, bottom);
+        mTexture.layout(0, 0, this.getMeasuredWidth(), this.getMeasuredHeight());
     }
 
     @Override

package/android/src/main/java/com/shopify/reactnative/skia/SkiaBaseViewManager.java

@@ -0,0 +1,34 @@
+package com.shopify.reactnative.skia;
+
+import com.facebook.react.uimanager.annotations.ReactProp;
+import com.facebook.react.views.view.ReactViewGroup;
+import com.facebook.react.views.view.ReactViewManager;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+
+public abstract class SkiaBaseViewManager extends ReactViewManager {
+
+    @Override
+    public void setNativeId(@NonNull ReactViewGroup view, @Nullable String nativeId) {
+        super.setNativeId(view, nativeId);
+        int nativeIdResolved = Integer.parseInt(nativeId);
+        ((SkiaBaseView)view).registerView(nativeIdResolved);
+    }
+
+    @ReactProp(name = "mode")
+    public void setMode(ReactViewGroup view, String mode) {
+        ((SkiaBaseView)view).setMode(mode);
+    }
+
+    @ReactProp(name = "debug")
+    public void setDebug(ReactViewGroup view, boolean show) {
+        ((SkiaBaseView)view).setDebugMode(show);
+    }
+
+    @Override
+    public void onDropViewInstance(@NonNull ReactViewGroup view) {
+        super.onDropViewInstance(view);
+        ((SkiaBaseView)view).unregisterView();
+    }
+}

package/android/src/main/java/com/shopify/reactnative/skia/SkiaDomViewManager.java

@@ -1,17 +1,9 @@
 package com.shopify.reactnative.skia;
 
-import com.facebook.react.bridge.ReactContext;
-import com.facebook.react.uimanager.BaseViewManager;
-import com.facebook.react.uimanager.LayoutShadowNode;
 import com.facebook.react.uimanager.ThemedReactContext;
-import com.facebook.react.uimanager.annotations.ReactProp;
-
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-
-import java.util.HashMap;
 
-public class SkiaDomViewManager extends BaseViewManager<SkiaDomView, LayoutShadowNode> {
+public class SkiaDomViewManager extends SkiaBaseViewManager {
 
     @NonNull
     @Override
@@ -19,46 +11,9 @@ public class SkiaDomViewManager extends BaseViewManager<SkiaDomView, LayoutShado
         return "SkiaDomView";
     }
 
-    @Override
-    public LayoutShadowNode createShadowNodeInstance() {
-        return new LayoutShadowNode();
-    }
-
-    @Override
-    public Class<? extends LayoutShadowNode> getShadowNodeClass() {
-        return LayoutShadowNode.class;
-    }
-
-    @Override
-    public void updateExtraData(SkiaDomView root, Object extraData) {
-    }
-
-    @Override
-    public void setNativeId(@NonNull SkiaDomView view, @Nullable String nativeId) {
-        super.setNativeId(view, nativeId);
-        int nativeIdResolved = Integer.parseInt(nativeId);
-        view.registerView(nativeIdResolved);
-    }
-
-    @ReactProp(name = "mode")
-    public void setMode(SkiaDomView view, String mode) {
-        view.setMode(mode);
-    }
-
-    @ReactProp(name = "debug")
-    public void setDebug(SkiaDomView view, boolean show) {
-        view.setDebugMode(show);
-    }
-
-    @Override
-    public void onDropViewInstance(@NonNull SkiaDomView view) {
-        super.onDropViewInstance(view);
-        view.unregisterView();
-    }
-
     @NonNull
     @Override
-    protected SkiaDomView createViewInstance(@NonNull ThemedReactContext reactContext) {
+    public SkiaDomView createViewInstance(@NonNull ThemedReactContext reactContext) {
         return new SkiaDomView(reactContext);
     }
 }

package/android/src/main/java/com/shopify/reactnative/skia/SkiaDrawViewManager.java

@@ -1,14 +1,9 @@
 package com.shopify.reactnative.skia;
 
-import com.facebook.react.uimanager.BaseViewManager;
-import com.facebook.react.uimanager.LayoutShadowNode;
 import com.facebook.react.uimanager.ThemedReactContext;
-import com.facebook.react.uimanager.annotations.ReactProp;
-
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
 
-public class SkiaDrawViewManager extends BaseViewManager<SkiaDrawView, LayoutShadowNode> {
+public class SkiaDrawViewManager extends SkiaBaseViewManager {
 
     @NonNull
     @Override
@@ -16,46 +11,9 @@ public class SkiaDrawViewManager extends BaseViewManager<SkiaDrawView, LayoutSha
         return "SkiaDrawView";
     }
 
-    @Override
-    public LayoutShadowNode createShadowNodeInstance() {
-        return new LayoutShadowNode();
-    }
-
-    @Override
-    public Class<? extends LayoutShadowNode> getShadowNodeClass() {
-        return LayoutShadowNode.class;
-    }
-
-    @Override
-    public void updateExtraData(SkiaDrawView root, Object extraData) {
-    }
-
-    @Override
-    public void setNativeId(@NonNull SkiaDrawView view, @Nullable String nativeId) {
-        super.setNativeId(view, nativeId);
-        int nativeIdResolved = Integer.parseInt(nativeId);
-        view.registerView(nativeIdResolved);
-    }
-
-    @ReactProp(name = "mode")
-    public void setMode(SkiaDrawView view, String mode) {
-        view.setMode(mode);
-    }
-
-    @ReactProp(name = "debug")
-    public void setDebug(SkiaDrawView view, boolean show) {
-        view.setDebugMode(show);
-    }
-
-    @Override
-    public void onDropViewInstance(@NonNull SkiaDrawView view) {
-        super.onDropViewInstance(view);
-        view.unregisterView();
-    }
-
     @NonNull
     @Override
-    protected SkiaDrawView createViewInstance(@NonNull ThemedReactContext reactContext) {
+    public SkiaDrawView createViewInstance(@NonNull ThemedReactContext reactContext) {
         return new SkiaDrawView(reactContext);
     }
 }

package/android/src/main/java/com/shopify/reactnative/skia/SkiaPictureViewManager.java

@@ -1,17 +1,9 @@
 package com.shopify.reactnative.skia;
 
-import com.facebook.react.bridge.ReactContext;
-import com.facebook.react.uimanager.BaseViewManager;
-import com.facebook.react.uimanager.LayoutShadowNode;
 import com.facebook.react.uimanager.ThemedReactContext;
-import com.facebook.react.uimanager.annotations.ReactProp;
-
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-
-import java.util.HashMap;
 
-public class SkiaPictureViewManager extends BaseViewManager<SkiaPictureView, LayoutShadowNode> {
+public class SkiaPictureViewManager extends SkiaBaseViewManager {
 
     @NonNull
     @Override
@@ -19,46 +11,9 @@ public class SkiaPictureViewManager extends BaseViewManager<SkiaPictureView, Lay
         return "SkiaPictureView";
     }
 
-    @Override
-    public LayoutShadowNode createShadowNodeInstance() {
-        return new LayoutShadowNode();
-    }
-
-    @Override
-    public Class<? extends LayoutShadowNode> getShadowNodeClass() {
-        return LayoutShadowNode.class;
-    }
-
-    @Override
-    public void updateExtraData(SkiaPictureView root, Object extraData) {
-    }
-
-    @Override
-    public void setNativeId(@NonNull SkiaPictureView view, @Nullable String nativeId) {
-        super.setNativeId(view, nativeId);
-        int nativeIdResolved = Integer.parseInt(nativeId);
-        view.registerView(nativeIdResolved);
-    }
-
-    @ReactProp(name = "mode")
-    public void setMode(SkiaPictureView view, String mode) {
-        view.setMode(mode);
-    }
-
-    @ReactProp(name = "debug")
-    public void setDebug(SkiaPictureView view, boolean show) {
-        view.setDebugMode(show);
-    }
-
-    @Override
-    public void onDropViewInstance(@NonNull SkiaPictureView view) {
-        super.onDropViewInstance(view);
-        view.unregisterView();
-    }
-
     @NonNull
     @Override
-    protected SkiaPictureView createViewInstance(@NonNull ThemedReactContext reactContext) {
+    public SkiaPictureView createViewInstance(@NonNull ThemedReactContext reactContext) {
         return new SkiaPictureView(reactContext);
     }
 }

package/cpp/api/JsiSkPath.h

@@ -41,6 +41,23 @@ public:
     return jsi::String::createFromUtf8(runtime, "Path");
   }
 
+  JSI_HOST_FUNCTION(addPath) {
+    auto src = JsiSkPath::fromValue(runtime, arguments[0]);
+    auto matrix =
+        count > 1 && !arguments[1].isUndefined() && !arguments[1].isNull()
+            ? JsiSkMatrix::fromValue(runtime, arguments[1])
+            : nullptr;
+    auto mode = count > 2 && arguments[2].asBool()
+                    ? SkPath::kExtend_AddPathMode
+                    : SkPath::kAppend_AddPathMode;
+    if (matrix == nullptr) {
+      getObject()->addPath(*src, mode);
+    } else {
+      getObject()->addPath(*src, *matrix, mode);
+    }
+    return thisValue.getObject(runtime);
+  }
+
   JSI_HOST_FUNCTION(addArc) {
     auto rect = JsiSkRect::fromValue(runtime, arguments[0]);
     auto start = arguments[1].asNumber();
@@ -512,9 +529,9 @@ public:
   JSI_EXPORT_PROPERTY_GETTERS(JSI_EXPORT_PROP_GET(JsiSkPath, __typename__))
 
   JSI_EXPORT_FUNCTIONS(
-      JSI_EXPORT_FUNC(JsiSkPath, addArc), JSI_EXPORT_FUNC(JsiSkPath, addOval),
-      JSI_EXPORT_FUNC(JsiSkPath, addPoly), JSI_EXPORT_FUNC(JsiSkPath, addRect),
-      JSI_EXPORT_FUNC(JsiSkPath, addRRect),
+      JSI_EXPORT_FUNC(JsiSkPath, addPath), JSI_EXPORT_FUNC(JsiSkPath, addArc),
+      JSI_EXPORT_FUNC(JsiSkPath, addOval), JSI_EXPORT_FUNC(JsiSkPath, addPoly),
+      JSI_EXPORT_FUNC(JsiSkPath, addRect), JSI_EXPORT_FUNC(JsiSkPath, addRRect),
       JSI_EXPORT_FUNC(JsiSkPath, arcToOval),
       JSI_EXPORT_FUNC(JsiSkPath, arcToRotated),
       JSI_EXPORT_FUNC(JsiSkPath, rArcTo),

package/cpp/rnskia/dom/base/DerivedNodeProp.h

@@ -116,7 +116,7 @@ public:
   /**
   Returns the derived value
    */
-  std::shared_ptr<T> getDerivedValue() { return _derivedValue; }
+  std::shared_ptr<const T> getDerivedValue() { return _derivedValue; }
 
   /**
    Returns true if is optional and one of the child props has a value, or all
@@ -128,7 +128,7 @@ protected:
   /**
    Set derived value from sub classes
    */
-  void setDerivedValue(std::shared_ptr<T> value) {
+  void setDerivedValue(std::shared_ptr<const T> value) {
     setIsChanged(_derivedValue != value);
     _derivedValue = value;
   }
@@ -138,11 +138,11 @@ protected:
    */
   void setDerivedValue(const T &&value) {
     setIsChanged(true);
-    _derivedValue = std::make_shared<T>(std::move(value));
+    _derivedValue = std::make_shared<const T>(std::move(value));
   }
 
 private:
-  std::shared_ptr<T> _derivedValue;
+  std::shared_ptr<const T> _derivedValue;
 };
 
 /**

package/cpp/rnskia/dom/nodes/JsiBoxNode.h

@@ -15,15 +15,8 @@ public:
 
 protected:
   void renderNode(DrawingContext *context) override {
-    // Verify
-    if (!_rrectProp->isSet() && !_rectProp->isSet()) {
-      throw std::runtime_error("The box property must be set on the Box node.");
-    }
-
     // Get rect - we'll try to end up with an rrect:
-    auto box = _rrectProp->isSet()
-                   ? *_rrectProp->getDerivedValue()
-                   : SkRRect::MakeRectXY(*_rectProp->getDerivedValue(), 0, 0);
+    auto box = *_boxProp->getDerivedValue();
 
     // Get shadows
     std::vector<std::shared_ptr<JsiBoxShadowNode>> shadows;
@@ -76,13 +69,13 @@ protected:
 
   void defineProperties(NodePropsContainer *container) override {
     JsiDomRenderNode::defineProperties(container);
-    _rrectProp = container->defineProperty<RRectProp>("box");
-    _rectProp = container->defineProperty<RectProp>("box");
+    _boxProp = container->defineProperty<BoxProps>("box");
+    _boxProp->require();
   }
 
 private:
-  SkRRect inflate(const SkRRect &box, SkScalar dx, SkScalar dy, size_t tx = 0,
-                  size_t ty = 0) {
+  SkRRect inflate(const SkRRect &box, SkScalar dx, SkScalar dy, SkScalar tx = 0,
+                  SkScalar ty = 0) {
     return SkRRect::MakeRectXY(
         SkRect::MakeXYWH(box.rect().x() - dx + tx, box.rect().y() - dy + ty,
                          box.rect().width() + 2 * dx,
@@ -90,13 +83,12 @@ private:
         box.getSimpleRadii().x() + dx, box.getSimpleRadii().y() + dy);
   }
 
-  SkRRect deflate(const SkRRect &box, SkScalar dx, SkScalar dy, size_t tx = 0,
-                  size_t ty = 0) {
+  SkRRect deflate(const SkRRect &box, SkScalar dx, SkScalar dy, SkScalar tx = 0,
+                  SkScalar ty = 0) {
     return inflate(box, -dx, -dy, tx, ty);
   }
 
-  RRectProp *_rrectProp;
-  RectProp *_rectProp;
+  BoxProps *_boxProp;
 };
 
 } // namespace RNSkia

package/cpp/rnskia/dom/nodes/JsiPathNode.h

@@ -59,20 +59,22 @@ protected:
                 ", end: " + std::to_string(_endProp->value().getAsNumber()));
           }
           filteredPath.swap(filteredPath);
-          _path = std::make_shared<SkPath>(filteredPath);
+          _path = std::make_shared<const SkPath>(filteredPath);
         } else if (hasStartOffset || hasEndOffset) {
           throw std::runtime_error(
               "Failed trimming path with parameters start: " +
               std::to_string(_startProp->value().getAsNumber()) +
               ", end: " + std::to_string(_endProp->value().getAsNumber()));
         } else {
-          _path = std::make_shared<SkPath>(filteredPath);
+          _path = std::make_shared<const SkPath>(filteredPath);
         }
 
         // Set fill style
         if (_fillTypeProp->isSet()) {
           auto fillType = _fillTypeProp->value().getAsString();
-          _path->setFillType(getFillTypeFromStringValue(fillType));
+          auto p = std::make_shared<SkPath>(*_path.get());
+          p->setFillType(getFillTypeFromStringValue(fillType));
+          _path = std::const_pointer_cast<const SkPath>(p);
         }
 
         // do we have a special paint here?
@@ -105,9 +107,14 @@ protected:
             precision = opts.getValue(PropNamePrecision).getAsNumber();
           }
 
-          if (!strokePaint.getFillPath(*_path.get(), _path.get(), nullptr,
+          // _path is const so we can't mutate it directly, let's replace the
+          // path like this:
+          auto p = std::make_shared<SkPath>(*_path.get());
+          if (!strokePaint.getFillPath(*_path.get(), p.get(), nullptr,
                                        precision)) {
             _path = nullptr;
+          } else {
+            _path = std::const_pointer_cast<const SkPath>(p);
           }
         }
 
@@ -157,7 +164,7 @@ private:
   NodeProp *_fillTypeProp;
   NodeProp *_strokeOptsProp;
 
-  std::shared_ptr<SkPath> _path;
+  std::shared_ptr<const SkPath> _path;
 };
 
 class StrokeOptsProps : public BaseDerivedProp {

package/cpp/rnskia/dom/nodes/JsiShaderNodes.h

@@ -67,9 +67,22 @@ protected:
       }
       auto uniforms =
           _uniformsProp->isSet() ? _uniformsProp->getDerivedValue() : nullptr;
-      auto localMatrix =
+
+      SkMatrix lm;
+      auto tm =
           _transformProp->isSet() ? _transformProp->getDerivedValue() : nullptr;
 
+      if (tm != nullptr) {
+        if (_originProp->isSet()) {
+          auto tr = _originProp->getDerivedValue();
+          lm.preTranslate(tr->x(), tr->y());
+          lm.preConcat(*tm);
+          lm.preTranslate(-tr->x(), -tr->y());
+        } else {
+          lm.preConcat(*tm);
+        }
+      }
+
       // get all children that are shader nodes
       std::vector<sk_sp<SkShader>> children;
       children.reserve(getChildren().size());
@@ -82,8 +95,7 @@ protected:
 
       // Update shader
       setShader(context, source->getObject()->makeShader(
-                             uniforms, children.data(), children.size(),
-                             localMatrix.get()));
+                             uniforms, children.data(), children.size(), &lm));
     }
   }
 
@@ -93,6 +105,7 @@ protected:
     _uniformsProp =
         container->defineProperty<UniformsProp>("uniforms", _sourceProp);
     _transformProp = container->defineProperty<TransformProp>("transform");
+    _originProp = container->defineProperty<PointProp>("origin");
 
     _sourceProp->require();
   }
@@ -101,6 +114,7 @@ private:
   NodeProp *_sourceProp;
   UniformsProp *_uniformsProp;
   TransformProp *_transformProp;
+  PointProp *_originProp;
 };
 
 class JsiImageShaderNode : public JsiBaseShaderNode,
@@ -114,15 +128,28 @@ protected:
     if (isChanged(context)) {
       auto image = _imageProps->getImage();
       auto rect = _imageProps->getRect();
-      auto lm = _transformProp->isSet()
-                    ? _transformProp->getDerivedValue().get()
-                    : nullptr;
+      auto lm =
+          _transformProp->isSet() ? _transformProp->getDerivedValue() : nullptr;
 
       if (rect != nullptr && lm != nullptr) {
         auto rc = _imageProps->getDerivedValue();
         auto m3 = _imageProps->rect2rect(rc->src, rc->dst);
-        lm->preTranslate(m3.x(), m3.y());
-        lm->preScale(m3.width(), m3.height());
+        if (_transformProp->isChanged()) {
+          // To modify the matrix we need to copy it since we're not allowed to
+          // modify values contained in properties - this would have caused the
+          // matrix to be translated and scaled more and more for each render
+          // even thought the matrix prop did not change.
+          _matrix.reset();
+          _matrix.preConcat(m3);
+          if (_originProp->isSet()) {
+            auto tr = _originProp->getDerivedValue();
+            _matrix.preTranslate(tr->x(), tr->y());
+            _matrix.preConcat(*lm);
+            _matrix.preTranslate(-tr->x(), -tr->y());
+          } else {
+            _matrix.preConcat(*lm);
+          }
+        }
       }
 
       setShader(
@@ -133,7 +160,7 @@ protected:
                                     _filterModeProp->value().getAsString()),
                                 getMipmapModeFromString(
                                     _mipmapModeProp->value().getAsString())),
-              lm));
+              &_matrix));
     }
   }
 
@@ -146,6 +173,7 @@ protected:
 
     _imageProps = container->defineProperty<ImageProps>();
     _transformProp = container->defineProperty<TransformProp>("transform");
+    _originProp = container->defineProperty<PointProp>("origin");
 
     _txProp->require();
     _tyProp->require();
@@ -185,12 +213,15 @@ private:
                              "\" is not a valid Mipmap Mode.");
   }
 
+  SkMatrix _matrix;
+
   TileModeProp *_txProp;
   TileModeProp *_tyProp;
   NodeProp *_filterModeProp;
   NodeProp *_mipmapModeProp;
   ImageProps *_imageProps;
   TransformProp *_transformProp;
+  PointProp *_originProp;
 };
 
 class JsiColorShaderNode : public JsiBaseShaderNode,
@@ -328,12 +359,12 @@ protected:
     }
   }
 
-  SkColor *_colors;
-  SkTileMode _mode;
+  const SkColor *_colors;
   double _flags;
-  SkScalar *_positions;
-  SkMatrix *_matrix;
   int _colorCount;
+  SkTileMode _mode;
+  const SkScalar *_positions;
+  const SkMatrix *_matrix;
 
 private:
   TransformsProps *_transformsProps;

package/cpp/rnskia/dom/props/ClipProp.h

@@ -45,18 +45,18 @@ public:
     return _pathProp->isSet() || _rectProp->isSet() || _rrectProp->isSet();
   }
 
-  SkPath *getPath() { return _path.get(); }
-  SkRect *getRect() { return _rect.get(); }
-  SkRRect *getRRect() { return _rrect.get(); }
+  const SkPath *getPath() { return _path.get(); }
+  const SkRect *getRect() { return _rect.get(); }
+  const SkRRect *getRRect() { return _rrect.get(); }
 
 private:
   PathProp *_pathProp;
   RectProp *_rectProp;
   RRectProp *_rrectProp;
 
-  std::shared_ptr<SkPath> _path;
-  std::shared_ptr<SkRect> _rect;
-  std::shared_ptr<SkRRect> _rrect;
+  std::shared_ptr<const SkPath> _path;
+  std::shared_ptr<const SkRect> _rect;
+  std::shared_ptr<const SkRRect> _rrect;
 };
 
 } // namespace RNSkia

package/cpp/rnskia/dom/props/ImageProps.h

@@ -74,14 +74,19 @@ public:
   }
 
   sk_sp<SkImage> getImage() { return _imageProp->getDerivedValue(); }
-  std::shared_ptr<SkRect> getRect() { return _rectProp->getDerivedValue(); }
-
-  SkRect rect2rect(SkRect src, SkRect dst) {
-    auto scaleX = dst.width() / src.width();
-    auto scaleY = dst.height() / src.height();
-    auto translateX = dst.x() - src.x() * scaleX;
-    auto translateY = dst.y() - src.y() * scaleY;
-    return SkRect::MakeXYWH(translateX, translateY, scaleX, scaleY);
+  std::shared_ptr<const SkRect> getRect() {
+    return _rectProp->getDerivedValue();
+  }
+
+  SkMatrix rect2rect(SkRect src, SkRect dst) {
+    auto sx = dst.width() / src.width();
+    auto sy = dst.height() / src.height();
+    auto tx = dst.x() - src.x() * sx;
+    auto ty = dst.y() - src.y() * sy;
+    SkMatrix m3;
+    m3.preTranslate(tx, ty);
+    m3.preScale(sx, sy);
+    return m3;
   }
 
 private:

package/cpp/rnskia/dom/props/PaintProps.h

@@ -19,8 +19,6 @@
 
 namespace RNSkia {
 
-static PropId PropNameCurrent = JsiPropId::get("current");
-
 class PaintProp : public DerivedProp<SkPaint> {
 public:
   explicit PaintProp(PropId name) : DerivedProp<SkPaint>() {
@@ -40,20 +38,6 @@ public:
           throw std::runtime_error("Expected SkPaint object, got unknown "
                                    "object when reading paint property.");
         }
-      } else if (_paintProp->value().getType() == PropType::Object) {
-        // We have a JS object - is it a ref?
-        auto ref = _paintProp->value().getValue(PropNameCurrent);
-        if (ref.getType() == PropType::HostObject) {
-          auto ptr = ref.getAs<JsiSkPaint>();
-          if (ptr != nullptr) {
-            // Update the local paint for the current context
-            setDerivedValue(ptr->getObject());
-          } else {
-            throw std::runtime_error(
-                "Expected reference to a SkPaint object, got unknown object "
-                "when reading paint property.");
-          }
-        }
       } else {
         setDerivedValue(nullptr);
       }