@shopify/react-native-skia 0.1.154 → 0.1.156

package/cpp/api/JsiSkTextBlob.h

@@ -16,35 +16,32 @@
 
 namespace RNSkia {
 
-    using namespace facebook;
-
-    class JsiSkTextBlob : public JsiSkWrappingSkPtrHostObject<SkTextBlob> {
-    public:
-        JsiSkTextBlob(
-                std::shared_ptr<RNSkPlatformContext> context,
-                sk_sp<SkTextBlob> shader
-        ) : JsiSkWrappingSkPtrHostObject<SkTextBlob>(std::move(context), std::move(shader)) {}
-
-        // TODO: declare in JsiSkWrappingSkPtrHostObject via extra template parameter?
-
-        JSI_PROPERTY_GET(__typename__) {
-            return jsi::String::createFromUtf8(runtime, "TextBlob");
-        }
-
-        JSI_EXPORT_PROPERTY_GETTERS(
-                JSI_EXPORT_PROP_GET(JsiSkTextBlob, __typename__),
-        )
-
-        /**
-        Returns the underlying object from a host object of this type
-       */
-        static sk_sp<SkTextBlob> fromValue(jsi::Runtime &runtime,
-                                                    const jsi::Value &obj) {
-            return obj.asObject(runtime)
-                        .asHostObject<JsiSkTextBlob>(runtime)
-                        ->getObject();
-
-        }
-
-    };
+namespace jsi = facebook::jsi;
+
+class JsiSkTextBlob : public JsiSkWrappingSkPtrHostObject<SkTextBlob> {
+public:
+  JsiSkTextBlob(std::shared_ptr<RNSkPlatformContext> context,
+                sk_sp<SkTextBlob> shader)
+      : JsiSkWrappingSkPtrHostObject<SkTextBlob>(std::move(context),
+                                                 std::move(shader)) {}
+
+  // TODO: declare in JsiSkWrappingSkPtrHostObject via extra template parameter?
+
+  JSI_PROPERTY_GET(__typename__) {
+    return jsi::String::createFromUtf8(runtime, "TextBlob");
+  }
+
+  JSI_EXPORT_PROPERTY_GETTERS(JSI_EXPORT_PROP_GET(JsiSkTextBlob,
+                                                  __typename__), )
+
+  /**
+  Returns the underlying object from a host object of this type
+ */
+  static sk_sp<SkTextBlob> fromValue(jsi::Runtime &runtime,
+                                     const jsi::Value &obj) {
+    return obj.asObject(runtime)
+        .asHostObject<JsiSkTextBlob>(runtime)
+        ->getObject();
+  }
+};
 } // namespace RNSkia

package/cpp/api/JsiSkTextBlobFactory.h

@@ -6,10 +6,10 @@
 
 #include <jsi/jsi.h>
 
+#include "JsiSkFont.h"
 #include "JsiSkHostObjects.h"
-#include "JsiSkTextBlob.h"
 #include "JsiSkRSXform.h"
-#include "JsiSkFont.h"
+#include "JsiSkTextBlob.h"
 
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdocumentation"
@@ -20,90 +20,91 @@
 
 namespace RNSkia {
 
-    using namespace facebook;
-
-    class JsiSkTextBlobFactory : public JsiSkHostObject {
-    public:
-        JSI_HOST_FUNCTION(MakeFromText) {
-            auto str = arguments[0].asString(runtime).utf8(runtime);
-            auto font = JsiSkFont::fromValue(runtime, arguments[1]);
-            auto textBlob = SkTextBlob::MakeFromString(str.c_str(), *font);
-            return jsi::Object::createFromHostObject(
-                    runtime,
-                    std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob))
-            );
-        }
-
-        JSI_HOST_FUNCTION(MakeFromGlyphs) {
-            auto jsiGlyphs = arguments[0].asObject(runtime).asArray(runtime);
-            auto font = JsiSkFont::fromValue(runtime, arguments[1]);
-            int bytesPerGlyph = 2;
-            std::vector<SkGlyphID> glyphs;
-            int glyphsSize = static_cast<int>(jsiGlyphs.size(runtime));
-            glyphs.reserve(glyphsSize);
-            for (int i = 0; i < glyphsSize; i++) {
-                glyphs.push_back(jsiGlyphs.getValueAtIndex(runtime, i).asNumber());
-            }
-            auto textBlob =  SkTextBlob::MakeFromText(glyphs.data(), glyphs.size() * bytesPerGlyph, *font, SkTextEncoding::kGlyphID);
-            return jsi::Object::createFromHostObject(
-                    runtime,
-                    std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob))
-            );
-        }
-
-        JSI_HOST_FUNCTION(MakeFromRSXform) {
-            auto str = arguments[0].asString(runtime).utf8(runtime);
-            auto jsiRsxforms = arguments[1].asObject(runtime).asArray(runtime);
-            auto font = JsiSkFont::fromValue(runtime, arguments[2]);            
-            std::vector<SkRSXform> rsxforms;
-            int rsxformsSize = static_cast<int>(jsiRsxforms.size(runtime));
-            rsxforms.reserve(rsxformsSize);
-            for (int i = 0; i < rsxformsSize; i++) {
-                auto rsxform = JsiSkRSXform::fromValue(runtime, jsiRsxforms.getValueAtIndex(runtime, i));
-                rsxforms.push_back(*rsxform);
-            }
-            auto textBlob = SkTextBlob::MakeFromRSXform(str.c_str(), str.length(), rsxforms.data(), *font);
-            return jsi::Object::createFromHostObject(
-                    runtime,
-                    std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob))
-            );
-        }
-
-        JSI_HOST_FUNCTION(MakeFromRSXformGlyphs) {
-            auto jsiGlyphs = arguments[0].asObject(runtime).asArray(runtime);
-            auto jsiRsxforms = arguments[1].asObject(runtime).asArray(runtime);
-            auto font = JsiSkFont::fromValue(runtime, arguments[2]);
-            int bytesPerGlyph = 2;
-            std::vector<SkGlyphID> glyphs;
-            int glyphsSize = static_cast<int>(jsiGlyphs.size(runtime));
-            glyphs.reserve(glyphsSize);
-            for (int i = 0; i < glyphsSize; i++) {
-                glyphs.push_back(jsiGlyphs.getValueAtIndex(runtime, i).asNumber());
-            }
-            std::vector<SkRSXform> rsxforms;
-            int rsxformsSize = static_cast<int>(jsiRsxforms.size(runtime));
-            rsxforms.reserve(rsxformsSize);
-            for (int i = 0; i < rsxformsSize; i++) {
-                auto rsxform = JsiSkRSXform::fromValue(runtime, jsiRsxforms.getValueAtIndex(runtime, i));
-                rsxforms.push_back(*rsxform);
-            }
-            auto textBlob = SkTextBlob::MakeFromRSXform(glyphs.data(), glyphs.size() * bytesPerGlyph, rsxforms.data(), *font, SkTextEncoding::kGlyphID);
-            return jsi::Object::createFromHostObject(
-                    runtime,
-                    std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob))
-            );
-        }
-
-
-        JSI_EXPORT_FUNCTIONS(
-            JSI_EXPORT_FUNC(JsiSkTextBlobFactory, MakeFromText),
-            JSI_EXPORT_FUNC(JsiSkTextBlobFactory, MakeFromGlyphs),
-            JSI_EXPORT_FUNC(JsiSkTextBlobFactory, MakeFromRSXform),
-            JSI_EXPORT_FUNC(JsiSkTextBlobFactory, MakeFromRSXformGlyphs),
-        )
-
-        JsiSkTextBlobFactory(std::shared_ptr<RNSkPlatformContext> context)
-                : JsiSkHostObject(std::move(context)) {}
-    };
+namespace jsi = facebook::jsi;
+
+class JsiSkTextBlobFactory : public JsiSkHostObject {
+public:
+  JSI_HOST_FUNCTION(MakeFromText) {
+    auto str = arguments[0].asString(runtime).utf8(runtime);
+    auto font = JsiSkFont::fromValue(runtime, arguments[1]);
+    auto textBlob = SkTextBlob::MakeFromString(str.c_str(), *font);
+    return jsi::Object::createFromHostObject(
+        runtime,
+        std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob)));
+  }
+
+  JSI_HOST_FUNCTION(MakeFromGlyphs) {
+    auto jsiGlyphs = arguments[0].asObject(runtime).asArray(runtime);
+    auto font = JsiSkFont::fromValue(runtime, arguments[1]);
+    int bytesPerGlyph = 2;
+    std::vector<SkGlyphID> glyphs;
+    int glyphsSize = static_cast<int>(jsiGlyphs.size(runtime));
+    glyphs.reserve(glyphsSize);
+    for (int i = 0; i < glyphsSize; i++) {
+      glyphs.push_back(jsiGlyphs.getValueAtIndex(runtime, i).asNumber());
+    }
+    auto textBlob =
+        SkTextBlob::MakeFromText(glyphs.data(), glyphs.size() * bytesPerGlyph,
+                                 *font, SkTextEncoding::kGlyphID);
+    return jsi::Object::createFromHostObject(
+        runtime,
+        std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob)));
+  }
+
+  JSI_HOST_FUNCTION(MakeFromRSXform) {
+    auto str = arguments[0].asString(runtime).utf8(runtime);
+    auto jsiRsxforms = arguments[1].asObject(runtime).asArray(runtime);
+    auto font = JsiSkFont::fromValue(runtime, arguments[2]);
+    std::vector<SkRSXform> rsxforms;
+    int rsxformsSize = static_cast<int>(jsiRsxforms.size(runtime));
+    rsxforms.reserve(rsxformsSize);
+    for (int i = 0; i < rsxformsSize; i++) {
+      auto rsxform = JsiSkRSXform::fromValue(
+          runtime, jsiRsxforms.getValueAtIndex(runtime, i));
+      rsxforms.push_back(*rsxform);
+    }
+    auto textBlob = SkTextBlob::MakeFromRSXform(str.c_str(), str.length(),
+                                                rsxforms.data(), *font);
+    return jsi::Object::createFromHostObject(
+        runtime,
+        std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob)));
+  }
+
+  JSI_HOST_FUNCTION(MakeFromRSXformGlyphs) {
+    auto jsiGlyphs = arguments[0].asObject(runtime).asArray(runtime);
+    auto jsiRsxforms = arguments[1].asObject(runtime).asArray(runtime);
+    auto font = JsiSkFont::fromValue(runtime, arguments[2]);
+    int bytesPerGlyph = 2;
+    std::vector<SkGlyphID> glyphs;
+    int glyphsSize = static_cast<int>(jsiGlyphs.size(runtime));
+    glyphs.reserve(glyphsSize);
+    for (int i = 0; i < glyphsSize; i++) {
+      glyphs.push_back(jsiGlyphs.getValueAtIndex(runtime, i).asNumber());
+    }
+    std::vector<SkRSXform> rsxforms;
+    int rsxformsSize = static_cast<int>(jsiRsxforms.size(runtime));
+    rsxforms.reserve(rsxformsSize);
+    for (int i = 0; i < rsxformsSize; i++) {
+      auto rsxform = JsiSkRSXform::fromValue(
+          runtime, jsiRsxforms.getValueAtIndex(runtime, i));
+      rsxforms.push_back(*rsxform);
+    }
+    auto textBlob = SkTextBlob::MakeFromRSXform(
+        glyphs.data(), glyphs.size() * bytesPerGlyph, rsxforms.data(), *font,
+        SkTextEncoding::kGlyphID);
+    return jsi::Object::createFromHostObject(
+        runtime,
+        std::make_shared<JsiSkTextBlob>(getContext(), std::move(textBlob)));
+  }
+
+  JSI_EXPORT_FUNCTIONS(JSI_EXPORT_FUNC(JsiSkTextBlobFactory, MakeFromText),
+                       JSI_EXPORT_FUNC(JsiSkTextBlobFactory, MakeFromGlyphs),
+                       JSI_EXPORT_FUNC(JsiSkTextBlobFactory, MakeFromRSXform),
+                       JSI_EXPORT_FUNC(JsiSkTextBlobFactory,
+                                       MakeFromRSXformGlyphs), )
+
+  explicit JsiSkTextBlobFactory(std::shared_ptr<RNSkPlatformContext> context)
+      : JsiSkHostObject(std::move(context)) {}
+};
 
 } // namespace RNSkia

package/cpp/api/JsiSkTypeface.h

@@ -18,7 +18,7 @@
 
 namespace RNSkia {
 
-using namespace facebook;
+namespace jsi = facebook::jsi;
 
 class JsiSkTypeface : public JsiSkWrappingSkPtrHostObject<SkTypeface> {
 public:
@@ -31,7 +31,7 @@ public:
 
   JsiSkTypeface(std::shared_ptr<RNSkPlatformContext> context,
                 sk_sp<SkTypeface> typeface)
-      : JsiSkWrappingSkPtrHostObject(std::move(context), std::move(typeface)){}
+      : JsiSkWrappingSkPtrHostObject(std::move(context), std::move(typeface)) {}
 
   /**
     Returns the underlying object from a host object of this type
@@ -47,10 +47,11 @@ public:
    Returns the jsi object from a host object of this type
   */
   static jsi::Value toValue(jsi::Runtime &runtime,
-                              std::shared_ptr<RNSkPlatformContext> context,
-                              sk_sp<SkTypeface> tf) {
+                            std::shared_ptr<RNSkPlatformContext> context,
+                            sk_sp<SkTypeface> tf) {
     return jsi::Object::createFromHostObject(
-              runtime, std::make_shared<JsiSkTypeface>(std::move(context), std::move(tf)));
+        runtime,
+        std::make_shared<JsiSkTypeface>(std::move(context), std::move(tf)));
   }
 };
 

package/cpp/api/JsiSkTypefaceFactory.h

@@ -5,30 +5,31 @@
 
 #include <jsi/jsi.h>
 
-#include "JsiSkTypeface.h"
-#include "JsiSkHostObjects.h"
 #include "JsiSkData.h"
+#include "JsiSkHostObjects.h"
+#include "JsiSkTypeface.h"
 
 namespace RNSkia {
 
-    using namespace facebook;
-
-    class JsiSkTypefaceFactory : public JsiSkHostObject {
-    public:
-        JSI_HOST_FUNCTION(MakeFreeTypeFaceFromData) {
-            auto data = JsiSkData::fromValue(runtime, arguments[0]);
-            auto typeface = SkFontMgr::RefDefault()->makeFromData(std::move(data));
-            if(typeface == nullptr) {
-              return jsi::Value::null();
-            }
-            return jsi::Object::createFromHostObject(
-                runtime, std::make_shared<JsiSkTypeface>(getContext(), typeface));
-        }
-
-        JSI_EXPORT_FUNCTIONS(JSI_EXPORT_FUNC(JsiSkTypefaceFactory, MakeFreeTypeFaceFromData))
-
-        JsiSkTypefaceFactory(std::shared_ptr<RNSkPlatformContext> context)
-                : JsiSkHostObject(std::move(context)) {}
-    };
+namespace jsi = facebook::jsi;
+
+class JsiSkTypefaceFactory : public JsiSkHostObject {
+public:
+  JSI_HOST_FUNCTION(MakeFreeTypeFaceFromData) {
+    auto data = JsiSkData::fromValue(runtime, arguments[0]);
+    auto typeface = SkFontMgr::RefDefault()->makeFromData(std::move(data));
+    if (typeface == nullptr) {
+      return jsi::Value::null();
+    }
+    return jsi::Object::createFromHostObject(
+        runtime, std::make_shared<JsiSkTypeface>(getContext(), typeface));
+  }
+
+  JSI_EXPORT_FUNCTIONS(JSI_EXPORT_FUNC(JsiSkTypefaceFactory,
+                                       MakeFreeTypeFaceFromData))
+
+  explicit JsiSkTypefaceFactory(std::shared_ptr<RNSkPlatformContext> context)
+      : JsiSkHostObject(std::move(context)) {}
+};
 
 } // namespace RNSkia

package/cpp/api/JsiSkVertices.h

@@ -1,8 +1,9 @@
 #pragma once
 
+#include <jsi/jsi.h>
 #include <memory>
 #include <utility>
-#include <jsi/jsi.h>
+#include <vector>
 
 #include "JsiSkHostObjects.h"
 
@@ -15,131 +16,143 @@
 
 namespace RNSkia {
 
-    using namespace facebook;
-
-    class JsiSkVertices : public JsiSkWrappingSkPtrHostObject<SkVertices> {
-    public:
-
-        JsiSkVertices(std::shared_ptr<RNSkPlatformContext> context,
-        sk_sp<SkVertices> vertices)
-        : JsiSkWrappingSkPtrHostObject<SkVertices>(std::move(context), std::move(vertices)) {}
-
-        // TODO: declare in JsiSkWrappingSkPtrHostObject via extra template parameter?
-        JSI_PROPERTY_GET(__typename__) {
-            return jsi::String::createFromUtf8(runtime, "Vertices");
-        }
-
-        JSI_EXPORT_PROPERTY_GETTERS(JSI_EXPORT_PROP_GET(JsiSkVertices, __typename__))
-
-        JSI_HOST_FUNCTION(bounds) {
-            const auto& result = getObject()->bounds();
-            return jsi::Object::createFromHostObject(
-                    runtime, std::make_shared<JsiSkRect>(getContext(), result));
-        }
-
-        JSI_HOST_FUNCTION(uniqueID) {
-            return static_cast<double>(getObject()->uniqueID());
+namespace jsi = facebook::jsi;
+
+class JsiSkVertices : public JsiSkWrappingSkPtrHostObject<SkVertices> {
+public:
+  JsiSkVertices(std::shared_ptr<RNSkPlatformContext> context,
+                sk_sp<SkVertices> vertices)
+      : JsiSkWrappingSkPtrHostObject<SkVertices>(std::move(context),
+                                                 std::move(vertices)) {}
+
+  // TODO: declare in JsiSkWrappingSkPtrHostObject via extra template parameter?
+  JSI_PROPERTY_GET(__typename__) {
+    return jsi::String::createFromUtf8(runtime, "Vertices");
+  }
+
+  JSI_EXPORT_PROPERTY_GETTERS(JSI_EXPORT_PROP_GET(JsiSkVertices, __typename__))
+
+  JSI_HOST_FUNCTION(bounds) {
+    const auto &result = getObject()->bounds();
+    return jsi::Object::createFromHostObject(
+        runtime, std::make_shared<JsiSkRect>(getContext(), result));
+  }
+
+  JSI_HOST_FUNCTION(uniqueID) {
+    return static_cast<double>(getObject()->uniqueID());
+  }
+
+  JSI_EXPORT_FUNCTIONS(JSI_EXPORT_FUNC(JsiSkVertices, bounds),
+                       JSI_EXPORT_FUNC(JsiSkVertices, uniqueID), )
+
+  /**
+    Returns the underlying object from a host object of this type
+   */
+  static sk_sp<SkVertices> fromValue(jsi::Runtime &runtime,
+                                     const jsi::Value &obj) {
+    return obj.asObject(runtime)
+        .asHostObject<JsiSkVertices>(runtime)
+        ->getObject();
+  }
+
+  /**
+   * Creates the function for construction a new instance of the SkVertices
+   * wrapper
+   * @param context platform context
+   * @return A function for creating a new host object wrapper for the
+   * SkVertices class
+   */
+  static const jsi::HostFunctionType
+  createCtor(std::shared_ptr<RNSkPlatformContext> context) {
+    return JSI_HOST_FUNCTION_LAMBDA {
+      auto mode = static_cast<SkVertices::VertexMode>(arguments[0].getNumber());
+      std::vector<SkPoint> positions;
+      std::vector<SkPoint> texs;
+      std::vector<SkColor> colors;
+      std::vector<uint16_t> indices;
+
+      auto jsiPositions = arguments[1].asObject(runtime).asArray(runtime);
+      auto positionsSize = static_cast<int>(jsiPositions.size(runtime));
+      positions.reserve(positionsSize);
+      for (int i = 0; i < positionsSize; i++) {
+        std::shared_ptr<SkPoint> point = JsiSkPoint::fromValue(
+            runtime,
+            jsiPositions.getValueAtIndex(runtime, i).asObject(runtime));
+        positions.push_back(*point.get());
+      }
+
+      if (count >= 3 && !arguments[2].isNull() && !arguments[2].isUndefined()) {
+        auto jsiTexs = arguments[2].asObject(runtime).asArray(runtime);
+        auto texsSize = jsiTexs.size(runtime);
+        texs.reserve(texsSize);
+        for (int i = 0; i < texsSize; i++) {
+          auto point = JsiSkPoint::fromValue(
+              runtime, jsiTexs.getValueAtIndex(runtime, i).asObject(runtime));
+          texs.push_back(*point.get());
         }
-
-        JSI_EXPORT_FUNCTIONS(JSI_EXPORT_FUNC(JsiSkVertices, bounds),
-                             JSI_EXPORT_FUNC(JsiSkVertices, uniqueID), )
-
-        /**
-          Returns the underlying object from a host object of this type
-         */
-        static sk_sp<SkVertices> fromValue(jsi::Runtime &runtime,
-                                                 const jsi::Value &obj) {
-            return obj.asObject(runtime)
-                        .asHostObject<JsiSkVertices>(runtime)
-                        ->getObject();
+      }
+
+      if (count >= 4 && !arguments[3].isNull() && !arguments[3].isUndefined()) {
+        auto jsiColors = arguments[3].asObject(runtime).asArray(runtime);
+        auto colorsSize = jsiColors.size(runtime);
+        colors.reserve(colorsSize);
+        for (int i = 0; i < colorsSize; i++) {
+          SkColor color = JsiSkColor::fromValue(
+              runtime, jsiColors.getValueAtIndex(runtime, i));
+          colors.push_back(color);
         }
-
-        /**
-         * Creates the function for construction a new instance of the SkVertices
-         * wrapper
-         * @param context platform context
-         * @return A function for creating a new host object wrapper for the SkVertices
-         * class
-         */
-        static const jsi::HostFunctionType
-        createCtor(std::shared_ptr<RNSkPlatformContext> context) {
-            return JSI_HOST_FUNCTION_LAMBDA {
-                auto mode = static_cast<SkVertices::VertexMode>(arguments[0].getNumber());
-                std::vector<SkPoint> positions;
-                std::vector<SkPoint> texs;
-                std::vector<SkColor> colors;
-                std::vector<uint16_t> indices;
-
-                auto jsiPositions = arguments[1].asObject(runtime).asArray(runtime);
-                auto positionsSize = static_cast<int>(jsiPositions.size(runtime));
-                positions.reserve(positionsSize);
-                for (int i = 0; i < positionsSize; i++) {
-                    std::shared_ptr<SkPoint> point = JsiSkPoint::fromValue(
-                            runtime, jsiPositions.getValueAtIndex(runtime, i).asObject(runtime));
-                    positions.push_back(*point.get());
-                }
-
-                if (count >= 3 && !arguments[2].isNull() && !arguments[2].isUndefined()) {
-                    auto jsiTexs = arguments[2].asObject(runtime).asArray(runtime);
-                    auto texsSize = jsiTexs.size(runtime);
-                    texs.reserve(texsSize);
-                    for (int i = 0; i < texsSize; i++) {
-                        auto point = JsiSkPoint::fromValue(
-                                runtime, jsiTexs.getValueAtIndex(runtime, i).asObject(runtime));
-                        texs.push_back(*point.get());
-                    }
-                }
-
-                if (count >= 4 && !arguments[3].isNull() && !arguments[3].isUndefined()) {
-                    auto jsiColors = arguments[3].asObject(runtime).asArray(runtime);
-                    auto colorsSize = jsiColors.size(runtime);
-                    colors.reserve(colorsSize);
-                    for (int i = 0; i < colorsSize; i++) {
-                        SkColor color = JsiSkColor::fromValue(runtime, jsiColors.getValueAtIndex(runtime, i));
-                        colors.push_back(color);
-                    }
-                }
-
-                int indicesSize = 0;
-                if (count >= 5 && !arguments[4].isNull() && !arguments[4].isUndefined()) {
-                    auto jsiIndices = arguments[4].asObject(runtime).asArray(runtime);
-                    indicesSize = static_cast<int>(jsiIndices.size(runtime));
-                    indices.reserve(indicesSize);
-                    for (int i = 0; i < indicesSize; i++) {
-                        uint16_t index = jsiIndices.getValueAtIndex(runtime, i).asNumber();
-                        indices.push_back(index);
-                    }
-                }
-// TODO: this is the technic used in CanvasKit: https://github.com/google/skia/blob/main/modules/canvaskit/interface.js#L1216
-// Note that the isVolatile parameter is unused when using MakeCopy()
-//                auto isVolatile = count >= 6 && !arguments[5].isNull() && !arguments[5].isUndefined() ? arguments[5].getBool() : false;
-//                auto flags = 0;
-//                // These flags are from SkVertices.h and should be kept in sync with those.
-//                if (texs.size() > 0) {
-//                    flags |= (1 << 0);
-//                }
-//                if (colors.size() > 0) {
-//                    flags |= (1 << 1);
-//                }
-//                if (!isVolatile) {
-//                    flags |= (1 << 2);
-//                }
-//                auto builder = SkVertices::Builder(mode, positionsSize/2, indicesSize, flags);
-//                std::copy(positions.data(), positions.data() + positionsSize, builder.positions());
-//                if (builder.texCoords()) {
-//                    std::copy(std::begin(texs), std::end(texs), builder.texCoords());
-//                }
-//                if (builder.colors()) {
-//                    std::copy(std::begin(colors), std::end(colors), builder.colors());
-//                }
-//                if (builder.indices()) {
-//                    std::copy(std::begin(indices), std::end(indices), builder.indices());
-//                }
-//                auto vertices = builder.detach();
-                auto vertices = SkVertices::MakeCopy(mode, positionsSize, positions.data(), texs.data(), colors.data(), indicesSize, indices.data());
-                return jsi::Object::createFromHostObject(
-                        runtime, std::make_shared<JsiSkVertices>(context, std::move(vertices)));
-            };
+      }
+
+      int indicesSize = 0;
+      if (count >= 5 && !arguments[4].isNull() && !arguments[4].isUndefined()) {
+        auto jsiIndices = arguments[4].asObject(runtime).asArray(runtime);
+        indicesSize = static_cast<int>(jsiIndices.size(runtime));
+        indices.reserve(indicesSize);
+        for (int i = 0; i < indicesSize; i++) {
+          uint16_t index = jsiIndices.getValueAtIndex(runtime, i).asNumber();
+          indices.push_back(index);
         }
+      }
+      // TODO: this is the technic used in CanvasKit:
+      // https://github.com/google/skia/blob/main/modules/canvaskit/interface.js#L1216
+      // Note that the isVolatile parameter is unused when using MakeCopy()
+      //                auto isVolatile = count >= 6 && !arguments[5].isNull()
+      //                && !arguments[5].isUndefined() ? arguments[5].getBool()
+      //                : false; auto flags = 0;
+      //                // These flags are from SkVertices.h and should be kept
+      //                in sync with those. if (texs.size() > 0) {
+      //                    flags |= (1 << 0);
+      //                }
+      //                if (colors.size() > 0) {
+      //                    flags |= (1 << 1);
+      //                }
+      //                if (!isVolatile) {
+      //                    flags |= (1 << 2);
+      //                }
+      //                auto builder = SkVertices::Builder(mode,
+      //                positionsSize/2, indicesSize, flags);
+      //                std::copy(positions.data(), positions.data() +
+      //                positionsSize, builder.positions()); if
+      //                (builder.texCoords()) {
+      //                    std::copy(std::begin(texs), std::end(texs),
+      //                    builder.texCoords());
+      //                }
+      //                if (builder.colors()) {
+      //                    std::copy(std::begin(colors), std::end(colors),
+      //                    builder.colors());
+      //                }
+      //                if (builder.indices()) {
+      //                    std::copy(std::begin(indices), std::end(indices),
+      //                    builder.indices());
+      //                }
+      //                auto vertices = builder.detach();
+      auto vertices = SkVertices::MakeCopy(
+          mode, positionsSize, positions.data(), texs.data(), colors.data(),
+          indicesSize, indices.data());
+      return jsi::Object::createFromHostObject(
+          runtime,
+          std::make_shared<JsiSkVertices>(context, std::move(vertices)));
     };
+  }
+};
 } // namespace RNSkia