@shopify/flash-list 2.0.1 → 2.0.2-rc.1

package/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerImpl.kt

@@ -0,0 +1,16 @@
+package com.shopify.reactnative.flash_list
+
+import android.content.Context
+import com.facebook.react.views.view.ReactViewGroup
+
+class CellContainerImpl(context: Context) : ReactViewGroup(context), CellContainer {
+    private var index = -1
+    override fun setIndex(value: Int) {
+        index = value
+    }
+
+    override fun getIndex(): Int {
+        return index
+    }
+
+}

package/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt

@@ -0,0 +1,34 @@
+package com.shopify.reactnative.flash_list
+
+import com.facebook.react.module.annotations.ReactModule
+import com.facebook.react.uimanager.ThemedReactContext
+import com.facebook.react.uimanager.ViewGroupManager
+import com.facebook.react.uimanager.ViewManagerDelegate
+import com.facebook.react.uimanager.annotations.ReactProp
+import com.facebook.react.viewmanagers.CellContainerManagerDelegate
+import com.facebook.react.viewmanagers.CellContainerManagerInterface
+
+@ReactModule(name = AutoLayoutViewManager.REACT_CLASS)
+class CellContainerManager: ViewGroupManager<CellContainerImpl>(), CellContainerManagerInterface<CellContainerImpl> {
+    private val mDelegate: CellContainerManagerDelegate<CellContainerImpl, CellContainerManager>
+        = CellContainerManagerDelegate(this)
+
+    companion object {
+        const val REACT_CLASS = "CellContainer"
+    }
+
+    override fun getName(): String {
+        return REACT_CLASS
+    }
+
+    override fun getDelegate(): ViewManagerDelegate<CellContainerImpl> = mDelegate
+
+    override fun createViewInstance(context: ThemedReactContext): CellContainerImpl {
+        return CellContainerImpl(context)
+    }
+
+    @ReactProp(name = "index")
+    override fun setIndex(view: CellContainerImpl, index: Int) {
+        view.index = index
+    }
+}

package/android/src/main/kotlin/com/shopify/reactnative/flash_list/FlashListPackage.kt

@@ -0,0 +1,19 @@
+package com.shopify.reactnative.flash_list
+
+import com.facebook.react.ReactPackage
+import com.facebook.react.bridge.NativeModule
+import com.facebook.react.bridge.ReactApplicationContext
+import com.facebook.react.uimanager.ViewManager
+
+class ReactNativeFlashListPackage : ReactPackage {
+  override fun createNativeModules(reactContext: ReactApplicationContext): List<NativeModule> {
+    return listOf()
+  }
+
+  override fun createViewManagers(reactContext: ReactApplicationContext): List<ViewManager<*, *>> {
+    return listOf(
+        AutoLayoutViewManager(),
+        CellContainerManager()
+    )
+  }
+}

package/android/src/paper/java/com/facebook/react/viewmanagers/AutoLayoutViewManagerDelegate.java

@@ -0,0 +1,47 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaDelegate.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import androidx.annotation.Nullable;
+import com.facebook.react.uimanager.BaseViewManager;
+import com.facebook.react.uimanager.BaseViewManagerDelegate;
+import com.facebook.react.uimanager.LayoutShadowNode;
+
+public class AutoLayoutViewManagerDelegate<T extends View, U extends BaseViewManager<T, ? extends LayoutShadowNode> & AutoLayoutViewManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
+  public AutoLayoutViewManagerDelegate(U viewManager) {
+    super(viewManager);
+  }
+  @Override
+  public void setProperty(T view, String propName, @Nullable Object value) {
+    switch (propName) {
+      case "horizontal":
+        mViewManager.setHorizontal(view, value == null ? false : (boolean) value);
+        break;
+      case "scrollOffset":
+        mViewManager.setScrollOffset(view, value == null ? 0f : ((Double) value).doubleValue());
+        break;
+      case "windowSize":
+        mViewManager.setWindowSize(view, value == null ? 0f : ((Double) value).doubleValue());
+        break;
+      case "renderAheadOffset":
+        mViewManager.setRenderAheadOffset(view, value == null ? 0f : ((Double) value).doubleValue());
+        break;
+      case "enableInstrumentation":
+        mViewManager.setEnableInstrumentation(view, value == null ? false : (boolean) value);
+        break;
+      case "disableAutoLayout":
+        mViewManager.setDisableAutoLayout(view, value == null ? false : (boolean) value);
+        break;
+      default:
+        super.setProperty(view, propName, value);
+    }
+  }
+}

package/android/src/paper/java/com/facebook/react/viewmanagers/AutoLayoutViewManagerInterface.java

@@ -0,0 +1,21 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaInterface.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+
+public interface AutoLayoutViewManagerInterface<T extends View> {
+  void setHorizontal(T view, boolean value);
+  void setScrollOffset(T view, double value);
+  void setWindowSize(T view, double value);
+  void setRenderAheadOffset(T view, double value);
+  void setEnableInstrumentation(T view, boolean value);
+  void setDisableAutoLayout(T view, boolean value);
+}

package/android/src/paper/java/com/facebook/react/viewmanagers/CellContainerManagerDelegate.java

@@ -0,0 +1,32 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaDelegate.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import androidx.annotation.Nullable;
+import com.facebook.react.uimanager.BaseViewManager;
+import com.facebook.react.uimanager.BaseViewManagerDelegate;
+import com.facebook.react.uimanager.LayoutShadowNode;
+
+public class CellContainerManagerDelegate<T extends View, U extends BaseViewManager<T, ? extends LayoutShadowNode> & CellContainerManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
+  public CellContainerManagerDelegate(U viewManager) {
+    super(viewManager);
+  }
+  @Override
+  public void setProperty(T view, String propName, @Nullable Object value) {
+    switch (propName) {
+      case "index":
+        mViewManager.setIndex(view, value == null ? 0 : ((Double) value).intValue());
+        break;
+      default:
+        super.setProperty(view, propName, value);
+    }
+  }
+}

package/android/src/paper/java/com/facebook/react/viewmanagers/CellContainerManagerInterface.java

@@ -0,0 +1,16 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaInterface.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+
+public interface CellContainerManagerInterface<T extends View> {
+  void setIndex(T view, int value);
+}

package/android/src/test/java/com/shopify/reactnative/flash_list/AutoLayoutShadowTest.kt

@@ -0,0 +1,147 @@
+package com.shopify.reactnative.flash_list
+
+import com.google.gson.Gson
+import com.shopify.reactnative.flash_list.models.Rect
+import com.shopify.reactnative.flash_list.models.TestDataModel
+import org.junit.Assert.assertEquals
+import org.junit.Test
+
+internal class AutoLayoutShadowTest {
+    private val gson = Gson()
+
+    /**
+     * Test against expected output from stored JSON */
+    @Test
+    fun clearGapsAndOverlapsVerticalList() {
+        val alShadow = getAutolayoutShadow(0)
+        val testModel = getTestModel()
+        testModel.vertical.forEachIndexed { index, it ->
+            alShadow.clearGapsAndOverlaps(it.input as Array<CellContainer>)
+            assertEquals("Index: $index", gson.toJson(it.expectedOutput), gson.toJson(it.input))
+        }
+    }
+
+    /**
+     * Test against expected output from stored JSON */
+    @Test
+    fun clearGapsAndOverlapsHorizontalList() {
+        val alShadow = getAutolayoutShadow(0)
+        alShadow.horizontal = true
+        val testModel = getTestModel()
+        testModel.horizontal.forEachIndexed { index, it ->
+            alShadow.clearGapsAndOverlaps(it.input as Array<CellContainer>)
+            assertEquals("Index: $index", gson.toJson(it.expectedOutput), gson.toJson(it.input))
+        }
+    }
+
+    /**
+     * Test against expected output from stored JSON */
+    @Test
+    fun clearGapsAndOverlapsWindowSize() {
+        val alShadow = getAutolayoutShadow(0)
+        alShadow.horizontal = true
+        alShadow.windowSize = 90
+        val testModel = getTestModel()
+        testModel.window.forEachIndexed { index, it ->
+            alShadow.clearGapsAndOverlaps(it.input as Array<CellContainer>)
+            assertEquals("Index: $index", gson.toJson(it.expectedOutput), gson.toJson(it.input))
+        }
+    }
+
+    /**
+     * Should only correct items in the visible window*/
+    @Test
+    fun clearGapsAndOverlapsBoundaryTest() {
+        val alShadow = getAutolayoutShadow(300)
+        alShadow.renderOffset = 100
+
+        //--------- Vertical -----------
+        //Item above visible window
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(120, 0, 100, 100, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(120, it[1].left)
+        }
+
+        //Item below visible window
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(120, 850, 100, 950, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(850, it[1].top)
+        }
+
+        //Item within visible window
+        arrayOf<CellContainer>(getRect(0, 250, 100, 100, 0), getRect(120, 250, 100, 100, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(100, it[1].left)
+        }
+
+        //At the top edge
+        arrayOf<CellContainer>(getRect(0, 200, 100, 100, 0), getRect(120, 200, 100, 100, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(100, it[1].left)
+        }
+
+        //--------- Horizontal -----------
+
+        alShadow.horizontal = true
+
+        //Item left of visible window
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(0, 120, 100, 100, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(120, it[1].top)
+        }
+
+        //Item right of visible window
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(850, 120, 950, 220, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(120, it[1].top)
+        }
+
+        //Item within visible window
+        arrayOf<CellContainer>(getRect(250, 0, 100, 100, 0), getRect(250, 120, 100, 100, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(100, it[1].top)
+        }
+
+        //At the left edge
+        arrayOf<CellContainer>(getRect(200, 0, 100, 100, 0), getRect(250, 150, 100, 100, 1)).let {
+            alShadow.clearGapsAndOverlaps(it)
+            assertEquals(100, it[1].top)
+        }
+    }
+
+    @Test
+    fun checkBlankForLastItem() {
+        val alShadow = getAutolayoutShadow(0)
+        val testModel = getTestModel()
+        testModel.vertical.forEachIndexed { index, it ->
+            alShadow.clearGapsAndOverlaps(it.input as Array<CellContainer>)
+            it.expectedOutput.map { value -> value.bottom }.maxOrNull()?.let { max ->
+                alShadow.computeBlankFromGivenOffset(0, 0, 0)
+                assertEquals("Index: $index", alShadow.windowSize - max, alShadow.blankOffsetAtEnd)
+            }
+        }
+    }
+
+    private fun getTestModel(): TestDataModel {
+        var str = this.javaClass.classLoader.getResource("LayoutTestData.json").readText()
+        return gson.fromJson<TestDataModel>(str, TestDataModel::class.java)
+    }
+
+    private fun getRect(l: Int, t: Int, r: Int, b: Int, index: Int): Rect {
+        var rect = Rect(b - t, r - l)
+        rect.left = l
+        rect.right = r
+        rect.bottom = b
+        rect.top = t
+        rect.index = index
+        return rect
+    }
+
+    private fun getAutolayoutShadow(offset: Int): AutoLayoutShadow {
+        val alShadow = AutoLayoutShadow()
+        alShadow.windowSize = 500
+        alShadow.renderOffset = 0
+        alShadow.scrollOffset = offset
+        return alShadow
+    }
+}

package/android/src/test/java/com/shopify/reactnative/flash_list/models/Rect.kt

@@ -0,0 +1,61 @@
+package com.shopify.reactnative.flash_list.models
+
+import com.shopify.reactnative.flash_list.CellContainer
+
+class Rect (h: Int? = 0, w: Int? = 0): CellContainer {
+    private var left = 0
+    private var right = 0
+    private var top = 0
+    private var bottom = 0
+    private var height = 0
+    private var width = 0
+    private var index = 0
+
+    override fun setIndex(value: Int) {
+        index = value
+    }
+
+    override fun getIndex(): Int {
+        return index
+    }
+
+    override fun setLeft(value: Int) {
+        left = value
+    }
+
+    override fun getLeft(): Int {
+        return left
+    }
+
+    override fun setTop(value: Int) {
+        top = value
+    }
+
+    override fun getTop(): Int {
+        return top
+    }
+
+    override fun setRight(value: Int) {
+        right = value
+    }
+
+    override fun getRight(): Int {
+        return right
+    }
+
+    override fun setBottom(value: Int) {
+        bottom = value
+    }
+
+    override fun getBottom(): Int {
+        return bottom
+    }
+
+    override fun getHeight(): Int {
+        return height
+    }
+
+    override fun getWidth(): Int {
+        return width
+    }
+}

package/android/src/test/java/com/shopify/reactnative/flash_list/models/TestCollection.kt

@@ -0,0 +1,6 @@
+package com.shopify.reactnative.flash_list.models
+
+class TestCollection {
+    lateinit var input: Array<Rect>
+    lateinit var expectedOutput: Array<Rect>
+}

package/android/src/test/java/com/shopify/reactnative/flash_list/models/TestDataModel.kt

@@ -0,0 +1,8 @@
+package com.shopify.reactnative.flash_list.models
+
+
+class TestDataModel {
+    lateinit var vertical: Array<TestCollection>
+    lateinit var horizontal: Array<TestCollection>
+    lateinit var window: Array<TestCollection>
+}