@shopify/flash-list 1.4.2 → 1.4.3

package/CHANGELOG.md

@@ -7,6 +7,18 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+- Fix definition conflicts with previous value
+  - https://github.com/Shopify/flash-list/pull/795
+- Fix Android unit test
+  - https://github.com/Shopify/flash-list/pull/815
+- Fix performance issues with inverted lists on Android
+  - https://github.com/Shopify/flash-list/pull/819
+
+## [1.4.2] - 2023-03-20
+
+- Apply layout correction only to consecutive cells
+  - https://github.com/Shopify/flash-list/pull/788
+
 ## [1.4.1] - 2023-01-24
 
 - Prevent overflow of sticky headers

package/android/src/test/java/com/shopify/reactnative/flash_list/AutoLayoutShadowTest.kt

@@ -57,25 +57,25 @@ internal class AutoLayoutShadowTest {
 
         //--------- Vertical -----------
         //Item above visible window
-        arrayOf<CellContainer>(getRect(0, 0, 100, 100), getRect(120, 0, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(120, 0, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(120, it[1].left)
         }
 
         //Item below visible window
-        arrayOf<CellContainer>(getRect(0, 0, 100, 100), getRect(120, 550, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(120, 550, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(550, it[1].top)
         }
 
         //Item within visible window
-        arrayOf<CellContainer>(getRect(0, 250, 100, 100), getRect(120, 250, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(0, 250, 100, 100, 0), getRect(120, 250, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(100, it[1].left)
         }
 
         //At the top edge
-        arrayOf<CellContainer>(getRect(0, 200, 100, 100), getRect(120, 200, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(0, 200, 100, 100, 0), getRect(120, 200, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(100, it[1].left)
         }
@@ -85,25 +85,25 @@ internal class AutoLayoutShadowTest {
         alShadow.horizontal = true
 
         //Item left of visible window
-        arrayOf<CellContainer>(getRect(0, 0, 100, 100), getRect(0, 120, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(0, 120, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(120, it[1].top)
         }
 
         //Item right of visible window
-        arrayOf<CellContainer>(getRect(0, 0, 100, 100), getRect(550, 120, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(0, 0, 100, 100, 0), getRect(550, 120, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(120, it[1].top)
         }
 
         //Item within visible window
-        arrayOf<CellContainer>(getRect(250, 0, 100, 100), getRect(250, 120, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(250, 0, 100, 100, 0), getRect(250, 120, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(100, it[1].top)
         }
 
         //At the left edge
-        arrayOf<CellContainer>(getRect(200, 0, 100, 100), getRect(250, 150, 100, 100)).let {
+        arrayOf<CellContainer>(getRect(200, 0, 100, 100, 0), getRect(250, 150, 100, 100, 1)).let {
             alShadow.clearGapsAndOverlaps(it)
             assertEquals(100, it[1].top)
         }
@@ -127,12 +127,13 @@ internal class AutoLayoutShadowTest {
         return gson.fromJson<TestDataModel>(str, TestDataModel::class.java)
     }
 
-    private fun getRect(l: Int, t: Int, r: Int, b: Int): Rect {
+    private fun getRect(l: Int, t: Int, r: Int, b: Int, index: Int): Rect {
         var rect = Rect(b - t, r - l)
         rect.left = l
         rect.right = r
         rect.bottom = b
         rect.top = t
+        rect.index = index
         return rect
     }
 

package/android/src/test/java/com/shopify/reactnative/flash_list/models/Rect.kt

@@ -9,12 +9,14 @@ class Rect (h: Int? = 0, w: Int? = 0): CellContainer {
     private var bottom = 0
     private var height = 0
     private var width = 0
+    private var index = 0
 
     override fun setIndex(value: Int) {
+        index = value
     }
 
     override fun getIndex(): Int {
-        return 0
+        return index
     }
 
     override fun setLeft(value: Int) {