@shopify/cli 3.59.2 → 3.60.0

package/dist/assets/cli-ruby/lib/project_types/extension/models/specification_handlers/theme_app_extension.rb

@@ -16,7 +16,7 @@ module Extension
         SUPPORTED_BUCKETS = %w(assets blocks snippets locales)
         BUNDLE_SIZE_LIMIT = 10 * 1024 * 1024 # 10MB
         LIQUID_SIZE_LIMIT = 100 * 1024 # 100kb
-        SUPPORTED_ASSET_EXTS = %w(.jpg .jpeg .js .css .png .svg)
+        SUPPORTED_ASSET_EXTS = %w(.jpg .jpeg .js .json .css .png .svg)
         SUPPORTED_LOCALE_EXTS = %w(.json)
 
         def create(directory_name, context, getting_started: false)

package/dist/assets/cli-ruby/lib/shopify_cli/theme/dev_server/proxy.rb

@@ -200,7 +200,7 @@ module ShopifyCLI
             +""
           end
 
-          expected_session_cookie = "#{SESSION_COOKIE_NAME}=#{secure_session_id}"
+          expected_session_cookie = "#{SESSION_COOKIE_NAME}=#{secure_session_id};"
 
           unless cookie_header.include?(expected_session_cookie)
             if cookie_header.include?(SESSION_COOKIE_NAME)

package/dist/assets/cli-ruby/lib/shopify_cli/theme/extension/syncer/extension_serve_job.rb

@@ -43,24 +43,7 @@ module ShopifyCLI
 
             job_in_progress!
 
-            input = {
-              api_key: @project.app.api_key,
-              registration_id: @project.registration_id,
-              config: JSON.generate(@specification_handler.config(@ctx)),
-              extension_context: @specification_handler.extension_context(@ctx),
-            }
-            response = ShopifyCLI::PartnersAPI.query(@ctx, "extension_update_draft", **input).dig(*RESPONSE_FIELD)
-            user_errors = response.dig(USER_ERRORS_FIELD)
-
-            if user_errors
-              @ctx.puts(error_message(@project.title))
-              error_files = erroneous_files(user_errors)
-              print_items(error_files)
-            else
-              @ctx.puts(success_message(@project.title))
-              print_items({}.freeze)
-              ::Extension::Tasks::Converters::VersionConverter.from_hash(@ctx, response.dig(VERSION_FIELD))
-            end
+            print_items({}.freeze)
 
             files = @syncer.pending_files.map(&:relative_path)
             # Notify changes after the sync is complete

package/dist/assets/cli-ruby/lib/shopify_cli/theme/repl/auth_middleware.rb

@@ -17,7 +17,7 @@ module ShopifyCLI
           @env = env
           @env["PATH_INFO"] = PASSWORD_PAGE_PATH if redirect_to_password?(@env)
 
-          return @app.call(@env) if password_page?(@env) || (storefront_session.nil? || secure_session.nil?)
+          return @app.call(@env) if password_page?(@env) || secure_session.nil?
 
           authenticate!
 

package/dist/assets/cli-ruby/test/shopify-cli/theme/dev_server/proxy_test.rb

@@ -10,7 +10,7 @@ module ShopifyCLI
   module Theme
     class DevServer
       class ProxyTest < Minitest::Test
-        SECURE_SESSION_ID = "deadbeef"
+        SECURE_SESSION_ID = ":deadbeef:"
 
         def setup
           super
@@ -110,7 +110,7 @@ module ShopifyCLI
             .with(
               headers: {
                 "Content-Length" => "0",
-                "Cookie" => "_shopify_essential=deadbeef",
+                "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID};",
                 "X-Shopify-Shop" => store,
               },
             )
@@ -169,7 +169,7 @@ module ShopifyCLI
           stub_request(:post, "https://dev-theme-server-store.myshopify.com/account/login?_fd=0&pb=0")
             .with(
               headers: {
-                "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID}",
+                "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID};",
               },
             )
             .to_return(
@@ -184,7 +184,7 @@ module ShopifyCLI
           stub_request(:get, "https://dev-theme-server-store.myshopify.com/?_fd=0&pb=0")
             .with(
               headers: {
-                "Cookie" => "_shopify_essential=#{new_shopify_essential}",
+                "Cookie" => "_shopify_essential=#{new_shopify_essential};",
               },
             )
             .to_return(status: 200)
@@ -323,7 +323,7 @@ module ShopifyCLI
           stub_request(:get, "https://dev-theme-server-store.myshopify.com/?_fd=0&pb=0")
             .with(
               headers: {
-                "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID}",
+                "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID};",
               },
             )
 
@@ -336,7 +336,7 @@ module ShopifyCLI
           stub_request(:get, "https://dev-theme-server-store.myshopify.com/?_fd=0&pb=0")
             .with(
               headers: {
-                "Cookie" => "cart_currency=CAD; secure_customer_sig=; _shopify_essential=#{SECURE_SESSION_ID}",
+                "Cookie" => "cart_currency=CAD; secure_customer_sig=; _shopify_essential=#{SECURE_SESSION_ID};",
               },
             )
 
@@ -345,6 +345,19 @@ module ShopifyCLI
             "HTTP_COOKIE" => "cart_currency=CAD; secure_customer_sig=")
         end
 
+        def test_shopify_essential_cookie_in_the_middle_of_the_cookie_string
+          stub_request(:get, "https://dev-theme-server-store.myshopify.com/?_fd=0&pb=0")
+            .with(
+              headers: {
+                "Cookie" => "cart_currency=CAD; _shopify_essential=#{SECURE_SESSION_ID}; secure_customer_sig=",
+              },
+            )
+
+          stub_session_id_request
+          request.get("/",
+            "HTTP_COOKIE" => "cart_currency=CAD; _shopify_essential=:expired:; secure_customer_sig=")
+        end
+
         def test_pass_pending_templates_to_storefront
           ShopifyCLI::DB
             .stubs(:get)
@@ -373,7 +386,7 @@ module ShopifyCLI
                 "Accept-Encoding" => "none",
                 "Authorization" => "Bearer TOKEN",
                 "Content-Type" => "application/x-www-form-urlencoded",
-                "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID}",
+                "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID};",
                 "Host" => "dev-theme-server-store.myshopify.com",
                 "X-Forwarded-For" => "",
                 "User-Agent" => "Shopify CLI",
@@ -597,7 +610,7 @@ module ShopifyCLI
         def default_proxy_headers(domain = "myshopify.com")
           {
             "Accept-Encoding" => "none",
-            "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID}",
+            "Cookie" => "_shopify_essential=#{SECURE_SESSION_ID};",
             "Host" => "dev-theme-server-store.#{domain}",
             "X-Forwarded-For" => "",
             "User-Agent" => "Shopify CLI",

package/dist/{chokidar-DGBVSVUZ.js → chokidar-DOC6OXDL.js}

@@ -1,17 +1,17 @@
 import {
   require_normalize_path
-} from "./chunk-7ZP3BQHT.js";
+} from "./chunk-3MBQVTEX.js";
 import {
   require_braces,
   require_glob_parent,
   require_is_glob,
   require_picomatch
-} from "./chunk-CYG4QPQ3.js";
+} from "./chunk-RQ24VTW4.js";
 import {
   __commonJS,
   __require,
   init_cjs_shims
-} from "./chunk-BVGYIZ3O.js";
+} from "./chunk-M63RTPGR.js";
 
 // ../../node_modules/.pnpm/readdirp@3.6.0/node_modules/readdirp/index.js
 var require_readdirp = __commonJS({