@shopgate/pwa-common-commerce 7.30.0 → 7.30.1-beta.1

package/cart/reducers/couponField.js

@@ -11,8 +11,7 @@ const defaultState = {
  * @param {Object} action The redux action.
  * @returns {Object}
  */
-export default (state = defaultState, action) => {
-  /* eslint-disable no-param-reassign */
+export default (state = defaultState, action = {}) => {
   const producer = produce(draft => {
     switch (action.type) {
       case SET_COUPON_FIELD_VALUE:
@@ -29,6 +28,5 @@ export default (state = defaultState, action) => {
         break;
     }
   });
-  /* eslint-enable no-param-reassign */
   return producer(state);
 };

package/cart/reducers/data.js

@@ -16,7 +16,7 @@ const defaultState = {
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default (state = defaultState, action) => {
+export default (state = defaultState, action = {}) => {
   switch (action.type) {
     case ADD_PRODUCTS_TO_CART:
     case ERROR_ADD_PRODUCTS_TO_CART:

package/category/reducers/categoriesById.js

@@ -8,7 +8,7 @@ import handleCategoryCollection from "./helpers/handleCategoryCollection";
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-const categoriesById = (state = {}, action) => {
+const categoriesById = (state = {}, action = {}) => {
   switch (action.type) {
     case REQUEST_CATEGORY:
       return {

package/category/reducers/childrenByCategoryId.js

@@ -7,7 +7,7 @@ import { CATEGORY_LIFETIME, REQUEST_CATEGORY, RECEIVE_CATEGORY, REQUEST_CATEGORY
  * @param {Object} action The action object.
  * @returns {Object} The new state.
  */
-const childrenByCategoryId = (state = {}, action) => {
+const childrenByCategoryId = (state = {}, action = {}) => {
   switch (action.type) {
     case REQUEST_CATEGORY:
     case REQUEST_CATEGORY_CHILDREN:

package/category/reducers/rootCategories.js

@@ -8,7 +8,7 @@ import handleReceivedCategories from "./helpers/handleReceivedCategories";
  * @param {Object} action The action object.
  * @return {Object} The store data.
  */
-const rootCategories = (state = {}, action) => {
+const rootCategories = (state = {}, action = {}) => {
   switch (action.type) {
     case REQUEST_ROOT_CATEGORIES:
       return {

package/favorites/reducers/lists.js

@@ -1,5 +1,5 @@
 import { produce } from 'immer';
-import { RECEIVE_FAVORITES_LISTS, SUCCESS_ADD_FAVORITES_LIST, SUCCESS_UPDATE_FAVORITES_LIST, SUCCESS_REMOVE_FAVORITES_LIST, OPEN_FAVORITE_LIST_CHOOSER, CLOSE_FAVORITE_LIST_CHOOSER, FAVORITES_LIFETIME, OPEN_FAVORITE_COMMENT_DIALOG, CLOSE_FAVORITE_COMMENT_DIALOG } from "../constants";
+import { CLOSE_FAVORITE_COMMENT_DIALOG, CLOSE_FAVORITE_LIST_CHOOSER, FAVORITES_LIFETIME, OPEN_FAVORITE_COMMENT_DIALOG, OPEN_FAVORITE_LIST_CHOOSER, RECEIVE_FAVORITES_LISTS, SUCCESS_ADD_FAVORITES_LIST, SUCCESS_REMOVE_FAVORITES_LIST, SUCCESS_UPDATE_FAVORITES_LIST } from "../constants";
 
 /**
  * Favorites lists reducer.
@@ -12,67 +12,62 @@ const lists = (state = {
   lists: [],
   chooser: null,
   commentDialog: null
-}, action) => {
-  /* eslint-disable no-param-reassign */
-  const newState = produce(state, draft => {
-    switch (action.type) {
-      case OPEN_FAVORITE_LIST_CHOOSER:
-        {
-          draft.chooser = {
-            productId: action.productId,
-            withRelatives: action.withRelatives
-          };
-          break;
-        }
-      case CLOSE_FAVORITE_LIST_CHOOSER:
-        {
-          draft.chooser = null;
-          break;
-        }
-      case OPEN_FAVORITE_COMMENT_DIALOG:
-        {
-          draft.commentDialog = {
-            productId: action.productId,
-            listId: action.listId
-          };
-          break;
-        }
-      case CLOSE_FAVORITE_COMMENT_DIALOG:
-        {
-          draft.commentDialog = null;
-          break;
-        }
-      case RECEIVE_FAVORITES_LISTS:
-        {
-          draft.expires = Date.now() + FAVORITES_LIFETIME;
-          draft.lists = action.favoritesLists;
-          break;
-        }
-      case SUCCESS_ADD_FAVORITES_LIST:
-        {
-          draft.lists.push({
-            id: action.listId,
-            name: action.name
-          });
-          break;
-        }
-      case SUCCESS_UPDATE_FAVORITES_LIST:
-        {
-          const list = draft.lists.find(l => l.id === action.listId);
-          list.name = action.name;
-          break;
-        }
-      case SUCCESS_REMOVE_FAVORITES_LIST:
-        {
-          const listIndex = draft.lists.findIndex(l => l.id === action.listId);
-          draft.lists.splice(listIndex, 1);
-          break;
-        }
-      default:
+}, action = {}) => produce(state, draft => {
+  switch (action.type) {
+    case OPEN_FAVORITE_LIST_CHOOSER:
+      {
+        draft.chooser = {
+          productId: action.productId,
+          withRelatives: action.withRelatives
+        };
         break;
-    }
-  });
-  /* eslint-enable no-param-reassign */
-  return newState;
-};
+      }
+    case CLOSE_FAVORITE_LIST_CHOOSER:
+      {
+        draft.chooser = null;
+        break;
+      }
+    case OPEN_FAVORITE_COMMENT_DIALOG:
+      {
+        draft.commentDialog = {
+          productId: action.productId,
+          listId: action.listId
+        };
+        break;
+      }
+    case CLOSE_FAVORITE_COMMENT_DIALOG:
+      {
+        draft.commentDialog = null;
+        break;
+      }
+    case RECEIVE_FAVORITES_LISTS:
+      {
+        draft.expires = Date.now() + FAVORITES_LIFETIME;
+        draft.lists = action.favoritesLists;
+        break;
+      }
+    case SUCCESS_ADD_FAVORITES_LIST:
+      {
+        draft.lists.push({
+          id: action.listId,
+          name: action.name
+        });
+        break;
+      }
+    case SUCCESS_UPDATE_FAVORITES_LIST:
+      {
+        const list = draft.lists.find(l => l.id === action.listId);
+        list.name = action.name;
+        break;
+      }
+    case SUCCESS_REMOVE_FAVORITES_LIST:
+      {
+        const listIndex = draft.lists.findIndex(l => l.id === action.listId);
+        draft.lists.splice(listIndex, 1);
+        break;
+      }
+    default:
+      break;
+  }
+});
 export default lists;

package/favorites/reducers/products.js

@@ -1,7 +1,7 @@
 import { produce } from 'immer';
 import isNumber from 'lodash/isNumber';
 import isString from 'lodash/isString';
-import { REQUEST_ADD_FAVORITES, SUCCESS_ADD_FAVORITES, CANCEL_REQUEST_SYNC_FAVORITES, ERROR_ADD_FAVORITES, REQUEST_REMOVE_FAVORITES, SUCCESS_REMOVE_FAVORITES, ERROR_REMOVE_FAVORITES, REQUEST_FAVORITES, ERROR_FETCH_FAVORITES, SUCCESS_REMOVE_FAVORITES_LIST, SUCCESS_ADD_FAVORITES_LIST, RECEIVE_FAVORITES, FAVORITES_LIFETIME, SUCCESS_UPDATE_FAVORITES, REQUEST_UPDATE_FAVORITES, ERROR_UPDATE_FAVORITES, RECEIVE_FAVORITES_LISTS } from "../constants";
+import { CANCEL_REQUEST_SYNC_FAVORITES, ERROR_ADD_FAVORITES, ERROR_FETCH_FAVORITES, ERROR_REMOVE_FAVORITES, ERROR_UPDATE_FAVORITES, FAVORITES_LIFETIME, RECEIVE_FAVORITES, RECEIVE_FAVORITES_LISTS, REQUEST_ADD_FAVORITES, REQUEST_FAVORITES, REQUEST_REMOVE_FAVORITES, REQUEST_UPDATE_FAVORITES, SUCCESS_ADD_FAVORITES, SUCCESS_ADD_FAVORITES_LIST, SUCCESS_REMOVE_FAVORITES, SUCCESS_REMOVE_FAVORITES_LIST, SUCCESS_UPDATE_FAVORITES } from "../constants";
 
 /**
  * Favorites reducer.
@@ -11,225 +11,220 @@ import { REQUEST_ADD_FAVORITES, SUCCESS_ADD_FAVORITES, CANCEL_REQUEST_SYNC_FAVOR
  */
 const products = (state = {
   byList: {}
-}, action) => {
-  /* eslint-disable no-param-reassign */
-  const producedState = produce(state, draft => {
-    switch (action.type) {
-      // Handle a new favorites request.
-      case REQUEST_FAVORITES:
-        {
-          const existingList = draft.byList[action.listId];
-          if (!existingList) {
-            draft.byList[action.listId] = {
-              isFetching: true,
-              lastChange: 0,
-              lastFetch: 0,
-              expires: 0,
-              items: [],
-              syncCount: 0
-            };
-            return;
-          }
-          existingList.isFetching = true;
-          existingList.expires = 0;
-          break;
+}, action = {}) => produce(state, draft => {
+  switch (action.type) {
+    // Handle a new favorites request.
+    case REQUEST_FAVORITES:
+      {
+        const existingList = draft.byList[action.listId];
+        if (!existingList) {
+          draft.byList[action.listId] = {
+            isFetching: true,
+            lastChange: 0,
+            lastFetch: 0,
+            expires: 0,
+            items: [],
+            syncCount: 0
+          };
+          return;
         }
+        existingList.isFetching = true;
+        existingList.expires = 0;
+        break;
+      }
 
-      // Handle incoming favorite products.
-      case RECEIVE_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          const isSynching = list.syncCount > 0;
-          const isOngoing = state.lastChange > action.requestTimestamp;
+    // Handle incoming favorite products.
+    case RECEIVE_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        const isSynching = list.syncCount > 0;
+        const isOngoing = state.lastChange > action.requestTimestamp;
 
-          /**
-           * Note: When favorites are received, an add or remove request can be in progress. In this
-           *       case only fetching state will be updated and the received data will be discarded.
-           *       A new fetch request will be queued as soon as the sync is done, which will recover
-           *       discarded data.
-          */
-          list.isFetching = false;
-          if (list.ready && (isSynching || isOngoing)) {
-            return;
-          }
-          list.expires = Date.now() + FAVORITES_LIFETIME;
-          list.items = action.items.map(({
-            quantity,
-            notes,
-            product
-          }) => ({
-            quantity,
-            notes,
-            productId: product.id
-          }));
-          list.ready = true;
-          // `syncCount` stays untouched because this is not considered to be a sync.
-          break;
+        /**
+         * Note: When favorites are received, an add or remove request can be in progress. In this
+         *       case only fetching state will be updated and the received data will be discarded.
+         *       A new fetch request will be queued as soon as the sync is done, which will recover
+         *       discarded data.
+         */
+        list.isFetching = false;
+        if (list.ready && (isSynching || isOngoing)) {
+          return;
         }
+        list.expires = Date.now() + FAVORITES_LIFETIME;
+        list.items = action.items.map(({
+          quantity,
+          notes,
+          product
+        }) => ({
+          quantity,
+          notes,
+          productId: product.id
+        }));
+        list.ready = true;
+        // `syncCount` stays untouched because this is not considered to be a sync.
+        break;
+      }
 
-      // Handle failed fetching
-      case ERROR_FETCH_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          list.isFetching = false;
-          list.expires = 0;
-          list.ready = true;
-          // `syncCount` stays untouched because this is not considered to be a sync.
-          break;
-        }
+    // Handle failed fetching
+    case ERROR_FETCH_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        list.isFetching = false;
+        list.expires = 0;
+        list.ready = true;
+        // `syncCount` stays untouched because this is not considered to be a sync.
+        break;
+      }
 
-      // Handle adding favorite list products.
-      case REQUEST_ADD_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          const matchingItem = list.items.find(({
-            productId
-          }) => productId === action.productId);
-          if (matchingItem) {
-            matchingItem.notes = typeof action.notes === 'string' ? action.notes : matchingItem.notes;
-            matchingItem.quantity = typeof action.quantity === 'number' ? matchingItem.quantity + action.quantity : matchingItem.quantity + 1;
-          } else {
-            list.items.push({
-              notes: action.notes || '',
-              quantity: action.quantity || 1,
-              productId: action.productId
-            });
-          }
-          list.lastChange = Date.now();
-          list.syncCount += 1;
-          break;
+    // Handle adding favorite list products.
+    case REQUEST_ADD_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        const matchingItem = list.items.find(({
+          productId
+        }) => productId === action.productId);
+        if (matchingItem) {
+          matchingItem.notes = typeof action.notes === 'string' ? action.notes : matchingItem.notes;
+          matchingItem.quantity = typeof action.quantity === 'number' ? matchingItem.quantity + action.quantity : matchingItem.quantity + 1;
+        } else {
+          list.items.push({
+            notes: action.notes || '',
+            quantity: action.quantity || 1,
+            productId: action.productId
+          });
         }
-      case REQUEST_UPDATE_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          const matchingItem = list.items.find(({
-            productId
-          }) => productId === action.productId);
-          if (matchingItem) {
-            if (isNumber(action.quantity)) {
-              matchingItem.quantity = action.quantity;
-            }
-            if (isString(action.notes)) {
-              matchingItem.notes = action.notes;
-            }
-            list.lastChange = Date.now();
-            list.syncCount += 1;
+        list.lastChange = Date.now();
+        list.syncCount += 1;
+        break;
+      }
+    case REQUEST_UPDATE_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        const matchingItem = list.items.find(({
+          productId
+        }) => productId === action.productId);
+        if (matchingItem) {
+          if (isNumber(action.quantity)) {
+            matchingItem.quantity = action.quantity;
           }
-          break;
-        }
-
-      // Handle removing favorite list products.
-      case REQUEST_REMOVE_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          const matchingItemIndex = list.items.findIndex(({
-            productId
-          }) => productId === action.productId);
-          if (matchingItemIndex > -1) {
-            list.items.splice(matchingItemIndex, 1);
+          if (isString(action.notes)) {
+            matchingItem.notes = action.notes;
           }
           list.lastChange = Date.now();
           list.syncCount += 1;
-          break;
-        }
-      // Handle cancellation of synchronization.
-      // Sync count needs to be updated, when an add or a remove favorites action is cancelled
-      // This recovers from invalid sync states when a backend call is detected to be redundant
-      case CANCEL_REQUEST_SYNC_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          list.syncCount -= action.count;
-          break;
         }
+        break;
+      }
 
-      // Handle success of adding favorite list products.
-      case SUCCESS_ADD_FAVORITES:
-      case SUCCESS_UPDATE_FAVORITES:
-      case SUCCESS_REMOVE_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          list.lastChange = Date.now();
-          list.syncCount -= 1;
-          break;
+    // Handle removing favorite list products.
+    case REQUEST_REMOVE_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        const matchingItemIndex = list.items.findIndex(({
+          productId
+        }) => productId === action.productId);
+        if (matchingItemIndex > -1) {
+          list.items.splice(matchingItemIndex, 1);
         }
+        list.lastChange = Date.now();
+        list.syncCount += 1;
+        break;
+      }
+    // Handle cancellation of synchronization.
+    // Sync count needs to be updated, when an add or a remove favorites action is cancelled
+    // This recovers from invalid sync states when a backend call is detected to be redundant
+    case CANCEL_REQUEST_SYNC_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        list.syncCount -= action.count;
+        break;
+      }
 
-      // Handle deletion failure by adding the product back in to the list.
-      case ERROR_REMOVE_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          list.items.push({
-            productId: action.productId,
-            quantity: action.quantity || 1,
-            notes: action.notes || ''
-          });
-          list.lastChange = Date.now();
-          list.syncCount -= 1;
-          break;
-        }
+    // Handle success of adding favorite list products.
+    case SUCCESS_ADD_FAVORITES:
+    case SUCCESS_UPDATE_FAVORITES:
+    case SUCCESS_REMOVE_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        list.lastChange = Date.now();
+        list.syncCount -= 1;
+        break;
+      }
 
-      // Handle adding failure by removing the product from the list.
-      case ERROR_ADD_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          const matchingItemIndex = list.items.findIndex(({
-            productId
-          }) => productId === action.productId);
-          if (matchingItemIndex > -1) {
-            list.items.splice(matchingItemIndex, 1);
-          }
-          list.lastChange = Date.now();
-          list.syncCount -= 1;
-          break;
-        }
-      case ERROR_UPDATE_FAVORITES:
-        {
-          const list = draft.byList[action.listId];
-          list.lastChange = Date.now();
-          list.syncCount -= 1;
-          break;
-        }
+    // Handle deletion failure by adding the product back in to the list.
+    case ERROR_REMOVE_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        list.items.push({
+          productId: action.productId,
+          quantity: action.quantity || 1,
+          notes: action.notes || ''
+        });
+        list.lastChange = Date.now();
+        list.syncCount -= 1;
+        break;
+      }
 
-      // Handle cleanup after deletion of a list.
-      case SUCCESS_REMOVE_FAVORITES_LIST:
-        {
-          delete draft.byList[action.listId];
-          break;
+    // Handle adding failure by removing the product from the list.
+    case ERROR_ADD_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        const matchingItemIndex = list.items.findIndex(({
+          productId
+        }) => productId === action.productId);
+        if (matchingItemIndex > -1) {
+          list.items.splice(matchingItemIndex, 1);
         }
+        list.lastChange = Date.now();
+        list.syncCount -= 1;
+        break;
+      }
+    case ERROR_UPDATE_FAVORITES:
+      {
+        const list = draft.byList[action.listId];
+        list.lastChange = Date.now();
+        list.syncCount -= 1;
+        break;
+      }
 
-      // Handle adding new lists.
-      case SUCCESS_ADD_FAVORITES_LIST:
-        {
-          draft.byList[action.listId] = {
-            isFetching: true,
-            lastChange: 0,
-            lastFetch: 0,
-            expires: 0,
-            items: [],
-            syncCount: 0,
-            ready: true
-          };
-          break;
-        }
+    // Handle cleanup after deletion of a list.
+    case SUCCESS_REMOVE_FAVORITES_LIST:
+      {
+        delete draft.byList[action.listId];
+        break;
+      }
 
-      // Handle cleanup after lists are updated
-      case RECEIVE_FAVORITES_LISTS:
-        {
-          const listIds = action.favoritesLists.map(({
-            id
-          }) => id);
-          Object.keys(draft.byList).forEach(id => {
-            if (!listIds.includes(id)) {
-              // Remove list items that don't have a list anymore
-              delete draft.byList[id];
-            }
-          });
-          break;
-        }
-      default:
+    // Handle adding new lists.
+    case SUCCESS_ADD_FAVORITES_LIST:
+      {
+        draft.byList[action.listId] = {
+          isFetching: true,
+          lastChange: 0,
+          lastFetch: 0,
+          expires: 0,
+          items: [],
+          syncCount: 0,
+          ready: true
+        };
+        break;
+      }
+
+    // Handle cleanup after lists are updated
+    case RECEIVE_FAVORITES_LISTS:
+      {
+        const listIds = action.favoritesLists.map(({
+          id
+        }) => id);
+        Object.keys(draft.byList).forEach(id => {
+          if (!listIds.includes(id)) {
+            // Remove list items that don't have a list anymore
+            delete draft.byList[id];
+          }
+        });
         break;
-    }
-  });
-  /* eslint-enable no-param-reassign */
-  return producedState;
-};
+      }
+    default:
+      break;
+  }
+});
 export default products;

package/favorites/selectors/index.js

@@ -3,8 +3,7 @@ import { createSelector } from 'reselect';
 import uniq from 'lodash/uniq';
 import appConfig from '@shopgate/pwa-common/helpers/config';
 import { hasNewServices } from '@shopgate/engage/core/helpers';
-import { getProducts, getProductId } from "../../product/selectors/product";
-import { getKnownRelatives } from "../../product/selectors/variants";
+import { getProducts, getProductId, getKnownRelatives } from "../../product";
 const defaultIds = [];
 
 /**

package/filter/reducers/resultsByHash.js

@@ -8,7 +8,7 @@ import enrichFilters from "./helpers/enrichFilters";
  * @param {Object} action The current redux action.
  * @return {Object} The new state.
  */
-export default function resultsByHash(state = {}, action) {
+export default function resultsByHash(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_FILTERS:
       {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shopgate/pwa-common-commerce",
-  "version": "7.30.0",
+  "version": "7.30.1-beta.1",
   "description": "Commerce library for the Shopgate Connect PWA.",
   "license": "Apache-2.0",
   "author": "Shopgate <support@shopgate.com>",
@@ -19,9 +19,9 @@
     "reselect": "^4.1.8"
   },
   "devDependencies": {
-    "@shopgate/pwa-common": "7.30.0",
-    "@shopgate/pwa-core": "7.30.0",
-    "lodash": "^4.17.4",
+    "@shopgate/pwa-common": "7.30.1-beta.1",
+    "@shopgate/pwa-core": "7.30.1-beta.1",
+    "lodash": "^4.17.23",
     "react": "^17.0.2",
     "react-dom": "^17.0.2"
   }

package/product/actions/fetchProductsById.d.ts

@@ -1,6 +1,4 @@
-// fetchProductsById.d.ts
-
-import { ThunkAction } from 'redux-thunk';
+import type { ThunkAction } from 'redux-thunk';
 import { AnyAction } from 'redux';
 
 export interface FetchProductsResult {

package/product/reducers/descriptionsByProductId.js

@@ -7,7 +7,7 @@ import { PRODUCT_LIFETIME, REQUEST_PRODUCT_DESCRIPTION, RECEIVE_PRODUCT_DESCRIPT
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function descriptionsByProductId(state = {}, action) {
+export default function descriptionsByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_DESCRIPTION:
       return {

package/product/reducers/imagesByProductId.js

@@ -7,7 +7,7 @@ import { PRODUCT_LIFETIME, REQUEST_PRODUCT_IMAGES, RECEIVE_PRODUCT_IMAGES, ERROR
  * @param {Object} action The action object.
  * @returns {Object}
  */
-export default function imagesByProductId(state = {}, action) {
+export default function imagesByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_IMAGES:
       return {

package/product/reducers/mediaByProductId.js

@@ -7,7 +7,7 @@ import { PRODUCT_LIFETIME, REQUEST_PRODUCT_MEDIA, RECEIVE_PRODUCT_MEDIA, ERROR_P
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function mediaByProductId(state = {}, action) {
+export default function mediaByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_MEDIA:
       return {

package/product/reducers/optionsByProductId.js

@@ -7,7 +7,7 @@ import formatOptions from "./helpers/formatOptions";
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function optionsByProductId(state = {}, action) {
+export default function optionsByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_OPTIONS:
       return {

package/product/reducers/productRelationsByHash.js

@@ -6,7 +6,7 @@ import { REQUEST_PRODUCT_RELATIONS, RECEIVE_PRODUCT_RELATIONS, ERROR_PRODUCT_REL
  * @param {Object} action Action.
  * @returns {Object}
  */
-const productRelationsByHash = (state = {}, action) => {
+const productRelationsByHash = (state = {}, action = {}) => {
   switch (action.type) {
     case REQUEST_PRODUCT_RELATIONS:
       return {

package/product/reducers/productsById.js

@@ -9,7 +9,7 @@ import handleProductCollection from "./helpers/handleProductCollection";
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function productsById(state = {}, action) {
+export default function productsById(state = {}, action = {}) {
   switch (action.type) {
     case RECEIVE_PRODUCTS:
       return {

package/product/reducers/propertiesByProductId.js

@@ -7,7 +7,7 @@ import { PRODUCT_LIFETIME, REQUEST_PRODUCT_PROPERTIES, RECEIVE_PRODUCT_PROPERTIE
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function propertiesByProductId(state = {}, action) {
+export default function propertiesByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_PROPERTIES:
       return {

package/product/reducers/resultsByHash.js

@@ -11,7 +11,7 @@ import { PRODUCT_LIFETIME, REQUEST_PRODUCTS, RECEIVE_PRODUCTS, ERROR_PRODUCTS, E
  * @param {Object} action The current redux action.
  * @return {Object} The new state.
  */
-export default function resultsByHash(state = {}, action) {
+export default function resultsByHash(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCTS:
       return {

package/product/reducers/shippingByProductId.js

@@ -6,7 +6,7 @@ import { PRODUCT_LIFETIME, REQUEST_PRODUCT_SHIPPING, RECEIVE_PRODUCT_SHIPPING, E
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function shippingByProductId(state = {}, action) {
+export default function shippingByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_SHIPPING:
       return {

package/product/reducers/variantsByProductId.js

@@ -7,7 +7,7 @@ import { PRODUCT_LIFETIME, REQUEST_PRODUCT_VARIANTS, RECEIVE_PRODUCT_VARIANTS, E
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function variantsByProductId(state = {}, action) {
+export default function variantsByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_VARIANTS:
       return {

package/product/selectors/product.js

@@ -11,13 +11,18 @@ import { getIsLocationBasedShopping } from '@shopgate/engage/core/selectors/merc
 import { getActiveFilters } from "../../filter/selectors";
 import { filterProperties } from "../helpers";
 
+/**
+ * Shared empty product state to keep the fallback referentially stable.
+ */
+const EMPTY_PRODUCT_STATE = {};
+
 /**
  * Retrieves the product state from the store.
  * @deprecated Also exists within @shopgate/engage/product/selectors/product
  * @param {Object} state The current application state.
  * @return {Object} The product state.
  */
-export const getProductState = state => state.product || {};
+export const getProductState = state => state.product || EMPTY_PRODUCT_STATE;
 
 /**
  * Selects all products from the store.

package/reviews/reducers/reviewsByHash.js

@@ -7,7 +7,7 @@ import { REVIEWS_LIFETIME, REQUEST_REVIEWS, RECEIVE_REVIEWS, ERROR_REVIEWS } fro
  * @param {Object} action The current redux action.
  * @return {Object} The new state.
  */
-function reviewsByHash(state = {}, action) {
+function reviewsByHash(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_REVIEWS:
       return {

package/reviews/reducers/reviewsById.js

@@ -7,7 +7,7 @@ import { RECEIVE_PRODUCT_REVIEWS, RECEIVE_REVIEWS, RECEIVE_USER_REVIEW, RECEIVE_
  * @param {Object} action The current redux action.
  * @return {Object} The new state.
  */
-function reviewsById(state = {}, action) {
+function reviewsById(state = {}, action = {}) {
   switch (action.type) {
     case RECEIVE_PRODUCT_REVIEWS:
     case RECEIVE_REVIEWS:

package/reviews/reducers/reviewsByProductId.js

@@ -6,7 +6,7 @@ import { REQUEST_PRODUCT_REVIEWS, RECEIVE_PRODUCT_REVIEWS, ERROR_PRODUCT_REVIEWS
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function reviewsByProductId(state = {}, action) {
+export default function reviewsByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_PRODUCT_REVIEWS:
       return {

package/reviews/reducers/userReviewsByProductId.js

@@ -6,7 +6,7 @@ import { REQUEST_USER_REVIEW, REQUEST_SUBMIT_REVIEW, RECEIVE_USER_REVIEW, RECEIV
  * @param {Object} action The action object.
  * @return {Object} The new state.
  */
-export default function userReviewsByProductId(state = {}, action) {
+export default function userReviewsByProductId(state = {}, action = {}) {
   switch (action.type) {
     case REQUEST_USER_REVIEW:
       return {

package/search/reducers/index.js

@@ -9,7 +9,7 @@ const initialState = {
  * @param {Object} action The action object.
  * @return {Object} The updated search suggestions data.
  */
-const search = (state = initialState, action) => {
+const search = (state = initialState, action = {}) => {
   switch (action.type) {
     case REQUEST_SEARCH_SUGGESTIONS:
       return {