@shop-os/modelkit 0.7.1 → 0.7.3

package/CHANGELOG.md

@@ -9,6 +9,33 @@ header in the release PR.
 
 ## [Unreleased]
 
+## [0.7.3] - Unreleased
+
+ENG-3272 Luma code review follow-ups.
+
+### Changed
+- `ray-3.2` (generate) returns the output as `{ url, expiresAt }` instead of downloading it: its 5 s bill needs no bytes. Luma's URL lasts 1 hour; `expiresAt` is 55 minutes after the result. Edit and reframe still download the MP4 to read its length, and that download is now retried.
+- A URL source for edit or reframe sends `media_type` from its extension (`.mov` is `video/quicktime`, `.webm` is `video/webm`), else `video/mp4`.
+- Luma receives the `providerModelId` lowercased, the same spelling the row checks accept.
+
+### Fixed
+- An edit or reframe whose MP4 length cannot be read bills the caller's measured `durationSeconds` for an inline (`bytes`) source too, not only for a URL source. Before, it billed 5 s.
+- The MP4 length reader reads boxes with a 64-bit size or a size of 0 (box to end of file), so a `moov` after a large `mdat` is found.
+- A completed video takes only an output typed `video` (or untyped); an output of another type is no longer downloaded as the video.
+- `result({ signal })` also cancels the poll requests and the download, not only the wait between polls.
+- A 200 response that is not JSON is a `ModelKitError`: on submit `provider_rejected`, on a poll a transient `network` error that keeps polling.
+
+## [0.7.2] - Unreleased
+
+ENG-3272 review fixes. Merged as a second 0.7.1 after FlashVSR's 0.7.1 had published, so npm never got it; released as 0.7.2.
+
+### Added
+- `takesTargetAspectRatio(row)` (both entries): a row that requires a source video and lists ratios without `"adaptive"` renders the source into the ratio it is given (Ray 3.2 Reframe). Consumers send a ratio to an edit only for these rows; every other edit keeps the source's framing (H3 Max Relight lists `"adaptive"`, so it stays out).
+- `lumaReframeTooTall(req)`: a 9:16 or 3:4 target at 1080p, which Luma renders at 720p.
+
+### Changed
+- `resolveVideoOptions` on a luma reframe row refuses (`error`) or replaces with the row default (`coerce`) an `"adaptive"` or missing target ratio, and refuses or lowers a vertical 1080p target to 720p. The rule runs where quotes read the request, so a hold is never taken at a rate the render will not use; the adapter keeps the same check as a backstop.
+
 ## [0.7.1] - Unreleased
 
 ### Changed

package/dist/catalog.cjs

@@ -49,6 +49,7 @@ __export(catalog_entry_exports, {
   isModelKitError: () => isModelKitError,
   liveCatalog: () => liveCatalog,
   liveState: () => liveState,
+  lumaReframeTooTall: () => lumaReframeTooTall,
   model3dConstraints: () => model3dConstraints,
   model3dInputRefusal: () => model3dInputRefusal,
   model3dPricingSku: () => model3dPricingSku,
@@ -74,6 +75,7 @@ __export(catalog_entry_exports, {
   resolveVideoOptions: () => resolveVideoOptions,
   resolveVoiceChangeOptions: () => resolveVoiceChangeOptions,
   sortCatalogRows: () => sortCatalogRows,
+  takesTargetAspectRatio: () => takesTargetAspectRatio,
   videoLengthViolation: () => videoLengthViolation,
   videoToolConstraints: () => videoToolConstraints
 });
@@ -6420,6 +6422,57 @@ function applyXaiVideoRules(model, req, onUnsupported, warnings) {
   });
   req.resolution = XAI_REFERENCE_MAX_RESOLUTION;
 }
+function takesTargetAspectRatio(model) {
+  const ratios = model.constraints.aspectRatios ?? [];
+  return (model.constraints.requires ?? []).includes("sourceVideo") && ratios.length > 0 && !ratios.includes("adaptive");
+}
+var LUMA_REFRAME_VERTICAL_MAX_RESOLUTION = "720p";
+function lumaReframeTooTall(req) {
+  const vertical = req.aspectRatio === "9:16" || req.aspectRatio === "3:4";
+  return vertical && req.resolution === "1080p";
+}
+function applyLumaVideoRules(model, req, onUnsupported, warnings) {
+  if (model.adapter !== "luma" || !takesTargetAspectRatio(model)) return;
+  if (req.aspectRatio === void 0 || req.aspectRatio === "adaptive") {
+    const listed2 = model.constraints.aspectRatios ?? [];
+    const fallback = model.defaults.aspectRatio !== void 0 && model.defaults.aspectRatio !== "adaptive" ? model.defaults.aspectRatio : listed2[0];
+    const message2 = `${model.id} needs a target aspect ratio: ${listed2.join(", ")}`;
+    if (onUnsupported === "error" || fallback === void 0) {
+      throw new ModelKitError({
+        code: "unsupported_option",
+        message: message2,
+        model: model.id,
+        retryable: false
+      });
+    }
+    warnings.push({
+      code: "ratio_coerced",
+      field: "aspectRatio",
+      from: req.aspectRatio ?? "adaptive",
+      to: fallback,
+      message: message2
+    });
+    req.aspectRatio = fallback;
+  }
+  if (!lumaReframeTooTall(req)) return;
+  const message = `${model.id} renders 9:16 and 3:4 reframes at up to ${LUMA_REFRAME_VERTICAL_MAX_RESOLUTION}`;
+  if (onUnsupported === "error") {
+    throw new ModelKitError({
+      code: "unsupported_option",
+      message,
+      model: model.id,
+      retryable: false
+    });
+  }
+  warnings.push({
+    code: "resolution_coerced",
+    field: "resolution",
+    from: req.resolution,
+    to: LUMA_REFRAME_VERTICAL_MAX_RESOLUTION,
+    message
+  });
+  req.resolution = LUMA_REFRAME_VERTICAL_MAX_RESOLUTION;
+}
 var MINIMAX_H3_INSERT = "minimax/h3-max/insert-video";
 var INSERT_MIN = 1.625;
 var INSERT_MAX = 60;
@@ -9133,6 +9186,7 @@ function resolveVideoOptions(model, request, onUnsupported = "error") {
     delete merged.previousInteractionId;
   }
   applyXaiVideoRules(model, merged, onUnsupported, warnings);
+  applyLumaVideoRules(model, merged, onUnsupported, warnings);
   checkVideoRequired(model, merged);
   applyFalVideoRules(model, merged, request.aspectRatio, warnings);
   return { request: merged, warnings };