@shop-os/modelkit 0.4.4 → 0.4.5

package/CHANGELOG.md

@@ -9,6 +9,11 @@ header in the release PR.
 
 ## [Unreleased]
 
+## [0.4.5] - Unreleased
+
+### Fixed
+- Video length maximums and combined totals forgive ffprobe's container over-read. ffprobe reads a clip a few hundredths over its nominal length (a 10 s clip reads 10.04 s), so a clip at the limit was refused. A length is now over a maximum only when it and its tenth are both over: a source that reads 10.04 s passes Gemini Omni's 10 s cap, one that reads 10.05 s or more is still refused, and a limit that is not a whole tenth (Kling O1's 10.05 s) still takes a clip at it. A combined total adds each clip's tenth, so three 5.04 s references fit a 15 s total. The rule is never stricter than the old raw comparison. It applies to the reference maximum and total and the source maximum in `videoLengthViolation`, and to the source cap in `planVideoTool`. Minimums stay raw: the over-read makes a clip that reads short shorter still, so 3.96 s is still under a 4 s minimum.
+
 ## [0.4.4] - Unreleased
 
 ### Added

package/dist/catalog.cjs

@@ -3324,6 +3324,20 @@ function resetLiveCatalog() {
 
 // src/catalog/video-tools-spec.ts
 var import_zod6 = require("zod");
+
+// src/video-length.ts
+function tenths(seconds2) {
+  return Math.round(seconds2 * 10) / 10;
+}
+function overMax(seconds2, max) {
+  return seconds2 > max && tenths(seconds2) > max;
+}
+function overTotal(lengths, total) {
+  const sum = (values) => values.reduce((acc, len) => acc + len, 0);
+  return sum(lengths) > total && tenths(sum(lengths.map(tenths))) > total;
+}
+
+// src/catalog/video-tools-spec.ts
 var RangeSchema2 = import_zod6.z.object({ min: import_zod6.z.number(), max: import_zod6.z.number() });
 var ToolSchema = import_zod6.z.object({
   kind: import_zod6.z.enum(["upscale", "interpolate", "hdr"]),
@@ -3367,7 +3381,7 @@ function planVideoTool(row, req) {
     return fail("The source video's width, height and duration are required");
   }
   const maxSeconds = row.constraints.sourceVideoSeconds?.max;
-  if (maxSeconds !== void 0 && durationSeconds > maxSeconds) {
+  if (maxSeconds !== void 0 && overMax(durationSeconds, maxSeconds)) {
     return fail(`${row.label} takes source videos up to ${maxSeconds} seconds.`);
   }
   const base = {
@@ -3564,7 +3578,7 @@ function videoLengthViolation(model, input) {
   const lengths = (input.referenceVideos ?? []).map(knownLength);
   if (limits?.max !== void 0) {
     const max = limits.max;
-    const i = lengths.findIndex((len) => len !== void 0 && len > max);
+    const i = lengths.findIndex((len) => len !== void 0 && overMax(len, max));
     if (i >= 0)
       return `${model.label} takes reference videos up to ${String(max)} s each; video ${i + 1} is ${seconds(lengths[i], max)} s.`;
   }
@@ -3576,14 +3590,17 @@ function videoLengthViolation(model, input) {
   const source = knownLength(input.sourceVideo);
   const sourceLimits = model.constraints.sourceVideoSeconds;
   if (limits?.total !== void 0) {
-    const refSum = lengths.reduce((acc, len) => acc + (len ?? 0), 0);
-    const sum = refSum + (sourceLimits?.inReferenceTotal ? source ?? 0 : 0);
-    if (sum > limits.total)
+    const counted = [
+      ...lengths.filter((len) => len !== void 0),
+      ...sourceLimits?.inReferenceTotal && source !== void 0 ? [source] : []
+    ];
+    const sum = counted.reduce((acc, len) => acc + len, 0);
+    if (overTotal(counted, limits.total))
       return `${model.label} takes reference videos up to ${String(limits.total)} s combined; these add up to ${seconds(sum, limits.total)} s.`;
   }
   if (source === void 0) return void 0;
   const sourceMin = effectiveMin(sourceLimits, input.taskType);
-  if (sourceLimits?.max !== void 0 && source > sourceLimits.max)
+  if (sourceLimits?.max !== void 0 && overMax(source, sourceLimits.max))
     return `${model.label} takes a source video up to ${String(sourceLimits.max)} s; this one is ${seconds(source, sourceLimits.max)} s.`;
   if (sourceMin !== void 0 && source < sourceMin)
     return `${model.label} takes a source video of at least ${String(sourceMin)} s; this one is ${seconds(source, sourceMin)} s.`;