@shoelace-style/localize 3.1.0 → 3.1.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 3.1.2
+
+- Fixed a bug that caused underscores in locale identifiers to throw a `RangeError`
+
+## 3.1.1
+
+- Upgraded TypeScript to 5.1.3
+
 ## 3.1.0
 
 - Added `exists()` method to determine if a term and/or a fallback term exists [#17](https://github.com/shoelace-style/localize/issues/17)

package/dist/index.d.ts

@@ -1,5 +1,5 @@
 import type { ReactiveController, ReactiveControllerHost } from 'lit';
-export declare type FunctionParams<T> = T extends (...args: infer U) => string ? U : never;
+export type FunctionParams<T> = T extends (...args: infer U) => string ? U : [];
 export interface Translation {
     $code: string;
     $name: string;

package/dist/index.js

@@ -51,7 +51,7 @@ export class LocalizeController {
     }
     getTranslationData(lang) {
         var _a, _b;
-        const locale = new Intl.Locale(lang);
+        const locale = new Intl.Locale(lang.replace(/_/g, '-'));
         const language = locale === null || locale === void 0 ? void 0 : locale.language.toLowerCase();
         const region = (_b = (_a = locale === null || locale === void 0 ? void 0 : locale.region) === null || _a === void 0 ? void 0 : _a.toLowerCase()) !== null && _b !== void 0 ? _b : '';
         const primary = translations.get(`${language}-${region}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shoelace-style/localize",
-  "version": "3.1.0",
+  "version": "3.1.2",
   "description": "A micro library for localizing custom elements using Lit's Reactive Controller model.",
   "main": "dist/index.js",
   "module": "dist/index.js",
@@ -35,6 +35,6 @@
   "devDependencies": {
     "del": "^6.0.0",
     "lit": "^2.0.2",
-    "typescript": "4.8.4"
+    "typescript": "^5.1.3"
   }
 }

package/src/index.ts

@@ -1,6 +1,6 @@
 import type { LitElement, ReactiveController, ReactiveControllerHost } from 'lit';
 
-export type FunctionParams<T> = T extends (...args: infer U) => string ? U : never;
+export type FunctionParams<T> = T extends (...args: infer U) => string ? U : [];
 
 export interface Translation {
   $code: string; // e.g. en, en-GB
@@ -117,7 +117,9 @@ export class LocalizeController<UserTranslation extends Translation = DefaultTra
   }
 
   private getTranslationData(lang: string) {
-    const locale = new Intl.Locale(lang);
+    // Convert "en_US" to "en-US". Note that both underscores and dashes are allowed per spec, but underscores result in
+    // a RangeError by the call to `new Intl.Locale()`. See: https://unicode.org/reports/tr35/#unicode-locale-identifier
+    const locale = new Intl.Locale(lang.replace(/_/g, '-'));
     const language = locale?.language.toLowerCase();
     const region = locale?.region?.toLowerCase() ?? '';
     const primary = <UserTranslation>translations.get(`${language}-${region}`);