@shiyuphan/follow-me 0.6.0 → 0.8.0

package/dist/src/prompt.js

@@ -1,3 +1,4 @@
+import { changedLines } from "./coverage.js";
 import { tipStartOf } from "./diff.js";
 import { anchorOn, concernOn } from "./evolve.js";
 /** Consecutive runs collapse: [0,1,2,3,7] becomes "0-3,7". */
@@ -581,14 +582,14 @@ function itemHeading(item, level) {
     parts.push(kept === null ? "raised by the reviewer" : "raised by the agent, kept by the reviewer");
     return `${"#".repeat(level)} ${parts.join(" · ")}`;
 }
-function renderItems(items, units, level) {
+function renderItems(items, units, level, tallies) {
     const out = [];
     const sorted = sortItems(items, units);
     const paths = [...new Set(sorted.flatMap((i) => (i.where.path === null ? [] : [i.where.path])))];
-    const group = (title, members) => {
+    const group = (title, members, lead = []) => {
         if (members.length === 0)
             return;
-        out.push(`${"#".repeat(level)} ${title}`, "");
+        out.push(`${"#".repeat(level)} ${title}`, "", ...lead);
         for (const item of members) {
             out.push(itemHeading(item, level + 1), "", ...quoteBlock(item.where.quote));
             if (item.where.quote.length > 0)
@@ -596,8 +597,12 @@ function renderItems(items, units, level) {
             out.push(...voices(item), "");
         }
     };
-    for (const path of paths)
-        group(path, sorted.filter((i) => i.where.path === path));
+    for (const path of paths) {
+        const tally = tallies.get(path);
+        group(path, sorted.filter((i) => i.where.path === path), tally === undefined
+            ? []
+            : [`coverage: ${tally.covered} of ${tally.executable} changed lines`, ""]);
+    }
     group("General", sorted.filter((i) => i.where.path === null));
     return out;
 }
@@ -719,24 +724,43 @@ function spanOf(rows) {
         startOldLine: range && first.op !== "+" ? first.base : null,
     };
 }
-function commentSpan(ctx, c) {
+function commentRows(ctx, c) {
     const { anchor } = c;
     if (anchor.kind !== "hunk")
-        return NO_SPAN;
+        return null;
     const hunk = ctx.units.get(anchor.unit);
     if (hunk?.kind !== "hunk")
-        return NO_SPAN;
+        return null;
     const { offsets, changes } = anchor;
-    if (offsets !== undefined)
-        return spanOf(numberedRows(hunk, ctx.units, (i) => offsets.includes(i)));
-    return spanOf(numberedRows(hunk, ctx.units, (_, n) => n !== null && (changes === null || changes.includes(n))));
+    const want = offsets !== undefined
+        ? (i) => offsets.includes(i)
+        : (_, n) => n !== null && (changes === null || changes.includes(n));
+    return { path: hunk.path, rows: numberedRows(hunk, ctx.units, want) };
 }
-function concernSpan(ctx, concern) {
+function concernRows(ctx, concern) {
     const hunk = concern.unit === undefined ? undefined : ctx.units.get(concern.unit);
     if (hunk?.kind !== "hunk")
-        return NO_SPAN;
+        return null;
     const lines = concern.lines;
-    return spanOf(numberedRows(hunk, ctx.units, (_, n) => n !== null && (lines === undefined || lines.includes(n))));
+    const want = (_, n) => n !== null && (lines === undefined || lines.includes(n));
+    return { path: hunk.path, rows: numberedRows(hunk, ctx.units, want) };
+}
+function spanAt(at) {
+    return at === null ? NO_SPAN : spanOf(at.rows);
+}
+/**
+ * Whether the test run ran every executable added row the item points at. Absent without a run
+ * that still fits the file, when it picks no such row, or when its code changed after it was said.
+ */
+function coveredOf(ctx, id, at) {
+    const file = at === null ? undefined : ctx.coverage?.get(at.path);
+    if (at === null || file === undefined || ctx.marks?.has(id))
+        return {};
+    const hits = at.rows.flatMap((r) => {
+        const n = r.op === "+" ? file.lines.get(r.tip) : undefined;
+        return n === undefined ? [] : [n];
+    });
+    return hits.length === 0 ? {} : { covered: hits.every((n) => n > 0) };
 }
 function threadOf(c) {
     return (c.replies ?? []).map((r) => ({ author: r.author, body: r.body }));
@@ -761,6 +785,7 @@ function collectItems(review, ctx, responses) {
         const { kept } = it;
         const first = it.comments[0];
         if (kept !== null) {
+            const at = concernRows(ctx, kept.concern);
             const note = kept.note === null ? "" : `\n\nReviewer: ${kept.note}`;
             const thread = it.comments.flatMap((c) => [
                 { author: "reviewer", body: c.body },
@@ -770,7 +795,7 @@ function collectItems(review, ctx, responses) {
                 where: it.where,
                 item: {
                     id: kept.concern.id,
-                    ...concernSpan(ctx, kept.concern),
+                    ...spanAt(at),
                     path: it.where.path,
                     oldPath: it.where.path,
                     severity: it.severity,
@@ -780,16 +805,18 @@ function collectItems(review, ctx, responses) {
                     resolved: false,
                     excluded: noConcerns.has(kept.concern.id),
                     ...changedOf(ctx, kept.concern.id),
+                    ...coveredOf(ctx, kept.concern.id, at),
                 },
             };
         }
         if (first === undefined)
             throw new Error("an item with neither a concern nor a comment");
+        const at = commentRows(ctx, first);
         return {
             where: it.where,
             item: {
                 id: first.id,
-                ...commentSpan(ctx, first),
+                ...spanAt(at),
                 path: it.where.path,
                 oldPath: it.where.path,
                 severity: it.severity,
@@ -799,6 +826,7 @@ function collectItems(review, ctx, responses) {
                 resolved: resolved.has(first.id),
                 excluded: noComments.has(first.id),
                 ...changedOf(ctx, first.id),
+                ...coveredOf(ctx, first.id, at),
             },
         };
     });
@@ -812,7 +840,7 @@ function collectItems(review, ctx, responses) {
             where,
             item: {
                 id: q.id,
-                ...commentSpan(ctx, q),
+                ...spanAt(commentRows(ctx, q)),
                 path: where.path,
                 oldPath: where.path,
                 severity: q.severity ?? null,
@@ -832,7 +860,7 @@ function collectItems(review, ctx, responses) {
  * Excluded ones are present and marked; whoever posts them skips those.
  */
 export function reportItems(review, commits, units, opts) {
-    const session = folded(review, commits, units, opts.earlier);
+    const session = folded(review, commits, units, opts);
     return collectItems(session.review, session.ctx, opts.responses).map((c) => c.item);
 }
 /** A short list of what the reviewer left out, so nothing vanishes without a trace. */
@@ -855,9 +883,11 @@ function renderExcluded(collected) {
  * taking their unit, and a mark on each whose code changed. Each id appears once; this
  * version's own copy wins.
  */
-function folded(review, commits, units, earlier) {
+function folded(review, commits, units, opts) {
+    const { earlier } = opts;
+    const coverage = opts.coverage === undefined ? {} : { coverage: opts.coverage };
     if (earlier === undefined)
-        return { review, ctx: { commits, units } };
+        return { review, ctx: { commits, units, ...coverage } };
     const marks = new Map();
     const mark = (id, at) => {
         if (at.since !== null)
@@ -895,6 +925,7 @@ function folded(review, commits, units, earlier) {
         ctx: {
             units,
             marks,
+            ...coverage,
             commits: commits.map((commit, k) => {
                 const mine = lost.filter((c) => owner(c.unit, c.commit) === k);
                 if (mine.length === 0)
@@ -915,7 +946,7 @@ function folded(review, commits, units, earlier) {
  * Concerns the reviewer has not decided are left out, as are those dismissed.
  */
 export function renderReport(full, commits, units, opts) {
-    const session = folded(full, commits, units, opts.earlier);
+    const session = folded(full, commits, units, opts);
     const { ctx } = session;
     const excluded = session.review.excluded;
     if (excluded === undefined)
@@ -942,12 +973,14 @@ function renderIncluded(review, ctx, opts) {
     const issues = walk ? rest : rest.filter((c) => c.severity !== undefined);
     const feedback = walk ? [] : rest.filter((c) => c.severity === undefined);
     const items = buildItems(ctx, keptConcerns(review, commits), issues);
+    // Keyed by path as the items name it, so a file's heading finds its count.
+    const tallies = new Map(ctx.coverage === undefined ? [] : changedLines(units, ctx.coverage));
     const out = [];
     if (walk) {
         out.push(`# Code review: ${opts.branch} (${commits.length === 1 ? "1 commit" : `${commits.length} commits`}, ${summarizeIssues(items)})`, "");
         if (items.length === 0 && questions.length === 0)
             out.push("The reviewer raised no issues.", "");
-        out.push(...renderItems(items, units, 2));
+        out.push(...renderItems(items, units, 2, tallies));
     }
     else {
         out.push(`# Review of plan v${review.planVersion}`, "");
@@ -960,7 +993,7 @@ function renderIncluded(review, ctx, opts) {
         }
         out.push(...renderPlanFeedback(ctx, feedback));
         if (items.length > 0) {
-            out.push(`## Code issues (${summarizeIssues(items)})`, "", ...renderItems(items, units, 3));
+            out.push(`## Code issues (${summarizeIssues(items)})`, "", ...renderItems(items, units, 3, tallies));
         }
     }
     if (questions.length > 0)
@@ -985,6 +1018,28 @@ function indented(body) {
 function said(head, body) {
     return body.includes("\n") ? [`${head}:`, indented(body)] : [`${head}: ${body}`];
 }
+/**
+ * The one line that tells the agent a reviewer accepted an offer: where it sits, as the tip lines
+ * of its hunk or its commit, its label, and the command that answers it.
+ */
+export function acceptedOfferLine(c, offer, ctx) {
+    const found = (ctx?.commits ?? []).flatMap((commit, k) => (commit.offers ?? []).flatMap((o) => (o.id === offer ? [{ o, k }] : [])))[0];
+    let place = describeAnchor(c.anchor, ctx);
+    if (found !== undefined && found.o.unit === undefined)
+        place = `commit ${found.k + 1}`;
+    else if (found?.o.unit !== undefined) {
+        const unit = ctx?.units.get(found.o.unit);
+        let where = unit?.path ?? found.o.unit;
+        if (unit?.kind === "hunk" && ctx !== null) {
+            const from = tipStartOf(unit, ctx.units);
+            const kept = unit.body.filter((row) => row.op !== "-").length;
+            where = `${unit.path}:${from}-${from + Math.max(kept, 1) - 1}`;
+        }
+        place = `${where} (commit ${found.k + 1})`;
+    }
+    const label = (found?.o.label ?? c.body).trim().replace(/\.+$/, "");
+    return `Reviewer accepted offer ${offer} on ${place}: ${label}. Reply with follow-me reply ${c.id} --diagram <file> [--map <file>].`;
+}
 /**
  * A new comment carries its short quote, since the agent has not seen it; everything else is one
  * line naming its id, because the agent already has the comment it refers to.
@@ -993,6 +1048,8 @@ function renderEvent(event, ctx) {
     switch (event.type) {
         case "comment": {
             const { comment: c } = event;
+            if (c.offer !== undefined)
+                return [acceptedOfferLine(c, c.offer, ctx)];
             const what = c.kind === "question" ? "question" : (c.severity ?? "comment");
             const lines = [`- ${c.id} ${what} on ${describeAnchor(c.anchor, ctx)}`];
             if (c.follows)
@@ -1014,8 +1071,12 @@ function renderEvent(event, ctx) {
         }
         case "resolved":
             return [`- ${event.commentId} ${event.resolved ? "resolved" : "reopened"}`];
+        case "offer-dismissed":
+            return [`- the reviewer dismissed offer ${event.offer}`];
         case "version":
             return [`- plan v${event.version} is open`];
+        case "coverage":
+            return [`- the page shows coverage from ${event.tip.slice(0, 12)}`];
         case "submitted":
             return ["- the reviewer submitted the review"];
         case "ended":
@@ -1049,11 +1110,38 @@ export function renderShownComment(c, ctx, version) {
     lines.push(...quoted.map((r) => `    ${r}`));
     lines.push(...said(c.author === "agent" ? "agent" : "reviewer", c.body));
     for (const reply of c.replies ?? []) {
-        const diagram = reply.diagram === undefined ? "" : " (with a diagram)";
-        lines.push(...said(`${reply.author} replied${diagram}`, reply.body));
+        const extras = [
+            reply.diagram === undefined ? null : "a diagram",
+            reply.map === undefined ? null : "a state map",
+        ];
+        const parts = extras.filter((x) => x !== null);
+        const head = `${reply.author} replied${parts.length === 0 ? "" : ` (with ${parts.join(" and ")})`}`;
+        lines.push(...(reply.body.trim() === "" ? [head] : said(head, reply.body)));
+        if (reply.map !== undefined)
+            lines.push(...renderMap(reply.map).map((l) => `  ${l}`));
     }
     return `${lines.join("\n")}\n`;
 }
+/** "src/a.ts:12-20" or "src/a.ts:12", a following place in the same file as ":30-41". */
+function formatLocs(locs) {
+    return locs
+        .map((loc, i) => {
+        const lines = loc.start === loc.end ? `${loc.start}` : `${loc.start}-${loc.end}`;
+        return i > 0 && locs[i - 1]?.path === loc.path ? `:${lines}` : `${utf8(loc.path)}:${lines}`;
+    })
+        .join(", ");
+}
+/** A state map, one line per state and per transition. */
+function renderMap(map) {
+    return [
+        ...Object.entries(map.states).map(([name, locs]) => `state ${name}: ${formatLocs(locs)}`),
+        ...(map.transitions ?? []).map((t) => {
+            const event = t.event === undefined ? "" : ` on ${t.event}`;
+            const at = t.at.length === 0 ? "" : `: ${formatLocs(t.at)}`;
+            return `${t.from} -> ${t.to}${event}${at}`;
+        }),
+    ];
+}
 /** A concern of the plan with the lines it is pinned to, as its commit writes them. */
 export function renderShownConcern(concern, commit, ctx) {
     const where = whereConcern(ctx, { concern, commit, severity: concern.severity, note: null });

package/dist/src/server.js

@@ -5,12 +5,13 @@ import { homedir } from "node:os";
 import { basename, isAbsolute, join } from "node:path";
 import { fileURLToPath } from "node:url";
 import { isReplyId, parseComment, parseDraft, parseNewDecision, parseNewReply, } from "./comments.js";
+import { serializeCoverage, staleFiles } from "./coverage.js";
 import { definitionIndex, isIdentifier } from "./definition.js";
 import { isRepoPath } from "./diff.js";
 import { carryConcerns, carrySession } from "./evolve.js";
-import { isConcernId, isPlanVersion } from "./plan.js";
+import { isConcernId, isOfferId, isPlanVersion } from "./plan.js";
 import { renderReport, reportItems } from "./prompt.js";
-import { isLockToken } from "./session.js";
+import { coverageAt, isLockToken, readCoverageIn, SessionFileError } from "./session.js";
 /** The requested port is taken; host.ts decides whether that is our server or a stranger. */
 export class PortInUseError extends Error {
     name = "PortInUseError";
@@ -93,6 +94,7 @@ export async function loadDraft(reviewsDir, version) {
                 earlierReplies: [],
                 carried: null,
                 carriedConcerns: [],
+                dismissedOffers: [],
             };
         }
         throw error;
@@ -257,6 +259,8 @@ function viewOf(registration, loaded, draft, earlier = loaded.earlier) {
         unitIds: new Set(state.units.map((u) => u.id)),
         hunkRows: new Map(state.units.flatMap((u) => u.kind === "hunk" ? [[u.id, u.body.length]] : [])),
         concernIds: new Set(state.commits.flatMap((c) => (c.concerns ?? []).map((k) => k.id))),
+        offers: new Map(state.commits.flatMap((c) => (c.offers ?? []).map((offer) => [offer.id, { offer, commit: c.index }]))),
+        dismissedOffers: new Set(draft.dismissedOffers),
         definitions: definitionIndex(loaded.repo, state.anchor.tip, new Map(state.units.map((u) => [u.id, u])), state.commits),
         draftFile: draftPath(reviewsDir, state.version),
         reviewFile: join(reviewsDir, `v${state.version}.json`),
@@ -313,6 +317,21 @@ function findSaid(view, id) {
         view.loaded.previous?.comments.find((c) => c.id === id) ??
         view.earlier?.find((c) => c.comment.id === id)?.comment);
 }
+/** The comment of this review, on this version or an earlier one, that accepted the offer. */
+function acceptedBy(view, offer) {
+    const said = [...view.comments.values(), ...(view.earlier ?? []).map((c) => c.comment)];
+    return said.find((c) => c.offer === offer);
+}
+/** Why a comment may not accept this offer, or null when it may. */
+function offerProblem(view, offer) {
+    if (!view.offers.has(offer)) {
+        return `offer ${offer} is not in plan v${view.loaded.state.version}`;
+    }
+    const by = acceptedBy(view, offer);
+    if (by !== undefined)
+        return `offer ${offer} is already accepted by ${by.id}`;
+    return view.dismissedOffers.has(offer) ? `offer ${offer} was dismissed` : null;
+}
 function earlierOf(view) {
     return [...view.earlierReplies].map(([comment, replies]) => ({ comment, replies }));
 }
@@ -413,6 +432,7 @@ function hostSession(id, registration, loaded, draft, load) {
         const resolved = [...view.resolved];
         const excluded = excludedOf();
         const earlierReplies = earlierOf(view);
+        const dismissedOffers = [...view.dismissedOffers];
         const snapshot = JSON.stringify({
             schema: "follow-me/review-draft@1",
             planVersion: state.version,
@@ -422,6 +442,7 @@ function hostSession(id, registration, loaded, draft, load) {
             ...(excluded === null ? {} : { excluded }),
             ...(earlierReplies.length === 0 ? {} : { earlierReplies }),
             ...carriedRefs(view),
+            ...(dismissedOffers.length === 0 ? {} : { dismissedOffers }),
         }, null, 2);
         const dir = view.loaded.reviewsDir;
         writes = writes.then(async () => {
@@ -457,6 +478,7 @@ function hostSession(id, registration, loaded, draft, load) {
         const resolved = [...view.resolved];
         const excluded = excludedOf();
         const earlierReplies = earlierOf(view);
+        const dismissedOffers = [...view.dismissedOffers];
         return {
             schema: "follow-me/review@1",
             mode: view.loaded.state.mode,
@@ -469,28 +491,51 @@ function hostSession(id, registration, loaded, draft, load) {
             ...(excluded === null ? {} : { excluded }),
             ...(earlierReplies.length === 0 ? {} : { earlierReplies }),
             ...carriedRefs(view),
+            ...(dismissedOffers.length === 0 ? {} : { dismissedOffers }),
         };
     };
-    const reportOptions = () => {
+    const reportOptions = async () => {
         const comments = sessionOf(view);
+        const { repo, state } = view.loaded;
+        const coverage = await coverageAt(repo, view.registration.dir, state.anchor.tip);
         return {
-            branch: view.loaded.state.anchor.branch,
+            branch: state.anchor.branch,
             responses: [],
             ...(comments === null ? {} : { earlier: { comments, concerns: view.earlierConcerns } }),
+            ...(coverage === null ? {} : { coverage }),
         };
     };
     const unitsOf = () => new Map(view.loaded.state.units.map((u) => [u.id, u]));
-    const report = (finished) => renderReport(finished, view.loaded.state.commits, unitsOf(), reportOptions());
+    const report = async (finished) => renderReport(finished, view.loaded.state.commits, unitsOf(), await reportOptions());
     /** Writes reviews/vN.json and its report once, and removes the autosave. */
     const writeReview = async (finished) => {
         await writes;
         await mkdir(view.loaded.reviewsDir, { recursive: true });
         await writeAtomic(view.reviewFile, `${JSON.stringify(finished, null, 2)}\n`);
-        await writeAtomic(view.reviewFile.replace(/\.json$/, ".md"), report(finished));
+        await writeAtomic(view.reviewFile.replace(/\.json$/, ".md"), await report(finished));
         await rm(view.draftFile, { force: true });
         return view.reviewFile;
     };
-    const hasWork = () => view.comments.size > 0 || view.decisions.size > 0 || view.earlierReplies.size > 0;
+    /** coverage.json as the agent last wrote it, or a 404 before its first run. */
+    const coverageFile = () => {
+        let coverage;
+        try {
+            coverage = readCoverageIn(view.registration.dir);
+        }
+        catch (error) {
+            if (error instanceof SessionFileError)
+                throw new HttpError(500, error.message);
+            throw error;
+        }
+        if (coverage === null) {
+            throw new HttpError(404, "no coverage yet; the agent records it with follow-me coverage");
+        }
+        return coverage;
+    };
+    const hasWork = () => view.comments.size > 0 ||
+        view.decisions.size > 0 ||
+        view.earlierReplies.size > 0 ||
+        view.dismissedOffers.size > 0;
     return {
         id,
         done,
@@ -514,6 +559,7 @@ function hostSession(id, registration, loaded, draft, load) {
             concerns: [...view.decisions.values()],
             resolved: [...view.resolved],
             excluded: { comments: [...view.excludedComments], concerns: [...view.excludedConcerns] },
+            dismissedOffers: [...view.dismissedOffers],
             seq: events.length,
             previous: previousOf(view),
             carried: carriedOf(view),
@@ -547,18 +593,37 @@ function hostSession(id, registration, loaded, draft, load) {
             return waitForEvents(since, timeoutMs, signal);
         },
         report: () => report(review()),
+        /**
+         * The agent's last test run, read from disk so a restarted server serves it too, with the
+         * covered files whose content changed since its tip. A new plan for the same tip stales nothing.
+         */
+        coverage: async () => {
+            const coverage = coverageFile();
+            const stale = await staleFiles(view.loaded.repo, coverage, view.loaded.state.anchor.tip);
+            return { ...serializeCoverage(coverage), stale };
+        },
+        /** The agent wrote coverage.json; the page hears it as one event and reloads its marks. */
+        coverageTaken: () => {
+            open();
+            const { tip, takenAt } = coverageFile();
+            emit({ type: "coverage", tip, takenAt });
+            return { tip, takenAt };
+        },
         /** The page reads a definition the plan shows from its hunk, so only others carry a preview. */
         define: async (name, from) => {
             const found = await view.definitions.lookup(name, from !== null && isRepoPath(from) ? from : null);
             return found.map((c) => (c.unit === null ? c : { ...c, preview: [] }));
         },
-        reportItems: () => reportItems(review(), view.loaded.state.commits, unitsOf(), reportOptions()),
+        reportItems: async () => reportItems(review(), view.loaded.state.commits, unitsOf(), await reportOptions()),
         add: async (raw) => {
             open();
             if (!isRecord(raw))
                 throw new HttpError(400, "malformed comment");
             const commentId = mintCommentId(new Set([...view.comments.keys(), ...(view.earlier ?? []).map((c) => c.comment.id)]));
             const comment = withReplies(accept(parseComment({ ...raw, id: commentId, createdAt: new Date().toISOString() })), undefined);
+            const problem = comment.offer === undefined ? null : offerProblem(view, comment.offer);
+            if (problem !== null)
+                throw new HttpError(400, problem);
             view.comments.set(commentId, comment);
             emit({ type: "comment", comment });
             await saveDraft();
@@ -569,6 +634,14 @@ function hostSession(id, registration, loaded, draft, load) {
             const parsed = withReplies(accept(parseComment(raw)), undefined);
             if (parsed.id !== target)
                 throw new HttpError(400, "comment id does not match the URL");
+            const before = view.comments.get(target);
+            if (parsed.offer !== before?.offer) {
+                const problem = before !== undefined || parsed.offer === undefined
+                    ? "a comment keeps the offer it accepted"
+                    : offerProblem(view, parsed.offer);
+                if (problem !== null)
+                    throw new HttpError(400, problem);
+            }
             // Replies belong to the conversation, not to the page's copy of the comment.
             const comment = withReplies(parsed, view.comments.get(target)?.replies);
             view.comments.set(comment.id, comment);
@@ -635,6 +708,25 @@ function hostSession(id, registration, loaded, draft, load) {
             await saveDraft();
             return decision;
         },
+        /**
+         * Waves an offer of this plan away. It stays dismissed for the rest of the review, across
+         * versions; dismissing it again changes nothing, and an accepted offer cannot be dismissed.
+         */
+        dismissOffer: async (target) => {
+            open();
+            if (!isOfferId(target) || !view.offers.has(target)) {
+                throw new HttpError(404, "no such offer in this plan");
+            }
+            const by = acceptedBy(view, target);
+            if (by !== undefined)
+                throw new HttpError(400, `offer ${target} is already accepted by ${by.id}`);
+            if (!view.dismissedOffers.has(target)) {
+                view.dismissedOffers.add(target);
+                emit({ type: "offer-dismissed", offer: target });
+                await saveDraft();
+            }
+            return [...view.dismissedOffers];
+        },
         /** Leaves a comment or an agent concern out of the hand-off, or puts it back. */
         exclude: async (raw) => {
             open();
@@ -728,13 +820,15 @@ function hostSession(id, registration, loaded, draft, load) {
                         comments: [...view.excludedComments],
                         concerns: [...view.excludedConcerns].filter(stillNamed),
                     },
+                    dismissedOffers: [...view.dismissedOffers],
                 }, earlier);
                 const carrying = earlier.comments.length +
                     earlier.concerns.length +
                     view.decisions.size +
                     view.resolved.size +
                     view.excludedComments.size +
-                    view.excludedConcerns.size;
+                    view.excludedConcerns.size +
+                    view.dismissedOffers.size;
                 if (carrying > 0)
                     await saveDraft();
                 emit({ type: "version", version, hash, carried: carriedOf(view) });
@@ -958,12 +1052,18 @@ export function startServer(opts) {
             const candidates = await session.define(name, url.searchParams.get("from"));
             return sendJson(res, 200, { candidates });
         }
+        if (method === "GET" && rest === "/api/coverage") {
+            return sendJson(res, 200, await session.coverage());
+        }
+        if (method === "POST" && rest === "/api/coverage") {
+            return sendJson(res, 200, session.coverageTaken());
+        }
         if (method === "GET" && rest === "/api/report" && url.searchParams.get("format") === "json") {
-            return sendJson(res, 200, session.reportItems());
+            return sendJson(res, 200, await session.reportItems());
         }
         if (method === "GET" && rest === "/api/report") {
             res.writeHead(200, { "content-type": "text/markdown; charset=utf-8" });
-            res.end(session.report());
+            res.end(await session.report());
             return;
         }
         if (method === "POST" && rest === "/api/version") {
@@ -989,6 +1089,10 @@ export function startServer(opts) {
         if (replies !== undefined && method === "POST") {
             return sendJson(res, 201, { id: await session.reply(replies, await readJson(req)) });
         }
+        const offer = /^\/api\/offers\/([^/]+)\/dismiss$/.exec(rest ?? "")?.[1];
+        if (offer !== undefined && method === "POST") {
+            return sendJson(res, 200, { dismissedOffers: await session.dismissOffer(offer) });
+        }
         const concern = /^\/api\/concerns\/([^/]+)$/.exec(rest ?? "")?.[1];
         if (concern !== undefined && method === "POST") {
             return sendJson(res, 200, await session.decide(concern, await readJson(req)));

package/dist/src/session.js

@@ -2,6 +2,7 @@ import { randomUUID } from "node:crypto";
 import { existsSync, linkSync, mkdirSync, readdirSync, readFileSync, renameSync, rmSync, statSync, writeFileSync, } from "node:fs";
 import { basename, dirname, join } from "node:path";
 import { parseDraft, parseReview } from "./comments.js";
+import { freshFiles, parseCoverage, serializeCoverage, staleFiles } from "./coverage.js";
 import { isSha } from "./diff.js";
 import { evolvePlan } from "./evolve.js";
 import { branchExists, currentBranch, defaultBaseRef, GitError, loadDiff, objectsDir, QUARANTINE_PREFIX, repoRoot, resolveCommit, } from "./git.js";
@@ -200,6 +201,36 @@ function parseApplied(v) {
         return null;
     return { schema, version, branch, head, hash, signed };
 }
+function coveragePath(dir) {
+    return join(dir, "coverage.json");
+}
+/** The coverage.json of the session in `dir`, or null when there is none. */
+export function readCoverageIn(dir) {
+    const path = coveragePath(dir);
+    const raw = readJson(path);
+    if (raw === undefined)
+        return null;
+    const coverage = parseCoverage(raw);
+    if (typeof coverage === "string")
+        throw new SessionFileError(`${path}: ${coverage}`);
+    return coverage;
+}
+/**
+ * What the report counts: the files of the session's test run that still describe `tip`. Null
+ * without a run, and when coverage.json cannot be read, so a report never fails on it.
+ */
+export async function coverageAt(repo, dir, tip) {
+    let coverage;
+    try {
+        coverage = readCoverageIn(dir);
+    }
+    catch (error) {
+        if (error instanceof SessionFileError)
+            return null;
+        throw error;
+    }
+    return coverage === null ? null : freshFiles(coverage, await staleFiles(repo, coverage, tip));
+}
 function makeSession(root, dir, anchor, diff) {
     const plansDir = join(dir, "plans");
     const splitReviews = join(dir, "reviews");
@@ -310,6 +341,9 @@ function makeSession(root, dir, anchor, diff) {
             writeJson(join(plansDir, `v${version}.json`), serializePlanFile(plan.file));
             return version;
         },
+        coverage: () => readCoverageIn(dir),
+        writeCoverage: (coverage) => writeJson(coveragePath(dir), serializeCoverage(coverage)),
+        clearCoverage: () => rmSync(coveragePath(dir), { force: true }),
         lock: (command) => acquireLock(dir, anchor.branch, command),
         adoptLock: (from, command) => adoptLock(dir, from, command),
         lockState: () => readLock(join(dir, "lock")),

package/dist/src/types.js

@@ -12,6 +12,8 @@
  *               review file, the autosaved draft and the server's events. Pure parsers.
  *   definition.ts where an identifier is defined at the branch tip, and where that lands in the
  *               plan: per-language patterns, ranking, placement and a per-tip cache.
+ *   coverage.ts lcov from the agent's test run: parse, place at the tip, merge runs, count the
+ *               changed lines covered, and which files went stale since.
  *   prompt.ts   the planner prompt for an agent, the feedback and the consolidated report.
  *   server.ts   the review server: a registry of hosted sessions, their JSON API, and ui/.
  *   host.ts     the one server per user: its record in the state dir, attach, start, stop.

package/dist/ui/dist/assets/{abnfDiagram-WEYOIA3C-fYSYLdMl.js → abnfDiagram-WEYOIA3C-Bp14ygmz.js}

@@ -1 +1 @@
-import{m as e,t}from"./mermaid-parser.core-DGpOP8AM.js";import{n}from"./chunk-Y2CYZVJY-DsF7k-Jl.js";import{m as r}from"./src-XnrqevnL.js";import"./chunk-DSNLSHJZ-B2z7FX4h.js";import{n as i,r as a,t as o}from"./chunk-2E7WHVMD-CNMuK9zj.js";import{t as s}from"./chunk-JWPE2WC7-DVXcaiue.js";import"./mermaid.core-BJtBFbJx.js";var c=e().RailroadAbnf.parser.LangiumParser,l=n(e=>{let t=e.alternatives.map(u);return t.length===1?t[0]:{type:`choice`,alternatives:t}},`transformAlternation`),u=n(e=>{let t=e.elements.map(f);return t.length===1?t[0]:{type:`sequence`,elements:t}},`transformConcatenation`),d=n(e=>{if(e.includes(`*`)){let[t,n]=e.split(`*`);return{min:t?parseInt(t,10):0,max:n?parseInt(n,10):1/0}}let t=parseInt(e,10);return{min:t,max:t}},`parseRepeat`),f=n(e=>{let t=p(e.primary);if(!e.repeat)return t;let{min:n,max:r}=d(e.repeat);return n===0&&r===1?{type:`optional`,element:t}:{type:`repetition`,element:t,min:n,max:r}},`transformElement`),p=n(e=>{switch(e.$type){case`AbnfStringLiteral`:return{type:`terminal`,value:e.value};case`AbnfNumVal`:return{type:`terminal`,value:e.value};case`AbnfRuleName`:return{type:`nonterminal`,name:e.name};case`AbnfGroup`:return l(e.element);case`AbnfOptionalGroup`:return{type:`optional`,element:l(e.element)};default:throw Error(`Unsupported ABNF primary node: ${e.$type}`)}},`transformPrimary`),m=n(e=>({name:e.name,definition:l(e.definition)}),`transformRule`),h=n(e=>{s(e,o),e.title&&o.setTitle(e.title),e.rules.map(e=>o.addRule(m(e)))},`populateDb`),g={parser:{parse:n(e=>{o.clear(),r.debug(`[ABNF Parser] Starting Langium parse`);let n=c.parse(e);if(n.lexerErrors.length>0||n.parserErrors.length>0)throw new t(n);let i=n.value;r.debug(`[ABNF Parser] Parsed rules:`,i.rules.length),h(i),r.debug(`[ABNF Parser] Parse complete`)},`parse`),parser:{yy:o}},db:o,renderer:a,styles:i};export{g as diagram};
+import{m as e,t}from"./mermaid-parser.core-Bxa71wW-.js";import{n}from"./chunk-Y2CYZVJY-DsF7k-Jl.js";import{m as r}from"./src-D5-ZzLwt.js";import"./chunk-DSNLSHJZ-CNjUo110.js";import{n as i,r as a,t as o}from"./chunk-2E7WHVMD-BODm_awL.js";import{t as s}from"./chunk-JWPE2WC7-DVXcaiue.js";import"./mermaid.core-DBI9F4bh.js";var c=e().RailroadAbnf.parser.LangiumParser,l=n(e=>{let t=e.alternatives.map(u);return t.length===1?t[0]:{type:`choice`,alternatives:t}},`transformAlternation`),u=n(e=>{let t=e.elements.map(f);return t.length===1?t[0]:{type:`sequence`,elements:t}},`transformConcatenation`),d=n(e=>{if(e.includes(`*`)){let[t,n]=e.split(`*`);return{min:t?parseInt(t,10):0,max:n?parseInt(n,10):1/0}}let t=parseInt(e,10);return{min:t,max:t}},`parseRepeat`),f=n(e=>{let t=p(e.primary);if(!e.repeat)return t;let{min:n,max:r}=d(e.repeat);return n===0&&r===1?{type:`optional`,element:t}:{type:`repetition`,element:t,min:n,max:r}},`transformElement`),p=n(e=>{switch(e.$type){case`AbnfStringLiteral`:return{type:`terminal`,value:e.value};case`AbnfNumVal`:return{type:`terminal`,value:e.value};case`AbnfRuleName`:return{type:`nonterminal`,name:e.name};case`AbnfGroup`:return l(e.element);case`AbnfOptionalGroup`:return{type:`optional`,element:l(e.element)};default:throw Error(`Unsupported ABNF primary node: ${e.$type}`)}},`transformPrimary`),m=n(e=>({name:e.name,definition:l(e.definition)}),`transformRule`),h=n(e=>{s(e,o),e.title&&o.setTitle(e.title),e.rules.map(e=>o.addRule(m(e)))},`populateDb`),g={parser:{parse:n(e=>{o.clear(),r.debug(`[ABNF Parser] Starting Langium parse`);let n=c.parse(e);if(n.lexerErrors.length>0||n.parserErrors.length>0)throw new t(n);let i=n.value;r.debug(`[ABNF Parser] Parsed rules:`,i.rules.length),h(i),r.debug(`[ABNF Parser] Parse complete`)},`parse`),parser:{yy:o}},db:o,renderer:a,styles:i};export{g as diagram};

package/dist/ui/dist/assets/{arc-DGuGSnwa.js → arc-DUR6uzhI.js}

@@ -1 +1 @@
-import{n as e,t}from"./path-fybaL0A-.js";import{a as n,c as r,d as i,f as a,i as o,l as s,m as c,n as l,o as u,p as d,r as f,u as p}from"./dist-BJd4jp9Y.js";function m(e){return e.innerRadius}function h(e){return e.outerRadius}function g(e){return e.startAngle}function _(e){return e.endAngle}function v(e){return e&&e.padAngle}function y(e,t,n,r,i,a,o,s){var c=n-e,l=r-t,u=o-i,d=s-a,f=d*c-u*l;if(!(f*f<1e-12))return f=(u*(t-a)-d*(e-i))/f,[e+f*c,t+f*l]}function b(e,t,n,r,i,a,o){var c=e-n,l=t-r,u=(o?a:-a)/d(c*c+l*l),f=u*l,p=-u*c,m=e+f,h=t+p,g=n+f,_=r+p,v=(m+g)/2,y=(h+_)/2,b=g-m,x=_-h,S=b*b+x*x,C=i-a,w=m*_-g*h,T=(x<0?-1:1)*d(s(0,C*C*S-w*w)),E=(w*x-b*T)/S,D=(-w*b-x*T)/S,O=(w*x+b*T)/S,k=(-w*b+x*T)/S,A=E-v,j=D-y,M=O-v,N=k-y;return A*A+j*j>M*M+N*N&&(E=O,D=k),{cx:E,cy:D,x01:-f,y01:-p,x11:E*(i/C-1),y11:D*(i/C-1)}}function x(){var s=m,x=h,S=e(0),C=null,w=g,T=_,E=v,D=null,O=t(k);function k(){var e,t,m=+s.apply(this,arguments),h=+x.apply(this,arguments),g=w.apply(this,arguments)-r,_=T.apply(this,arguments)-r,v=l(_-g),k=_>g;if(D||=e=O(),h<m&&(t=h,h=m,m=t),!(h>1e-12))D.moveTo(0,0);else if(v>c-1e-12)D.moveTo(h*u(g),h*a(g)),D.arc(0,0,h,g,_,!k),m>1e-12&&(D.moveTo(m*u(_),m*a(_)),D.arc(0,0,m,_,g,k));else{var A=g,j=_,M=g,N=_,P=v,F=v,I=E.apply(this,arguments)/2,L=I>1e-12&&(C?+C.apply(this,arguments):d(m*m+h*h)),R=p(l(h-m)/2,+S.apply(this,arguments)),z=R,B=R,V,H;if(L>1e-12){var U=o(L/m*a(I)),W=o(L/h*a(I));(P-=U*2)>1e-12?(U*=k?1:-1,M+=U,N-=U):(P=0,M=N=(g+_)/2),(F-=W*2)>1e-12?(W*=k?1:-1,A+=W,j-=W):(F=0,A=j=(g+_)/2)}var G=h*u(A),K=h*a(A),q=m*u(N),J=m*a(N);if(R>1e-12){var Y=h*u(j),X=h*a(j),Z=m*u(M),Q=m*a(M),$;if(v<i){if($=y(G,K,Z,Q,Y,X,q,J)){var ee=G-$[0],te=K-$[1],ne=Y-$[0],re=X-$[1],ie=1/a(f((ee*ne+te*re)/(d(ee*ee+te*te)*d(ne*ne+re*re)))/2),ae=d($[0]*$[0]+$[1]*$[1]);z=p(R,(m-ae)/(ie-1)),B=p(R,(h-ae)/(ie+1))}else z=B=0}}F>1e-12?B>1e-12?(V=b(Z,Q,G,K,h,B,k),H=b(Y,X,q,J,h,B,k),D.moveTo(V.cx+V.x01,V.cy+V.y01),B<R?D.arc(V.cx,V.cy,B,n(V.y01,V.x01),n(H.y01,H.x01),!k):(D.arc(V.cx,V.cy,B,n(V.y01,V.x01),n(V.y11,V.x11),!k),D.arc(0,0,h,n(V.cy+V.y11,V.cx+V.x11),n(H.cy+H.y11,H.cx+H.x11),!k),D.arc(H.cx,H.cy,B,n(H.y11,H.x11),n(H.y01,H.x01),!k))):(D.moveTo(G,K),D.arc(0,0,h,A,j,!k)):D.moveTo(G,K),!(m>1e-12)||!(P>1e-12)?D.lineTo(q,J):z>1e-12?(V=b(q,J,Y,X,m,-z,k),H=b(G,K,Z,Q,m,-z,k),D.lineTo(V.cx+V.x01,V.cy+V.y01),z<R?D.arc(V.cx,V.cy,z,n(V.y01,V.x01),n(H.y01,H.x01),!k):(D.arc(V.cx,V.cy,z,n(V.y01,V.x01),n(V.y11,V.x11),!k),D.arc(0,0,m,n(V.cy+V.y11,V.cx+V.x11),n(H.cy+H.y11,H.cx+H.x11),k),D.arc(H.cx,H.cy,z,n(H.y11,H.x11),n(H.y01,H.x01),!k))):D.arc(0,0,m,N,M,k)}if(D.closePath(),e)return D=null,e+``||null}return k.centroid=function(){var e=(+s.apply(this,arguments)+ +x.apply(this,arguments))/2,t=(+w.apply(this,arguments)+ +T.apply(this,arguments))/2-i/2;return[u(t)*e,a(t)*e]},k.innerRadius=function(t){return arguments.length?(s=typeof t==`function`?t:e(+t),k):s},k.outerRadius=function(t){return arguments.length?(x=typeof t==`function`?t:e(+t),k):x},k.cornerRadius=function(t){return arguments.length?(S=typeof t==`function`?t:e(+t),k):S},k.padRadius=function(t){return arguments.length?(C=t==null?null:typeof t==`function`?t:e(+t),k):C},k.startAngle=function(t){return arguments.length?(w=typeof t==`function`?t:e(+t),k):w},k.endAngle=function(t){return arguments.length?(T=typeof t==`function`?t:e(+t),k):T},k.padAngle=function(t){return arguments.length?(E=typeof t==`function`?t:e(+t),k):E},k.context=function(e){return arguments.length?(D=e??null,k):D},k}export{x as t};
+import{n as e,t}from"./path-fybaL0A-.js";import{a as n,c as r,d as i,f as a,i as o,l as s,m as c,n as l,o as u,p as d,r as f,u as p}from"./dist-DxQIK_Ay.js";function m(e){return e.innerRadius}function h(e){return e.outerRadius}function g(e){return e.startAngle}function _(e){return e.endAngle}function v(e){return e&&e.padAngle}function y(e,t,n,r,i,a,o,s){var c=n-e,l=r-t,u=o-i,d=s-a,f=d*c-u*l;if(!(f*f<1e-12))return f=(u*(t-a)-d*(e-i))/f,[e+f*c,t+f*l]}function b(e,t,n,r,i,a,o){var c=e-n,l=t-r,u=(o?a:-a)/d(c*c+l*l),f=u*l,p=-u*c,m=e+f,h=t+p,g=n+f,_=r+p,v=(m+g)/2,y=(h+_)/2,b=g-m,x=_-h,S=b*b+x*x,C=i-a,w=m*_-g*h,T=(x<0?-1:1)*d(s(0,C*C*S-w*w)),E=(w*x-b*T)/S,D=(-w*b-x*T)/S,O=(w*x+b*T)/S,k=(-w*b+x*T)/S,A=E-v,j=D-y,M=O-v,N=k-y;return A*A+j*j>M*M+N*N&&(E=O,D=k),{cx:E,cy:D,x01:-f,y01:-p,x11:E*(i/C-1),y11:D*(i/C-1)}}function x(){var s=m,x=h,S=e(0),C=null,w=g,T=_,E=v,D=null,O=t(k);function k(){var e,t,m=+s.apply(this,arguments),h=+x.apply(this,arguments),g=w.apply(this,arguments)-r,_=T.apply(this,arguments)-r,v=l(_-g),k=_>g;if(D||=e=O(),h<m&&(t=h,h=m,m=t),!(h>1e-12))D.moveTo(0,0);else if(v>c-1e-12)D.moveTo(h*u(g),h*a(g)),D.arc(0,0,h,g,_,!k),m>1e-12&&(D.moveTo(m*u(_),m*a(_)),D.arc(0,0,m,_,g,k));else{var A=g,j=_,M=g,N=_,P=v,F=v,I=E.apply(this,arguments)/2,L=I>1e-12&&(C?+C.apply(this,arguments):d(m*m+h*h)),R=p(l(h-m)/2,+S.apply(this,arguments)),z=R,B=R,V,H;if(L>1e-12){var U=o(L/m*a(I)),W=o(L/h*a(I));(P-=U*2)>1e-12?(U*=k?1:-1,M+=U,N-=U):(P=0,M=N=(g+_)/2),(F-=W*2)>1e-12?(W*=k?1:-1,A+=W,j-=W):(F=0,A=j=(g+_)/2)}var G=h*u(A),K=h*a(A),q=m*u(N),J=m*a(N);if(R>1e-12){var Y=h*u(j),X=h*a(j),Z=m*u(M),Q=m*a(M),$;if(v<i){if($=y(G,K,Z,Q,Y,X,q,J)){var ee=G-$[0],te=K-$[1],ne=Y-$[0],re=X-$[1],ie=1/a(f((ee*ne+te*re)/(d(ee*ee+te*te)*d(ne*ne+re*re)))/2),ae=d($[0]*$[0]+$[1]*$[1]);z=p(R,(m-ae)/(ie-1)),B=p(R,(h-ae)/(ie+1))}else z=B=0}}F>1e-12?B>1e-12?(V=b(Z,Q,G,K,h,B,k),H=b(Y,X,q,J,h,B,k),D.moveTo(V.cx+V.x01,V.cy+V.y01),B<R?D.arc(V.cx,V.cy,B,n(V.y01,V.x01),n(H.y01,H.x01),!k):(D.arc(V.cx,V.cy,B,n(V.y01,V.x01),n(V.y11,V.x11),!k),D.arc(0,0,h,n(V.cy+V.y11,V.cx+V.x11),n(H.cy+H.y11,H.cx+H.x11),!k),D.arc(H.cx,H.cy,B,n(H.y11,H.x11),n(H.y01,H.x01),!k))):(D.moveTo(G,K),D.arc(0,0,h,A,j,!k)):D.moveTo(G,K),!(m>1e-12)||!(P>1e-12)?D.lineTo(q,J):z>1e-12?(V=b(q,J,Y,X,m,-z,k),H=b(G,K,Z,Q,m,-z,k),D.lineTo(V.cx+V.x01,V.cy+V.y01),z<R?D.arc(V.cx,V.cy,z,n(V.y01,V.x01),n(H.y01,H.x01),!k):(D.arc(V.cx,V.cy,z,n(V.y01,V.x01),n(V.y11,V.x11),!k),D.arc(0,0,m,n(V.cy+V.y11,V.cx+V.x11),n(H.cy+H.y11,H.cx+H.x11),k),D.arc(H.cx,H.cy,z,n(H.y11,H.x11),n(H.y01,H.x01),!k))):D.arc(0,0,m,N,M,k)}if(D.closePath(),e)return D=null,e+``||null}return k.centroid=function(){var e=(+s.apply(this,arguments)+ +x.apply(this,arguments))/2,t=(+w.apply(this,arguments)+ +T.apply(this,arguments))/2-i/2;return[u(t)*e,a(t)*e]},k.innerRadius=function(t){return arguments.length?(s=typeof t==`function`?t:e(+t),k):s},k.outerRadius=function(t){return arguments.length?(x=typeof t==`function`?t:e(+t),k):x},k.cornerRadius=function(t){return arguments.length?(S=typeof t==`function`?t:e(+t),k):S},k.padRadius=function(t){return arguments.length?(C=t==null?null:typeof t==`function`?t:e(+t),k):C},k.startAngle=function(t){return arguments.length?(w=typeof t==`function`?t:e(+t),k):w},k.endAngle=function(t){return arguments.length?(T=typeof t==`function`?t:e(+t),k):T},k.padAngle=function(t){return arguments.length?(E=typeof t==`function`?t:e(+t),k):E},k.context=function(e){return arguments.length?(D=e??null,k):D},k}export{x as t};