@shiyuphan/follow-me 0.4.0 → 0.4.1

package/dist/src/comments.js

@@ -187,7 +187,10 @@ export function parseNewDecision(concern, v) {
         return "the decision is not an object";
     return withDecision(concern, { ...v, decidedAt: undefined });
 }
-/** Absent reads as none. The first item that does not parse names its index and reason. */
+/**
+ * Absent reads as none. The first item that does not parse names its index and reason. Items
+ * are objects so a string result can only mean a failure; string values go through parseIds.
+ */
 function parseList(raw, parse, what) {
     if (raw === undefined)
         return [];
@@ -202,8 +205,26 @@ function parseList(raw, parse, what) {
     }
     return out;
 }
-function parseConcernId(item) {
-    return isConcernId(item) ? item : "not a concern id";
+/** Absent reads as none. The first item that is not an id of the kind names its index. */
+function parseIds(raw, is, what, kind) {
+    if (raw === undefined)
+        return [];
+    if (!isArray(raw))
+        return `${what} is not an array`;
+    const out = [];
+    for (const [i, item] of raw.entries()) {
+        if (!is(item))
+            return `${what}[${i}]: not a ${kind} id`;
+        out.push(item);
+    }
+    return out;
+}
+/** Keeps only the items that are ids of the kind. */
+function lenientIds(raw, is) {
+    return isArray(raw) ? raw.filter(is) : [];
+}
+function isCommentIdValue(item) {
+    return typeof item === "string" && isCommentId(item);
 }
 /** Absent reads as nothing excluded. */
 export function parseExcluded(v) {
@@ -211,17 +232,14 @@ export function parseExcluded(v) {
         return { comments: [], concerns: [] };
     if (!isFields(v))
         return "excluded is not an object";
-    const comments = parseList(v.comments, parseCommentId, "excluded.comments");
+    const comments = parseIds(v.comments, isCommentIdValue, "excluded.comments", "comment");
     if (typeof comments === "string")
         return comments;
-    const concerns = parseList(v.concerns, parseConcernId, "excluded.concerns");
+    const concerns = parseIds(v.concerns, isConcernId, "excluded.concerns", "concern");
     return typeof concerns === "string" ? concerns : { comments, concerns };
 }
 function asCommentId(item) {
-    return typeof item === "string" && isCommentId(item) ? item : null;
-}
-function parseCommentId(item) {
-    return asCommentId(item) ?? "not a comment id";
+    return isCommentIdValue(item) ? item : null;
 }
 function parseEarlierReplies(v) {
     if (!isFields(v))
@@ -286,7 +304,7 @@ export function parseReview(v) {
     const concerns = parseList(v.concerns, parseDecision, "concerns");
     if (typeof concerns === "string")
         return concerns;
-    const resolved = parseList(v.resolved, parseCommentId, "resolved");
+    const resolved = parseIds(v.resolved, isCommentIdValue, "resolved", "comment");
     if (typeof resolved === "string")
         return resolved;
     const excluded = parseExcluded(v.excluded);
@@ -329,7 +347,7 @@ export function parseDraft(v) {
     return {
         comments: lenient(v.comments, parseComment),
         concerns: lenient(v.concerns, parseDecision),
-        resolved: lenient(v.resolved, parseCommentId),
+        resolved: lenientIds(v.resolved, isCommentIdValue),
         excluded: typeof excluded === "string" ? { comments: [], concerns: [] } : excluded,
         earlierReplies: lenient(v.earlierReplies, parseEarlierReplies),
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shiyuphan/follow-me",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "Split a branch's final changes into fine, ordered commits that read like the author's thought process, review them hunk by hunk, and hand the review back to a coding agent.",
   "license": "MIT",
   "type": "module",