@shivaedev/quality 0.77.0 → 0.78.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (96) hide show
  1. package/CHANGELOG.md +32 -0
  2. package/README.md +10 -14
  3. package/biome/preset.json +1 -1
  4. package/dist/adapters/declarationTagParameter.d.ts.map +1 -1
  5. package/dist/adapters/declarationTagParameter.js +4 -0
  6. package/dist/adapters/declarationTagParameter.js.map +1 -1
  7. package/dist/adapters/imports/resolve.d.ts.map +1 -1
  8. package/dist/adapters/imports/resolve.js +29 -5
  9. package/dist/adapters/imports/resolve.js.map +1 -1
  10. package/dist/adapters/presenceCheck.d.ts +3 -0
  11. package/dist/adapters/presenceCheck.d.ts.map +1 -0
  12. package/dist/adapters/presenceCheck.js +15 -0
  13. package/dist/adapters/presenceCheck.js.map +1 -0
  14. package/dist/engine/generateFirst.d.ts +5 -0
  15. package/dist/engine/generateFirst.d.ts.map +1 -0
  16. package/dist/engine/generateFirst.js +25 -0
  17. package/dist/engine/generateFirst.js.map +1 -0
  18. package/dist/engine/projectScripts.d.ts +11 -0
  19. package/dist/engine/projectScripts.d.ts.map +1 -0
  20. package/dist/engine/projectScripts.js +18 -0
  21. package/dist/engine/projectScripts.js.map +1 -0
  22. package/dist/engine/session.d.ts.map +1 -1
  23. package/dist/engine/session.js +2 -0
  24. package/dist/engine/session.js.map +1 -1
  25. package/dist/hooks/preCommit.d.ts.map +1 -1
  26. package/dist/hooks/preCommit.js +6 -19
  27. package/dist/hooks/preCommit.js.map +1 -1
  28. package/dist/imports/callsDefineModule.d.ts +3 -0
  29. package/dist/imports/callsDefineModule.d.ts.map +1 -0
  30. package/dist/imports/callsDefineModule.js +36 -0
  31. package/dist/imports/callsDefineModule.js.map +1 -0
  32. package/dist/imports/fences/check.d.ts.map +1 -1
  33. package/dist/imports/fences/check.js +3 -1
  34. package/dist/imports/fences/check.js.map +1 -1
  35. package/dist/imports/generatedFolders.d.ts +7 -0
  36. package/dist/imports/generatedFolders.d.ts.map +1 -0
  37. package/dist/imports/generatedFolders.js +21 -0
  38. package/dist/imports/generatedFolders.js.map +1 -0
  39. package/dist/imports/runtime.d.ts +1 -1
  40. package/dist/imports/runtime.d.ts.map +1 -1
  41. package/dist/imports/runtime.js +3 -2
  42. package/dist/imports/runtime.js.map +1 -1
  43. package/dist/naming/isOperationFile.d.ts +3 -0
  44. package/dist/naming/isOperationFile.d.ts.map +1 -0
  45. package/dist/naming/isOperationFile.js +42 -0
  46. package/dist/naming/isOperationFile.js.map +1 -0
  47. package/dist/naming/repeatedFolder.d.ts +2 -0
  48. package/dist/naming/repeatedFolder.d.ts.map +1 -0
  49. package/dist/naming/repeatedFolder.js +13 -0
  50. package/dist/naming/repeatedFolder.js.map +1 -0
  51. package/dist/rules/builtIn.d.ts +2 -4
  52. package/dist/rules/builtIn.d.ts.map +1 -1
  53. package/dist/rules/builtIn.js +2 -0
  54. package/dist/rules/builtIn.js.map +1 -1
  55. package/dist/rules/effect/serviceParameters.js +1 -1
  56. package/dist/rules/effect/serviceParameters.js.map +1 -1
  57. package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
  58. package/dist/rules/files/namedAfterExport.js +11 -12
  59. package/dist/rules/files/namedAfterExport.js.map +1 -1
  60. package/dist/rules/imports/resolvable.d.ts +1 -3
  61. package/dist/rules/imports/resolvable.d.ts.map +1 -1
  62. package/dist/rules/imports/resolvable.js +12 -10
  63. package/dist/rules/imports/resolvable.js.map +1 -1
  64. package/dist/rules/imports/runtime.d.ts.map +1 -1
  65. package/dist/rules/imports/runtime.js +26 -13
  66. package/dist/rules/imports/runtime.js.map +1 -1
  67. package/dist/rules/stories/rawServers.d.ts +2 -0
  68. package/dist/rules/stories/rawServers.d.ts.map +1 -0
  69. package/dist/rules/stories/rawServers.js +100 -0
  70. package/dist/rules/stories/rawServers.js.map +1 -0
  71. package/docs/north-star.md +1 -1
  72. package/package.json +4 -4
  73. package/src/adapters/declarationTagParameter.ts +4 -0
  74. package/src/adapters/imports/resolve.ts +31 -5
  75. package/src/adapters/presenceCheck.ts +17 -0
  76. package/src/engine/generateFirst.ts +32 -0
  77. package/src/engine/projectScripts.ts +25 -0
  78. package/src/engine/session.ts +2 -0
  79. package/src/hooks/preCommit.ts +10 -24
  80. package/src/imports/callsDefineModule.ts +43 -0
  81. package/src/imports/fences/check.ts +3 -1
  82. package/src/imports/generatedFolders.ts +28 -0
  83. package/src/imports/runtime.ts +7 -2
  84. package/src/naming/isOperationFile.ts +52 -0
  85. package/src/naming/repeatedFolder.ts +14 -0
  86. package/src/rules/builtIn.ts +2 -0
  87. package/src/rules/effect/serviceParameters.ts +1 -1
  88. package/src/rules/files/namedAfterExport.ts +14 -13
  89. package/src/rules/imports/resolvable.ts +13 -11
  90. package/src/rules/imports/runtime.ts +38 -14
  91. package/src/rules/stories/rawServers.ts +118 -0
  92. package/dist/imports/withoutGenerated.d.ts +0 -8
  93. package/dist/imports/withoutGenerated.d.ts.map +0 -1
  94. package/dist/imports/withoutGenerated.js +0 -65
  95. package/dist/imports/withoutGenerated.js.map +0 -1
  96. package/src/imports/withoutGenerated.ts +0 -82
@@ -1,6 +1,8 @@
1
1
  import { Effect } from "effect";
2
2
  import { builtinName } from "#adapters/builtinName.ts";
3
+ import { callsDefineModule } from "#imports/callsDefineModule.ts";
3
4
  import { outgoing, walkFrom } from "#imports/fences/reach.ts";
5
+ import { followedEdges, generatedFolders } from "#imports/generatedFolders.ts";
4
6
  import { importGraph } from "#imports/graph.ts";
5
7
  import { nodePlatformBarrels } from "#imports/nodePlatformBarrels.ts";
6
8
  import { runtimeDeclarationProblems, runtimeOf } from "#imports/runtime.ts";
@@ -13,47 +15,56 @@ function forbiddenImport(from, to, builtin) {
13
15
  return from === "client" && (to === "server" || builtin);
14
16
  }
15
17
  const REPAIR = "Move runtime-dependent code into src/client/ or src/server/ and keep shared code independent of both runtimes.";
16
- function forbiddenTarget(from, runtime) {
18
+ const MODULE_REPAIR = "Import the module's generated client from its generated folder instead; it holds no server code.";
19
+ function forbiddenTarget(from, { definedModules, runtime }) {
17
20
  return (endpoint) => {
18
21
  const to = endpoint.kind === "file" ? runtime(endpoint.path) : undefined;
19
22
  const builtin = endpoint.kind === "external" && builtinName(endpoint.specifier) !== undefined;
20
23
  if (!forbiddenImport(from, to, builtin)) {
21
24
  return undefined;
22
25
  }
23
- return builtin ? "Node built-in" : `${to} code`;
26
+ if (builtin) {
27
+ return { repair: REPAIR, target: "Node built-in" };
28
+ }
29
+ return endpoint.kind === "file" && definedModules.has(endpoint.path)
30
+ ? { repair: MODULE_REPAIR, target: "a defined module, which is server code," }
31
+ : { repair: REPAIR, target: `${to} code` };
24
32
  };
25
33
  }
26
34
  function importer(from) {
27
35
  return from === "client" ? "Client" : "Shared";
28
36
  }
29
37
  // An ignored module, such as generated output, is never reported itself, so its forbidden imports land on the checked file that reaches them.
30
- function ignoredFindings(ignored, edge, from, runtime) {
38
+ function ignoredFindings(ignored, edge, from, classified) {
31
39
  if (edge.to.kind !== "file" || !ignored.modules.has(edge.to.path)) {
32
40
  return [];
33
41
  }
34
- return walkFrom(edge.to.path, ignored.edgesFrom, forbiddenTarget(from, runtime)).reached.map((reached) => ({
42
+ return walkFrom(edge.to.path, ignored.edgesFrom, forbiddenTarget(from, classified)).reached.map(({ match, path }) => ({
35
43
  file: edge.from,
36
44
  line: edge.line,
37
- message: `${importer(from)} code reaches ${reached.match} through "${edge.specifier}", which git ignores: ${reached.path.join(" -> ")}. ${REPAIR}`,
45
+ message: `${importer(from)} code reaches ${match.target} through "${edge.specifier}", which git ignores: ${path.join(" -> ")}. ${match.repair}`,
38
46
  subject: edge.specifier,
39
47
  }));
40
48
  }
41
- function runtimeFindings(graph, runtime) {
42
- const ignored = { edgesFrom: outgoing(graph.ignoredEdges), modules: new Set(graph.ignoredModules) };
49
+ function runtimeFindings(graph, classified) {
50
+ const ignored = {
51
+ edgesFrom: outgoing(followedEdges(generatedFolders(graph.packages), graph.ignoredEdges)),
52
+ modules: new Set(graph.ignoredModules),
53
+ };
43
54
  return graph.edges.flatMap((edge) => {
44
- const from = runtime(edge.from);
55
+ const from = classified.runtime(edge.from);
45
56
  if (from === undefined || isTestCode(edge.from)) {
46
57
  return [];
47
58
  }
48
- const forbidden = forbiddenTarget(from, runtime)(edge.to);
59
+ const forbidden = forbiddenTarget(from, classified)(edge.to);
49
60
  if (forbidden === undefined) {
50
- return ignoredFindings(ignored, edge, from, runtime);
61
+ return ignoredFindings(ignored, edge, from, classified);
51
62
  }
52
63
  return [
53
64
  {
54
65
  file: edge.from,
55
66
  line: edge.line,
56
- message: `${importer(from)} code imports ${forbidden} through "${edge.specifier}". ${REPAIR}`,
67
+ message: `${importer(from)} code imports ${forbidden.target} through "${edge.specifier}". ${forbidden.repair}`,
57
68
  subject: edge.specifier,
58
69
  },
59
70
  ];
@@ -62,8 +73,10 @@ function runtimeFindings(graph, runtime) {
62
73
  export const importsRuntime = defineRule({
63
74
  check: (inputs) => Effect.gen(function* () {
64
75
  const graph = yield* importGraph(inputs);
65
- const runtime = yield* runtimeOf(inputs, graph.packages);
66
- const imports = [...runtimeFindings(graph, runtime), ...inputs.sources.flatMap(nodePlatformBarrels)];
76
+ const definedModules = new Set(inputs.sources.filter(callsDefineModule).map((file) => file.path));
77
+ const runtime = yield* runtimeOf(inputs, graph.packages, definedModules);
78
+ const classified = { definedModules, runtime };
79
+ const imports = [...runtimeFindings(graph, classified), ...inputs.sources.flatMap(nodePlatformBarrels)];
67
80
  const declarations = (yield* runtimeDeclarationProblems(inputs, graph.packages)).map(({ directory, message }) => ({
68
81
  file: directory === "." ? "package.json" : `${directory}/package.json`,
69
82
  line: 1,
@@ -1 +1 @@
1
- {"version":3,"file":"runtime.js","sourceRoot":"","sources":["../../../src/rules/imports/runtime.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAEvD,OAAO,EAAE,QAAQ,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAC9D,OAAO,EAAqC,WAAW,EAAE,MAAM,mBAAmB,CAAC;AACnF,OAAO,EAAE,mBAAmB,EAAE,MAAM,iCAAiC,CAAC;AACtE,OAAO,EAAgB,0BAA0B,EAAE,SAAS,EAAE,MAAM,qBAAqB,CAAC;AAC1F,OAAO,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACjD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AAEtC,SAAS,eAAe,CAAC,IAAa,EAAE,EAAuB,EAAE,OAAgB;IAChF,IAAI,IAAI,KAAK,QAAQ,EAAE,CAAC;QACvB,OAAO,EAAE,KAAK,QAAQ,IAAI,EAAE,KAAK,QAAQ,IAAI,OAAO,CAAC;IACtD,CAAC;IACD,OAAO,IAAI,KAAK,QAAQ,IAAI,CAAC,EAAE,KAAK,QAAQ,IAAI,OAAO,CAAC,CAAC;AAC1D,CAAC;AAED,MAAM,MAAM,GAAG,gHAAgH,CAAC;AAEhI,SAAS,eAAe,CAAC,IAAa,EAAE,OAA8C;IACrF,OAAO,CAAC,QAAkB,EAAsB,EAAE;QACjD,MAAM,EAAE,GAAG,QAAQ,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QACzE,MAAM,OAAO,GAAG,QAAQ,CAAC,IAAI,KAAK,UAAU,IAAI,WAAW,CAAC,QAAQ,CAAC,SAAS,CAAC,KAAK,SAAS,CAAC;QAC9F,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;YACzC,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,OAAO,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,GAAG,EAAE,OAAO,CAAC;IACjD,CAAC,CAAC;AACH,CAAC;AAED,SAAS,QAAQ,CAAC,IAAa;IAC9B,OAAO,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC;AAChD,CAAC;AAOD,8IAA8I;AAC9I,SAAS,eAAe,CAAC,OAAqB,EAAE,IAAgB,EAAE,IAAa,EAAE,OAA8C;IAC9H,IAAI,IAAI,CAAC,EAAE,CAAC,IAAI,KAAK,MAAM,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;QACnE,OAAO,EAAE,CAAC;IACX,CAAC;IACD,OAAO,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,OAAO,CAAC,SAAS,EAAE,eAAe,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;QAC1G,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,OAAO,EAAE,GAAG,QAAQ,CAAC,IAAI,CAAC,iBAAiB,OAAO,CAAC,KAAK,aAAa,IAAI,CAAC,SAAS,yBAAyB,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,MAAM,EAAE;QAClJ,OAAO,EAAE,IAAI,CAAC,SAAS;KACvB,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,eAAe,CAAC,KAAkB,EAAE,OAA8C;IAC1F,MAAM,OAAO,GAAG,EAAE,SAAS,EAAE,QAAQ,CAAC,KAAK,CAAC,YAAY,CAAC,EAAE,OAAO,EAAE,IAAI,GAAG,CAAC,KAAK,CAAC,cAAc,CAAC,EAAE,CAAC;IACpG,OAAO,KAAK,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACnC,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAChC,IAAI,IAAI,KAAK,SAAS,IAAI,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YACjD,OAAO,EAAE,CAAC;QACX,CAAC;QACD,MAAM,SAAS,GAAG,eAAe,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QAC1D,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC7B,OAAO,eAAe,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC;QACtD,CAAC;QACD,OAAO;YACN;gBACC,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,OAAO,EAAE,GAAG,QAAQ,CAAC,IAAI,CAAC,iBAAiB,SAAS,aAAa,IAAI,CAAC,SAAS,MAAM,MAAM,EAAE;gBAC7F,OAAO,EAAE,IAAI,CAAC,SAAS;aACvB;SACD,CAAC;IACH,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,MAAM,CAAC,MAAM,cAAc,GAAG,UAAU,CAAC;IACxC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CACjB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QACnB,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;QACzC,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,SAAS,CAAC,MAAM,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC;QACzD,MAAM,OAAO,GAAG,CAAC,GAAG,eAAe,CAAC,KAAK,EAAE,OAAO,CAAC,EAAE,GAAG,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAC,CAAC;QACrG,MAAM,YAAY,GAAG,CAAC,KAAK,CAAC,CAAC,0BAA0B,CAAC,MAAM,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,EAAE,SAAS,EAAE,OAAO,EAAE,EAAE,EAAE,CAAC,CAAC;YACjH,IAAI,EAAE,SAAS,KAAK,GAAG,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,GAAG,SAAS,eAAe;YACtE,IAAI,EAAE,CAAC;YACP,OAAO;YACP,OAAO,EAAE,iBAAiB;SAC1B,CAAC,CAAC,CAAC;QACJ,MAAM,MAAM,GAAG,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,QAAQ,CAAC,CAAC;QAC1G,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzB,OAAO,CAAC,GAAG,OAAO,EAAE,GAAG,YAAY,CAAC,CAAC;QACtC,CAAC;QACD,MAAM,EAAE,cAAc,EAAE,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,4BAA4B,CAAC,CAAC,CAAC;QAC7F,OAAO,CAAC,GAAG,OAAO,EAAE,GAAG,YAAY,EAAE,GAAG,CAAC,KAAK,CAAC,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;IAC1E,CAAC,CAAC;IACH,WAAW,EACV,oUAAoU;IACrU,EAAE,EAAE,iBAAiB;CACrB,CAAC,CAAC"}
1
+ {"version":3,"file":"runtime.js","sourceRoot":"","sources":["../../../src/rules/imports/runtime.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AACvD,OAAO,EAAE,iBAAiB,EAAE,MAAM,+BAA+B,CAAC;AAElE,OAAO,EAAE,QAAQ,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAC9D,OAAO,EAAE,aAAa,EAAE,gBAAgB,EAAE,MAAM,8BAA8B,CAAC;AAC/E,OAAO,EAAqC,WAAW,EAAE,MAAM,mBAAmB,CAAC;AACnF,OAAO,EAAE,mBAAmB,EAAE,MAAM,iCAAiC,CAAC;AACtE,OAAO,EAAgB,0BAA0B,EAAE,SAAS,EAAE,MAAM,qBAAqB,CAAC;AAC1F,OAAO,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACjD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AAEtC,SAAS,eAAe,CAAC,IAAa,EAAE,EAAuB,EAAE,OAAgB;IAChF,IAAI,IAAI,KAAK,QAAQ,EAAE,CAAC;QACvB,OAAO,EAAE,KAAK,QAAQ,IAAI,EAAE,KAAK,QAAQ,IAAI,OAAO,CAAC;IACtD,CAAC;IACD,OAAO,IAAI,KAAK,QAAQ,IAAI,CAAC,EAAE,KAAK,QAAQ,IAAI,OAAO,CAAC,CAAC;AAC1D,CAAC;AAED,MAAM,MAAM,GAAG,gHAAgH,CAAC;AAEhI,MAAM,aAAa,GAAG,kGAAkG,CAAC;AAYzH,SAAS,eAAe,CAAC,IAAa,EAAE,EAAE,cAAc,EAAE,OAAO,EAAc;IAC9E,OAAO,CAAC,QAAkB,EAAyB,EAAE;QACpD,MAAM,EAAE,GAAG,QAAQ,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QACzE,MAAM,OAAO,GAAG,QAAQ,CAAC,IAAI,KAAK,UAAU,IAAI,WAAW,CAAC,QAAQ,CAAC,SAAS,CAAC,KAAK,SAAS,CAAC;QAC9F,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;YACzC,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,IAAI,OAAO,EAAE,CAAC;YACb,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,eAAe,EAAE,CAAC;QACpD,CAAC;QACD,OAAO,QAAQ,CAAC,IAAI,KAAK,MAAM,IAAI,cAAc,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC;YACnE,CAAC,CAAC,EAAE,MAAM,EAAE,aAAa,EAAE,MAAM,EAAE,yCAAyC,EAAE;YAC9E,CAAC,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,OAAO,EAAE,CAAC;IAC7C,CAAC,CAAC;AACH,CAAC;AAED,SAAS,QAAQ,CAAC,IAAa;IAC9B,OAAO,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC;AAChD,CAAC;AAOD,8IAA8I;AAC9I,SAAS,eAAe,CAAC,OAAqB,EAAE,IAAgB,EAAE,IAAa,EAAE,UAAsB;IACtG,IAAI,IAAI,CAAC,EAAE,CAAC,IAAI,KAAK,MAAM,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;QACnE,OAAO,EAAE,CAAC;IACX,CAAC;IACD,OAAO,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,OAAO,CAAC,SAAS,EAAE,eAAe,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,CAAC;QACrH,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,OAAO,EAAE,GAAG,QAAQ,CAAC,IAAI,CAAC,iBAAiB,KAAK,CAAC,MAAM,aAAa,IAAI,CAAC,SAAS,yBAAyB,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,KAAK,CAAC,MAAM,EAAE;QAC/I,OAAO,EAAE,IAAI,CAAC,SAAS;KACvB,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,eAAe,CAAC,KAAkB,EAAE,UAAsB;IAClE,MAAM,OAAO,GAAG;QACf,SAAS,EAAE,QAAQ,CAAC,aAAa,CAAC,gBAAgB,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,KAAK,CAAC,YAAY,CAAC,CAAC;QACxF,OAAO,EAAE,IAAI,GAAG,CAAC,KAAK,CAAC,cAAc,CAAC;KACtC,CAAC;IACF,OAAO,KAAK,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACnC,MAAM,IAAI,GAAG,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3C,IAAI,IAAI,KAAK,SAAS,IAAI,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YACjD,OAAO,EAAE,CAAC;QACX,CAAC;QACD,MAAM,SAAS,GAAG,eAAe,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QAC7D,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC7B,OAAO,eAAe,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,UAAU,CAAC,CAAC;QACzD,CAAC;QACD,OAAO;YACN;gBACC,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,OAAO,EAAE,GAAG,QAAQ,CAAC,IAAI,CAAC,iBAAiB,SAAS,CAAC,MAAM,aAAa,IAAI,CAAC,SAAS,MAAM,SAAS,CAAC,MAAM,EAAE;gBAC9G,OAAO,EAAE,IAAI,CAAC,SAAS;aACvB;SACD,CAAC;IACH,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,MAAM,CAAC,MAAM,cAAc,GAAG,UAAU,CAAC;IACxC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CACjB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QACnB,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;QACzC,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QAClG,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,SAAS,CAAC,MAAM,EAAE,KAAK,CAAC,QAAQ,EAAE,cAAc,CAAC,CAAC;QACzE,MAAM,UAAU,GAAG,EAAE,cAAc,EAAE,OAAO,EAAE,CAAC;QAC/C,MAAM,OAAO,GAAG,CAAC,GAAG,eAAe,CAAC,KAAK,EAAE,UAAU,CAAC,EAAE,GAAG,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAC,CAAC;QACxG,MAAM,YAAY,GAAG,CAAC,KAAK,CAAC,CAAC,0BAA0B,CAAC,MAAM,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,EAAE,SAAS,EAAE,OAAO,EAAE,EAAE,EAAE,CAAC,CAAC;YACjH,IAAI,EAAE,SAAS,KAAK,GAAG,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,GAAG,SAAS,eAAe;YACtE,IAAI,EAAE,CAAC;YACP,OAAO;YACP,OAAO,EAAE,iBAAiB;SAC1B,CAAC,CAAC,CAAC;QACJ,MAAM,MAAM,GAAG,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,QAAQ,CAAC,CAAC;QAC1G,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzB,OAAO,CAAC,GAAG,OAAO,EAAE,GAAG,YAAY,CAAC,CAAC;QACtC,CAAC;QACD,MAAM,EAAE,cAAc,EAAE,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,4BAA4B,CAAC,CAAC,CAAC;QAC7F,OAAO,CAAC,GAAG,OAAO,EAAE,GAAG,YAAY,EAAE,GAAG,CAAC,KAAK,CAAC,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;IAC1E,CAAC,CAAC;IACH,WAAW,EACV,oUAAoU;IACrU,EAAE,EAAE,iBAAiB;CACrB,CAAC,CAAC"}
@@ -0,0 +1,2 @@
1
+ export declare const rawServers: import("#rule.ts").Rule<"tests/raw-servers", undefined, never>;
2
+ //# sourceMappingURL=rawServers.d.ts.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"rawServers.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/rawServers.ts"],"names":[],"mappings":"AAgHA,eAAO,MAAM,UAAU,gEAKrB,CAAC"}
@@ -0,0 +1,100 @@
1
+ import ts from "typescript";
2
+ import { isTestSupport } from "#naming/testName.ts";
3
+ import { defineRule } from "#rule.ts";
4
+ import { parse } from "#rules/parse.ts";
5
+ import { importBindings } from "#rules/stories/importBindings.ts";
6
+ import { memberName, nodesWhere, unwrapped } from "#rules/stories/syntax.ts";
7
+ const SERVER_MODULES = new Set(["http", "https", "net"]);
8
+ const CONSTRUCTORS = new Map([
9
+ ["createServer", ts.SyntaxKind.CallExpression],
10
+ ["Server", ts.SyntaxKind.NewExpression],
11
+ ]);
12
+ const HELPERS = "loopbackServer from @shivaedev/test-story/server/adapters/loopback.ts, which listens on a loopback port and closes it with the story's scope, or fake an outside HTTP API with fakeHttpService from @shivaedev/test-story/server/fakeHttpService.ts.";
13
+ const REPAIR = `Hand the server to ${HELPERS}`;
14
+ const NET_REPAIR = `For a free port or a listening endpoint, hand a node:http server to ${HELPERS}`;
15
+ function serverModule(binding) {
16
+ const name = binding?.module.replace(/^node:/u, "");
17
+ return name !== undefined && SERVER_MODULES.has(name) ? `node:${name}` : undefined;
18
+ }
19
+ function isConstruction(node) {
20
+ return ts.isCallExpression(node) || ts.isNewExpression(node);
21
+ }
22
+ function constructedFrom(node, bindings) {
23
+ const callee = unwrapped(node.expression);
24
+ if (ts.isIdentifier(callee)) {
25
+ const binding = bindings.get(callee.text);
26
+ return binding !== undefined && CONSTRUCTORS.get(binding.imported) === node.kind ? serverModule(binding) : undefined;
27
+ }
28
+ const receiver = ts.isPropertyAccessExpression(callee) ? unwrapped(callee.expression) : undefined;
29
+ const binding = receiver !== undefined && ts.isIdentifier(receiver) ? bindings.get(receiver.text) : undefined;
30
+ return CONSTRUCTORS.get(memberName(callee) ?? "") === node.kind ? serverModule(binding) : undefined;
31
+ }
32
+ function outermost(node) {
33
+ const parent = node.parent;
34
+ const wraps = ts.isParenthesizedExpression(parent)
35
+ || ts.isAsExpression(parent)
36
+ || ts.isSatisfiesExpression(parent)
37
+ || ts.isNonNullExpression(parent)
38
+ || ts.isAwaitExpression(parent);
39
+ return wraps ? outermost(parent) : node;
40
+ }
41
+ function boundName(node) {
42
+ const parent = node.parent;
43
+ if (ts.isVariableDeclaration(parent) && parent.initializer === node && ts.isIdentifier(parent.name)) {
44
+ return parent.name.text;
45
+ }
46
+ const assigned = ts.isBinaryExpression(parent) && parent.operatorToken.kind === ts.SyntaxKind.EqualsToken && parent.right === node;
47
+ return assigned && ts.isIdentifier(parent.left) ? parent.left.text : undefined;
48
+ }
49
+ // A node:net server that handles its own sockets speaks a protocol other than HTTP, which neither shared helper serves.
50
+ function handlesSockets(created) {
51
+ return (created.arguments ?? [])
52
+ .map(unwrapped)
53
+ .some((value) => ts.isArrowFunction(value) || ts.isFunctionExpression(value) || ts.isIdentifier(value));
54
+ }
55
+ function socketPath(argument) {
56
+ const value = argument === undefined ? undefined : unwrapped(argument);
57
+ if (value === undefined || !ts.isObjectLiteralExpression(value)) {
58
+ return value !== undefined && (ts.isStringLiteralLike(value) || ts.isTemplateExpression(value));
59
+ }
60
+ return value.properties.some((property) => property.name !== undefined && ts.isIdentifier(property.name) && property.name.text === "path");
61
+ }
62
+ // loopbackServer serves a loopback TCP port, so a server listening on a Unix socket or pipe path has no shared replacement.
63
+ function portListeners(source) {
64
+ return nodesWhere(source, (node) => ts.isCallExpression(node) && memberName(node.expression) === "listen" && !socketPath(node.arguments[0])).flatMap((call) => {
65
+ const callee = ts.isCallExpression(call) ? unwrapped(call.expression) : undefined;
66
+ return callee !== undefined && ts.isPropertyAccessExpression(callee) ? [unwrapped(callee.expression)] : [];
67
+ });
68
+ }
69
+ function findings(file) {
70
+ const source = isTestSupport(file.path) && file.text.includes("listen") ? parse(file) : undefined;
71
+ if (source === undefined) {
72
+ return [];
73
+ }
74
+ const bindings = importBindings(source);
75
+ const listeners = portListeners(source);
76
+ const names = new Set(listeners.flatMap((listener) => (ts.isIdentifier(listener) ? [listener.text] : [])));
77
+ return nodesWhere(source, isConstruction)
78
+ .filter(isConstruction)
79
+ .flatMap((created) => {
80
+ const module = constructedFrom(created, bindings);
81
+ const name = boundName(outermost(created));
82
+ const listened = listeners.includes(created) || (name !== undefined && names.has(name));
83
+ if (module === undefined || !listened || (module === "node:net" && handlesSockets(created))) {
84
+ return [];
85
+ }
86
+ return [
87
+ {
88
+ file: file.path,
89
+ line: source.getLineAndCharacterOfPosition(created.getStart(source)).line + 1,
90
+ message: `Starts a ${module} server with listen in test-support. ${module === "node:net" ? NET_REPAIR : REPAIR}`,
91
+ },
92
+ ];
93
+ });
94
+ }
95
+ export const rawServers = defineRule({
96
+ check: ({ sources }) => sources.flatMap(findings),
97
+ description: "Test-support listens on no loopback port with a node:http, node:https or node:net server of its own: hand a Node HTTP server to test-story's loopbackServer, or fake an outside HTTP API with fakeHttpService. Unix socket listeners and node:net servers that handle their own sockets are accepted.",
98
+ id: "tests/raw-servers",
99
+ });
100
+ //# sourceMappingURL=rawServers.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"rawServers.js","sourceRoot":"","sources":["../../../src/rules/stories/rawServers.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAE,KAAK,EAAE,MAAM,iBAAiB,CAAC;AACxC,OAAO,EAAsB,cAAc,EAAE,MAAM,kCAAkC,CAAC;AACtF,OAAO,EAAE,UAAU,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,0BAA0B,CAAC;AAE7E,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC,CAAC,MAAM,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;AACzD,MAAM,YAAY,GAAuC,IAAI,GAAG,CAAC;IAChE,CAAC,cAAc,EAAE,EAAE,CAAC,UAAU,CAAC,cAAc,CAAC;IAC9C,CAAC,QAAQ,EAAE,EAAE,CAAC,UAAU,CAAC,aAAa,CAAC;CACvC,CAAC,CAAC;AACH,MAAM,OAAO,GACZ,sPAAsP,CAAC;AACxP,MAAM,MAAM,GAAG,sBAAsB,OAAO,EAAE,CAAC;AAC/C,MAAM,UAAU,GAAG,uEAAuE,OAAO,EAAE,CAAC;AAEpG,SAAS,YAAY,CAAC,OAAkC;IACvD,MAAM,IAAI,GAAG,OAAO,EAAE,MAAM,CAAC,OAAO,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;IACpD,OAAO,IAAI,KAAK,SAAS,IAAI,cAAc,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,QAAQ,IAAI,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;AACpF,CAAC;AAID,SAAS,cAAc,CAAC,IAAa;IACpC,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;AAC9D,CAAC;AAED,SAAS,eAAe,CAAC,IAAkB,EAAE,QAA4C;IACxF,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC1C,OAAO,OAAO,KAAK,SAAS,IAAI,YAAY,CAAC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,KAAK,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACtH,CAAC;IACD,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,MAAM,OAAO,GAAG,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAC9G,OAAO,YAAY,CAAC,GAAG,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,KAAK,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;AACrG,CAAC;AAED,SAAS,SAAS,CAAC,IAAa;IAC/B,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;IAC3B,MAAM,KAAK,GACV,EAAE,CAAC,yBAAyB,CAAC,MAAM,CAAC;WACjC,EAAE,CAAC,cAAc,CAAC,MAAM,CAAC;WACzB,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC;WAChC,EAAE,CAAC,mBAAmB,CAAC,MAAM,CAAC;WAC9B,EAAE,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;IACjC,OAAO,KAAK,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AACzC,CAAC;AAED,SAAS,SAAS,CAAC,IAAa;IAC/B,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;IAC3B,IAAI,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,WAAW,KAAK,IAAI,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;QACrG,OAAO,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC;IACzB,CAAC;IACD,MAAM,QAAQ,GAAG,EAAE,CAAC,kBAAkB,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,aAAa,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,WAAW,IAAI,MAAM,CAAC,KAAK,KAAK,IAAI,CAAC;IACnI,OAAO,QAAQ,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;AAChF,CAAC;AAED,wHAAwH;AACxH,SAAS,cAAc,CAAC,OAAqB;IAC5C,OAAO,CAAC,OAAO,CAAC,SAAS,IAAI,EAAE,CAAC;SAC9B,GAAG,CAAC,SAAS,CAAC;SACd,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,EAAE,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,KAAK,CAAC,CAAC,CAAC;AAC1G,CAAC;AAED,SAAS,UAAU,CAAC,QAAmC;IACtD,MAAM,KAAK,GAAG,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC;IACvE,IAAI,KAAK,KAAK,SAAS,IAAI,CAAC,EAAE,CAAC,yBAAyB,CAAC,KAAK,CAAC,EAAE,CAAC;QACjE,OAAO,KAAK,KAAK,SAAS,IAAI,CAAC,EAAE,CAAC,mBAAmB,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,KAAK,CAAC,CAAC,CAAC;IACjG,CAAC;IACD,OAAO,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,IAAI,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC;AAC5I,CAAC;AAED,4HAA4H;AAC5H,SAAS,aAAa,CAAC,MAAqB;IAC3C,OAAO,UAAU,CAChB,MAAM,EACN,CAAC,IAAI,EAAE,EAAE,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,QAAQ,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CACjH,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QAClB,MAAM,MAAM,GAAG,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAClF,OAAO,MAAM,KAAK,SAAS,IAAI,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;IAC5G,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,SAAS,QAAQ,CAAC,IAAgB;IACjC,MAAM,MAAM,GAAG,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;QAC1B,OAAO,EAAE,CAAC;IACX,CAAC;IACD,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,SAAS,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,KAAK,GAAG,IAAI,GAAG,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IAC3G,OAAO,UAAU,CAAC,MAAM,EAAE,cAAc,CAAC;SACvC,MAAM,CAAC,cAAc,CAAC;SACtB,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE;QACpB,MAAM,MAAM,GAAG,eAAe,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;QAClD,MAAM,IAAI,GAAG,SAAS,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC;QAC3C,MAAM,QAAQ,GAAG,SAAS,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,KAAK,SAAS,IAAI,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;QACxF,IAAI,MAAM,KAAK,SAAS,IAAI,CAAC,QAAQ,IAAI,CAAC,MAAM,KAAK,UAAU,IAAI,cAAc,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC;YAC7F,OAAO,EAAE,CAAC;QACX,CAAC;QACD,OAAO;YACN;gBACC,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,IAAI,EAAE,MAAM,CAAC,6BAA6B,CAAC,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC;gBAC7E,OAAO,EAAE,YAAY,MAAM,wCAAwC,MAAM,KAAK,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,MAAM,EAAE;aAChH;SACD,CAAC;IACH,CAAC,CAAC,CAAC;AACL,CAAC;AAED,MAAM,CAAC,MAAM,UAAU,GAAG,UAAU,CAAC;IACpC,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,QAAQ,CAAC;IACjD,WAAW,EACV,uSAAuS;IACxS,EAAE,EAAE,mBAAmB;CACvB,CAAC,CAAC"}
@@ -10,7 +10,7 @@ Quality exists to make that decision once. A repository adopts Quality's opinion
10
10
 
11
11
  A consuming repository gets the whole policy. It does not select a preset of standards, turn a Quality rule off or demote it to a warning. Quality decides which checks belong together and explains their repairs. Internal exceptions belong to the package and have reasons; they are part of its judgement, not a template of switches for consumers to copy.
12
12
 
13
- The repository supplies facts Quality cannot infer: where the source and generated files live, which architectural boundaries its imports must respect, and which additional commands a commit must run. Shared Biome and TypeScript configuration and Vitest helpers carry the package's conventions into those tools. The usual setup should stay small, with defaults that make sense together.
13
+ The repository supplies facts Quality cannot infer: where the source files live, which architectural boundaries its imports must respect, and which additional commands a commit must run. Shared Biome and TypeScript configuration and Vitest helpers carry the package's conventions into those tools. The usual setup should stay small, with defaults that make sense together.
14
14
 
15
15
  Adopting the whole policy does not require fixing all old debt in one change. The baseline records existing findings by rule and file while the checks stay strict. An uncovered finding asks for a repair. Fixing debt passes immediately, and lowering tools reduce its recorded counts. A permitted permanent exception lives in the config with a reason, once for both Quality and Biome. When that exception no longer applies, the gate asks for its removal.
16
16
 
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@shivaedev/quality",
3
- "version": "0.77.0",
3
+ "version": "0.78.1",
4
4
  "description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
5
5
  "homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
6
6
  "bugs": {
@@ -56,7 +56,7 @@
56
56
  "@shivaedev/errors": "0.12.0",
57
57
  "@shivaedev/heavy-lock": "0.11.2",
58
58
  "@shivaedev/service": "0.9.1",
59
- "@shivaedev/skills": "0.9.1",
59
+ "@shivaedev/skills": "0.9.2",
60
60
  "@vitest/coverage-v8": "5.1.0",
61
61
  "browserslist": "4.29.5",
62
62
  "ignore": "7.0.14",
@@ -68,7 +68,7 @@
68
68
  "@effect/platform-node": "4.1.2",
69
69
  "@effect/platform-node-shared": "4.1.2",
70
70
  "@effect/vitest": "4.1.2",
71
- "@shivaedev/test-story": "0.47.0",
71
+ "@shivaedev/test-story": "0.47.2",
72
72
  "@types/node": "24.19.2",
73
73
  "@typescript/native": "npm:typescript@7.0.2",
74
74
  "effect": "4.1.2",
@@ -77,7 +77,7 @@
77
77
  "peerDependencies": {
78
78
  "@effect/platform-node": "4.1.2",
79
79
  "@effect/platform-node-shared": "4.1.2",
80
- "@shivaedev/test-story": "0.47.0",
80
+ "@shivaedev/test-story": "0.47.2",
81
81
  "effect": "4.1.2",
82
82
  "vitest": "5.1.0"
83
83
  },
@@ -1,4 +1,5 @@
1
1
  import ts from "typescript";
2
+ import { presenceCheck } from "#adapters/presenceCheck.ts";
2
3
  import { declarationOf, resolvedValue } from "#adapters/serviceModelSyntax.ts";
3
4
 
4
5
  const RPC_MIDDLEWARE = "~effect/rpc/RpcMiddleware";
@@ -124,6 +125,9 @@ export function declarationTagParameter(checker: ts.TypeChecker, carries: (type:
124
125
  if (ts.isVariableDeclaration(value.parent) && value.parent.initializer === value) {
125
126
  return onlyDeclared(body, value.parent.name, seen);
126
127
  }
128
+ if (presenceCheck(checker, value)) {
129
+ return true;
130
+ }
127
131
  const declaration = declares(value);
128
132
  seen.declared ||= declaration;
129
133
  return declaration;
@@ -1,4 +1,4 @@
1
- import { realpathSync } from "node:fs";
1
+ import { existsSync, realpathSync } from "node:fs";
2
2
  import { createRequire } from "node:module";
3
3
  import { dirname, join, relative } from "node:path";
4
4
  import ts from "typescript";
@@ -82,13 +82,39 @@ function resolvedPath(request: ImportRequest, from: string, project: Project): s
82
82
  return path === undefined ? undefined : fitting(path, request.type);
83
83
  }
84
84
 
85
+ // A package import of a missing file names a path in the repository when a workspace link leads there, outside installed packages.
86
+ function linkedTarget(root: string, path: string): string | undefined {
87
+ if (!path.includes(NODE_MODULES)) {
88
+ return undefined;
89
+ }
90
+ let folder = dirname(path);
91
+ while (!existsSync(folder) && dirname(folder) !== folder) {
92
+ folder = dirname(folder);
93
+ }
94
+ const target = posix(relative(realpathSync(root), join(realpathSync(folder), relative(folder, path))));
95
+ return target.startsWith("../") || target.split("/").includes("node_modules") ? undefined : target;
96
+ }
97
+
98
+ function workspaceHost(root: string): ts.ModuleResolutionHost {
99
+ return {
100
+ ...ts.sys,
101
+ fileExists: (path) => ts.sys.fileExists(path) || (!path.endsWith(`/${PACKAGE_JSON}`) && linkedTarget(root, path) !== undefined),
102
+ };
103
+ }
104
+
85
105
  export function presumedTarget(root: string, request: ImportRequest, from: string, project: Project): string | undefined {
86
- if (request.kind !== "import" || !request.specifier.startsWith(PACKAGE_IMPORT)) {
106
+ const specifier = request.specifier.replace(QUERY, "");
107
+ if (request.kind !== "import" || specifier.startsWith(".") || specifier.startsWith("/")) {
87
108
  return undefined;
88
109
  }
89
- const path = ts.resolveModuleName(request.specifier.replace(QUERY, ""), from, project.options, presumingHost, undefined, undefined, request.mode)
90
- .resolvedModule?.resolvedFileName;
91
- return path === undefined ? undefined : posix(relative(root, path));
110
+ if (specifier.startsWith(PACKAGE_IMPORT)) {
111
+ const path = ts.resolveModuleName(specifier, from, project.options, presumingHost, undefined, undefined, request.mode).resolvedModule
112
+ ?.resolvedFileName;
113
+ return path === undefined ? undefined : posix(relative(root, path));
114
+ }
115
+ const path = ts.resolveModuleName(specifier, from, project.options, workspaceHost(root), undefined, undefined, request.mode).resolvedModule
116
+ ?.resolvedFileName;
117
+ return path === undefined ? undefined : linkedTarget(root, path);
92
118
  }
93
119
 
94
120
  function endpointAt(root: string, specifier: string, path: string): Endpoint {
@@ -0,0 +1,17 @@
1
+ import ts from "typescript";
2
+
3
+ export function presenceCheck(checker: ts.TypeChecker, value: ts.Expression): boolean {
4
+ const comparison = value.parent;
5
+ if (!ts.isBinaryExpression(comparison)) {
6
+ return false;
7
+ }
8
+ const operator = comparison.operatorToken.kind;
9
+ const other = comparison.left === value ? comparison.right : comparison.left;
10
+ return (
11
+ (operator === ts.SyntaxKind.EqualsEqualsEqualsToken
12
+ || operator === ts.SyntaxKind.ExclamationEqualsEqualsToken
13
+ || operator === ts.SyntaxKind.EqualsEqualsToken
14
+ || operator === ts.SyntaxKind.ExclamationEqualsToken)
15
+ && (checker.getTypeAtLocation(other).flags & (ts.TypeFlags.Undefined | ts.TypeFlags.Null)) !== 0
16
+ );
17
+ }
@@ -0,0 +1,32 @@
1
+ import { Effect, Option, Stream } from "effect";
2
+ import { ChildProcess, ChildProcessSpawner } from "effect/process";
3
+ import { HeldLock } from "@shivaedev/heavy-lock/HeldLock.ts";
4
+ import { projectScripts } from "#engine/projectScripts.ts";
5
+ import { SetupFailure } from "#failure.ts";
6
+
7
+ const SCRIPT = "generate";
8
+
9
+ // Generated files are not committed, so the project writes them before any rule reads an import of them; a run holding the heavy lock lends it to the generator. An unreadable manifest names no script, and manifests/valid reports it.
10
+ export const generateFirst = Effect.fn("Engine.generateFirst")(
11
+ function* (root: string) {
12
+ const project = yield* projectScripts(root, [SCRIPT]).pipe(
13
+ Effect.catchTags({ FilesystemFailure: () => Effect.undefined, ManifestFailure: () => Effect.undefined }),
14
+ );
15
+ if (project === undefined || project.scripts.length === 0) {
16
+ return;
17
+ }
18
+ const { manager } = project;
19
+ const held = yield* Effect.serviceOption(HeldLock);
20
+ const env = Option.match(held, { onNone: () => ({}), onSome: (lock) => lock.env });
21
+ const spawner = yield* ChildProcessSpawner.ChildProcessSpawner;
22
+ const child = yield* spawner.spawn(ChildProcess.make(manager, ["run", SCRIPT], { cwd: root, env, extendEnv: true, stdin: "ignore" }));
23
+ const [output, code] = yield* Effect.all([Stream.mkString(Stream.decodeText(child.all)), child.exitCode], { concurrency: "unbounded" });
24
+ if (Number(code) !== 0) {
25
+ return yield* new SetupFailure({
26
+ message: `\`${manager} run ${SCRIPT}\` failed (exit ${code}) before Quality read the sources:\n${output.trimEnd()}`,
27
+ });
28
+ }
29
+ },
30
+ Effect.scoped,
31
+ Effect.catchTag("PlatformError", (cause) => new SetupFailure({ cause, message: `cannot run the project's ${SCRIPT} script: ${cause.message}` })),
32
+ );
@@ -0,0 +1,25 @@
1
+ import * as NodePath from "@effect/platform-node/NodePath";
2
+ import { Effect, Path } from "effect";
3
+ import { readPackageManifest } from "#adapters/manifestInventory.ts";
4
+ import { manifestReader } from "#adapters/manifestReader.ts";
5
+ import { SetupFailure } from "#failure.ts";
6
+
7
+ export interface ProjectScripts {
8
+ readonly manager: string;
9
+ readonly scripts: readonly string[];
10
+ }
11
+
12
+ const MANAGERS = ["npm", "pnpm", "yarn", "bun"];
13
+
14
+ export const projectScripts = Effect.fn("Engine.projectScripts")(function* (root: string, wanted: readonly string[]) {
15
+ const { join } = yield* Path.Path.pipe(Effect.provide(NodePath.layer));
16
+
17
+ const file = join(root, "package.json");
18
+ const manifest = yield* readPackageManifest(yield* manifestReader(root), file);
19
+ const scripts = wanted.filter((script) => manifest?.scripts?.[script] !== undefined);
20
+ const manager = manifest?.packageManager?.split("@")[0] ?? "npm";
21
+ if (scripts.length > 0 && !MANAGERS.includes(manager)) {
22
+ return yield* new SetupFailure({ message: `${file}: unsupported packageManager "${manager}". Use npm, pnpm, yarn or bun.` });
23
+ }
24
+ return { manager, scripts } satisfies ProjectScripts;
25
+ });
@@ -5,6 +5,7 @@ import { manifestReader } from "#adapters/manifestReader.ts";
5
5
  import { typeScriptProgram } from "#adapters/typeScriptProgram.ts";
6
6
  import { loadConfig, type ResolvedConfig } from "#config/load.ts";
7
7
  import { type BaselineFile, readBaseline, readInput } from "#engine/baselineFile.ts";
8
+ import { generateFirst } from "#engine/generateFirst.ts";
8
9
  import { runRules } from "#engine/runRules.ts";
9
10
  import type { Violation } from "#engine/violation.ts";
10
11
  import { biomeExceptions } from "#exceptions/biomeFindings.ts";
@@ -83,6 +84,7 @@ export const openSession = Effect.fn("Engine.openSession")(function* (
83
84
  }
84
85
  }
85
86
  const baseline = yield* readBaseline(config);
87
+ yield* generateFirst(config.root);
86
88
  const scanned = yield* scan(config);
87
89
  return { ...scanned, baseline, config, registry: registryEntries(config.exceptions) };
88
90
  });
@@ -1,11 +1,10 @@
1
- import * as NodePath from "@effect/platform-node/NodePath";
2
- import { Config, Console, Effect, Path } from "effect";
1
+ import { Config, Console, Effect } from "effect";
3
2
  import { ChildProcess, ChildProcessSpawner } from "effect/process";
4
- import { readPackageManifest } from "#adapters/manifestInventory.ts";
5
- import { manifestReader } from "#adapters/manifestReader.ts";
3
+ import type { ManifestReadFailure } from "#adapters/manifestInventory.ts";
6
4
  import { reportLint } from "#cli/lint.ts";
7
5
  import { loadConfig } from "#config/load.ts";
8
6
  import { passes } from "#engine/evaluate.ts";
7
+ import { projectScripts } from "#engine/projectScripts.ts";
9
8
  import { GateFailed, SetupFailure } from "#failure.ts";
10
9
  import { stagedCheck } from "#hooks/stagedCheck.ts";
11
10
  import { recap } from "#report/recap.ts";
@@ -13,25 +12,6 @@ import { recap } from "#report/recap.ts";
13
12
  const COMMIT_AGAIN =
14
13
  "help: fix what the output above reports, then commit again; `quality hooks pre-commit` repeats these checks without committing.";
15
14
 
16
- const commitScripts = Effect.fnUntraced(function* (root: string) {
17
- const { join } = yield* Path.Path.pipe(Effect.provide(NodePath.layer));
18
-
19
- const file = join(root, "package.json");
20
- const readText = yield* manifestReader(root);
21
- const manifest = yield* Effect.mapError(
22
- readPackageManifest(readText, file),
23
- (cause) => new SetupFailure({ cause, message: `${file} is invalid: ${cause.message}` }),
24
- );
25
- if (manifest === undefined) {
26
- return { manager: "npm", scripts: [] };
27
- }
28
- const manager = manifest.packageManager?.split("@")[0] ?? "npm";
29
- if (!["npm", "pnpm", "yarn", "bun"].includes(manager)) {
30
- return yield* new SetupFailure({ message: `${file}: unsupported packageManager "${manager}". Use npm, pnpm, yarn or bun.` });
31
- }
32
- return { manager, scripts: ["typecheck", "quality:commit"].filter((script) => manifest.scripts?.[script] !== undefined) };
33
- });
34
-
35
15
  const runScript = Effect.fnUntraced(
36
16
  function* (root: string, manager: string, script: string) {
37
17
  const spawner = yield* ChildProcessSpawner.ChildProcessSpawner;
@@ -44,6 +24,10 @@ const runScript = Effect.fnUntraced(
44
24
  Effect.mapError((error) => new SetupFailure({ cause: error, message: `cannot run a pre-commit script: ${error.message}` })),
45
25
  );
46
26
 
27
+ function invalidManifest(cause: ManifestReadFailure) {
28
+ return new SetupFailure({ cause, message: `${cause.path} is invalid: ${cause.message}` });
29
+ }
30
+
47
31
  const inCloudSession = Config.String("CLAUDE_CODE_REMOTE").pipe(
48
32
  Config.withDefault(""),
49
33
  Config.map((value) => value === "true"),
@@ -59,7 +43,9 @@ export const preCommitHook = Effect.fn("Hooks.preCommitHook")(function* (cwd: st
59
43
  }
60
44
  return;
61
45
  }
62
- const { manager, scripts } = yield* commitScripts(config.root);
46
+ const { manager, scripts } = yield* projectScripts(config.root, ["typecheck", "quality:commit"]).pipe(
47
+ Effect.catchTags({ FilesystemFailure: invalidManifest, ManifestFailure: invalidManifest }),
48
+ );
63
49
  const { context, outcome } = yield* reportLint(cwd, path, true);
64
50
  const linted = passes(outcome);
65
51
  const failed = linted ? [] : ["quality lint"];
@@ -0,0 +1,43 @@
1
+ import ts from "typescript";
2
+ import type { SourceFile } from "#rule.ts";
3
+ import { parse } from "#rules/parse.ts";
4
+
5
+ const DEFINE_MODULE = "@shivaedev/contract/defineModule.ts";
6
+
7
+ function definers(source: ts.SourceFile): ReadonlySet<string> {
8
+ return new Set(
9
+ source.statements.filter(ts.isImportDeclaration).flatMap((statement) => {
10
+ const clause = statement.importClause;
11
+ const bindings = clause?.namedBindings;
12
+ if (
13
+ clause === undefined
14
+ || clause.isTypeOnly
15
+ || bindings === undefined
16
+ || !ts.isNamedImports(bindings)
17
+ || !(ts.isStringLiteral(statement.moduleSpecifier) && statement.moduleSpecifier.text === DEFINE_MODULE)
18
+ ) {
19
+ return [];
20
+ }
21
+ return bindings.elements
22
+ .filter((element) => !element.isTypeOnly && (element.propertyName ?? element.name).text === "defineModule")
23
+ .map((element) => element.name.text);
24
+ }),
25
+ );
26
+ }
27
+
28
+ export function callsDefineModule(file: SourceFile): boolean {
29
+ const source = file.text.includes("defineModule") ? parse(file) : undefined;
30
+ const names = source === undefined ? new Set<string>() : definers(source);
31
+ if (source === undefined || names.size === 0) {
32
+ return false;
33
+ }
34
+ let found = false;
35
+ function visit(node: ts.Node): void {
36
+ found ||= ts.isCallExpression(node) && ts.isIdentifier(node.expression) && names.has(node.expression.text);
37
+ if (!found) {
38
+ ts.forEachChild(node, visit);
39
+ }
40
+ }
41
+ visit(source);
42
+ return found;
43
+ }
@@ -2,6 +2,7 @@ import { Effect } from "effect";
2
2
  import { compilePolicy } from "#imports/fences/compilePolicy.ts";
3
3
  import { discoverFences } from "#imports/fences/discover.ts";
4
4
  import type { Fence } from "#imports/fences/model.ts";
5
+ import { followedEdges, generatedFolders } from "#imports/generatedFolders.ts";
5
6
  import { importGraph } from "#imports/graph.ts";
6
7
  import type { RuleInputs } from "#rule.ts";
7
8
 
@@ -9,5 +10,6 @@ export const checkFences = Effect.fn("Imports.checkFences")(function* (inputs: R
9
10
  const graph = yield* importGraph(inputs);
10
11
  const fences = [...configured, ...(yield* discoverFences(inputs, graph.packages))];
11
12
  const policy = yield* Effect.fromResult(compilePolicy(fences, { files: inputs.files, packages: graph.packages }));
12
- return policy.flatMap((compiled) => compiled.evaluate(graph));
13
+ const followed = { ...graph, ignoredEdges: followedEdges(generatedFolders(graph.packages), graph.ignoredEdges) };
14
+ return policy.flatMap((compiled) => compiled.evaluate(followed));
13
15
  });
@@ -0,0 +1,28 @@
1
+ import { posix } from "node:path";
2
+ import type { ImportEdge } from "#imports/graph.ts";
3
+ import type { WorkspacePackage } from "#imports/workspace.ts";
4
+
5
+ const GENERATED = "src/generated";
6
+
7
+ // The generator of @shivaedev/build writes each project's output to src/generated, at the application root and in every workspace package.
8
+ export function generatedFolders(packages: readonly WorkspacePackage[]): readonly string[] {
9
+ return [GENERATED, ...packages.map((owner) => posix.join(owner.directory, GENERATED))];
10
+ }
11
+
12
+ function generatedFolderOf(folders: readonly string[], path: string): string | undefined {
13
+ return folders.find((folder) => path.startsWith(`${folder}/`));
14
+ }
15
+
16
+ export function generatedFrom(folders: readonly string[], path: string): string | undefined {
17
+ const folder = generatedFolderOf(folders, path);
18
+ return folder === undefined ? undefined : posix.join(posix.dirname(folder), path.slice(folder.length + 1));
19
+ }
20
+
21
+ // A generated client type-imports its module so the compiler checks they match; the import is erased.
22
+ export function ownModuleTypeImport(folders: readonly string[], edge: ImportEdge): boolean {
23
+ return edge.type && edge.to.kind === "file" && generatedFrom(folders, edge.from) === edge.to.path;
24
+ }
25
+
26
+ export function followedEdges(folders: readonly string[], edges: readonly ImportEdge[]): readonly ImportEdge[] {
27
+ return edges.filter((edge) => !ownModuleTypeImport(folders, edge));
28
+ }
@@ -84,7 +84,12 @@ export const runtimeDeclarationProblems = Effect.fn("Imports.runtimeDeclarationP
84
84
  return problems.flat();
85
85
  });
86
86
 
87
- export const runtimeOf = Effect.fn("Imports.runtimeOf")(function* (inputs: RuleInputs, packages: readonly WorkspacePackage[]) {
87
+ // A defined module holds the run of each operation, so it is server code wherever it sits.
88
+ export const runtimeOf = Effect.fn("Imports.runtimeOf")(function* (
89
+ inputs: RuleInputs,
90
+ packages: readonly WorkspacePackage[],
91
+ definedModules: ReadonlySet<string>,
92
+ ) {
88
93
  const owners = [...packages, { directory: ".", name: "." }];
89
94
  const manifests = new Map(
90
95
  yield* Effect.forEach(owners, (owner) =>
@@ -104,5 +109,5 @@ export const runtimeOf = Effect.fn("Imports.runtimeOf")(function* (inputs: RuleI
104
109
  );
105
110
  const executable = new Set(owners.filter((owner) => hasExecutable(manifests.get(owner.directory))).map((owner) => owner.directory));
106
111
  const policy = { adopted, declared, executable, packages };
107
- return (path: string) => classifyRuntime(policy, path);
112
+ return (path: string): Runtime | undefined => (definedModules.has(path) ? "server" : classifyRuntime(policy, path));
108
113
  });