@shivaedev/quality 0.76.0 → 0.78.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +80 -0
- package/README.md +66 -64
- package/dist/adapters/biome/pluginContract.d.ts +1 -1
- package/dist/adapters/biome/pluginContract.d.ts.map +1 -1
- package/dist/adapters/biome/pluginContract.js +2 -5
- package/dist/adapters/biome/pluginContract.js.map +1 -1
- package/dist/adapters/biome/run.d.ts.map +1 -1
- package/dist/adapters/biome/run.js +2 -0
- package/dist/adapters/biome/run.js.map +1 -1
- package/dist/adapters/biome/withExceptionConfig.d.ts.map +1 -1
- package/dist/adapters/biome/withExceptionConfig.js +21 -4
- package/dist/adapters/biome/withExceptionConfig.js.map +1 -1
- package/dist/adapters/changeKeyCheck.d.ts +10 -0
- package/dist/adapters/changeKeyCheck.d.ts.map +1 -0
- package/dist/adapters/{changeKeyFindings.js → changeKeyCheck.js} +8 -22
- package/dist/adapters/changeKeyCheck.js.map +1 -0
- package/dist/adapters/commandLine.d.ts +2 -0
- package/dist/adapters/commandLine.d.ts.map +1 -1
- package/dist/adapters/contextCaptureCheck.d.ts +9 -0
- package/dist/adapters/contextCaptureCheck.d.ts.map +1 -0
- package/dist/adapters/contextCaptureCheck.js +91 -0
- package/dist/adapters/contextCaptureCheck.js.map +1 -0
- package/dist/adapters/databaseUrlFindings.d.ts +1 -1
- package/dist/adapters/databaseUrlFindings.d.ts.map +1 -1
- package/dist/adapters/declaration-files/initialize.d.ts +6 -0
- package/dist/adapters/declaration-files/initialize.d.ts.map +1 -0
- package/dist/adapters/declaration-files/initialize.js +4 -0
- package/dist/adapters/declaration-files/initialize.js.map +1 -0
- package/dist/adapters/declaration-files/parse.d.ts +5 -0
- package/dist/adapters/declaration-files/parse.d.ts.map +1 -0
- package/dist/adapters/declaration-files/parse.js +6 -0
- package/dist/adapters/declaration-files/parse.js.map +1 -0
- package/dist/adapters/declaration-files/reader.d.ts +5 -0
- package/dist/adapters/declaration-files/reader.d.ts.map +1 -0
- package/dist/adapters/declaration-files/reader.js +23 -0
- package/dist/adapters/declaration-files/reader.js.map +1 -0
- package/dist/adapters/declaration-files/service.d.ts +9 -0
- package/dist/adapters/declaration-files/service.d.ts.map +1 -0
- package/dist/adapters/declaration-files/service.js +14 -0
- package/dist/adapters/declaration-files/service.js.map +1 -0
- package/dist/adapters/declarationTagParameter.d.ts.map +1 -1
- package/dist/adapters/declarationTagParameter.js +4 -0
- package/dist/adapters/declarationTagParameter.js.map +1 -1
- package/dist/adapters/foreignResources.d.ts.map +1 -1
- package/dist/adapters/foreignResources.js +0 -4
- package/dist/adapters/foreignResources.js.map +1 -1
- package/dist/adapters/import-compiler/graph.d.ts +8 -2
- package/dist/adapters/import-compiler/graph.d.ts.map +1 -1
- package/dist/adapters/import-compiler/graph.js +4 -1
- package/dist/adapters/import-compiler/graph.js.map +1 -1
- package/dist/adapters/import-compiler/service.d.ts +7 -1
- package/dist/adapters/import-compiler/service.d.ts.map +1 -1
- package/dist/adapters/imports/graph.d.ts +6 -3
- package/dist/adapters/imports/graph.d.ts.map +1 -1
- package/dist/adapters/imports/graph.js +31 -18
- package/dist/adapters/imports/graph.js.map +1 -1
- package/dist/adapters/imports/resolve.d.ts.map +1 -1
- package/dist/adapters/imports/resolve.js +29 -5
- package/dist/adapters/imports/resolve.js.map +1 -1
- package/dist/adapters/knip/configuration.d.ts +1 -1
- package/dist/adapters/knip/configuration.d.ts.map +1 -1
- package/dist/adapters/knip/configuration.js +6 -4
- package/dist/adapters/knip/configuration.js.map +1 -1
- package/dist/adapters/knip/entryPointFindings.d.ts +1 -1
- package/dist/adapters/knip/entryPointFindings.d.ts.map +1 -1
- package/dist/adapters/knip/run.d.ts.map +1 -1
- package/dist/adapters/knip/run.js +4 -1
- package/dist/adapters/knip/run.js.map +1 -1
- package/dist/adapters/outsideImportFindings.d.ts +4 -2
- package/dist/adapters/outsideImportFindings.d.ts.map +1 -1
- package/dist/adapters/outsideImportFindings.js +12 -52
- package/dist/adapters/outsideImportFindings.js.map +1 -1
- package/dist/adapters/presenceCheck.d.ts +3 -0
- package/dist/adapters/presenceCheck.d.ts.map +1 -0
- package/dist/adapters/presenceCheck.js +15 -0
- package/dist/adapters/presenceCheck.js.map +1 -0
- package/dist/adapters/queueReadoutFindings.d.ts +1 -1
- package/dist/adapters/queueReadoutFindings.d.ts.map +1 -1
- package/dist/adapters/rule.d.ts +9 -1
- package/dist/adapters/rule.d.ts.map +1 -1
- package/dist/adapters/rule.js +21 -6
- package/dist/adapters/rule.js.map +1 -1
- package/dist/adapters/runMain.d.ts +3 -4
- package/dist/adapters/runMain.d.ts.map +1 -1
- package/dist/adapters/runMain.js +2 -1
- package/dist/adapters/runMain.js.map +1 -1
- package/dist/adapters/serviceModelCheck.d.ts +9 -0
- package/dist/adapters/serviceModelCheck.d.ts.map +1 -0
- package/dist/adapters/{serviceModelFindings.js → serviceModelCheck.js} +9 -23
- package/dist/adapters/serviceModelCheck.js.map +1 -0
- package/dist/adapters/sharedErrorCatalog.d.ts +13 -0
- package/dist/adapters/sharedErrorCatalog.d.ts.map +1 -0
- package/dist/adapters/sharedErrorCatalog.js +28 -0
- package/dist/adapters/sharedErrorCatalog.js.map +1 -0
- package/dist/adapters/sharedErrorModules.d.ts +1 -1
- package/dist/adapters/sharedErrorModules.d.ts.map +1 -1
- package/dist/adapters/sharedErrorModules.js.map +1 -1
- package/dist/adapters/specReaderSources.d.ts +3 -2
- package/dist/adapters/specReaderSources.d.ts.map +1 -1
- package/dist/adapters/specReaderSources.js +6 -3
- package/dist/adapters/specReaderSources.js.map +1 -1
- package/dist/adapters/storyProgram.d.ts +2 -0
- package/dist/adapters/storyProgram.d.ts.map +1 -1
- package/dist/adapters/storyProgram.js +13 -3
- package/dist/adapters/storyProgram.js.map +1 -1
- package/dist/adapters/typeScriptProgram.d.ts +5 -0
- package/dist/adapters/typeScriptProgram.d.ts.map +1 -0
- package/dist/adapters/typeScriptProgram.js +43 -0
- package/dist/adapters/typeScriptProgram.js.map +1 -0
- package/dist/baseline/compare.d.ts +2 -0
- package/dist/baseline/compare.d.ts.map +1 -1
- package/dist/baseline/compare.js +43 -17
- package/dist/baseline/compare.js.map +1 -1
- package/dist/baseline/format.d.ts +1 -0
- package/dist/baseline/format.d.ts.map +1 -1
- package/dist/baseline/format.js +6 -2
- package/dist/baseline/format.js.map +1 -1
- package/dist/baseline/merge.d.ts.map +1 -1
- package/dist/baseline/merge.js +14 -1
- package/dist/baseline/merge.js.map +1 -1
- package/dist/baseline/rewrite.d.ts.map +1 -1
- package/dist/baseline/rewrite.js +3 -1
- package/dist/baseline/rewrite.js.map +1 -1
- package/dist/baseline/update.d.ts +7 -0
- package/dist/baseline/update.d.ts.map +1 -1
- package/dist/baseline/update.js +29 -8
- package/dist/baseline/update.js.map +1 -1
- package/dist/biome/exceptionConfig.d.ts +3 -0
- package/dist/biome/exceptionConfig.d.ts.map +1 -1
- package/dist/biome/exceptionConfig.js +15 -1
- package/dist/biome/exceptionConfig.js.map +1 -1
- package/dist/biome/scannerRules.d.ts +3 -0
- package/dist/biome/scannerRules.d.ts.map +1 -0
- package/dist/biome/scannerRules.js +42 -0
- package/dist/biome/scannerRules.js.map +1 -0
- package/dist/cli/args.d.ts +2 -0
- package/dist/cli/args.d.ts.map +1 -1
- package/dist/cli/args.js +10 -1
- package/dist/cli/args.js.map +1 -1
- package/dist/cli/baseline.d.ts.map +1 -1
- package/dist/cli/baseline.js +5 -1
- package/dist/cli/baseline.js.map +1 -1
- package/dist/cli/lint.d.ts +3 -2
- package/dist/cli/lint.d.ts.map +1 -1
- package/dist/cli/lint.js +13 -5
- package/dist/cli/lint.js.map +1 -1
- package/dist/cli/misplaced.d.ts +6 -0
- package/dist/cli/misplaced.d.ts.map +1 -1
- package/dist/cli/misplaced.js +4 -2
- package/dist/cli/misplaced.js.map +1 -1
- package/dist/cli/program.js +1 -1
- package/dist/cli/program.js.map +1 -1
- package/dist/cli/runSet.d.ts +5 -0
- package/dist/cli/runSet.d.ts.map +1 -0
- package/dist/cli/runSet.js +15 -0
- package/dist/cli/runSet.js.map +1 -0
- package/dist/cli/shrink.d.ts +4 -4
- package/dist/cli/shrink.d.ts.map +1 -1
- package/dist/cli/shrink.js.map +1 -1
- package/dist/cli/usage.d.ts +1 -1
- package/dist/cli/usage.d.ts.map +1 -1
- package/dist/cli/usage.js +7 -2
- package/dist/cli/usage.js.map +1 -1
- package/dist/config/decode.d.ts +1 -0
- package/dist/config/decode.d.ts.map +1 -1
- package/dist/config/decode.js +1 -0
- package/dist/config/decode.js.map +1 -1
- package/dist/config/load.d.ts +2 -0
- package/dist/config/load.d.ts.map +1 -1
- package/dist/config/load.js +1 -0
- package/dist/config/load.js.map +1 -1
- package/dist/config/resolve.d.ts +2 -1
- package/dist/config/resolve.d.ts.map +1 -1
- package/dist/config/resolve.js +9 -4
- package/dist/config/resolve.js.map +1 -1
- package/dist/config.d.ts +2 -0
- package/dist/config.d.ts.map +1 -1
- package/dist/config.js.map +1 -1
- package/dist/engine/childStarted.d.ts +4 -0
- package/dist/engine/childStarted.d.ts.map +1 -0
- package/dist/engine/childStarted.js +7 -0
- package/dist/engine/childStarted.js.map +1 -0
- package/dist/engine/evaluate.d.ts +1 -0
- package/dist/engine/evaluate.d.ts.map +1 -1
- package/dist/engine/evaluate.js +2 -1
- package/dist/engine/evaluate.js.map +1 -1
- package/dist/engine/generateFirst.d.ts +5 -0
- package/dist/engine/generateFirst.d.ts.map +1 -0
- package/dist/engine/generateFirst.js +25 -0
- package/dist/engine/generateFirst.js.map +1 -0
- package/dist/engine/projectScripts.d.ts +11 -0
- package/dist/engine/projectScripts.d.ts.map +1 -0
- package/dist/engine/projectScripts.js +18 -0
- package/dist/engine/projectScripts.js.map +1 -0
- package/dist/engine/runRule.d.ts +21 -0
- package/dist/engine/runRule.d.ts.map +1 -0
- package/dist/engine/runRule.js +70 -0
- package/dist/engine/runRule.js.map +1 -0
- package/dist/engine/runRules.d.ts +5 -12
- package/dist/engine/runRules.d.ts.map +1 -1
- package/dist/engine/runRules.js +49 -65
- package/dist/engine/runRules.js.map +1 -1
- package/dist/engine/session.d.ts +2 -1
- package/dist/engine/session.d.ts.map +1 -1
- package/dist/engine/session.js +22 -6
- package/dist/engine/session.js.map +1 -1
- package/dist/engine/violation.d.ts +7 -0
- package/dist/engine/violation.d.ts.map +1 -1
- package/dist/engine/violation.js +9 -0
- package/dist/engine/violation.js.map +1 -1
- package/dist/exceptions/biomeFindings.d.ts +5 -1
- package/dist/exceptions/biomeFindings.d.ts.map +1 -1
- package/dist/exceptions/biomeFindings.js +17 -18
- package/dist/exceptions/biomeFindings.js.map +1 -1
- package/dist/exceptions/registry.d.ts.map +1 -1
- package/dist/exceptions/registry.js +2 -2
- package/dist/exceptions/registry.js.map +1 -1
- package/dist/hooks/preCommit.d.ts +1 -2
- package/dist/hooks/preCommit.d.ts.map +1 -1
- package/dist/hooks/preCommit.js +16 -19
- package/dist/hooks/preCommit.js.map +1 -1
- package/dist/hooks/stagedCheck.d.ts +5 -0
- package/dist/hooks/stagedCheck.d.ts.map +1 -0
- package/dist/hooks/stagedCheck.js +43 -0
- package/dist/hooks/stagedCheck.js.map +1 -0
- package/dist/hooks/withStagedContent.d.ts +5 -0
- package/dist/hooks/withStagedContent.d.ts.map +1 -0
- package/dist/hooks/withStagedContent.js +84 -0
- package/dist/hooks/withStagedContent.js.map +1 -0
- package/dist/imports/browserGlobals.d.ts +1 -1
- package/dist/imports/browserGlobals.d.ts.map +1 -1
- package/dist/imports/browserNames.d.ts +1 -1
- package/dist/imports/browserNames.d.ts.map +1 -1
- package/dist/imports/browserNames.js +5 -3
- package/dist/imports/browserNames.js.map +1 -1
- package/dist/imports/callsDefineModule.d.ts +3 -0
- package/dist/imports/callsDefineModule.d.ts.map +1 -0
- package/dist/imports/callsDefineModule.js +36 -0
- package/dist/imports/callsDefineModule.js.map +1 -0
- package/dist/imports/fences/check.d.ts +1 -1
- package/dist/imports/fences/check.d.ts.map +1 -1
- package/dist/imports/fences/check.js +3 -1
- package/dist/imports/fences/check.js.map +1 -1
- package/dist/imports/fences/compilePolicy.js +1 -1
- package/dist/imports/fences/compilePolicy.js.map +1 -1
- package/dist/imports/fences/evaluate.d.ts +1 -1
- package/dist/imports/fences/evaluate.d.ts.map +1 -1
- package/dist/imports/fences/evaluate.js +1 -1
- package/dist/imports/fences/evaluate.js.map +1 -1
- package/dist/imports/generatedFolders.d.ts +7 -0
- package/dist/imports/generatedFolders.d.ts.map +1 -0
- package/dist/imports/generatedFolders.js +21 -0
- package/dist/imports/generatedFolders.js.map +1 -0
- package/dist/imports/graph.d.ts +6 -1
- package/dist/imports/graph.d.ts.map +1 -1
- package/dist/imports/graph.js +30 -2
- package/dist/imports/graph.js.map +1 -1
- package/dist/imports/runtime.d.ts +1 -1
- package/dist/imports/runtime.d.ts.map +1 -1
- package/dist/imports/runtime.js +3 -2
- package/dist/imports/runtime.js.map +1 -1
- package/dist/inventory/programmaticBuilds.d.ts +1 -1
- package/dist/inventory/programmaticBuilds.d.ts.map +1 -1
- package/dist/inventory/trackedPaths.d.ts +1 -0
- package/dist/inventory/trackedPaths.d.ts.map +1 -1
- package/dist/inventory/trackedPaths.js +9 -3
- package/dist/inventory/trackedPaths.js.map +1 -1
- package/dist/naming/isOperationFile.d.ts +3 -0
- package/dist/naming/isOperationFile.d.ts.map +1 -0
- package/dist/naming/isOperationFile.js +42 -0
- package/dist/naming/isOperationFile.js.map +1 -0
- package/dist/naming/repeatedFolder.d.ts +2 -0
- package/dist/naming/repeatedFolder.d.ts.map +1 -0
- package/dist/naming/repeatedFolder.js +13 -0
- package/dist/naming/repeatedFolder.js.map +1 -0
- package/dist/naming/testCode.d.ts +1 -1
- package/dist/naming/testCode.d.ts.map +1 -1
- package/dist/report/render.d.ts +1 -0
- package/dist/report/render.d.ts.map +1 -1
- package/dist/report/render.js +10 -3
- package/dist/report/render.js.map +1 -1
- package/dist/report/runSetLine.d.ts +3 -0
- package/dist/report/runSetLine.d.ts.map +1 -0
- package/dist/report/runSetLine.js +13 -0
- package/dist/report/runSetLine.js.map +1 -0
- package/dist/report/staleSections.d.ts.map +1 -1
- package/dist/report/staleSections.js +13 -0
- package/dist/report/staleSections.js.map +1 -1
- package/dist/rule.d.ts +30 -4
- package/dist/rule.d.ts.map +1 -1
- package/dist/rule.js +4 -2
- package/dist/rule.js.map +1 -1
- package/dist/rules/biome.d.ts +18 -1
- package/dist/rules/biome.d.ts.map +1 -1
- package/dist/rules/biome.js +32 -7
- package/dist/rules/biome.js.map +1 -1
- package/dist/rules/builtIn.d.ts +7 -9
- package/dist/rules/builtIn.d.ts.map +1 -1
- package/dist/rules/builtIn.js +2 -2
- package/dist/rules/builtIn.js.map +1 -1
- package/dist/rules/effect/adapterImports.d.ts +1 -1
- package/dist/rules/effect/adapterImports.d.ts.map +1 -1
- package/dist/rules/effect/adapterImports.js +1 -1
- package/dist/rules/effect/adapterImports.js.map +1 -1
- package/dist/rules/effect/boundary.d.ts +1 -1
- package/dist/rules/effect/boundary.d.ts.map +1 -1
- package/dist/rules/effect/boundary.js +60 -75
- package/dist/rules/effect/boundary.js.map +1 -1
- package/dist/rules/effect/boundaryFindings.d.ts +4 -0
- package/dist/rules/effect/boundaryFindings.d.ts.map +1 -0
- package/dist/rules/effect/boundaryFindings.js +63 -0
- package/dist/rules/effect/boundaryFindings.js.map +1 -0
- package/dist/rules/effect/boundaryReference.d.ts +4 -0
- package/dist/rules/effect/boundaryReference.d.ts.map +1 -1
- package/dist/rules/effect/boundaryReference.js +6 -3
- package/dist/rules/effect/boundaryReference.js.map +1 -1
- package/dist/rules/effect/contextCapture.d.ts.map +1 -1
- package/dist/rules/effect/contextCapture.js +3 -2
- package/dist/rules/effect/contextCapture.js.map +1 -1
- package/dist/rules/effect/errorTags.d.ts +10 -0
- package/dist/rules/effect/errorTags.d.ts.map +1 -0
- package/dist/rules/effect/errorTags.js +57 -0
- package/dist/rules/effect/errorTags.js.map +1 -0
- package/dist/rules/effect/failureHonesty.d.ts +1 -1
- package/dist/rules/effect/failureHonesty.d.ts.map +1 -1
- package/dist/rules/effect/failureHonesty.js +6 -5
- package/dist/rules/effect/failureHonesty.js.map +1 -1
- package/dist/rules/effect/policy.d.ts +1 -1
- package/dist/rules/effect/policy.d.ts.map +1 -1
- package/dist/rules/effect/policy.js +0 -2
- package/dist/rules/effect/policy.js.map +1 -1
- package/dist/rules/effect/promiseBridge.d.ts +3 -0
- package/dist/rules/effect/promiseBridge.d.ts.map +1 -0
- package/dist/rules/effect/promiseBridge.js +60 -0
- package/dist/rules/effect/promiseBridge.js.map +1 -0
- package/dist/rules/effect/rpcBoundary.d.ts.map +1 -1
- package/dist/rules/effect/rpcBoundary.js +92 -3
- package/dist/rules/effect/rpcBoundary.js.map +1 -1
- package/dist/rules/effect/serviceModel.d.ts.map +1 -1
- package/dist/rules/effect/serviceModel.js +3 -2
- package/dist/rules/effect/serviceModel.js.map +1 -1
- package/dist/rules/effect/serviceParameterCheck.d.ts +7 -0
- package/dist/rules/effect/serviceParameterCheck.d.ts.map +1 -0
- package/dist/rules/effect/serviceParameterCheck.js +15 -0
- package/dist/rules/effect/serviceParameterCheck.js.map +1 -0
- package/dist/rules/effect/serviceParameters.d.ts.map +1 -1
- package/dist/rules/effect/serviceParameters.js +4 -36
- package/dist/rules/effect/serviceParameters.js.map +1 -1
- package/dist/rules/effect/sharedErrorClasses.d.ts.map +1 -1
- package/dist/rules/effect/sharedErrorClasses.js +31 -2
- package/dist/rules/effect/sharedErrorClasses.js.map +1 -1
- package/dist/rules/effect/workspaceProgram.d.ts +5 -0
- package/dist/rules/effect/workspaceProgram.d.ts.map +1 -0
- package/dist/rules/effect/workspaceProgram.js +32 -0
- package/dist/rules/effect/workspaceProgram.js.map +1 -0
- package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
- package/dist/rules/files/namedAfterExport.js +11 -12
- package/dist/rules/files/namedAfterExport.js.map +1 -1
- package/dist/rules/imports/adminPaths.d.ts +1 -1
- package/dist/rules/imports/adminPaths.d.ts.map +1 -1
- package/dist/rules/imports/cycles.d.ts +1 -1
- package/dist/rules/imports/cycles.d.ts.map +1 -1
- package/dist/rules/imports/fences.d.ts +1 -1
- package/dist/rules/imports/fences.d.ts.map +1 -1
- package/dist/rules/imports/manifest.d.ts +1 -1
- package/dist/rules/imports/manifest.d.ts.map +1 -1
- package/dist/rules/imports/noTestCode.d.ts +1 -1
- package/dist/rules/imports/noTestCode.d.ts.map +1 -1
- package/dist/rules/imports/resolvable.d.ts +1 -3
- package/dist/rules/imports/resolvable.d.ts.map +1 -1
- package/dist/rules/imports/resolvable.js +12 -10
- package/dist/rules/imports/resolvable.js.map +1 -1
- package/dist/rules/imports/runtime.d.ts +1 -1
- package/dist/rules/imports/runtime.d.ts.map +1 -1
- package/dist/rules/imports/runtime.js +49 -9
- package/dist/rules/imports/runtime.js.map +1 -1
- package/dist/rules/manifestsNoTestKits.js +1 -1
- package/dist/rules/manifestsNoTestKits.js.map +1 -1
- package/dist/rules/maxLines.d.ts +1 -1
- package/dist/rules/maxLines.d.ts.map +1 -1
- package/dist/rules/packageFindings.d.ts +31 -0
- package/dist/rules/packageFindings.d.ts.map +1 -0
- package/dist/rules/packageFindings.js +65 -0
- package/dist/rules/packageFindings.js.map +1 -0
- package/dist/rules/parse.d.ts +4 -1
- package/dist/rules/parse.d.ts.map +1 -1
- package/dist/rules/parse.js +35 -2
- package/dist/rules/parse.js.map +1 -1
- package/dist/rules/rootedFindings.d.ts +5 -0
- package/dist/rules/rootedFindings.d.ts.map +1 -0
- package/dist/rules/rootedFindings.js +16 -0
- package/dist/rules/rootedFindings.js.map +1 -0
- package/dist/rules/stories/adapterOnlyFakes.d.ts +1 -1
- package/dist/rules/stories/adapterOnlyFakes.d.ts.map +1 -1
- package/dist/rules/stories/adapterOnlyFakes.js +1 -0
- package/dist/rules/stories/adapterOnlyFakes.js.map +1 -1
- package/dist/rules/stories/databaseUrl.d.ts +1 -1
- package/dist/rules/stories/databaseUrl.d.ts.map +1 -1
- package/dist/rules/stories/databaseUrl.js +1 -0
- package/dist/rules/stories/databaseUrl.js.map +1 -1
- package/dist/rules/stories/domainOutcomes.d.ts +1 -1
- package/dist/rules/stories/domainOutcomes.d.ts.map +1 -1
- package/dist/rules/stories/domainOutcomes.js +1 -0
- package/dist/rules/stories/domainOutcomes.js.map +1 -1
- package/dist/rules/stories/engine.d.ts +1 -1
- package/dist/rules/stories/engine.d.ts.map +1 -1
- package/dist/rules/stories/engine.js +1 -0
- package/dist/rules/stories/engine.js.map +1 -1
- package/dist/rules/stories/globalRetries.d.ts +1 -1
- package/dist/rules/stories/globalRetries.d.ts.map +1 -1
- package/dist/rules/stories/globalRetries.js +1 -0
- package/dist/rules/stories/globalRetries.js.map +1 -1
- package/dist/rules/stories/groupedOutcomes.d.ts +1 -1
- package/dist/rules/stories/groupedOutcomes.d.ts.map +1 -1
- package/dist/rules/stories/groupedOutcomes.js +1 -0
- package/dist/rules/stories/groupedOutcomes.js.map +1 -1
- package/dist/rules/stories/importedChangeKeys.js +2 -2
- package/dist/rules/stories/importedChangeKeys.js.map +1 -1
- package/dist/rules/stories/namedValues.d.ts +1 -1
- package/dist/rules/stories/namedValues.d.ts.map +1 -1
- package/dist/rules/stories/namedValues.js +1 -0
- package/dist/rules/stories/namedValues.js.map +1 -1
- package/dist/rules/stories/noExpect.d.ts +1 -1
- package/dist/rules/stories/noExpect.d.ts.map +1 -1
- package/dist/rules/stories/noLimitImports.d.ts +1 -1
- package/dist/rules/stories/noLimitImports.d.ts.map +1 -1
- package/dist/rules/stories/noLimitImports.js +1 -0
- package/dist/rules/stories/noLimitImports.js.map +1 -1
- package/dist/rules/stories/positiveRefusals.d.ts +1 -1
- package/dist/rules/stories/positiveRefusals.d.ts.map +1 -1
- package/dist/rules/stories/positiveRefusals.js +1 -0
- package/dist/rules/stories/positiveRefusals.js.map +1 -1
- package/dist/rules/stories/queueReadouts.d.ts +1 -1
- package/dist/rules/stories/queueReadouts.d.ts.map +1 -1
- package/dist/rules/stories/queueReadouts.js +1 -0
- package/dist/rules/stories/queueReadouts.js.map +1 -1
- package/dist/rules/stories/rawServers.d.ts +2 -0
- package/dist/rules/stories/rawServers.d.ts.map +1 -0
- package/dist/rules/stories/rawServers.js +100 -0
- package/dist/rules/stories/rawServers.js.map +1 -0
- package/dist/rules/stories/sources.d.ts +2 -2
- package/dist/rules/stories/sources.d.ts.map +1 -1
- package/dist/rules/stories/specHelpers.d.ts +1 -1
- package/dist/rules/stories/specHelpers.d.ts.map +1 -1
- package/dist/rules/stories/specHelpers.js +3 -2
- package/dist/rules/stories/specHelpers.js.map +1 -1
- package/dist/rules/stories/specs.d.ts +1 -1
- package/dist/rules/stories/specs.d.ts.map +1 -1
- package/dist/rules/stories/specs.js +1 -0
- package/dist/rules/stories/specs.js.map +1 -1
- package/dist/rules/stories/waitOnEvents.d.ts +1 -1
- package/dist/rules/stories/waitOnEvents.d.ts.map +1 -1
- package/dist/rules/stories/waitOnEvents.js +3 -3
- package/dist/rules/stories/waitOnEvents.js.map +1 -1
- package/dist/rules/suppressions/noDoubleCast.d.ts.map +1 -1
- package/dist/rules/suppressions/noDoubleCast.js +4 -49
- package/dist/rules/suppressions/noDoubleCast.js.map +1 -1
- package/dist/rules/suppressions/typedCastCheck.d.ts +10 -0
- package/dist/rules/suppressions/typedCastCheck.d.ts.map +1 -0
- package/dist/rules/suppressions/typedCastCheck.js +48 -0
- package/dist/rules/suppressions/typedCastCheck.js.map +1 -0
- package/dist/rules/unusedCode.d.ts.map +1 -1
- package/dist/rules/unusedCode.js +1 -0
- package/dist/rules/unusedCode.js.map +1 -1
- package/dist/testing/adapters/cli.d.ts +1 -0
- package/dist/testing/adapters/cli.d.ts.map +1 -1
- package/dist/testing/adapters/cli.js +10 -8
- package/dist/testing/adapters/cli.js.map +1 -1
- package/dist/testing/adapters/git.d.ts +1 -16
- package/dist/testing/adapters/git.d.ts.map +1 -1
- package/dist/testing/adapters/git.js +5 -10
- package/dist/testing/adapters/git.js.map +1 -1
- package/dist/testing/adapters/hookRepository.d.ts +3 -2
- package/dist/testing/adapters/hookRepository.d.ts.map +1 -1
- package/dist/testing/adapters/hookRepository.js +11 -8
- package/dist/testing/adapters/hookRepository.js.map +1 -1
- package/dist/testing/adapters/imports.d.ts.map +1 -1
- package/dist/testing/adapters/imports.js +4 -1
- package/dist/testing/adapters/imports.js.map +1 -1
- package/dist/testing/ruleStory.d.ts +1 -1
- package/dist/testing/ruleStory.js +2 -2
- package/dist/testing/ruleStory.js.map +1 -1
- package/docs/debt-and-hooks.md +5 -3
- package/docs/north-star.md +1 -1
- package/package.json +19 -19
- package/src/adapters/biome/pluginContract.ts +2 -5
- package/src/adapters/biome/run.ts +2 -0
- package/src/adapters/biome/withExceptionConfig.ts +26 -5
- package/src/adapters/{changeKeyFindings.ts → changeKeyCheck.ts} +8 -24
- package/src/adapters/contextCaptureCheck.ts +106 -0
- package/src/adapters/declaration-files/initialize.ts +4 -0
- package/src/adapters/declaration-files/parse.ts +9 -0
- package/src/adapters/declaration-files/reader.ts +28 -0
- package/src/adapters/declaration-files/service.ts +16 -0
- package/src/adapters/declarationTagParameter.ts +4 -0
- package/src/adapters/foreignResources.ts +0 -4
- package/src/adapters/import-compiler/graph.ts +7 -2
- package/src/adapters/imports/graph.ts +43 -18
- package/src/adapters/imports/resolve.ts +31 -5
- package/src/adapters/knip/configuration.ts +6 -4
- package/src/adapters/knip/run.ts +4 -1
- package/src/adapters/outsideImportFindings.ts +21 -65
- package/src/adapters/presenceCheck.ts +17 -0
- package/src/adapters/rule.ts +29 -6
- package/src/adapters/runMain.ts +7 -6
- package/src/adapters/{serviceModelFindings.ts → serviceModelCheck.ts} +10 -25
- package/src/adapters/sharedErrorCatalog.ts +43 -0
- package/src/adapters/sharedErrorModules.ts +1 -1
- package/src/adapters/specReaderSources.ts +6 -3
- package/src/adapters/storyProgram.ts +20 -3
- package/src/adapters/typeScriptProgram.ts +57 -0
- package/src/baseline/compare.ts +59 -19
- package/src/baseline/format.ts +7 -2
- package/src/baseline/merge.ts +15 -1
- package/src/baseline/rewrite.ts +3 -1
- package/src/baseline/update.ts +38 -8
- package/src/biome/exceptionConfig.ts +24 -3
- package/src/biome/scannerRules.ts +42 -0
- package/src/cli/args.ts +13 -2
- package/src/cli/baseline.ts +7 -1
- package/src/cli/lint.ts +14 -6
- package/src/cli/misplaced.ts +4 -2
- package/src/cli/program.ts +1 -1
- package/src/cli/runSet.ts +17 -0
- package/src/cli/shrink.ts +4 -11
- package/src/cli/usage.ts +7 -2
- package/src/config/decode.ts +1 -0
- package/src/config/load.ts +3 -0
- package/src/config/resolve.ts +11 -6
- package/src/config.ts +3 -0
- package/src/engine/childStarted.ts +8 -0
- package/src/engine/evaluate.ts +3 -1
- package/src/engine/generateFirst.ts +32 -0
- package/src/engine/projectScripts.ts +25 -0
- package/src/engine/runRule.ts +103 -0
- package/src/engine/runRules.ts +64 -86
- package/src/engine/session.ts +25 -5
- package/src/engine/violation.ts +16 -0
- package/src/exceptions/biomeFindings.ts +24 -21
- package/src/exceptions/registry.ts +2 -2
- package/src/hooks/preCommit.ts +24 -24
- package/src/hooks/stagedCheck.ts +54 -0
- package/src/hooks/withStagedContent.ts +111 -0
- package/src/imports/browserNames.ts +7 -5
- package/src/imports/callsDefineModule.ts +43 -0
- package/src/imports/fences/check.ts +3 -1
- package/src/imports/fences/compilePolicy.ts +1 -1
- package/src/imports/fences/evaluate.ts +2 -2
- package/src/imports/generatedFolders.ts +28 -0
- package/src/imports/graph.ts +47 -3
- package/src/imports/runtime.ts +7 -2
- package/src/inventory/trackedPaths.ts +10 -3
- package/src/naming/isOperationFile.ts +52 -0
- package/src/naming/repeatedFolder.ts +14 -0
- package/src/report/render.ts +12 -3
- package/src/report/runSetLine.ts +14 -0
- package/src/report/staleSections.ts +14 -0
- package/src/rule.ts +38 -7
- package/src/rules/biome.ts +53 -7
- package/src/rules/builtIn.ts +2 -2
- package/src/rules/effect/adapterImports.ts +1 -1
- package/src/rules/effect/boundary.ts +82 -83
- package/src/rules/effect/boundaryFindings.ts +71 -0
- package/src/rules/effect/boundaryReference.ts +7 -3
- package/src/rules/effect/contextCapture.ts +3 -2
- package/src/rules/effect/errorTags.ts +72 -0
- package/src/rules/effect/failureHonesty.ts +9 -5
- package/src/rules/effect/policy.ts +0 -2
- package/src/rules/effect/promiseBridge.ts +65 -0
- package/src/rules/effect/rpcBoundary.ts +111 -4
- package/src/rules/effect/serviceModel.ts +3 -2
- package/src/rules/effect/serviceParameterCheck.ts +22 -0
- package/src/rules/effect/serviceParameters.ts +5 -37
- package/src/rules/effect/sharedErrorClasses.ts +41 -3
- package/src/rules/effect/workspaceProgram.ts +34 -0
- package/src/rules/files/namedAfterExport.ts +14 -13
- package/src/rules/imports/resolvable.ts +13 -11
- package/src/rules/imports/runtime.ts +71 -10
- package/src/rules/manifestsNoTestKits.ts +1 -1
- package/src/rules/packageFindings.ts +103 -0
- package/src/rules/parse.ts +54 -3
- package/src/rules/rootedFindings.ts +19 -0
- package/src/rules/stories/adapterOnlyFakes.ts +1 -0
- package/src/rules/stories/databaseUrl.ts +1 -0
- package/src/rules/stories/domainOutcomes.ts +1 -0
- package/src/rules/stories/engine.ts +1 -0
- package/src/rules/stories/globalRetries.ts +1 -0
- package/src/rules/stories/groupedOutcomes.ts +1 -0
- package/src/rules/stories/importedChangeKeys.ts +2 -2
- package/src/rules/stories/namedValues.ts +1 -0
- package/src/rules/stories/noLimitImports.ts +1 -0
- package/src/rules/stories/positiveRefusals.ts +1 -0
- package/src/rules/stories/queueReadouts.ts +1 -0
- package/src/rules/stories/rawServers.ts +118 -0
- package/src/rules/stories/specHelpers.ts +8 -5
- package/src/rules/stories/specs.ts +1 -0
- package/src/rules/stories/waitOnEvents.ts +6 -3
- package/src/rules/suppressions/noDoubleCast.ts +5 -55
- package/src/rules/suppressions/typedCastCheck.ts +55 -0
- package/src/rules/unusedCode.ts +1 -0
- package/src/testing/adapters/cli.ts +13 -9
- package/src/testing/adapters/git.ts +6 -11
- package/src/testing/adapters/hookRepository.ts +12 -7
- package/src/testing/adapters/imports.ts +4 -1
- package/src/testing/ruleStory.ts +2 -2
- package/dist/adapters/biome/presetConfig.d.ts +0 -21
- package/dist/adapters/biome/presetConfig.d.ts.map +0 -1
- package/dist/adapters/biome/presetConfig.js +0 -32
- package/dist/adapters/biome/presetConfig.js.map +0 -1
- package/dist/adapters/changeKeyFindings.d.ts +0 -4
- package/dist/adapters/changeKeyFindings.d.ts.map +0 -1
- package/dist/adapters/changeKeyFindings.js.map +0 -1
- package/dist/adapters/contextCaptureFindings.d.ts +0 -4
- package/dist/adapters/contextCaptureFindings.d.ts.map +0 -1
- package/dist/adapters/contextCaptureFindings.js +0 -51
- package/dist/adapters/contextCaptureFindings.js.map +0 -1
- package/dist/adapters/nativeTransactionFindings.d.ts +0 -4
- package/dist/adapters/nativeTransactionFindings.d.ts.map +0 -1
- package/dist/adapters/nativeTransactionFindings.js +0 -98
- package/dist/adapters/nativeTransactionFindings.js.map +0 -1
- package/dist/adapters/rpcBoundaryFindings.d.ts +0 -4
- package/dist/adapters/rpcBoundaryFindings.d.ts.map +0 -1
- package/dist/adapters/rpcBoundaryFindings.js +0 -90
- package/dist/adapters/rpcBoundaryFindings.js.map +0 -1
- package/dist/adapters/serviceModelFindings.d.ts +0 -4
- package/dist/adapters/serviceModelFindings.d.ts.map +0 -1
- package/dist/adapters/serviceModelFindings.js.map +0 -1
- package/dist/adapters/sharedErrorFindings.d.ts +0 -4
- package/dist/adapters/sharedErrorFindings.d.ts.map +0 -1
- package/dist/adapters/sharedErrorFindings.js +0 -71
- package/dist/adapters/sharedErrorFindings.js.map +0 -1
- package/dist/adapters/transactionChanges.d.ts +0 -3
- package/dist/adapters/transactionChanges.d.ts.map +0 -1
- package/dist/adapters/transactionChanges.js +0 -81
- package/dist/adapters/transactionChanges.js.map +0 -1
- package/dist/adapters/vitePort.d.ts +0 -2
- package/dist/adapters/vitePort.d.ts.map +0 -1
- package/dist/adapters/vitePort.js +0 -5
- package/dist/adapters/vitePort.js.map +0 -1
- package/dist/appTestConfig.d.ts +0 -4
- package/dist/appTestConfig.d.ts.map +0 -1
- package/dist/appTestConfig.js +0 -9
- package/dist/appTestConfig.js.map +0 -1
- package/dist/appViteConfig.d.ts +0 -23
- package/dist/appViteConfig.d.ts.map +0 -1
- package/dist/appViteConfig.js +0 -17
- package/dist/appViteConfig.js.map +0 -1
- package/dist/biome/recommendedRules.d.ts +0 -3
- package/dist/biome/recommendedRules.d.ts.map +0 -1
- package/dist/biome/recommendedRules.js +0 -20
- package/dist/biome/recommendedRules.js.map +0 -1
- package/dist/imports/withoutGenerated.d.ts +0 -8
- package/dist/imports/withoutGenerated.d.ts.map +0 -1
- package/dist/imports/withoutGenerated.js +0 -65
- package/dist/imports/withoutGenerated.js.map +0 -1
- package/dist/rules/effect/program.d.ts +0 -8
- package/dist/rules/effect/program.d.ts.map +0 -1
- package/dist/rules/effect/program.js +0 -53
- package/dist/rules/effect/program.js.map +0 -1
- package/dist/rules/effect/sqlTransact.d.ts +0 -2
- package/dist/rules/effect/sqlTransact.d.ts.map +0 -1
- package/dist/rules/effect/sqlTransact.js +0 -9
- package/dist/rules/effect/sqlTransact.js.map +0 -1
- package/dist/rules/suppressions/biomeRecommended.d.ts +0 -7
- package/dist/rules/suppressions/biomeRecommended.d.ts.map +0 -1
- package/dist/rules/suppressions/biomeRecommended.js +0 -47
- package/dist/rules/suppressions/biomeRecommended.js.map +0 -1
- package/src/adapters/biome/presetConfig.ts +0 -34
- package/src/adapters/contextCaptureFindings.ts +0 -60
- package/src/adapters/nativeTransactionFindings.ts +0 -108
- package/src/adapters/rpcBoundaryFindings.ts +0 -98
- package/src/adapters/sharedErrorFindings.ts +0 -84
- package/src/adapters/transactionChanges.ts +0 -85
- package/src/adapters/vitePort.ts +0 -5
- package/src/appTestConfig.ts +0 -10
- package/src/appViteConfig.ts +0 -24
- package/src/biome/recommendedRules.ts +0 -27
- package/src/imports/withoutGenerated.ts +0 -82
- package/src/rules/effect/program.ts +0 -57
- package/src/rules/effect/sqlTransact.ts +0 -10
- package/src/rules/suppressions/biomeRecommended.ts +0 -60
|
@@ -1,33 +1,36 @@
|
|
|
1
1
|
import { Effect } from "effect";
|
|
2
|
-
import {
|
|
3
|
-
import {
|
|
2
|
+
import { needsScanner } from "#biome/scannerRules.ts";
|
|
3
|
+
import { keyOf, type Violation } from "#engine/violation.ts";
|
|
4
4
|
import type { StaleRegistryEntry } from "#exceptions/registry.ts";
|
|
5
5
|
import type { FilesystemFailure } from "#inventory/filesystem.ts";
|
|
6
6
|
import type { Finding, RuleInputs } from "#rule.ts";
|
|
7
7
|
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
8
|
+
// The biome rule reports excepted diagnostics at any severity; the session drops them and names each exception that none matched.
|
|
9
|
+
export const biomeExceptions = Effect.fn("Exceptions.biomeExceptions")(function* (
|
|
10
|
+
violations: readonly Violation[],
|
|
11
|
+
inputs: Pick<RuleInputs, "configFile" | "exceptions" | "readText">,
|
|
12
|
+
skippedHalves: ReadonlySet<string>,
|
|
13
|
+
) {
|
|
14
|
+
const declared = (inputs.exceptions ?? []).flatMap(({ files, reason, rules }) =>
|
|
11
15
|
rules.filter((rule) => /^biome\/(?:lint|assist)\//u.test(rule)).flatMap((rule) => files.map((file) => ({ file, reason, rule }))),
|
|
12
16
|
);
|
|
17
|
+
const excepted = new Set(declared.map(({ file, rule }) => keyOf(rule, file)));
|
|
18
|
+
const reported = new Set(violations.map((violation) => keyOf(violation.rule, violation.file)));
|
|
13
19
|
const texts = yield* Effect.forEach(declared, ({ file }) => inputs.readText(file), { concurrency: "unbounded" });
|
|
14
|
-
const
|
|
15
|
-
|
|
16
|
-
return [];
|
|
17
|
-
}
|
|
18
|
-
const exclusions = declarations.flatMap((entry) =>
|
|
19
|
-
entry.rules.includes("biome/files/includes") ? [{ ...entry, rules: ["biome/files/includes"] as const }] : [],
|
|
20
|
+
const judged = declared.filter(
|
|
21
|
+
(entry, index) => texts[index] !== undefined && !(skippedHalves.has("biome") && needsScanner(entry.rule.slice("biome/".length))),
|
|
20
22
|
);
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
23
|
+
return {
|
|
24
|
+
kept: violations.filter((violation) => !excepted.has(keyOf(violation.rule, violation.file))),
|
|
25
|
+
stale: judged
|
|
26
|
+
.filter(({ file, rule }) => !reported.has(keyOf(rule, file)))
|
|
27
|
+
.map(
|
|
28
|
+
(entry): StaleRegistryEntry => ({
|
|
29
|
+
entry,
|
|
30
|
+
problem: `matches no finding. Remove this file/rule pair from exceptions in ${inputs.configFile ?? "quality.config.ts"}`,
|
|
31
|
+
}),
|
|
32
|
+
),
|
|
33
|
+
};
|
|
31
34
|
});
|
|
32
35
|
|
|
33
36
|
const missingBiomeFile = Effect.fn("Exceptions.missingBiomeFile")(function* (
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import { Schema } from "effect";
|
|
2
2
|
import { type Decoded, decodeWith } from "#decoded.ts";
|
|
3
|
-
import { type RuleIndex, registrable, unusedEntryProblem, type Violation } from "#engine/violation.ts";
|
|
3
|
+
import { halfSkipped, type RuleIndex, registrable, skipped, unusedEntryProblem, type Violation } from "#engine/violation.ts";
|
|
4
4
|
|
|
5
5
|
const RegistryEntry = Schema.Struct({
|
|
6
6
|
file: Schema.NonEmptyString,
|
|
@@ -50,7 +50,7 @@ export function applyRegistry(violations: readonly Violation[], entries: readonl
|
|
|
50
50
|
return entry === undefined;
|
|
51
51
|
});
|
|
52
52
|
const stale = entries
|
|
53
|
-
.filter((entry) => !used.has(entry))
|
|
53
|
+
.filter((entry) => !(used.has(entry) || (registrable(rules, entry.rule) && (skipped(rules, entry.rule) || halfSkipped(rules, entry.rule)))))
|
|
54
54
|
.map((entry) => ({
|
|
55
55
|
entry,
|
|
56
56
|
problem: registrable(rules, entry.rule) ? unusedEntryProblem(rules, entry.rule, "matches no violation") : UNREGISTRABLE,
|
package/src/hooks/preCommit.ts
CHANGED
|
@@ -1,36 +1,17 @@
|
|
|
1
|
-
import
|
|
2
|
-
import { Console, Effect, Path } from "effect";
|
|
1
|
+
import { Config, Console, Effect } from "effect";
|
|
3
2
|
import { ChildProcess, ChildProcessSpawner } from "effect/process";
|
|
4
|
-
import {
|
|
5
|
-
import { manifestReader } from "#adapters/manifestReader.ts";
|
|
3
|
+
import type { ManifestReadFailure } from "#adapters/manifestInventory.ts";
|
|
6
4
|
import { reportLint } from "#cli/lint.ts";
|
|
7
5
|
import { loadConfig } from "#config/load.ts";
|
|
8
6
|
import { passes } from "#engine/evaluate.ts";
|
|
7
|
+
import { projectScripts } from "#engine/projectScripts.ts";
|
|
9
8
|
import { GateFailed, SetupFailure } from "#failure.ts";
|
|
9
|
+
import { stagedCheck } from "#hooks/stagedCheck.ts";
|
|
10
10
|
import { recap } from "#report/recap.ts";
|
|
11
11
|
|
|
12
12
|
const COMMIT_AGAIN =
|
|
13
13
|
"help: fix what the output above reports, then commit again; `quality hooks pre-commit` repeats these checks without committing.";
|
|
14
14
|
|
|
15
|
-
const commitScripts = Effect.fnUntraced(function* (root: string) {
|
|
16
|
-
const { join } = yield* Path.Path.pipe(Effect.provide(NodePath.layer));
|
|
17
|
-
|
|
18
|
-
const file = join(root, "package.json");
|
|
19
|
-
const readText = yield* manifestReader(root);
|
|
20
|
-
const manifest = yield* Effect.mapError(
|
|
21
|
-
readPackageManifest(readText, file),
|
|
22
|
-
(cause) => new SetupFailure({ cause, message: `${file} is invalid: ${cause.message}` }),
|
|
23
|
-
);
|
|
24
|
-
if (manifest === undefined) {
|
|
25
|
-
return { manager: "npm", scripts: [] };
|
|
26
|
-
}
|
|
27
|
-
const manager = manifest.packageManager?.split("@")[0] ?? "npm";
|
|
28
|
-
if (!["npm", "pnpm", "yarn", "bun"].includes(manager)) {
|
|
29
|
-
return yield* new SetupFailure({ message: `${file}: unsupported packageManager "${manager}". Use npm, pnpm, yarn or bun.` });
|
|
30
|
-
}
|
|
31
|
-
return { manager, scripts: ["typecheck", "quality:commit"].filter((script) => manifest.scripts?.[script] !== undefined) };
|
|
32
|
-
});
|
|
33
|
-
|
|
34
15
|
const runScript = Effect.fnUntraced(
|
|
35
16
|
function* (root: string, manager: string, script: string) {
|
|
36
17
|
const spawner = yield* ChildProcessSpawner.ChildProcessSpawner;
|
|
@@ -43,9 +24,28 @@ const runScript = Effect.fnUntraced(
|
|
|
43
24
|
Effect.mapError((error) => new SetupFailure({ cause: error, message: `cannot run a pre-commit script: ${error.message}` })),
|
|
44
25
|
);
|
|
45
26
|
|
|
27
|
+
function invalidManifest(cause: ManifestReadFailure) {
|
|
28
|
+
return new SetupFailure({ cause, message: `${cause.path} is invalid: ${cause.message}` });
|
|
29
|
+
}
|
|
30
|
+
|
|
31
|
+
const inCloudSession = Config.String("CLAUDE_CODE_REMOTE").pipe(
|
|
32
|
+
Config.withDefault(""),
|
|
33
|
+
Config.map((value) => value === "true"),
|
|
34
|
+
);
|
|
35
|
+
|
|
46
36
|
export const preCommitHook = Effect.fn("Hooks.preCommitHook")(function* (cwd: string, path: string | undefined) {
|
|
47
37
|
const config = yield* loadConfig(cwd, path);
|
|
48
|
-
const
|
|
38
|
+
const cloud = yield* inCloudSession.pipe(Effect.mapError((cause) => new SetupFailure({ cause, message: "cannot read CLAUDE_CODE_REMOTE." })));
|
|
39
|
+
if (config.preCommit === "staged" && !cloud) {
|
|
40
|
+
if (!(yield* stagedCheck(config))) {
|
|
41
|
+
yield* Console.error(`quality: pre-commit failed: Biome on the staged files.\n${COMMIT_AGAIN}`);
|
|
42
|
+
return yield* new GateFailed();
|
|
43
|
+
}
|
|
44
|
+
return;
|
|
45
|
+
}
|
|
46
|
+
const { manager, scripts } = yield* projectScripts(config.root, ["typecheck", "quality:commit"]).pipe(
|
|
47
|
+
Effect.catchTags({ FilesystemFailure: invalidManifest, ManifestFailure: invalidManifest }),
|
|
48
|
+
);
|
|
49
49
|
const { context, outcome } = yield* reportLint(cwd, path, true);
|
|
50
50
|
const linted = passes(outcome);
|
|
51
51
|
const failed = linted ? [] : ["quality lint"];
|
|
@@ -0,0 +1,54 @@
|
|
|
1
|
+
import * as NodePath from "@effect/platform-node/NodePath";
|
|
2
|
+
import { Console, Effect, Path } from "effect";
|
|
3
|
+
import { manifestReader } from "#adapters/manifestReader.ts";
|
|
4
|
+
import { biomeReport } from "#biome/report.ts";
|
|
5
|
+
import type { ResolvedConfig } from "#config/load.ts";
|
|
6
|
+
import { readBaseline } from "#engine/baselineFile.ts";
|
|
7
|
+
import { evaluate, type Outcome, passes } from "#engine/evaluate.ts";
|
|
8
|
+
import type { Violation } from "#engine/violation.ts";
|
|
9
|
+
import { registryEntries } from "#exceptions/registryEntries.ts";
|
|
10
|
+
import { SetupFailure } from "#failure.ts";
|
|
11
|
+
import { gitOrFail } from "#git/command.ts";
|
|
12
|
+
import { withStagedContent } from "#hooks/withStagedContent.ts";
|
|
13
|
+
import { type ReportContext, renderFindings } from "#report/render.ts";
|
|
14
|
+
import { failingFindings } from "#rules/biome.ts";
|
|
15
|
+
|
|
16
|
+
const BIOME = ["check", "--files-ignore-unknown=true", "--no-errors-on-unmatched"];
|
|
17
|
+
|
|
18
|
+
function pathsOf(output: string): readonly string[] {
|
|
19
|
+
return output.split("\0").filter((path) => path !== "");
|
|
20
|
+
}
|
|
21
|
+
|
|
22
|
+
function failed(error: { readonly message: string }): SetupFailure {
|
|
23
|
+
return new SetupFailure({ cause: error, message: error.message });
|
|
24
|
+
}
|
|
25
|
+
|
|
26
|
+
export const stagedCheck = Effect.fn("Hooks.stagedCheck")(function* (config: ResolvedConfig) {
|
|
27
|
+
const { relative } = yield* Path.Path.pipe(Effect.provide(NodePath.layer));
|
|
28
|
+
|
|
29
|
+
const staged = pathsOf(yield* gitOrFail(config.root, ["diff", "--cached", "--name-only", "--relative", "--diff-filter=d", "-z"]));
|
|
30
|
+
const unstaged = new Set(pathsOf(yield* gitOrFail(config.root, ["diff", "--name-only", "--relative", "-z"])));
|
|
31
|
+
const edited = staged.filter((path) => unstaged.has(path));
|
|
32
|
+
yield* Console.log(
|
|
33
|
+
`quality: checking ${staged.length === 1 ? "the staged file" : `the ${staged.length} staged files`} with Biome only, as preCommit is "staged".`,
|
|
34
|
+
);
|
|
35
|
+
const report =
|
|
36
|
+
staged.length === 0
|
|
37
|
+
? { diagnostics: [] }
|
|
38
|
+
: yield* withStagedContent(config.root, edited, biomeReport(config.root, BIOME, config.exceptions, staged, config.nonEffectFolders)).pipe(
|
|
39
|
+
Effect.mapError(failed),
|
|
40
|
+
);
|
|
41
|
+
const findings = yield* failingFindings({ readText: yield* manifestReader(config.root) }, report.diagnostics).pipe(Effect.mapError(failed));
|
|
42
|
+
const violations = findings.map((finding): Violation => ({ ...finding, level: "error", rule: `biome/${finding.subject ?? "internal"}` }));
|
|
43
|
+
const baseline = yield* readBaseline(config);
|
|
44
|
+
const evaluated = evaluate(violations, registryEntries(config.exceptions), baseline.entries, config);
|
|
45
|
+
const outcome: Outcome = { ...evaluated, looseBaseline: [], staleBaseline: [], staleRegistry: [], unsplitBaseline: [] };
|
|
46
|
+
const context: ReportContext = {
|
|
47
|
+
baseline: config.baseline,
|
|
48
|
+
checked: staged.length,
|
|
49
|
+
descriptions: new Map(config.active.map((rule) => [rule.id, rule.description])),
|
|
50
|
+
registry: config.exceptions.length === 0 ? config.registry : `${relative(config.root, config.file)} exceptions`,
|
|
51
|
+
};
|
|
52
|
+
yield* Console.log(renderFindings(outcome, context));
|
|
53
|
+
return passes(outcome);
|
|
54
|
+
});
|
|
@@ -0,0 +1,111 @@
|
|
|
1
|
+
import * as NodePath from "@effect/platform-node/NodePath";
|
|
2
|
+
import { Console, Effect, FileSystem, Path } from "effect";
|
|
3
|
+
import type { ChildProcessSpawner } from "effect/process";
|
|
4
|
+
import { SetupFailure } from "#failure.ts";
|
|
5
|
+
import { gitOrFail } from "#git/command.ts";
|
|
6
|
+
import { shellWords } from "#hooks/command.ts";
|
|
7
|
+
import { orWhenAbsent } from "#inventory/filesystem.ts";
|
|
8
|
+
|
|
9
|
+
type WorkingCopy =
|
|
10
|
+
| { readonly kind: "absent"; readonly path: string }
|
|
11
|
+
| { readonly blob: string; readonly bytes: Uint8Array; readonly kind: "file"; readonly mode: number; readonly path: string }
|
|
12
|
+
| { readonly kind: "link"; readonly path: string; readonly target: string };
|
|
13
|
+
|
|
14
|
+
function failed(error: { readonly message: string }): SetupFailure {
|
|
15
|
+
return new SetupFailure({ cause: error, message: error.message });
|
|
16
|
+
}
|
|
17
|
+
|
|
18
|
+
function recovery(copy: WorkingCopy): string {
|
|
19
|
+
const path = shellWords([copy.path]);
|
|
20
|
+
switch (copy.kind) {
|
|
21
|
+
case "absent":
|
|
22
|
+
return `rm -f ${path}`;
|
|
23
|
+
case "file":
|
|
24
|
+
return `git cat-file blob ${copy.blob} > ${path} && chmod ${copy.mode.toString(8)} ${path}`;
|
|
25
|
+
case "link":
|
|
26
|
+
return `ln -sfn ${shellWords([copy.target])} ${path}`;
|
|
27
|
+
}
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
function notice(root: string, copies: readonly WorkingCopy[]): string {
|
|
31
|
+
const [only] = copies;
|
|
32
|
+
const intro =
|
|
33
|
+
copies.length === 1 && only !== undefined
|
|
34
|
+
? `${only.path} changed after staging; Biome checks its staged content in place, then the working copy is put back. If the hook stops first, run this in ${root}:`
|
|
35
|
+
: `${copies.length} files changed after staging; Biome checks their staged content in place, then the working copies are put back. If the hook stops first, run these in ${root}:`;
|
|
36
|
+
return [`quality: ${intro}`, ...copies.map((copy) => ` ${recovery(copy)}`)].join("\n");
|
|
37
|
+
}
|
|
38
|
+
|
|
39
|
+
// The blob outlives a killed hook, so the printed command still recovers the working copy.
|
|
40
|
+
const setAside = Effect.fn("Hooks.setAside")(function* (
|
|
41
|
+
root: string,
|
|
42
|
+
path: string,
|
|
43
|
+
): Effect.fn.Return<WorkingCopy, SetupFailure, FileSystem.FileSystem | ChildProcessSpawner.ChildProcessSpawner> {
|
|
44
|
+
const { join } = yield* Path.Path.pipe(Effect.provide(NodePath.layer));
|
|
45
|
+
|
|
46
|
+
const fs = yield* FileSystem.FileSystem;
|
|
47
|
+
const at = join(root, path);
|
|
48
|
+
const info = yield* orWhenAbsent(at, fs.lstat(at), undefined).pipe(Effect.mapError(failed));
|
|
49
|
+
if (info === undefined) {
|
|
50
|
+
return { kind: "absent", path };
|
|
51
|
+
}
|
|
52
|
+
if (info.type === "SymbolicLink") {
|
|
53
|
+
return { kind: "link", path, target: yield* fs.readLink(at).pipe(Effect.mapError(failed)) };
|
|
54
|
+
}
|
|
55
|
+
if (info.type !== "File") {
|
|
56
|
+
return yield* new SetupFailure({ message: `${path} changed after staging into a ${info.type}, so the staged check cannot set it aside.` });
|
|
57
|
+
}
|
|
58
|
+
const bytes = yield* fs.readFile(at).pipe(Effect.mapError(failed));
|
|
59
|
+
const blob = (yield* gitOrFail(root, ["hash-object", "-w", "--no-filters", "--", path])).trim();
|
|
60
|
+
return { blob, bytes, kind: "file", mode: info.mode & 0o7777, path };
|
|
61
|
+
});
|
|
62
|
+
|
|
63
|
+
const setAsideAll = Effect.fn("Hooks.setAsideAll")(function* (root: string, paths: readonly string[]) {
|
|
64
|
+
const copies = yield* Effect.forEach(paths, (path) => setAside(root, path));
|
|
65
|
+
yield* Console.log(notice(root, copies));
|
|
66
|
+
return copies;
|
|
67
|
+
});
|
|
68
|
+
|
|
69
|
+
const putBack = Effect.fn("Hooks.putBack")(function* (root: string, copy: WorkingCopy) {
|
|
70
|
+
const { join } = yield* Path.Path.pipe(Effect.provide(NodePath.layer));
|
|
71
|
+
|
|
72
|
+
const fs = yield* FileSystem.FileSystem;
|
|
73
|
+
const at = join(root, copy.path);
|
|
74
|
+
yield* fs.remove(at, { force: true });
|
|
75
|
+
if (copy.kind === "file") {
|
|
76
|
+
yield* fs.writeFile(at, copy.bytes);
|
|
77
|
+
yield* fs.chmod(at, copy.mode);
|
|
78
|
+
}
|
|
79
|
+
if (copy.kind === "link") {
|
|
80
|
+
yield* fs.symlink(copy.target, at);
|
|
81
|
+
}
|
|
82
|
+
});
|
|
83
|
+
|
|
84
|
+
const restore = Effect.fn("Hooks.restore")(function* (root: string, copies: readonly WorkingCopy[]) {
|
|
85
|
+
const [, failures] = yield* Effect.partition(copies, (copy) => Effect.mapError(putBack(root, copy), (error) => ({ copy, error })));
|
|
86
|
+
if (failures.length === 0) {
|
|
87
|
+
return;
|
|
88
|
+
}
|
|
89
|
+
const lines = failures.map(({ copy, error }) => `quality: cannot put back the working copy of ${copy.path}: ${error.message}\n ${recovery(copy)}`);
|
|
90
|
+
yield* Console.error(lines.join("\n"));
|
|
91
|
+
return yield* new SetupFailure({
|
|
92
|
+
message: `${failures.length === 1 ? "a working copy was" : `${failures.length} working copies were`} not put back; run the commands above in ${root}.`,
|
|
93
|
+
});
|
|
94
|
+
});
|
|
95
|
+
|
|
96
|
+
// Biome reports no diagnostics for content piped to its stdin, so a file edited again after staging shows Biome its staged content
|
|
97
|
+
// on disk until the check ends.
|
|
98
|
+
export const withStagedContent = Effect.fn("Hooks.withStagedContent")(function* <TValue, TError, TRequirements>(
|
|
99
|
+
root: string,
|
|
100
|
+
edited: readonly string[],
|
|
101
|
+
check: Effect.Effect<TValue, TError, TRequirements>,
|
|
102
|
+
) {
|
|
103
|
+
if (edited.length === 0) {
|
|
104
|
+
return yield* check;
|
|
105
|
+
}
|
|
106
|
+
return yield* Effect.acquireUseRelease(
|
|
107
|
+
setAsideAll(root, edited),
|
|
108
|
+
() => Effect.andThen(gitOrFail(root, ["--literal-pathspecs", "checkout-index", "--force", "--", ...edited]), check),
|
|
109
|
+
(copies) => restore(root, copies),
|
|
110
|
+
);
|
|
111
|
+
});
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
import { dirname, join } from "node:path";
|
|
2
|
-
import { Effect, type FileSystem } from "effect";
|
|
2
|
+
import { type Context, Effect, type FileSystem } from "effect";
|
|
3
3
|
import ts from "typescript";
|
|
4
|
+
import { DeclarationFiles } from "#adapters/declaration-files/service.ts";
|
|
4
5
|
import { type FilesystemFailure, readRequiredText } from "#inventory/filesystem.ts";
|
|
5
6
|
|
|
6
7
|
const portable = new Set([
|
|
@@ -67,8 +68,7 @@ const portable = new Set([
|
|
|
67
68
|
"structuredClone",
|
|
68
69
|
]);
|
|
69
70
|
|
|
70
|
-
function namesInDom(
|
|
71
|
-
const source = ts.createSourceFile(path, text, ts.ScriptTarget.Latest, true);
|
|
71
|
+
function namesInDom(source: ts.SourceFile): readonly string[] {
|
|
72
72
|
return source.statements.flatMap((statement) => {
|
|
73
73
|
if (ts.isVariableStatement(statement)) {
|
|
74
74
|
return statement.declarationList.declarations.flatMap(({ name }) => (ts.isIdentifier(name) ? [name.text] : []));
|
|
@@ -80,9 +80,11 @@ function namesInDom(path: string, text: string): readonly string[] {
|
|
|
80
80
|
export const browserNames = Effect.fn("Imports.browserNames")(function* (): Effect.fn.Return<
|
|
81
81
|
ReadonlySet<string>,
|
|
82
82
|
FilesystemFailure,
|
|
83
|
-
FileSystem.FileSystem
|
|
83
|
+
Context.Service.Identifier<typeof DeclarationFiles> | FileSystem.FileSystem
|
|
84
84
|
> {
|
|
85
85
|
const path = join(dirname(ts.getDefaultLibFilePath({})), "lib.dom.d.ts");
|
|
86
86
|
const text = yield* readRequiredText(path);
|
|
87
|
-
|
|
87
|
+
const declarations = yield* DeclarationFiles;
|
|
88
|
+
const source = yield* declarations.parse(path, text, { target: ts.ScriptTarget.Latest });
|
|
89
|
+
return new Set(namesInDom(source).filter((name) => !portable.has(name)));
|
|
88
90
|
});
|
|
@@ -0,0 +1,43 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import type { SourceFile } from "#rule.ts";
|
|
3
|
+
import { parse } from "#rules/parse.ts";
|
|
4
|
+
|
|
5
|
+
const DEFINE_MODULE = "@shivaedev/contract/defineModule.ts";
|
|
6
|
+
|
|
7
|
+
function definers(source: ts.SourceFile): ReadonlySet<string> {
|
|
8
|
+
return new Set(
|
|
9
|
+
source.statements.filter(ts.isImportDeclaration).flatMap((statement) => {
|
|
10
|
+
const clause = statement.importClause;
|
|
11
|
+
const bindings = clause?.namedBindings;
|
|
12
|
+
if (
|
|
13
|
+
clause === undefined
|
|
14
|
+
|| clause.isTypeOnly
|
|
15
|
+
|| bindings === undefined
|
|
16
|
+
|| !ts.isNamedImports(bindings)
|
|
17
|
+
|| !(ts.isStringLiteral(statement.moduleSpecifier) && statement.moduleSpecifier.text === DEFINE_MODULE)
|
|
18
|
+
) {
|
|
19
|
+
return [];
|
|
20
|
+
}
|
|
21
|
+
return bindings.elements
|
|
22
|
+
.filter((element) => !element.isTypeOnly && (element.propertyName ?? element.name).text === "defineModule")
|
|
23
|
+
.map((element) => element.name.text);
|
|
24
|
+
}),
|
|
25
|
+
);
|
|
26
|
+
}
|
|
27
|
+
|
|
28
|
+
export function callsDefineModule(file: SourceFile): boolean {
|
|
29
|
+
const source = file.text.includes("defineModule") ? parse(file) : undefined;
|
|
30
|
+
const names = source === undefined ? new Set<string>() : definers(source);
|
|
31
|
+
if (source === undefined || names.size === 0) {
|
|
32
|
+
return false;
|
|
33
|
+
}
|
|
34
|
+
let found = false;
|
|
35
|
+
function visit(node: ts.Node): void {
|
|
36
|
+
found ||= ts.isCallExpression(node) && ts.isIdentifier(node.expression) && names.has(node.expression.text);
|
|
37
|
+
if (!found) {
|
|
38
|
+
ts.forEachChild(node, visit);
|
|
39
|
+
}
|
|
40
|
+
}
|
|
41
|
+
visit(source);
|
|
42
|
+
return found;
|
|
43
|
+
}
|
|
@@ -2,6 +2,7 @@ import { Effect } from "effect";
|
|
|
2
2
|
import { compilePolicy } from "#imports/fences/compilePolicy.ts";
|
|
3
3
|
import { discoverFences } from "#imports/fences/discover.ts";
|
|
4
4
|
import type { Fence } from "#imports/fences/model.ts";
|
|
5
|
+
import { followedEdges, generatedFolders } from "#imports/generatedFolders.ts";
|
|
5
6
|
import { importGraph } from "#imports/graph.ts";
|
|
6
7
|
import type { RuleInputs } from "#rule.ts";
|
|
7
8
|
|
|
@@ -9,5 +10,6 @@ export const checkFences = Effect.fn("Imports.checkFences")(function* (inputs: R
|
|
|
9
10
|
const graph = yield* importGraph(inputs);
|
|
10
11
|
const fences = [...configured, ...(yield* discoverFences(inputs, graph.packages))];
|
|
11
12
|
const policy = yield* Effect.fromResult(compilePolicy(fences, { files: inputs.files, packages: graph.packages }));
|
|
12
|
-
|
|
13
|
+
const followed = { ...graph, ignoredEdges: followedEdges(generatedFolders(graph.packages), graph.ignoredEdges) };
|
|
14
|
+
return policy.flatMap((compiled) => compiled.evaluate(followed));
|
|
13
15
|
});
|
|
@@ -26,7 +26,7 @@ function graphOf(chain: Chain): FenceGraph | undefined {
|
|
|
26
26
|
const edges = files.map(
|
|
27
27
|
(from, index): ImportEdge => ({ from, kind: "import", line: 1, specifier: "", to: endpointOf(chain[index + 1] ?? from), type: false }),
|
|
28
28
|
);
|
|
29
|
-
return { edges, modules: files };
|
|
29
|
+
return { edges, ignoredEdges: [], modules: files };
|
|
30
30
|
}
|
|
31
31
|
|
|
32
32
|
function crossedBy(policy: readonly CompiledFence[], graph: FenceGraph): readonly string[] {
|
|
@@ -6,7 +6,7 @@ import type { ImportEdge, ImportGraph } from "#imports/graph.ts";
|
|
|
6
6
|
import { isTestCode } from "#naming/testName.ts";
|
|
7
7
|
import type { Finding } from "#rule.ts";
|
|
8
8
|
|
|
9
|
-
export type FenceGraph = Pick<ImportGraph, "edges" | "modules">;
|
|
9
|
+
export type FenceGraph = Pick<ImportGraph, "edges" | "ignoredEdges" | "modules">;
|
|
10
10
|
|
|
11
11
|
export type Evaluate = (graph: FenceGraph) => readonly Finding[];
|
|
12
12
|
|
|
@@ -49,7 +49,7 @@ function importFindings(fence: Fence, importer: (path: string) => boolean, to: M
|
|
|
49
49
|
|
|
50
50
|
function reachFindings(fence: Fence, importer: (path: string) => boolean, to: Matcher): Evaluate {
|
|
51
51
|
return (graph) => {
|
|
52
|
-
const edgesFrom = outgoing(graph.edges);
|
|
52
|
+
const edgesFrom = outgoing([...graph.edges, ...graph.ignoredEdges]);
|
|
53
53
|
return graph.modules.filter(importer).flatMap((module) =>
|
|
54
54
|
reachedFrom(module, edgesFrom, to).map((reached) => ({
|
|
55
55
|
file: module,
|
|
@@ -0,0 +1,28 @@
|
|
|
1
|
+
import { posix } from "node:path";
|
|
2
|
+
import type { ImportEdge } from "#imports/graph.ts";
|
|
3
|
+
import type { WorkspacePackage } from "#imports/workspace.ts";
|
|
4
|
+
|
|
5
|
+
const GENERATED = "src/generated";
|
|
6
|
+
|
|
7
|
+
// The generator of @shivaedev/build writes each project's output to src/generated, at the application root and in every workspace package.
|
|
8
|
+
export function generatedFolders(packages: readonly WorkspacePackage[]): readonly string[] {
|
|
9
|
+
return [GENERATED, ...packages.map((owner) => posix.join(owner.directory, GENERATED))];
|
|
10
|
+
}
|
|
11
|
+
|
|
12
|
+
function generatedFolderOf(folders: readonly string[], path: string): string | undefined {
|
|
13
|
+
return folders.find((folder) => path.startsWith(`${folder}/`));
|
|
14
|
+
}
|
|
15
|
+
|
|
16
|
+
export function generatedFrom(folders: readonly string[], path: string): string | undefined {
|
|
17
|
+
const folder = generatedFolderOf(folders, path);
|
|
18
|
+
return folder === undefined ? undefined : posix.join(posix.dirname(folder), path.slice(folder.length + 1));
|
|
19
|
+
}
|
|
20
|
+
|
|
21
|
+
// A generated client type-imports its module so the compiler checks they match; the import is erased.
|
|
22
|
+
export function ownModuleTypeImport(folders: readonly string[], edge: ImportEdge): boolean {
|
|
23
|
+
return edge.type && edge.to.kind === "file" && generatedFrom(folders, edge.from) === edge.to.path;
|
|
24
|
+
}
|
|
25
|
+
|
|
26
|
+
export function followedEdges(folders: readonly string[], edges: readonly ImportEdge[]): readonly ImportEdge[] {
|
|
27
|
+
return edges.filter((edge) => !ownModuleTypeImport(folders, edge));
|
|
28
|
+
}
|
package/src/imports/graph.ts
CHANGED
|
@@ -1,8 +1,14 @@
|
|
|
1
|
+
import { relative } from "node:path";
|
|
1
2
|
import { Effect } from "effect";
|
|
3
|
+
import type { ChildProcessSpawner } from "effect/process";
|
|
4
|
+
import type { ImportAnalysisFailure } from "#adapters/ImportAnalysisFailure.ts";
|
|
2
5
|
import { ImportCompiler } from "#adapters/import-compiler/service.ts";
|
|
3
6
|
import type { Endpoint } from "#imports/Endpoint.ts";
|
|
4
7
|
import type { ImportKind } from "#imports/extract.ts";
|
|
5
8
|
import { type WorkspacePackage, workspacePackages } from "#imports/workspace.ts";
|
|
9
|
+
import { posix } from "#inventory/ignoreScope.ts";
|
|
10
|
+
import { linesOf } from "#inventory/linesOf.ts";
|
|
11
|
+
import { ignoredAmong } from "#inventory/trackedPaths.ts";
|
|
6
12
|
import type { Findings, RuleInputs, SourceFile } from "#rule.ts";
|
|
7
13
|
|
|
8
14
|
export interface ImportEdge {
|
|
@@ -19,14 +25,48 @@ export type UnresolvedImport = Omit<ImportEdge, "to"> & { readonly missing: stri
|
|
|
19
25
|
export interface ImportGraph {
|
|
20
26
|
readonly configFindings: Findings;
|
|
21
27
|
readonly edges: readonly ImportEdge[];
|
|
28
|
+
// Imports of the modules git ignores that the sources reach, such as generated output: rules follow them but never report them.
|
|
29
|
+
readonly ignoredEdges: readonly ImportEdge[];
|
|
30
|
+
readonly ignoredModules: readonly string[];
|
|
22
31
|
readonly modules: readonly string[];
|
|
23
32
|
readonly packages: readonly WorkspacePackage[];
|
|
24
33
|
readonly unresolved: readonly UnresolvedImport[];
|
|
25
34
|
}
|
|
26
35
|
|
|
36
|
+
const MODULE = /\.[cm]?[jt]sx?$/u;
|
|
37
|
+
|
|
38
|
+
const NODE_MODULES = /(?:^|\/)node_modules\//u;
|
|
39
|
+
|
|
40
|
+
function unlisted(listed: ReadonlySet<string>, edges: readonly ImportEdge[]): readonly string[] {
|
|
41
|
+
const paths = edges.flatMap((edge) => (edge.to.kind === "file" ? [edge.to.path] : []));
|
|
42
|
+
return [...new Set(paths)].filter((path) => !listed.has(path) && MODULE.test(path) && !NODE_MODULES.test(path) && !path.startsWith("../"));
|
|
43
|
+
}
|
|
44
|
+
|
|
45
|
+
const ignoredReach = Effect.fn("Imports.ignoredReach")(function* (
|
|
46
|
+
inputs: RuleInputs,
|
|
47
|
+
edges: readonly ImportEdge[],
|
|
48
|
+
follow: (files: readonly SourceFile[]) => Effect.Effect<readonly ImportEdge[], ImportAnalysisFailure>,
|
|
49
|
+
) {
|
|
50
|
+
const listed = new Set(inputs.files);
|
|
51
|
+
const modules: string[] = [];
|
|
52
|
+
const followed: ImportEdge[] = [];
|
|
53
|
+
for (let frontier = unlisted(listed, edges); frontier.length > 0; frontier = unlisted(listed, followed)) {
|
|
54
|
+
const ignored = (yield* ignoredAmong(inputs.root, frontier)).map((path) => posix(relative(inputs.root, path)));
|
|
55
|
+
for (const path of frontier) {
|
|
56
|
+
listed.add(path);
|
|
57
|
+
}
|
|
58
|
+
const files = yield* Effect.forEach(ignored, (path) =>
|
|
59
|
+
Effect.map(inputs.readText(path), (text) => (text === undefined ? [] : [{ lines: linesOf(text), path, text }])),
|
|
60
|
+
);
|
|
61
|
+
modules.push(...ignored);
|
|
62
|
+
followed.push(...(yield* follow(files.flat())));
|
|
63
|
+
}
|
|
64
|
+
return { ignoredEdges: followed, ignoredModules: modules };
|
|
65
|
+
});
|
|
66
|
+
|
|
27
67
|
const build = Effect.fn("Imports.build")(function* (inputs: RuleInputs) {
|
|
28
68
|
const compiler = yield* ImportCompiler;
|
|
29
|
-
const walked = yield* compiler.graph(inputs);
|
|
69
|
+
const { follow, ...walked } = yield* compiler.graph(inputs);
|
|
30
70
|
if (walked.modules.length === 0) {
|
|
31
71
|
return yield* Effect.die(
|
|
32
72
|
new Error(
|
|
@@ -34,11 +74,11 @@ const build = Effect.fn("Imports.build")(function* (inputs: RuleInputs) {
|
|
|
34
74
|
),
|
|
35
75
|
);
|
|
36
76
|
}
|
|
37
|
-
return { ...walked, packages: yield* workspacePackages(inputs) };
|
|
77
|
+
return { ...walked, ...(yield* ignoredReach(inputs, walked.edges, follow)), packages: yield* workspacePackages(inputs) };
|
|
38
78
|
});
|
|
39
79
|
|
|
40
80
|
type Graph = ReturnType<typeof build>;
|
|
41
|
-
const graphs = new WeakMap<readonly SourceFile[], Effect.Effect<ImportGraph, Effect.Error<Graph
|
|
81
|
+
const graphs = new WeakMap<readonly SourceFile[], Effect.Effect<ImportGraph, Effect.Error<Graph>, ChildProcessSpawner.ChildProcessSpawner>>();
|
|
42
82
|
|
|
43
83
|
// Import rules run on one scan, so they share the graph built from its sources.
|
|
44
84
|
export const importGraph = Effect.fn("Imports.importGraph")(function* (inputs: RuleInputs) {
|
|
@@ -50,3 +90,7 @@ export const importGraph = Effect.fn("Imports.importGraph")(function* (inputs: R
|
|
|
50
90
|
graphs.set(inputs.sources, graph);
|
|
51
91
|
return yield* graph;
|
|
52
92
|
});
|
|
93
|
+
|
|
94
|
+
export const ignoredModules = Effect.fn("Imports.ignoredModules")(function* (inputs: RuleInputs) {
|
|
95
|
+
return inputs.sources.some((file) => MODULE.test(file.path)) ? (yield* importGraph(inputs)).ignoredModules : [];
|
|
96
|
+
});
|
package/src/imports/runtime.ts
CHANGED
|
@@ -84,7 +84,12 @@ export const runtimeDeclarationProblems = Effect.fn("Imports.runtimeDeclarationP
|
|
|
84
84
|
return problems.flat();
|
|
85
85
|
});
|
|
86
86
|
|
|
87
|
-
|
|
87
|
+
// A defined module holds the run of each operation, so it is server code wherever it sits.
|
|
88
|
+
export const runtimeOf = Effect.fn("Imports.runtimeOf")(function* (
|
|
89
|
+
inputs: RuleInputs,
|
|
90
|
+
packages: readonly WorkspacePackage[],
|
|
91
|
+
definedModules: ReadonlySet<string>,
|
|
92
|
+
) {
|
|
88
93
|
const owners = [...packages, { directory: ".", name: "." }];
|
|
89
94
|
const manifests = new Map(
|
|
90
95
|
yield* Effect.forEach(owners, (owner) =>
|
|
@@ -104,5 +109,5 @@ export const runtimeOf = Effect.fn("Imports.runtimeOf")(function* (inputs: RuleI
|
|
|
104
109
|
);
|
|
105
110
|
const executable = new Set(owners.filter((owner) => hasExecutable(manifests.get(owner.directory))).map((owner) => owner.directory));
|
|
106
111
|
const policy = { adopted, declared, executable, packages };
|
|
107
|
-
return (path: string) => classifyRuntime(policy, path);
|
|
112
|
+
return (path: string): Runtime | undefined => (definedModules.has(path) ? "server" : classifyRuntime(policy, path));
|
|
108
113
|
});
|
|
@@ -3,10 +3,10 @@ import { Effect, Path } from "effect";
|
|
|
3
3
|
import { SetupFailure } from "#failure.ts";
|
|
4
4
|
import { run } from "#git/command.ts";
|
|
5
5
|
|
|
6
|
-
const listedPaths = Effect.fn("Inventory.listedPaths")(function* (directory: string, options: readonly string[],
|
|
6
|
+
const listedPaths = Effect.fn("Inventory.listedPaths")(function* (directory: string, options: readonly string[], paths: readonly string[] = ["."]) {
|
|
7
7
|
const { join } = yield* Path.Path.pipe(Effect.provide(NodePath.layer));
|
|
8
8
|
|
|
9
|
-
const result = yield* run(directory, ["ls-files", "-z", ...options, "--",
|
|
9
|
+
const result = yield* run(directory, ["ls-files", "-z", ...options, "--", ...paths]);
|
|
10
10
|
if (result.code !== 0) {
|
|
11
11
|
if (result.stderr.includes("not a git repository")) {
|
|
12
12
|
return undefined;
|
|
@@ -20,7 +20,7 @@ const listedPaths = Effect.fn("Inventory.listedPaths")(function* (directory: str
|
|
|
20
20
|
});
|
|
21
21
|
|
|
22
22
|
export const trackedPaths = Effect.fn("Inventory.trackedPaths")(function* (directory: string, path = ".") {
|
|
23
|
-
return (yield* listedPaths(directory, [], path)) ?? [];
|
|
23
|
+
return (yield* listedPaths(directory, [], [path])) ?? [];
|
|
24
24
|
});
|
|
25
25
|
|
|
26
26
|
export const ignoredTrackedPaths = Effect.fn("Inventory.ignoredTrackedPaths")(function* (directory: string) {
|
|
@@ -33,3 +33,10 @@ export const ignoredPaths = Effect.fn("Inventory.ignoredPaths")(function* (direc
|
|
|
33
33
|
const paths = yield* listedPaths(directory, ["--others", "--ignored", "--exclude-standard", "--directory"]);
|
|
34
34
|
return paths?.map((path) => resolve(path));
|
|
35
35
|
});
|
|
36
|
+
|
|
37
|
+
export const ignoredAmong = Effect.fn("Inventory.ignoredAmong")(function* (directory: string, paths: readonly string[]) {
|
|
38
|
+
if (paths.length === 0) {
|
|
39
|
+
return [];
|
|
40
|
+
}
|
|
41
|
+
return (yield* listedPaths(directory, ["--others", "--ignored", "--exclude-standard"], paths)) ?? [];
|
|
42
|
+
});
|