@shivaedev/quality 0.68.0 → 0.69.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (65) hide show
  1. package/CHANGELOG.md +16 -0
  2. package/README.md +20 -4
  3. package/dist/adapters/biome/withExceptionConfig.d.ts.map +1 -1
  4. package/dist/adapters/biome/withExceptionConfig.js +9 -3
  5. package/dist/adapters/biome/withExceptionConfig.js.map +1 -1
  6. package/dist/adapters/browserLibraryType.d.ts +3 -0
  7. package/dist/adapters/browserLibraryType.d.ts.map +1 -0
  8. package/dist/adapters/browserLibraryType.js +9 -0
  9. package/dist/adapters/browserLibraryType.js.map +1 -0
  10. package/dist/adapters/knip/configuration.d.ts.map +1 -1
  11. package/dist/adapters/knip/configuration.js +3 -1
  12. package/dist/adapters/knip/configuration.js.map +1 -1
  13. package/dist/adapters/knip/mockEntries.d.ts +3 -0
  14. package/dist/adapters/knip/mockEntries.d.ts.map +1 -0
  15. package/dist/adapters/knip/mockEntries.js +28 -0
  16. package/dist/adapters/knip/mockEntries.js.map +1 -0
  17. package/dist/adapters/outsideImportFindings.js +1 -1
  18. package/dist/adapters/outsideImportFindings.js.map +1 -1
  19. package/dist/adapters/reachableBuildEntries.d.ts.map +1 -1
  20. package/dist/adapters/reachableBuildEntries.js +2 -1
  21. package/dist/adapters/reachableBuildEntries.js.map +1 -1
  22. package/dist/adapters/spawnedEntries.d.ts +3 -0
  23. package/dist/adapters/spawnedEntries.d.ts.map +1 -0
  24. package/dist/adapters/spawnedEntries.js +36 -0
  25. package/dist/adapters/spawnedEntries.js.map +1 -0
  26. package/dist/inventory/programmaticEntries.d.ts.map +1 -1
  27. package/dist/inventory/programmaticEntries.js +3 -1
  28. package/dist/inventory/programmaticEntries.js.map +1 -1
  29. package/dist/rules/biome.d.ts.map +1 -1
  30. package/dist/rules/biome.js +3 -0
  31. package/dist/rules/biome.js.map +1 -1
  32. package/dist/rules/effect/failureFindings.d.ts.map +1 -1
  33. package/dist/rules/effect/failureFindings.js +5 -2
  34. package/dist/rules/effect/failureFindings.js.map +1 -1
  35. package/dist/rules/effect/failureHonesty.js +1 -1
  36. package/dist/rules/effect/failureHonesty.js.map +1 -1
  37. package/dist/rules/effect/serviceTypes.d.ts.map +1 -1
  38. package/dist/rules/effect/serviceTypes.js +2 -0
  39. package/dist/rules/effect/serviceTypes.js.map +1 -1
  40. package/dist/rules/exportImportFindings.d.ts +3 -0
  41. package/dist/rules/exportImportFindings.d.ts.map +1 -0
  42. package/dist/rules/exportImportFindings.js +40 -0
  43. package/dist/rules/exportImportFindings.js.map +1 -0
  44. package/dist/rules/files/folderNames.d.ts.map +1 -1
  45. package/dist/rules/files/folderNames.js +14 -6
  46. package/dist/rules/files/folderNames.js.map +1 -1
  47. package/dist/rules/manifestsExportsShape.d.ts.map +1 -1
  48. package/dist/rules/manifestsExportsShape.js +12 -26
  49. package/dist/rules/manifestsExportsShape.js.map +1 -1
  50. package/package.json +3 -3
  51. package/src/adapters/biome/withExceptionConfig.ts +9 -3
  52. package/src/adapters/browserLibraryType.ts +14 -0
  53. package/src/adapters/knip/configuration.ts +3 -1
  54. package/src/adapters/knip/mockEntries.ts +31 -0
  55. package/src/adapters/outsideImportFindings.ts +1 -1
  56. package/src/adapters/reachableBuildEntries.ts +2 -1
  57. package/src/adapters/spawnedEntries.ts +39 -0
  58. package/src/inventory/programmaticEntries.ts +3 -1
  59. package/src/rules/biome.ts +3 -0
  60. package/src/rules/effect/failureFindings.ts +6 -2
  61. package/src/rules/effect/failureHonesty.ts +1 -1
  62. package/src/rules/effect/serviceTypes.ts +2 -0
  63. package/src/rules/exportImportFindings.ts +44 -0
  64. package/src/rules/files/folderNames.ts +14 -6
  65. package/src/rules/manifestsExportsShape.ts +12 -28
@@ -3,6 +3,7 @@ import { Effect } from "effect";
3
3
  import { readPackageManifest } from "#adapters/manifestInventory.ts";
4
4
  import { workspacePackages } from "#imports/workspace.ts";
5
5
  import { defineRule, type Finding } from "#rule.ts";
6
+ import { exportImportFindings } from "#rules/exportImportFindings.ts";
6
7
 
7
8
  const PATTERN = "./*.ts";
8
9
 
@@ -13,6 +14,9 @@ function isMap(value: unknown): value is Readonly<Record<string, unknown>> {
13
14
  }
14
15
 
15
16
  function standardPattern(key: string, value: unknown, sourceOnly = false): boolean {
17
+ if (sourceOnly && key === "./*" && value === "./src/*") {
18
+ return true;
19
+ }
16
20
  if (!(key.startsWith("./") && key.endsWith(".ts")) || key.split("*").length !== 2) {
17
21
  return false;
18
22
  }
@@ -38,7 +42,9 @@ function exactAsset(key: string, value: unknown): boolean {
38
42
  }
39
43
 
40
44
  function finding(file: string, subject: string, reason: string, isPrivate: boolean): Finding {
41
- const sourceOnly = isPrivate ? ' For a private package, mapping "./*.ts" directly to "./src/*.ts" is also accepted.' : "";
45
+ const sourceOnly = isPrivate
46
+ ? ' For a private package, mapping "./*.ts" directly to "./src/*.ts", or "./*" to "./src/*" to preserve both .ts and .tsx extensions, is also accepted.'
47
+ : "";
42
48
  return {
43
49
  file,
44
50
  message: `${reason} Import the module at its file path through the single "${PATTERN}" wildcard (for example, "./server/better-auth/mount.ts" for "./src/server/better-auth/mount.ts"). Map it to source "./src/*.ts", types "./dist/*.d.ts" and default "./dist/*.js"; remove aliases and per-file module exports. Non-code assets must use their exact file paths.${sourceOnly}`,
@@ -75,31 +81,6 @@ function findingsIn(file: string, exports: unknown, isPrivate: boolean): readonl
75
81
  ];
76
82
  }
77
83
 
78
- function importFindings(file: string, imports: Readonly<Record<string, unknown>> = {}): readonly Finding[] {
79
- return Object.entries(imports).flatMap(([key, value]) => {
80
- if (key === "#*.ts" && value !== "./src/*.ts" && !standardPattern(PATTERN, value)) {
81
- return [
82
- {
83
- file,
84
- message:
85
- 'Import "#*.ts" must preserve the path from the source root. Map it to "./src/*.ts", or to source "./src/*.ts", types "./dist/*.d.ts" and default "./dist/*.js". Include subfolders in import specifiers, for example "#server/module.ts".',
86
- subject: key,
87
- },
88
- ];
89
- }
90
- if (key === "#test/*" && value !== "./src/test-support/*") {
91
- return [
92
- {
93
- file,
94
- message: 'Import "#test/*" must map to "./src/test-support/*". Keep test helpers under the source root’s test-support folder.',
95
- subject: key,
96
- },
97
- ];
98
- }
99
- return [];
100
- });
101
- }
102
-
103
84
  export const manifestsExportsShape = defineRule({
104
85
  check: (inputs) =>
105
86
  Effect.gen(function* () {
@@ -113,14 +94,17 @@ export const manifestsExportsShape = defineRule({
113
94
  if (file === "package.json" && manifest === undefined) {
114
95
  return [];
115
96
  }
116
- return [...findingsIn(file, manifest?.exports, manifest?.private === true), ...importFindings(file, manifest?.imports)];
97
+ return [
98
+ ...findingsIn(file, manifest?.exports, manifest?.private === true),
99
+ ...exportImportFindings(file, manifest?.imports, manifest?.private === true),
100
+ ];
117
101
  }),
118
102
  { concurrency: "unbounded" },
119
103
  );
120
104
  return findings.flat();
121
105
  }),
122
106
  description:
123
- "Packages export modules through one file-preserving wildcard without null blocks; declared #*.ts and #test/* imports preserve the source and test-support roots.",
107
+ "Packages export modules through one file-preserving wildcard without null blocks; declared #*.ts and #test/* imports preserve the source and test-support roots. Private packages may export ./src/* through ./* and map #test/* into their own test tree.",
124
108
  id: "manifests/exports-shape",
125
109
  registrable: false,
126
110
  });