@shivaedev/quality 0.67.3 → 0.68.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (106) hide show
  1. package/CHANGELOG.md +14 -0
  2. package/README.md +22 -5
  3. package/dist/PackageManifest.d.ts +1 -0
  4. package/dist/PackageManifest.d.ts.map +1 -1
  5. package/dist/PackageManifest.js +1 -1
  6. package/dist/PackageManifest.js.map +1 -1
  7. package/dist/adapters/biome/browserDiagnostic.d.ts +3 -0
  8. package/dist/adapters/biome/browserDiagnostic.d.ts.map +1 -0
  9. package/dist/adapters/biome/browserDiagnostic.js +93 -0
  10. package/dist/adapters/biome/browserDiagnostic.js.map +1 -0
  11. package/dist/adapters/biome/browserTargets.d.ts +19 -0
  12. package/dist/adapters/biome/browserTargets.d.ts.map +1 -0
  13. package/dist/adapters/biome/browserTargets.js +26 -0
  14. package/dist/adapters/biome/browserTargets.js.map +1 -0
  15. package/dist/adapters/biome/run.js +2 -2
  16. package/dist/adapters/biome/run.js.map +1 -1
  17. package/dist/adapters/biome/vitestEntry.d.ts +4 -0
  18. package/dist/adapters/biome/vitestEntry.d.ts.map +1 -0
  19. package/dist/adapters/biome/vitestEntry.js +27 -0
  20. package/dist/adapters/biome/vitestEntry.js.map +1 -0
  21. package/dist/adapters/biome/withExceptionConfig.d.ts +1 -1
  22. package/dist/adapters/biome/withExceptionConfig.d.ts.map +1 -1
  23. package/dist/adapters/biome/withExceptionConfig.js +4 -2
  24. package/dist/adapters/biome/withExceptionConfig.js.map +1 -1
  25. package/dist/adapters/knip/configuration.d.ts.map +1 -1
  26. package/dist/adapters/knip/configuration.js +1 -4
  27. package/dist/adapters/knip/configuration.js.map +1 -1
  28. package/dist/adapters/knip/run.js +3 -3
  29. package/dist/adapters/knip/run.js.map +1 -1
  30. package/dist/biome/recognizeDiagnostics.d.ts.map +1 -1
  31. package/dist/biome/recognizeDiagnostics.js +13 -6
  32. package/dist/biome/recognizeDiagnostics.js.map +1 -1
  33. package/dist/inventory/collect.js +2 -2
  34. package/dist/inventory/collect.js.map +1 -1
  35. package/dist/inventory/toolOwnedFiles.d.ts +4 -0
  36. package/dist/inventory/toolOwnedFiles.d.ts.map +1 -0
  37. package/dist/inventory/toolOwnedFiles.js +36 -0
  38. package/dist/inventory/toolOwnedFiles.js.map +1 -0
  39. package/dist/rules/files/otherNames.d.ts.map +1 -1
  40. package/dist/rules/files/otherNames.js +13 -1
  41. package/dist/rules/files/otherNames.js.map +1 -1
  42. package/dist/rules/stories/adapters/authTables.d.ts +3 -0
  43. package/dist/rules/stories/adapters/authTables.d.ts.map +1 -0
  44. package/dist/rules/stories/adapters/authTables.js +52 -0
  45. package/dist/rules/stories/adapters/authTables.js.map +1 -0
  46. package/dist/rules/stories/adapters/eventConsumption.d.ts +5 -0
  47. package/dist/rules/stories/adapters/eventConsumption.d.ts.map +1 -0
  48. package/dist/rules/stories/adapters/eventConsumption.js +30 -0
  49. package/dist/rules/stories/adapters/eventConsumption.js.map +1 -0
  50. package/dist/rules/stories/adapters/outcomeShapes.d.ts +5 -0
  51. package/dist/rules/stories/adapters/outcomeShapes.d.ts.map +1 -0
  52. package/dist/rules/stories/adapters/outcomeShapes.js +46 -0
  53. package/dist/rules/stories/adapters/outcomeShapes.js.map +1 -0
  54. package/dist/rules/stories/adapters/sqlTables.d.ts +5 -0
  55. package/dist/rules/stories/adapters/sqlTables.d.ts.map +1 -0
  56. package/dist/rules/stories/adapters/sqlTables.js +85 -0
  57. package/dist/rules/stories/adapters/sqlTables.js.map +1 -0
  58. package/dist/rules/stories/adapters/sqlTokens.d.ts +3 -0
  59. package/dist/rules/stories/adapters/sqlTokens.d.ts.map +1 -0
  60. package/dist/rules/stories/adapters/sqlTokens.js +30 -0
  61. package/dist/rules/stories/adapters/sqlTokens.js.map +1 -0
  62. package/dist/rules/stories/authSql.d.ts.map +1 -1
  63. package/dist/rules/stories/authSql.js +18 -111
  64. package/dist/rules/stories/authSql.js.map +1 -1
  65. package/dist/rules/stories/domainOutcomes.d.ts.map +1 -1
  66. package/dist/rules/stories/domainOutcomes.js +24 -17
  67. package/dist/rules/stories/domainOutcomes.js.map +1 -1
  68. package/dist/rules/stories/waitOnEvents.d.ts.map +1 -1
  69. package/dist/rules/stories/waitOnEvents.js +18 -2
  70. package/dist/rules/stories/waitOnEvents.js.map +1 -1
  71. package/package.json +3 -1
  72. package/src/PackageManifest.ts +1 -1
  73. package/src/adapters/biome/browserDiagnostic.ts +100 -0
  74. package/src/adapters/biome/browserTargets.ts +27 -0
  75. package/src/adapters/biome/run.ts +2 -2
  76. package/src/adapters/biome/vitestEntry.ts +37 -0
  77. package/src/adapters/biome/withExceptionConfig.ts +4 -2
  78. package/src/adapters/knip/configuration.ts +1 -4
  79. package/src/adapters/knip/run.ts +3 -3
  80. package/src/biome/recognizeDiagnostics.ts +12 -5
  81. package/src/inventory/collect.ts +2 -2
  82. package/src/inventory/toolOwnedFiles.ts +41 -0
  83. package/src/rules/files/otherNames.ts +13 -1
  84. package/src/rules/stories/adapters/authTables.ts +58 -0
  85. package/src/rules/stories/adapters/eventConsumption.ts +35 -0
  86. package/src/rules/stories/adapters/outcomeShapes.ts +57 -0
  87. package/src/rules/stories/adapters/sqlTables.ts +96 -0
  88. package/src/rules/stories/adapters/sqlTokens.ts +31 -0
  89. package/src/rules/stories/authSql.ts +20 -128
  90. package/src/rules/stories/domainOutcomes.ts +25 -18
  91. package/src/rules/stories/waitOnEvents.ts +24 -2
  92. package/dist/inventory/shadcnAlias.d.ts +0 -2
  93. package/dist/inventory/shadcnAlias.d.ts.map +0 -1
  94. package/dist/inventory/shadcnAlias.js +0 -73
  95. package/dist/inventory/shadcnAlias.js.map +0 -1
  96. package/dist/inventory/shadcnFiles.d.ts +0 -4
  97. package/dist/inventory/shadcnFiles.d.ts.map +0 -1
  98. package/dist/inventory/shadcnFiles.js +0 -83
  99. package/dist/inventory/shadcnFiles.js.map +0 -1
  100. package/dist/inventory/shadcnFolders.d.ts +0 -6
  101. package/dist/inventory/shadcnFolders.d.ts.map +0 -1
  102. package/dist/inventory/shadcnFolders.js +0 -27
  103. package/dist/inventory/shadcnFolders.js.map +0 -1
  104. package/src/inventory/shadcnAlias.ts +0 -88
  105. package/src/inventory/shadcnFiles.ts +0 -87
  106. package/src/inventory/shadcnFolders.ts +0 -36
@@ -1,124 +1,31 @@
1
- import { matchesGlob } from "node:path";
2
- import { Schema } from "effect";
1
+ import { Effect, Schema } from "effect";
3
2
  import { GlobDeclarations, globPatterns, validateGlobs } from "#config/globs.ts";
4
3
  import { defineRule } from "#rule.ts";
4
+ import { authTables } from "#rules/stories/adapters/authTables.ts";
5
+ import { sqlTables } from "#rules/stories/adapters/sqlTables.ts";
5
6
  import { matchesAny } from "./matchesAny.js";
6
7
  import { sqlTexts } from "./sqlText.js";
7
8
  const AuthSqlOptions = Schema.Struct({
8
9
  owners: GlobDeclarations,
9
10
  });
10
- const TOKENS = /--[^\n]*|\/\*[\s\S]*?\*\/|'(?:''|[^'])*'|"(?:""|[^"])*"|[\w$]+|[.,;()]/gu;
11
- const TABLE_START = new Set(["from", "join", "update", "into", "table", "truncate", "references", "using"]);
12
- const TABLE_END = new Set(["where", "group", "order", "having", "limit", "returning", "set", "values", "on", ";"]);
13
- const SKIP = new Set(["if", "not", "exists", "only", "table"]);
14
- const AUTH_TABLES = new Set(["user", "account", "session", "verification"]);
15
- const EXPRESSION_FROM = new Set(["extract", "overlay", "substring", "trim"]);
16
- const NON_TABLE_TARGETS = new Set([
17
- "all",
18
- "database",
19
- "domain",
20
- "foreign",
21
- "function",
22
- "language",
23
- "large",
24
- "parameter",
25
- "procedure",
26
- "routine",
27
- "schema",
28
- "sequence",
29
- "tablespace",
30
- "type",
31
- ]);
32
- function tableAt(tokens, index) {
33
- let next = index;
34
- while (SKIP.has(tokens[next]?.toLowerCase() ?? "")) {
35
- const only = tokens[next]?.toLowerCase() === "only";
36
- next += 1;
37
- if (only && tokens[next] === "(") {
38
- next += 1;
39
- }
40
- }
41
- while (tokens[next + 1] === ".") {
42
- next += 2;
43
- }
44
- return (tokens[next] ?? "").replaceAll('"', "").toLowerCase();
45
- }
46
- function tableBoundary(tokens, index, statementStart, fromIsTable) {
47
- const word = tokens[index]?.toLowerCase() ?? "";
48
- const permissions = ["grant", "revoke"].includes(tokens[statementStart]?.toLowerCase() ?? "");
49
- const roleTarget = permissions && (word === "to" || word === "from");
50
- const permissionTarget = permissions && word === "on" && !NON_TABLE_TARGETS.has(tokens[index + 1]?.toLowerCase() ?? "");
51
- const indexTarget = word === "on" && tokens.slice(statementStart, index).some((part) => part.toLowerCase() === "index");
52
- const tableClause = TABLE_START.has(word) && (word !== "from" || fromIsTable);
53
- return {
54
- ends: TABLE_END.has(word) || roleTarget,
55
- starts: !roleTarget && (tableClause || indexTarget || permissionTarget),
56
- };
57
- }
58
- function userForeignKeyAt(tokens, index, statementStart) {
59
- const statement = tokens.slice(statementStart, index).map((token) => token.toLowerCase());
60
- if (tokens[index]?.toLowerCase() !== "references" || !["create", "alter"].includes(statement[0] ?? "") || !statement.includes("table")) {
61
- return false;
62
- }
63
- let table = index + 1;
64
- while (tokens[table + 1] === ".") {
65
- table += 2;
66
- }
67
- if (tokens[table + 1] !== "(" || !["id", '"id"'].includes(tokens[table + 2]?.toLowerCase() ?? "") || tokens[table + 3] !== ")") {
68
- return false;
69
- }
70
- const remainder = tokens.slice(table + 4);
71
- const end = remainder.findIndex((token) => [",", ";", ")"].includes(token));
72
- const clause = remainder.slice(0, end === -1 ? undefined : end).join(" ");
73
- return /\bon delete (?:cascade|set null)\b/iu.test(clause);
74
- }
75
- function advanceContext(context, token, index, previous) {
76
- if (token === ";") {
77
- context.statementStart = index + 1;
78
- context.expressionFromDepths.clear();
79
- }
80
- if (token === "(") {
81
- context.depth += 1;
82
- if (EXPRESSION_FROM.has(previous?.toLowerCase() ?? "")) {
83
- context.expressionFromDepths.add(context.depth);
84
- }
85
- }
86
- if (token === ")") {
87
- context.tablesAtDepth.delete(context.depth);
88
- context.expressionFromDepths.delete(context.depth);
89
- context.depth -= 1;
90
- }
91
- }
92
- function authTableIn(text) {
93
- const tokens = [...text.matchAll(TOKENS)]
94
- .map(([token]) => token)
95
- .filter((token) => !(token.startsWith("--") || token.startsWith("/*") || token.startsWith("'")));
96
- const context = { depth: 0, expressionFromDepths: new Set(), statementStart: 0, tablesAtDepth: new Set() };
97
- return tokens.some((token, index) => {
98
- advanceContext(context, token, index, tokens[index - 1]);
99
- const boundary = tableBoundary(tokens, index, context.statementStart, !context.expressionFromDepths.has(context.depth));
100
- if (boundary.ends) {
101
- context.tablesAtDepth.delete(context.depth);
102
- }
103
- if (boundary.starts) {
104
- context.tablesAtDepth.add(context.depth);
105
- }
106
- return ((boundary.starts || (token === "," && context.tablesAtDepth.has(context.depth)))
107
- && AUTH_TABLES.has(tableAt(tokens, index + 1))
108
- && !(tableAt(tokens, index + 1) === "user" && userForeignKeyAt(tokens, index, context.statementStart)));
109
- });
110
- }
111
11
  export const authSql = defineRule({
112
- check: async ({ options, ...inputs }) => (await sqlTexts(inputs))
113
- .filter((query) => !matchesAny(query.file, globPatterns(options.owners)) && authTableIn(query.text))
114
- .map((query) => ({
115
- file: query.file,
116
- line: query.line,
117
- message: "SQL accesses a Better Auth table (user, account, session or verification). Use platform's auth API (@shivaedev/identity) for account data; app migrations may only reference user(id) with ON DELETE CASCADE or ON DELETE SET NULL. Only the configured auth-sql owners manage auth storage.",
118
- })),
12
+ check: ({ options, ...inputs }) => Effect.gen(function* () {
13
+ const queries = yield* Effect.promise(() => sqlTexts(inputs));
14
+ function owns(file) {
15
+ return matchesAny(file, globPatterns(options.owners));
16
+ }
17
+ const tables = authTables(queries, owns);
18
+ return queries
19
+ .filter((query) => !owns(query.file) && sqlTables(query.text).some((table) => tables.has(table.name) && !table.userReference))
20
+ .map((query) => ({
21
+ file: query.file,
22
+ line: query.line,
23
+ message: "SQL accesses a table owned by Better Auth or matching its schema. Use platform's auth API (@shivaedev/identity) for account data; app migrations may only reference user(id) with ON DELETE CASCADE or ON DELETE SET NULL. Only the configured auth-sql owners manage auth storage.",
24
+ }));
25
+ }),
119
26
  description: "Apps reference user IDs by foreign key and use identity for account data.",
120
27
  id: "boundaries/auth-sql",
121
28
  options: Schema.toStandardSchemaV1(AuthSqlOptions, { parseOptions: { errors: "all", onExcessProperty: "error" } }),
122
- validate: (context) => validateGlobs(context, matchesGlob),
29
+ validate: (context) => validateGlobs(context, (file, glob) => matchesAny(file, [glob])),
123
30
  });
124
31
  //# sourceMappingURL=authSql.js.map
@@ -1 +1 @@
1
- {"version":3,"file":"authSql.js","sourceRoot":"","sources":["../../../src/rules/stories/authSql.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,WAAW,CAAC;AACxC,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,gBAAgB,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjF,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAC7C,OAAO,EAAE,QAAQ,EAAE,MAAM,cAAc,CAAC;AAExC,MAAM,cAAc,GAAG,MAAM,CAAC,MAAM,CAAC;IACpC,MAAM,EAAE,gBAAgB;CACxB,CAAC,CAAC;AAEH,MAAM,MAAM,GAAG,0EAA0E,CAAC;AAC1F,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,OAAO,CAAC,CAAC,CAAC;AAC5G,MAAM,SAAS,GAAG,IAAI,GAAG,CAAC,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,QAAQ,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC,CAAC;AACnH,MAAM,IAAI,GAAG,IAAI,GAAG,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,QAAQ,EAAE,MAAM,EAAE,OAAO,CAAC,CAAC,CAAC;AAC/D,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,CAAC,MAAM,EAAE,SAAS,EAAE,SAAS,EAAE,cAAc,CAAC,CAAC,CAAC;AAC5E,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC,CAAC,SAAS,EAAE,SAAS,EAAE,WAAW,EAAE,MAAM,CAAC,CAAC,CAAC;AAC7E,MAAM,iBAAiB,GAAG,IAAI,GAAG,CAAC;IACjC,KAAK;IACL,UAAU;IACV,QAAQ;IACR,SAAS;IACT,UAAU;IACV,UAAU;IACV,OAAO;IACP,WAAW;IACX,WAAW;IACX,SAAS;IACT,QAAQ;IACR,UAAU;IACV,YAAY;IACZ,MAAM;CACN,CAAC,CAAC;AAEH,SAAS,OAAO,CAAC,MAAyB,EAAE,KAAa;IACxD,IAAI,IAAI,GAAG,KAAK,CAAC;IACjB,OAAO,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC;QACpD,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,EAAE,WAAW,EAAE,KAAK,MAAM,CAAC;QACpD,IAAI,IAAI,CAAC,CAAC;QACV,IAAI,IAAI,IAAI,MAAM,CAAC,IAAI,CAAC,KAAK,GAAG,EAAE,CAAC;YAClC,IAAI,IAAI,CAAC,CAAC;QACX,CAAC;IACF,CAAC;IACD,OAAO,MAAM,CAAC,IAAI,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC;QACjC,IAAI,IAAI,CAAC,CAAC;IACX,CAAC;IACD,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC,UAAU,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;AAC/D,CAAC;AAED,SAAS,aAAa,CAAC,MAAyB,EAAE,KAAa,EAAE,cAAsB,EAAE,WAAoB;IAC5G,MAAM,IAAI,GAAG,MAAM,CAAC,KAAK,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;IAChD,MAAM,WAAW,GAAG,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,cAAc,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,CAAC;IAC9F,MAAM,UAAU,GAAG,WAAW,IAAI,CAAC,IAAI,KAAK,IAAI,IAAI,IAAI,KAAK,MAAM,CAAC,CAAC;IACrE,MAAM,gBAAgB,GAAG,WAAW,IAAI,IAAI,KAAK,IAAI,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC,MAAM,CAAC,KAAK,GAAG,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,CAAC;IACxH,MAAM,WAAW,GAAG,IAAI,KAAK,IAAI,IAAI,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,EAAE,KAAK,OAAO,CAAC,CAAC;IACxH,MAAM,WAAW,GAAG,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,MAAM,IAAI,WAAW,CAAC,CAAC;IAC9E,OAAO;QACN,IAAI,EAAE,SAAS,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,UAAU;QACvC,MAAM,EAAE,CAAC,UAAU,IAAI,CAAC,WAAW,IAAI,WAAW,IAAI,gBAAgB,CAAC;KACvE,CAAC;AACH,CAAC;AAED,SAAS,gBAAgB,CAAC,MAAyB,EAAE,KAAa,EAAE,cAAsB;IACzF,MAAM,SAAS,GAAG,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC,CAAC;IAC1F,IAAI,MAAM,CAAC,KAAK,CAAC,EAAE,WAAW,EAAE,KAAK,YAAY,IAAI,CAAC,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,OAAO,CAAC,EAAE,CAAC;QACxI,OAAO,KAAK,CAAC;IACd,CAAC;IACD,IAAI,KAAK,GAAG,KAAK,GAAG,CAAC,CAAC;IACtB,OAAO,MAAM,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC;QAClC,KAAK,IAAI,CAAC,CAAC;IACZ,CAAC;IACD,IAAI,MAAM,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,GAAG,IAAI,CAAC,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,GAAG,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,IAAI,MAAM,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC;QAChI,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,SAAS,GAAG,MAAM,CAAC,KAAK,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC;IAC1C,MAAM,GAAG,GAAG,SAAS,CAAC,SAAS,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC;IAC5E,MAAM,MAAM,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAC1E,OAAO,sCAAsC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;AAC5D,CAAC;AASD,SAAS,cAAc,CAAC,OAAmB,EAAE,KAAa,EAAE,KAAa,EAAE,QAA4B;IACtG,IAAI,KAAK,KAAK,GAAG,EAAE,CAAC;QACnB,OAAO,CAAC,cAAc,GAAG,KAAK,GAAG,CAAC,CAAC;QACnC,OAAO,CAAC,oBAAoB,CAAC,KAAK,EAAE,CAAC;IACtC,CAAC;IACD,IAAI,KAAK,KAAK,GAAG,EAAE,CAAC;QACnB,OAAO,CAAC,KAAK,IAAI,CAAC,CAAC;QACnB,IAAI,eAAe,CAAC,GAAG,CAAC,QAAQ,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC;YACxD,OAAO,CAAC,oBAAoB,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;QACjD,CAAC;IACF,CAAC;IACD,IAAI,KAAK,KAAK,GAAG,EAAE,CAAC;QACnB,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;QAC5C,OAAO,CAAC,oBAAoB,CAAC,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;QACnD,OAAO,CAAC,KAAK,IAAI,CAAC,CAAC;IACpB,CAAC;AACF,CAAC;AAED,SAAS,WAAW,CAAC,IAAY;IAChC,MAAM,MAAM,GAAG,CAAC,GAAG,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;SACvC,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC;SACvB,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;IAClG,MAAM,OAAO,GAAe,EAAE,KAAK,EAAE,CAAC,EAAE,oBAAoB,EAAE,IAAI,GAAG,EAAE,EAAE,cAAc,EAAE,CAAC,EAAE,aAAa,EAAE,IAAI,GAAG,EAAE,EAAE,CAAC;IACvH,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,KAAK,EAAE,EAAE;QACnC,cAAc,CAAC,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC,CAAC;QACzD,MAAM,QAAQ,GAAG,aAAa,CAAC,MAAM,EAAE,KAAK,EAAE,OAAO,CAAC,cAAc,EAAE,CAAC,OAAO,CAAC,oBAAoB,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC;QACxH,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC;YACnB,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;QAC7C,CAAC;QACD,IAAI,QAAQ,CAAC,MAAM,EAAE,CAAC;YACrB,OAAO,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;QAC1C,CAAC;QACD,OAAO,CACN,CAAC,QAAQ,CAAC,MAAM,IAAI,CAAC,KAAK,KAAK,GAAG,IAAI,OAAO,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC;eAC7E,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,MAAM,EAAE,KAAK,GAAG,CAAC,CAAC,CAAC;eAC3C,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,KAAK,GAAG,CAAC,CAAC,KAAK,MAAM,IAAI,gBAAgB,CAAC,MAAM,EAAE,KAAK,EAAE,OAAO,CAAC,cAAc,CAAC,CAAC,CACtG,CAAC;IACH,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,MAAM,CAAC,MAAM,OAAO,GAAG,UAAU,CAAC;IACjC,KAAK,EAAE,KAAK,EAAE,EAAE,OAAO,EAAE,GAAG,MAAM,EAAE,EAAE,EAAE,CACvC,CAAC,MAAM,QAAQ,CAAC,MAAM,CAAC,CAAC;SACtB,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;SACnG,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;QAChB,IAAI,EAAE,KAAK,CAAC,IAAI;QAChB,IAAI,EAAE,KAAK,CAAC,IAAI;QAChB,OAAO,EACN,8RAA8R;KAC/R,CAAC,CAAC;IACL,WAAW,EAAE,2EAA2E;IACxF,EAAE,EAAE,qBAAqB;IACzB,OAAO,EAAE,MAAM,CAAC,kBAAkB,CAAC,cAAc,EAAE,EAAE,YAAY,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,gBAAgB,EAAE,OAAO,EAAE,EAAE,CAAC;IAClH,QAAQ,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,aAAa,CAAC,OAAO,EAAE,WAAW,CAAC;CAC1D,CAAC,CAAC"}
1
+ {"version":3,"file":"authSql.js","sourceRoot":"","sources":["../../../src/rules/stories/authSql.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,gBAAgB,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjF,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,UAAU,EAAE,MAAM,uCAAuC,CAAC;AACnE,OAAO,EAAE,SAAS,EAAE,MAAM,sCAAsC,CAAC;AACjE,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAC7C,OAAO,EAAE,QAAQ,EAAE,MAAM,cAAc,CAAC;AAExC,MAAM,cAAc,GAAG,MAAM,CAAC,MAAM,CAAC;IACpC,MAAM,EAAE,gBAAgB;CACxB,CAAC,CAAC;AAEH,MAAM,CAAC,MAAM,OAAO,GAAG,UAAU,CAAC;IACjC,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,GAAG,MAAM,EAAE,EAAE,EAAE,CACjC,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QACnB,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC;QAC9D,SAAS,IAAI,CAAC,IAAY;YACzB,OAAO,UAAU,CAAC,IAAI,EAAE,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC;QACvD,CAAC;QACD,MAAM,MAAM,GAAG,UAAU,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;QACzC,OAAO,OAAO;aACZ,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;aAC7H,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;YAChB,IAAI,EAAE,KAAK,CAAC,IAAI;YAChB,IAAI,EAAE,KAAK,CAAC,IAAI;YAChB,OAAO,EACN,qRAAqR;SACtR,CAAC,CAAC,CAAC;IACN,CAAC,CAAC;IACH,WAAW,EAAE,2EAA2E;IACxF,EAAE,EAAE,qBAAqB;IACzB,OAAO,EAAE,MAAM,CAAC,kBAAkB,CAAC,cAAc,EAAE,EAAE,YAAY,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,gBAAgB,EAAE,OAAO,EAAE,EAAE,CAAC;IAClH,QAAQ,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,aAAa,CAAC,OAAO,EAAE,CAAC,IAAI,EAAE,IAAI,EAAE,EAAE,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,CAAC,CAAC;CACvF,CAAC,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"domainOutcomes.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/domainOutcomes.ts"],"names":[],"mappings":"AAuCA,eAAO,MAAM,cAAc,oEAIzB,CAAC"}
1
+ {"version":3,"file":"domainOutcomes.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/domainOutcomes.ts"],"names":[],"mappings":"AAqCA,eAAO,MAAM,cAAc,oEAazB,CAAC"}
@@ -1,34 +1,41 @@
1
1
  import { Effect } from "effect";
2
2
  import ts from "typescript";
3
+ import { importGraph } from "#imports/graph.ts";
3
4
  import { defineRule } from "#rule.ts";
4
- import { bindsModule, importBindings } from "./importBindings.js";
5
+ import { internalValue, shapeModule } from "#rules/stories/adapters/outcomeShapes.ts";
6
+ import { importBindings } from "./importBindings.js";
7
+ import { storyOrigins } from "./origins.js";
5
8
  import { storySources } from "./sources.js";
6
- import { memberName, nodesWhere, syntaxFindings, unwrapped } from "./syntax.js";
7
- const MESSAGE = 'Uses an Exit, Cause or Result value or reads a _tag in a story. Have the kit\'s verb or readout return the outcome in the domain\'s words, such as "unauthorized" or "rolled back", and expect that; build failing inputs in a kit trait.';
8
- const SHAPES = ["Exit", "Cause", "Result"];
9
+ import { findingAt, memberName, nodesWhere, unwrapped } from "./syntax.js";
10
+ const MESSAGE = 'Uses an Exit, Cause or Result value or reads an internal outcome tag in a story. Have the kit\'s verb or readout return the outcome in the domain\'s words, such as "unauthorized" or "rolled back", and expect that; build failing inputs in a kit trait.';
9
11
  const OUTCOME_TAGS = new Set(["Failure", "Success"]);
10
- function shapeModule(source) {
11
- const bindings = importBindings(source);
12
- return (node) => {
13
- const value = unwrapped(node);
14
- return ts.isIdentifier(value) && SHAPES.some((shape) => bindsModule(bindings.get(value.text), shape, ["effect"]));
15
- };
16
- }
17
12
  function outcomeTag(node) {
18
13
  const name = ts.isIdentifier(node.name) || ts.isStringLiteral(node.name) ? node.name.text : undefined;
19
14
  const value = unwrapped(node.initializer);
20
15
  return name === "_tag" && ts.isStringLiteralLike(value) && OUTCOME_TAGS.has(value.text);
21
16
  }
22
- function shapeReads(source) {
23
- const fromShapeModule = shapeModule(source);
17
+ function shapeReads(source, checker) {
18
+ const bindings = importBindings(source);
24
19
  return nodesWhere(source, (node) => ((ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node))
25
- && (memberName(node) === "_tag" || fromShapeModule(node.expression)))
26
- || (ts.isBindingElement(node) && (node.propertyName ?? node.name).getText(source) === "_tag")
20
+ && (shapeModule(node.expression, bindings) || (memberName(node) === "_tag" && internalValue(node.expression, bindings, checker))))
21
+ || (ts.isBindingElement(node)
22
+ && (node.propertyName ?? node.name).getText(source) === "_tag"
23
+ && ts.isVariableDeclaration(node.parent.parent)
24
+ && node.parent.parent.initializer !== undefined
25
+ && internalValue(node.parent.parent.initializer, bindings, checker))
27
26
  || (ts.isPropertyAssignment(node) && outcomeTag(node)));
28
27
  }
29
28
  export const domainOutcomes = defineRule({
30
- check: (inputs) => Effect.map(storySources(inputs), (stories) => stories.flatMap((file) => syntaxFindings(file, shapeReads, MESSAGE))),
31
- description: "Story verbs and readouts return outcomes in the domain's words, not Exit, Cause or Result shapes or _tag reads.",
29
+ check: (inputs) => Effect.gen(function* () {
30
+ const stories = yield* storySources(inputs);
31
+ const origins = storyOrigins(inputs, yield* importGraph(inputs));
32
+ const checker = origins.checker;
33
+ return stories.flatMap((file) => {
34
+ const source = origins.source(file.path);
35
+ return source === undefined ? [] : shapeReads(source, checker).map((node) => ({ ...findingAt(source, node, MESSAGE), file: file.path }));
36
+ });
37
+ }),
38
+ description: "Story verbs and readouts return outcomes in the domain's words, not Exit, Cause or Result shapes or their internal tag reads.",
32
39
  id: "tests/domain-outcomes",
33
40
  });
34
41
  //# sourceMappingURL=domainOutcomes.js.map
@@ -1 +1 @@
1
- {"version":3,"file":"domainOutcomes.js","sourceRoot":"","sources":["../../../src/rules/stories/domainOutcomes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,WAAW,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAClE,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,UAAU,EAAE,UAAU,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEhF,MAAM,OAAO,GACZ,2OAA2O,CAAC;AAE7O,MAAM,MAAM,GAAG,CAAC,MAAM,EAAE,OAAO,EAAE,QAAQ,CAAC,CAAC;AAC3C,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC,CAAC,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,WAAW,CAAC,MAAqB;IACzC,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,OAAO,CAAC,IAAI,EAAE,EAAE;QACf,MAAM,KAAK,GAAG,SAAS,CAAC,IAAI,CAAC,CAAC;QAC9B,OAAO,EAAE,CAAC,YAAY,CAAC,KAAK,CAAC,IAAI,MAAM,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,WAAW,CAAC,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,KAAK,EAAE,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;IACnH,CAAC,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,IAA2B;IAC9C,MAAM,IAAI,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;IACtG,MAAM,KAAK,GAAG,SAAS,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC1C,OAAO,IAAI,KAAK,MAAM,IAAI,EAAE,CAAC,mBAAmB,CAAC,KAAK,CAAC,IAAI,YAAY,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;AACzF,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,eAAe,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC;IAC5C,OAAO,UAAU,CAChB,MAAM,EACN,CAAC,IAAI,EAAE,EAAE,CACR,CAAC,CAAC,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,CAAC;WACxE,CAAC,UAAU,CAAC,IAAI,CAAC,KAAK,MAAM,IAAI,eAAe,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC;WACnE,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,KAAK,MAAM,CAAC;WAC1F,CAAC,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,CAAC,CACvD,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,cAAc,GAAG,UAAU,CAAC;IACxC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC,CAAC;IACtI,WAAW,EAAE,iHAAiH;IAC9H,EAAE,EAAE,uBAAuB;CAC3B,CAAC,CAAC"}
1
+ {"version":3,"file":"domainOutcomes.js","sourceRoot":"","sources":["../../../src/rules/stories/domainOutcomes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,aAAa,EAAE,WAAW,EAAE,MAAM,0CAA0C,CAAC;AACtF,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAE3E,MAAM,OAAO,GACZ,4PAA4P,CAAC;AAE9P,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC,CAAC,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,UAAU,CAAC,IAA2B;IAC9C,MAAM,IAAI,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;IACtG,MAAM,KAAK,GAAG,SAAS,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC1C,OAAO,IAAI,KAAK,MAAM,IAAI,EAAE,CAAC,mBAAmB,CAAC,KAAK,CAAC,IAAI,YAAY,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;AACzF,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB,EAAE,OAAuB;IACjE,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,OAAO,UAAU,CAChB,MAAM,EACN,CAAC,IAAI,EAAE,EAAE,CACR,CAAC,CAAC,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,CAAC;WACxE,CAAC,WAAW,CAAC,IAAI,CAAC,UAAU,EAAE,QAAQ,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,KAAK,MAAM,IAAI,aAAa,CAAC,IAAI,CAAC,UAAU,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,CAAC,CAAC;WAChI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;eACzB,CAAC,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,KAAK,MAAM;eAC3D,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC;eAC5C,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,WAAW,KAAK,SAAS;eAC5C,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,WAAW,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC;WAClE,CAAC,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,CAAC,CACvD,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,cAAc,GAAG,UAAU,CAAC;IACxC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CACjB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QACnB,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC;QAC5C,MAAM,OAAO,GAAG,YAAY,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC;QACjE,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;QAChC,OAAO,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;YAC/B,MAAM,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACzC,OAAO,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,EAAE,GAAG,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,OAAO,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAC1I,CAAC,CAAC,CAAC;IACJ,CAAC,CAAC;IACH,WAAW,EAAE,+HAA+H;IAC5I,EAAE,EAAE,uBAAuB;CAC3B,CAAC,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"waitOnEvents.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAgEA,eAAO,MAAM,YAAY,mEAKvB,CAAC"}
1
+ {"version":3,"file":"waitOnEvents.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAsFA,eAAO,MAAM,YAAY,mEAKvB,CAAC"}
@@ -2,6 +2,7 @@ import { Effect } from "effect";
2
2
  import ts from "typescript";
3
3
  import { isTestSupport } from "#naming/testName.ts";
4
4
  import { defineRule } from "#rule.ts";
5
+ import { eventConsumption, repeatedEventConsumption } from "#rules/stories/adapters/eventConsumption.ts";
5
6
  import { failingSleep } from "#rules/stories/adapters/failureDeadline.ts";
6
7
  import { realTime } from "#rules/stories/adapters/realTime.ts";
7
8
  import { bindsModule, importBindings } from "./importBindings.js";
@@ -9,6 +10,7 @@ import { storyWaitSources } from "./sources.js";
9
10
  import { memberName, syntaxFindings, unwrapped } from "./syntax.js";
10
11
  const MESSAGE = "Waits on time in a story or reachable test-support: a sleep, a real timer, a wall-clock read such as Date.now(), polling with eventually or waitFor, fake timers or a clock adjustment in the spec. Settle on the engine's own signal through a kit verb, such as a Deferred the engine completes, story.runUntil or screenDriver's settle(). A deadline bounds a failure but does not prove completion; reaching it must fail the story. When time passing is the behaviour, name it in a kit verb that advances TestClock.";
11
12
  const VI_TIMING = /^(?:useFakeTimers|advanceTimers\w*|runAllTimers\w*|runOnlyPendingTimers\w*|runAllTicks|setSystemTime|waitFor|waitUntil)$/u;
13
+ const REPEATED_READS = new Set(["repeat", "repeatUntil", "repeatWhile"]);
12
14
  const CLOCK_CHANGES = new Set(["adjust", "setTime"]);
13
15
  function receiverOf(callee) {
14
16
  const receiver = ts.isPropertyAccessExpression(callee) ? unwrapped(callee.expression) : undefined;
@@ -22,7 +24,7 @@ function timedWait(call, bindings, support) {
22
24
  const callee = unwrapped(call.expression);
23
25
  if (ts.isIdentifier(callee)) {
24
26
  const binding = bindings.get(callee.text);
25
- return (binding?.imported === "eventually"
27
+ return ((binding?.imported === "eventually" && binding.module === "@shivaedev/test/eventually.ts")
26
28
  || (binding?.module === "effect/Effect" && binding.imported === "sleep" && !failingSleep(call, bindings))
27
29
  || realTime(call, bindings));
28
30
  }
@@ -34,15 +36,29 @@ function timedWait(call, bindings, support) {
34
36
  const binding = bindings.get(receiver.text);
35
37
  return (realTime(call, bindings)
36
38
  || (member === "sleep" && bindsModule(binding, "Effect", ["effect"]) && !failingSleep(call, bindings))
39
+ || (REPEATED_READS.has(member) && bindsModule(binding, "Effect", ["effect"]) && !repeatedEventConsumption(call, bindings))
37
40
  || (VI_TIMING.test(member) && vitestTiming(receiver, bindings))
38
41
  || (!support && CLOCK_CHANGES.has(member) && bindsModule(binding, "TestClock", ["effect/testing"])));
39
42
  }
43
+ function hasTimedCall(node, bindings, support) {
44
+ return ((ts.isCallExpression(node) && timedWait(node, bindings, support))
45
+ || (ts.isNewExpression(node) && realTime(node, bindings))
46
+ || ts.forEachChild(node, (child) => hasTimedCall(child, bindings, support)) === true);
47
+ }
48
+ function readsInCondition(node) {
49
+ return ts.isYieldExpression(node) || ts.forEachChild(node, readsInCondition) === true;
50
+ }
40
51
  function timedWaits(source) {
41
52
  const bindings = importBindings(source);
42
53
  const support = isTestSupport(source.fileName);
43
54
  const found = [];
44
55
  function visit(node) {
45
- if ((ts.isCallExpression(node) && timedWait(node, bindings, support)) || (ts.isNewExpression(node) && realTime(node, bindings))) {
56
+ if ((ts.isCallExpression(node) && timedWait(node, bindings, support))
57
+ || (ts.isNewExpression(node) && realTime(node, bindings))
58
+ || (ts.isWhileStatement(node)
59
+ && readsInCondition(node.expression)
60
+ && !eventConsumption(node, bindings)
61
+ && !hasTimedCall(node, bindings, support))) {
46
62
  found.push(node);
47
63
  }
48
64
  ts.forEachChild(node, visit);
@@ -1 +1 @@
1
- {"version":3,"file":"waitOnEvents.js","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,YAAY,EAAE,MAAM,4CAA4C,CAAC;AAC1E,OAAO,EAAE,QAAQ,EAAE,MAAM,qCAAqC,CAAC;AAC/D,OAAO,EAAE,WAAW,EAAsB,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACtF,OAAO,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEpE,MAAM,OAAO,GACZ,8fAA8f,CAAC;AAEhgB,MAAM,SAAS,GAAG,2HAA2H,CAAC;AAC9I,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,OAAO,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;AACnF,CAAC;AAED,SAAS,YAAY,CAAC,QAAuB,EAAE,QAA4C;IAC1F,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC,CAAC,WAAW,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,QAAQ,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAClH,CAAC;AAED,SAAS,SAAS,CAAC,IAAuB,EAAE,QAA4C,EAAE,OAAgB;IACzG,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC1C,OAAO,CACN,OAAO,EAAE,QAAQ,KAAK,YAAY;eAC/B,CAAC,OAAO,EAAE,MAAM,KAAK,eAAe,IAAI,OAAO,CAAC,QAAQ,KAAK,OAAO,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;eACtG,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAC3B,CAAC;IACH,CAAC;IACD,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;IACxC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC;IACpC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QAC5B,OAAO,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACjC,CAAC;IACD,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,CACN,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC;WACrB,CAAC,MAAM,KAAK,OAAO,IAAI,WAAW,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WACnG,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,YAAY,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;WAC5D,CAAC,CAAC,OAAO,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,WAAW,CAAC,OAAO,EAAE,WAAW,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,CACnG,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;IAC/C,MAAM,KAAK,GAAc,EAAE,CAAC;IAC5B,SAAS,KAAK,CAAC,IAAa;QAC3B,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,EAAE,CAAC;YACjI,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClB,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC9B,CAAC;IACD,KAAK,CAAC,MAAM,CAAC,CAAC;IACd,OAAO,KAAK,CAAC;AACd,CAAC;AAED,MAAM,CAAC,MAAM,YAAY,GAAG,UAAU,CAAC;IACtC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC,CAAC;IAC1I,WAAW,EAAE,uHAAuH;IACpI,EAAE,EAAE,sBAAsB;IAC1B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
1
+ {"version":3,"file":"waitOnEvents.js","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,gBAAgB,EAAE,wBAAwB,EAAE,MAAM,6CAA6C,CAAC;AACzG,OAAO,EAAE,YAAY,EAAE,MAAM,4CAA4C,CAAC;AAC1E,OAAO,EAAE,QAAQ,EAAE,MAAM,qCAAqC,CAAC;AAC/D,OAAO,EAAE,WAAW,EAAsB,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACtF,OAAO,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEpE,MAAM,OAAO,GACZ,8fAA8f,CAAC;AAEhgB,MAAM,SAAS,GAAG,2HAA2H,CAAC;AAC9I,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,aAAa,EAAE,aAAa,CAAC,CAAC,CAAC;AACzE,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,OAAO,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;AACnF,CAAC;AAED,SAAS,YAAY,CAAC,QAAuB,EAAE,QAA4C;IAC1F,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC,CAAC,WAAW,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,QAAQ,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAClH,CAAC;AAED,SAAS,SAAS,CAAC,IAAuB,EAAE,QAA4C,EAAE,OAAgB;IACzG,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC1C,OAAO,CACN,CAAC,OAAO,EAAE,QAAQ,KAAK,YAAY,IAAI,OAAO,CAAC,MAAM,KAAK,+BAA+B,CAAC;eACvF,CAAC,OAAO,EAAE,MAAM,KAAK,eAAe,IAAI,OAAO,CAAC,QAAQ,KAAK,OAAO,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;eACtG,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAC3B,CAAC;IACH,CAAC;IACD,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;IACxC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC;IACpC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QAC5B,OAAO,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACjC,CAAC;IACD,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,CACN,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC;WACrB,CAAC,MAAM,KAAK,OAAO,IAAI,WAAW,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WACnG,CAAC,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,WAAW,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,wBAAwB,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WACvH,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,YAAY,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;WAC5D,CAAC,CAAC,OAAO,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,WAAW,CAAC,OAAO,EAAE,WAAW,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,CACnG,CAAC;AACH,CAAC;AAED,SAAS,YAAY,CAAC,IAAa,EAAE,QAA4C,EAAE,OAAgB;IAClG,OAAO,CACN,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC;WAC9D,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WACtD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,YAAY,CAAC,KAAK,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,KAAK,IAAI,CACpF,CAAC;AACH,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAa;IACtC,OAAO,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,gBAAgB,CAAC,KAAK,IAAI,CAAC;AACvF,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;IAC/C,MAAM,KAAK,GAAc,EAAE,CAAC;IAC5B,SAAS,KAAK,CAAC,IAAa;QAC3B,IACC,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC;eAC9D,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;eACtD,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;mBACzB,gBAAgB,CAAC,IAAI,CAAC,UAAU,CAAC;mBACjC,CAAC,gBAAgB,CAAC,IAAI,EAAE,QAAQ,CAAC;mBACjC,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,EAC1C,CAAC;YACF,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClB,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC9B,CAAC;IACD,KAAK,CAAC,MAAM,CAAC,CAAC;IACd,OAAO,KAAK,CAAC;AACd,CAAC;AAED,MAAM,CAAC,MAAM,YAAY,GAAG,UAAU,CAAC;IACtC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC,CAAC;IAC1I,WAAW,EAAE,uHAAuH;IACpI,EAAE,EAAE,sBAAsB;IAC1B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@shivaedev/quality",
3
- "version": "0.67.3",
3
+ "version": "0.68.0",
4
4
  "description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
5
5
  "homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
6
6
  "bugs": {
@@ -52,11 +52,13 @@
52
52
  ],
53
53
  "dependencies": {
54
54
  "@biomejs/biome": "2.6.4",
55
+ "@mdn/browser-compat-data": "8.1.7",
55
56
  "@shivaedev/errors": "0.10.0",
56
57
  "@shivaedev/heavy-lock": "0.11.0",
57
58
  "@shivaedev/service": "0.8.0",
58
59
  "@shivaedev/skills": "0.8.0",
59
60
  "@vitest/coverage-v8": "5.0.5",
61
+ "browserslist": "4.29.5",
60
62
  "ignore": "7.0.14",
61
63
  "knip": "6.44.0",
62
64
  "sort-package-json": "4.1.0",
@@ -15,7 +15,7 @@ export const PackageManifest = Schema.Struct({
15
15
  packageManager: Schema.optionalKey(Schema.String),
16
16
  peerDependencies: Schema.optionalKey(Dependencies),
17
17
  private: Schema.optionalKey(Schema.Boolean),
18
- quality: Schema.optionalKey(Schema.Struct({ runtime: Schema.optionalKey(Schema.Unknown) })),
18
+ quality: Schema.optionalKey(Schema.Struct({ runtime: Schema.optionalKey(Schema.Unknown), toolOwned: Schema.optionalKey(Schema.Unknown) })),
19
19
  repository: Schema.optionalKey(Schema.Unknown),
20
20
  scripts: Schema.optionalKey(Dependencies),
21
21
  workspaces: Schema.optionalKey(Schema.Union([Schema.Array(Schema.String), Schema.Struct({ packages: Schema.Array(Schema.String) })])),
@@ -0,0 +1,100 @@
1
+ import bcd from "@mdn/browser-compat-data" with { type: "json" };
2
+ import type { BrowserName, CompatStatement, Identifier, SimpleSupportStatement } from "@mdn/browser-compat-data/types";
3
+ import type { Diagnostic } from "#biome/report.ts";
4
+ import { browserTargets } from "./browserTargets.ts";
5
+
6
+ const BROWSERS: Readonly<Record<string, BrowserName>> = {
7
+ "and_chr": "chrome_android",
8
+ "and_ff": "firefox_android",
9
+ chrome: "chrome",
10
+ edge: "edge",
11
+ firefox: "firefox",
12
+ ie: "ie",
13
+ "ios_saf": "safari_ios",
14
+ "op_mob": "opera_android",
15
+ opera: "opera",
16
+ safari: "safari",
17
+ samsung: "samsunginternet_android",
18
+ };
19
+
20
+ function version(value: string): number {
21
+ return Number.parseFloat(value.replace(/^≤/u, "").split("-")[0] ?? value);
22
+ }
23
+
24
+ function supports(statement: SimpleSupportStatement, target: string): boolean {
25
+ return (
26
+ typeof statement.version_added === "string"
27
+ && version(target) >= version(statement.version_added)
28
+ && !(typeof statement.version_removed === "string" && version(target) >= version(statement.version_removed))
29
+ && !statement.flags
30
+ && !statement.prefix
31
+ && !statement.alternative_name
32
+ && !statement.partial_implementation
33
+ );
34
+ }
35
+
36
+ function cssFunction(name: string, entries: Identifier | undefined): Identifier | undefined {
37
+ if (entries === undefined) {
38
+ return undefined;
39
+ }
40
+ const direct = entries[name];
41
+ if (direct?.__compat?.description?.includes(`${name}()`)) {
42
+ return direct;
43
+ }
44
+ for (const key of Object.keys(entries)) {
45
+ if (key !== "__compat") {
46
+ const found = cssFunction(name, entries[key]);
47
+ if (found !== undefined) {
48
+ return found;
49
+ }
50
+ }
51
+ }
52
+ return undefined;
53
+ }
54
+
55
+ function feature(message: string): CompatStatement | undefined {
56
+ const match = /^CSS (?<kind>pseudo-element|pseudo-class|property value|property|at-rule|function|media condition) (?<name>.+) isn't part/u.exec(
57
+ message,
58
+ );
59
+ if (match === null) {
60
+ return undefined;
61
+ }
62
+ const kind = match.groups?.kind;
63
+ const name = (match.groups?.name ?? "").toLowerCase();
64
+ let entry: Identifier | undefined;
65
+ if (kind === "pseudo-element" || kind === "pseudo-class") {
66
+ entry = bcd.css.selectors?.[name];
67
+ } else if (kind === "property value") {
68
+ const [property = "", value = ""] = name.split(": ");
69
+ entry = bcd.css.properties?.[property]?.[value];
70
+ } else if (kind === "property") {
71
+ entry = bcd.css.properties?.[name];
72
+ } else if (kind === "at-rule") {
73
+ entry = bcd.css["at-rules"]?.[name.replace(/^@/u, "")];
74
+ } else if (kind === "function") {
75
+ entry = cssFunction(name.replace(/\(\)$/u, ""), bcd.css.types);
76
+ } else if (kind === "media condition") {
77
+ entry = bcd.css["at-rules"]?.media?.[name];
78
+ }
79
+ return entry?.__compat;
80
+ }
81
+
82
+ export function browserDiagnostic(diagnostic: Diagnostic, file: string): Diagnostic | undefined {
83
+ const targets = browserTargets(file);
84
+ const compat = feature(diagnostic.message);
85
+ if (targets === undefined) {
86
+ return diagnostic;
87
+ }
88
+ const supported =
89
+ targets.length > 0
90
+ && compat !== undefined
91
+ && targets.every((target) => {
92
+ const [name = "", release = ""] = target.split(" ");
93
+ const browser = BROWSERS[name];
94
+ const support = browser === undefined ? undefined : compat.support[browser];
95
+ return (Array.isArray(support) ? support : [support]).some((statement) => statement !== undefined && supports(statement, release));
96
+ });
97
+ return supported
98
+ ? undefined
99
+ : { ...diagnostic, message: diagnostic.message.replace("the chosen Baseline", `the declared browser targets (${targets.join(", ")})`) };
100
+ }
@@ -0,0 +1,27 @@
1
+ import { dirname, relative } from "node:path";
2
+ import browserslist from "browserslist";
3
+ import { Effect } from "effect";
4
+ import { SetupFailure } from "#failure.ts";
5
+ import { posix } from "#inventory/ignoreScope.ts";
6
+ import { walk } from "#inventory/walk.ts";
7
+
8
+ export function browserTargets(file: string): readonly string[] | undefined {
9
+ const queries = browserslist.loadConfig({ env: "production", path: dirname(file) });
10
+ return queries === undefined ? undefined : browserslist(queries);
11
+ }
12
+
13
+ export const browserOverrides = Effect.fn("Biome.browserOverrides")(function* (root: string) {
14
+ const files = (yield* walk(root)).filter((file) => file.endsWith(".css"));
15
+ const declared = yield* Effect.try({
16
+ catch: (cause) => new SetupFailure({ cause, message: `Cannot resolve declared browser targets: ${String(cause)}` }),
17
+ try: () => files.filter((file) => browserTargets(file) !== undefined).map((file) => posix(relative(root, file))),
18
+ });
19
+ return declared.length === 0
20
+ ? []
21
+ : [
22
+ {
23
+ includes: declared,
24
+ linter: { rules: { suspicious: { useBaseline: { level: "error", options: { available: 0 } } } } },
25
+ },
26
+ ];
27
+ });
@@ -6,8 +6,8 @@ import { ChildProcess, ChildProcessSpawner } from "effect/process";
6
6
  import { withExceptionConfig } from "#adapters/biome/withExceptionConfig.ts";
7
7
  import type { ExceptionDeclaration } from "#exceptions/declaration.ts";
8
8
  import { posix } from "#inventory/ignoreScope.ts";
9
- import { shadcnFiles } from "#inventory/shadcnFiles.ts";
10
9
  import { skillCopies } from "#inventory/skillCopies.ts";
10
+ import { toolOwnedFiles } from "#inventory/toolOwnedFiles.ts";
11
11
 
12
12
  export interface BiomeRun {
13
13
  readonly code: number;
@@ -23,7 +23,7 @@ export const runBiome = Effect.fn("Biome.runBiome")(function* (
23
23
  exceptions: readonly ExceptionDeclaration[] = [],
24
24
  nonEffectFolders: readonly string[] = [],
25
25
  ) {
26
- const files = yield* shadcnFiles(root);
26
+ const files = yield* toolOwnedFiles(root);
27
27
  const copies = (yield* skillCopies(root)).paths.map((file) => posix(relative(root, file)));
28
28
  const toolOwned: readonly ExceptionDeclaration[] = [
29
29
  {
@@ -0,0 +1,37 @@
1
+ import ts from "typescript";
2
+ import type { Syntax } from "#biome/syntax.ts";
3
+
4
+ const ENTRIES = new Set(["it", "test", "beforeAll", "beforeEach", "afterAll", "afterEach"]);
5
+ const MODIFIERS = new Set(["only", "skip", "skipIf", "runIf", "concurrent", "sequential", "fails", "each"]);
6
+
7
+ function moduleOf(node: ts.Node): string | undefined {
8
+ for (let parent: ts.Node | undefined = node; parent !== undefined; parent = parent.parent) {
9
+ if (ts.isImportDeclaration(parent) && ts.isStringLiteral(parent.moduleSpecifier)) {
10
+ return parent.moduleSpecifier.text;
11
+ }
12
+ }
13
+ return undefined;
14
+ }
15
+
16
+ export function vitestEntry(expression: ts.Expression, { checker }: Syntax): boolean {
17
+ if (ts.isCallExpression(expression)) {
18
+ return vitestEntry(expression.expression, { checker, source: expression.getSourceFile() });
19
+ }
20
+ if (ts.isPropertyAccessExpression(expression)) {
21
+ if (MODIFIERS.has(expression.name.text)) {
22
+ return vitestEntry(expression.expression, { checker, source: expression.getSourceFile() });
23
+ }
24
+ const namespace = checker.getSymbolAtLocation(expression.expression);
25
+ return (
26
+ ENTRIES.has(expression.name.text)
27
+ && (namespace?.declarations ?? []).some((declaration) => ts.isNamespaceImport(declaration) && moduleOf(declaration) === "vitest")
28
+ );
29
+ }
30
+ return (
31
+ ts.isIdentifier(expression)
32
+ && (checker.getSymbolAtLocation(expression)?.declarations ?? []).some(
33
+ (declaration) =>
34
+ ts.isImportSpecifier(declaration) && ENTRIES.has((declaration.propertyName ?? declaration.name).text) && moduleOf(declaration) === "vitest",
35
+ )
36
+ );
37
+ }
@@ -3,6 +3,7 @@ import { Effect, Schema } from "effect";
3
3
  import { exceptionConfig } from "#biome/exceptionConfig.ts";
4
4
  import type { ExceptionDeclaration } from "#exceptions/declaration.ts";
5
5
  import { readOptionalText } from "#inventory/filesystem.ts";
6
+ import { browserOverrides } from "./browserTargets.ts";
6
7
  import { parseConfig, relocateConfig } from "./relocateConfig.ts";
7
8
 
8
9
  export const withExceptionConfig = Effect.fn("Biome.withExceptionConfig")(function* <TValue, TError, TRequirements>(
@@ -12,7 +13,8 @@ export const withExceptionConfig = Effect.fn("Biome.withExceptionConfig")(functi
12
13
  nonEffectFolders: readonly string[] = [],
13
14
  ) {
14
15
  const { includes, overrides } = exceptionConfig(declarations);
15
- if (includes.length === 0 && overrides.length === 0 && nonEffectFolders.length === 0) {
16
+ const targets = yield* browserOverrides(root);
17
+ if (includes.length === 0 && overrides.length === 0 && nonEffectFolders.length === 0 && targets.length === 0) {
16
18
  return yield* run([]);
17
19
  }
18
20
  const { config, text } = yield* Effect.gen(function* () {
@@ -39,7 +41,7 @@ export const withExceptionConfig = Effect.fn("Biome.withExceptionConfig")(functi
39
41
  const generated = {
40
42
  ...own,
41
43
  files: { ...files, includes: [...previousIncludes, ...includes.filter((pattern) => pattern !== "**"), "!.worktrees", "!.quality-biome-*"] },
42
- overrides: [...previousOverrides, ...overrides],
44
+ overrides: [...previousOverrides, ...overrides, ...targets],
43
45
  };
44
46
  const path = yield* relocateConfig(root, join(root, config), generated, nonEffectFolders);
45
47
  return yield* run([`--config-path=${path}`]);
@@ -3,7 +3,6 @@ import { readPackageManifest } from "#adapters/manifestInventory.ts";
3
3
  import { scriptPaths } from "#adapters/scriptPaths.ts";
4
4
  import { exportedModule, exportTargets } from "#imports/packageExports.ts";
5
5
  import { packageOf, workspacePackages } from "#imports/workspace.ts";
6
- import { SHADCN_FILE_GLOB } from "#inventory/shadcnFiles.ts";
7
6
  import type { RuleInputs } from "#rule.ts";
8
7
  import { KNIP_ISSUES } from "./findings.ts";
9
8
 
@@ -48,9 +47,7 @@ export async function knipConfiguration(inputs: RuleInputs, toolOwned: readonly
48
47
  const publicFiles = sources.filter((path) => exportedModule(manifest.exports, path));
49
48
  // Migration runners load these files from their directory, so no import reaches them.
50
49
  const migrations = sources.filter((path) => /(?:^|\/)server\/migrations\//u.test(path));
51
- const ui = toolOwned
52
- .filter((folder) => (packageOf(packages, `${folder}/component.ts`)?.directory ?? ".") === directory)
53
- .map((folder) => `${posix.relative(directory, folder)}/**/${SHADCN_FILE_GLOB}`);
50
+ const ui = toolOwned.filter((file) => (packageOf(packages, file)?.directory ?? ".") === directory).map((file) => posix.relative(directory, file));
54
51
  const styles = inputs.files
55
52
  .filter((path) => path.endsWith(".css") && (packageOf(packages, path)?.directory ?? ".") === directory)
56
53
  .map((path) => posix.relative(directory, path));
@@ -6,7 +6,7 @@ import { Effect, FileSystem, Stream } from "effect";
6
6
  import { ChildProcess, ChildProcessSpawner } from "effect/process";
7
7
  import { readPackageManifest } from "#adapters/manifestInventory.ts";
8
8
  import { programmaticEntries } from "#inventory/programmaticEntries.ts";
9
- import { shadcnFolders } from "#inventory/shadcnFolders.ts";
9
+ import { toolOwnedFiles } from "#inventory/toolOwnedFiles.ts";
10
10
  import type { RuleInputs } from "#rule.ts";
11
11
  import { knipConfiguration } from "./configuration.ts";
12
12
  import { entryPointFindings } from "./entryPointFindings.ts";
@@ -26,9 +26,9 @@ export const runKnip = Effect.fn("Knip.runKnip")(function* (inputs: RuleInputs)
26
26
  if ((yield* Effect.promise(() => readPackageManifest(inputs.readText, "package.json"))) === undefined) {
27
27
  return [];
28
28
  }
29
- const folders = yield* shadcnFolders(inputs.root);
29
+ const files = yield* toolOwnedFiles(inputs.root);
30
30
  const entries = yield* programmaticEntries(inputs);
31
- const configuration = yield* Effect.promise(() => knipConfiguration(inputs, folders, entries));
31
+ const configuration = yield* Effect.promise(() => knipConfiguration(inputs, files, entries));
32
32
  const checked = new Set([...inputs.files, ...Object.keys(configuration.workspaces).map((directory) => posix.join(directory, "package.json"))]);
33
33
  const findings = yield* Effect.scoped(
34
34
  Effect.gen(function* () {