@shivaedev/quality 0.65.0 → 0.66.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (134) hide show
  1. package/CHANGELOG.md +8 -0
  2. package/README.md +11 -3
  3. package/dist/adapters/callerContextData.d.ts +3 -0
  4. package/dist/adapters/callerContextData.d.ts.map +1 -0
  5. package/dist/adapters/callerContextData.js +42 -0
  6. package/dist/adapters/callerContextData.js.map +1 -0
  7. package/dist/adapters/contextCaptureFindings.d.ts +4 -0
  8. package/dist/adapters/contextCaptureFindings.d.ts.map +1 -0
  9. package/dist/adapters/contextCaptureFindings.js +49 -0
  10. package/dist/adapters/contextCaptureFindings.js.map +1 -0
  11. package/dist/adapters/import-compiler/browserChecker.d.ts +4 -0
  12. package/dist/adapters/import-compiler/browserChecker.d.ts.map +1 -0
  13. package/dist/adapters/import-compiler/browserChecker.js +4 -0
  14. package/dist/adapters/import-compiler/browserChecker.js.map +1 -0
  15. package/dist/adapters/import-compiler/departures.d.ts +5 -0
  16. package/dist/adapters/import-compiler/departures.d.ts.map +1 -0
  17. package/dist/adapters/import-compiler/departures.js +5 -0
  18. package/dist/adapters/import-compiler/departures.js.map +1 -0
  19. package/dist/adapters/import-compiler/graph.d.ts +4 -0
  20. package/dist/adapters/import-compiler/graph.d.ts.map +1 -0
  21. package/dist/adapters/import-compiler/graph.js +6 -0
  22. package/dist/adapters/import-compiler/graph.js.map +1 -0
  23. package/dist/adapters/import-compiler/service.d.ts +10 -0
  24. package/dist/adapters/import-compiler/service.d.ts.map +1 -0
  25. package/dist/adapters/import-compiler/service.js +16 -0
  26. package/dist/adapters/import-compiler/service.js.map +1 -0
  27. package/dist/adapters/initializerDependency.d.ts +3 -0
  28. package/dist/adapters/initializerDependency.d.ts.map +1 -0
  29. package/dist/adapters/initializerDependency.js +53 -0
  30. package/dist/adapters/initializerDependency.js.map +1 -0
  31. package/dist/adapters/serviceDefinitionProblems.js +1 -1
  32. package/dist/adapters/serviceDefinitionProblems.js.map +1 -1
  33. package/dist/adapters/serviceFolderFindings.d.ts.map +1 -1
  34. package/dist/adapters/serviceFolderFindings.js +12 -0
  35. package/dist/adapters/serviceFolderFindings.js.map +1 -1
  36. package/dist/adapters/serviceModelFindings.d.ts +4 -0
  37. package/dist/adapters/serviceModelFindings.d.ts.map +1 -0
  38. package/dist/adapters/serviceModelFindings.js +48 -0
  39. package/dist/adapters/serviceModelFindings.js.map +1 -0
  40. package/dist/adapters/serviceModelSyntax.d.ts +5 -0
  41. package/dist/adapters/serviceModelSyntax.d.ts.map +1 -0
  42. package/dist/adapters/serviceModelSyntax.js +53 -0
  43. package/dist/adapters/serviceModelSyntax.js.map +1 -0
  44. package/dist/adapters/serviceOperationProblems.d.ts +8 -0
  45. package/dist/adapters/serviceOperationProblems.d.ts.map +1 -0
  46. package/dist/adapters/serviceOperationProblems.js +108 -0
  47. package/dist/adapters/serviceOperationProblems.js.map +1 -0
  48. package/dist/adapters/serviceStateProblems.d.ts +7 -0
  49. package/dist/adapters/serviceStateProblems.d.ts.map +1 -0
  50. package/dist/adapters/serviceStateProblems.js +66 -0
  51. package/dist/adapters/serviceStateProblems.js.map +1 -0
  52. package/dist/imports/browserGlobals.js +1 -1
  53. package/dist/imports/browserGlobals.js.map +1 -1
  54. package/dist/imports/departures.js +1 -1
  55. package/dist/imports/departures.js.map +1 -1
  56. package/dist/imports/graph.js +1 -1
  57. package/dist/imports/graph.js.map +1 -1
  58. package/dist/rules/builtIn.d.ts +2 -2
  59. package/dist/rules/builtIn.d.ts.map +1 -1
  60. package/dist/rules/builtIn.js +2 -20
  61. package/dist/rules/builtIn.js.map +1 -1
  62. package/dist/rules/effect/contextCapture.d.ts +2 -0
  63. package/dist/rules/effect/contextCapture.d.ts.map +1 -0
  64. package/dist/rules/effect/contextCapture.js +9 -0
  65. package/dist/rules/effect/contextCapture.js.map +1 -0
  66. package/dist/rules/effect/policy.d.ts +2 -0
  67. package/dist/rules/effect/policy.d.ts.map +1 -0
  68. package/dist/rules/effect/policy.js +27 -0
  69. package/dist/rules/effect/policy.js.map +1 -0
  70. package/dist/rules/effect/serviceCatalog.d.ts +2 -2
  71. package/dist/rules/effect/serviceCatalog.d.ts.map +1 -1
  72. package/dist/rules/effect/serviceCatalog.js +14 -10
  73. package/dist/rules/effect/serviceCatalog.js.map +1 -1
  74. package/dist/rules/effect/serviceDefinitionAssembly.js +1 -1
  75. package/dist/rules/effect/serviceDefinitionAssembly.js.map +1 -1
  76. package/dist/rules/effect/serviceFolders.js +1 -1
  77. package/dist/rules/effect/serviceFolders.js.map +1 -1
  78. package/dist/rules/effect/serviceModel.d.ts +2 -0
  79. package/dist/rules/effect/serviceModel.d.ts.map +1 -0
  80. package/dist/rules/effect/serviceModel.js +9 -0
  81. package/dist/rules/effect/serviceModel.js.map +1 -0
  82. package/dist/rules/effect/serviceTypes.d.ts +2 -2
  83. package/dist/rules/effect/serviceTypes.d.ts.map +1 -1
  84. package/dist/rules/effect/serviceTypes.js +15 -3
  85. package/dist/rules/effect/serviceTypes.js.map +1 -1
  86. package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
  87. package/dist/rules/files/namedAfterExport.js +16 -3
  88. package/dist/rules/files/namedAfterExport.js.map +1 -1
  89. package/package.json +4 -4
  90. package/src/adapters/callerContextData.ts +46 -0
  91. package/src/adapters/contextCaptureFindings.ts +58 -0
  92. package/src/adapters/import-compiler/browserChecker.ts +5 -0
  93. package/src/adapters/import-compiler/departures.ts +9 -0
  94. package/src/adapters/import-compiler/graph.ts +9 -0
  95. package/src/adapters/import-compiler/service.ts +17 -0
  96. package/src/adapters/initializerDependency.ts +57 -0
  97. package/src/adapters/serviceDefinitionProblems.ts +1 -1
  98. package/src/adapters/serviceFolderFindings.ts +14 -0
  99. package/src/adapters/serviceModelFindings.ts +52 -0
  100. package/src/adapters/serviceModelSyntax.ts +58 -0
  101. package/src/adapters/serviceOperationProblems.ts +131 -0
  102. package/src/adapters/serviceStateProblems.ts +86 -0
  103. package/src/imports/browserGlobals.ts +1 -1
  104. package/src/imports/departures.ts +1 -1
  105. package/src/imports/graph.ts +1 -1
  106. package/src/rules/builtIn.ts +2 -20
  107. package/src/rules/effect/contextCapture.ts +10 -0
  108. package/src/rules/effect/policy.ts +27 -0
  109. package/src/rules/effect/serviceCatalog.ts +15 -10
  110. package/src/rules/effect/serviceDefinitionAssembly.ts +1 -1
  111. package/src/rules/effect/serviceFolders.ts +1 -1
  112. package/src/rules/effect/serviceModel.ts +10 -0
  113. package/src/rules/effect/serviceTypes.ts +15 -3
  114. package/src/rules/files/namedAfterExport.ts +16 -3
  115. package/dist/adapters/ImportCompiler.d.ts +0 -10
  116. package/dist/adapters/ImportCompiler.d.ts.map +0 -1
  117. package/dist/adapters/ImportCompiler.js +0 -16
  118. package/dist/adapters/ImportCompiler.js.map +0 -1
  119. package/dist/adapters/imports/analyzeDepartures.d.ts +0 -5
  120. package/dist/adapters/imports/analyzeDepartures.d.ts.map +0 -1
  121. package/dist/adapters/imports/analyzeDepartures.js +0 -5
  122. package/dist/adapters/imports/analyzeDepartures.js.map +0 -1
  123. package/dist/adapters/imports/analyzeGraph.d.ts +0 -4
  124. package/dist/adapters/imports/analyzeGraph.d.ts.map +0 -1
  125. package/dist/adapters/imports/analyzeGraph.js +0 -6
  126. package/dist/adapters/imports/analyzeGraph.js.map +0 -1
  127. package/dist/adapters/imports/checkBrowser.d.ts +0 -4
  128. package/dist/adapters/imports/checkBrowser.d.ts.map +0 -1
  129. package/dist/adapters/imports/checkBrowser.js +0 -4
  130. package/dist/adapters/imports/checkBrowser.js.map +0 -1
  131. package/src/adapters/ImportCompiler.ts +0 -17
  132. package/src/adapters/imports/analyzeDepartures.ts +0 -9
  133. package/src/adapters/imports/analyzeGraph.ts +0 -9
  134. package/src/adapters/imports/checkBrowser.ts +0 -5
@@ -1 +1 @@
1
- {"version":3,"file":"serviceTypes.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/serviceTypes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAK5B,wBAAgB,YAAY,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW;oBA+FlC,EAAE,CAAC,IAAI;wBA5DG,EAAE,CAAC,IAAI,KAAG,OAAO;2BAGd,EAAE,CAAC,IAAI,KAAG,OAAO;qBAnBvB,EAAE,CAAC,IAAI,KAAG,IAAI;EAyFtC"}
1
+ {"version":3,"file":"serviceTypes.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/serviceTypes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAM5B,wBAAgB,YAAY,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE,gBAAgB,UAAQ;oBA0G5D,EAAE,CAAC,IAAI;wBA7DG,EAAE,CAAC,IAAI,KAAG,OAAO;2BAGd,EAAE,CAAC,IAAI,KAAG,OAAO;qBA5BvB,EAAE,CAAC,IAAI,SAAS,MAAM,KAAG,IAAI;EAmGrD"}
@@ -1,8 +1,10 @@
1
1
  import ts from "typescript";
2
+ import { callerContextData } from "#adapters/callerContextData.ts";
2
3
  const SERVICE = "~effect/Context/Service";
3
4
  const CONTEXT = "~effect/Context";
4
- export function serviceTypes(checker) {
5
+ export function serviceTypes(checker, initializerState = false) {
5
6
  const shapes = new Set();
7
+ const contextData = new Set();
6
8
  const carried = new Map();
7
9
  function propertyType(type, name) {
8
10
  const property = type.getProperty(name);
@@ -17,16 +19,25 @@ export function serviceTypes(checker) {
17
19
  .every((property) => (property.flags & ts.SymbolFlags.Optional) !== 0
18
20
  && checker.getNonNullableType(checker.getTypeOfSymbol(property)).getCallSignatures().length === 0);
19
21
  }
20
- function remember(type) {
22
+ function remember(type, name) {
21
23
  if (type.getProperty(SERVICE) === undefined) {
22
24
  return;
23
25
  }
24
26
  const shape = propertyType(type, "Service");
27
+ if (initializerState && name !== undefined && shape !== undefined && callerContextData(checker, shape, name)) {
28
+ contextData.add(type);
29
+ contextData.add(shape);
30
+ shapes.delete(shape);
31
+ return;
32
+ }
33
+ if (shape !== undefined && contextData.has(shape)) {
34
+ return;
35
+ }
25
36
  if (shape !== undefined
26
37
  && shape.flags & ts.TypeFlags.Object
27
38
  && (shape.getProperties().length > 0 || shape.getCallSignatures().length > 0)
28
39
  && checker.getIndexInfosOfType(shape).length === 0
29
- && !options(shape)
40
+ && (initializerState || !options(shape))
30
41
  && (shape.getCallSignatures().length === 0 || type.getProperty("~effect/Context/Reference") === undefined)) {
31
42
  shapes.add(shape);
32
43
  }
@@ -53,6 +64,7 @@ export function serviceTypes(checker) {
53
64
  }
54
65
  function carries(type, seen = new Set()) {
55
66
  if (seen.has(type)
67
+ || contextData.has(type)
56
68
  || type.flags
57
69
  & (ts.TypeFlags.Any
58
70
  | ts.TypeFlags.Unknown
@@ -1 +1 @@
1
- {"version":3,"file":"serviceTypes.js","sourceRoot":"","sources":["../../../src/rules/effect/serviceTypes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAE5B,MAAM,OAAO,GAAG,yBAAyB,CAAC;AAC1C,MAAM,OAAO,GAAG,iBAAiB,CAAC;AAElC,MAAM,UAAU,YAAY,CAAC,OAAuB;IACnD,MAAM,MAAM,GAAG,IAAI,GAAG,EAAW,CAAC;IAClC,MAAM,OAAO,GAAG,IAAI,GAAG,EAAoB,CAAC;IAC5C,SAAS,YAAY,CAAC,IAAa,EAAE,IAAY;QAChD,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;QACxC,OAAO,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;IAC/E,CAAC;IACD,SAAS,OAAO,CAAC,IAAa;QAC7B,IAAI,IAAI,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACzC,OAAO,KAAK,CAAC;QACd,CAAC;QACD,OAAO,IAAI;aACT,aAAa,EAAE;aACf,KAAK,CACL,CAAC,QAAQ,EAAE,EAAE,CACZ,CAAC,QAAQ,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,QAAQ,CAAC,KAAK,CAAC;eAC7C,OAAO,CAAC,kBAAkB,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC,CAAC,iBAAiB,EAAE,CAAC,MAAM,KAAK,CAAC,CAClG,CAAC;IACJ,CAAC;IACD,SAAS,QAAQ,CAAC,IAAa;QAC9B,IAAI,IAAI,CAAC,WAAW,CAAC,OAAO,CAAC,KAAK,SAAS,EAAE,CAAC;YAC7C,OAAO;QACR,CAAC;QACD,MAAM,KAAK,GAAG,YAAY,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC;QAC5C,IACC,KAAK,KAAK,SAAS;eAChB,KAAK,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,MAAM;eACjC,CAAC,KAAK,CAAC,aAAa,EAAE,CAAC,MAAM,GAAG,CAAC,IAAI,KAAK,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,CAAC;eAC1E,OAAO,CAAC,mBAAmB,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC;eAC/C,CAAC,OAAO,CAAC,KAAK,CAAC;eACf,CAAC,KAAK,CAAC,iBAAiB,EAAE,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,CAAC,WAAW,CAAC,2BAA2B,CAAC,KAAK,SAAS,CAAC,EACzG,CAAC;YACF,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;QACnB,CAAC;IACF,CAAC;IACD,SAAS,WAAW,CAAC,IAAa;QACjC,OAAO,CAAC,gBAAgB,EAAE,gBAAgB,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC,KAAK,SAAS,CAAC,CAAC;IACpG,CAAC;IACD,SAAS,cAAc,CAAC,IAAa;QACpC,IAAI,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACtB,OAAO,IAAI,CAAC;QACb,CAAC;QACD,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,EAAE,EAAE,gBAAgB,CAAC;QACvD,MAAM,UAAU,GAAG,WAAW,KAAK,SAAS,IAAI,EAAE,CAAC,yBAAyB,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAC/I,OAAO,UAAU,KAAK,SAAS,IAAI,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC3D,CAAC;IACD,SAAS,eAAe,CAAC,OAAgB;QACxC,MAAM,QAAQ,GAAG,YAAY,CAAC,OAAO,EAAE,WAAW,CAAC,CAAC;QACpD,MAAM,SAAS,GAAG,QAAQ,EAAE,iBAAiB,EAAE,CAAC,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC,CAAC,CAAC;QAClE,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC7B,OAAO,KAAK,CAAC;QACd,CAAC;QACD,MAAM,QAAQ,GAAG,OAAO,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC;QACpD,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,uBAAuB,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;IAC9F,CAAC;IACD,SAAS,OAAO,CAAC,IAAa,EAAE,IAAI,GAAG,IAAI,GAAG,EAAW;QACxD,IACC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;eACX,IAAI,CAAC,KAAK;kBACV,CAAC,EAAE,CAAC,SAAS,CAAC,GAAG;sBAChB,EAAE,CAAC,SAAS,CAAC,OAAO;sBACpB,EAAE,CAAC,SAAS,CAAC,KAAK;sBAClB,EAAE,CAAC,SAAS,CAAC,UAAU;sBACvB,EAAE,CAAC,SAAS,CAAC,UAAU;sBACvB,EAAE,CAAC,SAAS,CAAC,WAAW;sBACxB,EAAE,CAAC,SAAS,CAAC,YAAY;sBACzB,EAAE,CAAC,SAAS,CAAC,UAAU,CAAC,EAC3B,CAAC;YACF,OAAO,KAAK,CAAC;QACd,CAAC;QACD,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACf,IAAI,IAAI,CAAC,qBAAqB,EAAE,EAAE,CAAC;YAClC,OAAO,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;QACvD,CAAC;QACD,IAAI,IAAI,CAAC,WAAW,CAAC,OAAO,CAAC,KAAK,SAAS,EAAE,CAAC;YAC7C,OAAO,IAAI,CAAC;QACb,CAAC;QACD,MAAM,OAAO,GAAG,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;QAC5C,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YAC3B,OAAO,eAAe,CAAC,OAAO,CAAC,CAAC;QACjC,CAAC;QACD,IAAI,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;YACvB,OAAO,KAAK,CAAC;QACd,CAAC;QACD,MAAM,UAAU,GAAG,OAAO,CAAC,uBAAuB,CAAC,IAAI,CAAC,CAAC;QACzD,IAAI,UAAU,KAAK,SAAS,IAAI,OAAO,CAAC,UAAU,EAAE,IAAI,CAAC,EAAE,CAAC;YAC3D,OAAO,IAAI,CAAC;QACb,CAAC;QACD,OAAO,CACN,cAAc,CAAC,IAAI,CAAC;eACjB,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;eAC5E,IAAI,CAAC,aAAa,EAAE,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,IAAI,OAAO,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,CAAC,CACzI,CAAC;IACH,CAAC;IACD,OAAO;QACN,OAAO,EAAE,CAAC,IAAa,EAAE,EAAE;YAC1B,MAAM,KAAK,GAAG,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAChC,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;gBACzB,OAAO,KAAK,CAAC;YACd,CAAC;YACD,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;YAC7B,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;YAC1B,OAAO,MAAM,CAAC;QACf,CAAC;QACD,WAAW;QACX,cAAc;QACd,QAAQ;KACR,CAAC;AACH,CAAC"}
1
+ {"version":3,"file":"serviceTypes.js","sourceRoot":"","sources":["../../../src/rules/effect/serviceTypes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,iBAAiB,EAAE,MAAM,gCAAgC,CAAC;AAEnE,MAAM,OAAO,GAAG,yBAAyB,CAAC;AAC1C,MAAM,OAAO,GAAG,iBAAiB,CAAC;AAElC,MAAM,UAAU,YAAY,CAAC,OAAuB,EAAE,gBAAgB,GAAG,KAAK;IAC7E,MAAM,MAAM,GAAG,IAAI,GAAG,EAAW,CAAC;IAClC,MAAM,WAAW,GAAG,IAAI,GAAG,EAAW,CAAC;IACvC,MAAM,OAAO,GAAG,IAAI,GAAG,EAAoB,CAAC;IAC5C,SAAS,YAAY,CAAC,IAAa,EAAE,IAAY;QAChD,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;QACxC,OAAO,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;IAC/E,CAAC;IACD,SAAS,OAAO,CAAC,IAAa;QAC7B,IAAI,IAAI,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACzC,OAAO,KAAK,CAAC;QACd,CAAC;QACD,OAAO,IAAI;aACT,aAAa,EAAE;aACf,KAAK,CACL,CAAC,QAAQ,EAAE,EAAE,CACZ,CAAC,QAAQ,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,QAAQ,CAAC,KAAK,CAAC;eAC7C,OAAO,CAAC,kBAAkB,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC,CAAC,iBAAiB,EAAE,CAAC,MAAM,KAAK,CAAC,CAClG,CAAC;IACJ,CAAC;IACD,SAAS,QAAQ,CAAC,IAAa,EAAE,IAAa;QAC7C,IAAI,IAAI,CAAC,WAAW,CAAC,OAAO,CAAC,KAAK,SAAS,EAAE,CAAC;YAC7C,OAAO;QACR,CAAC;QACD,MAAM,KAAK,GAAG,YAAY,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC;QAC5C,IAAI,gBAAgB,IAAI,IAAI,KAAK,SAAS,IAAI,KAAK,KAAK,SAAS,IAAI,iBAAiB,CAAC,OAAO,EAAE,KAAK,EAAE,IAAI,CAAC,EAAE,CAAC;YAC9G,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YACtB,WAAW,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;YACvB,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;YACrB,OAAO;QACR,CAAC;QACD,IAAI,KAAK,KAAK,SAAS,IAAI,WAAW,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;YACnD,OAAO;QACR,CAAC;QACD,IACC,KAAK,KAAK,SAAS;eAChB,KAAK,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,MAAM;eACjC,CAAC,KAAK,CAAC,aAAa,EAAE,CAAC,MAAM,GAAG,CAAC,IAAI,KAAK,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,CAAC;eAC1E,OAAO,CAAC,mBAAmB,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC;eAC/C,CAAC,gBAAgB,IAAI,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;eACrC,CAAC,KAAK,CAAC,iBAAiB,EAAE,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,CAAC,WAAW,CAAC,2BAA2B,CAAC,KAAK,SAAS,CAAC,EACzG,CAAC;YACF,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;QACnB,CAAC;IACF,CAAC;IACD,SAAS,WAAW,CAAC,IAAa;QACjC,OAAO,CAAC,gBAAgB,EAAE,gBAAgB,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC,KAAK,SAAS,CAAC,CAAC;IACpG,CAAC;IACD,SAAS,cAAc,CAAC,IAAa;QACpC,IAAI,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACtB,OAAO,IAAI,CAAC;QACb,CAAC;QACD,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,EAAE,EAAE,gBAAgB,CAAC;QACvD,MAAM,UAAU,GAAG,WAAW,KAAK,SAAS,IAAI,EAAE,CAAC,yBAAyB,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAC/I,OAAO,UAAU,KAAK,SAAS,IAAI,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC3D,CAAC;IACD,SAAS,eAAe,CAAC,OAAgB;QACxC,MAAM,QAAQ,GAAG,YAAY,CAAC,OAAO,EAAE,WAAW,CAAC,CAAC;QACpD,MAAM,SAAS,GAAG,QAAQ,EAAE,iBAAiB,EAAE,CAAC,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC,CAAC,CAAC;QAClE,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC7B,OAAO,KAAK,CAAC;QACd,CAAC;QACD,MAAM,QAAQ,GAAG,OAAO,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC;QACpD,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,uBAAuB,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;IAC9F,CAAC;IACD,SAAS,OAAO,CAAC,IAAa,EAAE,IAAI,GAAG,IAAI,GAAG,EAAW;QACxD,IACC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;eACX,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC;eACrB,IAAI,CAAC,KAAK;kBACV,CAAC,EAAE,CAAC,SAAS,CAAC,GAAG;sBAChB,EAAE,CAAC,SAAS,CAAC,OAAO;sBACpB,EAAE,CAAC,SAAS,CAAC,KAAK;sBAClB,EAAE,CAAC,SAAS,CAAC,UAAU;sBACvB,EAAE,CAAC,SAAS,CAAC,UAAU;sBACvB,EAAE,CAAC,SAAS,CAAC,WAAW;sBACxB,EAAE,CAAC,SAAS,CAAC,YAAY;sBACzB,EAAE,CAAC,SAAS,CAAC,UAAU,CAAC,EAC3B,CAAC;YACF,OAAO,KAAK,CAAC;QACd,CAAC;QACD,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACf,IAAI,IAAI,CAAC,qBAAqB,EAAE,EAAE,CAAC;YAClC,OAAO,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;QACvD,CAAC;QACD,IAAI,IAAI,CAAC,WAAW,CAAC,OAAO,CAAC,KAAK,SAAS,EAAE,CAAC;YAC7C,OAAO,IAAI,CAAC;QACb,CAAC;QACD,MAAM,OAAO,GAAG,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;QAC5C,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YAC3B,OAAO,eAAe,CAAC,OAAO,CAAC,CAAC;QACjC,CAAC;QACD,IAAI,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;YACvB,OAAO,KAAK,CAAC;QACd,CAAC;QACD,MAAM,UAAU,GAAG,OAAO,CAAC,uBAAuB,CAAC,IAAI,CAAC,CAAC;QACzD,IAAI,UAAU,KAAK,SAAS,IAAI,OAAO,CAAC,UAAU,EAAE,IAAI,CAAC,EAAE,CAAC;YAC3D,OAAO,IAAI,CAAC;QACb,CAAC;QACD,OAAO,CACN,cAAc,CAAC,IAAI,CAAC;eACjB,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;eAC5E,IAAI,CAAC,aAAa,EAAE,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,IAAI,OAAO,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,CAAC,CACzI,CAAC;IACH,CAAC;IACD,OAAO;QACN,OAAO,EAAE,CAAC,IAAa,EAAE,EAAE;YAC1B,MAAM,KAAK,GAAG,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAChC,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;gBACzB,OAAO,KAAK,CAAC;YACd,CAAC;YACD,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;YAC7B,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;YAC1B,OAAO,MAAM,CAAC;QACf,CAAC;QACD,WAAW;QACX,cAAc;QACd,QAAQ;KACR,CAAC;AACH,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"namedAfterExport.d.ts","sourceRoot":"","sources":["../../../src/rules/files/namedAfterExport.ts"],"names":[],"mappings":"AA2FA,eAAO,MAAM,gBAAgB;;;;;mCAe3B,CAAC"}
1
+ {"version":3,"file":"namedAfterExport.d.ts","sourceRoot":"","sources":["../../../src/rules/files/namedAfterExport.ts"],"names":[],"mappings":"AAsGA,eAAO,MAAM,gBAAgB;;;;;mCAiB3B,CAAC"}
@@ -1,6 +1,8 @@
1
1
  import { posix } from "node:path";
2
2
  import { Effect, Schema } from "effect";
3
3
  import { ignorePatterns } from "#adapters/ignore.ts";
4
+ import { serviceAssemblyImports } from "#adapters/serviceAssemblyImports.ts";
5
+ import { directServiceDefinitions } from "#adapters/serviceAssemblySyntax.ts";
4
6
  import { GlobDeclarations, globPatterns, validateGlobs } from "#config/globs.ts";
5
7
  import { routeFiles } from "#inventory/routeFiles.ts";
6
8
  import { exportFits } from "#naming/exportFits.ts";
@@ -62,12 +64,21 @@ function nameFinding(file, stem, folders) {
62
64
  : `"${stem}" exports several things, so it is a topic file named in camelCase, such as limits.ts. Or split it so each file has one main export. ${SHAPES}`;
63
65
  }
64
66
  function findingsOf(file, layout) {
67
+ const source = posix.basename(file.path) === "service.ts" ? parse(file) : undefined;
68
+ if (source !== undefined && directServiceDefinitions(source, serviceAssemblyImports(source).definitions).length > 0) {
69
+ return [];
70
+ }
65
71
  const stem = stemOf(file.path);
66
72
  const folders = layout.foldersOf(file.path);
67
73
  if (layout.scripts.has(file.path) || file.text.startsWith(SHEBANG)) {
68
74
  return KEBAB.test(stem)
69
75
  ? []
70
- : [{ file: file.path, message: `"${stem}" is run as a script, so it is named in kebab-case, such as build-docs.ts.` }];
76
+ : [
77
+ {
78
+ file: file.path,
79
+ message: `"${stem}" is run as a script, so it is named in kebab-case, such as build-docs.ts.`,
80
+ },
81
+ ];
71
82
  }
72
83
  const root = moduleRoot(file.path);
73
84
  const admin = root === undefined ? undefined : /^(?:client|server)\/(?<path>admin\/.+)$/u.exec(file.path.slice(root.length + 1))?.groups?.path;
@@ -87,9 +98,11 @@ export const namedAfterExport = defineRule({
87
98
  .filter((file) => !(TEST.test(file.path) || isMigrationFile(file.path) || routes.files.has(file.path) || toolOwned.ignores(file.path)))
88
99
  .flatMap((file) => findingsOf(file, layout));
89
100
  }),
90
- description: "A file is named after its main export or a module-level constant, including a private constant, with its folders as the prefix; module client/admin and server/admin files may repeat names from above the admin folder. TanStack Router configuration owns route filenames. A file of several exports is a camelCase topic file, and a script is kebab-case. Rename the file or the export; nothing renames them for you.",
101
+ description: "A file is named after its main export or a module-level constant, including a private constant, with its folders as the prefix; module client/admin and server/admin files may repeat names from above the admin folder. defineService declarations use service.ts; TanStack Router configuration owns route filenames. A file of several exports is a camelCase topic file, and a script is kebab-case. Rename the file or the export; nothing renames them for you.",
91
102
  id: "files/named-after-export",
92
- options: Schema.toStandardSchemaV1(NamedAfterExportOptions, { parseOptions: { errors: "all", onExcessProperty: "error" } }),
103
+ options: Schema.toStandardSchemaV1(NamedAfterExportOptions, {
104
+ parseOptions: { errors: "all", onExcessProperty: "error" },
105
+ }),
93
106
  validate: validateGlobs,
94
107
  });
95
108
  //# sourceMappingURL=namedAfterExport.js.map
@@ -1 +1 @@
1
- {"version":3,"file":"namedAfterExport.js","sourceRoot":"","sources":["../../../src/rules/files/namedAfterExport.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,EAAE,gBAAgB,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjF,OAAO,EAAE,UAAU,EAAE,MAAM,0BAA0B,CAAC;AACtD,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,eAAe,EAAE,MAAM,0BAA0B,CAAC;AAC3D,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACpE,OAAO,EAAsB,aAAa,EAAE,MAAM,0BAA0B,CAAC;AAC7E,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM,kBAAkB,CAAC;AACnE,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAE,KAAK,EAAE,MAAM,iBAAiB,CAAC;AAExC,MAAM,kBAAkB,GAAsB;IAC7C,YAAY;IACZ,QAAQ;IACR,SAAS;IACT,SAAS;IACT,wBAAwB;IACxB,wBAAwB;IACxB,wBAAwB;CACxB,CAAC;AAEF,MAAM,IAAI,GAAG,iCAAiC,CAAC;AAE/C,MAAM,OAAO,GAAG,IAAI,CAAC;AAErB,MAAM,MAAM,GACX,uNAAuN,CAAC;AAEzN,MAAM,uBAAuB,GAAG,MAAM,CAAC,MAAM,CAAC;IAC7C,SAAS,EAAE,gBAAgB;CAC3B,CAAC,CAAC;AAEH,SAAS,MAAM,CAAC,IAAY;IAC3B,OAAO,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC;AACtD,CAAC;AAED,SAAS,QAAQ,CAAC,IAAY,EAAE,OAA0B;IACzD,IAAI,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;QAC7B,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,KAAK,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;IAC5B,OAAO,OAAO,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,QAAQ,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;AAC3G,CAAC;AAED,SAAS,WAAW,CAAC,IAAgB,EAAE,IAAY,EAAE,OAA0B;IAC9E,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC;IAC3B,MAAM,OAAO,GAAG,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;IAC/D,MAAM,SAAS,GAAG,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;IACxG,IAAI,SAAS,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC,EAAE,CAAC;QACtE,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,CAAC,IAAI,CAAC,GAAG,OAAO,CAAC;IACvB,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;YACtB,CAAC,CAAC,SAAS;YACX,CAAC,CAAC,IAAI,IAAI,qIAAqI,CAAC;IAClJ,CAAC;IACD,IAAI,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC,EAAE,CAAC;QACpE,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,IAAI,GAAG,UAAU,CAAC,OAAO,CAAC,CAAC;IACjC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,IAAI,IAAI,8BAA8B,IAAI,CAAC,IAAI,KAAK,MAAM,iCAAiC,CAAC;IACpG,CAAC;IACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;QACtB,CAAC,CAAC,SAAS;QACX,CAAC,CAAC,IAAI,IAAI,wIAAwI,MAAM,EAAE,CAAC;AAC7J,CAAC;AAED,SAAS,UAAU,CAAC,IAAgB,EAAE,MAAqB;IAC1D,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/B,MAAM,OAAO,GAAG,MAAM,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5C,IAAI,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACpE,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;YACtB,CAAC,CAAC,EAAE;YACJ,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,OAAO,EAAE,IAAI,IAAI,4EAA4E,EAAE,CAAC,CAAC;IACzH,CAAC;IACD,MAAM,IAAI,GAAG,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACnC,MAAM,KAAK,GAAG,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,0CAA0C,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,IAAI,CAAC;IAC/I,MAAM,MAAM,GAAG,QAAQ,CAAC,IAAI,EAAE,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC;IAC/F,MAAM,QAAQ,GAAG;QAChB,WAAW,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC;QAChC,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,IAAI,yBAAyB,MAAM,mEAAmE;KAC7I,CAAC;IACF,OAAO,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;AACrG,CAAC;AAED,MAAM,CAAC,MAAM,gBAAgB,GAAG,UAAU,CAAC;IAC1C,KAAK,EAAE,CAAC,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,EAAE,CACtD,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QACnB,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,aAAa,CAAC,EAAE,KAAK,EAAE,QAAQ,EAAE,CAAC,CAAC;QACzD,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC;QACvC,MAAM,SAAS,GAAG,cAAc,CAAC,CAAC,GAAG,kBAAkB,EAAE,GAAG,YAAY,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QAC9F,OAAO,OAAO;aACZ,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;aACtI,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,UAAU,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC;IAC/C,CAAC,CAAC;IACH,WAAW,EACV,4ZAA4Z;IAC7Z,EAAE,EAAE,0BAA0B;IAC9B,OAAO,EAAE,MAAM,CAAC,kBAAkB,CAAC,uBAAuB,EAAE,EAAE,YAAY,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,gBAAgB,EAAE,OAAO,EAAE,EAAE,CAAC;IAC3H,QAAQ,EAAE,aAAa;CACvB,CAAC,CAAC"}
1
+ {"version":3,"file":"namedAfterExport.js","sourceRoot":"","sources":["../../../src/rules/files/namedAfterExport.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,EAAE,sBAAsB,EAAE,MAAM,qCAAqC,CAAC;AAC7E,OAAO,EAAE,wBAAwB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,OAAO,EAAE,gBAAgB,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjF,OAAO,EAAE,UAAU,EAAE,MAAM,0BAA0B,CAAC;AACtD,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,eAAe,EAAE,MAAM,0BAA0B,CAAC;AAC3D,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,eAAe,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACpE,OAAO,EAAsB,aAAa,EAAE,MAAM,0BAA0B,CAAC;AAC7E,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM,kBAAkB,CAAC;AACnE,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAE,KAAK,EAAE,MAAM,iBAAiB,CAAC;AAExC,MAAM,kBAAkB,GAAsB;IAC7C,YAAY;IACZ,QAAQ;IACR,SAAS;IACT,SAAS;IACT,wBAAwB;IACxB,wBAAwB;IACxB,wBAAwB;CACxB,CAAC;AAEF,MAAM,IAAI,GAAG,iCAAiC,CAAC;AAE/C,MAAM,OAAO,GAAG,IAAI,CAAC;AAErB,MAAM,MAAM,GACX,uNAAuN,CAAC;AAEzN,MAAM,uBAAuB,GAAG,MAAM,CAAC,MAAM,CAAC;IAC7C,SAAS,EAAE,gBAAgB;CAC3B,CAAC,CAAC;AAEH,SAAS,MAAM,CAAC,IAAY;IAC3B,OAAO,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC;AACtD,CAAC;AAED,SAAS,QAAQ,CAAC,IAAY,EAAE,OAA0B;IACzD,IAAI,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;QAC7B,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,KAAK,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;IAC5B,OAAO,OAAO,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,QAAQ,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;AAC3G,CAAC;AAED,SAAS,WAAW,CAAC,IAAgB,EAAE,IAAY,EAAE,OAA0B;IAC9E,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC;IAC3B,MAAM,OAAO,GAAG,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;IAC/D,MAAM,SAAS,GAAG,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;IACxG,IAAI,SAAS,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC,EAAE,CAAC;QACtE,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,CAAC,IAAI,CAAC,GAAG,OAAO,CAAC;IACvB,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;YACtB,CAAC,CAAC,SAAS;YACX,CAAC,CAAC,IAAI,IAAI,qIAAqI,CAAC;IAClJ,CAAC;IACD,IAAI,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC,EAAE,CAAC;QACpE,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,IAAI,GAAG,UAAU,CAAC,OAAO,CAAC,CAAC;IACjC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,IAAI,IAAI,8BAA8B,IAAI,CAAC,IAAI,KAAK,MAAM,iCAAiC,CAAC;IACpG,CAAC;IACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;QACtB,CAAC,CAAC,SAAS;QACX,CAAC,CAAC,IAAI,IAAI,wIAAwI,MAAM,EAAE,CAAC;AAC7J,CAAC;AAED,SAAS,UAAU,CAAC,IAAgB,EAAE,MAAqB;IAC1D,MAAM,MAAM,GAAG,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,YAAY,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACpF,IAAI,MAAM,KAAK,SAAS,IAAI,wBAAwB,CAAC,MAAM,EAAE,sBAAsB,CAAC,MAAM,CAAC,CAAC,WAAW,CAAC,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACrH,OAAO,EAAE,CAAC;IACX,CAAC;IACD,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/B,MAAM,OAAO,GAAG,MAAM,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5C,IAAI,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;QACpE,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;YACtB,CAAC,CAAC,EAAE;YACJ,CAAC,CAAC;gBACA;oBACC,IAAI,EAAE,IAAI,CAAC,IAAI;oBACf,OAAO,EAAE,IAAI,IAAI,4EAA4E;iBAC7F;aACD,CAAC;IACL,CAAC;IACD,MAAM,IAAI,GAAG,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACnC,MAAM,KAAK,GAAG,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,0CAA0C,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,IAAI,CAAC;IAC/I,MAAM,MAAM,GAAG,QAAQ,CAAC,IAAI,EAAE,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC;IAC/F,MAAM,QAAQ,GAAG;QAChB,WAAW,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC;QAChC,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,IAAI,yBAAyB,MAAM,mEAAmE;KAC7I,CAAC;IACF,OAAO,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;AACrG,CAAC;AAED,MAAM,CAAC,MAAM,gBAAgB,GAAG,UAAU,CAAC;IAC1C,KAAK,EAAE,CAAC,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,EAAE,CACtD,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QACnB,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,aAAa,CAAC,EAAE,KAAK,EAAE,QAAQ,EAAE,CAAC,CAAC;QACzD,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC;QACvC,MAAM,SAAS,GAAG,cAAc,CAAC,CAAC,GAAG,kBAAkB,EAAE,GAAG,YAAY,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QAC9F,OAAO,OAAO;aACZ,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;aACtI,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,UAAU,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC;IAC/C,CAAC,CAAC;IACH,WAAW,EACV,ucAAuc;IACxc,EAAE,EAAE,0BAA0B;IAC9B,OAAO,EAAE,MAAM,CAAC,kBAAkB,CAAC,uBAAuB,EAAE;QAC3D,YAAY,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,gBAAgB,EAAE,OAAO,EAAE;KAC1D,CAAC;IACF,QAAQ,EAAE,aAAa;CACvB,CAAC,CAAC"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@shivaedev/quality",
3
- "version": "0.65.0",
3
+ "version": "0.66.0",
4
4
  "description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
5
5
  "homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
6
6
  "bugs": {
@@ -57,7 +57,7 @@
57
57
  "@shivaedev/skills": "0.8.0",
58
58
  "@vitest/coverage-v8": "5.0.5",
59
59
  "ignore": "7.0.14",
60
- "knip": "6.43.0",
60
+ "knip": "6.44.0",
61
61
  "sort-package-json": "4.1.0",
62
62
  "typescript": "npm:@typescript/typescript6@6.0.2"
63
63
  },
@@ -65,7 +65,7 @@
65
65
  "@effect/platform-node": "4.1.0",
66
66
  "@effect/platform-node-shared": "4.1.0",
67
67
  "@effect/vitest": "4.1.0",
68
- "@shivaedev/test-story": "0.42.0",
68
+ "@shivaedev/test-story": "0.42.1",
69
69
  "@types/node": "24.19.2",
70
70
  "@typescript/native": "npm:typescript@7.0.2",
71
71
  "effect": "4.1.0",
@@ -74,7 +74,7 @@
74
74
  "peerDependencies": {
75
75
  "@effect/platform-node": "4.1.0",
76
76
  "@effect/platform-node-shared": "4.1.0",
77
- "@shivaedev/test-story": "0.42.0",
77
+ "@shivaedev/test-story": "0.42.1",
78
78
  "effect": "4.1.0",
79
79
  "vitest": "5.0.5"
80
80
  },
@@ -0,0 +1,46 @@
1
+ import ts from "typescript";
2
+
3
+ const CALLERS = new Set(["SessionUser", "Subject", "Identity", "SessionUserWithProviderAccounts"]);
4
+
5
+ function data(checker: ts.TypeChecker, value: ts.Type, seen: Set<ts.Type>): boolean {
6
+ if (seen.has(value)) {
7
+ return true;
8
+ }
9
+ seen.add(value);
10
+ if (value.flags & (ts.TypeFlags.Any | ts.TypeFlags.Unknown)) {
11
+ return false;
12
+ }
13
+ if (
14
+ value.flags
15
+ & (ts.TypeFlags.StringLike
16
+ | ts.TypeFlags.NumberLike
17
+ | ts.TypeFlags.BooleanLike
18
+ | ts.TypeFlags.ESSymbolLike
19
+ | ts.TypeFlags.BigIntLike
20
+ | ts.TypeFlags.Null
21
+ | ts.TypeFlags.Undefined
22
+ | ts.TypeFlags.Never)
23
+ ) {
24
+ return true;
25
+ }
26
+ if (value.isUnionOrIntersection()) {
27
+ return value.types.every((part) => data(checker, part, seen));
28
+ }
29
+ if (value.getProperty("~effect/Context/Service") !== undefined || value.getProperty("~effect/Context") !== undefined) {
30
+ return false;
31
+ }
32
+ if (value.getProperty("~effect/Effect") !== undefined) {
33
+ return true;
34
+ }
35
+ if (value.getCallSignatures().length > 0 || value.getConstructSignatures().length > 0) {
36
+ return false;
37
+ }
38
+ const element = checker.getIndexTypeOfType(value, ts.IndexKind.Number);
39
+ return element === undefined
40
+ ? value.getProperties().every((property) => data(checker, checker.getTypeOfSymbol(property), seen))
41
+ : data(checker, element, seen);
42
+ }
43
+
44
+ export function callerContextData(checker: ts.TypeChecker, type: ts.Type, name: string): boolean {
45
+ return CALLERS.has(name) && data(checker, type, new Set());
46
+ }
@@ -0,0 +1,58 @@
1
+ import { join } from "node:path";
2
+ import { Effect } from "effect";
3
+ import ts from "typescript";
4
+ import { effectApi } from "#adapters/serviceModelSyntax.ts";
5
+ import type { Finding, RuleInputs } from "#rule.ts";
6
+ import { effectProgram } from "#rules/effect/program.ts";
7
+
8
+ const RUNNERS = ["provideContext", "runPromiseWith", "runForkWith"];
9
+ const PROVIDERS = [...RUNNERS, "provide"];
10
+
11
+ function context(type: ts.Type): boolean {
12
+ return type.isUnionOrIntersection() ? type.types.some(context) : type.getProperty("~effect/Context") !== undefined;
13
+ }
14
+
15
+ function reprovides(checker: ts.TypeChecker, call: ts.CallExpression): boolean {
16
+ if (RUNNERS.some((name) => effectApi(checker, call.expression, name))) {
17
+ return true;
18
+ }
19
+ if (!effectApi(checker, call.expression, "provide")) {
20
+ return false;
21
+ }
22
+ const environment = call.arguments.at(-1);
23
+ return environment !== undefined && context(checker.getTypeAtLocation(environment));
24
+ }
25
+
26
+ export const contextCaptureFindings = Effect.fn("ContextCapture.contextCaptureFindings")((inputs: RuleInputs) =>
27
+ Effect.sync(() => {
28
+ const sources = inputs.sources.filter(
29
+ (file) => !/(?:^|\/)(?:adapters|test-support)\//u.test(file.path) && PROVIDERS.some((name) => file.text.includes(name)),
30
+ );
31
+ if (sources.length === 0) {
32
+ return [];
33
+ }
34
+ const program = effectProgram({ ...inputs, sources });
35
+ const checker = program.getTypeChecker();
36
+ return sources.flatMap((file): readonly Finding[] => {
37
+ const source = program.getSourceFile(join(inputs.root, file.path));
38
+ if (source === undefined) {
39
+ return [];
40
+ }
41
+ const syntax = source;
42
+ const findings: Finding[] = [];
43
+ function visit(node: ts.Node): void {
44
+ if (ts.isCallExpression(node) && reprovides(checker, node)) {
45
+ findings.push({
46
+ file: file.path,
47
+ line: syntax.getLineAndCharacterOfPosition(node.getStart(syntax)).line + 1,
48
+ message:
49
+ "Do not re-provide a captured Effect context in core code. Declare service requirements once and yield dependencies and the caller from the environment. Register the Layer at the host; put runtime bridges in adapters/ or test-support/.",
50
+ });
51
+ }
52
+ ts.forEachChild(node, visit);
53
+ }
54
+ visit(source);
55
+ return findings;
56
+ });
57
+ }),
58
+ );
@@ -0,0 +1,5 @@
1
+ import { Effect } from "effect";
2
+ import type ts from "typescript";
3
+ import { browserChecker as createBrowserChecker } from "#adapters/imports/browserChecker.ts";
4
+
5
+ export const browserChecker = Effect.fn("ImportCompiler.browserChecker")((source: ts.SourceFile) => Effect.sync(() => createBrowserChecker(source)));
@@ -0,0 +1,9 @@
1
+ import { Effect } from "effect";
2
+ import { analysisFailure } from "#adapters/imports/analysisFailure.ts";
3
+ import { departures as findDepartures } from "#adapters/imports/departures.ts";
4
+ import type { WorkspacePackage } from "#imports/workspace.ts";
5
+ import type { RuleInputs } from "#rule.ts";
6
+
7
+ export const departures = Effect.fn("ImportCompiler.departures")((inputs: RuleInputs, packages: readonly WorkspacePackage[]) =>
8
+ Effect.try({ catch: (cause) => analysisFailure(inputs.root, cause), try: () => findDepartures(inputs, packages) }),
9
+ );
@@ -0,0 +1,9 @@
1
+ import { realpathSync } from "node:fs";
2
+ import { Effect } from "effect";
3
+ import { analysisFailure } from "#adapters/imports/analysisFailure.ts";
4
+ import { graph as buildGraph } from "#adapters/imports/graph.ts";
5
+ import type { RuleInputs } from "#rule.ts";
6
+
7
+ export const graph = Effect.fn("ImportCompiler.graph")((inputs: RuleInputs) =>
8
+ Effect.try({ catch: (cause) => analysisFailure(inputs.root, cause), try: () => buildGraph(inputs, realpathSync(inputs.root)) }),
9
+ );
@@ -0,0 +1,17 @@
1
+ import { Effect } from "effect";
2
+ import type ts from "typescript";
3
+ import { defineService } from "@shivaedev/service/defineService.ts";
4
+ import { browserChecker } from "./browserChecker.ts";
5
+ import { departures } from "./departures.ts";
6
+ import { graph } from "./graph.ts";
7
+
8
+ export const ImportCompiler = defineService({
9
+ id: "@shivaedev/quality/ImportCompiler",
10
+ initialize: Effect.void,
11
+ methods: () => ({
12
+ browserChecker: browserChecker satisfies (source: ts.SourceFile) => Effect.Effect<ts.TypeChecker>,
13
+ departures,
14
+ graph,
15
+ }),
16
+ requires: [],
17
+ });
@@ -0,0 +1,57 @@
1
+ import ts from "typescript";
2
+ import { effectSuccess } from "#adapters/serviceModelSyntax.ts";
3
+
4
+ const DATA =
5
+ ts.TypeFlags.StringLike
6
+ | ts.TypeFlags.NumberLike
7
+ | ts.TypeFlags.BooleanLike
8
+ | ts.TypeFlags.ESSymbolLike
9
+ | ts.TypeFlags.BigIntLike
10
+ | ts.TypeFlags.Null
11
+ | ts.TypeFlags.Undefined
12
+ | ts.TypeFlags.Void
13
+ | ts.TypeFlags.Never
14
+ | ts.TypeFlags.Unknown
15
+ | ts.TypeFlags.Any;
16
+ const OWNED = /\/effect\/(?:src|dist(?:\/dts)?)\/(?:Ref|SynchronizedRef|ScopedRef|Cache|ScopedCache|Semaphore|Deferred)\.(?:d\.)?ts$/u;
17
+ const COLLECTIONS = new Set(["Map", "ReadonlyMap", "Set", "ReadonlySet", "Array", "ReadonlyArray"]);
18
+
19
+ function owned(type: ts.Type): boolean {
20
+ const symbol = type.getSymbol();
21
+ return (symbol?.declarations ?? []).some((declaration) => {
22
+ const path = declaration.getSourceFile().fileName.replaceAll("\\", "/");
23
+ return OWNED.test(path) || (COLLECTIONS.has(symbol?.name ?? "") && /\/lib\.[^/]+\.d\.ts$/u.test(path));
24
+ });
25
+ }
26
+
27
+ function reference(type: ts.Type): type is ts.TypeReference {
28
+ return "objectFlags" in type && typeof type.objectFlags === "number" && (type.objectFlags & ts.ObjectFlags.Reference) !== 0;
29
+ }
30
+
31
+ export function initializerDependency(checker: ts.TypeChecker, type: ts.Type, seen = new Set<ts.Type>()): boolean {
32
+ if (seen.has(type) || type.flags & DATA) {
33
+ return false;
34
+ }
35
+ seen.add(type);
36
+ if (type.isUnionOrIntersection()) {
37
+ return type.types.some((part) => initializerDependency(checker, part, seen));
38
+ }
39
+ const success = effectSuccess(checker, type);
40
+ if (success !== undefined) {
41
+ return initializerDependency(checker, success, seen);
42
+ }
43
+ if (owned(type)) {
44
+ const arguments_ = reference(type) ? checker.getTypeArguments(type) : [];
45
+ return arguments_.some((argument) => initializerDependency(checker, argument, seen));
46
+ }
47
+ for (const signature of type.getCallSignatures()) {
48
+ const result = signature.getReturnType();
49
+ if (effectSuccess(checker, result) !== undefined || (result.getProperty("then") !== undefined && result.getSymbol()?.name === "Promise")) {
50
+ return true;
51
+ }
52
+ if (initializerDependency(checker, result, seen)) {
53
+ return true;
54
+ }
55
+ }
56
+ return type.getProperties().some((property) => initializerDependency(checker, checker.getTypeOfSymbol(property), seen));
57
+ }
@@ -54,7 +54,7 @@ export function serviceDefinitionProblems(
54
54
  for (const operation of methods?.properties ?? []) {
55
55
  if (!isOperationReference(operation, imports, generics)) {
56
56
  found.push({
57
- message: "Reference a named operation export or call its named state factory.",
57
+ message: "Reference a named Effect.fn operation export that yields its dependencies. Use a state factory only for owned lifetime state.",
58
58
  node: operation,
59
59
  });
60
60
  }
@@ -59,6 +59,20 @@ export function serviceFolderFindings({ files, sources }: RuleInputs): readonly
59
59
  }),
60
60
  );
61
61
  const findings: Finding[] = [];
62
+ for (const file of sources) {
63
+ const source = parse(file);
64
+ if (source !== undefined && directServiceDefinitions(source, serviceAssemblyImports(source).definitions).length > 0) {
65
+ folders.add(posix.dirname(file.path));
66
+ if (posix.basename(file.path) !== "service.ts" && files.includes(`${posix.dirname(file.path)}/service.ts`)) {
67
+ findings.push({
68
+ file: file.path,
69
+ message:
70
+ "Give each service its own folder and move this declaration to its service.ts. Keep that service's operations in focused sibling files.",
71
+ });
72
+ }
73
+ }
74
+ }
75
+
62
76
  for (const folder of folders) {
63
77
  const service = `${folder}/service.ts`;
64
78
  if (!files.includes(service)) {
@@ -0,0 +1,52 @@
1
+ import { join } from "node:path";
2
+ import { Effect } from "effect";
3
+ import ts from "typescript";
4
+ import { serviceAssemblyImports } from "#adapters/serviceAssemblyImports.ts";
5
+ import { directServiceDefinitions } from "#adapters/serviceAssemblySyntax.ts";
6
+ import { serviceOperationProblems } from "#adapters/serviceOperationProblems.ts";
7
+ import { serviceStateProblems } from "#adapters/serviceStateProblems.ts";
8
+ import type { Finding, RuleInputs } from "#rule.ts";
9
+ import { effectProgram } from "#rules/effect/program.ts";
10
+ import { serviceCatalog } from "#rules/effect/serviceCatalog.ts";
11
+ import { parse } from "#rules/parse.ts";
12
+
13
+ function checkServices(inputs: RuleInputs): readonly Finding[] {
14
+ const program = effectProgram(inputs);
15
+ const checker = program.getTypeChecker();
16
+ const services = serviceCatalog(program, checker, [], true);
17
+ const found: Finding[] = [];
18
+ for (const file of inputs.sources) {
19
+ const source = program.getSourceFile(join(inputs.root, file.path));
20
+ if (source === undefined) {
21
+ continue;
22
+ }
23
+ for (const definition of directServiceDefinitions(source, serviceAssemblyImports(source).definitions)) {
24
+ const config = definition.arguments[0];
25
+ if (config === undefined || !ts.isObjectLiteralExpression(config)) {
26
+ continue;
27
+ }
28
+ const problems = [...serviceStateProblems(checker, config, services), ...serviceOperationProblems(checker, config, source.fileName)];
29
+ for (const { node, message } of problems) {
30
+ found.push({ file: file.path, line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1, message });
31
+ }
32
+ }
33
+ }
34
+ return found;
35
+ }
36
+
37
+ export const serviceModelFindings = Effect.fn("ServiceModel.serviceModelFindings")((inputs: RuleInputs) =>
38
+ Effect.sync(() => {
39
+ const groups = new Map<string, RuleInputs["sources"][number][]>();
40
+ for (const file of inputs.sources) {
41
+ const source = parse(file);
42
+ if (source === undefined || directServiceDefinitions(source, serviceAssemblyImports(source).definitions).length === 0) {
43
+ continue;
44
+ }
45
+ const group = /^(?:packages|examples)\/[^/]+/u.exec(file.path)?.[0] ?? ".";
46
+ const sources = groups.get(group) ?? [];
47
+ sources.push(file);
48
+ groups.set(group, sources);
49
+ }
50
+ return [...groups.values()].flatMap((sources) => checkServices({ ...inputs, sources }));
51
+ }),
52
+ );
@@ -0,0 +1,58 @@
1
+ import ts from "typescript";
2
+ import { unwrapExpression } from "#adapters/serviceAssemblySyntax.ts";
3
+ import { boundaryReference } from "#rules/effect/boundaryReference.ts";
4
+
5
+ export function effectApi(checker: ts.TypeChecker, node: ts.Node, name: string): boolean {
6
+ if (ts.isParenthesizedExpression(node)) {
7
+ return effectApi(checker, node.expression, name);
8
+ }
9
+ if (ts.isPropertyAccessExpression(node) && node.name.text !== name) {
10
+ return false;
11
+ }
12
+ const reference = boundaryReference(checker, node);
13
+ if (reference === `effect.Effect.${name}` || reference === `effect/Effect.${name}`) {
14
+ return true;
15
+ }
16
+ const declaration = declarationOf(checker, node);
17
+ if (declaration === undefined) {
18
+ return false;
19
+ }
20
+ const path = declaration.getSourceFile().fileName.replaceAll("\\", "/");
21
+ return (
22
+ /\/effect\/(?:src|dist(?:\/dts)?)\/Effect\.(?:d\.)?ts$/u.test(path)
23
+ && (ts.isVariableDeclaration(declaration) || ts.isFunctionDeclaration(declaration))
24
+ && declaration.name !== undefined
25
+ && ts.isIdentifier(declaration.name)
26
+ && declaration.name.text === name
27
+ );
28
+ }
29
+
30
+ function declarationOf(checker: ts.TypeChecker, node: ts.Node): ts.Declaration | undefined {
31
+ const symbol = ts.isShorthandPropertyAssignment(node.parent)
32
+ ? checker.getShorthandAssignmentValueSymbol(node.parent)
33
+ : checker.getSymbolAtLocation(node);
34
+ if (symbol === undefined) {
35
+ return;
36
+ }
37
+ const target = symbol.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(symbol) : symbol;
38
+ return target.valueDeclaration ?? target.declarations?.[0];
39
+ }
40
+
41
+ export function resolvedValue(checker: ts.TypeChecker, expression: ts.Expression, seen = new Set<ts.Node>()): ts.Node {
42
+ const value = unwrapExpression(expression);
43
+ if (seen.has(value)) {
44
+ return value;
45
+ }
46
+ seen.add(value);
47
+ const declaration = declarationOf(checker, value);
48
+ if (declaration !== undefined && ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
49
+ return resolvedValue(checker, declaration.initializer, seen);
50
+ }
51
+ return declaration !== undefined && (ts.isFunctionDeclaration(declaration) || ts.isMethodDeclaration(declaration)) ? declaration : value;
52
+ }
53
+
54
+ export function effectSuccess(checker: ts.TypeChecker, type: ts.Type): ts.Type | undefined {
55
+ const brand = type.getProperty("~effect/Effect");
56
+ const success = brand === undefined ? undefined : checker.getTypeOfSymbol(brand).getProperty("_A");
57
+ return success === undefined ? undefined : checker.getTypeOfSymbol(success).getCallSignatures()[0]?.getReturnType();
58
+ }