@shivaedev/quality 0.63.0 → 0.66.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (163) hide show
  1. package/CHANGELOG.md +25 -0
  2. package/README.md +13 -5
  3. package/biome/plugins/ambient-runtime.grit +3 -3
  4. package/dist/adapters/callerContextData.d.ts +3 -0
  5. package/dist/adapters/callerContextData.d.ts.map +1 -0
  6. package/dist/adapters/callerContextData.js +42 -0
  7. package/dist/adapters/callerContextData.js.map +1 -0
  8. package/dist/adapters/contextCaptureFindings.d.ts +4 -0
  9. package/dist/adapters/contextCaptureFindings.d.ts.map +1 -0
  10. package/dist/adapters/contextCaptureFindings.js +49 -0
  11. package/dist/adapters/contextCaptureFindings.js.map +1 -0
  12. package/dist/adapters/import-compiler/browserChecker.d.ts +4 -0
  13. package/dist/adapters/import-compiler/browserChecker.d.ts.map +1 -0
  14. package/dist/adapters/import-compiler/browserChecker.js +4 -0
  15. package/dist/adapters/import-compiler/browserChecker.js.map +1 -0
  16. package/dist/adapters/import-compiler/departures.d.ts +5 -0
  17. package/dist/adapters/import-compiler/departures.d.ts.map +1 -0
  18. package/dist/adapters/import-compiler/departures.js +5 -0
  19. package/dist/adapters/import-compiler/departures.js.map +1 -0
  20. package/dist/adapters/import-compiler/graph.d.ts +4 -0
  21. package/dist/adapters/import-compiler/graph.d.ts.map +1 -0
  22. package/dist/adapters/import-compiler/graph.js +6 -0
  23. package/dist/adapters/import-compiler/graph.js.map +1 -0
  24. package/dist/adapters/import-compiler/service.d.ts +10 -0
  25. package/dist/adapters/import-compiler/service.d.ts.map +1 -0
  26. package/dist/adapters/import-compiler/service.js +16 -0
  27. package/dist/adapters/import-compiler/service.js.map +1 -0
  28. package/dist/adapters/initializerDependency.d.ts +3 -0
  29. package/dist/adapters/initializerDependency.d.ts.map +1 -0
  30. package/dist/adapters/initializerDependency.js +53 -0
  31. package/dist/adapters/initializerDependency.js.map +1 -0
  32. package/dist/adapters/outsideImportFindings.d.ts.map +1 -1
  33. package/dist/adapters/outsideImportFindings.js +13 -1
  34. package/dist/adapters/outsideImportFindings.js.map +1 -1
  35. package/dist/adapters/serviceDefinitionProblems.js +1 -1
  36. package/dist/adapters/serviceDefinitionProblems.js.map +1 -1
  37. package/dist/adapters/serviceFolderFindings.d.ts.map +1 -1
  38. package/dist/adapters/serviceFolderFindings.js +12 -0
  39. package/dist/adapters/serviceFolderFindings.js.map +1 -1
  40. package/dist/adapters/serviceModelFindings.d.ts +4 -0
  41. package/dist/adapters/serviceModelFindings.d.ts.map +1 -0
  42. package/dist/adapters/serviceModelFindings.js +48 -0
  43. package/dist/adapters/serviceModelFindings.js.map +1 -0
  44. package/dist/adapters/serviceModelSyntax.d.ts +5 -0
  45. package/dist/adapters/serviceModelSyntax.d.ts.map +1 -0
  46. package/dist/adapters/serviceModelSyntax.js +53 -0
  47. package/dist/adapters/serviceModelSyntax.js.map +1 -0
  48. package/dist/adapters/serviceOperationProblems.d.ts +8 -0
  49. package/dist/adapters/serviceOperationProblems.d.ts.map +1 -0
  50. package/dist/adapters/serviceOperationProblems.js +108 -0
  51. package/dist/adapters/serviceOperationProblems.js.map +1 -0
  52. package/dist/adapters/serviceStateProblems.d.ts +7 -0
  53. package/dist/adapters/serviceStateProblems.d.ts.map +1 -0
  54. package/dist/adapters/serviceStateProblems.js +66 -0
  55. package/dist/adapters/serviceStateProblems.js.map +1 -0
  56. package/dist/cli/lint.js +1 -1
  57. package/dist/cli/lint.js.map +1 -1
  58. package/dist/imports/browserGlobals.js +1 -1
  59. package/dist/imports/browserGlobals.js.map +1 -1
  60. package/dist/imports/departures.js +1 -1
  61. package/dist/imports/departures.js.map +1 -1
  62. package/dist/imports/graph.js +1 -1
  63. package/dist/imports/graph.js.map +1 -1
  64. package/dist/rules/builtIn.d.ts +2 -2
  65. package/dist/rules/builtIn.d.ts.map +1 -1
  66. package/dist/rules/builtIn.js +2 -20
  67. package/dist/rules/builtIn.js.map +1 -1
  68. package/dist/rules/effect/adapterImports.js +1 -1
  69. package/dist/rules/effect/adapterImports.js.map +1 -1
  70. package/dist/rules/effect/contextCapture.d.ts +2 -0
  71. package/dist/rules/effect/contextCapture.d.ts.map +1 -0
  72. package/dist/rules/effect/contextCapture.js +9 -0
  73. package/dist/rules/effect/contextCapture.js.map +1 -0
  74. package/dist/rules/effect/policy.d.ts +2 -0
  75. package/dist/rules/effect/policy.d.ts.map +1 -0
  76. package/dist/rules/effect/policy.js +27 -0
  77. package/dist/rules/effect/policy.js.map +1 -0
  78. package/dist/rules/effect/serviceCatalog.d.ts +2 -2
  79. package/dist/rules/effect/serviceCatalog.d.ts.map +1 -1
  80. package/dist/rules/effect/serviceCatalog.js +14 -10
  81. package/dist/rules/effect/serviceCatalog.js.map +1 -1
  82. package/dist/rules/effect/serviceDefinitionAssembly.js +1 -1
  83. package/dist/rules/effect/serviceDefinitionAssembly.js.map +1 -1
  84. package/dist/rules/effect/serviceFolders.js +1 -1
  85. package/dist/rules/effect/serviceFolders.js.map +1 -1
  86. package/dist/rules/effect/serviceModel.d.ts +2 -0
  87. package/dist/rules/effect/serviceModel.d.ts.map +1 -0
  88. package/dist/rules/effect/serviceModel.js +9 -0
  89. package/dist/rules/effect/serviceModel.js.map +1 -0
  90. package/dist/rules/effect/serviceTypes.d.ts +2 -2
  91. package/dist/rules/effect/serviceTypes.d.ts.map +1 -1
  92. package/dist/rules/effect/serviceTypes.js +15 -3
  93. package/dist/rules/effect/serviceTypes.js.map +1 -1
  94. package/dist/rules/files/folderNames.d.ts.map +1 -1
  95. package/dist/rules/files/folderNames.js +4 -1
  96. package/dist/rules/files/folderNames.js.map +1 -1
  97. package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
  98. package/dist/rules/files/namedAfterExport.js +16 -3
  99. package/dist/rules/files/namedAfterExport.js.map +1 -1
  100. package/dist/rules/stories/adapters/failureDeadline.d.ts +5 -0
  101. package/dist/rules/stories/adapters/failureDeadline.d.ts.map +1 -0
  102. package/dist/rules/stories/adapters/failureDeadline.js +66 -0
  103. package/dist/rules/stories/adapters/failureDeadline.js.map +1 -0
  104. package/dist/rules/stories/adapters/realTime.d.ts +4 -0
  105. package/dist/rules/stories/adapters/realTime.d.ts.map +1 -0
  106. package/dist/rules/stories/adapters/realTime.js +65 -0
  107. package/dist/rules/stories/adapters/realTime.js.map +1 -0
  108. package/dist/rules/stories/waitOnEvents.d.ts.map +1 -1
  109. package/dist/rules/stories/waitOnEvents.js +13 -70
  110. package/dist/rules/stories/waitOnEvents.js.map +1 -1
  111. package/package.json +15 -15
  112. package/src/adapters/callerContextData.ts +46 -0
  113. package/src/adapters/contextCaptureFindings.ts +58 -0
  114. package/src/adapters/import-compiler/browserChecker.ts +5 -0
  115. package/src/adapters/import-compiler/departures.ts +9 -0
  116. package/src/adapters/import-compiler/graph.ts +9 -0
  117. package/src/adapters/import-compiler/service.ts +17 -0
  118. package/src/adapters/initializerDependency.ts +57 -0
  119. package/src/adapters/outsideImportFindings.ts +14 -1
  120. package/src/adapters/serviceDefinitionProblems.ts +1 -1
  121. package/src/adapters/serviceFolderFindings.ts +14 -0
  122. package/src/adapters/serviceModelFindings.ts +52 -0
  123. package/src/adapters/serviceModelSyntax.ts +58 -0
  124. package/src/adapters/serviceOperationProblems.ts +131 -0
  125. package/src/adapters/serviceStateProblems.ts +86 -0
  126. package/src/cli/lint.ts +1 -1
  127. package/src/imports/browserGlobals.ts +1 -1
  128. package/src/imports/departures.ts +1 -1
  129. package/src/imports/graph.ts +1 -1
  130. package/src/rules/builtIn.ts +2 -20
  131. package/src/rules/effect/adapterImports.ts +1 -1
  132. package/src/rules/effect/contextCapture.ts +10 -0
  133. package/src/rules/effect/policy.ts +27 -0
  134. package/src/rules/effect/serviceCatalog.ts +15 -10
  135. package/src/rules/effect/serviceDefinitionAssembly.ts +1 -1
  136. package/src/rules/effect/serviceFolders.ts +1 -1
  137. package/src/rules/effect/serviceModel.ts +10 -0
  138. package/src/rules/effect/serviceTypes.ts +15 -3
  139. package/src/rules/files/folderNames.ts +4 -1
  140. package/src/rules/files/namedAfterExport.ts +16 -3
  141. package/src/rules/stories/adapters/failureDeadline.ts +78 -0
  142. package/src/rules/stories/adapters/realTime.ts +76 -0
  143. package/src/rules/stories/waitOnEvents.ts +12 -82
  144. package/dist/adapters/ImportCompiler.d.ts +0 -10
  145. package/dist/adapters/ImportCompiler.d.ts.map +0 -1
  146. package/dist/adapters/ImportCompiler.js +0 -16
  147. package/dist/adapters/ImportCompiler.js.map +0 -1
  148. package/dist/adapters/imports/analyzeDepartures.d.ts +0 -5
  149. package/dist/adapters/imports/analyzeDepartures.d.ts.map +0 -1
  150. package/dist/adapters/imports/analyzeDepartures.js +0 -5
  151. package/dist/adapters/imports/analyzeDepartures.js.map +0 -1
  152. package/dist/adapters/imports/analyzeGraph.d.ts +0 -4
  153. package/dist/adapters/imports/analyzeGraph.d.ts.map +0 -1
  154. package/dist/adapters/imports/analyzeGraph.js +0 -6
  155. package/dist/adapters/imports/analyzeGraph.js.map +0 -1
  156. package/dist/adapters/imports/checkBrowser.d.ts +0 -4
  157. package/dist/adapters/imports/checkBrowser.d.ts.map +0 -1
  158. package/dist/adapters/imports/checkBrowser.js +0 -4
  159. package/dist/adapters/imports/checkBrowser.js.map +0 -1
  160. package/src/adapters/ImportCompiler.ts +0 -17
  161. package/src/adapters/imports/analyzeDepartures.ts +0 -9
  162. package/src/adapters/imports/analyzeGraph.ts +0 -9
  163. package/src/adapters/imports/checkBrowser.ts +0 -5
@@ -2,75 +2,14 @@ import { Effect } from "effect";
2
2
  import ts from "typescript";
3
3
  import { isTestSupport } from "#naming/testName.ts";
4
4
  import { defineRule } from "#rule.ts";
5
+ import { failingSleep } from "#rules/stories/adapters/failureDeadline.ts";
6
+ import { realTime } from "#rules/stories/adapters/realTime.ts";
5
7
  import { bindsModule, importBindings } from "./importBindings.js";
6
8
  import { storyWaitSources } from "./sources.js";
7
9
  import { memberName, syntaxFindings, unwrapped } from "./syntax.js";
8
- const MESSAGE = "Waits on time in a story or reachable test-support: a sleep, a timer, polling with eventually or waitFor, fake timers or a clock adjustment in the spec. Settle on the engine's own signal through a kit verb, such as a Deferred the engine completes, story.runUntil or screenDriver's settle(). A deadline bounds a failure but does not prove completion; reaching it must fail the story. When time passing is the behaviour, name it in a kit verb that advances TestClock.";
9
- const TIMERS = new Set(["setInterval", "setTimeout"]);
10
+ const MESSAGE = "Waits on time in a story or reachable test-support: a sleep, a real timer, a wall-clock read such as Date.now(), polling with eventually or waitFor, fake timers or a clock adjustment in the spec. Settle on the engine's own signal through a kit verb, such as a Deferred the engine completes, story.runUntil or screenDriver's settle(). A deadline bounds a failure but does not prove completion; reaching it must fail the story. When time passing is the behaviour, name it in a kit verb that advances TestClock.";
10
11
  const VI_TIMING = /^(?:useFakeTimers|advanceTimers\w*|runAllTimers\w*|runOnlyPendingTimers\w*|runAllTicks|setSystemTime|waitFor|waitUntil)$/u;
11
12
  const CLOCK_CHANGES = new Set(["adjust", "setTime"]);
12
- function terminal(body) {
13
- if (!ts.isBlock(body)) {
14
- return unwrapped(body);
15
- }
16
- const last = body.statements.at(-1);
17
- return last !== undefined && (ts.isReturnStatement(last) || ts.isExpressionStatement(last)) ? last.expression : undefined;
18
- }
19
- function fails(expression, bindings) {
20
- const value = unwrapped(expression);
21
- if (ts.isArrowFunction(value) || ts.isFunctionExpression(value)) {
22
- const result = terminal(value.body);
23
- return result !== undefined && fails(result, bindings);
24
- }
25
- if (!(ts.isCallExpression(value) && ts.isPropertyAccessExpression(value.expression))) {
26
- return false;
27
- }
28
- const receiver = value.expression.expression;
29
- return (ts.isIdentifier(receiver)
30
- && bindsModule(bindings.get(receiver.text), "Effect", ["effect"])
31
- && ["die", "fail"].includes(value.expression.name.text));
32
- }
33
- function failingSleep(call, bindings) {
34
- const access = call.parent;
35
- const pipe = access.parent;
36
- if (!(ts.isPropertyAccessExpression(access) && access.name.text === "pipe" && ts.isCallExpression(pipe) && pipe.arguments.length === 1)) {
37
- return false;
38
- }
39
- const step = pipe.arguments[0];
40
- if (step === undefined || !ts.isCallExpression(step) || memberName(step.expression) !== "andThen") {
41
- return false;
42
- }
43
- const receiver = ts.isPropertyAccessExpression(step.expression) ? step.expression.expression : undefined;
44
- return (receiver !== undefined
45
- && ts.isIdentifier(receiver)
46
- && bindsModule(bindings.get(receiver.text), "Effect", ["effect"])
47
- && step.arguments.length === 1
48
- && step.arguments[0] !== undefined
49
- && fails(step.arguments[0], bindings));
50
- }
51
- function rejectionName(call) {
52
- for (let node = call.parent; node !== undefined; node = node.parent) {
53
- if ((ts.isArrowFunction(node) || ts.isFunctionExpression(node))
54
- && ts.isNewExpression(node.parent)
55
- && ts.isIdentifier(node.parent.expression)
56
- && node.parent.expression.text === "Promise") {
57
- const name = node.parameters[1]?.name;
58
- return name !== undefined && ts.isIdentifier(name) ? name.text : undefined;
59
- }
60
- }
61
- return undefined;
62
- }
63
- function rejectingTimer(call) {
64
- const reject = rejectionName(call);
65
- const callback = call.arguments[0];
66
- if (reject === undefined || callback === undefined) {
67
- return false;
68
- }
69
- const body = ts.isArrowFunction(callback) || ts.isFunctionExpression(callback) ? terminal(callback.body) : callback;
70
- return (body !== undefined
71
- && ((ts.isIdentifier(body) && body.text === reject)
72
- || (ts.isCallExpression(body) && ts.isIdentifier(body.expression) && body.expression.text === reject)));
73
- }
74
13
  function receiverOf(callee) {
75
14
  const receiver = ts.isPropertyAccessExpression(callee) ? unwrapped(callee.expression) : undefined;
76
15
  return receiver !== undefined && ts.isIdentifier(receiver) ? receiver : undefined;
@@ -82,25 +21,28 @@ function vitestTiming(receiver, bindings) {
82
21
  function timedWait(call, bindings, support) {
83
22
  const callee = unwrapped(call.expression);
84
23
  if (ts.isIdentifier(callee)) {
85
- return ((TIMERS.has(callee.text) && !(callee.text === "setTimeout" && rejectingTimer(call))) || bindings.get(callee.text)?.imported === "eventually");
24
+ const binding = bindings.get(callee.text);
25
+ return (binding?.imported === "eventually"
26
+ || (binding?.module === "effect/Effect" && binding.imported === "sleep" && !failingSleep(call, bindings))
27
+ || realTime(call, bindings));
86
28
  }
87
29
  const member = memberName(callee) ?? "";
88
30
  const receiver = receiverOf(callee);
89
31
  if (receiver === undefined) {
90
- return false;
32
+ return realTime(call, bindings);
91
33
  }
92
34
  const binding = bindings.get(receiver.text);
93
- return ((member === "sleep" && bindsModule(binding, "Effect", ["effect"]) && !failingSleep(call, bindings))
35
+ return (realTime(call, bindings)
36
+ || (member === "sleep" && bindsModule(binding, "Effect", ["effect"]) && !failingSleep(call, bindings))
94
37
  || (VI_TIMING.test(member) && vitestTiming(receiver, bindings))
95
- || (!support && CLOCK_CHANGES.has(member) && bindsModule(binding, "TestClock", ["effect/testing"]))
96
- || (TIMERS.has(member) && receiver.text === "globalThis" && !(member === "setTimeout" && rejectingTimer(call))));
38
+ || (!support && CLOCK_CHANGES.has(member) && bindsModule(binding, "TestClock", ["effect/testing"])));
97
39
  }
98
40
  function timedWaits(source) {
99
41
  const bindings = importBindings(source);
100
42
  const support = isTestSupport(source.fileName);
101
43
  const found = [];
102
44
  function visit(node) {
103
- if (ts.isCallExpression(node) && timedWait(node, bindings, support)) {
45
+ if ((ts.isCallExpression(node) && timedWait(node, bindings, support)) || (ts.isNewExpression(node) && realTime(node, bindings))) {
104
46
  found.push(node);
105
47
  }
106
48
  ts.forEachChild(node, visit);
@@ -112,5 +54,6 @@ export const waitOnEvents = defineRule({
112
54
  check: (inputs) => Effect.map(storyWaitSources(inputs), (sources) => sources.flatMap((file) => syntaxFindings(file, timedWaits, MESSAGE))),
113
55
  description: "Stories and reachable test-support settle on the engine's own signals; controlled clock advances belong in kit verbs.",
114
56
  id: "tests/wait-on-events",
57
+ registrable: false,
115
58
  });
116
59
  //# sourceMappingURL=waitOnEvents.js.map
@@ -1 +1 @@
1
- {"version":3,"file":"waitOnEvents.js","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,WAAW,EAAsB,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACtF,OAAO,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEpE,MAAM,OAAO,GACZ,mdAAmd,CAAC;AAErd,MAAM,MAAM,GAAG,IAAI,GAAG,CAAC,CAAC,aAAa,EAAE,YAAY,CAAC,CAAC,CAAC;AACtD,MAAM,SAAS,GAAG,2HAA2H,CAAC;AAC9I,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,QAAQ,CAAC,IAAoB;IACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;QACvB,OAAO,SAAS,CAAC,IAAI,CAAC,CAAC;IACxB,CAAC;IACD,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACpC,OAAO,IAAI,KAAK,SAAS,IAAI,CAAC,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;AAC3H,CAAC;AAED,SAAS,KAAK,CAAC,UAAyB,EAAE,QAA4C;IACrF,MAAM,KAAK,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC;IACpC,IAAI,EAAE,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,KAAK,CAAC,EAAE,CAAC;QACjE,MAAM,MAAM,GAAG,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QACpC,OAAO,MAAM,KAAK,SAAS,IAAI,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC;IACxD,CAAC;IACD,IAAI,CAAC,CAAC,EAAE,CAAC,gBAAgB,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,EAAE,CAAC;QACtF,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,QAAQ,GAAG,KAAK,CAAC,UAAU,CAAC,UAAU,CAAC;IAC7C,OAAO,CACN,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC;WACtB,WAAW,CAAC,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC;WAC9D,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CACvD,CAAC;AACH,CAAC;AAED,SAAS,YAAY,CAAC,IAAuB,EAAE,QAA4C;IAC1F,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;IAC3B,MAAM,IAAI,GAAG,MAAM,CAAC,MAAM,CAAC;IAC3B,IAAI,CAAC,CAAC,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,IAAI,CAAC,IAAI,KAAK,MAAM,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,CAAC,EAAE,CAAC;QACzI,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IAC/B,IAAI,IAAI,KAAK,SAAS,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,SAAS,EAAE,CAAC;QACnG,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;IACzG,OAAO,CACN,QAAQ,KAAK,SAAS;WACnB,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC;WACzB,WAAW,CAAC,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC;WAC9D,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;WAC3B,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,KAAK,SAAS;WAC/B,KAAK,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,QAAQ,CAAC,CACrC,CAAC;AACH,CAAC;AAED,SAAS,aAAa,CAAC,IAAuB;IAC7C,KAAK,IAAI,IAAI,GAAwB,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,SAAS,EAAE,IAAI,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC;QAC1F,IACC,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAC;eACxD,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,MAAM,CAAC;eAC/B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,UAAU,CAAC;eACvC,IAAI,CAAC,MAAM,CAAC,UAAU,CAAC,IAAI,KAAK,SAAS,EAC3C,CAAC;YACF,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC;YACtC,OAAO,IAAI,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;QAC5E,CAAC;IACF,CAAC;IACD,OAAO,SAAS,CAAC;AAClB,CAAC;AAED,SAAS,cAAc,CAAC,IAAuB;IAC9C,MAAM,MAAM,GAAG,aAAa,CAAC,IAAI,CAAC,CAAC;IACnC,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IACnC,IAAI,MAAM,KAAK,SAAS,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QACpD,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC;IACpH,OAAO,CACN,IAAI,KAAK,SAAS;WACf,CAAC,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,KAAK,MAAM,CAAC;eAC/C,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC,CACvG,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,OAAO,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;AACnF,CAAC;AAED,SAAS,YAAY,CAAC,QAAuB,EAAE,QAA4C;IAC1F,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC,CAAC,WAAW,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,QAAQ,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAClH,CAAC;AAED,SAAS,SAAS,CAAC,IAAuB,EAAE,QAA4C,EAAE,OAAgB;IACzG,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,OAAO,CACN,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,QAAQ,KAAK,YAAY,CAC5I,CAAC;IACH,CAAC;IACD,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;IACxC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC;IACpC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QAC5B,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,CACN,CAAC,MAAM,KAAK,OAAO,IAAI,WAAW,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WAChG,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,YAAY,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;WAC5D,CAAC,CAAC,OAAO,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,WAAW,CAAC,OAAO,EAAE,WAAW,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC;WAChG,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,QAAQ,CAAC,IAAI,KAAK,YAAY,IAAI,CAAC,CAAC,MAAM,KAAK,YAAY,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,CAC/G,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;IAC/C,MAAM,KAAK,GAAc,EAAE,CAAC;IAC5B,SAAS,KAAK,CAAC,IAAa;QAC3B,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,EAAE,CAAC;YACrE,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClB,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC9B,CAAC;IACD,KAAK,CAAC,MAAM,CAAC,CAAC;IACd,OAAO,KAAK,CAAC;AACd,CAAC;AAED,MAAM,CAAC,MAAM,YAAY,GAAG,UAAU,CAAC;IACtC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC,CAAC;IAC1I,WAAW,EAAE,uHAAuH;IACpI,EAAE,EAAE,sBAAsB;CAC1B,CAAC,CAAC"}
1
+ {"version":3,"file":"waitOnEvents.js","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,YAAY,EAAE,MAAM,4CAA4C,CAAC;AAC1E,OAAO,EAAE,QAAQ,EAAE,MAAM,qCAAqC,CAAC;AAC/D,OAAO,EAAE,WAAW,EAAsB,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACtF,OAAO,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEpE,MAAM,OAAO,GACZ,8fAA8f,CAAC;AAEhgB,MAAM,SAAS,GAAG,2HAA2H,CAAC;AAC9I,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,OAAO,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;AACnF,CAAC;AAED,SAAS,YAAY,CAAC,QAAuB,EAAE,QAA4C;IAC1F,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC,CAAC,WAAW,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,QAAQ,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAClH,CAAC;AAED,SAAS,SAAS,CAAC,IAAuB,EAAE,QAA4C,EAAE,OAAgB;IACzG,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC1C,OAAO,CACN,OAAO,EAAE,QAAQ,KAAK,YAAY;eAC/B,CAAC,OAAO,EAAE,MAAM,KAAK,eAAe,IAAI,OAAO,CAAC,QAAQ,KAAK,OAAO,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;eACtG,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAC3B,CAAC;IACH,CAAC;IACD,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;IACxC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC;IACpC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QAC5B,OAAO,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACjC,CAAC;IACD,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,CACN,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC;WACrB,CAAC,MAAM,KAAK,OAAO,IAAI,WAAW,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WACnG,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,YAAY,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;WAC5D,CAAC,CAAC,OAAO,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,WAAW,CAAC,OAAO,EAAE,WAAW,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,CACnG,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;IAC/C,MAAM,KAAK,GAAc,EAAE,CAAC;IAC5B,SAAS,KAAK,CAAC,IAAa;QAC3B,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,EAAE,CAAC;YACjI,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClB,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC9B,CAAC;IACD,KAAK,CAAC,MAAM,CAAC,CAAC;IACd,OAAO,KAAK,CAAC;AACd,CAAC;AAED,MAAM,CAAC,MAAM,YAAY,GAAG,UAAU,CAAC;IACtC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC,CAAC;IAC1I,WAAW,EAAE,uHAAuH;IACpI,EAAE,EAAE,sBAAsB;IAC1B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@shivaedev/quality",
3
- "version": "0.63.0",
3
+ "version": "0.66.0",
4
4
  "description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
5
5
  "homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
6
6
  "bugs": {
@@ -51,31 +51,31 @@
51
51
  ],
52
52
  "dependencies": {
53
53
  "@biomejs/biome": "2.6.4",
54
- "@shivaedev/errors": "0.9.1",
55
- "@shivaedev/heavy-lock": "0.10.1",
56
- "@shivaedev/service": "0.7.1",
57
- "@shivaedev/skills": "0.7.1",
54
+ "@shivaedev/errors": "0.10.0",
55
+ "@shivaedev/heavy-lock": "0.11.0",
56
+ "@shivaedev/service": "0.8.0",
57
+ "@shivaedev/skills": "0.8.0",
58
58
  "@vitest/coverage-v8": "5.0.5",
59
59
  "ignore": "7.0.14",
60
- "knip": "6.43.0",
60
+ "knip": "6.44.0",
61
61
  "sort-package-json": "4.1.0",
62
62
  "typescript": "npm:@typescript/typescript6@6.0.2"
63
63
  },
64
64
  "devDependencies": {
65
- "@effect/platform-node": "4.0.7",
66
- "@effect/platform-node-shared": "4.0.7",
67
- "@effect/vitest": "4.0.7",
68
- "@shivaedev/test-story": "0.40.0",
65
+ "@effect/platform-node": "4.1.0",
66
+ "@effect/platform-node-shared": "4.1.0",
67
+ "@effect/vitest": "4.1.0",
68
+ "@shivaedev/test-story": "0.42.1",
69
69
  "@types/node": "24.19.2",
70
70
  "@typescript/native": "npm:typescript@7.0.2",
71
- "effect": "4.0.7",
71
+ "effect": "4.1.0",
72
72
  "vitest": "5.0.5"
73
73
  },
74
74
  "peerDependencies": {
75
- "@effect/platform-node": "4.0.7",
76
- "@effect/platform-node-shared": "4.0.7",
77
- "@shivaedev/test-story": "0.40.0",
78
- "effect": "4.0.7",
75
+ "@effect/platform-node": "4.1.0",
76
+ "@effect/platform-node-shared": "4.1.0",
77
+ "@shivaedev/test-story": "0.42.1",
78
+ "effect": "4.1.0",
79
79
  "vitest": "5.0.5"
80
80
  },
81
81
  "peerDependenciesMeta": {
@@ -0,0 +1,46 @@
1
+ import ts from "typescript";
2
+
3
+ const CALLERS = new Set(["SessionUser", "Subject", "Identity", "SessionUserWithProviderAccounts"]);
4
+
5
+ function data(checker: ts.TypeChecker, value: ts.Type, seen: Set<ts.Type>): boolean {
6
+ if (seen.has(value)) {
7
+ return true;
8
+ }
9
+ seen.add(value);
10
+ if (value.flags & (ts.TypeFlags.Any | ts.TypeFlags.Unknown)) {
11
+ return false;
12
+ }
13
+ if (
14
+ value.flags
15
+ & (ts.TypeFlags.StringLike
16
+ | ts.TypeFlags.NumberLike
17
+ | ts.TypeFlags.BooleanLike
18
+ | ts.TypeFlags.ESSymbolLike
19
+ | ts.TypeFlags.BigIntLike
20
+ | ts.TypeFlags.Null
21
+ | ts.TypeFlags.Undefined
22
+ | ts.TypeFlags.Never)
23
+ ) {
24
+ return true;
25
+ }
26
+ if (value.isUnionOrIntersection()) {
27
+ return value.types.every((part) => data(checker, part, seen));
28
+ }
29
+ if (value.getProperty("~effect/Context/Service") !== undefined || value.getProperty("~effect/Context") !== undefined) {
30
+ return false;
31
+ }
32
+ if (value.getProperty("~effect/Effect") !== undefined) {
33
+ return true;
34
+ }
35
+ if (value.getCallSignatures().length > 0 || value.getConstructSignatures().length > 0) {
36
+ return false;
37
+ }
38
+ const element = checker.getIndexTypeOfType(value, ts.IndexKind.Number);
39
+ return element === undefined
40
+ ? value.getProperties().every((property) => data(checker, checker.getTypeOfSymbol(property), seen))
41
+ : data(checker, element, seen);
42
+ }
43
+
44
+ export function callerContextData(checker: ts.TypeChecker, type: ts.Type, name: string): boolean {
45
+ return CALLERS.has(name) && data(checker, type, new Set());
46
+ }
@@ -0,0 +1,58 @@
1
+ import { join } from "node:path";
2
+ import { Effect } from "effect";
3
+ import ts from "typescript";
4
+ import { effectApi } from "#adapters/serviceModelSyntax.ts";
5
+ import type { Finding, RuleInputs } from "#rule.ts";
6
+ import { effectProgram } from "#rules/effect/program.ts";
7
+
8
+ const RUNNERS = ["provideContext", "runPromiseWith", "runForkWith"];
9
+ const PROVIDERS = [...RUNNERS, "provide"];
10
+
11
+ function context(type: ts.Type): boolean {
12
+ return type.isUnionOrIntersection() ? type.types.some(context) : type.getProperty("~effect/Context") !== undefined;
13
+ }
14
+
15
+ function reprovides(checker: ts.TypeChecker, call: ts.CallExpression): boolean {
16
+ if (RUNNERS.some((name) => effectApi(checker, call.expression, name))) {
17
+ return true;
18
+ }
19
+ if (!effectApi(checker, call.expression, "provide")) {
20
+ return false;
21
+ }
22
+ const environment = call.arguments.at(-1);
23
+ return environment !== undefined && context(checker.getTypeAtLocation(environment));
24
+ }
25
+
26
+ export const contextCaptureFindings = Effect.fn("ContextCapture.contextCaptureFindings")((inputs: RuleInputs) =>
27
+ Effect.sync(() => {
28
+ const sources = inputs.sources.filter(
29
+ (file) => !/(?:^|\/)(?:adapters|test-support)\//u.test(file.path) && PROVIDERS.some((name) => file.text.includes(name)),
30
+ );
31
+ if (sources.length === 0) {
32
+ return [];
33
+ }
34
+ const program = effectProgram({ ...inputs, sources });
35
+ const checker = program.getTypeChecker();
36
+ return sources.flatMap((file): readonly Finding[] => {
37
+ const source = program.getSourceFile(join(inputs.root, file.path));
38
+ if (source === undefined) {
39
+ return [];
40
+ }
41
+ const syntax = source;
42
+ const findings: Finding[] = [];
43
+ function visit(node: ts.Node): void {
44
+ if (ts.isCallExpression(node) && reprovides(checker, node)) {
45
+ findings.push({
46
+ file: file.path,
47
+ line: syntax.getLineAndCharacterOfPosition(node.getStart(syntax)).line + 1,
48
+ message:
49
+ "Do not re-provide a captured Effect context in core code. Declare service requirements once and yield dependencies and the caller from the environment. Register the Layer at the host; put runtime bridges in adapters/ or test-support/.",
50
+ });
51
+ }
52
+ ts.forEachChild(node, visit);
53
+ }
54
+ visit(source);
55
+ return findings;
56
+ });
57
+ }),
58
+ );
@@ -0,0 +1,5 @@
1
+ import { Effect } from "effect";
2
+ import type ts from "typescript";
3
+ import { browserChecker as createBrowserChecker } from "#adapters/imports/browserChecker.ts";
4
+
5
+ export const browserChecker = Effect.fn("ImportCompiler.browserChecker")((source: ts.SourceFile) => Effect.sync(() => createBrowserChecker(source)));
@@ -0,0 +1,9 @@
1
+ import { Effect } from "effect";
2
+ import { analysisFailure } from "#adapters/imports/analysisFailure.ts";
3
+ import { departures as findDepartures } from "#adapters/imports/departures.ts";
4
+ import type { WorkspacePackage } from "#imports/workspace.ts";
5
+ import type { RuleInputs } from "#rule.ts";
6
+
7
+ export const departures = Effect.fn("ImportCompiler.departures")((inputs: RuleInputs, packages: readonly WorkspacePackage[]) =>
8
+ Effect.try({ catch: (cause) => analysisFailure(inputs.root, cause), try: () => findDepartures(inputs, packages) }),
9
+ );
@@ -0,0 +1,9 @@
1
+ import { realpathSync } from "node:fs";
2
+ import { Effect } from "effect";
3
+ import { analysisFailure } from "#adapters/imports/analysisFailure.ts";
4
+ import { graph as buildGraph } from "#adapters/imports/graph.ts";
5
+ import type { RuleInputs } from "#rule.ts";
6
+
7
+ export const graph = Effect.fn("ImportCompiler.graph")((inputs: RuleInputs) =>
8
+ Effect.try({ catch: (cause) => analysisFailure(inputs.root, cause), try: () => buildGraph(inputs, realpathSync(inputs.root)) }),
9
+ );
@@ -0,0 +1,17 @@
1
+ import { Effect } from "effect";
2
+ import type ts from "typescript";
3
+ import { defineService } from "@shivaedev/service/defineService.ts";
4
+ import { browserChecker } from "./browserChecker.ts";
5
+ import { departures } from "./departures.ts";
6
+ import { graph } from "./graph.ts";
7
+
8
+ export const ImportCompiler = defineService({
9
+ id: "@shivaedev/quality/ImportCompiler",
10
+ initialize: Effect.void,
11
+ methods: () => ({
12
+ browserChecker: browserChecker satisfies (source: ts.SourceFile) => Effect.Effect<ts.TypeChecker>,
13
+ departures,
14
+ graph,
15
+ }),
16
+ requires: [],
17
+ });
@@ -0,0 +1,57 @@
1
+ import ts from "typescript";
2
+ import { effectSuccess } from "#adapters/serviceModelSyntax.ts";
3
+
4
+ const DATA =
5
+ ts.TypeFlags.StringLike
6
+ | ts.TypeFlags.NumberLike
7
+ | ts.TypeFlags.BooleanLike
8
+ | ts.TypeFlags.ESSymbolLike
9
+ | ts.TypeFlags.BigIntLike
10
+ | ts.TypeFlags.Null
11
+ | ts.TypeFlags.Undefined
12
+ | ts.TypeFlags.Void
13
+ | ts.TypeFlags.Never
14
+ | ts.TypeFlags.Unknown
15
+ | ts.TypeFlags.Any;
16
+ const OWNED = /\/effect\/(?:src|dist(?:\/dts)?)\/(?:Ref|SynchronizedRef|ScopedRef|Cache|ScopedCache|Semaphore|Deferred)\.(?:d\.)?ts$/u;
17
+ const COLLECTIONS = new Set(["Map", "ReadonlyMap", "Set", "ReadonlySet", "Array", "ReadonlyArray"]);
18
+
19
+ function owned(type: ts.Type): boolean {
20
+ const symbol = type.getSymbol();
21
+ return (symbol?.declarations ?? []).some((declaration) => {
22
+ const path = declaration.getSourceFile().fileName.replaceAll("\\", "/");
23
+ return OWNED.test(path) || (COLLECTIONS.has(symbol?.name ?? "") && /\/lib\.[^/]+\.d\.ts$/u.test(path));
24
+ });
25
+ }
26
+
27
+ function reference(type: ts.Type): type is ts.TypeReference {
28
+ return "objectFlags" in type && typeof type.objectFlags === "number" && (type.objectFlags & ts.ObjectFlags.Reference) !== 0;
29
+ }
30
+
31
+ export function initializerDependency(checker: ts.TypeChecker, type: ts.Type, seen = new Set<ts.Type>()): boolean {
32
+ if (seen.has(type) || type.flags & DATA) {
33
+ return false;
34
+ }
35
+ seen.add(type);
36
+ if (type.isUnionOrIntersection()) {
37
+ return type.types.some((part) => initializerDependency(checker, part, seen));
38
+ }
39
+ const success = effectSuccess(checker, type);
40
+ if (success !== undefined) {
41
+ return initializerDependency(checker, success, seen);
42
+ }
43
+ if (owned(type)) {
44
+ const arguments_ = reference(type) ? checker.getTypeArguments(type) : [];
45
+ return arguments_.some((argument) => initializerDependency(checker, argument, seen));
46
+ }
47
+ for (const signature of type.getCallSignatures()) {
48
+ const result = signature.getReturnType();
49
+ if (effectSuccess(checker, result) !== undefined || (result.getProperty("then") !== undefined && result.getSymbol()?.name === "Promise")) {
50
+ return true;
51
+ }
52
+ if (initializerDependency(checker, result, seen)) {
53
+ return true;
54
+ }
55
+ }
56
+ return type.getProperties().some((property) => initializerDependency(checker, checker.getTypeOfSymbol(property), seen));
57
+ }
@@ -7,6 +7,19 @@ import { packageOf } from "#imports/workspace.ts";
7
7
  import { testName } from "#naming/testName.ts";
8
8
  import type { Finding, RuleInputs } from "#rule.ts";
9
9
 
10
+ const CLIENT_RENDERING_LIBRARIES = new Set([
11
+ "react",
12
+ "react-dom",
13
+ "lucide-react",
14
+ "@base-ui/react",
15
+ "@tanstack/react-router",
16
+ "@tanstack/react-table",
17
+ "class-variance-authority",
18
+ "cn",
19
+ "clsx",
20
+ "tailwind-merge",
21
+ ]);
22
+
10
23
  function exempt(path: string, name: string): boolean {
11
24
  return (
12
25
  /(?:^|\/)(?:adapters|test-support)\//u.test(path)
@@ -14,7 +27,7 @@ function exempt(path: string, name: string): boolean {
14
27
  || name === "effect"
15
28
  || name.startsWith("@effect/")
16
29
  || name.startsWith("@shivaedev/")
17
- || ((name === "react" || name === "react-dom") && /(?:^|\/)client\//u.test(path))
30
+ || (CLIENT_RENDERING_LIBRARIES.has(name) && /(?:^|\/)client\//u.test(path))
18
31
  );
19
32
  }
20
33
 
@@ -54,7 +54,7 @@ export function serviceDefinitionProblems(
54
54
  for (const operation of methods?.properties ?? []) {
55
55
  if (!isOperationReference(operation, imports, generics)) {
56
56
  found.push({
57
- message: "Reference a named operation export or call its named state factory.",
57
+ message: "Reference a named Effect.fn operation export that yields its dependencies. Use a state factory only for owned lifetime state.",
58
58
  node: operation,
59
59
  });
60
60
  }
@@ -59,6 +59,20 @@ export function serviceFolderFindings({ files, sources }: RuleInputs): readonly
59
59
  }),
60
60
  );
61
61
  const findings: Finding[] = [];
62
+ for (const file of sources) {
63
+ const source = parse(file);
64
+ if (source !== undefined && directServiceDefinitions(source, serviceAssemblyImports(source).definitions).length > 0) {
65
+ folders.add(posix.dirname(file.path));
66
+ if (posix.basename(file.path) !== "service.ts" && files.includes(`${posix.dirname(file.path)}/service.ts`)) {
67
+ findings.push({
68
+ file: file.path,
69
+ message:
70
+ "Give each service its own folder and move this declaration to its service.ts. Keep that service's operations in focused sibling files.",
71
+ });
72
+ }
73
+ }
74
+ }
75
+
62
76
  for (const folder of folders) {
63
77
  const service = `${folder}/service.ts`;
64
78
  if (!files.includes(service)) {
@@ -0,0 +1,52 @@
1
+ import { join } from "node:path";
2
+ import { Effect } from "effect";
3
+ import ts from "typescript";
4
+ import { serviceAssemblyImports } from "#adapters/serviceAssemblyImports.ts";
5
+ import { directServiceDefinitions } from "#adapters/serviceAssemblySyntax.ts";
6
+ import { serviceOperationProblems } from "#adapters/serviceOperationProblems.ts";
7
+ import { serviceStateProblems } from "#adapters/serviceStateProblems.ts";
8
+ import type { Finding, RuleInputs } from "#rule.ts";
9
+ import { effectProgram } from "#rules/effect/program.ts";
10
+ import { serviceCatalog } from "#rules/effect/serviceCatalog.ts";
11
+ import { parse } from "#rules/parse.ts";
12
+
13
+ function checkServices(inputs: RuleInputs): readonly Finding[] {
14
+ const program = effectProgram(inputs);
15
+ const checker = program.getTypeChecker();
16
+ const services = serviceCatalog(program, checker, [], true);
17
+ const found: Finding[] = [];
18
+ for (const file of inputs.sources) {
19
+ const source = program.getSourceFile(join(inputs.root, file.path));
20
+ if (source === undefined) {
21
+ continue;
22
+ }
23
+ for (const definition of directServiceDefinitions(source, serviceAssemblyImports(source).definitions)) {
24
+ const config = definition.arguments[0];
25
+ if (config === undefined || !ts.isObjectLiteralExpression(config)) {
26
+ continue;
27
+ }
28
+ const problems = [...serviceStateProblems(checker, config, services), ...serviceOperationProblems(checker, config, source.fileName)];
29
+ for (const { node, message } of problems) {
30
+ found.push({ file: file.path, line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1, message });
31
+ }
32
+ }
33
+ }
34
+ return found;
35
+ }
36
+
37
+ export const serviceModelFindings = Effect.fn("ServiceModel.serviceModelFindings")((inputs: RuleInputs) =>
38
+ Effect.sync(() => {
39
+ const groups = new Map<string, RuleInputs["sources"][number][]>();
40
+ for (const file of inputs.sources) {
41
+ const source = parse(file);
42
+ if (source === undefined || directServiceDefinitions(source, serviceAssemblyImports(source).definitions).length === 0) {
43
+ continue;
44
+ }
45
+ const group = /^(?:packages|examples)\/[^/]+/u.exec(file.path)?.[0] ?? ".";
46
+ const sources = groups.get(group) ?? [];
47
+ sources.push(file);
48
+ groups.set(group, sources);
49
+ }
50
+ return [...groups.values()].flatMap((sources) => checkServices({ ...inputs, sources }));
51
+ }),
52
+ );
@@ -0,0 +1,58 @@
1
+ import ts from "typescript";
2
+ import { unwrapExpression } from "#adapters/serviceAssemblySyntax.ts";
3
+ import { boundaryReference } from "#rules/effect/boundaryReference.ts";
4
+
5
+ export function effectApi(checker: ts.TypeChecker, node: ts.Node, name: string): boolean {
6
+ if (ts.isParenthesizedExpression(node)) {
7
+ return effectApi(checker, node.expression, name);
8
+ }
9
+ if (ts.isPropertyAccessExpression(node) && node.name.text !== name) {
10
+ return false;
11
+ }
12
+ const reference = boundaryReference(checker, node);
13
+ if (reference === `effect.Effect.${name}` || reference === `effect/Effect.${name}`) {
14
+ return true;
15
+ }
16
+ const declaration = declarationOf(checker, node);
17
+ if (declaration === undefined) {
18
+ return false;
19
+ }
20
+ const path = declaration.getSourceFile().fileName.replaceAll("\\", "/");
21
+ return (
22
+ /\/effect\/(?:src|dist(?:\/dts)?)\/Effect\.(?:d\.)?ts$/u.test(path)
23
+ && (ts.isVariableDeclaration(declaration) || ts.isFunctionDeclaration(declaration))
24
+ && declaration.name !== undefined
25
+ && ts.isIdentifier(declaration.name)
26
+ && declaration.name.text === name
27
+ );
28
+ }
29
+
30
+ function declarationOf(checker: ts.TypeChecker, node: ts.Node): ts.Declaration | undefined {
31
+ const symbol = ts.isShorthandPropertyAssignment(node.parent)
32
+ ? checker.getShorthandAssignmentValueSymbol(node.parent)
33
+ : checker.getSymbolAtLocation(node);
34
+ if (symbol === undefined) {
35
+ return;
36
+ }
37
+ const target = symbol.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(symbol) : symbol;
38
+ return target.valueDeclaration ?? target.declarations?.[0];
39
+ }
40
+
41
+ export function resolvedValue(checker: ts.TypeChecker, expression: ts.Expression, seen = new Set<ts.Node>()): ts.Node {
42
+ const value = unwrapExpression(expression);
43
+ if (seen.has(value)) {
44
+ return value;
45
+ }
46
+ seen.add(value);
47
+ const declaration = declarationOf(checker, value);
48
+ if (declaration !== undefined && ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
49
+ return resolvedValue(checker, declaration.initializer, seen);
50
+ }
51
+ return declaration !== undefined && (ts.isFunctionDeclaration(declaration) || ts.isMethodDeclaration(declaration)) ? declaration : value;
52
+ }
53
+
54
+ export function effectSuccess(checker: ts.TypeChecker, type: ts.Type): ts.Type | undefined {
55
+ const brand = type.getProperty("~effect/Effect");
56
+ const success = brand === undefined ? undefined : checker.getTypeOfSymbol(brand).getProperty("_A");
57
+ return success === undefined ? undefined : checker.getTypeOfSymbol(success).getCallSignatures()[0]?.getReturnType();
58
+ }