@shivaedev/quality 0.62.1 → 0.65.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (125) hide show
  1. package/CHANGELOG.md +34 -0
  2. package/README.md +20 -4
  3. package/biome/plugins/ambient-runtime.grit +3 -3
  4. package/dist/adapters/biome/run.d.ts.map +1 -1
  5. package/dist/adapters/biome/run.js +6 -2
  6. package/dist/adapters/biome/run.js.map +1 -1
  7. package/dist/adapters/databaseUrlFindings.d.ts +11 -0
  8. package/dist/adapters/databaseUrlFindings.d.ts.map +1 -0
  9. package/dist/adapters/databaseUrlFindings.js +20 -0
  10. package/dist/adapters/databaseUrlFindings.js.map +1 -0
  11. package/dist/adapters/databaseUrlReads.d.ts +3 -0
  12. package/dist/adapters/databaseUrlReads.d.ts.map +1 -0
  13. package/dist/adapters/databaseUrlReads.js +107 -0
  14. package/dist/adapters/databaseUrlReads.js.map +1 -0
  15. package/dist/adapters/imports/resolve.js +1 -1
  16. package/dist/adapters/imports/resolve.js.map +1 -1
  17. package/dist/adapters/knip/report.d.ts +3 -0
  18. package/dist/adapters/knip/report.d.ts.map +1 -0
  19. package/dist/adapters/knip/report.js +22 -0
  20. package/dist/adapters/knip/report.js.map +1 -0
  21. package/dist/adapters/knip/run.d.ts +1 -1
  22. package/dist/adapters/knip/run.d.ts.map +1 -1
  23. package/dist/adapters/knip/run.js +3 -5
  24. package/dist/adapters/knip/run.js.map +1 -1
  25. package/dist/adapters/outsideImportFindings.d.ts.map +1 -1
  26. package/dist/adapters/outsideImportFindings.js +15 -31
  27. package/dist/adapters/outsideImportFindings.js.map +1 -1
  28. package/dist/adapters/units/runtime.d.ts +6 -0
  29. package/dist/adapters/units/runtime.d.ts.map +1 -0
  30. package/dist/adapters/units/runtime.js +46 -0
  31. package/dist/adapters/units/runtime.js.map +1 -0
  32. package/dist/adapters/units/runtimeImports.d.ts +10 -0
  33. package/dist/adapters/units/runtimeImports.d.ts.map +1 -0
  34. package/dist/adapters/units/runtimeImports.js +51 -0
  35. package/dist/adapters/units/runtimeImports.js.map +1 -0
  36. package/dist/adapters/units/runtimeOrigins.d.ts +4 -0
  37. package/dist/adapters/units/runtimeOrigins.d.ts.map +1 -0
  38. package/dist/adapters/units/runtimeOrigins.js +85 -0
  39. package/dist/adapters/units/runtimeOrigins.js.map +1 -0
  40. package/dist/adapters/units/runtimeUse.d.ts +8 -0
  41. package/dist/adapters/units/runtimeUse.d.ts.map +1 -0
  42. package/dist/adapters/units/runtimeUse.js +60 -0
  43. package/dist/adapters/units/runtimeUse.js.map +1 -0
  44. package/dist/cli/lint.js +1 -1
  45. package/dist/cli/lint.js.map +1 -1
  46. package/dist/imports/extract.d.ts.map +1 -1
  47. package/dist/imports/extract.js +13 -2
  48. package/dist/imports/extract.js.map +1 -1
  49. package/dist/inventory/collect.d.ts.map +1 -1
  50. package/dist/inventory/collect.js +3 -0
  51. package/dist/inventory/collect.js.map +1 -1
  52. package/dist/inventory/skillCopies.d.ts +7 -0
  53. package/dist/inventory/skillCopies.d.ts.map +1 -0
  54. package/dist/inventory/skillCopies.js +25 -0
  55. package/dist/inventory/skillCopies.js.map +1 -0
  56. package/dist/manifests/sorted.d.ts +1 -1
  57. package/dist/manifests/sorted.d.ts.map +1 -1
  58. package/dist/manifests/sorted.js +7 -4
  59. package/dist/manifests/sorted.js.map +1 -1
  60. package/dist/rules/builtIn.d.ts +2 -2
  61. package/dist/rules/builtIn.d.ts.map +1 -1
  62. package/dist/rules/builtIn.js +4 -0
  63. package/dist/rules/builtIn.js.map +1 -1
  64. package/dist/rules/effect/adapterImports.js +1 -1
  65. package/dist/rules/effect/adapterImports.js.map +1 -1
  66. package/dist/rules/files/folderNames.d.ts.map +1 -1
  67. package/dist/rules/files/folderNames.js +4 -1
  68. package/dist/rules/files/folderNames.js.map +1 -1
  69. package/dist/rules/manifestsNoTestKits.d.ts +2 -0
  70. package/dist/rules/manifestsNoTestKits.d.ts.map +1 -0
  71. package/dist/rules/manifestsNoTestKits.js +59 -0
  72. package/dist/rules/manifestsNoTestKits.js.map +1 -0
  73. package/dist/rules/stories/adapters/failureDeadline.d.ts +5 -0
  74. package/dist/rules/stories/adapters/failureDeadline.d.ts.map +1 -0
  75. package/dist/rules/stories/adapters/failureDeadline.js +66 -0
  76. package/dist/rules/stories/adapters/failureDeadline.js.map +1 -0
  77. package/dist/rules/stories/adapters/realTime.d.ts +4 -0
  78. package/dist/rules/stories/adapters/realTime.d.ts.map +1 -0
  79. package/dist/rules/stories/adapters/realTime.js +65 -0
  80. package/dist/rules/stories/adapters/realTime.js.map +1 -0
  81. package/dist/rules/stories/databaseUrl.d.ts +2 -0
  82. package/dist/rules/stories/databaseUrl.d.ts.map +1 -0
  83. package/dist/rules/stories/databaseUrl.js +8 -0
  84. package/dist/rules/stories/databaseUrl.js.map +1 -0
  85. package/dist/rules/stories/engineOf.d.ts.map +1 -1
  86. package/dist/rules/stories/engineOf.js +1 -0
  87. package/dist/rules/stories/engineOf.js.map +1 -1
  88. package/dist/rules/stories/specs.d.ts.map +1 -1
  89. package/dist/rules/stories/specs.js +2 -1
  90. package/dist/rules/stories/specs.js.map +1 -1
  91. package/dist/rules/stories/unitTests.d.ts +2 -2
  92. package/dist/rules/stories/unitTests.d.ts.map +1 -1
  93. package/dist/rules/stories/unitTests.js +6 -2
  94. package/dist/rules/stories/unitTests.js.map +1 -1
  95. package/dist/rules/stories/waitOnEvents.d.ts.map +1 -1
  96. package/dist/rules/stories/waitOnEvents.js +13 -70
  97. package/dist/rules/stories/waitOnEvents.js.map +1 -1
  98. package/package.json +15 -15
  99. package/src/adapters/biome/run.ts +6 -2
  100. package/src/adapters/databaseUrlFindings.ts +23 -0
  101. package/src/adapters/databaseUrlReads.ts +119 -0
  102. package/src/adapters/imports/resolve.ts +1 -1
  103. package/src/adapters/knip/report.ts +22 -0
  104. package/src/adapters/knip/run.ts +3 -7
  105. package/src/adapters/outsideImportFindings.ts +15 -34
  106. package/src/adapters/units/runtime.ts +53 -0
  107. package/src/adapters/units/runtimeImports.ts +60 -0
  108. package/src/adapters/units/runtimeOrigins.ts +96 -0
  109. package/src/adapters/units/runtimeUse.ts +72 -0
  110. package/src/cli/lint.ts +1 -1
  111. package/src/imports/extract.ts +16 -2
  112. package/src/inventory/collect.ts +3 -0
  113. package/src/inventory/skillCopies.ts +30 -0
  114. package/src/manifests/sorted.ts +9 -8
  115. package/src/rules/builtIn.ts +4 -0
  116. package/src/rules/effect/adapterImports.ts +1 -1
  117. package/src/rules/files/folderNames.ts +4 -1
  118. package/src/rules/manifestsNoTestKits.ts +73 -0
  119. package/src/rules/stories/adapters/failureDeadline.ts +78 -0
  120. package/src/rules/stories/adapters/realTime.ts +76 -0
  121. package/src/rules/stories/databaseUrl.ts +8 -0
  122. package/src/rules/stories/engineOf.ts +1 -0
  123. package/src/rules/stories/specs.ts +2 -1
  124. package/src/rules/stories/unitTests.ts +10 -2
  125. package/src/rules/stories/waitOnEvents.ts +12 -82
@@ -2,75 +2,14 @@ import { Effect } from "effect";
2
2
  import ts from "typescript";
3
3
  import { isTestSupport } from "#naming/testName.ts";
4
4
  import { defineRule } from "#rule.ts";
5
+ import { failingSleep } from "#rules/stories/adapters/failureDeadline.ts";
6
+ import { realTime } from "#rules/stories/adapters/realTime.ts";
5
7
  import { bindsModule, importBindings } from "./importBindings.js";
6
8
  import { storyWaitSources } from "./sources.js";
7
9
  import { memberName, syntaxFindings, unwrapped } from "./syntax.js";
8
- const MESSAGE = "Waits on time in a story or reachable test-support: a sleep, a timer, polling with eventually or waitFor, fake timers or a clock adjustment in the spec. Settle on the engine's own signal through a kit verb, such as a Deferred the engine completes, story.runUntil or screenDriver's settle(). A deadline bounds a failure but does not prove completion; reaching it must fail the story. When time passing is the behaviour, name it in a kit verb that advances TestClock.";
9
- const TIMERS = new Set(["setInterval", "setTimeout"]);
10
+ const MESSAGE = "Waits on time in a story or reachable test-support: a sleep, a real timer, a wall-clock read such as Date.now(), polling with eventually or waitFor, fake timers or a clock adjustment in the spec. Settle on the engine's own signal through a kit verb, such as a Deferred the engine completes, story.runUntil or screenDriver's settle(). A deadline bounds a failure but does not prove completion; reaching it must fail the story. When time passing is the behaviour, name it in a kit verb that advances TestClock.";
10
11
  const VI_TIMING = /^(?:useFakeTimers|advanceTimers\w*|runAllTimers\w*|runOnlyPendingTimers\w*|runAllTicks|setSystemTime|waitFor|waitUntil)$/u;
11
12
  const CLOCK_CHANGES = new Set(["adjust", "setTime"]);
12
- function terminal(body) {
13
- if (!ts.isBlock(body)) {
14
- return unwrapped(body);
15
- }
16
- const last = body.statements.at(-1);
17
- return last !== undefined && (ts.isReturnStatement(last) || ts.isExpressionStatement(last)) ? last.expression : undefined;
18
- }
19
- function fails(expression, bindings) {
20
- const value = unwrapped(expression);
21
- if (ts.isArrowFunction(value) || ts.isFunctionExpression(value)) {
22
- const result = terminal(value.body);
23
- return result !== undefined && fails(result, bindings);
24
- }
25
- if (!(ts.isCallExpression(value) && ts.isPropertyAccessExpression(value.expression))) {
26
- return false;
27
- }
28
- const receiver = value.expression.expression;
29
- return (ts.isIdentifier(receiver)
30
- && bindsModule(bindings.get(receiver.text), "Effect", ["effect"])
31
- && ["die", "fail"].includes(value.expression.name.text));
32
- }
33
- function failingSleep(call, bindings) {
34
- const access = call.parent;
35
- const pipe = access.parent;
36
- if (!(ts.isPropertyAccessExpression(access) && access.name.text === "pipe" && ts.isCallExpression(pipe) && pipe.arguments.length === 1)) {
37
- return false;
38
- }
39
- const step = pipe.arguments[0];
40
- if (step === undefined || !ts.isCallExpression(step) || memberName(step.expression) !== "andThen") {
41
- return false;
42
- }
43
- const receiver = ts.isPropertyAccessExpression(step.expression) ? step.expression.expression : undefined;
44
- return (receiver !== undefined
45
- && ts.isIdentifier(receiver)
46
- && bindsModule(bindings.get(receiver.text), "Effect", ["effect"])
47
- && step.arguments.length === 1
48
- && step.arguments[0] !== undefined
49
- && fails(step.arguments[0], bindings));
50
- }
51
- function rejectionName(call) {
52
- for (let node = call.parent; node !== undefined; node = node.parent) {
53
- if ((ts.isArrowFunction(node) || ts.isFunctionExpression(node))
54
- && ts.isNewExpression(node.parent)
55
- && ts.isIdentifier(node.parent.expression)
56
- && node.parent.expression.text === "Promise") {
57
- const name = node.parameters[1]?.name;
58
- return name !== undefined && ts.isIdentifier(name) ? name.text : undefined;
59
- }
60
- }
61
- return undefined;
62
- }
63
- function rejectingTimer(call) {
64
- const reject = rejectionName(call);
65
- const callback = call.arguments[0];
66
- if (reject === undefined || callback === undefined) {
67
- return false;
68
- }
69
- const body = ts.isArrowFunction(callback) || ts.isFunctionExpression(callback) ? terminal(callback.body) : callback;
70
- return (body !== undefined
71
- && ((ts.isIdentifier(body) && body.text === reject)
72
- || (ts.isCallExpression(body) && ts.isIdentifier(body.expression) && body.expression.text === reject)));
73
- }
74
13
  function receiverOf(callee) {
75
14
  const receiver = ts.isPropertyAccessExpression(callee) ? unwrapped(callee.expression) : undefined;
76
15
  return receiver !== undefined && ts.isIdentifier(receiver) ? receiver : undefined;
@@ -82,25 +21,28 @@ function vitestTiming(receiver, bindings) {
82
21
  function timedWait(call, bindings, support) {
83
22
  const callee = unwrapped(call.expression);
84
23
  if (ts.isIdentifier(callee)) {
85
- return ((TIMERS.has(callee.text) && !(callee.text === "setTimeout" && rejectingTimer(call))) || bindings.get(callee.text)?.imported === "eventually");
24
+ const binding = bindings.get(callee.text);
25
+ return (binding?.imported === "eventually"
26
+ || (binding?.module === "effect/Effect" && binding.imported === "sleep" && !failingSleep(call, bindings))
27
+ || realTime(call, bindings));
86
28
  }
87
29
  const member = memberName(callee) ?? "";
88
30
  const receiver = receiverOf(callee);
89
31
  if (receiver === undefined) {
90
- return false;
32
+ return realTime(call, bindings);
91
33
  }
92
34
  const binding = bindings.get(receiver.text);
93
- return ((member === "sleep" && bindsModule(binding, "Effect", ["effect"]) && !failingSleep(call, bindings))
35
+ return (realTime(call, bindings)
36
+ || (member === "sleep" && bindsModule(binding, "Effect", ["effect"]) && !failingSleep(call, bindings))
94
37
  || (VI_TIMING.test(member) && vitestTiming(receiver, bindings))
95
- || (!support && CLOCK_CHANGES.has(member) && bindsModule(binding, "TestClock", ["effect/testing"]))
96
- || (TIMERS.has(member) && receiver.text === "globalThis" && !(member === "setTimeout" && rejectingTimer(call))));
38
+ || (!support && CLOCK_CHANGES.has(member) && bindsModule(binding, "TestClock", ["effect/testing"])));
97
39
  }
98
40
  function timedWaits(source) {
99
41
  const bindings = importBindings(source);
100
42
  const support = isTestSupport(source.fileName);
101
43
  const found = [];
102
44
  function visit(node) {
103
- if (ts.isCallExpression(node) && timedWait(node, bindings, support)) {
45
+ if ((ts.isCallExpression(node) && timedWait(node, bindings, support)) || (ts.isNewExpression(node) && realTime(node, bindings))) {
104
46
  found.push(node);
105
47
  }
106
48
  ts.forEachChild(node, visit);
@@ -112,5 +54,6 @@ export const waitOnEvents = defineRule({
112
54
  check: (inputs) => Effect.map(storyWaitSources(inputs), (sources) => sources.flatMap((file) => syntaxFindings(file, timedWaits, MESSAGE))),
113
55
  description: "Stories and reachable test-support settle on the engine's own signals; controlled clock advances belong in kit verbs.",
114
56
  id: "tests/wait-on-events",
57
+ registrable: false,
115
58
  });
116
59
  //# sourceMappingURL=waitOnEvents.js.map
@@ -1 +1 @@
1
- {"version":3,"file":"waitOnEvents.js","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,WAAW,EAAsB,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACtF,OAAO,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEpE,MAAM,OAAO,GACZ,mdAAmd,CAAC;AAErd,MAAM,MAAM,GAAG,IAAI,GAAG,CAAC,CAAC,aAAa,EAAE,YAAY,CAAC,CAAC,CAAC;AACtD,MAAM,SAAS,GAAG,2HAA2H,CAAC;AAC9I,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,QAAQ,CAAC,IAAoB;IACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;QACvB,OAAO,SAAS,CAAC,IAAI,CAAC,CAAC;IACxB,CAAC;IACD,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACpC,OAAO,IAAI,KAAK,SAAS,IAAI,CAAC,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;AAC3H,CAAC;AAED,SAAS,KAAK,CAAC,UAAyB,EAAE,QAA4C;IACrF,MAAM,KAAK,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC;IACpC,IAAI,EAAE,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,KAAK,CAAC,EAAE,CAAC;QACjE,MAAM,MAAM,GAAG,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QACpC,OAAO,MAAM,KAAK,SAAS,IAAI,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC;IACxD,CAAC;IACD,IAAI,CAAC,CAAC,EAAE,CAAC,gBAAgB,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,EAAE,CAAC;QACtF,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,QAAQ,GAAG,KAAK,CAAC,UAAU,CAAC,UAAU,CAAC;IAC7C,OAAO,CACN,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC;WACtB,WAAW,CAAC,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC;WAC9D,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CACvD,CAAC;AACH,CAAC;AAED,SAAS,YAAY,CAAC,IAAuB,EAAE,QAA4C;IAC1F,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;IAC3B,MAAM,IAAI,GAAG,MAAM,CAAC,MAAM,CAAC;IAC3B,IAAI,CAAC,CAAC,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,IAAI,CAAC,IAAI,KAAK,MAAM,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,CAAC,EAAE,CAAC;QACzI,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IAC/B,IAAI,IAAI,KAAK,SAAS,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,SAAS,EAAE,CAAC;QACnG,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;IACzG,OAAO,CACN,QAAQ,KAAK,SAAS;WACnB,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC;WACzB,WAAW,CAAC,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC;WAC9D,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;WAC3B,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,KAAK,SAAS;WAC/B,KAAK,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,QAAQ,CAAC,CACrC,CAAC;AACH,CAAC;AAED,SAAS,aAAa,CAAC,IAAuB;IAC7C,KAAK,IAAI,IAAI,GAAwB,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,SAAS,EAAE,IAAI,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC;QAC1F,IACC,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAC;eACxD,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,MAAM,CAAC;eAC/B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,UAAU,CAAC;eACvC,IAAI,CAAC,MAAM,CAAC,UAAU,CAAC,IAAI,KAAK,SAAS,EAC3C,CAAC;YACF,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC;YACtC,OAAO,IAAI,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;QAC5E,CAAC;IACF,CAAC;IACD,OAAO,SAAS,CAAC;AAClB,CAAC;AAED,SAAS,cAAc,CAAC,IAAuB;IAC9C,MAAM,MAAM,GAAG,aAAa,CAAC,IAAI,CAAC,CAAC;IACnC,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IACnC,IAAI,MAAM,KAAK,SAAS,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QACpD,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC;IACpH,OAAO,CACN,IAAI,KAAK,SAAS;WACf,CAAC,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,KAAK,MAAM,CAAC;eAC/C,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC,CACvG,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,OAAO,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;AACnF,CAAC;AAED,SAAS,YAAY,CAAC,QAAuB,EAAE,QAA4C;IAC1F,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC,CAAC,WAAW,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,QAAQ,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAClH,CAAC;AAED,SAAS,SAAS,CAAC,IAAuB,EAAE,QAA4C,EAAE,OAAgB;IACzG,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,OAAO,CACN,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,QAAQ,KAAK,YAAY,CAC5I,CAAC;IACH,CAAC;IACD,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;IACxC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC;IACpC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QAC5B,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,CACN,CAAC,MAAM,KAAK,OAAO,IAAI,WAAW,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WAChG,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,YAAY,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;WAC5D,CAAC,CAAC,OAAO,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,WAAW,CAAC,OAAO,EAAE,WAAW,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC;WAChG,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,QAAQ,CAAC,IAAI,KAAK,YAAY,IAAI,CAAC,CAAC,MAAM,KAAK,YAAY,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,CAC/G,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;IAC/C,MAAM,KAAK,GAAc,EAAE,CAAC;IAC5B,SAAS,KAAK,CAAC,IAAa;QAC3B,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,EAAE,CAAC;YACrE,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClB,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC9B,CAAC;IACD,KAAK,CAAC,MAAM,CAAC,CAAC;IACd,OAAO,KAAK,CAAC;AACd,CAAC;AAED,MAAM,CAAC,MAAM,YAAY,GAAG,UAAU,CAAC;IACtC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC,CAAC;IAC1I,WAAW,EAAE,uHAAuH;IACpI,EAAE,EAAE,sBAAsB;CAC1B,CAAC,CAAC"}
1
+ {"version":3,"file":"waitOnEvents.js","sourceRoot":"","sources":["../../../src/rules/stories/waitOnEvents.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,YAAY,EAAE,MAAM,4CAA4C,CAAC;AAC1E,OAAO,EAAE,QAAQ,EAAE,MAAM,qCAAqC,CAAC;AAC/D,OAAO,EAAE,WAAW,EAAsB,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACtF,OAAO,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEpE,MAAM,OAAO,GACZ,8fAA8f,CAAC;AAEhgB,MAAM,SAAS,GAAG,2HAA2H,CAAC;AAC9I,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC;AAErD,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAClG,OAAO,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;AACnF,CAAC;AAED,SAAS,YAAY,CAAC,QAAuB,EAAE,QAA4C;IAC1F,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC,CAAC,WAAW,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,QAAQ,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAClH,CAAC;AAED,SAAS,SAAS,CAAC,IAAuB,EAAE,QAA4C,EAAE,OAAgB;IACzG,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC1C,OAAO,CACN,OAAO,EAAE,QAAQ,KAAK,YAAY;eAC/B,CAAC,OAAO,EAAE,MAAM,KAAK,eAAe,IAAI,OAAO,CAAC,QAAQ,KAAK,OAAO,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;eACtG,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAC3B,CAAC;IACH,CAAC;IACD,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;IACxC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC;IACpC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QAC5B,OAAO,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACjC,CAAC;IACD,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5C,OAAO,CACN,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC;WACrB,CAAC,MAAM,KAAK,OAAO,IAAI,WAAW,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;WACnG,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,YAAY,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;WAC5D,CAAC,CAAC,OAAO,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,WAAW,CAAC,OAAO,EAAE,WAAW,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,CACnG,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,MAAqB;IACxC,MAAM,QAAQ,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;IAC/C,MAAM,KAAK,GAAc,EAAE,CAAC;IAC5B,SAAS,KAAK,CAAC,IAAa;QAC3B,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,EAAE,CAAC;YACjI,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClB,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC9B,CAAC;IACD,KAAK,CAAC,MAAM,CAAC,CAAC;IACd,OAAO,KAAK,CAAC;AACd,CAAC;AAED,MAAM,CAAC,MAAM,YAAY,GAAG,UAAU,CAAC;IACtC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,gBAAgB,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC,CAAC;IAC1I,WAAW,EAAE,uHAAuH;IACpI,EAAE,EAAE,sBAAsB;IAC1B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@shivaedev/quality",
3
- "version": "0.62.1",
3
+ "version": "0.65.0",
4
4
  "description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
5
5
  "homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
6
6
  "bugs": {
@@ -50,10 +50,11 @@
50
50
  "README.md"
51
51
  ],
52
52
  "dependencies": {
53
- "@biomejs/biome": "2.6.3",
54
- "@shivaedev/errors": "0.9.1",
55
- "@shivaedev/heavy-lock": "0.10.1",
56
- "@shivaedev/service": "0.7.1",
53
+ "@biomejs/biome": "2.6.4",
54
+ "@shivaedev/errors": "0.10.0",
55
+ "@shivaedev/heavy-lock": "0.11.0",
56
+ "@shivaedev/service": "0.8.0",
57
+ "@shivaedev/skills": "0.8.0",
57
58
  "@vitest/coverage-v8": "5.0.5",
58
59
  "ignore": "7.0.14",
59
60
  "knip": "6.43.0",
@@ -61,21 +62,20 @@
61
62
  "typescript": "npm:@typescript/typescript6@6.0.2"
62
63
  },
63
64
  "devDependencies": {
64
- "@effect/platform-node": "4.0.7",
65
- "@effect/platform-node-shared": "4.0.7",
66
- "@effect/vitest": "4.0.7",
67
- "@shivaedev/test": "0.15.1",
68
- "@shivaedev/test-story": "0.39.2",
65
+ "@effect/platform-node": "4.1.0",
66
+ "@effect/platform-node-shared": "4.1.0",
67
+ "@effect/vitest": "4.1.0",
68
+ "@shivaedev/test-story": "0.42.0",
69
69
  "@types/node": "24.19.2",
70
70
  "@typescript/native": "npm:typescript@7.0.2",
71
- "effect": "4.0.7",
71
+ "effect": "4.1.0",
72
72
  "vitest": "5.0.5"
73
73
  },
74
74
  "peerDependencies": {
75
- "@effect/platform-node": "4.0.7",
76
- "@effect/platform-node-shared": "4.0.7",
77
- "@shivaedev/test-story": "0.39.2",
78
- "effect": "4.0.7",
75
+ "@effect/platform-node": "4.1.0",
76
+ "@effect/platform-node-shared": "4.1.0",
77
+ "@shivaedev/test-story": "0.42.0",
78
+ "effect": "4.1.0",
79
79
  "vitest": "5.0.5"
80
80
  },
81
81
  "peerDependenciesMeta": {
@@ -1,10 +1,13 @@
1
1
  import { createRequire } from "node:module";
2
+ import { relative } from "node:path";
2
3
  import process from "node:process";
3
4
  import { Effect, Stream } from "effect";
4
5
  import { ChildProcess, ChildProcessSpawner } from "effect/process";
5
6
  import { withExceptionConfig } from "#adapters/biome/withExceptionConfig.ts";
6
7
  import type { ExceptionDeclaration } from "#exceptions/declaration.ts";
8
+ import { posix } from "#inventory/ignoreScope.ts";
7
9
  import { shadcnFiles } from "#inventory/shadcnFiles.ts";
10
+ import { skillCopies } from "#inventory/skillCopies.ts";
8
11
 
9
12
  export interface BiomeRun {
10
13
  readonly code: number;
@@ -21,10 +24,11 @@ export const runBiome = Effect.fn("Biome.runBiome")(function* (
21
24
  nonEffectFolders: readonly string[] = [],
22
25
  ) {
23
26
  const files = yield* shadcnFiles(root);
27
+ const copies = (yield* skillCopies(root)).paths.map((file) => posix(relative(root, file)));
24
28
  const toolOwned: readonly ExceptionDeclaration[] = [
25
29
  {
26
- files: ["**", "!**/pnpm-lock.yaml", ...files.map((file) => `!${file}`)],
27
- reason: "pnpm writes its lockfiles; canonical shadcn component filenames in the configured UI folder belong to its CLI.",
30
+ files: ["**", "!**/pnpm-lock.yaml", ...[...files, ...copies].map((file) => `!${file}`)],
31
+ reason: "pnpm, shadcn and the skills tool own their generated files and copies.",
28
32
  rules: ["biome/files/includes"],
29
33
  },
30
34
  ];
@@ -0,0 +1,23 @@
1
+ import { join } from "node:path";
2
+ import { Effect } from "effect";
3
+ import { importGraph } from "#imports/graph.ts";
4
+ import { isTestSupport } from "#naming/testName.ts";
5
+ import type { RuleInputs } from "#rule.ts";
6
+ import { findingAt } from "#rules/stories/syntax.ts";
7
+ import { databaseUrlReads } from "./databaseUrlReads.ts";
8
+ import { storyProgram } from "./storyProgram.ts";
9
+
10
+ const MESSAGE =
11
+ "Reads a *DATABASE_URL variable directly in test-support. Use postgresTestUrl(name) from @shivaedev/test-sql/server/adapters/postgresTestUrl.ts so missing PostgreSQL URLs fail in CI instead of silently skipping tests.";
12
+
13
+ export const databaseUrlFindings = Effect.fn("Stories.databaseUrlFindings")(function* (inputs: RuleInputs) {
14
+ const graph = yield* importGraph(inputs);
15
+ const program = storyProgram(inputs, graph);
16
+ const checker = program.getTypeChecker();
17
+ return inputs.sources
18
+ .filter((file) => isTestSupport(file.path))
19
+ .flatMap((file) => {
20
+ const source = program.getSourceFile(join(inputs.root, file.path));
21
+ return source === undefined ? [] : databaseUrlReads(source, checker).map((node) => ({ ...findingAt(source, node, MESSAGE), file: file.path }));
22
+ });
23
+ });
@@ -0,0 +1,119 @@
1
+ import ts from "typescript";
2
+ import { importFrom } from "#rules/stories/importOrigin.ts";
3
+ import { memberName, nodesWhere, unwrapped } from "#rules/stories/syntax.ts";
4
+
5
+ const READERS = new Set(["String", "NonEmptyString", "Redacted", "URL", "string", "nonEmptyString", "redacted", "url"]);
6
+
7
+ function importedReference(node: ts.Node): readonly string[] | undefined {
8
+ const from = importFrom(node);
9
+ if (from === undefined) {
10
+ return undefined;
11
+ }
12
+ if (ts.isImportSpecifier(node)) {
13
+ return [from, (node.propertyName ?? node.name).text];
14
+ }
15
+ if (ts.isNamespaceImport(node) || (ts.isImportClause(node) && (from === "node:process" || from === "process"))) {
16
+ return [from];
17
+ }
18
+ return undefined;
19
+ }
20
+
21
+ function bindingName(node: ts.BindingElement): string | undefined {
22
+ const name = node.propertyName ?? node.name;
23
+ return ts.isIdentifier(name) || ts.isStringLiteralLike(name) ? name.text : undefined;
24
+ }
25
+
26
+ export function databaseUrlReads(source: ts.SourceFile, checker: ts.TypeChecker): readonly ts.Node[] {
27
+ const visiting = new Set<ts.Node>();
28
+ function declaration(node: ts.Node): readonly string[] | undefined {
29
+ if (ts.isVariableDeclaration(node) && node.initializer !== undefined && (node.parent.flags & ts.NodeFlags.Const) !== 0) {
30
+ return value(node.initializer);
31
+ }
32
+ if (ts.isBindingElement(node) && ts.isObjectBindingPattern(node.parent) && ts.isVariableDeclaration(node.parent.parent)) {
33
+ const base = declaration(node.parent.parent);
34
+ const name = bindingName(node);
35
+ return base !== undefined && name !== undefined ? [...base, name] : undefined;
36
+ }
37
+ return importedReference(node);
38
+ }
39
+ function value(expression: ts.Expression): readonly string[] | undefined {
40
+ const node = unwrapped(expression);
41
+ if (visiting.has(node)) {
42
+ return undefined;
43
+ }
44
+ visiting.add(node);
45
+ const result = reference(node);
46
+ visiting.delete(node);
47
+ return result;
48
+ }
49
+ function reference(node: ts.Expression): readonly string[] | undefined {
50
+ if (ts.isStringLiteralLike(node)) {
51
+ return [node.text];
52
+ }
53
+ if (ts.isIdentifier(node)) {
54
+ const symbol = checker.getSymbolAtLocation(node);
55
+ return (
56
+ symbol?.declarations?.map(declaration).find((item) => item !== undefined)
57
+ ?? (symbol === undefined && node.text === "process" ? ["process"] : undefined)
58
+ );
59
+ }
60
+ if (ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) {
61
+ return access(node);
62
+ }
63
+ return undefined;
64
+ }
65
+ function access(node: ts.PropertyAccessExpression | ts.ElementAccessExpression): readonly string[] | undefined {
66
+ const base = value(node.expression);
67
+ const name = memberName(node) ?? (ts.isElementAccessExpression(node) ? value(node.argumentExpression)?.[0] : undefined);
68
+ return base !== undefined && name !== undefined ? [...base, name] : undefined;
69
+ }
70
+ function environment(path: readonly string[] | undefined): boolean {
71
+ return path?.length === 2 && (path[0] === "process" || path[0] === "node:process") && path[1] === "env";
72
+ }
73
+ function databaseName(path: readonly string[] | undefined): boolean {
74
+ return path?.length === 1 && path[0]?.endsWith("DATABASE_URL") === true;
75
+ }
76
+ function environmentBinding(node: ts.BindingElement): boolean {
77
+ if (node.dotDotDotToken !== undefined || !ts.isObjectBindingPattern(node.parent)) {
78
+ return false;
79
+ }
80
+ const parent = node.parent.parent;
81
+ return (
82
+ ts.isVariableDeclaration(parent)
83
+ && parent.initializer !== undefined
84
+ && environment(value(parent.initializer))
85
+ && bindingName(node)?.endsWith("DATABASE_URL") === true
86
+ );
87
+ }
88
+ function read(node: ts.Node): boolean {
89
+ if (ts.isCallExpression(node)) {
90
+ const path = value(node.expression);
91
+ const method = path?.at(-1) ?? "";
92
+ const argument = node.arguments[method === "schema" ? 1 : 0];
93
+ return (
94
+ path !== undefined
95
+ && (READERS.has(method) || method === "schema")
96
+ && path.slice(0, -1).join("/") === "effect/Config"
97
+ && argument !== undefined
98
+ && databaseName(value(argument))
99
+ );
100
+ }
101
+ if (ts.isBindingElement(node)) {
102
+ return environmentBinding(node);
103
+ }
104
+ if (!(ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node))) {
105
+ return false;
106
+ }
107
+ const path = value(node);
108
+ return environment(path?.slice(0, -1)) && databaseName(path?.slice(-1)) && !write(node);
109
+ }
110
+ return nodesWhere(source, read);
111
+ }
112
+
113
+ function write(node: ts.Expression): boolean {
114
+ const parent = node.parent;
115
+ return (
116
+ ts.isDeleteExpression(parent)
117
+ || (ts.isBinaryExpression(parent) && parent.left === node && parent.operatorToken.kind === ts.SyntaxKind.EqualsToken)
118
+ );
119
+ }
@@ -14,7 +14,7 @@ const ASSET_DECLARATION = /\.d(?<extension>\.[^./]+)\.ts$/u;
14
14
 
15
15
  const DECLARATION = /\.d\.[cm]?ts$/u;
16
16
 
17
- const QUERY = /\?.*$/u;
17
+ const QUERY = /(?<=\.wasm)\?init$|\?(?:(?:shared)?worker(?:&(?:inline|url))?|raw|url(?:&(?:no-)?inline)?|(?:no-)?inline)$/u;
18
18
 
19
19
  const PACKAGE_IMPORT = "#";
20
20
 
@@ -0,0 +1,22 @@
1
+ import type { Findings } from "#rule.ts";
2
+ import { knipFindings } from "./findings.ts";
3
+
4
+ export function knipReport(stdout: string, stderr: string, code: number): Findings {
5
+ let report: Findings;
6
+ let failure: string;
7
+ try {
8
+ report = knipFindings(stdout);
9
+ if (code === (report.length > 0 ? 1 : 0)) {
10
+ return report;
11
+ }
12
+ failure = `knip exited ${code} inconsistently with its report:\n${stderr || stdout}`;
13
+ } catch {
14
+ failure = `knip exited ${code} without a valid report:\n${stderr || stdout || "No output."}`;
15
+ }
16
+ return [
17
+ {
18
+ file: "package.json",
19
+ message: `Unused-code analysis did not complete. Repair the tool configuration or command failure and rerun quality lint. ${failure}`,
20
+ },
21
+ ];
22
+ }
@@ -9,7 +9,8 @@ import { shadcnFolders } from "#inventory/shadcnFolders.ts";
9
9
  import type { RuleInputs } from "#rule.ts";
10
10
  import { knipConfiguration } from "./configuration.ts";
11
11
  import { entryPointFindings } from "./entryPointFindings.ts";
12
- import { KNIP_ISSUES, knipFindings } from "./findings.ts";
12
+ import { KNIP_ISSUES } from "./findings.ts";
13
+ import { knipReport } from "./report.ts";
13
14
  import { sourceConfig } from "./sourceConfig.ts";
14
15
 
15
16
  const API = createRequire(import.meta.url).resolve("knip");
@@ -65,12 +66,7 @@ export const runKnip = Effect.fn("Knip.runKnip")(function* (inputs: RuleInputs)
65
66
  [Stream.mkString(Stream.decodeText(child.stdout)), Stream.mkString(Stream.decodeText(child.stderr)), child.exitCode],
66
67
  { concurrency: "unbounded" },
67
68
  );
68
- const report = yield* Effect.try(() => knipFindings(stdout)).pipe(
69
- Effect.mapError(() => new Error(`knip exited ${code} without a valid report:\n${stderr || stdout || "No output."}`)),
70
- );
71
- if (Number(code) !== (report.length > 0 ? 1 : 0)) {
72
- return yield* Effect.fail(new Error(`knip exited ${code} inconsistently with its report:\n${stderr || stdout}`));
73
- }
69
+ const report = knipReport(stdout, stderr, Number(code));
74
70
  return report.filter((finding) => checked.has(finding.file));
75
71
  }),
76
72
  );
@@ -1,50 +1,33 @@
1
1
  import { Effect } from "effect";
2
- import ts from "typescript";
3
2
  import type { ImportAnalysisFailure } from "#adapters/ImportAnalysisFailure.ts";
4
3
  import { readPackageManifest } from "#adapters/manifestInventory.ts";
5
4
  import { importGraph } from "#imports/graph.ts";
6
5
  import { packageNameOf } from "#imports/packageName.ts";
7
6
  import { packageOf } from "#imports/workspace.ts";
7
+ import { testName } from "#naming/testName.ts";
8
8
  import type { Finding, RuleInputs } from "#rule.ts";
9
- import { parse } from "#rules/parse.ts";
10
9
 
11
- function onlyInlineTypes(statement: ts.Statement): boolean {
12
- if (ts.isImportDeclaration(statement)) {
13
- const clause = statement.importClause;
14
- const bindings = clause?.namedBindings;
15
- return (
16
- clause?.name === undefined
17
- && bindings !== undefined
18
- && ts.isNamedImports(bindings)
19
- && bindings.elements.length > 0
20
- && bindings.elements.every((item) => item.isTypeOnly)
21
- );
22
- }
23
- const exports = ts.isExportDeclaration(statement) ? statement.exportClause : undefined;
24
- return exports !== undefined && ts.isNamedExports(exports) && exports.elements.length > 0 && exports.elements.every((item) => item.isTypeOnly);
25
- }
26
-
27
- function inlineTypes(inputs: RuleInputs): ReadonlySet<string> {
28
- const sites = new Set<string>();
29
- for (const file of inputs.sources) {
30
- const source = parse(file);
31
- if (source === undefined) {
32
- continue;
33
- }
34
- for (const statement of source.statements.filter(onlyInlineTypes)) {
35
- sites.add(`${file.path}:${source.getLineAndCharacterOfPosition(statement.getStart(source)).line + 1}`);
36
- }
37
- }
38
- return sites;
39
- }
10
+ const CLIENT_RENDERING_LIBRARIES = new Set([
11
+ "react",
12
+ "react-dom",
13
+ "lucide-react",
14
+ "@base-ui/react",
15
+ "@tanstack/react-router",
16
+ "@tanstack/react-table",
17
+ "class-variance-authority",
18
+ "cn",
19
+ "clsx",
20
+ "tailwind-merge",
21
+ ]);
40
22
 
41
23
  function exempt(path: string, name: string): boolean {
42
24
  return (
43
25
  /(?:^|\/)(?:adapters|test-support)\//u.test(path)
26
+ || (name === "vitest" && testName(path)?.modifiers.includes("unit") === true)
44
27
  || name === "effect"
45
28
  || name.startsWith("@effect/")
46
29
  || name.startsWith("@shivaedev/")
47
- || ((name === "react" || name === "react-dom") && /(?:^|\/)client\//u.test(path))
30
+ || (CLIENT_RENDERING_LIBRARIES.has(name) && /(?:^|\/)client\//u.test(path))
48
31
  );
49
32
  }
50
33
 
@@ -67,7 +50,6 @@ export const outsideImportFindings = Effect.fn("Imports.outsideImportFindings")(
67
50
  { concurrency: "unbounded" },
68
51
  ),
69
52
  );
70
- const types = inlineTypes(inputs);
71
53
  const workspace = new Set(graph.packages.map((owner) => owner.name));
72
54
  const sites = [
73
55
  ...graph.edges.flatMap((edge) => (edge.to.kind === "external" ? [{ ...edge, name: edge.to.package }] : [])),
@@ -81,7 +63,6 @@ export const outsideImportFindings = Effect.fn("Imports.outsideImportFindings")(
81
63
  workspace.has(site.name)
82
64
  || site.type
83
65
  || site.kind !== "import"
84
- || types.has(`${site.from}:${site.line}`)
85
66
  || exempt(site.from, site.name)
86
67
  || !(site.name.startsWith("node:") || runtime.get(directory)?.has(site.name))
87
68
  ) {
@@ -0,0 +1,53 @@
1
+ import type ts from "typescript";
2
+ import { type Trail, walkFrom } from "#imports/fences/reach.ts";
3
+ import type { ImportEdge } from "#imports/graph.ts";
4
+ import type { Finding } from "#rule.ts";
5
+ import { runtimeOrigins } from "./runtimeOrigins.ts";
6
+ import { firstRuntimeUse, type RuntimeUse } from "./runtimeUse.ts";
7
+
8
+ export const PURE_REPAIR = "Exercise the Effect behaviour through the package story kit, or test an existing pure API without the runner.";
9
+
10
+ export function runtime(checker: ts.TypeChecker, source: (path: string) => ts.SourceFile | undefined) {
11
+ const origin = runtimeOrigins(checker);
12
+ const known = new Map<string, RuntimeUse | undefined>();
13
+
14
+ function runtimeUse(module: string): RuntimeUse | undefined {
15
+ if (known.has(module)) {
16
+ return known.get(module);
17
+ }
18
+ const syntax = source(module);
19
+ const first = syntax === undefined ? undefined : firstRuntimeUse(syntax, origin);
20
+ known.set(module, first);
21
+ return first;
22
+ }
23
+
24
+ function findings(file: string, visited: ReadonlyMap<string, Trail>): readonly Finding[] {
25
+ const found: Finding[] = [];
26
+ for (const [module, trail] of visited) {
27
+ const use = runtimeUse(module);
28
+ if (use === undefined) {
29
+ continue;
30
+ }
31
+ const chain = [...trail.path.slice(1, -1), `${module}:${use.line}`].join(" -> ");
32
+ found.push({
33
+ file,
34
+ line: module === file ? use.line : trail.line,
35
+ message: `This \`.unit\` test reaches \`${use.what}\` through \`${chain}\`. ${PURE_REPAIR}`,
36
+ });
37
+ }
38
+ return found;
39
+ }
40
+
41
+ return (file: string, edgesFrom: ReadonlyMap<string, readonly ImportEdge[]>): Finding | undefined => {
42
+ const own = findings(file, new Map([[file, { line: 0, path: [file] }]]));
43
+ const imported = (edgesFrom.get(file) ?? []).flatMap((edge) => {
44
+ if (edge.to.kind !== "file") {
45
+ return [];
46
+ }
47
+ const visited = walkFrom(edge.to.path, edgesFrom, () => undefined).visited;
48
+ const trails = new Map([...visited].map(([module, trail]) => [module, { line: edge.line, path: [file, ...trail.path] }]));
49
+ return findings(file, trails);
50
+ });
51
+ return [...own, ...imported].sort((a, b) => (a.line ?? 0) - (b.line ?? 0))[0];
52
+ };
53
+ }
@@ -0,0 +1,60 @@
1
+ import ts from "typescript";
2
+ import { importFrom } from "#rules/stories/importOrigin.ts";
3
+
4
+ export interface RuntimeName {
5
+ readonly module: string;
6
+ readonly path: readonly string[];
7
+ }
8
+
9
+ export function runtimeImport(module: string | undefined, path: readonly string[]): RuntimeName | undefined {
10
+ if (module === undefined || !(module === "effect" || module.startsWith("effect/") || module === "@effect/vitest")) {
11
+ return undefined;
12
+ }
13
+ const subpath = /^effect\/(?:testing\/)?(?<name>Effect|Clock|TestClock)$/u.exec(module)?.groups?.name;
14
+ return subpath === undefined ? { module: module === "effect/testing" ? "effect" : module, path } : { module: "effect", path: [subpath, ...path] };
15
+ }
16
+
17
+ function assignedRuntime(node: ts.ImportEqualsDeclaration): RuntimeName | undefined {
18
+ if (node.isTypeOnly || !ts.isExternalModuleReference(node.moduleReference)) {
19
+ return undefined;
20
+ }
21
+ const module = node.moduleReference.expression;
22
+ return module !== undefined && ts.isStringLiteralLike(module) ? runtimeImport(module.text, []) : undefined;
23
+ }
24
+
25
+ export function importedRuntime(node: ts.Node): RuntimeName | undefined {
26
+ if (ts.isImportSpecifier(node)) {
27
+ return node.isTypeOnly || node.parent.parent.isTypeOnly ? undefined : runtimeImport(importFrom(node), [(node.propertyName ?? node.name).text]);
28
+ }
29
+ if (ts.isNamespaceImport(node)) {
30
+ return node.parent.isTypeOnly ? undefined : runtimeImport(importFrom(node), []);
31
+ }
32
+ return ts.isImportEqualsDeclaration(node) ? assignedRuntime(node) : undefined;
33
+ }
34
+
35
+ export function exportedRuntime(node: ts.ExportSpecifier | ts.NamespaceExport): RuntimeName | undefined {
36
+ const statement = ts.isExportSpecifier(node) ? node.parent.parent : node.parent;
37
+ if (statement.isTypeOnly || (ts.isExportSpecifier(node) && node.isTypeOnly)) {
38
+ return undefined;
39
+ }
40
+ const module = statement.moduleSpecifier;
41
+ return module !== undefined && ts.isStringLiteral(module)
42
+ ? runtimeImport(module.text, ts.isExportSpecifier(node) ? [(node.propertyName ?? node.name).text] : [])
43
+ : undefined;
44
+ }
45
+
46
+ export function runtimeOf(name: RuntimeName | undefined): string | undefined {
47
+ if (name?.module === "effect") {
48
+ const [head, property] = name.path;
49
+ if (head === "Clock" || head === "TestClock") {
50
+ return name.path.join(".");
51
+ }
52
+ return head === "Effect" && property?.startsWith("run") === true ? `Effect.${property}` : undefined;
53
+ }
54
+ const [head, property] = name?.path ?? [];
55
+ return name?.module === "@effect/vitest"
56
+ && (head === "it" || head === "test")
57
+ && ["effect", "live", "scoped", "scopedLive"].includes(property ?? "")
58
+ ? `${head}.${property}`
59
+ : undefined;
60
+ }