@shivaedev/quality 0.57.1 → 0.59.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +34 -0
- package/README.md +19 -6
- package/dist/adapters/ImportAnalysisFailure.d.ts +10 -0
- package/dist/adapters/ImportAnalysisFailure.d.ts.map +1 -0
- package/dist/adapters/ImportAnalysisFailure.js +4 -0
- package/dist/adapters/ImportAnalysisFailure.js.map +1 -0
- package/dist/adapters/ImportCompiler.d.ts +2 -13
- package/dist/adapters/ImportCompiler.d.ts.map +1 -1
- package/dist/adapters/ImportCompiler.js +7 -13
- package/dist/adapters/ImportCompiler.js.map +1 -1
- package/dist/adapters/bodyReferences.d.ts +10 -0
- package/dist/adapters/bodyReferences.d.ts.map +1 -0
- package/dist/adapters/bodyReferences.js +125 -0
- package/dist/adapters/bodyReferences.js.map +1 -0
- package/dist/adapters/engineEscapes.d.ts +10 -0
- package/dist/adapters/engineEscapes.d.ts.map +1 -0
- package/dist/adapters/engineEscapes.js +103 -0
- package/dist/adapters/engineEscapes.js.map +1 -0
- package/dist/adapters/imports/analysisFailure.d.ts +3 -0
- package/dist/adapters/imports/analysisFailure.d.ts.map +1 -0
- package/dist/adapters/imports/analysisFailure.js +5 -0
- package/dist/adapters/imports/analysisFailure.js.map +1 -0
- package/dist/adapters/imports/analyzeDepartures.d.ts +5 -0
- package/dist/adapters/imports/analyzeDepartures.d.ts.map +1 -0
- package/dist/adapters/imports/analyzeDepartures.js +5 -0
- package/dist/adapters/imports/analyzeDepartures.js.map +1 -0
- package/dist/adapters/imports/analyzeGraph.d.ts +4 -0
- package/dist/adapters/imports/analyzeGraph.d.ts.map +1 -0
- package/dist/adapters/imports/analyzeGraph.js +6 -0
- package/dist/adapters/imports/analyzeGraph.js.map +1 -0
- package/dist/adapters/imports/checkBrowser.d.ts +4 -0
- package/dist/adapters/imports/checkBrowser.d.ts.map +1 -0
- package/dist/adapters/imports/checkBrowser.js +4 -0
- package/dist/adapters/imports/checkBrowser.js.map +1 -0
- package/dist/adapters/indirectServiceReferences.d.ts +3 -0
- package/dist/adapters/indirectServiceReferences.d.ts.map +1 -0
- package/dist/adapters/indirectServiceReferences.js +19 -0
- package/dist/adapters/indirectServiceReferences.js.map +1 -0
- package/dist/adapters/knip/entryPointFindings.d.ts +1 -1
- package/dist/adapters/knip/entryPointFindings.d.ts.map +1 -1
- package/dist/adapters/nativeTransactionFindings.d.ts +4 -0
- package/dist/adapters/nativeTransactionFindings.d.ts.map +1 -0
- package/dist/adapters/nativeTransactionFindings.js +98 -0
- package/dist/adapters/nativeTransactionFindings.js.map +1 -0
- package/dist/adapters/outcomeAssertions.d.ts +9 -0
- package/dist/adapters/outcomeAssertions.d.ts.map +1 -0
- package/dist/adapters/outcomeAssertions.js +94 -0
- package/dist/adapters/outcomeAssertions.js.map +1 -0
- package/dist/adapters/outsideImportFindings.d.ts +1 -1
- package/dist/adapters/outsideImportFindings.d.ts.map +1 -1
- package/dist/adapters/positiveRefusalFindings.d.ts +4 -0
- package/dist/adapters/positiveRefusalFindings.d.ts.map +1 -0
- package/dist/adapters/positiveRefusalFindings.js +41 -0
- package/dist/adapters/positiveRefusalFindings.js.map +1 -0
- package/dist/adapters/queueReadoutFindings.d.ts +1 -1
- package/dist/adapters/queueReadoutFindings.d.ts.map +1 -1
- package/dist/adapters/rpcBoundaryFindings.d.ts +4 -0
- package/dist/adapters/rpcBoundaryFindings.d.ts.map +1 -0
- package/dist/adapters/rpcBoundaryFindings.js +90 -0
- package/dist/adapters/rpcBoundaryFindings.js.map +1 -0
- package/dist/adapters/serviceAccess.d.ts +4 -0
- package/dist/adapters/serviceAccess.d.ts.map +1 -0
- package/dist/adapters/serviceAccess.js +33 -0
- package/dist/adapters/serviceAccess.js.map +1 -0
- package/dist/adapters/serviceAssemblyImports.d.ts +10 -0
- package/dist/adapters/serviceAssemblyImports.d.ts.map +1 -0
- package/dist/adapters/serviceAssemblyImports.js +71 -0
- package/dist/adapters/serviceAssemblyImports.js.map +1 -0
- package/dist/adapters/serviceAssemblySyntax.d.ts +10 -0
- package/dist/adapters/serviceAssemblySyntax.d.ts.map +1 -0
- package/dist/adapters/serviceAssemblySyntax.js +105 -0
- package/dist/adapters/serviceAssemblySyntax.js.map +1 -0
- package/dist/adapters/serviceDefinitionProblems.d.ts +7 -0
- package/dist/adapters/serviceDefinitionProblems.d.ts.map +1 -0
- package/dist/adapters/serviceDefinitionProblems.js +43 -0
- package/dist/adapters/serviceDefinitionProblems.js.map +1 -0
- package/dist/adapters/serviceIdFindings.d.ts.map +1 -1
- package/dist/adapters/serviceIdFindings.js +12 -7
- package/dist/adapters/serviceIdFindings.js.map +1 -1
- package/dist/adapters/transactionChanges.d.ts +3 -0
- package/dist/adapters/transactionChanges.d.ts.map +1 -0
- package/dist/adapters/transactionChanges.js +81 -0
- package/dist/adapters/transactionChanges.js.map +1 -0
- package/dist/adapters/vitePort.d.ts +2 -0
- package/dist/adapters/vitePort.d.ts.map +1 -0
- package/dist/adapters/vitePort.js +5 -0
- package/dist/adapters/vitePort.js.map +1 -0
- package/dist/appViteConfig.d.ts +4 -1
- package/dist/appViteConfig.d.ts.map +1 -1
- package/dist/appViteConfig.js +7 -3
- package/dist/appViteConfig.js.map +1 -1
- package/dist/imports/departures.d.ts +1 -1
- package/dist/imports/departures.d.ts.map +1 -1
- package/dist/imports/fences/check.d.ts +1 -1
- package/dist/imports/fences/check.d.ts.map +1 -1
- package/dist/imports/graph.d.ts +1 -1
- package/dist/imports/graph.d.ts.map +1 -1
- package/dist/rules/builtIn.d.ts +2 -2
- package/dist/rules/builtIn.d.ts.map +1 -1
- package/dist/rules/builtIn.js +8 -0
- package/dist/rules/builtIn.js.map +1 -1
- package/dist/rules/effect/rpcBoundary.d.ts +2 -0
- package/dist/rules/effect/rpcBoundary.d.ts.map +1 -0
- package/dist/rules/effect/rpcBoundary.js +9 -0
- package/dist/rules/effect/rpcBoundary.js.map +1 -0
- package/dist/rules/effect/serviceCatalog.d.ts +1 -1
- package/dist/rules/effect/serviceCatalog.d.ts.map +1 -1
- package/dist/rules/effect/serviceCatalog.js +4 -2
- package/dist/rules/effect/serviceCatalog.js.map +1 -1
- package/dist/rules/effect/serviceDefinitionAssembly.d.ts +2 -0
- package/dist/rules/effect/serviceDefinitionAssembly.d.ts.map +1 -0
- package/dist/rules/effect/serviceDefinitionAssembly.js +43 -0
- package/dist/rules/effect/serviceDefinitionAssembly.js.map +1 -0
- package/dist/rules/effect/serviceIds.js +1 -1
- package/dist/rules/effect/serviceIds.js.map +1 -1
- package/dist/rules/effect/serviceParameters.d.ts.map +1 -1
- package/dist/rules/effect/serviceParameters.js +12 -6
- package/dist/rules/effect/serviceParameters.js.map +1 -1
- package/dist/rules/effect/sqlTransact.d.ts +2 -0
- package/dist/rules/effect/sqlTransact.d.ts.map +1 -0
- package/dist/rules/effect/sqlTransact.js +9 -0
- package/dist/rules/effect/sqlTransact.js.map +1 -0
- package/dist/rules/stories/engine.d.ts.map +1 -1
- package/dist/rules/stories/engine.js +24 -7
- package/dist/rules/stories/engine.js.map +1 -1
- package/dist/rules/stories/positiveRefusals.d.ts +2 -0
- package/dist/rules/stories/positiveRefusals.d.ts.map +1 -0
- package/dist/rules/stories/positiveRefusals.js +17 -0
- package/dist/rules/stories/positiveRefusals.js.map +1 -0
- package/dist/rules/stories/sources.d.ts +1 -1
- package/dist/rules/stories/sources.d.ts.map +1 -1
- package/dist/rules/stories/usesInputs.d.ts.map +1 -1
- package/dist/rules/stories/usesInputs.js +3 -2
- package/dist/rules/stories/usesInputs.js.map +1 -1
- package/dist/testing/adapters/cli.d.ts +2 -2
- package/dist/testing/adapters/cli.d.ts.map +1 -1
- package/dist/testing/adapters/cli.js +11 -14
- package/dist/testing/adapters/cli.js.map +1 -1
- package/dist/testing/adapters/git.d.ts +10 -0
- package/dist/testing/adapters/git.d.ts.map +1 -1
- package/dist/testing/adapters/git.js +6 -2
- package/dist/testing/adapters/git.js.map +1 -1
- package/dist/testing/adapters/hookRepository.d.ts.map +1 -1
- package/dist/testing/adapters/hookRepository.js +6 -2
- package/dist/testing/adapters/hookRepository.js.map +1 -1
- package/dist/testing/ruleStory.d.ts.map +1 -1
- package/dist/testing/ruleStory.js +1 -2
- package/dist/testing/ruleStory.js.map +1 -1
- package/package.json +6 -6
- package/src/adapters/ImportAnalysisFailure.ts +6 -0
- package/src/adapters/ImportCompiler.ts +7 -20
- package/src/adapters/bodyReferences.ts +141 -0
- package/src/adapters/engineEscapes.ts +119 -0
- package/src/adapters/imports/analysisFailure.ts +5 -0
- package/src/adapters/imports/analyzeDepartures.ts +9 -0
- package/src/adapters/imports/analyzeGraph.ts +9 -0
- package/src/adapters/imports/checkBrowser.ts +5 -0
- package/src/adapters/indirectServiceReferences.ts +25 -0
- package/src/adapters/nativeTransactionFindings.ts +108 -0
- package/src/adapters/outcomeAssertions.ts +110 -0
- package/src/adapters/outsideImportFindings.ts +1 -1
- package/src/adapters/positiveRefusalFindings.ts +52 -0
- package/src/adapters/rpcBoundaryFindings.ts +98 -0
- package/src/adapters/serviceAccess.ts +38 -0
- package/src/adapters/serviceAssemblyImports.ts +93 -0
- package/src/adapters/serviceAssemblySyntax.ts +129 -0
- package/src/adapters/serviceDefinitionProblems.ts +63 -0
- package/src/adapters/serviceIdFindings.ts +16 -13
- package/src/adapters/transactionChanges.ts +85 -0
- package/src/adapters/vitePort.ts +5 -0
- package/src/appViteConfig.ts +13 -3
- package/src/rules/builtIn.ts +8 -0
- package/src/rules/effect/rpcBoundary.ts +10 -0
- package/src/rules/effect/serviceCatalog.ts +4 -2
- package/src/rules/effect/serviceDefinitionAssembly.ts +46 -0
- package/src/rules/effect/serviceIds.ts +1 -1
- package/src/rules/effect/serviceParameters.ts +12 -6
- package/src/rules/effect/sqlTransact.ts +10 -0
- package/src/rules/stories/engine.ts +25 -9
- package/src/rules/stories/positiveRefusals.ts +17 -0
- package/src/rules/stories/usesInputs.ts +3 -2
- package/src/testing/adapters/cli.ts +22 -14
- package/src/testing/adapters/git.ts +7 -2
- package/src/testing/adapters/hookRepository.ts +6 -2
- package/src/testing/ruleStory.ts +1 -2
|
@@ -4,7 +4,7 @@ import { dirname, join } from "node:path";
|
|
|
4
4
|
import sortPackageJson from "sort-package-json";
|
|
5
5
|
import { shellWords } from "#hooks/command.ts";
|
|
6
6
|
import { qualityArgs } from "./cli.js";
|
|
7
|
-
import { commitAll, git,
|
|
7
|
+
import { commitAll, git, isolatedEnvironment } from "./git.js";
|
|
8
8
|
import { formatTree } from "./qualityTree.js";
|
|
9
9
|
import { DEFAULT_FILES, linkPackage, seedTree } from "./tree.js";
|
|
10
10
|
const CHECKS_LOG = "checks.log";
|
|
@@ -84,7 +84,11 @@ export function withWorktree(repository, name, at) {
|
|
|
84
84
|
return root;
|
|
85
85
|
}
|
|
86
86
|
export function commits(cwd, message) {
|
|
87
|
-
const result = spawnSync("git", ["commit", "--quiet", "--allow-empty", "--message", message], {
|
|
87
|
+
const result = spawnSync("git", ["commit", "--quiet", "--allow-empty", "--message", message], {
|
|
88
|
+
cwd,
|
|
89
|
+
encoding: "utf8",
|
|
90
|
+
env: isolatedEnvironment(cwd),
|
|
91
|
+
});
|
|
88
92
|
return { status: result.status, stderr: result.stderr, stdout: result.stdout };
|
|
89
93
|
}
|
|
90
94
|
export function hookText(repository) {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"hookRepository.js","sourceRoot":"","sources":["../../../src/testing/adapters/hookRepository.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAC/C,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,SAAS,EAAE,YAAY,EAAE,QAAQ,EAAE,aAAa,EAAE,MAAM,SAAS,CAAC;AAClG,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,eAAe,MAAM,mBAAmB,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAC/C,OAAO,EAAE,WAAW,EAAY,MAAM,UAAU,CAAC;AACjD,OAAO,EAAE,SAAS,EAAE,GAAG,EAAE,
|
|
1
|
+
{"version":3,"file":"hookRepository.js","sourceRoot":"","sources":["../../../src/testing/adapters/hookRepository.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAC/C,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,SAAS,EAAE,YAAY,EAAE,QAAQ,EAAE,aAAa,EAAE,MAAM,SAAS,CAAC;AAClG,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,eAAe,MAAM,mBAAmB,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAC/C,OAAO,EAAE,WAAW,EAAY,MAAM,UAAU,CAAC;AACjD,OAAO,EAAE,SAAS,EAAE,GAAG,EAAE,mBAAmB,EAAE,MAAM,UAAU,CAAC;AAC/D,OAAO,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAC;AAC9C,OAAO,EAAE,aAAa,EAAE,WAAW,EAAiB,QAAQ,EAAE,MAAM,WAAW,CAAC;AAehF,MAAM,UAAU,GAAG,YAAY,CAAC;AAEhC,MAAM,cAAc,GAAG;IACtB,QAAQ,EAAE,MAAM,CAAC,WAAW,CAAC;QAC5B,CAAC,QAAQ,EAAE,YAAY,CAAC;QACxB,CAAC,OAAO,EAAE,eAAe,CAAC;QAC1B,CAAC,SAAS,EAAE,aAAa,CAAC;KAC1B,CAAC;CACF,CAAC;AAEF,sHAAsH;AACtH,MAAM,UAAU,IAAI,CAAC,IAAY;IAChC,OAAO,QAAQ,IAAI,OAAO,UAAU,EAAE,CAAC;AACxC,CAAC;AAED,MAAM,UAAU,SAAS,CAAC,IAAY;IACrC,OAAO,UAAU,CAAC,IAAI,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,UAAU,CAAC,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;AAC/F,CAAC;AAED,MAAM,KAAK,GAAa,EAAE,OAAO,EAAE,oDAAoD,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;AAE/G,MAAM,GAAG,GAAG,wBAAwB,UAAU,CAAC,WAAW,CAAC,EAAE,CAAC,CAAC,SAAS,CAAC;AAEzE,MAAM,MAAM,GAAa;IACxB,OAAO,EAAE,sGAAsG;IAC/G,IAAI,EAAE,mBAAmB;CACzB,CAAC;AAEF,MAAM,UAAU,MAAM,CAAC,IAAY,EAAE,IAAY,EAAE,OAAe;IACjE,SAAS,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC1D,aAAa,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,OAAO,CAAC,CAAC;AAC1C,CAAC;AAED,SAAS,QAAQ,CAAC,MAAyC;IAC1D,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,eAAe,CAAC,EAAE,OAAO,EAAE,cAAc,EAAE,IAAI,EAAE,QAAQ,EAAE,GAAG,MAAM,EAAE,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC;AACnH,CAAC;AAED,SAAS,OAAO,CAAC,IAAY;IAC5B,MAAM,CAAC,IAAI,EAAE,2BAA2B,EAAE,GAAG,CAAC,CAAC;IAC/C,SAAS,CAAC,IAAI,CAAC,IAAI,EAAE,2BAA2B,CAAC,EAAE,KAAK,CAAC,CAAC;AAC3D,CAAC;AAED,2FAA2F;AAC3F,MAAM,UAAU,cAAc,CAAC,EAC9B,UAAU,GAAG,KAAK,EAClB,KAAK,GAAG,UAAU,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,EAC5C,MAAM,GAAG,EAAE,EACX,OAAO,GAAG,EAAE,GACZ,GAAc,EAAE;IAChB,MAAM,IAAI,GAAG,QAAQ,CACpB;QACC,GAAG,CAAC,UAAU;YACb,CAAC,CAAC,EAAE;YACJ,CAAC,CAAC;gBACA,MAAM;gBACN,EAAE,OAAO,EAAE,iBAAiB,EAAE,IAAI,EAAE,YAAY,EAAE;gBAClD,EAAE,OAAO,EAAE,2DAA2D,EAAE,IAAI,EAAE,YAAY,EAAE;aAC5F,CAAC;QACJ,EAAE,OAAO,EAAE,mBAAmB,EAAE,IAAI,EAAE,QAAQ,EAAE;QAChD,EAAE,OAAO,EAAE,QAAQ,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE;QACxD,GAAG,KAAK;KACR,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;QAChB,GAAG,IAAI;QACP,IAAI,EAAE,IAAI,CAAC,MAAM,EAAE,IAAI,CAAC,IAAI,CAAC;KAC7B,CAAC,CAAC,EACH,CAAC,EAAE,OAAO,EAAE,iBAAiB,EAAE,IAAI,EAAE,YAAY,EAAE,CAAC,CACpD,CAAC;IACF,OAAO,CAAC,IAAI,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC;IAC5B,WAAW,CAAC,IAAI,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC;IAChC,UAAU,CAAC,IAAI,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC;IAC/B,GAAG,CAAC,IAAI,EAAE,MAAM,EAAE,SAAS,CAAC,CAAC;IAC7B,SAAS,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;IACxB,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,YAAY,CAAC,EAAE,IAAI,EAAE,CAAC;AAC1E,CAAC;AAED,MAAM,UAAU,WAAW,CAAC,IAAY,EAAE,OAAyC,EAAE,cAAuB;IAC3G,MAAM,CAAC,IAAI,EAAE,cAAc,EAAE,QAAQ,CAAC,EAAE,cAAc,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC;IACpE,OAAO,IAAI,CAAC;AACb,CAAC;AAED,MAAM,UAAU,aAAa,CAAC,UAA0B,EAAE,IAAY;IACrE,MAAM,CAAC,UAAU,CAAC,IAAI,EAAE,IAAI,EAAE,uCAAuC,CAAC,CAAC;IACvE,MAAM,CAAC,UAAU,CAAC,IAAI,EAAE,cAAc,EAAE,QAAQ,CAAC,EAAE,GAAG,EAAE,EAAE,OAAO,EAAE,KAAK,IAAI,EAAE,EAAE,EAAE,eAAe,EAAE,EAAE,oBAAoB,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC,CAAC;IACrI,UAAU,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC;IAC5B,OAAO,IAAI,CAAC,UAAU,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;AACpC,CAAC;AAED,MAAM,UAAU,gBAAgB,CAAC,UAA0B,EAAE,IAAY,EAAE,IAAI,GAAG,QAAQ,CAAC,EAAE,CAAC;IAC7F,GAAG,CAAC,UAAU,CAAC,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,SAAS,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;IACrE,OAAO,IAAI,CAAC;AACb,CAAC;AAED,MAAM,UAAU,YAAY,CAAC,UAA0B,EAAE,IAAY,EAAE,EAAW;IACjF,MAAM,IAAI,GAAG,gBAAgB,CAAC,UAAU,EAAE,IAAI,EAAE,EAAE,CAAC,CAAC;IACpD,OAAO,CAAC,IAAI,CAAC,IAAI,EAAE,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC;IACvC,WAAW,CAAC,IAAI,CAAC,IAAI,EAAE,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC;IAC3C,OAAO,IAAI,CAAC;AACb,CAAC;AAED,MAAM,UAAU,OAAO,CAAC,GAAW,EAAE,OAAe;IACnD,MAAM,MAAM,GAAG,SAAS,CAAC,KAAK,EAAE,CAAC,QAAQ,EAAE,SAAS,EAAE,eAAe,EAAE,WAAW,EAAE,OAAO,CAAC,EAAE;QAC7F,GAAG;QACH,QAAQ,EAAE,MAAM;QAChB,GAAG,EAAE,mBAAmB,CAAC,GAAG,CAAC;KAC7B,CAAC,CAAC;IACH,OAAO,EAAE,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,CAAC;AAChF,CAAC;AAED,MAAM,UAAU,QAAQ,CAAC,UAA0B;IAClD,OAAO,UAAU,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,UAAU,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;AACxF,CAAC;AAED,MAAM,UAAU,QAAQ,CAAC,UAA0B;IAClD,OAAO,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,IAAI,GAAG,KAAK,CAAC;AAC/C,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"ruleStory.d.ts","sourceRoot":"","sources":["../../src/testing/ruleStory.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAIlD,OAAO,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,IAAI,EAAE,MAAM,UAAU,CAAC;AACxE,OAAO,EAAE,KAAK,GAAG,EAAc,MAAM,0BAA0B,CAAC;AAEhE,OAAO,EAAe,KAAK,QAAQ,EAAE,MAAM,2BAA2B,CAAC;AAEvE,UAAU,UAAU;IACnB,MAAM,EAAE,GAAG,GAAG,SAAS,CAAC;IACxB,QAAQ,EAAE,QAAQ,GAAG,SAAS,CAAC;IAC/B,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;CACtB;AAgBD,wBAAgB,UAAU,CAAC,OAAO,EAAE,OAAO,GAAG,MAAM,CAEnD;AA6BD,wBAAgB,aAAa;
|
|
1
|
+
{"version":3,"file":"ruleStory.d.ts","sourceRoot":"","sources":["../../src/testing/ruleStory.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAIlD,OAAO,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,cAAc,EAAE,IAAI,EAAE,MAAM,UAAU,CAAC;AACxE,OAAO,EAAE,KAAK,GAAG,EAAc,MAAM,0BAA0B,CAAC;AAEhE,OAAO,EAAe,KAAK,QAAQ,EAAE,MAAM,2BAA2B,CAAC;AAEvE,UAAU,UAAU;IACnB,MAAM,EAAE,GAAG,GAAG,SAAS,CAAC;IACxB,QAAQ,EAAE,QAAQ,GAAG,SAAS,CAAC;IAC/B,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;CACtB;AAgBD,wBAAgB,UAAU,CAAC,OAAO,EAAE,OAAO,GAAG,MAAM,CAEnD;AA6BD,wBAAgB,aAAa;YAcqB,MAAM;;;;;;;;;uBA+BlC,SAAS,QAAQ,EAAE;;;uCAOP,SAAS,QAAQ,EAAE;qCAIrB,MAAM,UAAU,MAAM;EAqBrD"}
|
|
@@ -46,7 +46,6 @@ function outcomeOf({ status }) {
|
|
|
46
46
|
}
|
|
47
47
|
export function makeRuleStory() {
|
|
48
48
|
const ruleStory = storyKit({
|
|
49
|
-
clock: "live",
|
|
50
49
|
create: () => Effect.gen(function* () {
|
|
51
50
|
const fs = yield* FileSystem.FileSystem;
|
|
52
51
|
const root = yield* fs.makeTempDirectoryScoped({ prefix: "quality-rule-" });
|
|
@@ -72,7 +71,7 @@ export function makeRuleStory() {
|
|
|
72
71
|
findings: () => checked(engine),
|
|
73
72
|
gate: Effect.fn("RuleStory.gate")(function* () {
|
|
74
73
|
story.tell("quality runs the repository gate");
|
|
75
|
-
engine.answer = yield*
|
|
74
|
+
engine.answer = yield* runQuality(engine.root, "lint");
|
|
76
75
|
}),
|
|
77
76
|
gateOutcome: () => Effect.map(answered(engine), outcomeOf),
|
|
78
77
|
gateReport: () => Effect.map(answered(engine), (answer) => answer.stdout + answer.stderr),
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"ruleStory.js","sourceRoot":"","sources":["../../src/testing/ruleStory.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAClD,OAAO,EAAE,QAAQ,EAAE,MAAM,0CAA0C,CAAC;AACpE,OAAO,EAAE,mBAAmB,EAAE,MAAM,mBAAmB,CAAC;AACxD,OAAO,EAAE,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAE3C,OAAO,EAAY,UAAU,EAAE,MAAM,0BAA0B,CAAC;AAChE,OAAO,EAAE,OAAO,EAAE,MAAM,8BAA8B,CAAC;AACvD,OAAO,EAAE,WAAW,EAAiB,MAAM,2BAA2B,CAAC;AAQvE,MAAM,QAAQ,GAAG,MAAM,CAAC,EAAE,CAAC,oBAAoB,CAAC,CAAC,QAAQ,CAAC,EAAE,IAAY,EAAE,KAA0B;IACnG,MAAM,EAAE,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC;IACxC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;IAC9B,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QAC1B,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;QAC1C,KAAK,CAAC,CAAC,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACnE,KAAK,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,MAAM,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;IACjD,CAAC;AACF,CAAC,CAAC,CAAC;AAEH,SAAS,OAAO,CAAC,KAA0B;IAC1C,OAAO,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAClD,CAAC;AAED,MAAM,UAAU,UAAU,CAAC,OAAgB;IAC1C,OAAO,OAAO,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,IAAI,IAAI,OAAO,CAAC,IAAI,EAAE,CAAC;AACtF,CAAC;AAED,SAAS,OAAO,CAAC,MAAkB;IAClC,IAAI,MAAM,CAAC,QAAQ,KAAK,SAAS,EAAE,CAAC;QACnC,OAAO,MAAM,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,0CAA0C,CAAC,CAAC,CAAC;IAC1E,CAAC;IACD,OAAO,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;AACxC,CAAC;AAED,SAAS,QAAQ,CAAC,MAAkB;IACnC,IAAI,MAAM,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;QACjC,OAAO,MAAM,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,wCAAwC,CAAC,CAAC,CAAC;IACxE,CAAC;IACD,OAAO,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;AACtC,CAAC;AAED,SAAS,SAAS,CAAC,EAAE,MAAM,EAAO;IACjC,IAAI,MAAM,KAAK,CAAC,EAAE,CAAC;QAClB,OAAO,QAAQ,CAAC;IACjB,CAAC;IACD,IAAI,MAAM,KAAK,CAAC,EAAE,CAAC;QAClB,OAAO,UAAU,CAAC;IACnB,CAAC;IACD,IAAI,MAAM,KAAK,CAAC,EAAE,CAAC;QAClB,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,OAAO,UAAU,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC;AACnC,CAAC;AAED,MAAM,UAAU,aAAa;IAC5B,MAAM,SAAS,GAAG,QAAQ,CAAC;QAC1B,
|
|
1
|
+
{"version":3,"file":"ruleStory.js","sourceRoot":"","sources":["../../src/testing/ruleStory.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAClD,OAAO,EAAE,QAAQ,EAAE,MAAM,0CAA0C,CAAC;AACpE,OAAO,EAAE,mBAAmB,EAAE,MAAM,mBAAmB,CAAC;AACxD,OAAO,EAAE,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAE3C,OAAO,EAAY,UAAU,EAAE,MAAM,0BAA0B,CAAC;AAChE,OAAO,EAAE,OAAO,EAAE,MAAM,8BAA8B,CAAC;AACvD,OAAO,EAAE,WAAW,EAAiB,MAAM,2BAA2B,CAAC;AAQvE,MAAM,QAAQ,GAAG,MAAM,CAAC,EAAE,CAAC,oBAAoB,CAAC,CAAC,QAAQ,CAAC,EAAE,IAAY,EAAE,KAA0B;IACnG,MAAM,EAAE,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC;IACxC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;IAC9B,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QAC1B,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;QAC1C,KAAK,CAAC,CAAC,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACnE,KAAK,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,MAAM,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;IACjD,CAAC;AACF,CAAC,CAAC,CAAC;AAEH,SAAS,OAAO,CAAC,KAA0B;IAC1C,OAAO,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAClD,CAAC;AAED,MAAM,UAAU,UAAU,CAAC,OAAgB;IAC1C,OAAO,OAAO,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,IAAI,IAAI,OAAO,CAAC,IAAI,EAAE,CAAC;AACtF,CAAC;AAED,SAAS,OAAO,CAAC,MAAkB;IAClC,IAAI,MAAM,CAAC,QAAQ,KAAK,SAAS,EAAE,CAAC;QACnC,OAAO,MAAM,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,0CAA0C,CAAC,CAAC,CAAC;IAC1E,CAAC;IACD,OAAO,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;AACxC,CAAC;AAED,SAAS,QAAQ,CAAC,MAAkB;IACnC,IAAI,MAAM,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;QACjC,OAAO,MAAM,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,wCAAwC,CAAC,CAAC,CAAC;IACxE,CAAC;IACD,OAAO,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;AACtC,CAAC;AAED,SAAS,SAAS,CAAC,EAAE,MAAM,EAAO;IACjC,IAAI,MAAM,KAAK,CAAC,EAAE,CAAC;QAClB,OAAO,QAAQ,CAAC;IACjB,CAAC;IACD,IAAI,MAAM,KAAK,CAAC,EAAE,CAAC;QAClB,OAAO,UAAU,CAAC;IACnB,CAAC;IACD,IAAI,MAAM,KAAK,CAAC,EAAE,CAAC;QAClB,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,OAAO,UAAU,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC;AACnC,CAAC;AAED,MAAM,UAAU,aAAa;IAC5B,MAAM,SAAS,GAAG,QAAQ,CAAC;QAC1B,MAAM,EAAE,GAAG,EAAE,CACZ,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YACnB,MAAM,EAAE,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC;YACxC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,EAAE,CAAC,uBAAuB,CAAC,EAAE,MAAM,EAAE,eAAe,EAAE,CAAC,CAAC;YAC5E,MAAM,MAAM,GAAe,EAAE,MAAM,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC;YAC5E,OAAO,MAAM,CAAC;QACf,CAAC,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC,EAAE,QAAQ,EAAE,CAAC;QACzC,KAAK,EAAE,QAAQ;QACf,IAAI,EAAE,cAAc;QACpB,MAAM,EAAE,CAAC,YAAY,CAAC;QACtB,KAAK,EAAE,CAAC,MAAM,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC;YAC1B,KAAK,EAAE,MAAM,CAAC,EAAE,CAAC,iBAAiB,CAAC,CAAC,QAAQ,CAAC,EAAU,IAA0B,EAAE,OAAgB,EAAE,SAAS,GAAG,GAAG;gBACnH,KAAK,CAAC,IAAI,CAAC,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,kBAAkB,IAAI,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,kBAAkB,IAAI,CAAC,EAAE,SAAS,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;gBAC9H,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC;gBACxE,IAAI,UAAU,CAAC,IAAI,KAAK,SAAS,EAAE,CAAC;oBACnC,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,GAAG,IAAI,CAAC,EAAE,yBAAyB,UAAU,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC;gBACxG,CAAC;gBACD,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;gBAC9B,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC;gBACvF,MAAM,CAAC,QAAQ,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC;gBAClD,OAAO,MAAM,CAAC,QAAQ,CAAC;YACxB,CAAC,CAAC;YACF,QAAQ,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC;YAC/B,IAAI,EAAE,MAAM,CAAC,EAAE,CAAC,gBAAgB,CAAC,CAAC,QAAQ,CAAC;gBAC1C,KAAK,CAAC,IAAI,CAAC,kCAAkC,CAAC,CAAC;gBAC/C,MAAM,CAAC,MAAM,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;YACxD,CAAC,CAAC;YACF,WAAW,EAAE,GAAG,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,SAAS,CAAC;YAC1D,UAAU,EAAE,GAAG,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;YACzF,SAAS,EAAE,GAAG,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;YACpF,QAAQ,EAAE,GAAG,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;YACrG,YAAY,EAAE,MAAM,CAAC,EAAE,CAAC,wBAAwB,CAAC,CAAC,QAAQ,CAAC,EAAE,IAAoB,EAAE,OAAgB;gBAClG,KAAK,CAAC,IAAI,CAAC,sBAAsB,IAAI,CAAC,EAAE,SAAS,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;gBAC5E,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,mBAAmB,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,CAAC;gBACnF,OAAO,UAAU,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC;YAC/D,CAAC,CAAC;YACF,OAAO,EAAE,MAAM,CAAC,EAAE,CAAC,mBAAmB,CAAC,CAAC,QAAQ,CAAC,EAAE,IAAY;gBAC9D,KAAK,CAAC,IAAI,CAAC,sBAAsB,IAAI,EAAE,CAAC,CAAC;gBACzC,MAAM,EAAE,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC;gBACxC,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;gBAC/B,KAAK,CAAC,CAAC,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;YACnF,CAAC,CAAC;YACF,MAAM,EAAE,CAAC,GAAG,KAA0B,EAAE,EAAE;gBACzC,KAAK,CAAC,IAAI,CAAC,qBAAqB,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;gBAClD,OAAO,QAAQ,CAAC,MAAM,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;YACrC,CAAC;SACD,CAAC;KACF,CAAC,CAAC;IAEH,SAAS,aAAa,CAAC,GAAG,KAA0B;QACnD,OAAO,SAAS,CAAC,KAAK,CAAC,YAAY,EAAE,2BAA2B,OAAO,CAAC,KAAK,CAAC,EAAE,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC,CAAC;IAC7H,CAAC;IAED,SAAS,eAAe,CAAC,IAAY,EAAE,MAAc;QACpD,OAAO,SAAS,CAAC,KAAK,CAAC,YAAY,EAAE,wBAAwB,IAAI,OAAO,MAAM,EAAE,EAAE,CAAC,MAAM,EAAE,EAAE,CAC5F,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YACnB,MAAM,EAAE,GAAG,KAAK,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC;YACxC,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;YAC/B,KAAK,CAAC,CAAC,EAAE,CAAC,aAAa,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;YAC3F,KAAK,CAAC,CAAC,EAAE,CAAC,OAAO,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;QAC1D,CAAC,CAAC,CACF,CAAC;IACH,CAAC;IAED,SAAS,gBAAgB;QACxB,OAAO,eAAe,CAAC,iCAAiC,EAAE,WAAW,CAAC,CAAC;IACxE,CAAC;IAED,MAAM,OAAO,GAIT,EAAE,GAAG,SAAS,EAAE,gBAAgB,EAAE,aAAa,EAAE,eAAe,EAAE,CAAC;IACvE,OAAO,OAAO,CAAC;AAChB,CAAC"}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@shivaedev/quality",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.59.0",
|
|
4
4
|
"description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
|
|
5
5
|
"homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
|
|
6
6
|
"bugs": {
|
|
@@ -51,9 +51,9 @@
|
|
|
51
51
|
],
|
|
52
52
|
"dependencies": {
|
|
53
53
|
"@biomejs/biome": "2.6.3",
|
|
54
|
-
"@shivaedev/errors": "0.
|
|
55
|
-
"@shivaedev/heavy-lock": "0.
|
|
56
|
-
"@shivaedev/service": "0.6.
|
|
54
|
+
"@shivaedev/errors": "0.8.0",
|
|
55
|
+
"@shivaedev/heavy-lock": "0.9.0",
|
|
56
|
+
"@shivaedev/service": "0.6.2",
|
|
57
57
|
"@vitest/coverage-v8": "5.0.5",
|
|
58
58
|
"ignore": "7.0.14",
|
|
59
59
|
"knip": "6.43.0",
|
|
@@ -65,7 +65,7 @@
|
|
|
65
65
|
"@effect/platform-node-shared": "4.0.6",
|
|
66
66
|
"@effect/vitest": "4.0.6",
|
|
67
67
|
"@shivaedev/test": "0.14.0",
|
|
68
|
-
"@shivaedev/test-story": "0.
|
|
68
|
+
"@shivaedev/test-story": "0.37.1",
|
|
69
69
|
"@types/node": "24.19.2",
|
|
70
70
|
"@typescript/native": "npm:typescript@7.0.2",
|
|
71
71
|
"effect": "4.0.6",
|
|
@@ -74,7 +74,7 @@
|
|
|
74
74
|
"peerDependencies": {
|
|
75
75
|
"@effect/platform-node": "4.0.6",
|
|
76
76
|
"@effect/platform-node-shared": "4.0.6",
|
|
77
|
-
"@shivaedev/test-story": "0.
|
|
77
|
+
"@shivaedev/test-story": "0.37.1",
|
|
78
78
|
"effect": "4.0.6",
|
|
79
79
|
"vitest": "5.0.5"
|
|
80
80
|
},
|
|
@@ -1,30 +1,17 @@
|
|
|
1
|
-
import {
|
|
2
|
-
import { Data, Effect } from "effect";
|
|
1
|
+
import { Effect } from "effect";
|
|
3
2
|
import type ts from "typescript";
|
|
4
3
|
import { defineService } from "@shivaedev/service/defineService.ts";
|
|
5
|
-
import {
|
|
6
|
-
import {
|
|
7
|
-
import {
|
|
8
|
-
import type { WorkspacePackage } from "#imports/workspace.ts";
|
|
9
|
-
import type { RuleInputs } from "#rule.ts";
|
|
10
|
-
|
|
11
|
-
export class ImportAnalysisFailure extends Data.TaggedError("ImportAnalysisFailure")<{
|
|
12
|
-
readonly message: string;
|
|
13
|
-
readonly root: string;
|
|
14
|
-
}> {}
|
|
15
|
-
|
|
16
|
-
function failure(root: string, cause: unknown): ImportAnalysisFailure {
|
|
17
|
-
return new ImportAnalysisFailure({ message: `Cannot analyze imports in ${root}: ${cause instanceof Error ? cause.message : String(cause)}`, root });
|
|
18
|
-
}
|
|
4
|
+
import { analyzeDepartures } from "#adapters/imports/analyzeDepartures.ts";
|
|
5
|
+
import { analyzeGraph } from "#adapters/imports/analyzeGraph.ts";
|
|
6
|
+
import { checkBrowser } from "#adapters/imports/checkBrowser.ts";
|
|
19
7
|
|
|
20
8
|
export const ImportCompiler = defineService({
|
|
21
9
|
id: "@shivaedev/quality/ImportCompiler",
|
|
22
10
|
initialize: Effect.void,
|
|
23
11
|
methods: () => ({
|
|
24
|
-
browserChecker: (source: ts.SourceFile) => Effect.
|
|
25
|
-
departures:
|
|
26
|
-
|
|
27
|
-
graph: (inputs: RuleInputs) => Effect.try({ catch: (cause) => failure(inputs.root, cause), try: () => graph(inputs, realpathSync(inputs.root)) }),
|
|
12
|
+
browserChecker: checkBrowser satisfies (source: ts.SourceFile) => Effect.Effect<ts.TypeChecker>,
|
|
13
|
+
departures: analyzeDepartures,
|
|
14
|
+
graph: analyzeGraph,
|
|
28
15
|
}),
|
|
29
16
|
requires: [],
|
|
30
17
|
});
|
|
@@ -0,0 +1,141 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { importFrom } from "#rules/stories/importOrigin.ts";
|
|
3
|
+
import { memberName, unwrapped } from "#rules/stories/syntax.ts";
|
|
4
|
+
|
|
5
|
+
export interface BodyReference {
|
|
6
|
+
readonly file?: string | undefined;
|
|
7
|
+
readonly kind: "data" | "import" | "service" | "told";
|
|
8
|
+
readonly module: string;
|
|
9
|
+
readonly path: readonly string[];
|
|
10
|
+
}
|
|
11
|
+
|
|
12
|
+
export function storyBody(body: ts.Expression, checker: ts.TypeChecker) {
|
|
13
|
+
const declaration = checker.getTypeAtLocation(body).getCallSignatures()[0]?.declaration;
|
|
14
|
+
return declaration !== undefined && "body" in declaration ? declaration : undefined;
|
|
15
|
+
}
|
|
16
|
+
|
|
17
|
+
function importName(node: ts.ImportSpecifier | ts.NamespaceImport | ts.ImportClause): string | undefined {
|
|
18
|
+
if (ts.isImportSpecifier(node)) {
|
|
19
|
+
return (node.propertyName ?? node.name).text;
|
|
20
|
+
}
|
|
21
|
+
return ts.isImportClause(node) ? "default" : undefined;
|
|
22
|
+
}
|
|
23
|
+
|
|
24
|
+
function wrapped(node: ts.Node): node is ts.ParenthesizedExpression | ts.AsExpression | ts.SatisfiesExpression | ts.NonNullExpression {
|
|
25
|
+
return ts.isParenthesizedExpression(node) || ts.isAsExpression(node) || ts.isSatisfiesExpression(node) || ts.isNonNullExpression(node);
|
|
26
|
+
}
|
|
27
|
+
|
|
28
|
+
function importBinding(node: ts.Node): node is ts.ImportSpecifier | ts.NamespaceImport | ts.ImportClause {
|
|
29
|
+
return ts.isImportSpecifier(node) || ts.isNamespaceImport(node) || ts.isImportClause(node);
|
|
30
|
+
}
|
|
31
|
+
|
|
32
|
+
export function bodyReferences(body: ts.SignatureDeclaration, checker: ts.TypeChecker) {
|
|
33
|
+
const known = new Map<ts.Node, BodyReference | undefined>();
|
|
34
|
+
const visiting = new Set<ts.Node>();
|
|
35
|
+
const told = body.parameters[0];
|
|
36
|
+
function symbol(value: ts.Symbol | undefined): BodyReference | undefined {
|
|
37
|
+
return value?.declarations?.map(visit).find((reference) => reference !== undefined);
|
|
38
|
+
}
|
|
39
|
+
function imported(node: ts.ImportSpecifier | ts.NamespaceImport | ts.ImportClause): BodyReference | undefined {
|
|
40
|
+
const name = importName(node);
|
|
41
|
+
const module = importFrom(node);
|
|
42
|
+
if (module === undefined) {
|
|
43
|
+
return undefined;
|
|
44
|
+
}
|
|
45
|
+
const value = checker.getSymbolAtLocation(node.name ?? node);
|
|
46
|
+
const target = value !== undefined && value.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(value) : undefined;
|
|
47
|
+
const resolved = symbol(target);
|
|
48
|
+
if (resolved?.kind === "service" || resolved?.kind === "data") {
|
|
49
|
+
return resolved;
|
|
50
|
+
}
|
|
51
|
+
const canonical = target?.declarations === undefined ? name : target.name;
|
|
52
|
+
return { file: target?.declarations?.[0]?.getSourceFile().fileName, kind: "import", module, path: name === undefined ? [] : [canonical ?? name] };
|
|
53
|
+
}
|
|
54
|
+
|
|
55
|
+
function member(reference: BodyReference | undefined, name: string): BodyReference | undefined {
|
|
56
|
+
return reference === undefined ? undefined : { ...reference, path: [...reference.path, name] };
|
|
57
|
+
}
|
|
58
|
+
function binding(node: ts.BindingElement): BodyReference | undefined {
|
|
59
|
+
const name = node.propertyName ?? node.name;
|
|
60
|
+
return ts.isIdentifier(name) || ts.isStringLiteral(name) ? member(visit(node.parent.parent), name.text) : undefined;
|
|
61
|
+
}
|
|
62
|
+
function call(node: ts.CallExpression): BodyReference | undefined {
|
|
63
|
+
const called = visit(node.expression);
|
|
64
|
+
if ((called?.kind === "service" && called.path.length === 0) || (called?.kind === "import" && serviceFactory(called))) {
|
|
65
|
+
return { kind: "service", module: called.module, path: [] };
|
|
66
|
+
}
|
|
67
|
+
if (called?.kind === "data" || (called?.kind === "import" && dataFactory(called))) {
|
|
68
|
+
return { kind: "data", module: called.module, path: [] };
|
|
69
|
+
}
|
|
70
|
+
return undefined;
|
|
71
|
+
}
|
|
72
|
+
function property(node: ts.PropertyAccessExpression | ts.ElementAccessExpression): BodyReference | undefined {
|
|
73
|
+
const receiver = visit(node.expression);
|
|
74
|
+
if (receiver?.kind === "import" && receiver.path.length === 0) {
|
|
75
|
+
const resolved = symbol(checker.getSymbolAtLocation(ts.isPropertyAccessExpression(node) ? node.name : node));
|
|
76
|
+
if (resolved?.kind === "service" || resolved?.kind === "data") {
|
|
77
|
+
return resolved;
|
|
78
|
+
}
|
|
79
|
+
}
|
|
80
|
+
return member(receiver, memberName(node) ?? "");
|
|
81
|
+
}
|
|
82
|
+
function expression(node: ts.Node): BodyReference | undefined {
|
|
83
|
+
if (ts.isIdentifier(node)) {
|
|
84
|
+
return symbol(checker.getSymbolAtLocation(node));
|
|
85
|
+
}
|
|
86
|
+
if (ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) {
|
|
87
|
+
return property(node);
|
|
88
|
+
}
|
|
89
|
+
return ts.isCallExpression(node) ? call(node) : undefined;
|
|
90
|
+
}
|
|
91
|
+
function classReference(node: ts.ClassDeclaration): BodyReference | undefined {
|
|
92
|
+
return node.heritageClauses
|
|
93
|
+
?.flatMap((clause) => clause.types.map((base) => visit(base.expression)))
|
|
94
|
+
.find((value) => value?.kind === "service" || value?.kind === "data");
|
|
95
|
+
}
|
|
96
|
+
function origin(node: ts.Node): BodyReference | undefined {
|
|
97
|
+
if (wrapped(node)) {
|
|
98
|
+
return visit(node.expression);
|
|
99
|
+
}
|
|
100
|
+
if (node === told) {
|
|
101
|
+
return { kind: "told", module: "", path: [] };
|
|
102
|
+
}
|
|
103
|
+
if (importBinding(node)) {
|
|
104
|
+
return imported(node);
|
|
105
|
+
}
|
|
106
|
+
if (ts.isVariableDeclaration(node)) {
|
|
107
|
+
return node.initializer === undefined ? undefined : visit(unwrapped(node.initializer));
|
|
108
|
+
}
|
|
109
|
+
if (ts.isBindingElement(node)) {
|
|
110
|
+
return binding(node);
|
|
111
|
+
}
|
|
112
|
+
if (ts.isClassDeclaration(node)) {
|
|
113
|
+
return classReference(node);
|
|
114
|
+
}
|
|
115
|
+
return expression(node);
|
|
116
|
+
}
|
|
117
|
+
function visit(node: ts.Node): BodyReference | undefined {
|
|
118
|
+
if (visiting.has(node) || known.has(node)) {
|
|
119
|
+
return known.get(node);
|
|
120
|
+
}
|
|
121
|
+
visiting.add(node);
|
|
122
|
+
const value = origin(node);
|
|
123
|
+
visiting.delete(node);
|
|
124
|
+
known.set(node, value);
|
|
125
|
+
return value;
|
|
126
|
+
}
|
|
127
|
+
return visit;
|
|
128
|
+
}
|
|
129
|
+
|
|
130
|
+
function dataFactory({ module, path }: BodyReference): boolean {
|
|
131
|
+
return (module === "effect" && (path[0] === "Schema" || path[0] === "Data")) || module === "effect/Schema" || module === "effect/Data";
|
|
132
|
+
}
|
|
133
|
+
|
|
134
|
+
function serviceFactory({ module, path }: BodyReference): boolean {
|
|
135
|
+
return (
|
|
136
|
+
(module === "@shivaedev/service/defineService.ts" && path[0] === "defineService")
|
|
137
|
+
|| ((module === "effect" || module === "effect/Context")
|
|
138
|
+
&& path.at(-1) !== undefined
|
|
139
|
+
&& ["Service", "Tag", "GenericTag", "Reference"].includes(path.at(-1) ?? ""))
|
|
140
|
+
);
|
|
141
|
+
}
|
|
@@ -0,0 +1,119 @@
|
|
|
1
|
+
import { posix } from "node:path";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import { isTestSupport, testName } from "#naming/testName.ts";
|
|
4
|
+
import { engineOf } from "#rules/stories/engineOf.ts";
|
|
5
|
+
import { memberName, unwrapped } from "#rules/stories/syntax.ts";
|
|
6
|
+
import { type BodyReference, bodyReferences, storyBody } from "./bodyReferences.ts";
|
|
7
|
+
import { serviceAccess } from "./serviceAccess.ts";
|
|
8
|
+
|
|
9
|
+
export interface EngineEscape {
|
|
10
|
+
readonly node: ts.Node;
|
|
11
|
+
readonly reason: string;
|
|
12
|
+
}
|
|
13
|
+
|
|
14
|
+
function production({ file, module }: BodyReference): boolean {
|
|
15
|
+
return (
|
|
16
|
+
!(isTestSupport(file ?? module) || module.startsWith("@shivaedev/test"))
|
|
17
|
+
&& (/^[.#/]/u.test(module)
|
|
18
|
+
|| module.startsWith("@shivaedev/")
|
|
19
|
+
|| engineOf({ kind: "external", package: module, specifier: module }) !== undefined)
|
|
20
|
+
);
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
function constructorTest(file: string, reference: BodyReference): boolean {
|
|
24
|
+
const name = testName(file);
|
|
25
|
+
const target = reference.file ?? posix.join(posix.dirname(file), reference.module);
|
|
26
|
+
return name !== undefined && target.endsWith(`/${posix.join(name.folder, name.stem)}${name.extension}`);
|
|
27
|
+
}
|
|
28
|
+
|
|
29
|
+
function constructorCall(node: ts.CallExpression | ts.NewExpression, called: BodyReference): boolean {
|
|
30
|
+
const name = called.path.at(-1) ?? "";
|
|
31
|
+
return (
|
|
32
|
+
called.kind === "import"
|
|
33
|
+
&& production(called)
|
|
34
|
+
&& (ts.isNewExpression(node) || /^(?:(?:make|create|build)[A-Z]|make$|create$|build$|defineService$|layer(?:$|[A-Z]))/u.test(name))
|
|
35
|
+
);
|
|
36
|
+
}
|
|
37
|
+
|
|
38
|
+
export function engineEscapes(body: ts.Expression, checker: ts.TypeChecker, file: string) {
|
|
39
|
+
const declaration = storyBody(body, checker);
|
|
40
|
+
if (declaration?.body === undefined) {
|
|
41
|
+
return { drivesSubject: false, escapes: [] };
|
|
42
|
+
}
|
|
43
|
+
const reference = bodyReferences(declaration, checker);
|
|
44
|
+
const block = declaration.body;
|
|
45
|
+
const escapes: EngineEscape[] = [];
|
|
46
|
+
let drivesSubject = false;
|
|
47
|
+
function transactionHandle(node: ts.Node, value: BodyReference): boolean {
|
|
48
|
+
if (!((value.module === "effect/sql/SqlClient" || value.module === "effect/sql") && value.path.at(-1) === "SqlClient")) {
|
|
49
|
+
return false;
|
|
50
|
+
}
|
|
51
|
+
const yielded = node.parent;
|
|
52
|
+
const binding = yielded.parent;
|
|
53
|
+
if (!(ts.isYieldExpression(yielded) && ts.isVariableDeclaration(binding) && ts.isIdentifier(binding.name))) {
|
|
54
|
+
return false;
|
|
55
|
+
}
|
|
56
|
+
const name = binding.name;
|
|
57
|
+
const symbol = checker.getSymbolAtLocation(name);
|
|
58
|
+
const uses: ts.Identifier[] = [];
|
|
59
|
+
function collect(current: ts.Node): void {
|
|
60
|
+
if (ts.isIdentifier(current) && current !== name && checker.getSymbolAtLocation(current) === symbol) {
|
|
61
|
+
uses.push(current);
|
|
62
|
+
}
|
|
63
|
+
ts.forEachChild(current, collect);
|
|
64
|
+
}
|
|
65
|
+
collect(block);
|
|
66
|
+
return (
|
|
67
|
+
uses.length > 0
|
|
68
|
+
&& uses.every(
|
|
69
|
+
(use) =>
|
|
70
|
+
(ts.isPropertyAccessExpression(use.parent) || ts.isElementAccessExpression(use.parent))
|
|
71
|
+
&& use.parent.expression === use
|
|
72
|
+
&& memberName(use.parent) === "withTransaction",
|
|
73
|
+
)
|
|
74
|
+
);
|
|
75
|
+
}
|
|
76
|
+
function accessReason(node: ts.Node): string | undefined {
|
|
77
|
+
const value = reference(node);
|
|
78
|
+
if (value?.kind === "told" && value.path[0] === "story" && value.path[1] === "engine") {
|
|
79
|
+
return "Reads story.engine";
|
|
80
|
+
}
|
|
81
|
+
if (value === undefined || !serviceAccess(node, value, reference)) {
|
|
82
|
+
return undefined;
|
|
83
|
+
}
|
|
84
|
+
if (transactionHandle(node, value)) {
|
|
85
|
+
drivesSubject = true;
|
|
86
|
+
return undefined;
|
|
87
|
+
}
|
|
88
|
+
return "Reads a raw service handle";
|
|
89
|
+
}
|
|
90
|
+
function checkConstructor(node: ts.CallExpression | ts.NewExpression): void {
|
|
91
|
+
const called = reference(unwrapped(node.expression));
|
|
92
|
+
if (called === undefined || !constructorCall(node, called)) {
|
|
93
|
+
return;
|
|
94
|
+
}
|
|
95
|
+
if (constructorTest(file, called)) {
|
|
96
|
+
drivesSubject = true;
|
|
97
|
+
} else {
|
|
98
|
+
escapes.push({ node, reason: "Calls a production constructor" });
|
|
99
|
+
}
|
|
100
|
+
}
|
|
101
|
+
function visit(node: ts.Node): void {
|
|
102
|
+
if (ts.isTypeNode(node)) {
|
|
103
|
+
return;
|
|
104
|
+
}
|
|
105
|
+
if (ts.isIdentifier(node) || ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) {
|
|
106
|
+
const reason = accessReason(node);
|
|
107
|
+
if (reason !== undefined) {
|
|
108
|
+
escapes.push({ node, reason });
|
|
109
|
+
return;
|
|
110
|
+
}
|
|
111
|
+
}
|
|
112
|
+
if (ts.isCallExpression(node) || ts.isNewExpression(node)) {
|
|
113
|
+
checkConstructor(node);
|
|
114
|
+
}
|
|
115
|
+
ts.forEachChild(node, visit);
|
|
116
|
+
}
|
|
117
|
+
visit(declaration.body);
|
|
118
|
+
return { drivesSubject, escapes: escapes.filter((found, index) => escapes.findIndex((other) => other.reason === found.reason) === index) };
|
|
119
|
+
}
|
|
@@ -0,0 +1,5 @@
|
|
|
1
|
+
import { ImportAnalysisFailure } from "#adapters/ImportAnalysisFailure.ts";
|
|
2
|
+
|
|
3
|
+
export function analysisFailure(root: string, cause: unknown): ImportAnalysisFailure {
|
|
4
|
+
return new ImportAnalysisFailure({ message: `Cannot analyze imports in ${root}: ${cause instanceof Error ? cause.message : String(cause)}`, root });
|
|
5
|
+
}
|
|
@@ -0,0 +1,9 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
2
|
+
import type { WorkspacePackage } from "#imports/workspace.ts";
|
|
3
|
+
import type { RuleInputs } from "#rule.ts";
|
|
4
|
+
import { analysisFailure } from "./analysisFailure.ts";
|
|
5
|
+
import { departures } from "./departures.ts";
|
|
6
|
+
|
|
7
|
+
export const analyzeDepartures = Effect.fn("ImportCompiler.analyzeDepartures")((inputs: RuleInputs, packages: readonly WorkspacePackage[]) =>
|
|
8
|
+
Effect.try({ catch: (cause) => analysisFailure(inputs.root, cause), try: () => departures(inputs, packages) }),
|
|
9
|
+
);
|
|
@@ -0,0 +1,9 @@
|
|
|
1
|
+
import { realpathSync } from "node:fs";
|
|
2
|
+
import { Effect } from "effect";
|
|
3
|
+
import type { RuleInputs } from "#rule.ts";
|
|
4
|
+
import { analysisFailure } from "./analysisFailure.ts";
|
|
5
|
+
import { graph } from "./graph.ts";
|
|
6
|
+
|
|
7
|
+
export const analyzeGraph = Effect.fn("ImportCompiler.analyzeGraph")((inputs: RuleInputs) =>
|
|
8
|
+
Effect.try({ catch: (cause) => analysisFailure(inputs.root, cause), try: () => graph(inputs, realpathSync(inputs.root)) }),
|
|
9
|
+
);
|
|
@@ -0,0 +1,25 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { unwrapExpression } from "#adapters/serviceAssemblySyntax.ts";
|
|
3
|
+
|
|
4
|
+
export function indirectServiceReferences(
|
|
5
|
+
source: ts.SourceFile,
|
|
6
|
+
names: ReadonlySet<string>,
|
|
7
|
+
definitions: readonly ts.CallExpression[],
|
|
8
|
+
): readonly ts.Node[] {
|
|
9
|
+
const direct = new Set(definitions.map((definition) => unwrapExpression(definition.expression)));
|
|
10
|
+
const found: ts.Node[] = [];
|
|
11
|
+
function visit(node: ts.Node): void {
|
|
12
|
+
if (
|
|
13
|
+
ts.isIdentifier(node)
|
|
14
|
+
&& names.has(node.text)
|
|
15
|
+
&& !direct.has(node)
|
|
16
|
+
&& !ts.isImportSpecifier(node.parent)
|
|
17
|
+
&& !ts.isPropertyAccessExpression(node.parent)
|
|
18
|
+
) {
|
|
19
|
+
found.push(node);
|
|
20
|
+
}
|
|
21
|
+
ts.forEachChild(node, visit);
|
|
22
|
+
}
|
|
23
|
+
visit(source);
|
|
24
|
+
return found;
|
|
25
|
+
}
|
|
@@ -0,0 +1,108 @@
|
|
|
1
|
+
import { join } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
3
|
+
import ts from "typescript";
|
|
4
|
+
import type { Finding, RuleInputs } from "#rule.ts";
|
|
5
|
+
import { effectProgram } from "#rules/effect/program.ts";
|
|
6
|
+
import { parse } from "#rules/parse.ts";
|
|
7
|
+
import { memberName, nodesWhere, unwrapped } from "#rules/stories/syntax.ts";
|
|
8
|
+
import { transactionChanges } from "./transactionChanges.ts";
|
|
9
|
+
|
|
10
|
+
function candidates(source: ts.SourceFile): readonly ts.Node[] {
|
|
11
|
+
const aliases = new Set(["withTransaction"]);
|
|
12
|
+
for (const node of nodesWhere(source, (candidate) => ts.isVariableDeclaration(candidate) || ts.isBindingElement(candidate))) {
|
|
13
|
+
if (ts.isVariableDeclaration(node) && ts.isIdentifier(node.name) && node.initializer !== undefined) {
|
|
14
|
+
const value = unwrapped(node.initializer);
|
|
15
|
+
if (memberName(value) === "withTransaction" || (ts.isIdentifier(value) && aliases.has(value.text))) {
|
|
16
|
+
aliases.add(node.name.text);
|
|
17
|
+
}
|
|
18
|
+
}
|
|
19
|
+
if (ts.isBindingElement(node) && node.propertyName?.getText() === "withTransaction" && ts.isIdentifier(node.name)) {
|
|
20
|
+
aliases.add(node.name.text);
|
|
21
|
+
}
|
|
22
|
+
}
|
|
23
|
+
function reference(expression: ts.Expression): boolean {
|
|
24
|
+
const value = unwrapped(expression);
|
|
25
|
+
return memberName(value) === "withTransaction" || (ts.isIdentifier(value) && aliases.has(value.text));
|
|
26
|
+
}
|
|
27
|
+
return nodesWhere(source, (node) => ts.isCallExpression(node) && (reference(node.expression) || node.arguments.some(reference)));
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
function nativeTransaction(checker: ts.TypeChecker, expression: ts.Expression): boolean {
|
|
31
|
+
const value = unwrapped(expression);
|
|
32
|
+
if (!ts.isIdentifier(value) && memberName(value) !== "withTransaction") {
|
|
33
|
+
return false;
|
|
34
|
+
}
|
|
35
|
+
const signature = checker.getTypeAtLocation(value).getCallSignatures()[0];
|
|
36
|
+
const declaration = signature?.getDeclaration();
|
|
37
|
+
if (declaration === undefined) {
|
|
38
|
+
return false;
|
|
39
|
+
}
|
|
40
|
+
const path = declaration.getSourceFile().fileName.replaceAll("\\", "/");
|
|
41
|
+
return (
|
|
42
|
+
/\/effect\/(?:src|dist(?:\/dts)?)\/sql\/SqlClient\.(?:d\.)?ts$/u.test(path)
|
|
43
|
+
&& ts.isPropertySignature(declaration.parent)
|
|
44
|
+
&& declaration.parent.name.getText() === "withTransaction"
|
|
45
|
+
);
|
|
46
|
+
}
|
|
47
|
+
|
|
48
|
+
function changedBodies(checker: ts.TypeChecker, call: ts.CallExpression): readonly ts.Expression[] {
|
|
49
|
+
if (nativeTransaction(checker, call.expression)) {
|
|
50
|
+
return call.arguments.slice(0, 1);
|
|
51
|
+
}
|
|
52
|
+
const callee = unwrapped(call.expression);
|
|
53
|
+
const index = call.arguments.findIndex((argument) => nativeTransaction(checker, argument));
|
|
54
|
+
if (index < 0) {
|
|
55
|
+
return [];
|
|
56
|
+
}
|
|
57
|
+
if (ts.isPropertyAccessExpression(callee) && callee.name.text === "pipe") {
|
|
58
|
+
return [callee.expression, ...call.arguments.slice(0, index)];
|
|
59
|
+
}
|
|
60
|
+
const declaration = checker.getResolvedSignature(call)?.getDeclaration();
|
|
61
|
+
return declaration !== undefined && /\/effect\/(?:src|dist(?:\/dts)?)\/Function\.(?:d\.)?ts$/u.test(declaration.getSourceFile().fileName)
|
|
62
|
+
? call.arguments.slice(0, index)
|
|
63
|
+
: [];
|
|
64
|
+
}
|
|
65
|
+
|
|
66
|
+
function findingsIn(inputs: RuleInputs): readonly Finding[] {
|
|
67
|
+
const program = effectProgram(inputs);
|
|
68
|
+
const checker = program.getTypeChecker();
|
|
69
|
+
return inputs.sources.flatMap((file) => {
|
|
70
|
+
const source = program.getSourceFile(join(inputs.root, file.path));
|
|
71
|
+
if (source === undefined) {
|
|
72
|
+
return [];
|
|
73
|
+
}
|
|
74
|
+
return candidates(source).flatMap((node): readonly Finding[] => {
|
|
75
|
+
if (!ts.isCallExpression(node)) {
|
|
76
|
+
return [];
|
|
77
|
+
}
|
|
78
|
+
if (!changedBodies(checker, node).some((body) => transactionChanges(checker, body))) {
|
|
79
|
+
return [];
|
|
80
|
+
}
|
|
81
|
+
return [
|
|
82
|
+
{
|
|
83
|
+
file: file.path,
|
|
84
|
+
line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1,
|
|
85
|
+
message:
|
|
86
|
+
"Uses native sql.withTransaction around repository writes or change announcements. Begin the outer transaction with transact(effect, { onSqlError }) so changed keys follow its commit.",
|
|
87
|
+
},
|
|
88
|
+
];
|
|
89
|
+
});
|
|
90
|
+
});
|
|
91
|
+
}
|
|
92
|
+
|
|
93
|
+
export const nativeTransactionFindings = Effect.fn("NativeTransactions.nativeTransactionFindings")((inputs: RuleInputs) =>
|
|
94
|
+
Effect.sync(() => {
|
|
95
|
+
const groups = new Map<string, RuleInputs["sources"][number][]>();
|
|
96
|
+
for (const source of inputs.sources) {
|
|
97
|
+
const syntax = source.text.includes("withTransaction") ? parse(source) : undefined;
|
|
98
|
+
if (syntax === undefined || candidates(syntax).length === 0) {
|
|
99
|
+
continue;
|
|
100
|
+
}
|
|
101
|
+
const group = /^(?:packages|examples)\/[^/]+/u.exec(source.path)?.[0] ?? ".";
|
|
102
|
+
const sources = groups.get(group) ?? [];
|
|
103
|
+
sources.push(source);
|
|
104
|
+
groups.set(group, sources);
|
|
105
|
+
}
|
|
106
|
+
return [...groups.values()].flatMap((sources) => findingsIn({ ...inputs, sources }));
|
|
107
|
+
}),
|
|
108
|
+
);
|