@shivaedev/quality 0.56.0 → 0.57.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +41 -0
- package/README.md +63 -4
- package/biome/plugins/effect-test-bodies.grit +1 -1
- package/dist/{rules/suppressions → adapters}/biome/configs.d.ts +2 -2
- package/dist/adapters/biome/configs.d.ts.map +1 -0
- package/dist/{rules/suppressions → adapters}/biome/configs.js +2 -2
- package/dist/adapters/biome/configs.js.map +1 -0
- package/dist/adapters/biome/presetConfig.d.ts +21 -0
- package/dist/adapters/biome/presetConfig.d.ts.map +1 -0
- package/dist/adapters/biome/presetConfig.js +32 -0
- package/dist/adapters/biome/presetConfig.js.map +1 -0
- package/dist/adapters/biome/relocateConfig.d.ts.map +1 -0
- package/dist/adapters/biome/relocateConfig.js.map +1 -0
- package/dist/adapters/biome/resolvePackage.d.ts.map +1 -0
- package/dist/adapters/biome/resolvePackage.js.map +1 -0
- package/dist/adapters/biome/rootConfig.d.ts +9 -0
- package/dist/adapters/biome/rootConfig.d.ts.map +1 -0
- package/dist/adapters/biome/rootConfig.js +11 -0
- package/dist/adapters/biome/rootConfig.js.map +1 -0
- package/dist/adapters/biome/run.js +1 -1
- package/dist/adapters/biome/run.js.map +1 -1
- package/dist/adapters/biome/syntaxOf.d.ts +3 -0
- package/dist/adapters/biome/syntaxOf.d.ts.map +1 -0
- package/dist/adapters/biome/syntaxOf.js +11 -0
- package/dist/adapters/biome/syntaxOf.js.map +1 -0
- package/dist/adapters/biome/withExceptionConfig.d.ts +8 -0
- package/dist/adapters/biome/withExceptionConfig.d.ts.map +1 -0
- package/dist/adapters/biome/withExceptionConfig.js +38 -0
- package/dist/adapters/biome/withExceptionConfig.js.map +1 -0
- package/dist/adapters/changeKeyApi.d.ts +4 -0
- package/dist/adapters/changeKeyApi.d.ts.map +1 -0
- package/dist/adapters/changeKeyApi.js +58 -0
- package/dist/adapters/changeKeyApi.js.map +1 -0
- package/dist/adapters/changeKeyFindings.d.ts +4 -0
- package/dist/adapters/changeKeyFindings.d.ts.map +1 -0
- package/dist/adapters/changeKeyFindings.js +87 -0
- package/dist/adapters/changeKeyFindings.js.map +1 -0
- package/dist/adapters/changeKeyLiterals.d.ts +3 -0
- package/dist/adapters/changeKeyLiterals.d.ts.map +1 -0
- package/dist/adapters/changeKeyLiterals.js +56 -0
- package/dist/adapters/changeKeyLiterals.js.map +1 -0
- package/dist/adapters/executable.d.ts +3 -0
- package/dist/adapters/executable.d.ts.map +1 -0
- package/dist/adapters/executable.js +14 -0
- package/dist/adapters/executable.js.map +1 -0
- package/dist/adapters/ignore.d.ts +10 -0
- package/dist/adapters/ignore.d.ts.map +1 -0
- package/dist/adapters/ignore.js +10 -0
- package/dist/adapters/ignore.js.map +1 -0
- package/dist/adapters/imports/fakeReferences.d.ts +14 -0
- package/dist/adapters/imports/fakeReferences.d.ts.map +1 -0
- package/dist/adapters/imports/fakeReferences.js +103 -0
- package/dist/adapters/imports/fakeReferences.js.map +1 -0
- package/dist/adapters/imports/fakeTargets.d.ts +13 -0
- package/dist/adapters/imports/fakeTargets.d.ts.map +1 -0
- package/dist/adapters/imports/fakeTargets.js +14 -0
- package/dist/adapters/imports/fakeTargets.js.map +1 -0
- package/dist/adapters/outsideImportFindings.d.ts +5 -0
- package/dist/adapters/outsideImportFindings.d.ts.map +1 -0
- package/dist/adapters/outsideImportFindings.js +78 -0
- package/dist/adapters/outsideImportFindings.js.map +1 -0
- package/dist/adapters/queueReadoutFindings.d.ts +8 -0
- package/dist/adapters/queueReadoutFindings.d.ts.map +1 -0
- package/dist/adapters/queueReadoutFindings.js +30 -0
- package/dist/adapters/queueReadoutFindings.js.map +1 -0
- package/dist/adapters/queueTestingOrigin.d.ts +5 -0
- package/dist/adapters/queueTestingOrigin.d.ts.map +1 -0
- package/dist/adapters/queueTestingOrigin.js +95 -0
- package/dist/adapters/queueTestingOrigin.js.map +1 -0
- package/dist/adapters/readConfig.d.ts +7 -0
- package/dist/adapters/readConfig.d.ts.map +1 -0
- package/dist/adapters/readConfig.js +40 -0
- package/dist/adapters/readConfig.js.map +1 -0
- package/dist/adapters/serviceIdFindings.d.ts +4 -0
- package/dist/adapters/serviceIdFindings.d.ts.map +1 -0
- package/dist/adapters/serviceIdFindings.js +65 -0
- package/dist/adapters/serviceIdFindings.js.map +1 -0
- package/dist/adapters/sharedErrorFindings.d.ts +4 -0
- package/dist/adapters/sharedErrorFindings.d.ts.map +1 -0
- package/dist/adapters/sharedErrorFindings.js +71 -0
- package/dist/adapters/sharedErrorFindings.js.map +1 -0
- package/dist/adapters/sharedErrorModules.d.ts +7 -0
- package/dist/adapters/sharedErrorModules.d.ts.map +1 -0
- package/dist/adapters/sharedErrorModules.js +66 -0
- package/dist/adapters/sharedErrorModules.js.map +1 -0
- package/dist/adapters/testProjects.d.ts.map +1 -1
- package/dist/adapters/testProjects.js +18 -2
- package/dist/adapters/testProjects.js.map +1 -1
- package/dist/appTestConfig.d.ts +1 -1
- package/dist/appTestConfig.d.ts.map +1 -1
- package/dist/appTestConfig.js.map +1 -1
- package/dist/baseline/cleanupMergeFiles.d.ts.map +1 -1
- package/dist/baseline/cleanupMergeFiles.js +3 -2
- package/dist/baseline/cleanupMergeFiles.js.map +1 -1
- package/dist/baseline/shards.d.ts.map +1 -1
- package/dist/baseline/shards.js +4 -2
- package/dist/baseline/shards.js.map +1 -1
- package/dist/biome/exceptionConfig.d.ts +0 -7
- package/dist/biome/exceptionConfig.d.ts.map +1 -1
- package/dist/biome/exceptionConfig.js +0 -36
- package/dist/biome/exceptionConfig.js.map +1 -1
- package/dist/biome/recognizeDiagnostics.d.ts.map +1 -1
- package/dist/biome/recognizeDiagnostics.js +2 -1
- package/dist/biome/recognizeDiagnostics.js.map +1 -1
- package/dist/biome/recommendedRules.d.ts.map +1 -1
- package/dist/biome/recommendedRules.js +3 -2
- package/dist/biome/recommendedRules.js.map +1 -1
- package/dist/biome/report.d.ts.map +1 -1
- package/dist/biome/report.js +3 -2
- package/dist/biome/report.js.map +1 -1
- package/dist/biome/syntax.d.ts +0 -1
- package/dist/biome/syntax.d.ts.map +1 -1
- package/dist/biome/syntax.js +0 -9
- package/dist/biome/syntax.js.map +1 -1
- package/dist/biome/withoutEntryPointImports.d.ts +32 -2
- package/dist/biome/withoutEntryPointImports.d.ts.map +1 -1
- package/dist/biome/withoutEntryPointImports.js +12 -10
- package/dist/biome/withoutEntryPointImports.js.map +1 -1
- package/dist/cli/baseline.d.ts.map +1 -1
- package/dist/cli/baseline.js +3 -2
- package/dist/cli/baseline.js.map +1 -1
- package/dist/cli/fix.d.ts.map +1 -1
- package/dist/cli/fix.js +3 -2
- package/dist/cli/fix.js.map +1 -1
- package/dist/cli/fixRule.d.ts.map +1 -1
- package/dist/cli/fixRule.js +4 -3
- package/dist/cli/fixRule.js.map +1 -1
- package/dist/cli/lint.d.ts.map +1 -1
- package/dist/cli/lint.js +2 -2
- package/dist/cli/lint.js.map +1 -1
- package/dist/cli/migrateBaseline.d.ts.map +1 -1
- package/dist/cli/migrateBaseline.js +3 -2
- package/dist/cli/migrateBaseline.js.map +1 -1
- package/dist/cli/migrateExceptions.d.ts.map +1 -1
- package/dist/cli/migrateExceptions.js +3 -2
- package/dist/cli/migrateExceptions.js.map +1 -1
- package/dist/config/globs.d.ts.map +1 -1
- package/dist/config/globs.js +1 -5
- package/dist/config/globs.js.map +1 -1
- package/dist/config/load.d.ts +2 -2
- package/dist/config/load.d.ts.map +1 -1
- package/dist/config/load.js +6 -36
- package/dist/config/load.js.map +1 -1
- package/dist/domEnvironment.config.js +1 -1
- package/dist/domEnvironment.config.js.map +1 -1
- package/dist/engine/session.d.ts.map +1 -1
- package/dist/engine/session.js +3 -2
- package/dist/engine/session.js.map +1 -1
- package/dist/exceptions/biomeFindings.d.ts +1 -1
- package/dist/exceptions/biomeFindings.d.ts.map +1 -1
- package/dist/exceptions/biomeFindings.js +10 -6
- package/dist/exceptions/biomeFindings.js.map +1 -1
- package/dist/hooks/install.d.ts.map +1 -1
- package/dist/hooks/install.js +4 -2
- package/dist/hooks/install.js.map +1 -1
- package/dist/hooks/location.d.ts.map +1 -1
- package/dist/hooks/location.js +3 -2
- package/dist/hooks/location.js.map +1 -1
- package/dist/hooks/preCommit.d.ts.map +1 -1
- package/dist/hooks/preCommit.js +3 -2
- package/dist/hooks/preCommit.js.map +1 -1
- package/dist/hooks/setup.d.ts.map +1 -1
- package/dist/hooks/setup.js +3 -2
- package/dist/hooks/setup.js.map +1 -1
- package/dist/hooks/status.d.ts.map +1 -1
- package/dist/hooks/status.js +5 -15
- package/dist/hooks/status.js.map +1 -1
- package/dist/hooks/uninstall.d.ts.map +1 -1
- package/dist/hooks/uninstall.js +3 -2
- package/dist/hooks/uninstall.js.map +1 -1
- package/dist/inventory/collect.js +2 -2
- package/dist/inventory/collect.js.map +1 -1
- package/dist/inventory/filesystem.d.ts.map +1 -1
- package/dist/inventory/filesystem.js +3 -2
- package/dist/inventory/filesystem.js.map +1 -1
- package/dist/inventory/ignoreScope.d.ts +2 -2
- package/dist/inventory/ignoreScope.d.ts.map +1 -1
- package/dist/inventory/ignoreScope.js +2 -2
- package/dist/inventory/ignoreScope.js.map +1 -1
- package/dist/inventory/shadcnFolders.d.ts.map +1 -1
- package/dist/inventory/shadcnFolders.js +4 -2
- package/dist/inventory/shadcnFolders.js.map +1 -1
- package/dist/inventory/trackedPaths.d.ts.map +1 -1
- package/dist/inventory/trackedPaths.js +4 -2
- package/dist/inventory/trackedPaths.js.map +1 -1
- package/dist/naming/packageLayout.d.ts +2 -1
- package/dist/naming/packageLayout.d.ts.map +1 -1
- package/dist/naming/packageLayout.js +4 -6
- package/dist/naming/packageLayout.js.map +1 -1
- package/dist/naming/testName.d.ts +1 -1
- package/dist/naming/testName.d.ts.map +1 -1
- package/dist/naming/testName.js +1 -1
- package/dist/naming/testName.js.map +1 -1
- package/dist/rules/biome.d.ts +1 -8
- package/dist/rules/biome.d.ts.map +1 -1
- package/dist/rules/biome.js +6 -15
- package/dist/rules/biome.js.map +1 -1
- package/dist/rules/builtIn.d.ts +2 -2
- package/dist/rules/builtIn.d.ts.map +1 -1
- package/dist/rules/builtIn.js +12 -0
- package/dist/rules/builtIn.js.map +1 -1
- package/dist/rules/effect/adapterImports.d.ts +2 -0
- package/dist/rules/effect/adapterImports.d.ts.map +1 -0
- package/dist/rules/effect/adapterImports.js +9 -0
- package/dist/rules/effect/adapterImports.js.map +1 -0
- package/dist/rules/effect/program.d.ts +1 -1
- package/dist/rules/effect/program.d.ts.map +1 -1
- package/dist/rules/effect/program.js +2 -2
- package/dist/rules/effect/program.js.map +1 -1
- package/dist/rules/effect/serviceIds.d.ts +2 -0
- package/dist/rules/effect/serviceIds.d.ts.map +1 -0
- package/dist/rules/effect/serviceIds.js +9 -0
- package/dist/rules/effect/serviceIds.js.map +1 -0
- package/dist/rules/effect/sharedErrorClasses.d.ts +2 -0
- package/dist/rules/effect/sharedErrorClasses.d.ts.map +1 -0
- package/dist/rules/effect/sharedErrorClasses.js +9 -0
- package/dist/rules/effect/sharedErrorClasses.js.map +1 -0
- package/dist/rules/files/folderNames.d.ts.map +1 -1
- package/dist/rules/files/folderNames.js +7 -7
- package/dist/rules/files/folderNames.js.map +1 -1
- package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
- package/dist/rules/files/namedAfterExport.js +6 -6
- package/dist/rules/files/namedAfterExport.js.map +1 -1
- package/dist/rules/files/otherNames.d.ts.map +1 -1
- package/dist/rules/files/otherNames.js +7 -7
- package/dist/rules/files/otherNames.js.map +1 -1
- package/dist/rules/files/packageImports.d.ts +2 -1
- package/dist/rules/files/packageImports.d.ts.map +1 -1
- package/dist/rules/files/packageImports.js +4 -3
- package/dist/rules/files/packageImports.js.map +1 -1
- package/dist/rules/files/stylesheetImporters.d.ts +2 -1
- package/dist/rules/files/stylesheetImporters.d.ts.map +1 -1
- package/dist/rules/files/stylesheetImporters.js +5 -4
- package/dist/rules/files/stylesheetImporters.js.map +1 -1
- package/dist/rules/imports/manifest.d.ts.map +1 -1
- package/dist/rules/imports/manifest.js +9 -6
- package/dist/rules/imports/manifest.js.map +1 -1
- package/dist/rules/manifestsApplication.d.ts.map +1 -1
- package/dist/rules/manifestsApplication.js +22 -22
- package/dist/rules/manifestsApplication.js.map +1 -1
- package/dist/rules/manifestsExportsShape.d.ts.map +1 -1
- package/dist/rules/manifestsExportsShape.js +32 -8
- package/dist/rules/manifestsExportsShape.js.map +1 -1
- package/dist/rules/manifestsSorted.d.ts.map +1 -1
- package/dist/rules/manifestsSorted.js +6 -5
- package/dist/rules/manifestsSorted.js.map +1 -1
- package/dist/rules/manifestsSourceFirst.d.ts.map +1 -1
- package/dist/rules/manifestsSourceFirst.js +6 -5
- package/dist/rules/manifestsSourceFirst.js.map +1 -1
- package/dist/rules/stories/adapterOnlyFakes.d.ts +2 -0
- package/dist/rules/stories/adapterOnlyFakes.d.ts.map +1 -0
- package/dist/rules/stories/adapterOnlyFakes.js +63 -0
- package/dist/rules/stories/adapterOnlyFakes.js.map +1 -0
- package/dist/rules/stories/fakeImplementation.d.ts +4 -0
- package/dist/rules/stories/fakeImplementation.d.ts.map +1 -0
- package/dist/rules/stories/fakeImplementation.js +22 -0
- package/dist/rules/stories/fakeImplementation.js.map +1 -0
- package/dist/rules/stories/fakeReplacements.d.ts +4 -0
- package/dist/rules/stories/fakeReplacements.d.ts.map +1 -0
- package/dist/rules/stories/fakeReplacements.js +71 -0
- package/dist/rules/stories/fakeReplacements.js.map +1 -0
- package/dist/rules/stories/importOrigin.js +2 -2
- package/dist/rules/stories/importOrigin.js.map +1 -1
- package/dist/rules/stories/importedChangeKeys.d.ts +2 -0
- package/dist/rules/stories/importedChangeKeys.d.ts.map +1 -0
- package/dist/rules/stories/importedChangeKeys.js +9 -0
- package/dist/rules/stories/importedChangeKeys.js.map +1 -0
- package/dist/rules/stories/pureNetImport.d.ts +4 -0
- package/dist/rules/stories/pureNetImport.d.ts.map +1 -0
- package/dist/rules/stories/pureNetImport.js +23 -0
- package/dist/rules/stories/pureNetImport.js.map +1 -0
- package/dist/rules/stories/queueReadouts.d.ts +2 -0
- package/dist/rules/stories/queueReadouts.d.ts.map +1 -0
- package/dist/rules/stories/queueReadouts.js +9 -0
- package/dist/rules/stories/queueReadouts.js.map +1 -0
- package/dist/rules/stories/unitTests.d.ts.map +1 -1
- package/dist/rules/stories/unitTests.js +4 -3
- package/dist/rules/stories/unitTests.js.map +1 -1
- package/dist/rules/suppressions/biome/weakenings.d.ts +1 -1
- package/dist/rules/suppressions/biome/weakenings.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeOverrides.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeOverrides.js +5 -5
- package/dist/rules/suppressions/biomeOverrides.js.map +1 -1
- package/dist/rules/suppressions/biomeRecommended.d.ts +1 -1
- package/dist/rules/suppressions/biomeRecommended.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeRecommended.js +12 -30
- package/dist/rules/suppressions/biomeRecommended.js.map +1 -1
- package/dist/rules/suppressions/noIgnoreDeprecations.d.ts.map +1 -1
- package/dist/rules/suppressions/noIgnoreDeprecations.js +3 -2
- package/dist/rules/suppressions/noIgnoreDeprecations.js.map +1 -1
- package/dist/rules/test-names/colocated.js +2 -2
- package/dist/rules/test-names/colocated.js.map +1 -1
- package/dist/rules/test-names/follow.js +4 -4
- package/dist/rules/test-names/follow.js.map +1 -1
- package/dist/testing/adapters/assertThat.d.ts +5 -0
- package/dist/testing/adapters/assertThat.d.ts.map +1 -0
- package/dist/testing/adapters/assertThat.js +9 -0
- package/dist/testing/adapters/assertThat.js.map +1 -0
- package/dist/testing/adapters/cli.d.ts +21 -0
- package/dist/testing/adapters/cli.d.ts.map +1 -0
- package/dist/testing/adapters/cli.js +85 -0
- package/dist/testing/adapters/cli.js.map +1 -0
- package/dist/testing/adapters/git.d.ts +14 -0
- package/dist/testing/adapters/git.d.ts.map +1 -0
- package/dist/testing/adapters/git.js +52 -0
- package/dist/testing/adapters/git.js.map +1 -0
- package/dist/testing/adapters/hookPath.d.ts +2 -0
- package/dist/testing/adapters/hookPath.d.ts.map +1 -0
- package/dist/testing/adapters/hookPath.js +6 -0
- package/dist/testing/adapters/hookPath.js.map +1 -0
- package/dist/testing/adapters/hookRepository.d.ts +25 -0
- package/dist/testing/adapters/hookRepository.d.ts.map +1 -0
- package/dist/testing/adapters/hookRepository.js +96 -0
- package/dist/testing/adapters/hookRepository.js.map +1 -0
- package/dist/testing/adapters/imports.d.ts +5 -0
- package/dist/testing/adapters/imports.d.ts.map +1 -0
- package/dist/testing/adapters/imports.js +29 -0
- package/dist/testing/adapters/imports.js.map +1 -0
- package/dist/testing/adapters/packageExports.d.ts +15 -0
- package/dist/testing/adapters/packageExports.d.ts.map +1 -0
- package/dist/testing/adapters/packageExports.js +29 -0
- package/dist/testing/adapters/packageExports.js.map +1 -0
- package/dist/testing/adapters/qualityTree.d.ts +4 -0
- package/dist/testing/adapters/qualityTree.d.ts.map +1 -0
- package/dist/testing/adapters/qualityTree.js +21 -0
- package/dist/testing/adapters/qualityTree.js.map +1 -0
- package/dist/testing/adapters/run.d.ts +4 -0
- package/dist/testing/adapters/run.d.ts.map +1 -0
- package/dist/testing/adapters/run.js +6 -0
- package/dist/testing/adapters/run.js.map +1 -0
- package/dist/testing/adapters/storySpecFiles.d.ts +7 -0
- package/dist/testing/adapters/storySpecFiles.d.ts.map +1 -0
- package/dist/testing/adapters/storySpecFiles.js +48 -0
- package/dist/testing/adapters/storySpecFiles.js.map +1 -0
- package/dist/testing/adapters/tree.d.ts +13 -0
- package/dist/testing/adapters/tree.d.ts.map +1 -0
- package/dist/testing/adapters/tree.js +42 -0
- package/dist/testing/adapters/tree.js.map +1 -0
- package/dist/testing/adapters/writePackageExports.d.ts +2 -0
- package/dist/testing/adapters/writePackageExports.d.ts.map +1 -0
- package/dist/testing/adapters/writePackageExports.js +9 -0
- package/dist/testing/adapters/writePackageExports.js.map +1 -0
- package/dist/testing/ruleStory.d.ts +28 -0
- package/dist/testing/ruleStory.d.ts.map +1 -0
- package/dist/testing/ruleStory.js +115 -0
- package/dist/testing/ruleStory.js.map +1 -0
- package/dist/unitIoGuard.config.js +1 -1
- package/dist/unitIoGuard.config.js.map +1 -1
- package/package.json +8 -2
- package/src/{rules/suppressions → adapters}/biome/configs.ts +2 -2
- package/src/adapters/biome/presetConfig.ts +34 -0
- package/src/adapters/biome/rootConfig.ts +19 -0
- package/src/adapters/biome/run.ts +1 -1
- package/src/adapters/biome/syntaxOf.ts +12 -0
- package/src/adapters/biome/withExceptionConfig.ts +45 -0
- package/src/adapters/changeKeyApi.ts +62 -0
- package/src/adapters/changeKeyFindings.ts +96 -0
- package/src/adapters/changeKeyLiterals.ts +60 -0
- package/src/adapters/executable.ts +14 -0
- package/src/adapters/ignore.ts +16 -0
- package/src/adapters/imports/fakeReferences.ts +115 -0
- package/src/adapters/imports/fakeTargets.ts +21 -0
- package/src/adapters/outsideImportFindings.ts +98 -0
- package/src/adapters/queueReadoutFindings.ts +37 -0
- package/src/adapters/queueTestingOrigin.ts +113 -0
- package/src/adapters/readConfig.ts +42 -0
- package/src/adapters/serviceIdFindings.ts +80 -0
- package/src/adapters/sharedErrorFindings.ts +84 -0
- package/src/adapters/sharedErrorModules.ts +81 -0
- package/src/adapters/testProjects.ts +18 -2
- package/src/appTestConfig.ts +1 -1
- package/src/baseline/cleanupMergeFiles.ts +4 -2
- package/src/baseline/shards.ts +6 -2
- package/src/biome/exceptionConfig.ts +0 -43
- package/src/biome/recognizeDiagnostics.ts +2 -1
- package/src/biome/recommendedRules.ts +4 -2
- package/src/biome/report.ts +4 -2
- package/src/biome/syntax.ts +0 -10
- package/src/biome/withoutEntryPointImports.ts +15 -10
- package/src/cli/baseline.ts +4 -2
- package/src/cli/fix.ts +4 -2
- package/src/cli/fixRule.ts +5 -3
- package/src/cli/lint.ts +3 -2
- package/src/cli/migrateBaseline.ts +4 -2
- package/src/cli/migrateExceptions.ts +4 -2
- package/src/config/globs.ts +1 -6
- package/src/config/load.ts +8 -38
- package/src/domEnvironment.config.ts +1 -1
- package/src/engine/session.ts +4 -2
- package/src/exceptions/biomeFindings.ts +11 -10
- package/src/hooks/install.ts +6 -2
- package/src/hooks/location.ts +4 -2
- package/src/hooks/preCommit.ts +4 -2
- package/src/hooks/setup.ts +4 -2
- package/src/hooks/status.ts +7 -15
- package/src/hooks/uninstall.ts +4 -2
- package/src/inventory/collect.ts +2 -2
- package/src/inventory/filesystem.ts +4 -2
- package/src/inventory/ignoreScope.ts +3 -3
- package/src/inventory/shadcnFolders.ts +6 -2
- package/src/inventory/trackedPaths.ts +6 -2
- package/src/naming/packageLayout.ts +14 -7
- package/src/naming/testName.ts +1 -1
- package/src/rules/biome.ts +6 -23
- package/src/rules/builtIn.ts +12 -0
- package/src/rules/effect/adapterImports.ts +10 -0
- package/src/rules/effect/program.ts +2 -2
- package/src/rules/effect/serviceIds.ts +10 -0
- package/src/rules/effect/sharedErrorClasses.ts +10 -0
- package/src/rules/files/folderNames.ts +19 -18
- package/src/rules/files/namedAfterExport.ts +10 -9
- package/src/rules/files/otherNames.ts +17 -16
- package/src/rules/files/packageImports.ts +14 -4
- package/src/rules/files/stylesheetImporters.ts +13 -6
- package/src/rules/imports/manifest.ts +14 -8
- package/src/rules/manifestsApplication.ts +44 -33
- package/src/rules/manifestsExportsShape.ts +45 -15
- package/src/rules/manifestsSorted.ts +16 -11
- package/src/rules/manifestsSourceFirst.ts +22 -17
- package/src/rules/stories/adapterOnlyFakes.ts +66 -0
- package/src/rules/stories/fakeImplementation.ts +23 -0
- package/src/rules/stories/fakeReplacements.ts +74 -0
- package/src/rules/stories/importOrigin.ts +2 -2
- package/src/rules/stories/importedChangeKeys.ts +10 -0
- package/src/rules/stories/pureNetImport.ts +29 -0
- package/src/rules/stories/queueReadouts.ts +9 -0
- package/src/rules/stories/unitTests.ts +6 -3
- package/src/rules/suppressions/biome/weakenings.ts +1 -1
- package/src/rules/suppressions/biomeOverrides.ts +17 -16
- package/src/rules/suppressions/biomeRecommended.ts +13 -32
- package/src/rules/suppressions/noIgnoreDeprecations.ts +4 -2
- package/src/rules/test-names/colocated.ts +2 -2
- package/src/rules/test-names/follow.ts +4 -4
- package/src/testing/adapters/assertThat.ts +12 -0
- package/src/testing/adapters/cli.ts +105 -0
- package/src/testing/adapters/git.ts +62 -0
- package/src/testing/adapters/hookPath.ts +6 -0
- package/src/testing/adapters/hookRepository.ts +134 -0
- package/src/testing/adapters/imports.ts +35 -0
- package/src/testing/adapters/packageExports.ts +37 -0
- package/src/testing/adapters/qualityTree.ts +26 -0
- package/src/testing/adapters/run.ts +7 -0
- package/src/testing/adapters/storySpecFiles.ts +54 -0
- package/src/testing/adapters/tree.ts +55 -0
- package/src/testing/adapters/writePackageExports.ts +9 -0
- package/src/testing/ruleStory.ts +139 -0
- package/src/unitIoGuard.config.ts +1 -1
- package/dist/biome/relocateConfig.d.ts.map +0 -1
- package/dist/biome/relocateConfig.js.map +0 -1
- package/dist/rules/suppressions/biome/configs.d.ts.map +0 -1
- package/dist/rules/suppressions/biome/configs.js.map +0 -1
- package/dist/rules/suppressions/biome/resolvePackage.d.ts.map +0 -1
- package/dist/rules/suppressions/biome/resolvePackage.js.map +0 -1
- /package/dist/{biome → adapters/biome}/relocateConfig.d.ts +0 -0
- /package/dist/{biome → adapters/biome}/relocateConfig.js +0 -0
- /package/dist/{rules/suppressions → adapters}/biome/resolvePackage.d.ts +0 -0
- /package/dist/{rules/suppressions → adapters}/biome/resolvePackage.js +0 -0
- /package/src/{biome → adapters/biome}/relocateConfig.ts +0 -0
- /package/src/{rules/suppressions → adapters}/biome/resolvePackage.ts +0 -0
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
-
import { Order, Schema } from "effect";
|
|
3
|
-
import
|
|
2
|
+
import { Effect, Order, Schema } from "effect";
|
|
3
|
+
import { type IgnoreMatcher, ignorePatterns } from "#adapters/ignore.ts";
|
|
4
4
|
import { GlobDeclarations, globPatterns, validateGlobs } from "#config/globs.ts";
|
|
5
5
|
import { nativeNames } from "#naming/nativeNames.ts";
|
|
6
6
|
import { packageLayout } from "#naming/packageLayout.ts";
|
|
@@ -50,11 +50,11 @@ function groupMessage(name: string): string | undefined {
|
|
|
50
50
|
}
|
|
51
51
|
|
|
52
52
|
interface Context {
|
|
53
|
-
readonly content:
|
|
53
|
+
readonly content: IgnoreMatcher;
|
|
54
54
|
readonly names: ReadonlyMap<string, string>;
|
|
55
55
|
readonly native: ReadonlySet<string>;
|
|
56
56
|
readonly stems: ReadonlySet<string>;
|
|
57
|
-
readonly toolOwned:
|
|
57
|
+
readonly toolOwned: IgnoreMatcher;
|
|
58
58
|
}
|
|
59
59
|
|
|
60
60
|
function messageFor(folder: string, context: Context): string | undefined {
|
|
@@ -73,20 +73,21 @@ function messageFor(folder: string, context: Context): string | undefined {
|
|
|
73
73
|
}
|
|
74
74
|
|
|
75
75
|
export const folderNames = defineRule({
|
|
76
|
-
check:
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
|
|
83
|
-
|
|
84
|
-
|
|
85
|
-
|
|
86
|
-
|
|
87
|
-
|
|
88
|
-
|
|
89
|
-
|
|
76
|
+
check: ({ files, options, readText }) =>
|
|
77
|
+
Effect.gen(function* () {
|
|
78
|
+
const layout = yield* packageLayout({ files, readText });
|
|
79
|
+
const context: Context = {
|
|
80
|
+
content: ignorePatterns([...globPatterns(options.content)]),
|
|
81
|
+
names: layout.names,
|
|
82
|
+
native: nativeNames(files).folders,
|
|
83
|
+
stems: stemsIn(files),
|
|
84
|
+
toolOwned: ignorePatterns([...globPatterns(options.toolOwned)]),
|
|
85
|
+
};
|
|
86
|
+
return foldersIn(files).flatMap((folder): readonly Finding[] => {
|
|
87
|
+
const message = messageFor(folder, context);
|
|
88
|
+
return message === undefined ? [] : [{ file: folder, message }];
|
|
89
|
+
});
|
|
90
|
+
}),
|
|
90
91
|
description:
|
|
91
92
|
"A package folder is named after its package, a module folder after its main file, a content folder in snake_case and every other folder in kebab-case.",
|
|
92
93
|
id: "files/folder-names",
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
-
import { Schema } from "effect";
|
|
3
|
-
import
|
|
2
|
+
import { Effect, Schema } from "effect";
|
|
3
|
+
import { ignorePatterns } from "#adapters/ignore.ts";
|
|
4
4
|
import { GlobDeclarations, globPatterns, validateGlobs } from "#config/globs.ts";
|
|
5
5
|
import { exportFits } from "#naming/exportFits.ts";
|
|
6
6
|
import { mainExport } from "#naming/mainExport.ts";
|
|
@@ -89,13 +89,14 @@ function findingsOf(file: SourceFile, layout: PackageLayout): readonly Finding[]
|
|
|
89
89
|
}
|
|
90
90
|
|
|
91
91
|
export const namedAfterExport = defineRule({
|
|
92
|
-
check:
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
92
|
+
check: ({ files, options, readText, sources }) =>
|
|
93
|
+
Effect.gen(function* () {
|
|
94
|
+
const layout = yield* packageLayout({ files, readText });
|
|
95
|
+
const toolOwned = ignorePatterns([...DEFAULT_TOOL_OWNED, ...globPatterns(options.toolOwned)]);
|
|
96
|
+
return sources
|
|
97
|
+
.filter((file) => !(TEST.test(file.path) || isMigrationFile(file.path) || toolOwned.ignores(file.path)))
|
|
98
|
+
.flatMap((file) => findingsOf(file, layout));
|
|
99
|
+
}),
|
|
99
100
|
description:
|
|
100
101
|
"A file is named after its main export or a module-level constant, including a private constant, with its folders as the prefix; module client/admin and server/admin files may repeat names from above the admin folder. A file of several exports is a camelCase topic file, and a script is kebab-case. Rename the file or the export; nothing renames them for you.",
|
|
101
102
|
id: "files/named-after-export",
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
-
import { Schema } from "effect";
|
|
3
|
-
import
|
|
2
|
+
import { Effect, Schema } from "effect";
|
|
3
|
+
import { type IgnoreMatcher, ignorePatterns } from "#adapters/ignore.ts";
|
|
4
4
|
import { GlobDeclarations, globPatterns, validateGlobs } from "#config/globs.ts";
|
|
5
5
|
import { nativeNames } from "#naming/nativeNames.ts";
|
|
6
6
|
import { CAMEL, KEBAB } from "#naming/words.ts";
|
|
@@ -54,10 +54,10 @@ function stylesheetMessage(path: string, stem: string, importedBy: readonly stri
|
|
|
54
54
|
}
|
|
55
55
|
|
|
56
56
|
interface Context {
|
|
57
|
-
readonly content:
|
|
57
|
+
readonly content: IgnoreMatcher;
|
|
58
58
|
readonly native: ReturnType<typeof nativeNames>;
|
|
59
59
|
readonly stylesheets: ReadonlyMap<string, readonly string[]>;
|
|
60
|
-
readonly toolOwned:
|
|
60
|
+
readonly toolOwned: IgnoreMatcher;
|
|
61
61
|
}
|
|
62
62
|
|
|
63
63
|
function messageFor(path: string, context: Context): string | undefined {
|
|
@@ -87,18 +87,19 @@ function messageFor(path: string, context: Context): string | undefined {
|
|
|
87
87
|
}
|
|
88
88
|
|
|
89
89
|
export const otherNames = defineRule({
|
|
90
|
-
check:
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
90
|
+
check: ({ files, options, readText, sources }) =>
|
|
91
|
+
Effect.gen(function* () {
|
|
92
|
+
const context: Context = {
|
|
93
|
+
content: ignorePatterns([...globPatterns(options.content)]),
|
|
94
|
+
native: nativeNames(files),
|
|
95
|
+
stylesheets: yield* stylesheetImporters({ files, readText, sources }),
|
|
96
|
+
toolOwned: ignorePatterns([...DEFAULT_TOOL_OWNED, ...globPatterns(options.toolOwned)]),
|
|
97
|
+
};
|
|
98
|
+
return files.flatMap((path): readonly Finding[] => {
|
|
99
|
+
const message = messageFor(path, context);
|
|
100
|
+
return message === undefined ? [] : [{ file: path, message }];
|
|
101
|
+
});
|
|
102
|
+
}),
|
|
102
103
|
description:
|
|
103
104
|
"Documents, data, assets and GritQL files are kebab-case, a stylesheet that one component imports is named after it, a Prisma schema is camelCase and content is snake_case.",
|
|
104
105
|
id: "files/other-names",
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
2
3
|
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
3
4
|
import type { RuleInputs } from "#rule.ts";
|
|
4
5
|
|
|
@@ -38,10 +39,19 @@ function matched(imports: unknown, specifier: string): readonly string[] {
|
|
|
38
39
|
return targetsIn(best.value).map((target) => target.replaceAll("*", star));
|
|
39
40
|
}
|
|
40
41
|
|
|
41
|
-
export
|
|
42
|
+
export const packageImports = Effect.fn("Files.packageImports")(function* ({
|
|
43
|
+
files,
|
|
44
|
+
readText,
|
|
45
|
+
}: Pick<RuleInputs, "files" | "readText">): Effect.fn.Return<PackageImports> {
|
|
42
46
|
const directories = files.filter((path) => posix.basename(path) === MANIFEST).map((path) => posix.dirname(path));
|
|
43
|
-
const manifests =
|
|
44
|
-
directories
|
|
47
|
+
const manifests = yield* Effect.forEach(
|
|
48
|
+
directories,
|
|
49
|
+
(directory) =>
|
|
50
|
+
Effect.map(
|
|
51
|
+
Effect.promise(() => readPackageManifest(readText, posix.join(directory, MANIFEST))),
|
|
52
|
+
(manifest) => ({ directory, imports: manifest?.imports }),
|
|
53
|
+
),
|
|
54
|
+
{ concurrency: "unbounded" },
|
|
45
55
|
);
|
|
46
56
|
const deepestFirst = manifests.toSorted((left, right) => right.directory.length - left.directory.length);
|
|
47
57
|
const present = new Set(files);
|
|
@@ -54,4 +64,4 @@ export async function packageImports({ files, readText }: Pick<RuleInputs, "file
|
|
|
54
64
|
.map((target) => posix.normalize(posix.join(owner.directory, target)))
|
|
55
65
|
.find((path) => present.has(path));
|
|
56
66
|
};
|
|
57
|
-
}
|
|
67
|
+
});
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
2
3
|
import ts from "typescript";
|
|
3
4
|
import type { RuleInputs, SourceFile } from "#rule.ts";
|
|
4
5
|
import { parse } from "#rules/parse.ts";
|
|
@@ -41,13 +42,19 @@ function resolver(aliases: PackageImports, present: ReadonlySet<string>, fromSty
|
|
|
41
42
|
};
|
|
42
43
|
}
|
|
43
44
|
|
|
44
|
-
export
|
|
45
|
+
export const stylesheetImporters = Effect.fn("Files.stylesheetImporters")(function* (
|
|
45
46
|
inputs: Pick<RuleInputs, "files" | "readText" | "sources">,
|
|
46
|
-
):
|
|
47
|
+
): Effect.fn.Return<ReadonlyMap<string, readonly string[]>> {
|
|
47
48
|
const present = new Set(inputs.files);
|
|
48
|
-
const aliases =
|
|
49
|
-
const stylesheets =
|
|
50
|
-
inputs.files.filter((path) => STYLESHEET.test(path))
|
|
49
|
+
const aliases = yield* packageImports(inputs);
|
|
50
|
+
const stylesheets = yield* Effect.forEach(
|
|
51
|
+
inputs.files.filter((path) => STYLESHEET.test(path)),
|
|
52
|
+
(path) =>
|
|
53
|
+
Effect.map(
|
|
54
|
+
Effect.promise(() => inputs.readText(path)),
|
|
55
|
+
(text) => ({ path, text: text ?? "" }),
|
|
56
|
+
),
|
|
57
|
+
{ concurrency: "unbounded" },
|
|
51
58
|
);
|
|
52
59
|
const fromModule = resolver(aliases, present, false);
|
|
53
60
|
const fromStylesheet = resolver(aliases, present, true);
|
|
@@ -62,4 +69,4 @@ export async function stylesheetImporters(
|
|
|
62
69
|
}
|
|
63
70
|
}
|
|
64
71
|
return found;
|
|
65
|
-
}
|
|
72
|
+
});
|
|
@@ -33,26 +33,26 @@ interface ManifestDependencies {
|
|
|
33
33
|
readonly shipped: ReadonlySet<string>;
|
|
34
34
|
}
|
|
35
35
|
|
|
36
|
-
|
|
36
|
+
const manifestDependencies = Effect.fn("Imports.manifestDependencies")(function* (
|
|
37
37
|
inputs: RuleInputs,
|
|
38
38
|
owner: WorkspacePackage,
|
|
39
39
|
graph: ImportGraph,
|
|
40
40
|
workspace: ReadonlyMap<string, string>,
|
|
41
|
-
):
|
|
41
|
+
): Effect.fn.Return<ManifestDependencies> {
|
|
42
42
|
const path = posix.join(owner.directory, "package.json");
|
|
43
|
-
const manifest =
|
|
43
|
+
const manifest = yield* Effect.promise(() => readPackageManifest(inputs.readText, path));
|
|
44
44
|
if (manifest === undefined) {
|
|
45
|
-
|
|
45
|
+
return yield* Effect.die(new Error("the manifest is missing"));
|
|
46
46
|
}
|
|
47
47
|
return {
|
|
48
48
|
...bundleInputs(graph, owner, manifest, (candidate) => developmentFile(owner, candidate)),
|
|
49
49
|
application: isApplication(manifest),
|
|
50
50
|
development: new Set(dependencyNames(manifest, "devDependencies")),
|
|
51
|
-
entryPoints:
|
|
51
|
+
entryPoints: yield* Effect.promise(() => entryPointsOf(inputs, owner.directory, manifest, workspace)),
|
|
52
52
|
private: Reflect.get(manifest, "private") === true,
|
|
53
53
|
shipped: new Set(SHIPPED_FIELDS.flatMap((field) => dependencyNames(manifest, field))),
|
|
54
54
|
};
|
|
55
|
-
}
|
|
55
|
+
});
|
|
56
56
|
|
|
57
57
|
function developmentFile(owner: WorkspacePackage, path: string): boolean {
|
|
58
58
|
return isTestCode(path) || isTooling(owner.directory, path);
|
|
@@ -93,8 +93,14 @@ export const importsManifest = defineRule({
|
|
|
93
93
|
const owners = [...graph.packages, ...(root === undefined ? [] : [root])];
|
|
94
94
|
const workspace = new Map(graph.packages.map((owner) => [owner.name, owner.directory]));
|
|
95
95
|
const policies = new Map(
|
|
96
|
-
yield* Effect.
|
|
97
|
-
|
|
96
|
+
yield* Effect.forEach(
|
|
97
|
+
owners,
|
|
98
|
+
(owner) =>
|
|
99
|
+
Effect.map(manifestDependencies(inputs, owner, graph, workspace), (policy): readonly [WorkspacePackage, ManifestDependencies] => [
|
|
100
|
+
owner,
|
|
101
|
+
policy,
|
|
102
|
+
]),
|
|
103
|
+
{ concurrency: "unbounded" },
|
|
98
104
|
),
|
|
99
105
|
);
|
|
100
106
|
const runtime = new Set([...policies.values()].flatMap((policy) => [...policy.runtime]));
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { dirname, posix, relative, resolve, sep } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
2
3
|
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
3
4
|
import { pnpmWorkspaceList } from "#imports/pnpmWorkspacePatterns.ts";
|
|
4
5
|
import { workspacePackages } from "#imports/workspace.ts";
|
|
@@ -24,30 +25,34 @@ function ancestors(root: string, directory: string): readonly string[] {
|
|
|
24
25
|
return parent === start ? [start] : [start, ...ancestors(root, relative(root, parent))];
|
|
25
26
|
}
|
|
26
27
|
|
|
27
|
-
|
|
28
|
+
const nearestWorkspace = Effect.fn("Manifests.nearestWorkspace")(function* (inputs: Pick<RuleInputs, "readText" | "root">, directory: string) {
|
|
28
29
|
for (const candidate of ancestors(inputs.root, directory)) {
|
|
29
30
|
const path = posix.join(relative(inputs.root, candidate).split(sep).join("/") || ".", "pnpm-workspace.yaml");
|
|
30
|
-
const text =
|
|
31
|
+
const text = yield* Effect.promise(() => inputs.readText(path));
|
|
31
32
|
if (text !== undefined) {
|
|
32
33
|
return { path, text };
|
|
33
34
|
}
|
|
34
35
|
}
|
|
35
36
|
return undefined;
|
|
36
|
-
}
|
|
37
|
+
});
|
|
37
38
|
|
|
38
|
-
|
|
39
|
-
|
|
39
|
+
const hoistFindings = Effect.fn("Manifests.hoistFindings")(function* (
|
|
40
|
+
inputs: Pick<RuleInputs, "readText" | "root">,
|
|
41
|
+
manifestPath: string,
|
|
42
|
+
directory: string,
|
|
43
|
+
): Effect.fn.Return<readonly Finding[]> {
|
|
44
|
+
const workspace = yield* nearestWorkspace(inputs, directory);
|
|
40
45
|
const target = workspace?.path ?? posix.join(directory, "pnpm-workspace.yaml");
|
|
41
46
|
const repair = `Add \`${HOIST_LINE}\` to ${target} so the pieces platform brings resolve by their own names.`;
|
|
42
47
|
if (workspace === undefined) {
|
|
43
48
|
return [{ file: manifestPath, message: `Depends on "${PLATFORM}" without a pnpm-workspace.yaml. ${repair}`, subject: HOIST_KEY }];
|
|
44
49
|
}
|
|
45
|
-
|
|
46
|
-
|
|
47
|
-
|
|
48
|
-
} catch (cause) {
|
|
50
|
+
const parsed = yield* Effect.try({ catch: (cause) => cause, try: () => pnpmWorkspaceList(workspace.text, HOIST_KEY) }).pipe(Effect.result);
|
|
51
|
+
if (parsed._tag === "Failure") {
|
|
52
|
+
const cause = parsed.failure;
|
|
49
53
|
return [{ file: workspace.path, message: `${cause instanceof Error ? cause.message : String(cause)}. Write ${HOIST_LINE}.`, subject: HOIST_KEY }];
|
|
50
54
|
}
|
|
55
|
+
const patterns = parsed.success;
|
|
51
56
|
const included = patterns.some((pattern) => !pattern.startsWith("!") && hoists(pattern));
|
|
52
57
|
const excluded = patterns.some((pattern) => pattern.startsWith("!") && hoists(pattern.slice(1)));
|
|
53
58
|
if (included && !excluded) {
|
|
@@ -56,16 +61,18 @@ async function hoistFindings(inputs: Pick<RuleInputs, "readText" | "root">, mani
|
|
|
56
61
|
return [
|
|
57
62
|
{ file: manifestPath, message: `Depends on "${PLATFORM}", but ${workspace.path} does not hoist ${HOISTED}. ${repair}`, subject: HOIST_KEY },
|
|
58
63
|
];
|
|
59
|
-
}
|
|
64
|
+
});
|
|
60
65
|
|
|
61
|
-
|
|
66
|
+
const duplicateFindings = Effect.fn("Manifests.duplicateFindings")(function* (
|
|
62
67
|
inputs: Pick<RuleInputs, "readText">,
|
|
63
68
|
manifestPath: string,
|
|
64
69
|
directory: string,
|
|
65
70
|
manifest: unknown,
|
|
66
71
|
workspace: ReadonlyMap<string, string>,
|
|
67
|
-
):
|
|
68
|
-
const entryPoints = (
|
|
72
|
+
): Effect.fn.Return<readonly Finding[]> {
|
|
73
|
+
const entryPoints = (yield* Effect.promise(() => entryPointsOf(inputs, directory, manifest, workspace))).filter(
|
|
74
|
+
(entry) => entry.declared !== undefined,
|
|
75
|
+
);
|
|
69
76
|
return DEPENDENCY_FIELDS.flatMap((field) =>
|
|
70
77
|
dependencyNames(manifest, field).flatMap((name) => {
|
|
71
78
|
const entry = entryPoints.find((candidate) => candidate.provides.has(name));
|
|
@@ -80,28 +87,32 @@ async function duplicateFindings(
|
|
|
80
87
|
];
|
|
81
88
|
}),
|
|
82
89
|
);
|
|
83
|
-
}
|
|
90
|
+
});
|
|
84
91
|
|
|
85
92
|
export const manifestsApplication = defineRule({
|
|
86
|
-
check:
|
|
87
|
-
|
|
88
|
-
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
|
|
93
|
+
check: (inputs) =>
|
|
94
|
+
Effect.gen(function* () {
|
|
95
|
+
const packages = yield* Effect.promise(() => workspacePackages(inputs));
|
|
96
|
+
const workspace = new Map(packages.map((owner) => [owner.name, owner.directory]));
|
|
97
|
+
const directories = [".", ...packages.map((owner) => owner.directory)];
|
|
98
|
+
const findings = yield* Effect.forEach(
|
|
99
|
+
directories,
|
|
100
|
+
(directory) =>
|
|
101
|
+
Effect.gen(function* () {
|
|
102
|
+
const manifestPath = posix.join(directory, "package.json");
|
|
103
|
+
const manifest = yield* Effect.promise(() => readPackageManifest(inputs.readText, manifestPath));
|
|
104
|
+
if (!isApplication(manifest)) {
|
|
105
|
+
return [];
|
|
106
|
+
}
|
|
107
|
+
return [
|
|
108
|
+
...(yield* hoistFindings(inputs, manifestPath, directory)),
|
|
109
|
+
...(yield* duplicateFindings(inputs, manifestPath, directory, manifest, workspace)),
|
|
110
|
+
];
|
|
111
|
+
}),
|
|
112
|
+
{ concurrency: "unbounded" },
|
|
113
|
+
);
|
|
114
|
+
return findings.flat();
|
|
115
|
+
}),
|
|
105
116
|
description: `An application, a package that depends on ${PLATFORM}, hoists ${HOISTED} in its nearest pnpm-workspace.yaml and lists no package beside the entry point that already brings it.`,
|
|
106
117
|
id: "manifests/application",
|
|
107
118
|
});
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
2
3
|
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
3
4
|
import { workspacePackages } from "#imports/workspace.ts";
|
|
4
5
|
import { defineRule, type Finding } from "#rule.ts";
|
|
@@ -64,23 +65,52 @@ function findingsIn(file: string, exports: unknown): readonly Finding[] {
|
|
|
64
65
|
];
|
|
65
66
|
}
|
|
66
67
|
|
|
68
|
+
function importFindings(file: string, imports: Readonly<Record<string, unknown>> = {}): readonly Finding[] {
|
|
69
|
+
return Object.entries(imports).flatMap(([key, value]) => {
|
|
70
|
+
if (key === "#*.ts" && value !== "./src/*.ts" && !standardPattern(PATTERN, value)) {
|
|
71
|
+
return [
|
|
72
|
+
{
|
|
73
|
+
file,
|
|
74
|
+
message:
|
|
75
|
+
'Import "#*.ts" must preserve the path from the source root. Map it to "./src/*.ts", or to source "./src/*.ts", types "./dist/*.d.ts" and default "./dist/*.js". Include subfolders in import specifiers, for example "#server/module.ts".',
|
|
76
|
+
subject: key,
|
|
77
|
+
},
|
|
78
|
+
];
|
|
79
|
+
}
|
|
80
|
+
if (key === "#test/*" && value !== "./src/test-support/*") {
|
|
81
|
+
return [
|
|
82
|
+
{
|
|
83
|
+
file,
|
|
84
|
+
message: 'Import "#test/*" must map to "./src/test-support/*". Keep test helpers under the source root’s test-support folder.',
|
|
85
|
+
subject: key,
|
|
86
|
+
},
|
|
87
|
+
];
|
|
88
|
+
}
|
|
89
|
+
return [];
|
|
90
|
+
});
|
|
91
|
+
}
|
|
92
|
+
|
|
67
93
|
export const manifestsExportsShape = defineRule({
|
|
68
|
-
check:
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
|
|
80
|
-
|
|
81
|
-
|
|
94
|
+
check: (inputs) =>
|
|
95
|
+
Effect.gen(function* () {
|
|
96
|
+
const packages = yield* Effect.promise(() => workspacePackages(inputs));
|
|
97
|
+
const files = ["package.json", ...packages.map((owner) => posix.join(owner.directory, "package.json"))];
|
|
98
|
+
const findings = yield* Effect.forEach(
|
|
99
|
+
files,
|
|
100
|
+
(file) =>
|
|
101
|
+
Effect.gen(function* () {
|
|
102
|
+
const manifest = yield* Effect.promise(() => readPackageManifest(inputs.readText, file));
|
|
103
|
+
if (file === "package.json" && manifest === undefined) {
|
|
104
|
+
return [];
|
|
105
|
+
}
|
|
106
|
+
return [...findingsIn(file, manifest?.exports), ...importFindings(file, manifest?.imports)];
|
|
107
|
+
}),
|
|
108
|
+
{ concurrency: "unbounded" },
|
|
109
|
+
);
|
|
110
|
+
return findings.flat();
|
|
111
|
+
}),
|
|
82
112
|
description:
|
|
83
|
-
"
|
|
113
|
+
"Packages export modules through one file-preserving wildcard without null blocks; declared #*.ts and #test/* imports preserve the source and test-support roots.",
|
|
84
114
|
id: "manifests/exports-shape",
|
|
85
115
|
registrable: false,
|
|
86
116
|
});
|
|
@@ -1,19 +1,24 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
1
2
|
import { manifestFiles, manifestText } from "#adapters/manifestInventory.ts";
|
|
2
3
|
import { sortingOf } from "#manifests/sorted.ts";
|
|
3
4
|
import { defineRule } from "#rule.ts";
|
|
4
5
|
|
|
5
6
|
export const manifestsSorted = defineRule({
|
|
6
|
-
check:
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
7
|
+
check: (inputs) =>
|
|
8
|
+
Effect.gen(function* () {
|
|
9
|
+
const findings = yield* Effect.forEach(
|
|
10
|
+
manifestFiles(inputs),
|
|
11
|
+
(file) =>
|
|
12
|
+
Effect.gen(function* () {
|
|
13
|
+
const text = yield* Effect.promise(() => manifestText(inputs.readText, file));
|
|
14
|
+
return text === undefined || sortingOf(text)._tag === "Sorted"
|
|
15
|
+
? []
|
|
16
|
+
: [{ file, message: "Keys are not in sort-package-json order. Run `quality fix`." }];
|
|
17
|
+
}),
|
|
18
|
+
{ concurrency: "unbounded" },
|
|
19
|
+
);
|
|
20
|
+
return findings.flat();
|
|
21
|
+
}),
|
|
17
22
|
description: "Every package.json in the repository keeps its keys in sort-package-json order. `quality fix` sorts them.",
|
|
18
23
|
id: "manifests/sorted",
|
|
19
24
|
registrable: false,
|
|
@@ -1,3 +1,4 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
1
2
|
import { manifestEntry, manifestFiles } from "#adapters/manifestInventory.ts";
|
|
2
3
|
import { defineRule, type Finding } from "#rule.ts";
|
|
3
4
|
import { itemsOf, type Json, member, parseJsonc } from "#rules/suppressions/biome/json.ts";
|
|
@@ -24,23 +25,27 @@ function misplaced(path: string, field: string, value: unknown, node: Json | und
|
|
|
24
25
|
}
|
|
25
26
|
|
|
26
27
|
export const manifestsSourceFirst = defineRule({
|
|
27
|
-
check:
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
28
|
+
check: (inputs) =>
|
|
29
|
+
Effect.gen(function* () {
|
|
30
|
+
const findings = yield* Effect.forEach(
|
|
31
|
+
manifestFiles(inputs),
|
|
32
|
+
(path) =>
|
|
33
|
+
Effect.gen(function* () {
|
|
34
|
+
const entry = yield* Effect.promise(() => manifestEntry(inputs.readText, path));
|
|
35
|
+
if (entry === undefined) {
|
|
36
|
+
return [];
|
|
37
|
+
}
|
|
38
|
+
const { manifest, text } = entry;
|
|
39
|
+
const parsed = parseJsonc(path, text);
|
|
40
|
+
const location = parsed._tag === "Parsed" ? parsed.json : undefined;
|
|
41
|
+
return ["exports", "imports"].flatMap((field) =>
|
|
42
|
+
misplaced(path, field, field === "exports" ? manifest.exports : manifest.imports, member(location, field)),
|
|
43
|
+
);
|
|
44
|
+
}),
|
|
45
|
+
{ concurrency: "unbounded" },
|
|
46
|
+
);
|
|
47
|
+
return findings.flat();
|
|
48
|
+
}),
|
|
44
49
|
description:
|
|
45
50
|
'Every package.json condition block that names the "source" condition lists it first in exports and imports, so TypeScript reads the sources whether or not built output exists.',
|
|
46
51
|
id: "manifests/source-first",
|
|
@@ -0,0 +1,66 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import { fakeApi, fakeReferences } from "#adapters/imports/fakeReferences.ts";
|
|
4
|
+
import { type FakeModule, fakeTargets } from "#adapters/imports/fakeTargets.ts";
|
|
5
|
+
import { importGraph } from "#imports/graph.ts";
|
|
6
|
+
import { isTestCode } from "#naming/testName.ts";
|
|
7
|
+
import { defineRule, type Finding } from "#rule.ts";
|
|
8
|
+
import { fakeReplacements } from "./fakeReplacements.ts";
|
|
9
|
+
import { storyProgram } from "./program.ts";
|
|
10
|
+
|
|
11
|
+
function internal(path: string): boolean {
|
|
12
|
+
return !path.split("/").includes("adapters");
|
|
13
|
+
}
|
|
14
|
+
|
|
15
|
+
function message(target: string): string {
|
|
16
|
+
return `Replaces owned code in ${target} outside adapters/. Exercise the real module or service; fake only adapters/ or outside libraries and platform globals. Delete a test whose failure can only be shown by faking internals.`;
|
|
17
|
+
}
|
|
18
|
+
|
|
19
|
+
export const adapterOnlyFakes = defineRule({
|
|
20
|
+
check: Effect.fn("Stories.check")(function* (inputs) {
|
|
21
|
+
const graph = yield* importGraph(inputs);
|
|
22
|
+
const program = storyProgram(inputs, graph);
|
|
23
|
+
const references = fakeReferences(program, inputs.root);
|
|
24
|
+
const modules: FakeModule[] = [];
|
|
25
|
+
const findings: Finding[] = [];
|
|
26
|
+
for (const file of inputs.sources.filter((candidate) => isTestCode(candidate.path))) {
|
|
27
|
+
const source = references.source(file.path);
|
|
28
|
+
if (source === undefined) {
|
|
29
|
+
continue;
|
|
30
|
+
}
|
|
31
|
+
const syntax = source;
|
|
32
|
+
function line(node: ts.Node): number {
|
|
33
|
+
return syntax.getLineAndCharacterOfPosition(node.getStart(syntax)).line + 1;
|
|
34
|
+
}
|
|
35
|
+
function visit(node: ts.Node): void {
|
|
36
|
+
if (ts.isCallExpression(node) && ["vi.mock", "vi.doMock"].includes(fakeApi(references.reference(node.expression)) ?? "")) {
|
|
37
|
+
const argument = node.arguments[0];
|
|
38
|
+
const name =
|
|
39
|
+
argument !== undefined && ts.isCallExpression(argument) && argument.expression.kind === ts.SyntaxKind.ImportKeyword
|
|
40
|
+
? argument.arguments[0]
|
|
41
|
+
: argument;
|
|
42
|
+
if (name !== undefined && ts.isStringLiteralLike(name)) {
|
|
43
|
+
modules.push({ file: file.path, line: line(node), specifier: name.text });
|
|
44
|
+
}
|
|
45
|
+
}
|
|
46
|
+
ts.forEachChild(node, visit);
|
|
47
|
+
}
|
|
48
|
+
visit(source);
|
|
49
|
+
for (const node of fakeReplacements(source, references)) {
|
|
50
|
+
const target = references.owner(node, true);
|
|
51
|
+
if (target !== undefined && internal(target)) {
|
|
52
|
+
findings.push({ file: file.path, line: line(node), message: message(target) });
|
|
53
|
+
}
|
|
54
|
+
}
|
|
55
|
+
}
|
|
56
|
+
return [
|
|
57
|
+
...findings,
|
|
58
|
+
...fakeTargets(inputs, modules)
|
|
59
|
+
.filter(({ target }) => internal(target))
|
|
60
|
+
.map(({ file, line, target }) => ({ file, line, message: message(target) })),
|
|
61
|
+
];
|
|
62
|
+
}),
|
|
63
|
+
description: "Tests fake only adapters, outside libraries and platform globals; owned modules and services run for real.",
|
|
64
|
+
id: "tests/adapter-only-fakes",
|
|
65
|
+
registrable: false,
|
|
66
|
+
});
|