@shivaedev/quality 0.54.0 → 0.55.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (106) hide show
  1. package/CHANGELOG.md +25 -0
  2. package/README.md +6 -4
  3. package/dist/adapters/compileCache.config.d.ts +2 -0
  4. package/dist/adapters/compileCache.config.d.ts.map +1 -0
  5. package/dist/adapters/compileCache.config.js +3 -0
  6. package/dist/adapters/compileCache.config.js.map +1 -0
  7. package/dist/adapters/manifestInventory.d.ts.map +1 -1
  8. package/dist/adapters/manifestInventory.js +3 -1
  9. package/dist/adapters/manifestInventory.js.map +1 -1
  10. package/dist/adapters/manifestReader.d.ts +2 -2
  11. package/dist/adapters/manifestReader.d.ts.map +1 -1
  12. package/dist/adapters/manifestReader.js +2 -1
  13. package/dist/adapters/manifestReader.js.map +1 -1
  14. package/dist/adapters/testProjects.d.ts.map +1 -1
  15. package/dist/adapters/testProjects.js +1 -0
  16. package/dist/adapters/testProjects.js.map +1 -1
  17. package/dist/biome/report.d.ts +2 -1
  18. package/dist/biome/report.d.ts.map +1 -1
  19. package/dist/biome/report.js +11 -5
  20. package/dist/biome/report.js.map +1 -1
  21. package/dist/cli/lint.d.ts.map +1 -1
  22. package/dist/cli/lint.js +3 -1
  23. package/dist/cli/lint.js.map +1 -1
  24. package/dist/config.d.ts +5 -5
  25. package/dist/config.d.ts.map +1 -1
  26. package/dist/config.js.map +1 -1
  27. package/dist/engine/runRules.d.ts.map +1 -1
  28. package/dist/engine/runRules.js +29 -6
  29. package/dist/engine/runRules.js.map +1 -1
  30. package/dist/engine/session.d.ts +3 -2
  31. package/dist/engine/session.d.ts.map +1 -1
  32. package/dist/engine/session.js +9 -6
  33. package/dist/engine/session.js.map +1 -1
  34. package/dist/exceptions/biomeFindings.d.ts +3 -0
  35. package/dist/exceptions/biomeFindings.d.ts.map +1 -1
  36. package/dist/exceptions/biomeFindings.js +21 -0
  37. package/dist/exceptions/biomeFindings.js.map +1 -1
  38. package/dist/hooks/preCommit.js +1 -1
  39. package/dist/hooks/preCommit.js.map +1 -1
  40. package/dist/imports/extract.d.ts +2 -1
  41. package/dist/imports/extract.d.ts.map +1 -1
  42. package/dist/imports/extract.js +11 -10
  43. package/dist/imports/extract.js.map +1 -1
  44. package/dist/imports/graph.d.ts +2 -1
  45. package/dist/imports/graph.d.ts.map +1 -1
  46. package/dist/imports/graph.js +4 -2
  47. package/dist/imports/graph.js.map +1 -1
  48. package/dist/imports/projects.d.ts +4 -1
  49. package/dist/imports/projects.d.ts.map +1 -1
  50. package/dist/imports/projects.js +42 -17
  51. package/dist/imports/projects.js.map +1 -1
  52. package/dist/imports/resolve.d.ts.map +1 -1
  53. package/dist/imports/resolve.js +5 -3
  54. package/dist/imports/resolve.js.map +1 -1
  55. package/dist/manifests/sorted.d.ts.map +1 -1
  56. package/dist/manifests/sorted.js +1 -1
  57. package/dist/manifests/sorted.js.map +1 -1
  58. package/dist/rules/builtIn.d.ts +1 -1
  59. package/dist/rules/builtIn.d.ts.map +1 -1
  60. package/dist/rules/builtIn.js +2 -0
  61. package/dist/rules/builtIn.js.map +1 -1
  62. package/dist/rules/imports/resolvable.d.ts.map +1 -1
  63. package/dist/rules/imports/resolvable.js +9 -6
  64. package/dist/rules/imports/resolvable.js.map +1 -1
  65. package/dist/rules/stories/collectionOrigins.d.ts +1 -1
  66. package/dist/rules/stories/collectionOrigins.d.ts.map +1 -1
  67. package/dist/rules/stories/collectionOrigins.js.map +1 -1
  68. package/dist/rules/stories/globalRetries.d.ts +2 -0
  69. package/dist/rules/stories/globalRetries.d.ts.map +1 -0
  70. package/dist/rules/stories/globalRetries.js +45 -0
  71. package/dist/rules/stories/globalRetries.js.map +1 -0
  72. package/dist/rules/stories/importOrigin.d.ts +3 -1
  73. package/dist/rules/stories/importOrigin.d.ts.map +1 -1
  74. package/dist/rules/stories/importOrigin.js +15 -0
  75. package/dist/rules/stories/importOrigin.js.map +1 -1
  76. package/dist/rules/stories/origins.d.ts.map +1 -1
  77. package/dist/rules/stories/origins.js +14 -12
  78. package/dist/rules/stories/origins.js.map +1 -1
  79. package/dist/rules/stories/retryOption.d.ts +3 -0
  80. package/dist/rules/stories/retryOption.d.ts.map +1 -0
  81. package/dist/rules/stories/retryOption.js +37 -0
  82. package/dist/rules/stories/retryOption.js.map +1 -0
  83. package/package.json +4 -4
  84. package/src/adapters/compileCache.config.ts +3 -0
  85. package/src/adapters/manifestInventory.ts +3 -1
  86. package/src/adapters/manifestReader.ts +4 -3
  87. package/src/adapters/testProjects.ts +1 -0
  88. package/src/biome/report.ts +11 -5
  89. package/src/cli/lint.ts +3 -0
  90. package/src/config.ts +7 -5
  91. package/src/engine/runRules.ts +31 -11
  92. package/src/engine/session.ts +14 -13
  93. package/src/exceptions/biomeFindings.ts +29 -0
  94. package/src/hooks/preCommit.ts +1 -1
  95. package/src/imports/extract.ts +12 -10
  96. package/src/imports/graph.ts +7 -4
  97. package/src/imports/projects.ts +61 -27
  98. package/src/imports/resolve.ts +5 -3
  99. package/src/manifests/sorted.ts +3 -3
  100. package/src/rules/builtIn.ts +2 -0
  101. package/src/rules/imports/resolvable.ts +9 -6
  102. package/src/rules/stories/collectionOrigins.ts +13 -1
  103. package/src/rules/stories/globalRetries.ts +50 -0
  104. package/src/rules/stories/importOrigin.ts +17 -0
  105. package/src/rules/stories/origins.ts +14 -13
  106. package/src/rules/stories/retryOption.ts +41 -0
@@ -0,0 +1,45 @@
1
+ import { Effect } from "effect";
2
+ import ts from "typescript";
3
+ import { importGraph } from "#imports/graph.ts";
4
+ import { defineRule } from "#rule.ts";
5
+ import { storyOrigins } from "./origins.js";
6
+ import { retryOption } from "./retryOption.js";
7
+ import { memberName, nodesWhere } from "./syntax.js";
8
+ const BUILDERS = new Set(["each", "for", "extend", "runIf", "skipIf", "layer"]);
9
+ const MESSAGE = "Declares a test or suite retry. Remove the retry option: retries are global only and recorded by vitest-rerun, so flakes stay visible.";
10
+ function optionsOf(call, origin) {
11
+ if (origin === "story") {
12
+ return call.arguments.slice(3, 4);
13
+ }
14
+ return origin === "plain" || origin === "suite" ? call.arguments.slice(1, 3) : [];
15
+ }
16
+ export const globalRetries = defineRule({
17
+ check: (inputs) => Effect.gen(function* () {
18
+ const graph = yield* Effect.promise(() => importGraph(inputs));
19
+ const origins = storyOrigins(inputs, graph);
20
+ const retry = retryOption(origins.checker);
21
+ return inputs.sources.flatMap((file) => {
22
+ const source = origins.source(file.path);
23
+ if (source === undefined) {
24
+ return [];
25
+ }
26
+ const findings = nodesWhere(source, (node) => {
27
+ if (!ts.isCallExpression(node) || BUILDERS.has(memberName(node.expression) ?? "")) {
28
+ return false;
29
+ }
30
+ if (!node.arguments.slice(1, 4).some((argument) => retry(argument))) {
31
+ return false;
32
+ }
33
+ return optionsOf(node, origins.origin(node.expression)).some((argument) => retry(argument));
34
+ });
35
+ return findings.map((node) => ({
36
+ file: file.path,
37
+ line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1,
38
+ message: MESSAGE,
39
+ }));
40
+ });
41
+ }),
42
+ description: "Test, suite and story retries are global only and recorded by vitest-rerun; registrations declare no retry option.",
43
+ id: "tests/global-retries",
44
+ });
45
+ //# sourceMappingURL=globalRetries.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"globalRetries.js","sourceRoot":"","sources":["../../../src/rules/stories/globalRetries.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AAEtC,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAC/C,OAAO,EAAE,UAAU,EAAE,UAAU,EAAE,MAAM,aAAa,CAAC;AAErD,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,CAAC;AAChF,MAAM,OAAO,GACZ,wIAAwI,CAAC;AAE1I,SAAS,SAAS,CAAC,IAAuB,EAAE,MAAc;IACzD,IAAI,MAAM,KAAK,OAAO,EAAE,CAAC;QACxB,OAAO,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IACnC,CAAC;IACD,OAAO,MAAM,KAAK,OAAO,IAAI,MAAM,KAAK,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;AACnF,CAAC;AAED,MAAM,CAAC,MAAM,aAAa,GAAG,UAAU,CAAC;IACvC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CACjB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QACnB,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC;QAC/D,MAAM,OAAO,GAAG,YAAY,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;QAC5C,MAAM,KAAK,GAAG,WAAW,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;QAC3C,OAAO,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;YACtC,MAAM,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACzC,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;gBAC1B,OAAO,EAAE,CAAC;YACX,CAAC;YACD,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,EAAE;gBAC5C,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC;oBACnF,OAAO,KAAK,CAAC;gBACd,CAAC;gBACD,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;oBACrE,OAAO,KAAK,CAAC;gBACd,CAAC;gBACD,OAAO,SAAS,CAAC,IAAI,EAAE,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC;YAC7F,CAAC,CAAC,CAAC;YACH,OAAO,QAAQ,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;gBAC9B,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,IAAI,EAAE,MAAM,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC;gBAC1E,OAAO,EAAE,OAAO;aAChB,CAAC,CAAC,CAAC;QACL,CAAC,CAAC,CAAC;IACJ,CAAC,CAAC;IACH,WAAW,EAAE,oHAAoH;IACjI,EAAE,EAAE,sBAAsB;CAC1B,CAAC,CAAC"}
@@ -1,2 +1,4 @@
1
- export declare function importOrigin(from: string | undefined, name?: string): "factory" | "plain" | "stories" | "suite" | "vitest" | undefined;
1
+ import ts from "typescript";
2
+ export declare function importFrom(node: ts.Node): string | undefined;
3
+ export declare function importOrigin(from: string | undefined, name?: string): "effectFactory" | "factory" | "plain" | "stories" | "suite" | "vitest" | undefined;
2
4
  //# sourceMappingURL=importOrigin.d.ts.map
@@ -1 +1 @@
1
- {"version":3,"file":"importOrigin.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/importOrigin.ts"],"names":[],"mappings":"AAOA,wBAAgB,YAAY,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,EAAE,IAAI,CAAC,EAAE,MAAM,oEAYnE"}
1
+ {"version":3,"file":"importOrigin.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/importOrigin.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAE5B,wBAAgB,UAAU,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,GAAG,MAAM,GAAG,SAAS,CAO5D;AASD,wBAAgB,YAAY,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,EAAE,IAAI,CAAC,EAAE,MAAM,sFAkBnE"}
@@ -1,3 +1,12 @@
1
+ import ts from "typescript";
2
+ export function importFrom(node) {
3
+ for (let current = node; current !== undefined; current = current.parent) {
4
+ if (ts.isImportDeclaration(current) && ts.isStringLiteral(current.moduleSpecifier)) {
5
+ return current.moduleSpecifier.text;
6
+ }
7
+ }
8
+ return undefined;
9
+ }
1
10
  function moduleOrigin(from) {
2
11
  if (from === "vitest" || from === "@effect/vitest") {
3
12
  return "vitest";
@@ -5,6 +14,12 @@ function moduleOrigin(from) {
5
14
  return from === "@shivaedev/test-story" || from === "@shivaedev/test-story/server/storyKit.ts" ? "stories" : undefined;
6
15
  }
7
16
  export function importOrigin(from, name) {
17
+ if (from === "@shivaedev/test/makeEffectIt.ts" && name === "makeEffectIt") {
18
+ return "effectFactory";
19
+ }
20
+ if (from === "@shivaedev/test/it.ts" && name === "it") {
21
+ return "plain";
22
+ }
8
23
  const namespace = moduleOrigin(from);
9
24
  if (name === undefined) {
10
25
  return namespace;
@@ -1 +1 @@
1
- {"version":3,"file":"importOrigin.js","sourceRoot":"","sources":["../../../src/rules/stories/importOrigin.ts"],"names":[],"mappings":"AAAA,SAAS,YAAY,CAAC,IAAwB;IAC7C,IAAI,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,gBAAgB,EAAE,CAAC;QACpD,OAAO,QAAQ,CAAC;IACjB,CAAC;IACD,OAAO,IAAI,KAAK,uBAAuB,IAAI,IAAI,KAAK,0CAA0C,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC;AACxH,CAAC;AAED,MAAM,UAAU,YAAY,CAAC,IAAwB,EAAE,IAAa;IACnE,MAAM,SAAS,GAAG,YAAY,CAAC,IAAI,CAAC,CAAC;IACrC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,IAAI,IAAI,KAAK,UAAU,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;QACpD,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,IAAI,CAAC,IAAI,KAAK,UAAU,IAAI,IAAI,KAAK,OAAO,CAAC,IAAI,SAAS,KAAK,QAAQ,EAAE,CAAC;QACzE,OAAO,OAAO,CAAC;IAChB,CAAC;IACD,OAAO,CAAC,IAAI,KAAK,IAAI,IAAI,IAAI,KAAK,MAAM,CAAC,IAAI,SAAS,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC;AAC3F,CAAC"}
1
+ {"version":3,"file":"importOrigin.js","sourceRoot":"","sources":["../../../src/rules/stories/importOrigin.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAE5B,MAAM,UAAU,UAAU,CAAC,IAAa;IACvC,KAAK,IAAI,OAAO,GAAwB,IAAI,EAAE,OAAO,KAAK,SAAS,EAAE,OAAO,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC;QAC/F,IAAI,EAAE,CAAC,mBAAmB,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,OAAO,CAAC,eAAe,CAAC,EAAE,CAAC;YACpF,OAAO,OAAO,CAAC,eAAe,CAAC,IAAI,CAAC;QACrC,CAAC;IACF,CAAC;IACD,OAAO,SAAS,CAAC;AAClB,CAAC;AAED,SAAS,YAAY,CAAC,IAAwB;IAC7C,IAAI,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,gBAAgB,EAAE,CAAC;QACpD,OAAO,QAAQ,CAAC;IACjB,CAAC;IACD,OAAO,IAAI,KAAK,uBAAuB,IAAI,IAAI,KAAK,0CAA0C,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC;AACxH,CAAC;AAED,MAAM,UAAU,YAAY,CAAC,IAAwB,EAAE,IAAa;IACnE,IAAI,IAAI,KAAK,iCAAiC,IAAI,IAAI,KAAK,cAAc,EAAE,CAAC;QAC3E,OAAO,eAAe,CAAC;IACxB,CAAC;IACD,IAAI,IAAI,KAAK,uBAAuB,IAAI,IAAI,KAAK,IAAI,EAAE,CAAC;QACvD,OAAO,OAAO,CAAC;IAChB,CAAC;IACD,MAAM,SAAS,GAAG,YAAY,CAAC,IAAI,CAAC,CAAC;IACrC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,IAAI,IAAI,KAAK,UAAU,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;QACpD,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,IAAI,CAAC,IAAI,KAAK,UAAU,IAAI,IAAI,KAAK,OAAO,CAAC,IAAI,SAAS,KAAK,QAAQ,EAAE,CAAC;QACzE,OAAO,OAAO,CAAC;IAChB,CAAC;IACD,OAAO,CAAC,IAAI,KAAK,IAAI,IAAI,IAAI,KAAK,MAAM,CAAC,IAAI,SAAS,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC;AAC3F,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"origins.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/origins.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AACrD,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AAC3C,OAAO,EAAmB,KAAK,MAAM,EAAE,MAAM,wBAAwB,CAAC;AActE,wBAAgB,YAAY,CAAC,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,WAAW;;mBAgH7C,EAAE,CAAC,IAAI,KAAG,MAAM;mBAWW,MAAM;EACtD"}
1
+ {"version":3,"file":"origins.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/origins.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AACrD,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AAC3C,OAAO,EAAmB,KAAK,MAAM,EAAE,MAAM,wBAAwB,CAAC;AAMtE,wBAAgB,YAAY,CAAC,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,WAAW;;mBAyH7C,EAAE,CAAC,IAAI,KAAG,MAAM;mBAWW,MAAM;EACtD"}
@@ -1,17 +1,10 @@
1
1
  import { join } from "node:path";
2
2
  import ts from "typescript";
3
3
  import { iterationOrigin } from "./collectionOrigins.js";
4
- import { importOrigin } from "./importOrigin.js";
4
+ import { importFrom, importOrigin } from "./importOrigin.js";
5
5
  import { storyProgram } from "./program.js";
6
6
  import { returnValues } from "./returnValues.js";
7
- function importFrom(node) {
8
- for (let current = node; current !== undefined; current = current.parent) {
9
- if (ts.isImportDeclaration(current) && ts.isStringLiteral(current.moduleSpecifier)) {
10
- return current.moduleSpecifier.text;
11
- }
12
- }
13
- return undefined;
14
- }
7
+ import { memberName } from "./syntax.js";
15
8
  export function storyOrigins(inputs, graph) {
16
9
  const program = storyProgram(inputs, graph);
17
10
  const checker = program.getTypeChecker();
@@ -65,8 +58,8 @@ export function storyOrigins(inputs, graph) {
65
58
  return undefined;
66
59
  }
67
60
  function member(receiver, name) {
68
- if (receiver === "kit" && name === "it") {
69
- return "story";
61
+ if ((receiver === "effectKit" && name === "effectApp") || (receiver === "kit" && name === "it")) {
62
+ return receiver === "kit" ? "story" : "plain";
70
63
  }
71
64
  if (receiver === "story" || receiver === "plain" || receiver === "suite") {
72
65
  return receiver;
@@ -99,7 +92,10 @@ export function storyOrigins(inputs, graph) {
99
92
  const values = returnValues(checker.getResolvedSignature(node)?.declaration);
100
93
  return values.length > 0 && values.every((value) => value !== undefined && visit(value) === "kit") ? "kit" : callee;
101
94
  }
102
- return callee === "factory" ? "kit" : callee;
95
+ if (callee === "factory" || callee === "effectFactory") {
96
+ return callee === "factory" ? "kit" : "effectKit";
97
+ }
98
+ return callee;
103
99
  }
104
100
  function expression(node) {
105
101
  if (ts.isParenthesizedExpression(node) || ts.isAsExpression(node) || ts.isSatisfiesExpression(node)) {
@@ -108,9 +104,15 @@ export function storyOrigins(inputs, graph) {
108
104
  if (ts.isCallExpression(node)) {
109
105
  return call(node);
110
106
  }
107
+ if (ts.isTaggedTemplateExpression(node)) {
108
+ return visit(node.tag);
109
+ }
111
110
  if (ts.isPropertyAccessExpression(node)) {
112
111
  return member(visit(node.expression), node.name.text) ?? symbol(checker.getSymbolAtLocation(node.name));
113
112
  }
113
+ if (ts.isElementAccessExpression(node)) {
114
+ return member(visit(node.expression), memberName(node) ?? "");
115
+ }
114
116
  return ts.isIdentifier(node) ? identifier(node) : declaration(node);
115
117
  }
116
118
  function visit(node) {
@@ -1 +1 @@
1
- {"version":3,"file":"origins.js","sourceRoot":"","sources":["../../../src/rules/stories/origins.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,MAAM,YAAY,CAAC;AAG5B,OAAO,EAAE,eAAe,EAAe,MAAM,wBAAwB,CAAC;AACtE,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AACjD,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAEjD,SAAS,UAAU,CAAC,IAAa;IAChC,KAAK,IAAI,OAAO,GAAwB,IAAI,EAAE,OAAO,KAAK,SAAS,EAAE,OAAO,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC;QAC/F,IAAI,EAAE,CAAC,mBAAmB,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,OAAO,CAAC,eAAe,CAAC,EAAE,CAAC;YACpF,OAAO,OAAO,CAAC,eAAe,CAAC,IAAI,CAAC;QACrC,CAAC;IACF,CAAC;IACD,OAAO,SAAS,CAAC;AAClB,CAAC;AAED,MAAM,UAAU,YAAY,CAAC,MAAkB,EAAE,KAAkB;IAClE,MAAM,OAAO,GAAG,YAAY,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;IAC5C,MAAM,OAAO,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IACzC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAW,CAAC;IACpC,MAAM,KAAK,GAAG,IAAI,GAAG,EAAmB,CAAC;IAEzC,SAAS,OAAO,CAAC,IAAuB;QACvC,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC;YACnD,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,MAAM,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QACxC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;YAC3C,OAAO,OAAO,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAC1F,CAAC;QACD,MAAM,IAAI,GAAG,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,IAAI,CAAC;QAC5C,OAAO,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACjG,CAAC;IAED,SAAS,WAAW,CAAC,IAAa;QACjC,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;YAChC,OAAO,YAAY,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC;QAC9E,CAAC;QACD,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;YAChC,OAAO,YAAY,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC;QACvC,CAAC;QACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,CAAC;YACrE,OAAO,IAAI,CAAC,WAAW,KAAK,SAAS,CAAC,CAAC,CAAC,eAAe,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAChG,CAAC;QACD,OAAO,YAAY,CAAC,IAAI,CAAC,CAAC;IAC3B,CAAC;IAED,SAAS,YAAY,CAAC,IAAa;QAClC,IAAI,EAAE,CAAC,6BAA6B,CAAC,IAAI,CAAC,EAAE,CAAC;YAC5C,OAAO,MAAM,CAAC,OAAO,CAAC,iCAAiC,CAAC,IAAI,CAAC,CAAC,CAAC;QAChE,CAAC;QACD,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAC9D,CAAC;IAED,SAAS,MAAM,CAAC,KAA4B;QAC3C,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;YACzB,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,MAAM,MAAM,GAAG,KAAK,CAAC,YAAY,EAAE,GAAG,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,KAAK,SAAS,CAAC,CAAC;QACrF,OAAO,MAAM,IAAI,CAAC,KAAK,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,gBAAgB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IAC7G,CAAC;IAED,SAAS,MAAM,CAAC,IAAgC;QAC/C,KAAK,MAAM,QAAQ,IAAI,CAAC,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC;YACvD,IAAI,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC;gBACvC,OAAO,KAAK,CAAC,QAAQ,CAAC,KAAK,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,CAAC;YACxD,CAAC;YACD,IAAI,EAAE,CAAC,kBAAkB,CAAC,QAAQ,CAAC,IAAI,KAAK,CAAC,QAAQ,CAAC,UAAU,CAAC,KAAK,KAAK,EAAE,CAAC;gBAC7E,OAAO,KAAK,CAAC;YACd,CAAC;QACF,CAAC;QACD,OAAO,SAAS,CAAC;IAClB,CAAC;IAED,SAAS,MAAM,CAAC,QAAgB,EAAE,IAAY;QAC7C,IAAI,QAAQ,KAAK,KAAK,IAAI,IAAI,KAAK,IAAI,EAAE,CAAC;YACzC,OAAO,OAAO,CAAC;QAChB,CAAC;QACD,IAAI,QAAQ,KAAK,OAAO,IAAI,QAAQ,KAAK,OAAO,IAAI,QAAQ,KAAK,OAAO,EAAE,CAAC;YAC1E,OAAO,QAAQ,CAAC;QACjB,CAAC;QACD,MAAM,IAAI,GAAG,QAAQ,KAAK,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;QAC1D,OAAO,YAAY,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,0CAA0C,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IACvG,CAAC;IAED,SAAS,UAAU,CAAC,IAAmB;QACtC,IAAI,IAAI,CAAC,IAAI,KAAK,UAAU,IAAI,IAAI,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;YACvD,OAAO,MAAM,CAAC,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC;QAC7D,CAAC;QACD,MAAM,KAAK,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QAChD,OAAO,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,KAAK,SAAS,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,IAAI,IAAI,IAAI,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IACrH,CAAC;IAED,SAAS,MAAM,CAAC,IAAa;QAC5B,IAAI,EAAE,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;YAC7B,OAAO,UAAU,CAAC;QACnB,CAAC;QACD,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;YACxC,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC;QACrB,CAAC;QACD,IAAI,EAAE,CAAC,wBAAwB,CAAC,IAAI,CAAC,EAAE,CAAC;YACvC,OAAO,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;QACjC,CAAC;QACD,OAAO,UAAU,CAAC,IAAI,CAAC,CAAC;IACzB,CAAC;IAED,SAAS,IAAI,CAAC,IAAuB;QACpC,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QACtC,IAAI,MAAM,KAAK,UAAU,EAAE,CAAC;YAC3B,MAAM,MAAM,GAAG,YAAY,CAAC,OAAO,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,WAAW,CAAC,CAAC;YAC7E,OAAO,MAAM,CAAC,MAAM,GAAG,CAAC,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,IAAI,KAAK,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC;QACrH,CAAC;QACD,OAAO,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC;IAC9C,CAAC;IAED,SAAS,UAAU,CAAC,IAAa;QAChC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,EAAE,CAAC;YACrG,OAAO,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QAC/B,CAAC;QACD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YAC/B,OAAO,IAAI,CAAC,IAAI,CAAC,CAAC;QACnB,CAAC;QACD,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,EAAE,CAAC;YACzC,OAAO,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QACzG,CAAC;QACD,OAAO,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IACrE,CAAC;IAED,SAAS,KAAK,CAAC,IAAa;QAC3B,IAAI,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YAC3C,OAAO,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACxB,CAAC;QACD,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACnB,MAAM,MAAM,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC;QAC5B,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QACtB,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QACxB,OAAO,MAAM,CAAC;IACf,CAAC;IAED,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,IAAY,EAAE,EAAE,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,EAAE,CAAC;AAC7G,CAAC"}
1
+ {"version":3,"file":"origins.js","sourceRoot":"","sources":["../../../src/rules/stories/origins.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,MAAM,YAAY,CAAC;AAG5B,OAAO,EAAE,eAAe,EAAe,MAAM,wBAAwB,CAAC;AACtE,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAC7D,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AACjD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAC;AAEzC,MAAM,UAAU,YAAY,CAAC,MAAkB,EAAE,KAAkB;IAClE,MAAM,OAAO,GAAG,YAAY,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;IAC5C,MAAM,OAAO,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IACzC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAW,CAAC;IACpC,MAAM,KAAK,GAAG,IAAI,GAAG,EAAmB,CAAC;IAEzC,SAAS,OAAO,CAAC,IAAuB;QACvC,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC;YACnD,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,MAAM,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QACxC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;YAC3C,OAAO,OAAO,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAC1F,CAAC;QACD,MAAM,IAAI,GAAG,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,IAAI,CAAC;QAC5C,OAAO,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACjG,CAAC;IAED,SAAS,WAAW,CAAC,IAAa;QACjC,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;YAChC,OAAO,YAAY,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC;QAC9E,CAAC;QACD,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;YAChC,OAAO,YAAY,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC;QACvC,CAAC;QACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,CAAC;YACrE,OAAO,IAAI,CAAC,WAAW,KAAK,SAAS,CAAC,CAAC,CAAC,eAAe,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAChG,CAAC;QACD,OAAO,YAAY,CAAC,IAAI,CAAC,CAAC;IAC3B,CAAC;IAED,SAAS,YAAY,CAAC,IAAa;QAClC,IAAI,EAAE,CAAC,6BAA6B,CAAC,IAAI,CAAC,EAAE,CAAC;YAC5C,OAAO,MAAM,CAAC,OAAO,CAAC,iCAAiC,CAAC,IAAI,CAAC,CAAC,CAAC;QAChE,CAAC;QACD,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAC9D,CAAC;IAED,SAAS,MAAM,CAAC,KAA4B;QAC3C,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;YACzB,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,MAAM,MAAM,GAAG,KAAK,CAAC,YAAY,EAAE,GAAG,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,KAAK,SAAS,CAAC,CAAC;QACrF,OAAO,MAAM,IAAI,CAAC,KAAK,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,gBAAgB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IAC7G,CAAC;IAED,SAAS,MAAM,CAAC,IAAgC;QAC/C,KAAK,MAAM,QAAQ,IAAI,CAAC,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC;YACvD,IAAI,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC;gBACvC,OAAO,KAAK,CAAC,QAAQ,CAAC,KAAK,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,CAAC;YACxD,CAAC;YACD,IAAI,EAAE,CAAC,kBAAkB,CAAC,QAAQ,CAAC,IAAI,KAAK,CAAC,QAAQ,CAAC,UAAU,CAAC,KAAK,KAAK,EAAE,CAAC;gBAC7E,OAAO,KAAK,CAAC;YACd,CAAC;QACF,CAAC;QACD,OAAO,SAAS,CAAC;IAClB,CAAC;IAED,SAAS,MAAM,CAAC,QAAgB,EAAE,IAAY;QAC7C,IAAI,CAAC,QAAQ,KAAK,WAAW,IAAI,IAAI,KAAK,WAAW,CAAC,IAAI,CAAC,QAAQ,KAAK,KAAK,IAAI,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;YACjG,OAAO,QAAQ,KAAK,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC;QAC/C,CAAC;QACD,IAAI,QAAQ,KAAK,OAAO,IAAI,QAAQ,KAAK,OAAO,IAAI,QAAQ,KAAK,OAAO,EAAE,CAAC;YAC1E,OAAO,QAAQ,CAAC;QACjB,CAAC;QACD,MAAM,IAAI,GAAG,QAAQ,KAAK,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;QAC1D,OAAO,YAAY,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,0CAA0C,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IACvG,CAAC;IAED,SAAS,UAAU,CAAC,IAAmB;QACtC,IAAI,IAAI,CAAC,IAAI,KAAK,UAAU,IAAI,IAAI,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;YACvD,OAAO,MAAM,CAAC,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC;QAC7D,CAAC;QACD,MAAM,KAAK,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QAChD,OAAO,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,KAAK,SAAS,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,IAAI,IAAI,IAAI,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IACrH,CAAC;IAED,SAAS,MAAM,CAAC,IAAa;QAC5B,IAAI,EAAE,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;YAC7B,OAAO,UAAU,CAAC;QACnB,CAAC;QACD,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;YACxC,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC;QACrB,CAAC;QACD,IAAI,EAAE,CAAC,wBAAwB,CAAC,IAAI,CAAC,EAAE,CAAC;YACvC,OAAO,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;QACjC,CAAC;QACD,OAAO,UAAU,CAAC,IAAI,CAAC,CAAC;IACzB,CAAC;IAED,SAAS,IAAI,CAAC,IAAuB;QACpC,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QACtC,IAAI,MAAM,KAAK,UAAU,EAAE,CAAC;YAC3B,MAAM,MAAM,GAAG,YAAY,CAAC,OAAO,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,WAAW,CAAC,CAAC;YAC7E,OAAO,MAAM,CAAC,MAAM,GAAG,CAAC,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,IAAI,KAAK,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC;QACrH,CAAC;QACD,IAAI,MAAM,KAAK,SAAS,IAAI,MAAM,KAAK,eAAe,EAAE,CAAC;YACxD,OAAO,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,WAAW,CAAC;QACnD,CAAC;QACD,OAAO,MAAM,CAAC;IACf,CAAC;IAED,SAAS,UAAU,CAAC,IAAa;QAChC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,EAAE,CAAC;YACrG,OAAO,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QAC/B,CAAC;QACD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YAC/B,OAAO,IAAI,CAAC,IAAI,CAAC,CAAC;QACnB,CAAC;QACD,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,EAAE,CAAC;YACzC,OAAO,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACxB,CAAC;QACD,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,EAAE,CAAC;YACzC,OAAO,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QACzG,CAAC;QACD,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;YACxC,OAAO,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,UAAU,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC;QAC/D,CAAC;QACD,OAAO,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IACrE,CAAC;IAED,SAAS,KAAK,CAAC,IAAa;QAC3B,IAAI,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YAC3C,OAAO,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACxB,CAAC;QACD,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACnB,MAAM,MAAM,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC;QAC5B,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QACtB,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QACxB,OAAO,MAAM,CAAC;IACf,CAAC;IAED,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,IAAY,EAAE,EAAE,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,EAAE,CAAC;AAC7G,CAAC"}
@@ -0,0 +1,3 @@
1
+ import ts from "typescript";
2
+ export declare function retryOption(checker: ts.TypeChecker): (expression: ts.Expression) => boolean;
3
+ //# sourceMappingURL=retryOption.d.ts.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"retryOption.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/retryOption.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAwB5B,wBAAgB,WAAW,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,gBAe9B,EAAE,CAAC,UAAU,aACjC"}
@@ -0,0 +1,37 @@
1
+ import ts from "typescript";
2
+ import { unwrapped } from "./syntax.js";
3
+ function retryKey(name) {
4
+ if (name === undefined) {
5
+ return false;
6
+ }
7
+ const key = ts.isComputedPropertyName(name) ? unwrapped(name.expression) : name;
8
+ return (ts.isIdentifier(key) && !ts.isComputedPropertyName(name) && key.text === "retry") || (ts.isStringLiteralLike(key) && key.text === "retry");
9
+ }
10
+ function initializers(node, checker) {
11
+ if (!(ts.isIdentifier(node) || ts.isPropertyAccessExpression(node))) {
12
+ return [];
13
+ }
14
+ const symbol = checker.getSymbolAtLocation(node);
15
+ const target = symbol !== undefined && symbol.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(symbol) : symbol;
16
+ return (target?.declarations ?? []).flatMap((declaration) => (ts.isVariableDeclaration(declaration) || ts.isPropertyAssignment(declaration)) && declaration.initializer !== undefined
17
+ ? [declaration.initializer]
18
+ : []);
19
+ }
20
+ export function retryOption(checker) {
21
+ function visit(expression, seen) {
22
+ const node = unwrapped(expression);
23
+ if (seen.has(node)) {
24
+ return false;
25
+ }
26
+ seen.add(node);
27
+ if (ts.isObjectLiteralExpression(node)) {
28
+ return node.properties.some((property) => retryKey(property.name) || (ts.isSpreadAssignment(property) && visit(property.expression, seen)));
29
+ }
30
+ if (ts.isConditionalExpression(node)) {
31
+ return visit(node.whenTrue, seen) || visit(node.whenFalse, seen);
32
+ }
33
+ return initializers(node, checker).some((value) => visit(value, seen));
34
+ }
35
+ return (expression) => visit(expression, new Set());
36
+ }
37
+ //# sourceMappingURL=retryOption.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"retryOption.js","sourceRoot":"","sources":["../../../src/rules/stories/retryOption.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAExC,SAAS,QAAQ,CAAC,IAAiC;IAClD,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,GAAG,GAAG,EAAE,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAChF,OAAO,CAAC,EAAE,CAAC,YAAY,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,sBAAsB,CAAC,IAAI,CAAC,IAAI,GAAG,CAAC,IAAI,KAAK,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC,mBAAmB,CAAC,GAAG,CAAC,IAAI,GAAG,CAAC,IAAI,KAAK,OAAO,CAAC,CAAC;AACpJ,CAAC;AAED,SAAS,YAAY,CAAC,IAAmB,EAAE,OAAuB;IACjE,IAAI,CAAC,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC;QACrE,OAAO,EAAE,CAAC;IACX,CAAC;IACD,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;IACjD,MAAM,MAAM,GAAG,MAAM,KAAK,SAAS,IAAI,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;IACvH,OAAO,CAAC,MAAM,EAAE,YAAY,IAAI,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,WAAW,EAAE,EAAE,CAC3D,CAAC,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,WAAW,CAAC,CAAC,IAAI,WAAW,CAAC,WAAW,KAAK,SAAS;QACvH,CAAC,CAAC,CAAC,WAAW,CAAC,WAAW,CAAC;QAC3B,CAAC,CAAC,EAAE,CACL,CAAC;AACH,CAAC;AAED,MAAM,UAAU,WAAW,CAAC,OAAuB;IAClD,SAAS,KAAK,CAAC,UAAyB,EAAE,IAAkB;QAC3D,MAAM,IAAI,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC;QACnC,IAAI,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACpB,OAAO,KAAK,CAAC;QACd,CAAC;QACD,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACf,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;YACxC,OAAO,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,kBAAkB,CAAC,QAAQ,CAAC,IAAI,KAAK,CAAC,QAAQ,CAAC,UAAU,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC;QAC7I,CAAC;QACD,IAAI,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,EAAE,CAAC;YACtC,OAAO,KAAK,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,IAAI,KAAK,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;QAClE,CAAC;QACD,OAAO,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC,CAAC;IACxE,CAAC;IACD,OAAO,CAAC,UAAyB,EAAE,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,IAAI,GAAG,EAAE,CAAC,CAAC;AACpE,CAAC"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@shivaedev/quality",
3
- "version": "0.54.0",
3
+ "version": "0.55.0",
4
4
  "description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
5
5
  "homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
6
6
  "bugs": {
@@ -50,8 +50,8 @@
50
50
  "README.md"
51
51
  ],
52
52
  "dependencies": {
53
- "@biomejs/biome": "2.6.2",
54
- "@shivaedev/heavy-lock": "0.7.1",
53
+ "@biomejs/biome": "2.6.3",
54
+ "@shivaedev/heavy-lock": "0.8.0",
55
55
  "@shivaedev/types": "0.3.0",
56
56
  "@vitest/coverage-v8": "5.0.5",
57
57
  "ignore": "7.0.14",
@@ -63,7 +63,7 @@
63
63
  "@effect/platform-node": "4.0.6",
64
64
  "@effect/platform-node-shared": "4.0.6",
65
65
  "@effect/vitest": "4.0.6",
66
- "@shivaedev/test-story": "0.32.0",
66
+ "@shivaedev/test-story": "0.33.0",
67
67
  "@types/node": "24.19.2",
68
68
  "@typescript/native": "npm:typescript@7.0.2",
69
69
  "effect": "4.0.6",
@@ -0,0 +1,3 @@
1
+ import { enableCompileCache } from "node:module";
2
+
3
+ enableCompileCache();
@@ -75,7 +75,9 @@ export async function loadPackageManifests(readText: ReadText, files: readonly s
75
75
  const failures: ManifestFailure[] = [];
76
76
  for (const file of files) {
77
77
  try {
78
- await manifestEntry(readText, file);
78
+ if ((await manifestEntry(readText, file)) === undefined) {
79
+ throw new ManifestFailure({ message: `required input is missing: ${file}`, path: file });
80
+ }
79
81
  } catch (cause) {
80
82
  if (!(cause instanceof ManifestFailure)) {
81
83
  throw cause;
@@ -1,11 +1,12 @@
1
1
  import { resolve } from "node:path";
2
- import { Effect, type FileSystem } from "effect";
2
+ import { Effect, type FileSystem, type Scope } from "effect";
3
3
  import { readOptionalText } from "#inventory/filesystem.ts";
4
4
  import type { RuleInputs } from "#rule.ts";
5
5
 
6
6
  export const manifestReader = Effect.fn("Manifests.manifestReader")(function* (
7
7
  root: string,
8
- ): Effect.fn.Return<RuleInputs["readText"], never, FileSystem.FileSystem> {
8
+ ): Effect.fn.Return<RuleInputs["readText"], never, FileSystem.FileSystem | Scope.Scope> {
9
9
  const services = yield* Effect.context<FileSystem.FileSystem>();
10
- return (path) => Effect.runPromiseWith(services)(readOptionalText(resolve(root, path)));
10
+ const signal = yield* Effect.abortSignal;
11
+ return (path) => Effect.runPromiseWith(services)(readOptionalText(resolve(root, path)), { signal });
11
12
  });
@@ -44,6 +44,7 @@ export function testProjects(options: TestProjectsOptions = {}): TestUserConfig
44
44
  const { coverage = false } = options;
45
45
  const output = Effect.runSync(TestOutput.pipe(Effect.provide(TestOutput.layer)));
46
46
  return {
47
+ execArgv: ["--import", fileURLToPath(import.meta.resolve("#adapters/compileCache.config.ts"))],
47
48
  maxWorkers: workerCount(options),
48
49
  ...(coverage === false
49
50
  ? {}
@@ -19,7 +19,7 @@ export type Diagnostic = typeof Diagnostic.Type;
19
19
 
20
20
  const Report = Schema.Struct({
21
21
  diagnostics: Schema.Array(Diagnostic),
22
- summary: Schema.Struct({ changed: Schema.Int }),
22
+ summary: Schema.Struct({ changed: Schema.Int, unchanged: Schema.Int }),
23
23
  });
24
24
 
25
25
  export type Report = typeof Report.Type;
@@ -32,7 +32,6 @@ function failure(args: readonly string[], run: BiomeRun, missing: string, output
32
32
  return new SetupFailure({ message: `biome ${args.join(" ")} exited ${run.code} without ${missing}:\n${output.trim()}` });
33
33
  }
34
34
 
35
- // Biome exits with an error but prints an empty report when no file was processed, so only a failing diagnostic explains a failed run.
36
35
  function unexplained(run: BiomeRun, report: Report): boolean {
37
36
  return run.code !== 0 && !report.diagnostics.some((diagnostic) => FAILING.has(diagnostic.severity));
38
37
  }
@@ -49,6 +48,11 @@ const reportFor = Effect.fn("Biome.reportFor")(function* (
49
48
  if (report._tag === "None") {
50
49
  return yield* Effect.fail(failure(command, run, "a report", [run.stdout, run.stderr].join("\n")));
51
50
  }
51
+ if (report.value.summary.changed + report.value.summary.unchanged === 0 && !args.includes("--no-errors-on-unmatched")) {
52
+ return yield* new SetupFailure({
53
+ message: `biome ${command.join(" ")} processed no files. Check files.includes in biome.json or biome.jsonc so Quality has files to check.`,
54
+ });
55
+ }
52
56
  if (unexplained(run, report.value)) {
53
57
  return yield* Effect.fail(failure(command, run, "a failing diagnostic", run.stderr));
54
58
  }
@@ -59,15 +63,17 @@ export const biomeReport = Effect.fn("Biome.biomeReport")(function* (
59
63
  root: string,
60
64
  args: readonly string[],
61
65
  exceptions: readonly ExceptionDeclaration[] = [],
66
+ files: readonly string[] = ["."],
62
67
  ) {
63
- const [report, tracked] = yield* Effect.all([reportFor(root, args, ["."], exceptions), ignoredTrackedPaths(root)], {
68
+ const [report, tracked] = yield* Effect.all([reportFor(root, args, files, exceptions), ignoredTrackedPaths(root)], {
64
69
  concurrency: "unbounded",
65
70
  });
66
71
  const paths = tracked
67
72
  .map((path) => relative(root, path))
73
+ .filter((path) => files.includes(".") || files.includes(path))
68
74
  .filter((path) => !path.split(sep).some((part) => part === ".git" || part === ".worktrees" || part === "node_modules"));
69
- const extra =
70
- paths.length === 0 ? undefined : yield* reportFor(root, [...args, "--vcs-enabled=false", "--no-errors-on-unmatched"], paths, exceptions);
75
+ const extraArgs = [...args, "--vcs-enabled=false", ...(args.includes("--no-errors-on-unmatched") ? [] : ["--no-errors-on-unmatched"])];
76
+ const extra = paths.length === 0 ? undefined : yield* reportFor(root, extraArgs, paths, exceptions);
71
77
  const diagnostics = [...report.diagnostics, ...(extra?.diagnostics ?? [])];
72
78
  const unique = [...new Map(diagnostics.map((diagnostic) => [JSON.stringify(diagnostic), diagnostic])).values()];
73
79
  return {
package/src/cli/lint.ts CHANGED
@@ -1,4 +1,5 @@
1
1
  import { relative } from "node:path";
2
+ import * as NodeCrypto from "@effect/platform-node/NodeCrypto";
2
3
  import * as NodePath from "@effect/platform-node/NodePath";
3
4
  import { Console, Effect } from "effect";
4
5
  import { withHeavyLock } from "@shivaedev/heavy-lock/withHeavyLock.ts";
@@ -20,6 +21,7 @@ export const lint = Effect.fn("Cli.lint")(
20
21
  ...evaluated,
21
22
  looseBaseline: evaluated.looseBaseline.filter(({ entry }) => !rejected.has(keyOf(entry.rule, entry.file))),
22
23
  staleBaseline: [...evaluated.staleBaseline, ...loose],
24
+ staleRegistry: [...evaluated.staleRegistry, ...session.staleRegistry],
23
25
  };
24
26
  yield* Console.log(
25
27
  render(outcome, {
@@ -37,6 +39,7 @@ export const lint = Effect.fn("Cli.lint")(
37
39
  (effect) =>
38
40
  withHeavyLock(effect, { command: "quality lint" }).pipe(
39
41
  Effect.catchTag("HeavyLockError", (cause) => new SetupFailure({ cause, message: cause.message })),
42
+ Effect.provide(NodeCrypto.layer),
40
43
  Effect.provide(NodePath.layer),
41
44
  ),
42
45
  );
package/src/config.ts CHANGED
@@ -1,20 +1,20 @@
1
1
  import type { ExceptionDeclaration } from "#exceptions/declaration.ts";
2
+ import type { Rule } from "#rule.ts";
2
3
  import type { builtInRules } from "#rules/builtIn.ts";
3
- import type { Rule } from "./rule.ts";
4
4
 
5
5
  export type Level = "error";
6
6
 
7
7
  export type RuleSetting<TInput> = "error" | { readonly level?: "error"; readonly options?: TInput };
8
8
 
9
- type InputOf<TCandidate> = TCandidate extends Rule<string, infer TInput> ? TInput : never;
9
+ type InputOf<TCandidate> = TCandidate extends Rule<string, infer TInput, unknown> ? TInput : never;
10
10
 
11
- export type RuleSettings<TRules extends readonly Rule[]> = {
11
+ export type RuleSettings<TRules extends readonly Rule<string, unknown, unknown>[]> = {
12
12
  readonly [TCandidate in TRules[number] as TCandidate["id"]]?: RuleSetting<InputOf<TCandidate>>;
13
13
  };
14
14
 
15
15
  export type BuiltInRules = typeof builtInRules;
16
16
 
17
- export interface QualityConfig<TLocal extends readonly Rule[] = readonly Rule[]> {
17
+ export interface QualityConfig<TLocal extends readonly Rule<string, unknown, unknown>[] = readonly Rule<string, unknown, unknown>[]> {
18
18
  readonly baseline?: string;
19
19
  readonly exceptions?: readonly ExceptionDeclaration[];
20
20
  readonly extensions?: readonly string[];
@@ -24,6 +24,8 @@ export interface QualityConfig<TLocal extends readonly Rule[] = readonly Rule[]>
24
24
  readonly sources?: readonly string[];
25
25
  }
26
26
 
27
- export function defineConfig<const TLocal extends readonly Rule[] = readonly []>(config: QualityConfig<TLocal>): QualityConfig<TLocal> {
27
+ export function defineConfig<const TLocal extends readonly Rule<string, unknown, unknown>[] = readonly []>(
28
+ config: QualityConfig<TLocal>,
29
+ ): QualityConfig<TLocal> {
28
30
  return config;
29
31
  }
@@ -1,7 +1,8 @@
1
- import { isAbsolute, relative } from "node:path";
1
+ import { basename, isAbsolute, relative } from "node:path";
2
2
  import { Effect } from "effect";
3
3
  import { ManifestFailure } from "#adapters/manifestInventory.ts";
4
4
  import { SetupFailure } from "#failure.ts";
5
+ import { FilesystemFailure } from "#inventory/filesystem.ts";
5
6
  import { posix } from "#inventory/ignoreScope.ts";
6
7
  import type { Finding, RuleCheck, RuleInputs, RuleServices } from "#rule.ts";
7
8
  import type { ActiveLevel, Violation } from "./violation.ts";
@@ -49,19 +50,38 @@ function violationOf(rule: ActiveRule, root: string, finding: Finding, exception
49
50
  };
50
51
  }
51
52
 
53
+ function expectedFailure(rule: ActiveRule, root: string, cause: unknown): readonly Violation[] | undefined {
54
+ if (cause instanceof ManifestFailure || cause instanceof FilesystemFailure) {
55
+ const manifest = cause instanceof ManifestFailure || basename(cause.path) === "package.json";
56
+ return [
57
+ {
58
+ file: repositoryPath(root, cause.path),
59
+ level: rule.level,
60
+ message: cause.message,
61
+ rule: manifest ? "manifests/valid" : rule.id,
62
+ },
63
+ ];
64
+ }
65
+ return undefined;
66
+ }
67
+
52
68
  function runRule(rule: ActiveRule, inputs: RuleInputs, exceptionFile: string): Effect.Effect<readonly Violation[], SetupFailure, RuleServices> {
53
69
  return Effect.suspend(() => rule.check(inputs)).pipe(
54
- Effect.catch((cause) =>
55
- cause instanceof SetupFailure
56
- ? Effect.fail(new SetupFailure({ cause, message: `rule ${rule.id} failed: ${cause.message}` }))
57
- : Effect.die(cause),
58
- ),
59
70
  Effect.map((findings) => findings.map((finding) => violationOf(rule, inputs.root, finding, exceptionFile))),
60
- Effect.catchDefect((cause) =>
61
- cause instanceof ManifestFailure
62
- ? Effect.succeed([{ file: cause.path, level: "error" as const, message: cause.message, rule: "manifests/valid" }])
63
- : Effect.die(new Error(`rule ${rule.id} failed: ${messageOf(cause)}`, { cause })),
64
- ),
71
+ Effect.catch((cause) => {
72
+ const findings = expectedFailure(rule, inputs.root, cause);
73
+ if (findings !== undefined) {
74
+ return Effect.succeed(findings);
75
+ }
76
+ if (cause instanceof SetupFailure) {
77
+ return Effect.fail(new SetupFailure({ cause, message: `rule ${rule.id} failed: ${cause.message}` }));
78
+ }
79
+ return Effect.die(cause);
80
+ }),
81
+ Effect.catchDefect((cause) => {
82
+ const findings = expectedFailure(rule, inputs.root, cause);
83
+ return findings === undefined ? Effect.die(new Error(`rule ${rule.id} failed: ${messageOf(cause)}`, { cause })) : Effect.succeed(findings);
84
+ }),
65
85
  );
66
86
  }
67
87
 
@@ -1,13 +1,13 @@
1
1
  import { relative } from "node:path";
2
- import { Effect } from "effect";
2
+ import { Effect, type Scope } from "effect";
3
3
  import { setManifestFiles } from "#adapters/manifestInventory.ts";
4
4
  import { manifestReader } from "#adapters/manifestReader.ts";
5
5
  import { loadConfig, type ResolvedConfig } from "#config/load.ts";
6
- import type { RegistryEntry } from "#exceptions/registry.ts";
6
+ import { staleBiomeExceptions } from "#exceptions/biomeFindings.ts";
7
+ import type { RegistryEntry, StaleRegistryEntry } from "#exceptions/registry.ts";
7
8
  import { registryEntries } from "#exceptions/registryEntries.ts";
8
9
  import { SetupFailure } from "#failure.ts";
9
10
  import { collectInventory, type Inventory } from "#inventory/collect.ts";
10
- import type { FilesystemFailure } from "#inventory/filesystem.ts";
11
11
  import type { RuleServices } from "#rule.ts";
12
12
  import { type BaselineFile, readBaseline, readInput } from "./baselineFile.ts";
13
13
  import { runRules } from "./runRules.ts";
@@ -18,12 +18,11 @@ export interface Session {
18
18
  readonly config: ResolvedConfig;
19
19
  readonly inventory: Inventory;
20
20
  readonly registry: readonly RegistryEntry[];
21
+ readonly staleRegistry: readonly StaleRegistryEntry[];
21
22
  readonly violations: readonly Violation[];
22
23
  }
23
24
 
24
- function setup<TValue, TRequirements>(
25
- effect: Effect.Effect<TValue, FilesystemFailure | SetupFailure, TRequirements>,
26
- ): Effect.Effect<TValue, SetupFailure, TRequirements> {
25
+ function setup<TValue, TRequirements>(effect: Effect.Effect<TValue, Error, TRequirements>): Effect.Effect<TValue, SetupFailure, TRequirements> {
27
26
  return Effect.mapError(effect, (failure) =>
28
27
  failure instanceof SetupFailure ? failure : new SetupFailure({ cause: failure, message: failure.message }),
29
28
  );
@@ -31,20 +30,22 @@ function setup<TValue, TRequirements>(
31
30
 
32
31
  export const scan = Effect.fn("Engine.scan")(function* (
33
32
  config: ResolvedConfig,
34
- ): Effect.fn.Return<Pick<Session, "inventory" | "violations">, SetupFailure, RuleServices> {
33
+ ): Effect.fn.Return<Pick<Session, "inventory" | "staleRegistry" | "violations">, SetupFailure, RuleServices | Scope.Scope> {
35
34
  const inventory = yield* setup(collectInventory(config.root, config));
36
35
  const readText = yield* manifestReader(config.root);
37
36
  setManifestFiles(readText, inventory.manifestFiles);
38
- const violations = yield* runRules(config.active, {
37
+ const inputs = {
39
38
  configFile: relative(config.root, config.file),
40
39
  exceptions: config.exceptions,
41
40
  files: inventory.files,
42
41
  readText,
43
42
  root: config.root,
44
43
  sources: inventory.sources,
45
- });
46
- return { inventory, violations };
47
- });
44
+ };
45
+ const violations = yield* runRules(config.active, inputs);
46
+ const staleRegistry = yield* setup(staleBiomeExceptions(inputs));
47
+ return { inventory, staleRegistry, violations };
48
+ }, Effect.scoped);
48
49
 
49
50
  export const openSession = Effect.fn("Engine.openSession")(function* (
50
51
  cwd: string,
@@ -60,6 +61,6 @@ export const openSession = Effect.fn("Engine.openSession")(function* (
60
61
  }
61
62
  }
62
63
  const baseline = yield* readBaseline(config);
63
- const { inventory, violations } = yield* scan(config);
64
- return { baseline, config, inventory, registry: registryEntries(config.exceptions), violations };
64
+ const scanned = yield* scan(config);
65
+ return { ...scanned, baseline, config, registry: registryEntries(config.exceptions) };
65
66
  });
@@ -1,5 +1,34 @@
1
+ import { Effect } from "effect";
2
+ import { biomeReport } from "#biome/report.ts";
3
+ import { withoutEntryPointImports } from "#biome/withoutEntryPointImports.ts";
4
+ import type { StaleRegistryEntry } from "#exceptions/registry.ts";
1
5
  import type { Finding, RuleInputs } from "#rule.ts";
2
6
 
7
+ export const staleBiomeExceptions = Effect.fn("Exceptions.staleBiomeExceptions")(function* (inputs: RuleInputs) {
8
+ const declarations = inputs.exceptions ?? [];
9
+ const declared = declarations.flatMap(({ files, reason, rules }) =>
10
+ rules.filter((rule) => /^biome\/(?:lint|assist)\//u.test(rule)).flatMap((rule) => files.map((file) => ({ file, reason, rule }))),
11
+ );
12
+ const texts = yield* Effect.forEach(declared, ({ file }) => Effect.promise(() => inputs.readText(file)), { concurrency: "unbounded" });
13
+ const entries = declared.filter((_, index) => texts[index] !== undefined);
14
+ if (entries.length === 0) {
15
+ return [];
16
+ }
17
+ const exclusions = declarations.flatMap((entry) =>
18
+ entry.rules.includes("biome/files/includes") ? [{ ...entry, rules: ["biome/files/includes"] as const }] : [],
19
+ );
20
+ const report = yield* biomeReport(inputs.root, ["check", "--no-errors-on-unmatched"], exclusions, [...new Set(entries.map(({ file }) => file))]);
21
+ const diagnostics = yield* Effect.promise(() => withoutEntryPointImports(inputs.readText, report.diagnostics));
22
+ return entries
23
+ .filter(({ file, rule }) => !diagnostics.some((diagnostic) => diagnostic.location.path === file && `biome/${diagnostic.category}` === rule))
24
+ .map(
25
+ (entry): StaleRegistryEntry => ({
26
+ entry,
27
+ problem: `matches no finding. Remove this file/rule pair from exceptions in ${inputs.configFile ?? "quality.config.ts"}`,
28
+ }),
29
+ );
30
+ });
31
+
3
32
  export async function missingBiomeFiles(inputs: RuleInputs): Promise<readonly Finding[]> {
4
33
  const paths = (inputs.exceptions ?? [])
5
34
  .filter((entry) => entry.rules.some((rule) => rule.startsWith("biome/") && rule !== "biome/files/includes"))
@@ -25,7 +25,7 @@ const commitScripts = Effect.fnUntraced(function* (root: string) {
25
25
  return yield* new SetupFailure({ message: `${file}: unsupported packageManager "${manager}". Use npm, pnpm, yarn or bun.` });
26
26
  }
27
27
  return { manager, scripts: ["typecheck", "quality:commit"].filter((script) => manifest.scripts?.[script] !== undefined) };
28
- });
28
+ }, Effect.scoped);
29
29
 
30
30
  const runScript = Effect.fnUntraced(
31
31
  function* (root: string, manager: string, script: string) {