@shivaedev/quality 0.50.0 → 0.51.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +10 -0
- package/README.md +12 -0
- package/dist/config/resolve.d.ts.map +1 -1
- package/dist/config/resolve.js +9 -6
- package/dist/config/resolve.js.map +1 -1
- package/dist/rules/builtIn.d.ts +1 -1
- package/dist/rules/builtIn.d.ts.map +1 -1
- package/dist/rules/builtIn.js +2 -0
- package/dist/rules/builtIn.js.map +1 -1
- package/dist/rules/effect/failureFindings.d.ts +8 -0
- package/dist/rules/effect/failureFindings.d.ts.map +1 -0
- package/dist/rules/effect/failureFindings.js +47 -0
- package/dist/rules/effect/failureFindings.js.map +1 -0
- package/dist/rules/effect/failureHonesty.d.ts +2 -0
- package/dist/rules/effect/failureHonesty.d.ts.map +1 -0
- package/dist/rules/effect/failureHonesty.js +53 -0
- package/dist/rules/effect/failureHonesty.js.map +1 -0
- package/dist/rules/effect/failureOperations.d.ts +9 -0
- package/dist/rules/effect/failureOperations.d.ts.map +1 -0
- package/dist/rules/effect/failureOperations.js +55 -0
- package/dist/rules/effect/failureOperations.js.map +1 -0
- package/dist/rules/effect/successRecovery.d.ts +3 -0
- package/dist/rules/effect/successRecovery.d.ts.map +1 -0
- package/dist/rules/effect/successRecovery.js +43 -0
- package/dist/rules/effect/successRecovery.js.map +1 -0
- package/package.json +2 -2
- package/src/config/resolve.ts +4 -6
- package/src/rules/builtIn.ts +2 -0
- package/src/rules/effect/failureFindings.ts +55 -0
- package/src/rules/effect/failureHonesty.ts +59 -0
- package/src/rules/effect/failureOperations.ts +66 -0
- package/src/rules/effect/successRecovery.ts +44 -0
package/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,15 @@
|
|
|
1
1
|
# Changelog
|
|
2
2
|
|
|
3
|
+
## 0.51.0 - 2026-10-31
|
|
4
|
+
|
|
5
|
+
### Added
|
|
6
|
+
|
|
7
|
+
- Report swallowed failures with `effect/failure-honesty`: forked forever loops piped through `orDie`, conditional retries without `times` or `schedule`, blanket catches returning success, and FileSystem calls wrapped in `option` or `orElseSucceed`. Findings explain typed recovery alternatives. The rule refuses config exceptions; record reviewed existing debt through first adoption.
|
|
8
|
+
|
|
9
|
+
### Breaking
|
|
10
|
+
|
|
11
|
+
- Heavy-lock only treats `NotFound` as an absent holder. Acquisition reports other read failures as `HeavyLockError`, preserving the filesystem cause. Consumers of `lockFile.ts`'s `readHolder` must now handle `PlatformError` in the Effect error channel; callers of `acquireHeavyLock` keep handling `HeavyLockError` and should repair an unreadable lock path instead of waiting for acquisition.
|
|
12
|
+
|
|
3
13
|
## 0.50.0 - 2026-10-31
|
|
4
14
|
|
|
5
15
|
### Added
|
package/README.md
CHANGED
|
@@ -52,6 +52,18 @@ Both rules refuse config exceptions and inline suppressions. Record existing deb
|
|
|
52
52
|
|
|
53
53
|
When an upgrade expands these checks, inspect the new findings, repair the small ones and record retained debt with `quality baseline write --first-adoption --rule effect/boundary` (or `--rule effect/service-parameters`). This explicit first-adoption mode requires named rules that refuse config exceptions and may record unchanged files. Review each raised count and explain its reason in the pull request. Ordinary writes still require changed `--file` selections. Run `quality baseline tighten` after repairs to lower the touched files' counts.
|
|
54
54
|
|
|
55
|
+
### Failure honesty
|
|
56
|
+
|
|
57
|
+
`effect/failure-honesty` checks TypeScript and JavaScript throughout the inventory, including adapters and tests. It reports four failure-hiding shapes:
|
|
58
|
+
- A forever loop piped through `orDie` and then forked. Recover a named reason within each iteration with a Schedule-bounded retry, or expose an explicit unavailable state and supervise termination.
|
|
59
|
+
- `Effect.retry({ while })` without `times` or `schedule`. Supply a Schedule-bounded retry and preserve the final typed failure.
|
|
60
|
+
- A blanket `catch`, `catchAll`, `catchCause` or `catchAllCause` whose handler returns `Effect.succeed(...)` or `Effect.void` on every return branch. Catch a named reason with `catchTag` or `catchIf`, re-failing other errors, or model an explicit unavailable state with `Effect.match`.
|
|
61
|
+
- A FileSystem service call wrapped in `Effect.option` or `Effect.orElseSucceed`. Catch a named reason such as `NotFound`, propagate other failures, or represent unavailability explicitly. An option around a non-filesystem computation remains accepted.
|
|
62
|
+
|
|
63
|
+
The check follows Effect import aliases, local operation and handler aliases, nested calls and `.pipe(...)` stages. It recognizes FileSystem instances yielded from the native service and their local aliases. Retry options are checked as object literals; a spread may supply a bound. It does not infer whether a supplied schedule terminates or analyze arbitrary recovery helpers. Static findings identify these shapes, not every possible swallowed failure.
|
|
64
|
+
|
|
65
|
+
This rule refuses config exceptions and inline suppressions, with no exempt folders. For first adoption, review each finding, fix small repairs and record retained debt with `quality baseline write --first-adoption --rule effect/failure-honesty`, explaining each retained entry in the pull request. Subsequent debt follows the normal changed-file baseline contract; run `quality baseline tighten` after repairs.
|
|
66
|
+
|
|
55
67
|
### 1. Once per repository: connect the shared policy
|
|
56
68
|
|
|
57
69
|
A new repository needs no `quality.config.ts`. Quality checks sources from the current directory with every built-in rule at its default error level. Baseline entries for `packages/<package>/...` live in `packages/<package>/quality-baseline.jsonl`; entries outside packages live in the root `quality-baseline.jsonl`. A package with no entries has no shard file. Permanent exceptions belong in `quality.config.ts`.
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"resolve.d.ts","sourceRoot":"","sources":["../../src/config/resolve.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACtD,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,sBAAsB,CAAC;AACtD,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,UAAU,CAAC;AAIrC,MAAM,WAAW,aAAc,SAAQ,SAAS;IAC/C,QAAQ,CAAC,MAAM,EAAE,SAAS,UAAU,EAAE,CAAC;CACvC;
|
|
1
|
+
{"version":3,"file":"resolve.d.ts","sourceRoot":"","sources":["../../src/config/resolve.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACtD,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,sBAAsB,CAAC;AACtD,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,UAAU,CAAC;AAIrC,MAAM,WAAW,aAAc,SAAQ,SAAS;IAC/C,QAAQ,CAAC,MAAM,EAAE,SAAS,UAAU,EAAE,CAAC;CACvC;AA4CD,eAAO,MAAM,YAAY;;;;;;;;;;;;;;;;;;yDAmBvB,CAAC"}
|
package/dist/config/resolve.js
CHANGED
|
@@ -20,12 +20,15 @@ function activeRule(rule, check) {
|
|
|
20
20
|
};
|
|
21
21
|
}
|
|
22
22
|
function activate(rule, setting) {
|
|
23
|
-
return Effect.tryPromise({ catch: messageOf, try: () => rule.configure(optionsOf(setting)) }).pipe(Effect.
|
|
24
|
-
|
|
25
|
-
:
|
|
26
|
-
_tag: "
|
|
27
|
-
|
|
28
|
-
|
|
23
|
+
return Effect.tryPromise({ catch: messageOf, try: () => rule.configure(optionsOf(setting)) }).pipe(Effect.match({
|
|
24
|
+
onFailure: (failure) => ({ _tag: "Invalid", issues: [`rules.${rule.id}.options: validation threw: ${failure}`] }),
|
|
25
|
+
onSuccess: (configured) => configured._tag === "Invalid"
|
|
26
|
+
? { _tag: "Invalid", issues: configured.issues.map((issue) => `rules.${rule.id}.options: ${issue}`) }
|
|
27
|
+
: {
|
|
28
|
+
_tag: "Valid",
|
|
29
|
+
value: activeRule(rule, configured.check),
|
|
30
|
+
},
|
|
31
|
+
}));
|
|
29
32
|
}
|
|
30
33
|
export const resolveRules = Effect.fn("Config.resolveRules")(function* (config) {
|
|
31
34
|
const rules = [...builtInRules, ...(config.local ?? [])];
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"resolve.js","sourceRoot":"","sources":["../../src/config/resolve.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAKhC,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AASjD,SAAS,SAAS,CAAC,KAAc;IAChC,OAAO,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;AAC/D,CAAC;AAED,SAAS,SAAS,CAAC,OAA4B;IAC9C,OAAO,OAAO,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC;AAClE,CAAC;AAED,SAAS,eAAe,CAAC,KAAsB;IAC9C,OAAO,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CACpC,KAAK,CAAC,SAAS,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,EAAE,KAAK,IAAI,CAAC,EAAE,CAAC,KAAK,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,mBAAmB,IAAI,CAAC,EAAE,sBAAsB,CAAC,CACpH,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,IAAU,EAAE,KAA0B;IACzD,OAAO;QACN,KAAK;QACL,WAAW,EAAE,IAAI,CAAC,WAAW;QAC7B,MAAM,EAAE,IAAI,CAAC,MAAM,KAAK,IAAI;QAC5B,EAAE,EAAE,IAAI,CAAC,EAAE;QACX,KAAK,EAAE,OAAO;QACd,WAAW,EAAE,IAAI,CAAC,WAAW,KAAK,KAAK;KACvC,CAAC;AACH,CAAC;AAED,SAAS,QAAQ,CAAC,IAAU,EAAE,OAA4B;IACzD,OAAO,MAAM,CAAC,UAAU,CAAC,EAAE,KAAK,EAAE,SAAS,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,CAAC,IAAI,CACjG,MAAM,CAAC,
|
|
1
|
+
{"version":3,"file":"resolve.js","sourceRoot":"","sources":["../../src/config/resolve.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAKhC,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AASjD,SAAS,SAAS,CAAC,KAAc;IAChC,OAAO,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;AAC/D,CAAC;AAED,SAAS,SAAS,CAAC,OAA4B;IAC9C,OAAO,OAAO,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC;AAClE,CAAC;AAED,SAAS,eAAe,CAAC,KAAsB;IAC9C,OAAO,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CACpC,KAAK,CAAC,SAAS,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,EAAE,KAAK,IAAI,CAAC,EAAE,CAAC,KAAK,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,mBAAmB,IAAI,CAAC,EAAE,sBAAsB,CAAC,CACpH,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,IAAU,EAAE,KAA0B;IACzD,OAAO;QACN,KAAK;QACL,WAAW,EAAE,IAAI,CAAC,WAAW;QAC7B,MAAM,EAAE,IAAI,CAAC,MAAM,KAAK,IAAI;QAC5B,EAAE,EAAE,IAAI,CAAC,EAAE;QACX,KAAK,EAAE,OAAO;QACd,WAAW,EAAE,IAAI,CAAC,WAAW,KAAK,KAAK;KACvC,CAAC;AACH,CAAC;AAED,SAAS,QAAQ,CAAC,IAAU,EAAE,OAA4B;IACzD,OAAO,MAAM,CAAC,UAAU,CAAC,EAAE,KAAK,EAAE,SAAS,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,CAAC,IAAI,CACjG,MAAM,CAAC,KAAK,CAAC;QACZ,SAAS,EAAE,CAAC,OAAO,EAAuB,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC,SAAS,IAAI,CAAC,EAAE,+BAA+B,OAAO,EAAE,CAAC,EAAE,CAAC;QACtI,SAAS,EAAE,CAAC,UAAU,EAAuB,EAAE,CAC9C,UAAU,CAAC,IAAI,KAAK,SAAS;YAC5B,CAAC,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,MAAM,EAAE,UAAU,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,SAAS,IAAI,CAAC,EAAE,aAAa,KAAK,EAAE,CAAC,EAAE;YACrG,CAAC,CAAC;gBACA,IAAI,EAAE,OAAO;gBACb,KAAK,EAAE,UAAU,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,CAAC;aACzC;KACJ,CAAC,CACF,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,YAAY,GAAG,MAAM,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,QAAQ,CAAC,EAAE,MAAmB;IAC1F,MAAM,KAAK,GAAoB,CAAC,GAAG,YAAY,EAAE,GAAG,CAAC,MAAM,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,CAAC;IAC1E,MAAM,QAAQ,GAAG,MAAM,CAAC,KAAK,IAAI,EAAE,CAAC;IACpC,MAAM,KAAK,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC;IACpD,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,KAAK,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC;IAC9F,MAAM,OAAO,GAAG;QACf,GAAG,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC;aACtB,MAAM,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;aAC9B,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,SAAS,EAAE,EAAE,CAAC;KAC5B,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,GAAG,IAAI,yCAAyC,CAAC,CAAC;IAClE,MAAM,SAAS,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,KAAK,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IAC5F,MAAM,MAAM,GAAG,CAAC,GAAG,eAAe,CAAC,KAAK,CAAC,EAAE,GAAG,OAAO,EAAE,GAAG,SAAS,CAAC,OAAO,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC,MAAM,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IAC3I,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACvB,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC;IACpC,CAAC;IACD,MAAM,MAAM,GAAG,SAAS,CAAC,OAAO,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC,MAAM,CAAC,IAAI,KAAK,OAAO,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAC9F,MAAM,MAAM,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,EAAE,EAAE,OAAgB,CAAC,CAAC,CAAC,CAAC;IACzE,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,KAAK,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC;IACzG,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,aAAa,EAAE,EAAE,CAAC;AAC9E,CAAC,CAAC,CAAC"}
|
package/dist/rules/builtIn.d.ts
CHANGED
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
export declare const builtInRules: readonly [import("../rule.ts").Rule<"code/unused", undefined, import("../rule.ts").RuleServices>, import("../rule.ts").Rule<"effect/boundary", undefined, never>, import("../rule.ts").Rule<"effect/service-parameters", undefined, never>, import("../rule.ts").Rule<"react/jsx-conditionals", undefined, never>, import("../rule.ts").Rule<"structure/max-lines", {
|
|
1
|
+
export declare const builtInRules: readonly [import("../rule.ts").Rule<"code/unused", undefined, import("../rule.ts").RuleServices>, import("../rule.ts").Rule<"effect/boundary", undefined, never>, import("../rule.ts").Rule<"effect/failure-honesty", undefined, never>, import("../rule.ts").Rule<"effect/service-parameters", undefined, never>, import("../rule.ts").Rule<"react/jsx-conditionals", undefined, never>, import("../rule.ts").Rule<"structure/max-lines", {
|
|
2
2
|
readonly source?: number;
|
|
3
3
|
readonly test?: number;
|
|
4
4
|
}, never>, import("../rule.ts").Rule<"nesting/max-depth", undefined, never>, import("../rule.ts").Rule<"structure/no-barrel", undefined, never>, import("../rule.ts").Rule<"comments/no-jsdoc", {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"builtIn.d.ts","sourceRoot":"","sources":["../../src/rules/builtIn.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"builtIn.d.ts","sourceRoot":"","sources":["../../src/rules/builtIn.ts"],"names":[],"mappings":"AAuDA,eAAO,MAAM,YAAY;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;sWAuDf,CAAC"}
|
package/dist/rules/builtIn.js
CHANGED
|
@@ -8,6 +8,7 @@ import { noTodo } from "#rules/comments/noTodo.ts";
|
|
|
8
8
|
import { docsReferences } from "#rules/docs/references.ts";
|
|
9
9
|
import { docsUnversionedInstalls } from "#rules/docs/unversionedInstalls.ts";
|
|
10
10
|
import { effectBoundary } from "#rules/effect/boundary.ts";
|
|
11
|
+
import { failureHonesty } from "#rules/effect/failureHonesty.ts";
|
|
11
12
|
import { serviceParameters } from "#rules/effect/serviceParameters.ts";
|
|
12
13
|
import { distinctCase } from "#rules/files/distinctCase.ts";
|
|
13
14
|
import { folderNames } from "#rules/files/folderNames.ts";
|
|
@@ -54,6 +55,7 @@ import { unusedCode } from "./unusedCode.js";
|
|
|
54
55
|
export const builtInRules = [
|
|
55
56
|
unusedCode,
|
|
56
57
|
effectBoundary,
|
|
58
|
+
failureHonesty,
|
|
57
59
|
serviceParameters,
|
|
58
60
|
jsxConditionals,
|
|
59
61
|
maxLines,
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"builtIn.js","sourceRoot":"","sources":["../../src/rules/builtIn.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,+BAA+B,CAAC;AAC3D,OAAO,EAAE,QAAQ,EAAE,MAAM,6BAA6B,CAAC;AACvD,OAAO,EAAE,mBAAmB,EAAE,MAAM,wCAAwC,CAAC;AAC7E,OAAO,EAAE,OAAO,EAAE,MAAM,4BAA4B,CAAC;AACrD,OAAO,EAAE,eAAe,EAAE,MAAM,oCAAoC,CAAC;AACrE,OAAO,EAAE,aAAa,EAAE,MAAM,kCAAkC,CAAC;AACjE,OAAO,EAAE,MAAM,EAAE,MAAM,2BAA2B,CAAC;AACnD,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,uBAAuB,EAAE,MAAM,oCAAoC,CAAC;AAC7E,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,iBAAiB,EAAE,MAAM,oCAAoC,CAAC;AACvE,OAAO,EAAE,YAAY,EAAE,MAAM,8BAA8B,CAAC;AAC5D,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAC;AAC1D,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAC;AACpE,OAAO,EAAE,UAAU,EAAE,MAAM,4BAA4B,CAAC;AACxD,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,YAAY,EAAE,MAAM,0BAA0B,CAAC;AACxD,OAAO,EAAE,YAAY,EAAE,MAAM,0BAA0B,CAAC;AACxD,OAAO,EAAE,eAAe,EAAE,MAAM,4BAA4B,CAAC;AAC7D,OAAO,EAAE,UAAU,EAAE,MAAM,8BAA8B,CAAC;AAC1D,OAAO,EAAE,iBAAiB,EAAE,MAAM,8BAA8B,CAAC;AACjE,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,eAAe,EAAE,MAAM,iCAAiC,CAAC;AAClE,OAAO,EAAE,OAAO,EAAE,MAAM,2BAA2B,CAAC;AACpD,OAAO,EAAE,cAAc,EAAE,MAAM,kCAAkC,CAAC;AAClE,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AACvD,OAAO,EAAE,eAAe,EAAE,MAAM,mCAAmC,CAAC;AACpE,OAAO,EAAE,UAAU,EAAE,MAAM,8BAA8B,CAAC;AAC1D,OAAO,EAAE,WAAW,EAAE,MAAM,+BAA+B,CAAC;AAC5D,OAAO,EAAE,QAAQ,EAAE,MAAM,4BAA4B,CAAC;AACtD,OAAO,EAAE,cAAc,EAAE,MAAM,kCAAkC,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,4BAA4B,CAAC;AACtD,OAAO,EAAE,UAAU,EAAE,MAAM,yBAAyB,CAAC;AACrD,OAAO,EAAE,WAAW,EAAE,MAAM,+BAA+B,CAAC;AAC5D,OAAO,EAAE,UAAU,EAAE,MAAM,yBAAyB,CAAC;AACrD,OAAO,EAAE,YAAY,EAAE,MAAM,gCAAgC,CAAC;AAC9D,OAAO,EAAE,cAAc,EAAE,MAAM,uCAAuC,CAAC;AACvE,OAAO,EAAE,gBAAgB,EAAE,MAAM,yCAAyC,CAAC;AAC3E,OAAO,EAAE,YAAY,EAAE,MAAM,qCAAqC,CAAC;AACnE,OAAO,EAAE,oBAAoB,EAAE,MAAM,6CAA6C,CAAC;AACnF,OAAO,EAAE,QAAQ,EAAE,MAAM,iCAAiC,CAAC;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,gCAAgC,CAAC;AAChE,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAC;AAC1D,OAAO,EAAE,KAAK,EAAE,MAAM,YAAY,CAAC;AACnC,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,qBAAqB,EAAE,MAAM,4BAA4B,CAAC;AACnE,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AACvD,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAE7C,MAAM,CAAC,MAAM,YAAY,GAAG;IAC3B,UAAU;IACV,cAAc;IACd,iBAAiB;IACjB,eAAe;IACf,QAAQ;IACR,QAAQ;IACR,QAAQ;IACR,OAAO;IACP,eAAe;IACf,aAAa;IACb,QAAQ;IACR,MAAM;IACN,mBAAmB;IACnB,UAAU;IACV,cAAc;IACd,uBAAuB;IACvB,QAAQ;IACR,YAAY;IACZ,oBAAoB;IACpB,cAAc;IACd,gBAAgB;IAChB,KAAK;IACL,YAAY;IACZ,YAAY;IACZ,cAAc;IACd,iBAAiB;IACjB,eAAe;IACf,cAAc;IACd,UAAU;IACV,cAAc;IACd,eAAe;IACf,oBAAoB;IACpB,qBAAqB;IACrB,oBAAoB;IACpB,gBAAgB;IAChB,WAAW;IACX,YAAY;IACZ,UAAU;IACV,WAAW;IACX,cAAc;IACd,UAAU;IACV,UAAU;IACV,WAAW;IACX,QAAQ;IACR,OAAO;IACP,QAAQ;IACR,WAAW;IACX,UAAU;IACV,WAAW;IACX,cAAc;IACd,cAAc;IACd,eAAe;IACf,YAAY;CACH,CAAC"}
|
|
1
|
+
{"version":3,"file":"builtIn.js","sourceRoot":"","sources":["../../src/rules/builtIn.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,+BAA+B,CAAC;AAC3D,OAAO,EAAE,QAAQ,EAAE,MAAM,6BAA6B,CAAC;AACvD,OAAO,EAAE,mBAAmB,EAAE,MAAM,wCAAwC,CAAC;AAC7E,OAAO,EAAE,OAAO,EAAE,MAAM,4BAA4B,CAAC;AACrD,OAAO,EAAE,eAAe,EAAE,MAAM,oCAAoC,CAAC;AACrE,OAAO,EAAE,aAAa,EAAE,MAAM,kCAAkC,CAAC;AACjE,OAAO,EAAE,MAAM,EAAE,MAAM,2BAA2B,CAAC;AACnD,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,uBAAuB,EAAE,MAAM,oCAAoC,CAAC;AAC7E,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,iCAAiC,CAAC;AACjE,OAAO,EAAE,iBAAiB,EAAE,MAAM,oCAAoC,CAAC;AACvE,OAAO,EAAE,YAAY,EAAE,MAAM,8BAA8B,CAAC;AAC5D,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAC;AAC1D,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAC;AACpE,OAAO,EAAE,UAAU,EAAE,MAAM,4BAA4B,CAAC;AACxD,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,YAAY,EAAE,MAAM,0BAA0B,CAAC;AACxD,OAAO,EAAE,YAAY,EAAE,MAAM,0BAA0B,CAAC;AACxD,OAAO,EAAE,eAAe,EAAE,MAAM,4BAA4B,CAAC;AAC7D,OAAO,EAAE,UAAU,EAAE,MAAM,8BAA8B,CAAC;AAC1D,OAAO,EAAE,iBAAiB,EAAE,MAAM,8BAA8B,CAAC;AACjE,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAC3D,OAAO,EAAE,eAAe,EAAE,MAAM,iCAAiC,CAAC;AAClE,OAAO,EAAE,OAAO,EAAE,MAAM,2BAA2B,CAAC;AACpD,OAAO,EAAE,cAAc,EAAE,MAAM,kCAAkC,CAAC;AAClE,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AACvD,OAAO,EAAE,eAAe,EAAE,MAAM,mCAAmC,CAAC;AACpE,OAAO,EAAE,UAAU,EAAE,MAAM,8BAA8B,CAAC;AAC1D,OAAO,EAAE,WAAW,EAAE,MAAM,+BAA+B,CAAC;AAC5D,OAAO,EAAE,QAAQ,EAAE,MAAM,4BAA4B,CAAC;AACtD,OAAO,EAAE,cAAc,EAAE,MAAM,kCAAkC,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,4BAA4B,CAAC;AACtD,OAAO,EAAE,UAAU,EAAE,MAAM,yBAAyB,CAAC;AACrD,OAAO,EAAE,WAAW,EAAE,MAAM,+BAA+B,CAAC;AAC5D,OAAO,EAAE,UAAU,EAAE,MAAM,yBAAyB,CAAC;AACrD,OAAO,EAAE,YAAY,EAAE,MAAM,gCAAgC,CAAC;AAC9D,OAAO,EAAE,cAAc,EAAE,MAAM,uCAAuC,CAAC;AACvE,OAAO,EAAE,gBAAgB,EAAE,MAAM,yCAAyC,CAAC;AAC3E,OAAO,EAAE,YAAY,EAAE,MAAM,qCAAqC,CAAC;AACnE,OAAO,EAAE,oBAAoB,EAAE,MAAM,6CAA6C,CAAC;AACnF,OAAO,EAAE,QAAQ,EAAE,MAAM,iCAAiC,CAAC;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,gCAAgC,CAAC;AAChE,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAC;AAC1D,OAAO,EAAE,KAAK,EAAE,MAAM,YAAY,CAAC;AACnC,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,qBAAqB,EAAE,MAAM,4BAA4B,CAAC;AACnE,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AACvD,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAE7C,MAAM,CAAC,MAAM,YAAY,GAAG;IAC3B,UAAU;IACV,cAAc;IACd,cAAc;IACd,iBAAiB;IACjB,eAAe;IACf,QAAQ;IACR,QAAQ;IACR,QAAQ;IACR,OAAO;IACP,eAAe;IACf,aAAa;IACb,QAAQ;IACR,MAAM;IACN,mBAAmB;IACnB,UAAU;IACV,cAAc;IACd,uBAAuB;IACvB,QAAQ;IACR,YAAY;IACZ,oBAAoB;IACpB,cAAc;IACd,gBAAgB;IAChB,KAAK;IACL,YAAY;IACZ,YAAY;IACZ,cAAc;IACd,iBAAiB;IACjB,eAAe;IACf,cAAc;IACd,UAAU;IACV,cAAc;IACd,eAAe;IACf,oBAAoB;IACpB,qBAAqB;IACrB,oBAAoB;IACpB,gBAAgB;IAChB,WAAW;IACX,YAAY;IACZ,UAAU;IACV,WAAW;IACX,cAAc;IACd,UAAU;IACV,UAAU;IACV,WAAW;IACX,QAAQ;IACR,OAAO;IACP,QAAQ;IACR,WAAW;IACX,UAAU;IACV,WAAW;IACX,cAAc;IACd,cAAc;IACd,eAAe;IACf,YAAY;CACH,CAAC"}
|
|
@@ -0,0 +1,8 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
interface FailureFinding {
|
|
3
|
+
readonly message: string;
|
|
4
|
+
readonly node: ts.Node;
|
|
5
|
+
}
|
|
6
|
+
export declare function failureFindings(checker: ts.TypeChecker, node: ts.CallExpression): readonly FailureFinding[];
|
|
7
|
+
export {};
|
|
8
|
+
//# sourceMappingURL=failureFindings.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"failureFindings.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/failureFindings.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAI5B,UAAU,cAAc;IACvB,QAAQ,CAAC,OAAO,EAAE,MAAM,CAAC;IACzB,QAAQ,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC;CACvB;AAyBD,wBAAgB,eAAe,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE,IAAI,EAAE,EAAE,CAAC,cAAc,GAAG,SAAS,cAAc,EAAE,CAsB3G"}
|
|
@@ -0,0 +1,47 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { effectName, failureOperations, fileSystemCall } from "./failureOperations.js";
|
|
3
|
+
import { successRecovery } from "./successRecovery.js";
|
|
4
|
+
function unboundedRetry(node) {
|
|
5
|
+
const options = node.arguments.at(-1);
|
|
6
|
+
if (options === undefined || !ts.isObjectLiteralExpression(options)) {
|
|
7
|
+
return false;
|
|
8
|
+
}
|
|
9
|
+
const names = options.properties.flatMap((property) => (property.name === undefined ? [] : [property.name.getText().replaceAll(/["']/gu, "")]));
|
|
10
|
+
return names.includes("while") && !names.includes("times") && !names.includes("schedule") && !options.properties.some(ts.isSpreadAssignment);
|
|
11
|
+
}
|
|
12
|
+
function operationFailure(checker, operation, before) {
|
|
13
|
+
if (["option", "orElseSucceed"].includes(operation.name) && before.some((part) => fileSystemCall(checker, part.node))) {
|
|
14
|
+
return "FileSystem failure becomes absence or success. Catch a named reason such as NotFound, re-fail other errors, or return an explicit unavailable state.";
|
|
15
|
+
}
|
|
16
|
+
if (/^fork(?:Scoped|In|Detach|Daemon|Child)?$/u.test(operation.name)) {
|
|
17
|
+
const names = before.map((part) => part.name);
|
|
18
|
+
const forever = names.indexOf("forever");
|
|
19
|
+
if (forever !== -1 && names.indexOf("orDie", forever + 1) !== -1) {
|
|
20
|
+
return "Forked forever loop dies on failure. Catch a named reason within each iteration with a Schedule-bounded retry, or expose an explicit unavailable state and supervise termination.";
|
|
21
|
+
}
|
|
22
|
+
}
|
|
23
|
+
return undefined;
|
|
24
|
+
}
|
|
25
|
+
export function failureFindings(checker, node) {
|
|
26
|
+
const findings = [];
|
|
27
|
+
const name = effectName(checker, node.expression);
|
|
28
|
+
if (name === "retry" && unboundedRetry(node)) {
|
|
29
|
+
findings.push({ message: "Retry has while without times or schedule. Use a Schedule-bounded retry and preserve the final typed failure.", node });
|
|
30
|
+
}
|
|
31
|
+
const handler = node.arguments.at(-1);
|
|
32
|
+
if (["catch", "catchAll", "catchCause", "catchAllCause"].includes(name ?? "") && handler !== undefined && successRecovery(checker, handler)) {
|
|
33
|
+
findings.push({
|
|
34
|
+
message: "Catch turns every failure into success. Catch a named reason with catchTag or catchIf and re-fail the rest, or model an explicit unavailable state.",
|
|
35
|
+
node,
|
|
36
|
+
});
|
|
37
|
+
}
|
|
38
|
+
const operations = failureOperations(checker, node);
|
|
39
|
+
for (const [index, operation] of operations.entries()) {
|
|
40
|
+
const message = operationFailure(checker, operation, operations.slice(0, index));
|
|
41
|
+
if (message !== undefined) {
|
|
42
|
+
findings.push({ message, node: operation.node });
|
|
43
|
+
}
|
|
44
|
+
}
|
|
45
|
+
return findings;
|
|
46
|
+
}
|
|
47
|
+
//# sourceMappingURL=failureFindings.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"failureFindings.js","sourceRoot":"","sources":["../../../src/rules/effect/failureFindings.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAyB,iBAAiB,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAC9G,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AAOvD,SAAS,cAAc,CAAC,IAAuB;IAC9C,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACtC,IAAI,OAAO,KAAK,SAAS,IAAI,CAAC,EAAE,CAAC,yBAAyB,CAAC,OAAO,CAAC,EAAE,CAAC;QACrE,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,KAAK,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,QAAQ,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,UAAU,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IAChJ,OAAO,KAAK,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC,kBAAkB,CAAC,CAAC;AAC9I,CAAC;AAED,SAAS,gBAAgB,CAAC,OAAuB,EAAE,SAA2B,EAAE,MAAmC;IAClH,IAAI,CAAC,QAAQ,EAAE,eAAe,CAAC,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,OAAO,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC;QACvH,OAAO,sJAAsJ,CAAC;IAC/J,CAAC;IACD,IAAI,2CAA2C,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,EAAE,CAAC;QACtE,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC9C,MAAM,OAAO,GAAG,KAAK,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;QACzC,IAAI,OAAO,KAAK,CAAC,CAAC,IAAI,KAAK,CAAC,OAAO,CAAC,OAAO,EAAE,OAAO,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;YAClE,OAAO,mLAAmL,CAAC;QAC5L,CAAC;IACF,CAAC;IACD,OAAO,SAAS,CAAC;AAClB,CAAC;AAED,MAAM,UAAU,eAAe,CAAC,OAAuB,EAAE,IAAuB;IAC/E,MAAM,QAAQ,GAAqB,EAAE,CAAC;IACtC,MAAM,IAAI,GAAG,UAAU,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,CAAC,CAAC;IAClD,IAAI,IAAI,KAAK,OAAO,IAAI,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;QAC9C,QAAQ,CAAC,IAAI,CAAC,EAAE,OAAO,EAAE,+GAA+G,EAAE,IAAI,EAAE,CAAC,CAAC;IACnJ,CAAC;IACD,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACtC,IAAI,CAAC,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,eAAe,CAAC,CAAC,QAAQ,CAAC,IAAI,IAAI,EAAE,CAAC,IAAI,OAAO,KAAK,SAAS,IAAI,eAAe,CAAC,OAAO,EAAE,OAAO,CAAC,EAAE,CAAC;QAC7I,QAAQ,CAAC,IAAI,CAAC;YACb,OAAO,EACN,qJAAqJ;YACtJ,IAAI;SACJ,CAAC,CAAC;IACJ,CAAC;IACD,MAAM,UAAU,GAAG,iBAAiB,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;IACpD,KAAK,MAAM,CAAC,KAAK,EAAE,SAAS,CAAC,IAAI,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC;QACvD,MAAM,OAAO,GAAG,gBAAgB,CAAC,OAAO,EAAE,SAAS,EAAE,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC,CAAC;QACjF,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YAC3B,QAAQ,CAAC,IAAI,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,SAAS,CAAC,IAAI,EAAE,CAAC,CAAC;QAClD,CAAC;IACF,CAAC;IACD,OAAO,QAAQ,CAAC;AACjB,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"failureHonesty.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/failureHonesty.ts"],"names":[],"mappings":"AAmCA,eAAO,MAAM,cAAc,qEAuBzB,CAAC"}
|
|
@@ -0,0 +1,53 @@
|
|
|
1
|
+
import { join } from "node:path";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import { defineRule } from "#rule.ts";
|
|
4
|
+
import { failureFindings } from "./failureFindings.js";
|
|
5
|
+
import { effectProgram } from "./program.js";
|
|
6
|
+
function checkFailures(inputs) {
|
|
7
|
+
const program = effectProgram(inputs, false);
|
|
8
|
+
const checker = program.getTypeChecker();
|
|
9
|
+
return inputs.sources.flatMap((file) => {
|
|
10
|
+
const source = program.getSourceFile(join(inputs.root, file.path));
|
|
11
|
+
const findings = [];
|
|
12
|
+
const reported = new Set();
|
|
13
|
+
function report(node, message) {
|
|
14
|
+
const key = `${node.pos}:${message}`;
|
|
15
|
+
if (source !== undefined && !reported.has(key)) {
|
|
16
|
+
reported.add(key);
|
|
17
|
+
findings.push({ file: file.path, line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1, message });
|
|
18
|
+
}
|
|
19
|
+
}
|
|
20
|
+
function visit(node) {
|
|
21
|
+
if (ts.isCallExpression(node)) {
|
|
22
|
+
for (const finding of failureFindings(checker, node)) {
|
|
23
|
+
report(finding.node, finding.message);
|
|
24
|
+
}
|
|
25
|
+
}
|
|
26
|
+
ts.forEachChild(node, visit);
|
|
27
|
+
}
|
|
28
|
+
if (source !== undefined) {
|
|
29
|
+
visit(source);
|
|
30
|
+
}
|
|
31
|
+
return findings;
|
|
32
|
+
});
|
|
33
|
+
}
|
|
34
|
+
export const failureHonesty = defineRule({
|
|
35
|
+
check: (inputs) => {
|
|
36
|
+
const groups = new Map();
|
|
37
|
+
for (const source of inputs.sources) {
|
|
38
|
+
if (!(/\.[cm]?[jt]sx?$/u.test(source.path)
|
|
39
|
+
&& /\b(?:catch|catchAll|catchCause|catchAllCause|retry|forever|option|orElseSucceed)\b/u.test(source.text))) {
|
|
40
|
+
continue;
|
|
41
|
+
}
|
|
42
|
+
const group = /^(?:packages|examples)\/[^/]+/u.exec(source.path)?.[0] ?? ".";
|
|
43
|
+
const sources = groups.get(group) ?? [];
|
|
44
|
+
sources.push(source);
|
|
45
|
+
groups.set(group, sources);
|
|
46
|
+
}
|
|
47
|
+
return [...groups.values()].flatMap((sources) => checkFailures({ ...inputs, sources }));
|
|
48
|
+
},
|
|
49
|
+
description: "Keep failures typed and observable: no forked forever/orDie loops, retry({ while }) without a bound, blanket catch-to-success, or FileSystem option/orElseSucceed. Catch a named reason, use a Schedule-bounded retry or model an explicit unavailable state. No config exceptions or inline suppressions; baseline existing debt.",
|
|
50
|
+
id: "effect/failure-honesty",
|
|
51
|
+
registrable: false,
|
|
52
|
+
});
|
|
53
|
+
//# sourceMappingURL=failureHonesty.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"failureHonesty.js","sourceRoot":"","sources":["../../../src/rules/effect/failureHonesty.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AACvD,OAAO,EAAE,aAAa,EAAE,MAAM,cAAc,CAAC;AAE7C,SAAS,aAAa,CAAC,MAAkB;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;IAC7C,MAAM,OAAO,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IACzC,OAAO,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACtC,MAAM,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QACnE,MAAM,QAAQ,GAAc,EAAE,CAAC;QAC/B,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;QACnC,SAAS,MAAM,CAAC,IAAa,EAAE,OAAe;YAC7C,MAAM,GAAG,GAAG,GAAG,IAAI,CAAC,GAAG,IAAI,OAAO,EAAE,CAAC;YACrC,IAAI,MAAM,KAAK,SAAS,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;gBAChD,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;gBAClB,QAAQ,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE,MAAM,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC,EAAE,OAAO,EAAE,CAAC,CAAC;YACzH,CAAC;QACF,CAAC;QACD,SAAS,KAAK,CAAC,IAAa;YAC3B,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC/B,KAAK,MAAM,OAAO,IAAI,eAAe,CAAC,OAAO,EAAE,IAAI,CAAC,EAAE,CAAC;oBACtD,MAAM,CAAC,OAAO,CAAC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,CAAC;gBACvC,CAAC;YACF,CAAC;YACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QAC9B,CAAC;QACD,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,KAAK,CAAC,MAAM,CAAC,CAAC;QACf,CAAC;QACD,OAAO,QAAQ,CAAC;IACjB,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,MAAM,CAAC,MAAM,cAAc,GAAG,UAAU,CAAC;IACxC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE;QACjB,MAAM,MAAM,GAAG,IAAI,GAAG,EAA2C,CAAC;QAClE,KAAK,MAAM,MAAM,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;YACrC,IACC,CAAC,CACA,kBAAkB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC;mBACjC,qFAAqF,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,CAC1G,EACA,CAAC;gBACF,SAAS;YACV,CAAC;YACD,MAAM,KAAK,GAAG,gCAAgC,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC;YAC7E,MAAM,OAAO,GAAG,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;YACxC,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;YACrB,MAAM,CAAC,GAAG,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC;QAC5B,CAAC;QACD,OAAO,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,aAAa,CAAC,EAAE,GAAG,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC;IACzF,CAAC;IACD,WAAW,EACV,oUAAoU;IACrU,EAAE,EAAE,wBAAwB;IAC5B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
|
|
@@ -0,0 +1,9 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
export interface FailureOperation {
|
|
3
|
+
readonly name: string;
|
|
4
|
+
readonly node: ts.Node;
|
|
5
|
+
}
|
|
6
|
+
export declare function effectName(checker: ts.TypeChecker, node: ts.Node): string | undefined;
|
|
7
|
+
export declare function failureOperations(checker: ts.TypeChecker, node: ts.Node, seen?: Set<ts.Symbol>): FailureOperation[];
|
|
8
|
+
export declare function fileSystemCall(checker: ts.TypeChecker, node: ts.Node): boolean;
|
|
9
|
+
//# sourceMappingURL=failureOperations.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"failureOperations.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/failureOperations.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAG5B,MAAM,WAAW,gBAAgB;IAChC,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IACtB,QAAQ,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC;CACvB;AAED,wBAAgB,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE,IAAI,EAAE,EAAE,CAAC,IAAI,GAAG,MAAM,GAAG,SAAS,CAErF;AAED,wBAAgB,iBAAiB,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE,IAAI,EAAE,EAAE,CAAC,IAAI,EAAE,IAAI,iBAAuB,GAAG,gBAAgB,EAAE,CA2BzH;AAoBD,wBAAgB,cAAc,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE,IAAI,EAAE,EAAE,CAAC,IAAI,GAAG,OAAO,CAM9E"}
|
|
@@ -0,0 +1,55 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { boundaryReference } from "./boundaryReference.js";
|
|
3
|
+
export function effectName(checker, node) {
|
|
4
|
+
return /^effect(?:\.Effect|\/Effect)\.(?<name>\w+)$/u.exec(boundaryReference(checker, node) ?? "")?.groups?.name;
|
|
5
|
+
}
|
|
6
|
+
export function failureOperations(checker, node, seen = new Set()) {
|
|
7
|
+
if (ts.isParenthesizedExpression(node)) {
|
|
8
|
+
return failureOperations(checker, node.expression, seen);
|
|
9
|
+
}
|
|
10
|
+
if (ts.isIdentifier(node)) {
|
|
11
|
+
const symbol = checker.getSymbolAtLocation(node);
|
|
12
|
+
if (symbol !== undefined && !seen.has(symbol)) {
|
|
13
|
+
seen.add(symbol);
|
|
14
|
+
const declaration = symbol.valueDeclaration;
|
|
15
|
+
if (declaration !== undefined && ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
16
|
+
return failureOperations(checker, declaration.initializer, seen);
|
|
17
|
+
}
|
|
18
|
+
}
|
|
19
|
+
}
|
|
20
|
+
if (ts.isCallExpression(node) && ts.isPropertyAccessExpression(node.expression) && node.expression.name.text === "pipe") {
|
|
21
|
+
return [
|
|
22
|
+
failureOperations(checker, node.expression.expression, seen),
|
|
23
|
+
...node.arguments.map((part) => failureOperations(checker, part, new Set(seen))),
|
|
24
|
+
].flat();
|
|
25
|
+
}
|
|
26
|
+
const name = effectName(checker, ts.isCallExpression(node) ? node.expression : node);
|
|
27
|
+
if (name === undefined) {
|
|
28
|
+
return [{ name: "source", node }];
|
|
29
|
+
}
|
|
30
|
+
const args = ts.isCallExpression(node) ? node.arguments : [];
|
|
31
|
+
const first = args[0];
|
|
32
|
+
return [...(first === undefined ? [] : failureOperations(checker, first, seen)), { name, node }];
|
|
33
|
+
}
|
|
34
|
+
function fileSystemService(checker, node, seen = new Set()) {
|
|
35
|
+
if (/^effect(?:\.FileSystem|\/FileSystem)\.FileSystem$/u.test(boundaryReference(checker, node) ?? "")) {
|
|
36
|
+
return true;
|
|
37
|
+
}
|
|
38
|
+
if (ts.isYieldExpression(node) || ts.isParenthesizedExpression(node)) {
|
|
39
|
+
return node.expression !== undefined && fileSystemService(checker, node.expression, seen);
|
|
40
|
+
}
|
|
41
|
+
const symbol = checker.getSymbolAtLocation(node);
|
|
42
|
+
if (symbol === undefined || seen.has(symbol)) {
|
|
43
|
+
return false;
|
|
44
|
+
}
|
|
45
|
+
seen.add(symbol);
|
|
46
|
+
return (symbol.declarations ?? []).some((declaration) => ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined && fileSystemService(checker, declaration.initializer, seen));
|
|
47
|
+
}
|
|
48
|
+
export function fileSystemCall(checker, node) {
|
|
49
|
+
if (!ts.isCallExpression(node)) {
|
|
50
|
+
return false;
|
|
51
|
+
}
|
|
52
|
+
const callee = node.expression;
|
|
53
|
+
return (ts.isPropertyAccessExpression(callee) || ts.isElementAccessExpression(callee)) && fileSystemService(checker, callee.expression);
|
|
54
|
+
}
|
|
55
|
+
//# sourceMappingURL=failureOperations.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"failureOperations.js","sourceRoot":"","sources":["../../../src/rules/effect/failureOperations.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAC;AAO3D,MAAM,UAAU,UAAU,CAAC,OAAuB,EAAE,IAAa;IAChE,OAAO,8CAA8C,CAAC,IAAI,CAAC,iBAAiB,CAAC,OAAO,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,EAAE,MAAM,EAAE,IAAI,CAAC;AAClH,CAAC;AAED,MAAM,UAAU,iBAAiB,CAAC,OAAuB,EAAE,IAAa,EAAE,IAAI,GAAG,IAAI,GAAG,EAAa;IACpG,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;QACxC,OAAO,iBAAiB,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,CAAC;IAC1D,CAAC;IACD,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QACjD,IAAI,MAAM,KAAK,SAAS,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;YAC/C,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;YACjB,MAAM,WAAW,GAAG,MAAM,CAAC,gBAAgB,CAAC;YAC5C,IAAI,WAAW,KAAK,SAAS,IAAI,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,WAAW,CAAC,WAAW,KAAK,SAAS,EAAE,CAAC;gBACjH,OAAO,iBAAiB,CAAC,OAAO,EAAE,WAAW,CAAC,WAAW,EAAE,IAAI,CAAC,CAAC;YAClE,CAAC;QACF,CAAC;IACF,CAAC;IACD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,MAAM,EAAE,CAAC;QACzH,OAAO;YACN,iBAAiB,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,CAAC,UAAU,EAAE,IAAI,CAAC;YAC5D,GAAG,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,iBAAiB,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;SAChF,CAAC,IAAI,EAAE,CAAC;IACV,CAAC;IACD,MAAM,IAAI,GAAG,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;IACrF,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;IACnC,CAAC;IACD,MAAM,IAAI,GAAG,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC;IAC7D,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;IACtB,OAAO,CAAC,GAAG,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,iBAAiB,CAAC,OAAO,EAAE,KAAK,EAAE,IAAI,CAAC,CAAC,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;AAClG,CAAC;AAED,SAAS,iBAAiB,CAAC,OAAuB,EAAE,IAAa,EAAE,IAAI,GAAG,IAAI,GAAG,EAAa;IAC7F,IAAI,oDAAoD,CAAC,IAAI,CAAC,iBAAiB,CAAC,OAAO,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC;QACvG,OAAO,IAAI,CAAC;IACb,CAAC;IACD,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;QACtE,OAAO,IAAI,CAAC,UAAU,KAAK,SAAS,IAAI,iBAAiB,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,CAAC;IAC3F,CAAC;IACD,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;IACjD,IAAI,MAAM,KAAK,SAAS,IAAI,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;QAC9C,OAAO,KAAK,CAAC;IACd,CAAC;IACD,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;IACjB,OAAO,CAAC,MAAM,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC,IAAI,CACtC,CAAC,WAAW,EAAE,EAAE,CACf,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,WAAW,CAAC,WAAW,KAAK,SAAS,IAAI,iBAAiB,CAAC,OAAO,EAAE,WAAW,CAAC,WAAW,EAAE,IAAI,CAAC,CAC5I,CAAC;AACH,CAAC;AAED,MAAM,UAAU,cAAc,CAAC,OAAuB,EAAE,IAAa;IACpE,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;QAChC,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC;IAC/B,OAAO,CAAC,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,MAAM,CAAC,CAAC,IAAI,iBAAiB,CAAC,OAAO,EAAE,MAAM,CAAC,UAAU,CAAC,CAAC;AACzI,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"successRecovery.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/successRecovery.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAwB5B,wBAAgB,eAAe,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE,OAAO,EAAE,EAAE,CAAC,IAAI,EAAE,IAAI,iBAAuB,GAAG,OAAO,CAmB/G"}
|
|
@@ -0,0 +1,43 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { returnValues } from "#rules/stories/returnValues.ts";
|
|
3
|
+
import { effectName } from "./failureOperations.js";
|
|
4
|
+
function success(checker, node, seen) {
|
|
5
|
+
if (ts.isParenthesizedExpression(node)) {
|
|
6
|
+
return success(checker, node.expression, seen);
|
|
7
|
+
}
|
|
8
|
+
if (ts.isConditionalExpression(node)) {
|
|
9
|
+
return success(checker, node.whenTrue, new Set(seen)) && success(checker, node.whenFalse, new Set(seen));
|
|
10
|
+
}
|
|
11
|
+
if (ts.isIdentifier(node)) {
|
|
12
|
+
const symbol = checker.getSymbolAtLocation(node);
|
|
13
|
+
if (symbol !== undefined && !seen.has(symbol)) {
|
|
14
|
+
seen.add(symbol);
|
|
15
|
+
const declaration = symbol.valueDeclaration;
|
|
16
|
+
if (declaration !== undefined && ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
17
|
+
return success(checker, declaration.initializer, seen);
|
|
18
|
+
}
|
|
19
|
+
}
|
|
20
|
+
}
|
|
21
|
+
return effectName(checker, ts.isCallExpression(node) ? node.expression : node) === (ts.isCallExpression(node) ? "succeed" : "void");
|
|
22
|
+
}
|
|
23
|
+
export function successRecovery(checker, handler, seen = new Set()) {
|
|
24
|
+
if (ts.isArrowFunction(handler) || ts.isFunctionExpression(handler) || ts.isFunctionDeclaration(handler)) {
|
|
25
|
+
const values = returnValues(handler);
|
|
26
|
+
return values.length > 0 && values.every((value) => value !== undefined && success(checker, value, new Set()));
|
|
27
|
+
}
|
|
28
|
+
if (effectName(checker, handler) === "succeed") {
|
|
29
|
+
return true;
|
|
30
|
+
}
|
|
31
|
+
const symbol = checker.getSymbolAtLocation(handler);
|
|
32
|
+
if (symbol === undefined || seen.has(symbol)) {
|
|
33
|
+
return false;
|
|
34
|
+
}
|
|
35
|
+
seen.add(symbol);
|
|
36
|
+
return (symbol.declarations ?? []).some((declaration) => {
|
|
37
|
+
if (ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
38
|
+
return successRecovery(checker, declaration.initializer, seen);
|
|
39
|
+
}
|
|
40
|
+
return ts.isFunctionDeclaration(declaration) && successRecovery(checker, declaration, seen);
|
|
41
|
+
});
|
|
42
|
+
}
|
|
43
|
+
//# sourceMappingURL=successRecovery.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"successRecovery.js","sourceRoot":"","sources":["../../../src/rules/effect/successRecovery.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,YAAY,EAAE,MAAM,gCAAgC,CAAC;AAC9D,OAAO,EAAE,UAAU,EAAE,MAAM,wBAAwB,CAAC;AAEpD,SAAS,OAAO,CAAC,OAAuB,EAAE,IAAa,EAAE,IAAoB;IAC5E,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;QACxC,OAAO,OAAO,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,CAAC;IAChD,CAAC;IACD,IAAI,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,EAAE,CAAC;QACtC,OAAO,OAAO,CAAC,OAAO,EAAE,IAAI,CAAC,QAAQ,EAAE,IAAI,GAAG,CAAC,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC,OAAO,EAAE,IAAI,CAAC,SAAS,EAAE,IAAI,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;IAC1G,CAAC;IACD,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QACjD,IAAI,MAAM,KAAK,SAAS,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;YAC/C,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;YACjB,MAAM,WAAW,GAAG,MAAM,CAAC,gBAAgB,CAAC;YAC5C,IAAI,WAAW,KAAK,SAAS,IAAI,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,WAAW,CAAC,WAAW,KAAK,SAAS,EAAE,CAAC;gBACjH,OAAO,OAAO,CAAC,OAAO,EAAE,WAAW,CAAC,WAAW,EAAE,IAAI,CAAC,CAAC;YACxD,CAAC;QACF,CAAC;IACF,CAAC;IACD,OAAO,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;AACrI,CAAC;AAED,MAAM,UAAU,eAAe,CAAC,OAAuB,EAAE,OAAgB,EAAE,IAAI,GAAG,IAAI,GAAG,EAAa;IACrG,IAAI,EAAE,CAAC,eAAe,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,OAAO,CAAC,EAAE,CAAC;QAC1G,MAAM,MAAM,GAAG,YAAY,CAAC,OAAO,CAAC,CAAC;QACrC,OAAO,MAAM,CAAC,MAAM,GAAG,CAAC,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,IAAI,OAAO,CAAC,OAAO,EAAE,KAAK,EAAE,IAAI,GAAG,EAAE,CAAC,CAAC,CAAC;IAChH,CAAC;IACD,IAAI,UAAU,CAAC,OAAO,EAAE,OAAO,CAAC,KAAK,SAAS,EAAE,CAAC;QAChD,OAAO,IAAI,CAAC;IACb,CAAC;IACD,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC;IACpD,IAAI,MAAM,KAAK,SAAS,IAAI,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;QAC9C,OAAO,KAAK,CAAC;IACd,CAAC;IACD,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;IACjB,OAAO,CAAC,MAAM,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,WAAW,EAAE,EAAE;QACvD,IAAI,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,WAAW,CAAC,WAAW,KAAK,SAAS,EAAE,CAAC;YACpF,OAAO,eAAe,CAAC,OAAO,EAAE,WAAW,CAAC,WAAW,EAAE,IAAI,CAAC,CAAC;QAChE,CAAC;QACD,OAAO,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,eAAe,CAAC,OAAO,EAAE,WAAW,EAAE,IAAI,CAAC,CAAC;IAC7F,CAAC,CAAC,CAAC;AACJ,CAAC"}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@shivaedev/quality",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.51.0",
|
|
4
4
|
"description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
|
|
5
5
|
"homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
|
|
6
6
|
"bugs": {
|
|
@@ -62,7 +62,7 @@
|
|
|
62
62
|
"@effect/platform-node": "4.0.6",
|
|
63
63
|
"@effect/platform-node-shared": "4.0.6",
|
|
64
64
|
"@effect/vitest": "4.0.6",
|
|
65
|
-
"@shivaedev/test-story": "0.
|
|
65
|
+
"@shivaedev/test-story": "0.31.0",
|
|
66
66
|
"@types/node": "24.19.2",
|
|
67
67
|
"@typescript/native": "npm:typescript@7.0.2",
|
|
68
68
|
"effect": "4.0.6",
|
package/src/config/resolve.ts
CHANGED
|
@@ -39,18 +39,16 @@ function activeRule(rule: Rule, check: ActiveRule["check"]): ActiveRule {
|
|
|
39
39
|
|
|
40
40
|
function activate(rule: Rule, setting: Setting | undefined): Effect.Effect<Decoded<ActiveRule>> {
|
|
41
41
|
return Effect.tryPromise({ catch: messageOf, try: () => rule.configure(optionsOf(setting)) }).pipe(
|
|
42
|
-
Effect.
|
|
43
|
-
(
|
|
42
|
+
Effect.match({
|
|
43
|
+
onFailure: (failure): Decoded<ActiveRule> => ({ _tag: "Invalid", issues: [`rules.${rule.id}.options: validation threw: ${failure}`] }),
|
|
44
|
+
onSuccess: (configured): Decoded<ActiveRule> =>
|
|
44
45
|
configured._tag === "Invalid"
|
|
45
46
|
? { _tag: "Invalid", issues: configured.issues.map((issue) => `rules.${rule.id}.options: ${issue}`) }
|
|
46
47
|
: {
|
|
47
48
|
_tag: "Valid",
|
|
48
49
|
value: activeRule(rule, configured.check),
|
|
49
50
|
},
|
|
50
|
-
),
|
|
51
|
-
Effect.catch((failure: string) =>
|
|
52
|
-
Effect.succeed<Decoded<ActiveRule>>({ _tag: "Invalid", issues: [`rules.${rule.id}.options: validation threw: ${failure}`] }),
|
|
53
|
-
),
|
|
51
|
+
}),
|
|
54
52
|
);
|
|
55
53
|
}
|
|
56
54
|
|
package/src/rules/builtIn.ts
CHANGED
|
@@ -8,6 +8,7 @@ import { noTodo } from "#rules/comments/noTodo.ts";
|
|
|
8
8
|
import { docsReferences } from "#rules/docs/references.ts";
|
|
9
9
|
import { docsUnversionedInstalls } from "#rules/docs/unversionedInstalls.ts";
|
|
10
10
|
import { effectBoundary } from "#rules/effect/boundary.ts";
|
|
11
|
+
import { failureHonesty } from "#rules/effect/failureHonesty.ts";
|
|
11
12
|
import { serviceParameters } from "#rules/effect/serviceParameters.ts";
|
|
12
13
|
import { distinctCase } from "#rules/files/distinctCase.ts";
|
|
13
14
|
import { folderNames } from "#rules/files/folderNames.ts";
|
|
@@ -55,6 +56,7 @@ import { unusedCode } from "./unusedCode.ts";
|
|
|
55
56
|
export const builtInRules = [
|
|
56
57
|
unusedCode,
|
|
57
58
|
effectBoundary,
|
|
59
|
+
failureHonesty,
|
|
58
60
|
serviceParameters,
|
|
59
61
|
jsxConditionals,
|
|
60
62
|
maxLines,
|
|
@@ -0,0 +1,55 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { effectName, type FailureOperation, failureOperations, fileSystemCall } from "./failureOperations.ts";
|
|
3
|
+
import { successRecovery } from "./successRecovery.ts";
|
|
4
|
+
|
|
5
|
+
interface FailureFinding {
|
|
6
|
+
readonly message: string;
|
|
7
|
+
readonly node: ts.Node;
|
|
8
|
+
}
|
|
9
|
+
|
|
10
|
+
function unboundedRetry(node: ts.CallExpression): boolean {
|
|
11
|
+
const options = node.arguments.at(-1);
|
|
12
|
+
if (options === undefined || !ts.isObjectLiteralExpression(options)) {
|
|
13
|
+
return false;
|
|
14
|
+
}
|
|
15
|
+
const names = options.properties.flatMap((property) => (property.name === undefined ? [] : [property.name.getText().replaceAll(/["']/gu, "")]));
|
|
16
|
+
return names.includes("while") && !names.includes("times") && !names.includes("schedule") && !options.properties.some(ts.isSpreadAssignment);
|
|
17
|
+
}
|
|
18
|
+
|
|
19
|
+
function operationFailure(checker: ts.TypeChecker, operation: FailureOperation, before: readonly FailureOperation[]): string | undefined {
|
|
20
|
+
if (["option", "orElseSucceed"].includes(operation.name) && before.some((part) => fileSystemCall(checker, part.node))) {
|
|
21
|
+
return "FileSystem failure becomes absence or success. Catch a named reason such as NotFound, re-fail other errors, or return an explicit unavailable state.";
|
|
22
|
+
}
|
|
23
|
+
if (/^fork(?:Scoped|In|Detach|Daemon|Child)?$/u.test(operation.name)) {
|
|
24
|
+
const names = before.map((part) => part.name);
|
|
25
|
+
const forever = names.indexOf("forever");
|
|
26
|
+
if (forever !== -1 && names.indexOf("orDie", forever + 1) !== -1) {
|
|
27
|
+
return "Forked forever loop dies on failure. Catch a named reason within each iteration with a Schedule-bounded retry, or expose an explicit unavailable state and supervise termination.";
|
|
28
|
+
}
|
|
29
|
+
}
|
|
30
|
+
return undefined;
|
|
31
|
+
}
|
|
32
|
+
|
|
33
|
+
export function failureFindings(checker: ts.TypeChecker, node: ts.CallExpression): readonly FailureFinding[] {
|
|
34
|
+
const findings: FailureFinding[] = [];
|
|
35
|
+
const name = effectName(checker, node.expression);
|
|
36
|
+
if (name === "retry" && unboundedRetry(node)) {
|
|
37
|
+
findings.push({ message: "Retry has while without times or schedule. Use a Schedule-bounded retry and preserve the final typed failure.", node });
|
|
38
|
+
}
|
|
39
|
+
const handler = node.arguments.at(-1);
|
|
40
|
+
if (["catch", "catchAll", "catchCause", "catchAllCause"].includes(name ?? "") && handler !== undefined && successRecovery(checker, handler)) {
|
|
41
|
+
findings.push({
|
|
42
|
+
message:
|
|
43
|
+
"Catch turns every failure into success. Catch a named reason with catchTag or catchIf and re-fail the rest, or model an explicit unavailable state.",
|
|
44
|
+
node,
|
|
45
|
+
});
|
|
46
|
+
}
|
|
47
|
+
const operations = failureOperations(checker, node);
|
|
48
|
+
for (const [index, operation] of operations.entries()) {
|
|
49
|
+
const message = operationFailure(checker, operation, operations.slice(0, index));
|
|
50
|
+
if (message !== undefined) {
|
|
51
|
+
findings.push({ message, node: operation.node });
|
|
52
|
+
}
|
|
53
|
+
}
|
|
54
|
+
return findings;
|
|
55
|
+
}
|
|
@@ -0,0 +1,59 @@
|
|
|
1
|
+
import { join } from "node:path";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import { defineRule, type Finding, type RuleInputs } from "#rule.ts";
|
|
4
|
+
import { failureFindings } from "./failureFindings.ts";
|
|
5
|
+
import { effectProgram } from "./program.ts";
|
|
6
|
+
|
|
7
|
+
function checkFailures(inputs: RuleInputs): readonly Finding[] {
|
|
8
|
+
const program = effectProgram(inputs, false);
|
|
9
|
+
const checker = program.getTypeChecker();
|
|
10
|
+
return inputs.sources.flatMap((file) => {
|
|
11
|
+
const source = program.getSourceFile(join(inputs.root, file.path));
|
|
12
|
+
const findings: Finding[] = [];
|
|
13
|
+
const reported = new Set<string>();
|
|
14
|
+
function report(node: ts.Node, message: string): void {
|
|
15
|
+
const key = `${node.pos}:${message}`;
|
|
16
|
+
if (source !== undefined && !reported.has(key)) {
|
|
17
|
+
reported.add(key);
|
|
18
|
+
findings.push({ file: file.path, line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1, message });
|
|
19
|
+
}
|
|
20
|
+
}
|
|
21
|
+
function visit(node: ts.Node): void {
|
|
22
|
+
if (ts.isCallExpression(node)) {
|
|
23
|
+
for (const finding of failureFindings(checker, node)) {
|
|
24
|
+
report(finding.node, finding.message);
|
|
25
|
+
}
|
|
26
|
+
}
|
|
27
|
+
ts.forEachChild(node, visit);
|
|
28
|
+
}
|
|
29
|
+
if (source !== undefined) {
|
|
30
|
+
visit(source);
|
|
31
|
+
}
|
|
32
|
+
return findings;
|
|
33
|
+
});
|
|
34
|
+
}
|
|
35
|
+
|
|
36
|
+
export const failureHonesty = defineRule({
|
|
37
|
+
check: (inputs) => {
|
|
38
|
+
const groups = new Map<string, RuleInputs["sources"][number][]>();
|
|
39
|
+
for (const source of inputs.sources) {
|
|
40
|
+
if (
|
|
41
|
+
!(
|
|
42
|
+
/\.[cm]?[jt]sx?$/u.test(source.path)
|
|
43
|
+
&& /\b(?:catch|catchAll|catchCause|catchAllCause|retry|forever|option|orElseSucceed)\b/u.test(source.text)
|
|
44
|
+
)
|
|
45
|
+
) {
|
|
46
|
+
continue;
|
|
47
|
+
}
|
|
48
|
+
const group = /^(?:packages|examples)\/[^/]+/u.exec(source.path)?.[0] ?? ".";
|
|
49
|
+
const sources = groups.get(group) ?? [];
|
|
50
|
+
sources.push(source);
|
|
51
|
+
groups.set(group, sources);
|
|
52
|
+
}
|
|
53
|
+
return [...groups.values()].flatMap((sources) => checkFailures({ ...inputs, sources }));
|
|
54
|
+
},
|
|
55
|
+
description:
|
|
56
|
+
"Keep failures typed and observable: no forked forever/orDie loops, retry({ while }) without a bound, blanket catch-to-success, or FileSystem option/orElseSucceed. Catch a named reason, use a Schedule-bounded retry or model an explicit unavailable state. No config exceptions or inline suppressions; baseline existing debt.",
|
|
57
|
+
id: "effect/failure-honesty",
|
|
58
|
+
registrable: false,
|
|
59
|
+
});
|
|
@@ -0,0 +1,66 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { boundaryReference } from "./boundaryReference.ts";
|
|
3
|
+
|
|
4
|
+
export interface FailureOperation {
|
|
5
|
+
readonly name: string;
|
|
6
|
+
readonly node: ts.Node;
|
|
7
|
+
}
|
|
8
|
+
|
|
9
|
+
export function effectName(checker: ts.TypeChecker, node: ts.Node): string | undefined {
|
|
10
|
+
return /^effect(?:\.Effect|\/Effect)\.(?<name>\w+)$/u.exec(boundaryReference(checker, node) ?? "")?.groups?.name;
|
|
11
|
+
}
|
|
12
|
+
|
|
13
|
+
export function failureOperations(checker: ts.TypeChecker, node: ts.Node, seen = new Set<ts.Symbol>()): FailureOperation[] {
|
|
14
|
+
if (ts.isParenthesizedExpression(node)) {
|
|
15
|
+
return failureOperations(checker, node.expression, seen);
|
|
16
|
+
}
|
|
17
|
+
if (ts.isIdentifier(node)) {
|
|
18
|
+
const symbol = checker.getSymbolAtLocation(node);
|
|
19
|
+
if (symbol !== undefined && !seen.has(symbol)) {
|
|
20
|
+
seen.add(symbol);
|
|
21
|
+
const declaration = symbol.valueDeclaration;
|
|
22
|
+
if (declaration !== undefined && ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
23
|
+
return failureOperations(checker, declaration.initializer, seen);
|
|
24
|
+
}
|
|
25
|
+
}
|
|
26
|
+
}
|
|
27
|
+
if (ts.isCallExpression(node) && ts.isPropertyAccessExpression(node.expression) && node.expression.name.text === "pipe") {
|
|
28
|
+
return [
|
|
29
|
+
failureOperations(checker, node.expression.expression, seen),
|
|
30
|
+
...node.arguments.map((part) => failureOperations(checker, part, new Set(seen))),
|
|
31
|
+
].flat();
|
|
32
|
+
}
|
|
33
|
+
const name = effectName(checker, ts.isCallExpression(node) ? node.expression : node);
|
|
34
|
+
if (name === undefined) {
|
|
35
|
+
return [{ name: "source", node }];
|
|
36
|
+
}
|
|
37
|
+
const args = ts.isCallExpression(node) ? node.arguments : [];
|
|
38
|
+
const first = args[0];
|
|
39
|
+
return [...(first === undefined ? [] : failureOperations(checker, first, seen)), { name, node }];
|
|
40
|
+
}
|
|
41
|
+
|
|
42
|
+
function fileSystemService(checker: ts.TypeChecker, node: ts.Node, seen = new Set<ts.Symbol>()): boolean {
|
|
43
|
+
if (/^effect(?:\.FileSystem|\/FileSystem)\.FileSystem$/u.test(boundaryReference(checker, node) ?? "")) {
|
|
44
|
+
return true;
|
|
45
|
+
}
|
|
46
|
+
if (ts.isYieldExpression(node) || ts.isParenthesizedExpression(node)) {
|
|
47
|
+
return node.expression !== undefined && fileSystemService(checker, node.expression, seen);
|
|
48
|
+
}
|
|
49
|
+
const symbol = checker.getSymbolAtLocation(node);
|
|
50
|
+
if (symbol === undefined || seen.has(symbol)) {
|
|
51
|
+
return false;
|
|
52
|
+
}
|
|
53
|
+
seen.add(symbol);
|
|
54
|
+
return (symbol.declarations ?? []).some(
|
|
55
|
+
(declaration) =>
|
|
56
|
+
ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined && fileSystemService(checker, declaration.initializer, seen),
|
|
57
|
+
);
|
|
58
|
+
}
|
|
59
|
+
|
|
60
|
+
export function fileSystemCall(checker: ts.TypeChecker, node: ts.Node): boolean {
|
|
61
|
+
if (!ts.isCallExpression(node)) {
|
|
62
|
+
return false;
|
|
63
|
+
}
|
|
64
|
+
const callee = node.expression;
|
|
65
|
+
return (ts.isPropertyAccessExpression(callee) || ts.isElementAccessExpression(callee)) && fileSystemService(checker, callee.expression);
|
|
66
|
+
}
|
|
@@ -0,0 +1,44 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { returnValues } from "#rules/stories/returnValues.ts";
|
|
3
|
+
import { effectName } from "./failureOperations.ts";
|
|
4
|
+
|
|
5
|
+
function success(checker: ts.TypeChecker, node: ts.Node, seen: Set<ts.Symbol>): boolean {
|
|
6
|
+
if (ts.isParenthesizedExpression(node)) {
|
|
7
|
+
return success(checker, node.expression, seen);
|
|
8
|
+
}
|
|
9
|
+
if (ts.isConditionalExpression(node)) {
|
|
10
|
+
return success(checker, node.whenTrue, new Set(seen)) && success(checker, node.whenFalse, new Set(seen));
|
|
11
|
+
}
|
|
12
|
+
if (ts.isIdentifier(node)) {
|
|
13
|
+
const symbol = checker.getSymbolAtLocation(node);
|
|
14
|
+
if (symbol !== undefined && !seen.has(symbol)) {
|
|
15
|
+
seen.add(symbol);
|
|
16
|
+
const declaration = symbol.valueDeclaration;
|
|
17
|
+
if (declaration !== undefined && ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
18
|
+
return success(checker, declaration.initializer, seen);
|
|
19
|
+
}
|
|
20
|
+
}
|
|
21
|
+
}
|
|
22
|
+
return effectName(checker, ts.isCallExpression(node) ? node.expression : node) === (ts.isCallExpression(node) ? "succeed" : "void");
|
|
23
|
+
}
|
|
24
|
+
|
|
25
|
+
export function successRecovery(checker: ts.TypeChecker, handler: ts.Node, seen = new Set<ts.Symbol>()): boolean {
|
|
26
|
+
if (ts.isArrowFunction(handler) || ts.isFunctionExpression(handler) || ts.isFunctionDeclaration(handler)) {
|
|
27
|
+
const values = returnValues(handler);
|
|
28
|
+
return values.length > 0 && values.every((value) => value !== undefined && success(checker, value, new Set()));
|
|
29
|
+
}
|
|
30
|
+
if (effectName(checker, handler) === "succeed") {
|
|
31
|
+
return true;
|
|
32
|
+
}
|
|
33
|
+
const symbol = checker.getSymbolAtLocation(handler);
|
|
34
|
+
if (symbol === undefined || seen.has(symbol)) {
|
|
35
|
+
return false;
|
|
36
|
+
}
|
|
37
|
+
seen.add(symbol);
|
|
38
|
+
return (symbol.declarations ?? []).some((declaration) => {
|
|
39
|
+
if (ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
40
|
+
return successRecovery(checker, declaration.initializer, seen);
|
|
41
|
+
}
|
|
42
|
+
return ts.isFunctionDeclaration(declaration) && successRecovery(checker, declaration, seen);
|
|
43
|
+
});
|
|
44
|
+
}
|