@shivaedev/quality 0.42.0 → 0.43.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +33 -0
- package/README.md +45 -1
- package/biome/declarations.json +5 -0
- package/biome/plugins/ambient-runtime.grit +3 -1
- package/biome/preset.json +2 -2
- package/dist/rules/builtIn.d.ts +1 -1
- package/dist/rules/builtIn.d.ts.map +1 -1
- package/dist/rules/builtIn.js +6 -0
- package/dist/rules/builtIn.js.map +1 -1
- package/dist/rules/effect/boundary.d.ts +2 -0
- package/dist/rules/effect/boundary.d.ts.map +1 -0
- package/dist/rules/effect/boundary.js +66 -0
- package/dist/rules/effect/boundary.js.map +1 -0
- package/dist/rules/effect/layerConstructor.d.ts +3 -0
- package/dist/rules/effect/layerConstructor.d.ts.map +1 -0
- package/dist/rules/effect/layerConstructor.js +35 -0
- package/dist/rules/effect/layerConstructor.js.map +1 -0
- package/dist/rules/effect/ownsParameters.d.ts +3 -0
- package/dist/rules/effect/ownsParameters.d.ts.map +1 -0
- package/dist/rules/effect/ownsParameters.js +45 -0
- package/dist/rules/effect/ownsParameters.js.map +1 -0
- package/dist/rules/effect/program.d.ts +4 -0
- package/dist/rules/effect/program.d.ts.map +1 -0
- package/dist/rules/effect/program.js +24 -0
- package/dist/rules/effect/program.js.map +1 -0
- package/dist/rules/effect/publicFunctions.d.ts +3 -0
- package/dist/rules/effect/publicFunctions.d.ts.map +1 -0
- package/dist/rules/effect/publicFunctions.js +68 -0
- package/dist/rules/effect/publicFunctions.js.map +1 -0
- package/dist/rules/effect/serviceCatalog.d.ts +8 -0
- package/dist/rules/effect/serviceCatalog.d.ts.map +1 -0
- package/dist/rules/effect/serviceCatalog.js +56 -0
- package/dist/rules/effect/serviceCatalog.js.map +1 -0
- package/dist/rules/effect/serviceFindings.d.ts +5 -0
- package/dist/rules/effect/serviceFindings.d.ts.map +1 -0
- package/dist/rules/effect/serviceFindings.js +88 -0
- package/dist/rules/effect/serviceFindings.js.map +1 -0
- package/dist/rules/effect/serviceOrigin.d.ts +3 -0
- package/dist/rules/effect/serviceOrigin.d.ts.map +1 -0
- package/dist/rules/effect/serviceOrigin.js +85 -0
- package/dist/rules/effect/serviceOrigin.js.map +1 -0
- package/dist/rules/effect/serviceParameters.d.ts +2 -0
- package/dist/rules/effect/serviceParameters.d.ts.map +1 -0
- package/dist/rules/effect/serviceParameters.js +33 -0
- package/dist/rules/effect/serviceParameters.js.map +1 -0
- package/dist/rules/effect/serviceTypes.d.ts +8 -0
- package/dist/rules/effect/serviceTypes.d.ts.map +1 -0
- package/dist/rules/effect/serviceTypes.js +94 -0
- package/dist/rules/effect/serviceTypes.js.map +1 -0
- package/dist/rules/react/jsxConditionals.d.ts +2 -0
- package/dist/rules/react/jsxConditionals.d.ts.map +1 -0
- package/dist/rules/react/jsxConditionals.js +54 -0
- package/dist/rules/react/jsxConditionals.js.map +1 -0
- package/dist/rules/stories/engineOf.d.ts.map +1 -1
- package/dist/rules/stories/engineOf.js +2 -1
- package/dist/rules/stories/engineOf.js.map +1 -1
- package/dist/rules/stories/namedValues.js +4 -4
- package/dist/rules/stories/namedValues.js.map +1 -1
- package/package.json +3 -3
- package/src/rules/builtIn.ts +6 -0
- package/src/rules/effect/boundary.ts +75 -0
- package/src/rules/effect/layerConstructor.ts +40 -0
- package/src/rules/effect/ownsParameters.ts +46 -0
- package/src/rules/effect/program.ts +26 -0
- package/src/rules/effect/publicFunctions.ts +70 -0
- package/src/rules/effect/serviceCatalog.ts +57 -0
- package/src/rules/effect/serviceFindings.ts +96 -0
- package/src/rules/effect/serviceOrigin.ts +94 -0
- package/src/rules/effect/serviceParameters.ts +35 -0
- package/src/rules/effect/serviceTypes.ts +101 -0
- package/src/rules/react/jsxConditionals.ts +59 -0
- package/src/rules/stories/engineOf.ts +2 -1
- package/src/rules/stories/namedValues.ts +4 -4
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceCatalog.js","sourceRoot":"","sources":["../../../src/rules/effect/serviceCatalog.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,gCAAgC,CAAC;AAC/D,OAAO,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAE7D,MAAM,UAAU,cAAc,CAAC,OAAmB,EAAE,OAAuB;IAC1E,MAAM,QAAQ,GAAG,YAAY,CAAC,OAAO,CAAC,CAAC;IACvC,SAAS,QAAQ,CAAC,IAA6C;QAC9D,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtD,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO;QACR,CAAC;QACD,MAAM,MAAM,GAAG,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;QAC/F,MAAM,UAAU,GAAG,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,kBAAkB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;QACxG,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;YACpC,MAAM,QAAQ,GAAG,SAAS,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;YAC1G,IAAI,aAAa,CAAC,OAAO,EAAE,QAAQ,CAAC,EAAE,CAAC;gBACtC,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC,CAAC;YACtD,CAAC;QACF,CAAC;IACF,CAAC;IACD,SAAS,UAAU,CAAC,IAA0B;QAC7C,IAAI,CAAC,aAAa,CAAC,OAAO,EAAE,IAAI,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC5C,OAAO;QACR,CAAC;QACD,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC1D,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO;QACR,CAAC;QACD,MAAM,MAAM,GAAG,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;QAC/F,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,CAAC;IACpD,CAAC;IAED,SAAS,QAAQ,CAAC,IAAa;QAC9B,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,aAAa,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;YAC1E,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC,CAAC;QACpD,CAAC;QACD,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;YAC9D,QAAQ,CAAC,IAAI,CAAC,CAAC;QAChB,CAAC;QACD,IAAI,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,KAAK,SAAS,IAAI,aAAa,CAAC,OAAO,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YACjG,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QACzD,CAAC;QACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,aAAa,CAAC,OAAO,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YACzE,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QACzD,CAAC;QACD,IAAI,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,UAAU,CAAC,IAAI,CAAC,CAAC;QAClB,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACjC,CAAC;IACD,KAAK,MAAM,MAAM,IAAI,OAAO,CAAC,cAAc,EAAE,EAAE,CAAC;QAC/C,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,gBAAgB,CAAC,IAAI,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,cAAc,CAAC,EAAE,CAAC;YAC7F,QAAQ,CAAC,MAAM,CAAC,CAAC;QAClB,CAAC;IACF,CAAC;IACD,OAAO,QAAQ,CAAC;AACjB,CAAC"}
|
|
@@ -0,0 +1,5 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import type { Finding } from "#rule.ts";
|
|
3
|
+
import type { serviceTypes } from "#rules/effect/serviceTypes.ts";
|
|
4
|
+
export declare function serviceFindings(root: string, sources: readonly ts.SourceFile[], checker: ts.TypeChecker, services: ReturnType<typeof serviceTypes>): readonly Finding[];
|
|
5
|
+
//# sourceMappingURL=serviceFindings.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceFindings.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/serviceFindings.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,UAAU,CAAC;AAGxC,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AASlE,wBAAgB,eAAe,CAC9B,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,SAAS,EAAE,CAAC,UAAU,EAAE,EACjC,OAAO,EAAE,EAAE,CAAC,WAAW,EACvB,QAAQ,EAAE,UAAU,CAAC,OAAO,YAAY,CAAC,GACvC,SAAS,OAAO,EAAE,CA4EpB"}
|
|
@@ -0,0 +1,88 @@
|
|
|
1
|
+
import { relative } from "node:path";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import { layerConstructor } from "#rules/effect/layerConstructor.ts";
|
|
4
|
+
import { publicFunctions } from "#rules/effect/publicFunctions.ts";
|
|
5
|
+
function publicDeclaration(declaration, local) {
|
|
6
|
+
if (!local.has(declaration.getSourceFile()) || ts.getCombinedModifierFlags(declaration) & (ts.ModifierFlags.Private | ts.ModifierFlags.Protected)) {
|
|
7
|
+
return false;
|
|
8
|
+
}
|
|
9
|
+
return !((ts.isMethodDeclaration(declaration) || ts.isPropertyDeclaration(declaration)) && ts.isPrivateIdentifier(declaration.name));
|
|
10
|
+
}
|
|
11
|
+
export function serviceFindings(root, sources, checker, services) {
|
|
12
|
+
const findings = new Map();
|
|
13
|
+
const visited = new Set();
|
|
14
|
+
const activeSignatures = new Set();
|
|
15
|
+
const local = new Set(sources);
|
|
16
|
+
function parameterFinding(symbol) {
|
|
17
|
+
if (!services.carries(checker.getTypeOfSymbol(symbol))) {
|
|
18
|
+
return;
|
|
19
|
+
}
|
|
20
|
+
for (const parameter of symbol.declarations ?? []) {
|
|
21
|
+
if (!(ts.isParameter(parameter) && local.has(parameter.getSourceFile()))) {
|
|
22
|
+
continue;
|
|
23
|
+
}
|
|
24
|
+
const source = parameter.getSourceFile();
|
|
25
|
+
const file = relative(root, source.fileName).replaceAll("\\", "/");
|
|
26
|
+
findings.set(parameter, {
|
|
27
|
+
file,
|
|
28
|
+
line: source.getLineAndCharacterOfPosition(parameter.getStart(source)).line + 1,
|
|
29
|
+
message: `Parameter ${parameter.name.getText(source)} carries a service. Read services from Effect's environment instead of passing them; return an Effect or Stream with requirements. Service implementation methods and Layer constructors are accepted; only test-support/ folders are exempt, not adapters/.`,
|
|
30
|
+
});
|
|
31
|
+
}
|
|
32
|
+
}
|
|
33
|
+
function signatureFinding(signature) {
|
|
34
|
+
const declaration = signature.declaration;
|
|
35
|
+
if (declaration === undefined || !local.has(declaration.getSourceFile()) || layerConstructor(checker, declaration)) {
|
|
36
|
+
return;
|
|
37
|
+
}
|
|
38
|
+
const result = signature.getReturnType();
|
|
39
|
+
if (result.getProperty("~effect/Layer") !== undefined) {
|
|
40
|
+
return;
|
|
41
|
+
}
|
|
42
|
+
for (const parameter of signature.parameters) {
|
|
43
|
+
parameterFinding(parameter);
|
|
44
|
+
}
|
|
45
|
+
if (activeSignatures.has(declaration)) {
|
|
46
|
+
return;
|
|
47
|
+
}
|
|
48
|
+
activeSignatures.add(declaration);
|
|
49
|
+
surface(result);
|
|
50
|
+
activeSignatures.delete(declaration);
|
|
51
|
+
}
|
|
52
|
+
function members(type) {
|
|
53
|
+
if (type.isUnionOrIntersection()) {
|
|
54
|
+
for (const part of type.types) {
|
|
55
|
+
surface(part);
|
|
56
|
+
}
|
|
57
|
+
}
|
|
58
|
+
for (const index of checker.getIndexInfosOfType(type)) {
|
|
59
|
+
surface(index.type);
|
|
60
|
+
}
|
|
61
|
+
for (const signature of type.getConstructSignatures()) {
|
|
62
|
+
surface(signature.getReturnType());
|
|
63
|
+
}
|
|
64
|
+
for (const property of type
|
|
65
|
+
.getProperties()
|
|
66
|
+
.filter((candidate) => (candidate.declarations ?? []).some((declaration) => publicDeclaration(declaration, local)))) {
|
|
67
|
+
surface(checker.getTypeOfSymbol(property));
|
|
68
|
+
}
|
|
69
|
+
}
|
|
70
|
+
function surface(type) {
|
|
71
|
+
if (visited.has(type) || !(type.flags & (ts.TypeFlags.Object | ts.TypeFlags.Intersection | ts.TypeFlags.Union))) {
|
|
72
|
+
return;
|
|
73
|
+
}
|
|
74
|
+
visited.add(type);
|
|
75
|
+
const signatures = type.getCallSignatures();
|
|
76
|
+
const constructsLayer = signatures.some((signature) => signature.declaration !== undefined && layerConstructor(checker, signature.declaration));
|
|
77
|
+
if (services.computation(type) || (!constructsLayer && services.implementation(type))) {
|
|
78
|
+
return;
|
|
79
|
+
}
|
|
80
|
+
members(type);
|
|
81
|
+
for (const signature of signatures) {
|
|
82
|
+
signatureFinding(signature);
|
|
83
|
+
}
|
|
84
|
+
}
|
|
85
|
+
publicFunctions(sources, checker, surface);
|
|
86
|
+
return [...findings.values()];
|
|
87
|
+
}
|
|
88
|
+
//# sourceMappingURL=serviceFindings.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceFindings.js","sourceRoot":"","sources":["../../../src/rules/effect/serviceFindings.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,WAAW,CAAC;AACrC,OAAO,EAAE,MAAM,YAAY,CAAC;AAE5B,OAAO,EAAE,gBAAgB,EAAE,MAAM,mCAAmC,CAAC;AACrE,OAAO,EAAE,eAAe,EAAE,MAAM,kCAAkC,CAAC;AAGnE,SAAS,iBAAiB,CAAC,WAA2B,EAAE,KAAiC;IACxF,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,CAAC,aAAa,EAAE,CAAC,IAAI,EAAE,CAAC,wBAAwB,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC,aAAa,CAAC,OAAO,GAAG,EAAE,CAAC,aAAa,CAAC,SAAS,CAAC,EAAE,CAAC;QACnJ,OAAO,KAAK,CAAC;IACd,CAAC;IACD,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,mBAAmB,CAAC,WAAW,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,CAAC,IAAI,EAAE,CAAC,mBAAmB,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC;AACtI,CAAC;AAED,MAAM,UAAU,eAAe,CAC9B,IAAY,EACZ,OAAiC,EACjC,OAAuB,EACvB,QAAyC;IAEzC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAoC,CAAC;IAC7D,MAAM,OAAO,GAAG,IAAI,GAAG,EAAW,CAAC;IACnC,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAA4C,CAAC;IAC7E,MAAM,KAAK,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,CAAC;IAC/B,SAAS,gBAAgB,CAAC,MAAiB;QAC1C,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,OAAO,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC;YACxD,OAAO;QACR,CAAC;QACD,KAAK,MAAM,SAAS,IAAI,MAAM,CAAC,YAAY,IAAI,EAAE,EAAE,CAAC;YACnD,IAAI,CAAC,CAAC,EAAE,CAAC,WAAW,CAAC,SAAS,CAAC,IAAI,KAAK,CAAC,GAAG,CAAC,SAAS,CAAC,aAAa,EAAE,CAAC,CAAC,EAAE,CAAC;gBAC1E,SAAS;YACV,CAAC;YACD,MAAM,MAAM,GAAG,SAAS,CAAC,aAAa,EAAE,CAAC;YACzC,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC,QAAQ,CAAC,CAAC,UAAU,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC;YACnE,QAAQ,CAAC,GAAG,CAAC,SAAS,EAAE;gBACvB,IAAI;gBACJ,IAAI,EAAE,MAAM,CAAC,6BAA6B,CAAC,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC;gBAC/E,OAAO,EAAE,aAAa,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,8PAA8P;aAClT,CAAC,CAAC;QACJ,CAAC;IACF,CAAC;IACD,SAAS,gBAAgB,CAAC,SAAuB;QAChD,MAAM,WAAW,GAAG,SAAS,CAAC,WAAW,CAAC;QAC1C,IAAI,WAAW,KAAK,SAAS,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,CAAC,aAAa,EAAE,CAAC,IAAI,gBAAgB,CAAC,OAAO,EAAE,WAAW,CAAC,EAAE,CAAC;YACpH,OAAO;QACR,CAAC;QACD,MAAM,MAAM,GAAG,SAAS,CAAC,aAAa,EAAE,CAAC;QACzC,IAAI,MAAM,CAAC,WAAW,CAAC,eAAe,CAAC,KAAK,SAAS,EAAE,CAAC;YACvD,OAAO;QACR,CAAC;QACD,KAAK,MAAM,SAAS,IAAI,SAAS,CAAC,UAAU,EAAE,CAAC;YAC9C,gBAAgB,CAAC,SAAS,CAAC,CAAC;QAC7B,CAAC;QACD,IAAI,gBAAgB,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YACvC,OAAO;QACR,CAAC;QACD,gBAAgB,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;QAClC,OAAO,CAAC,MAAM,CAAC,CAAC;QAChB,gBAAgB,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;IACtC,CAAC;IACD,SAAS,OAAO,CAAC,IAAa;QAC7B,IAAI,IAAI,CAAC,qBAAqB,EAAE,EAAE,CAAC;YAClC,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;gBAC/B,OAAO,CAAC,IAAI,CAAC,CAAC;YACf,CAAC;QACF,CAAC;QACD,KAAK,MAAM,KAAK,IAAI,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;YACvD,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QACrB,CAAC;QACD,KAAK,MAAM,SAAS,IAAI,IAAI,CAAC,sBAAsB,EAAE,EAAE,CAAC;YACvD,OAAO,CAAC,SAAS,CAAC,aAAa,EAAE,CAAC,CAAC;QACpC,CAAC;QACD,KAAK,MAAM,QAAQ,IAAI,IAAI;aACzB,aAAa,EAAE;aACf,MAAM,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,SAAS,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,WAAW,EAAE,EAAE,CAAC,iBAAiB,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;YACtH,OAAO,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC,CAAC;QAC5C,CAAC;IACF,CAAC;IACD,SAAS,OAAO,CAAC,IAAa;QAC7B,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,GAAG,CAAC,EAAE,CAAC,SAAS,CAAC,MAAM,GAAG,EAAE,CAAC,SAAS,CAAC,YAAY,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;YACjH,OAAO;QACR,CAAC;QACD,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAClB,MAAM,UAAU,GAAG,IAAI,CAAC,iBAAiB,EAAE,CAAC;QAC5C,MAAM,eAAe,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,WAAW,KAAK,SAAS,IAAI,gBAAgB,CAAC,OAAO,EAAE,SAAS,CAAC,WAAW,CAAC,CAAC,CAAC;QAChJ,IAAI,QAAQ,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,eAAe,IAAI,QAAQ,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC;YACvF,OAAO;QACR,CAAC;QACD,OAAO,CAAC,IAAI,CAAC,CAAC;QACd,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;YACpC,gBAAgB,CAAC,SAAS,CAAC,CAAC;QAC7B,CAAC;IACF,CAAC;IACD,eAAe,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;IAC3C,OAAO,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC;AAC/B,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceOrigin.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/serviceOrigin.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAsE5B,wBAAgB,aAAa,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE,IAAI,EAAE,EAAE,CAAC,IAAI,GAAG,EAAE,CAAC,MAAM,EAAE,IAAI,iBAAuB,GAAG,OAAO,CAuBtH"}
|
|
@@ -0,0 +1,85 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { returnValues } from "#rules/stories/returnValues.ts";
|
|
3
|
+
const SERVICE_NAMES = new Set(["Service", "ServiceClass", "Key", "Reference", "Tag", "TagClass", "GenericTag"]);
|
|
4
|
+
function annotation(declaration) {
|
|
5
|
+
if (ts.isVariableDeclaration(declaration)
|
|
6
|
+
|| ts.isParameter(declaration)
|
|
7
|
+
|| ts.isTypeAliasDeclaration(declaration)
|
|
8
|
+
|| ts.isFunctionLike(declaration)) {
|
|
9
|
+
return declaration.type;
|
|
10
|
+
}
|
|
11
|
+
return ts.isTypeParameterDeclaration(declaration) ? declaration.constraint : undefined;
|
|
12
|
+
}
|
|
13
|
+
function declarationOrigin(checker, declaration, seen) {
|
|
14
|
+
const type = annotation(declaration);
|
|
15
|
+
if (type !== undefined && serviceOrigin(checker, type, seen)) {
|
|
16
|
+
return true;
|
|
17
|
+
}
|
|
18
|
+
if (ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
19
|
+
return serviceOrigin(checker, declaration.initializer, seen);
|
|
20
|
+
}
|
|
21
|
+
if (ts.isClassDeclaration(declaration) || ts.isInterfaceDeclaration(declaration)) {
|
|
22
|
+
return declaration.heritageClauses?.some((clause) => clause.types.some((base) => serviceOrigin(checker, base.expression, seen))) ?? false;
|
|
23
|
+
}
|
|
24
|
+
return ts.isFunctionLike(declaration) && returnValues(declaration).some((value) => value !== undefined && serviceOrigin(checker, value, seen));
|
|
25
|
+
}
|
|
26
|
+
function symbolOrigin(checker, symbol, seen) {
|
|
27
|
+
const target = symbol.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(symbol) : symbol;
|
|
28
|
+
if (seen.has(target)) {
|
|
29
|
+
return false;
|
|
30
|
+
}
|
|
31
|
+
seen.add(target);
|
|
32
|
+
return (target.declarations ?? []).some((declaration) => {
|
|
33
|
+
const file = declaration.getSourceFile().fileName.replaceAll("\\", "/");
|
|
34
|
+
if (/\/effect\/(?:src|dist)\/(?:Context|Effect)(?:\.d)?\.ts$/u.test(file)
|
|
35
|
+
&& SERVICE_NAMES.has(target.name)
|
|
36
|
+
&& (ts.isVariableDeclaration(declaration)
|
|
37
|
+
|| ts.isFunctionDeclaration(declaration)
|
|
38
|
+
|| ts.isClassDeclaration(declaration)
|
|
39
|
+
|| ts.isInterfaceDeclaration(declaration)
|
|
40
|
+
|| ts.isTypeAliasDeclaration(declaration))) {
|
|
41
|
+
return true;
|
|
42
|
+
}
|
|
43
|
+
if (file.endsWith("/service/src/defineService.ts") && target.name === "defineService") {
|
|
44
|
+
return true;
|
|
45
|
+
}
|
|
46
|
+
return declarationOrigin(checker, declaration, seen);
|
|
47
|
+
});
|
|
48
|
+
}
|
|
49
|
+
function reference(node) {
|
|
50
|
+
if (ts.isCallExpression(node)) {
|
|
51
|
+
return node.expression;
|
|
52
|
+
}
|
|
53
|
+
if (ts.isTypeReferenceNode(node)) {
|
|
54
|
+
return node.typeName;
|
|
55
|
+
}
|
|
56
|
+
if (ts.isTypeQueryNode(node)) {
|
|
57
|
+
return node.exprName;
|
|
58
|
+
}
|
|
59
|
+
return ts.isParenthesizedTypeNode(node) ? node.type : undefined;
|
|
60
|
+
}
|
|
61
|
+
export function serviceOrigin(checker, node, seen = new Set()) {
|
|
62
|
+
if (!("kind" in node)) {
|
|
63
|
+
return symbolOrigin(checker, node, seen);
|
|
64
|
+
}
|
|
65
|
+
const referred = reference(node);
|
|
66
|
+
if (referred !== undefined) {
|
|
67
|
+
return serviceOrigin(checker, referred, seen);
|
|
68
|
+
}
|
|
69
|
+
if (ts.isUnionTypeNode(node) || ts.isIntersectionTypeNode(node)) {
|
|
70
|
+
return node.types.some((part) => serviceOrigin(checker, part, seen));
|
|
71
|
+
}
|
|
72
|
+
if (ts.isFunctionExpression(node) || ts.isArrowFunction(node)) {
|
|
73
|
+
return returnValues(node).some((value) => value !== undefined && serviceOrigin(checker, value, seen));
|
|
74
|
+
}
|
|
75
|
+
if (ts.isPropertyAccessExpression(node) && !SERVICE_NAMES.has(node.name.text)) {
|
|
76
|
+
return false;
|
|
77
|
+
}
|
|
78
|
+
const location = ts.isQualifiedName(node) ? node.right : node;
|
|
79
|
+
if (!(ts.isIdentifier(location) || ts.isPropertyAccessExpression(location))) {
|
|
80
|
+
return false;
|
|
81
|
+
}
|
|
82
|
+
const symbol = checker.getSymbolAtLocation(ts.isPropertyAccessExpression(location) ? location.name : location);
|
|
83
|
+
return symbol !== undefined && symbolOrigin(checker, symbol, seen);
|
|
84
|
+
}
|
|
85
|
+
//# sourceMappingURL=serviceOrigin.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceOrigin.js","sourceRoot":"","sources":["../../../src/rules/effect/serviceOrigin.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,YAAY,EAAE,MAAM,gCAAgC,CAAC;AAE9D,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,SAAS,EAAE,cAAc,EAAE,KAAK,EAAE,WAAW,EAAE,KAAK,EAAE,UAAU,EAAE,YAAY,CAAC,CAAC,CAAC;AAEhH,SAAS,UAAU,CAAC,WAA2B;IAC9C,IACC,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC;WAClC,EAAE,CAAC,WAAW,CAAC,WAAW,CAAC;WAC3B,EAAE,CAAC,sBAAsB,CAAC,WAAW,CAAC;WACtC,EAAE,CAAC,cAAc,CAAC,WAAW,CAAC,EAChC,CAAC;QACF,OAAO,WAAW,CAAC,IAAI,CAAC;IACzB,CAAC;IACD,OAAO,EAAE,CAAC,0BAA0B,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;AACxF,CAAC;AAED,SAAS,iBAAiB,CAAC,OAAuB,EAAE,WAA2B,EAAE,IAAoB;IACpG,MAAM,IAAI,GAAG,UAAU,CAAC,WAAW,CAAC,CAAC;IACrC,IAAI,IAAI,KAAK,SAAS,IAAI,aAAa,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC;QAC9D,OAAO,IAAI,CAAC;IACb,CAAC;IACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,WAAW,CAAC,WAAW,KAAK,SAAS,EAAE,CAAC;QACpF,OAAO,aAAa,CAAC,OAAO,EAAE,WAAW,CAAC,WAAW,EAAE,IAAI,CAAC,CAAC;IAC9D,CAAC;IACD,IAAI,EAAE,CAAC,kBAAkB,CAAC,WAAW,CAAC,IAAI,EAAE,CAAC,sBAAsB,CAAC,WAAW,CAAC,EAAE,CAAC;QAClF,OAAO,WAAW,CAAC,eAAe,EAAE,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,aAAa,CAAC,OAAO,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC;IAC3I,CAAC;IACD,OAAO,EAAE,CAAC,cAAc,CAAC,WAAW,CAAC,IAAI,YAAY,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,IAAI,aAAa,CAAC,OAAO,EAAE,KAAK,EAAE,IAAI,CAAC,CAAC,CAAC;AAChJ,CAAC;AAED,SAAS,YAAY,CAAC,OAAuB,EAAE,MAAiB,EAAE,IAAoB;IACrF,MAAM,MAAM,GAAG,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;IAC/F,IAAI,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;QACtB,OAAO,KAAK,CAAC;IACd,CAAC;IACD,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;IACjB,OAAO,CAAC,MAAM,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,WAAW,EAAE,EAAE;QACvD,MAAM,IAAI,GAAG,WAAW,CAAC,aAAa,EAAE,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC;QACxE,IACC,0DAA0D,CAAC,IAAI,CAAC,IAAI,CAAC;eAClE,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC;eAC9B,CAAC,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC;mBACrC,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC;mBACrC,EAAE,CAAC,kBAAkB,CAAC,WAAW,CAAC;mBAClC,EAAE,CAAC,sBAAsB,CAAC,WAAW,CAAC;mBACtC,EAAE,CAAC,sBAAsB,CAAC,WAAW,CAAC,CAAC,EAC1C,CAAC;YACF,OAAO,IAAI,CAAC;QACb,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ,CAAC,+BAA+B,CAAC,IAAI,MAAM,CAAC,IAAI,KAAK,eAAe,EAAE,CAAC;YACvF,OAAO,IAAI,CAAC;QACb,CAAC;QACD,OAAO,iBAAiB,CAAC,OAAO,EAAE,WAAW,EAAE,IAAI,CAAC,CAAC;IACtD,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,SAAS,SAAS,CAAC,IAAa;IAC/B,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;QAC/B,OAAO,IAAI,CAAC,UAAU,CAAC;IACxB,CAAC;IACD,IAAI,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;QAClC,OAAO,IAAI,CAAC,QAAQ,CAAC;IACtB,CAAC;IACD,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;QAC9B,OAAO,IAAI,CAAC,QAAQ,CAAC;IACtB,CAAC;IACD,OAAO,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;AACjE,CAAC;AAED,MAAM,UAAU,aAAa,CAAC,OAAuB,EAAE,IAAyB,EAAE,IAAI,GAAG,IAAI,GAAG,EAAa;IAC5G,IAAI,CAAC,CAAC,MAAM,IAAI,IAAI,CAAC,EAAE,CAAC;QACvB,OAAO,YAAY,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;IAC1C,CAAC;IACD,MAAM,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC,CAAC;IACjC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QAC5B,OAAO,aAAa,CAAC,OAAO,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAC;IAC/C,CAAC;IACD,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,sBAAsB,CAAC,IAAI,CAAC,EAAE,CAAC;QACjE,OAAO,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,aAAa,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;IACtE,CAAC;IACD,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;QAC/D,OAAO,YAAY,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,IAAI,aAAa,CAAC,OAAO,EAAE,KAAK,EAAE,IAAI,CAAC,CAAC,CAAC;IACvG,CAAC;IACD,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;QAC/E,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,QAAQ,GAAG,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC;IAC9D,IAAI,CAAC,CAAC,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;QAC7E,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,EAAE,CAAC,0BAA0B,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;IAC/G,OAAO,MAAM,KAAK,SAAS,IAAI,YAAY,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,CAAC,CAAC;AACpE,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceParameters.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/serviceParameters.ts"],"names":[],"mappings":"AAMA,eAAO,MAAM,iBAAiB,iEAkB5B,CAAC"}
|
|
@@ -0,0 +1,33 @@
|
|
|
1
|
+
import { join } from "node:path";
|
|
2
|
+
import { defineRule } from "#rule.ts";
|
|
3
|
+
import { effectProgram } from "#rules/effect/program.ts";
|
|
4
|
+
import { serviceCatalog } from "#rules/effect/serviceCatalog.ts";
|
|
5
|
+
import { serviceFindings } from "#rules/effect/serviceFindings.ts";
|
|
6
|
+
export const serviceParameters = defineRule({
|
|
7
|
+
check: (inputs) => {
|
|
8
|
+
const groups = new Map();
|
|
9
|
+
for (const source of inputs.sources) {
|
|
10
|
+
if (/(?:^|\/)test-support\//u.test(source.path)) {
|
|
11
|
+
continue;
|
|
12
|
+
}
|
|
13
|
+
const group = /^(?:packages|examples)\/[^/]+/u.exec(source.path)?.[0] ?? ".";
|
|
14
|
+
const files = groups.get(group) ?? [];
|
|
15
|
+
files.push(source);
|
|
16
|
+
groups.set(group, files);
|
|
17
|
+
}
|
|
18
|
+
return [...groups.values()].flatMap((sources) => checkServices({ ...inputs, sources }));
|
|
19
|
+
},
|
|
20
|
+
description: "Exported functions and public methods take services from Effect's environment, including aliases, constraints, inferred/destructured parameters and factory returns. Service keys/classes, non-empty Contexts and implementation shapes are services; Effect/Stream requirements are computations. Service implementation methods and Layer constructors are accepted. Only test-support/ folders are exempt. The fixed adapters/ convention bridges outside libraries to Effect values; adapters still follow this rule and ambient runtime bans. No config exceptions or inline suppressions; baseline existing debt.",
|
|
21
|
+
id: "effect/service-parameters",
|
|
22
|
+
registrable: false,
|
|
23
|
+
});
|
|
24
|
+
function checkServices(inputs) {
|
|
25
|
+
const program = effectProgram(inputs);
|
|
26
|
+
const checker = program.getTypeChecker();
|
|
27
|
+
const sources = inputs.sources.flatMap((file) => {
|
|
28
|
+
const source = program.getSourceFile(join(inputs.root, file.path));
|
|
29
|
+
return source === undefined ? [] : [source];
|
|
30
|
+
});
|
|
31
|
+
return serviceFindings(inputs.root, sources, checker, serviceCatalog(program, checker));
|
|
32
|
+
}
|
|
33
|
+
//# sourceMappingURL=serviceParameters.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceParameters.js","sourceRoot":"","sources":["../../../src/rules/effect/serviceParameters.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAE,aAAa,EAAE,MAAM,0BAA0B,CAAC;AACzD,OAAO,EAAE,cAAc,EAAE,MAAM,iCAAiC,CAAC;AACjE,OAAO,EAAE,eAAe,EAAE,MAAM,kCAAkC,CAAC;AAEnE,MAAM,CAAC,MAAM,iBAAiB,GAAG,UAAU,CAAC;IAC3C,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE;QACjB,MAAM,MAAM,GAAG,IAAI,GAAG,EAA2C,CAAC;QAClE,KAAK,MAAM,MAAM,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;YACrC,IAAI,yBAAyB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;gBACjD,SAAS;YACV,CAAC;YACD,MAAM,KAAK,GAAG,gCAAgC,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC;YAC7E,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;YACtC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;YACnB,MAAM,CAAC,GAAG,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAC1B,CAAC;QACD,OAAO,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,aAAa,CAAC,EAAE,GAAG,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC;IACzF,CAAC;IACD,WAAW,EACV,ylBAAylB;IAC1lB,EAAE,EAAE,2BAA2B;IAC/B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC;AAEH,SAAS,aAAa,CAAC,MAAkB;IACxC,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC;IACtC,MAAM,OAAO,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IACzC,MAAM,OAAO,GAAG,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QAC/C,MAAM,MAAM,GAAG,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;QACnE,OAAO,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IACH,OAAO,eAAe,CAAC,MAAM,CAAC,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,cAAc,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,CAAC;AACzF,CAAC"}
|
|
@@ -0,0 +1,8 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
export declare function serviceTypes(checker: ts.TypeChecker): {
|
|
3
|
+
carries: (type: ts.Type) => boolean;
|
|
4
|
+
computation: (type: ts.Type) => boolean;
|
|
5
|
+
implementation: (type: ts.Type) => boolean;
|
|
6
|
+
remember: (type: ts.Type) => void;
|
|
7
|
+
};
|
|
8
|
+
//# sourceMappingURL=serviceTypes.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceTypes.d.ts","sourceRoot":"","sources":["../../../src/rules/effect/serviceTypes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAK5B,wBAAgB,YAAY,CAAC,OAAO,EAAE,EAAE,CAAC,WAAW;oBAkFlC,EAAE,CAAC,IAAI;wBA5DG,EAAE,CAAC,IAAI,KAAG,OAAO;2BAGd,EAAE,CAAC,IAAI,KAAG,OAAO;qBAlBvB,EAAE,CAAC,IAAI,KAAG,IAAI;EAwFtC"}
|
|
@@ -0,0 +1,94 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
const SERVICE = "~effect/Context/Service";
|
|
3
|
+
const CONTEXT = "~effect/Context";
|
|
4
|
+
export function serviceTypes(checker) {
|
|
5
|
+
const shapes = new Set();
|
|
6
|
+
const carried = new Map();
|
|
7
|
+
function propertyType(type, name) {
|
|
8
|
+
const property = type.getProperty(name);
|
|
9
|
+
return property === undefined ? undefined : checker.getTypeOfSymbol(property);
|
|
10
|
+
}
|
|
11
|
+
function remember(type) {
|
|
12
|
+
if (type.getProperty(SERVICE) === undefined) {
|
|
13
|
+
return;
|
|
14
|
+
}
|
|
15
|
+
const shape = propertyType(type, "Service");
|
|
16
|
+
if (shape !== undefined
|
|
17
|
+
&& shape.flags & ts.TypeFlags.Object
|
|
18
|
+
&& (shape.getProperties().length > 0 || shape.getCallSignatures().length > 0)
|
|
19
|
+
&& checker.getIndexInfosOfType(shape).length === 0
|
|
20
|
+
&& (shape.getCallSignatures().length === 0 || type.getProperty("~effect/Context/Reference") === undefined)) {
|
|
21
|
+
shapes.add(shape);
|
|
22
|
+
}
|
|
23
|
+
}
|
|
24
|
+
function computation(type) {
|
|
25
|
+
return ["~effect/Effect", "~effect/Stream"].some((brand) => type.getProperty(brand) !== undefined);
|
|
26
|
+
}
|
|
27
|
+
function implementation(type) {
|
|
28
|
+
if (shapes.has(type)) {
|
|
29
|
+
return true;
|
|
30
|
+
}
|
|
31
|
+
const declaration = type.getSymbol()?.valueDeclaration;
|
|
32
|
+
const contextual = declaration !== undefined && ts.isObjectLiteralExpression(declaration) ? checker.getContextualType(declaration) : undefined;
|
|
33
|
+
return contextual !== undefined && shapes.has(contextual);
|
|
34
|
+
}
|
|
35
|
+
function nonEmptyContext(context) {
|
|
36
|
+
const variance = propertyType(context, "_Services");
|
|
37
|
+
const parameter = variance?.getCallSignatures()[0]?.parameters[0];
|
|
38
|
+
if (parameter === undefined) {
|
|
39
|
+
return false;
|
|
40
|
+
}
|
|
41
|
+
const required = checker.getTypeOfSymbol(parameter);
|
|
42
|
+
return !((checker.getBaseConstraintOfType(required) ?? required).flags & ts.TypeFlags.Never);
|
|
43
|
+
}
|
|
44
|
+
function carries(type, seen = new Set()) {
|
|
45
|
+
if (seen.has(type)
|
|
46
|
+
|| type.flags
|
|
47
|
+
& (ts.TypeFlags.Any
|
|
48
|
+
| ts.TypeFlags.Unknown
|
|
49
|
+
| ts.TypeFlags.Never
|
|
50
|
+
| ts.TypeFlags.StringLike
|
|
51
|
+
| ts.TypeFlags.NumberLike
|
|
52
|
+
| ts.TypeFlags.BooleanLike
|
|
53
|
+
| ts.TypeFlags.ESSymbolLike
|
|
54
|
+
| ts.TypeFlags.BigIntLike)) {
|
|
55
|
+
return false;
|
|
56
|
+
}
|
|
57
|
+
seen.add(type);
|
|
58
|
+
if (type.isUnionOrIntersection()) {
|
|
59
|
+
return type.types.some((part) => carries(part, seen));
|
|
60
|
+
}
|
|
61
|
+
if (type.getProperty(SERVICE) !== undefined) {
|
|
62
|
+
return true;
|
|
63
|
+
}
|
|
64
|
+
const context = propertyType(type, CONTEXT);
|
|
65
|
+
if (context !== undefined) {
|
|
66
|
+
return nonEmptyContext(context);
|
|
67
|
+
}
|
|
68
|
+
if (computation(type)) {
|
|
69
|
+
return false;
|
|
70
|
+
}
|
|
71
|
+
const constraint = checker.getBaseConstraintOfType(type);
|
|
72
|
+
if (constraint !== undefined && carries(constraint, seen)) {
|
|
73
|
+
return true;
|
|
74
|
+
}
|
|
75
|
+
return (implementation(type)
|
|
76
|
+
|| checker.getIndexInfosOfType(type).some((index) => carries(index.type, seen))
|
|
77
|
+
|| type.getProperties().some((property) => !(property.flags & ts.SymbolFlags.Method) && carries(checker.getTypeOfSymbol(property), seen)));
|
|
78
|
+
}
|
|
79
|
+
return {
|
|
80
|
+
carries: (type) => {
|
|
81
|
+
const known = carried.get(type);
|
|
82
|
+
if (known !== undefined) {
|
|
83
|
+
return known;
|
|
84
|
+
}
|
|
85
|
+
const result = carries(type);
|
|
86
|
+
carried.set(type, result);
|
|
87
|
+
return result;
|
|
88
|
+
},
|
|
89
|
+
computation,
|
|
90
|
+
implementation,
|
|
91
|
+
remember,
|
|
92
|
+
};
|
|
93
|
+
}
|
|
94
|
+
//# sourceMappingURL=serviceTypes.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"serviceTypes.js","sourceRoot":"","sources":["../../../src/rules/effect/serviceTypes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAE5B,MAAM,OAAO,GAAG,yBAAyB,CAAC;AAC1C,MAAM,OAAO,GAAG,iBAAiB,CAAC;AAElC,MAAM,UAAU,YAAY,CAAC,OAAuB;IACnD,MAAM,MAAM,GAAG,IAAI,GAAG,EAAW,CAAC;IAClC,MAAM,OAAO,GAAG,IAAI,GAAG,EAAoB,CAAC;IAC5C,SAAS,YAAY,CAAC,IAAa,EAAE,IAAY;QAChD,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;QACxC,OAAO,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;IAC/E,CAAC;IACD,SAAS,QAAQ,CAAC,IAAa;QAC9B,IAAI,IAAI,CAAC,WAAW,CAAC,OAAO,CAAC,KAAK,SAAS,EAAE,CAAC;YAC7C,OAAO;QACR,CAAC;QACD,MAAM,KAAK,GAAG,YAAY,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC;QAC5C,IACC,KAAK,KAAK,SAAS;eAChB,KAAK,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,MAAM;eACjC,CAAC,KAAK,CAAC,aAAa,EAAE,CAAC,MAAM,GAAG,CAAC,IAAI,KAAK,CAAC,iBAAiB,EAAE,CAAC,MAAM,GAAG,CAAC,CAAC;eAC1E,OAAO,CAAC,mBAAmB,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC;eAC/C,CAAC,KAAK,CAAC,iBAAiB,EAAE,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,CAAC,WAAW,CAAC,2BAA2B,CAAC,KAAK,SAAS,CAAC,EACzG,CAAC;YACF,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;QACnB,CAAC;IACF,CAAC;IACD,SAAS,WAAW,CAAC,IAAa;QACjC,OAAO,CAAC,gBAAgB,EAAE,gBAAgB,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC,KAAK,SAAS,CAAC,CAAC;IACpG,CAAC;IACD,SAAS,cAAc,CAAC,IAAa;QACpC,IAAI,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACtB,OAAO,IAAI,CAAC;QACb,CAAC;QACD,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,EAAE,EAAE,gBAAgB,CAAC;QACvD,MAAM,UAAU,GAAG,WAAW,KAAK,SAAS,IAAI,EAAE,CAAC,yBAAyB,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAC/I,OAAO,UAAU,KAAK,SAAS,IAAI,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC3D,CAAC;IACD,SAAS,eAAe,CAAC,OAAgB;QACxC,MAAM,QAAQ,GAAG,YAAY,CAAC,OAAO,EAAE,WAAW,CAAC,CAAC;QACpD,MAAM,SAAS,GAAG,QAAQ,EAAE,iBAAiB,EAAE,CAAC,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC,CAAC,CAAC;QAClE,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC7B,OAAO,KAAK,CAAC;QACd,CAAC;QACD,MAAM,QAAQ,GAAG,OAAO,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC;QACpD,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,uBAAuB,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;IAC9F,CAAC;IACD,SAAS,OAAO,CAAC,IAAa,EAAE,IAAI,GAAG,IAAI,GAAG,EAAW;QACxD,IACC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;eACX,IAAI,CAAC,KAAK;kBACV,CAAC,EAAE,CAAC,SAAS,CAAC,GAAG;sBAChB,EAAE,CAAC,SAAS,CAAC,OAAO;sBACpB,EAAE,CAAC,SAAS,CAAC,KAAK;sBAClB,EAAE,CAAC,SAAS,CAAC,UAAU;sBACvB,EAAE,CAAC,SAAS,CAAC,UAAU;sBACvB,EAAE,CAAC,SAAS,CAAC,WAAW;sBACxB,EAAE,CAAC,SAAS,CAAC,YAAY;sBACzB,EAAE,CAAC,SAAS,CAAC,UAAU,CAAC,EAC3B,CAAC;YACF,OAAO,KAAK,CAAC;QACd,CAAC;QACD,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACf,IAAI,IAAI,CAAC,qBAAqB,EAAE,EAAE,CAAC;YAClC,OAAO,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;QACvD,CAAC;QACD,IAAI,IAAI,CAAC,WAAW,CAAC,OAAO,CAAC,KAAK,SAAS,EAAE,CAAC;YAC7C,OAAO,IAAI,CAAC;QACb,CAAC;QACD,MAAM,OAAO,GAAG,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;QAC5C,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YAC3B,OAAO,eAAe,CAAC,OAAO,CAAC,CAAC;QACjC,CAAC;QACD,IAAI,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;YACvB,OAAO,KAAK,CAAC;QACd,CAAC;QACD,MAAM,UAAU,GAAG,OAAO,CAAC,uBAAuB,CAAC,IAAI,CAAC,CAAC;QACzD,IAAI,UAAU,KAAK,SAAS,IAAI,OAAO,CAAC,UAAU,EAAE,IAAI,CAAC,EAAE,CAAC;YAC3D,OAAO,IAAI,CAAC;QACb,CAAC;QACD,OAAO,CACN,cAAc,CAAC,IAAI,CAAC;eACjB,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;eAC5E,IAAI,CAAC,aAAa,EAAE,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,GAAG,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,IAAI,OAAO,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,CAAC,CACzI,CAAC;IACH,CAAC;IACD,OAAO;QACN,OAAO,EAAE,CAAC,IAAa,EAAE,EAAE;YAC1B,MAAM,KAAK,GAAG,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAChC,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;gBACzB,OAAO,KAAK,CAAC;YACd,CAAC;YACD,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;YAC7B,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;YAC1B,OAAO,MAAM,CAAC;QACf,CAAC;QACD,WAAW;QACX,cAAc;QACd,QAAQ;KACR,CAAC;AACH,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"jsxConditionals.d.ts","sourceRoot":"","sources":["../../../src/rules/react/jsxConditionals.ts"],"names":[],"mappings":"AAgCA,eAAO,MAAM,eAAe,8DA0B1B,CAAC"}
|
|
@@ -0,0 +1,54 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { defineRule } from "#rule.ts";
|
|
3
|
+
import { parse } from "#rules/parse.ts";
|
|
4
|
+
const REPAIR = "Decide before the JSX with an if and early return, or a variable computed above the return; or extract a component that receives the data and returns null when it has nothing to show.";
|
|
5
|
+
function mapCall(node) {
|
|
6
|
+
return ts.isCallExpression(node) && ts.isPropertyAccessExpression(node.expression) && node.expression.name.text === "map";
|
|
7
|
+
}
|
|
8
|
+
function childContext(node) {
|
|
9
|
+
let mapped = false;
|
|
10
|
+
let child = false;
|
|
11
|
+
for (let parent = node.parent; parent !== undefined; parent = parent.parent) {
|
|
12
|
+
if (!child && ts.isJsxSpreadAttribute(parent)) {
|
|
13
|
+
return undefined;
|
|
14
|
+
}
|
|
15
|
+
if (ts.isJsxExpression(parent)) {
|
|
16
|
+
if (!(child || ts.isJsxElement(parent.parent) || ts.isJsxFragment(parent.parent))) {
|
|
17
|
+
return undefined;
|
|
18
|
+
}
|
|
19
|
+
child = true;
|
|
20
|
+
}
|
|
21
|
+
if (ts.isVariableDeclaration(parent) || (ts.isStatement(parent) && !ts.isReturnStatement(parent) && !ts.isBlock(parent))) {
|
|
22
|
+
break;
|
|
23
|
+
}
|
|
24
|
+
mapped ||= mapCall(parent);
|
|
25
|
+
}
|
|
26
|
+
return child ? { mapped } : undefined;
|
|
27
|
+
}
|
|
28
|
+
export const jsxConditionals = defineRule({
|
|
29
|
+
check: ({ sources }) => sources.flatMap((file) => {
|
|
30
|
+
const source = parse(file);
|
|
31
|
+
const findings = [];
|
|
32
|
+
function visit(node) {
|
|
33
|
+
if (ts.isConditionalExpression(node) || (ts.isBinaryExpression(node) && node.operatorToken.kind === ts.SyntaxKind.AmpersandAmpersandToken)) {
|
|
34
|
+
const context = childContext(node);
|
|
35
|
+
if (context !== undefined && source !== undefined) {
|
|
36
|
+
findings.push({
|
|
37
|
+
file: file.path,
|
|
38
|
+
line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1,
|
|
39
|
+
message: `Conditional rendering inside a JSX child. ${REPAIR}${context.mapped ? " Inside .map, extract the item into its own component that makes its own decision." : ""}`,
|
|
40
|
+
});
|
|
41
|
+
}
|
|
42
|
+
}
|
|
43
|
+
ts.forEachChild(node, visit);
|
|
44
|
+
}
|
|
45
|
+
if (source !== undefined) {
|
|
46
|
+
visit(source);
|
|
47
|
+
}
|
|
48
|
+
return findings;
|
|
49
|
+
}),
|
|
50
|
+
description: `Components decide what to render outside their JSX. ${REPAIR} Inside .map, extract an item component that makes its own decision. Attribute values are accepted.`,
|
|
51
|
+
id: "react/jsx-conditionals",
|
|
52
|
+
registrable: false,
|
|
53
|
+
});
|
|
54
|
+
//# sourceMappingURL=jsxConditionals.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"jsxConditionals.js","sourceRoot":"","sources":["../../../src/rules/react/jsxConditionals.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAgB,MAAM,UAAU,CAAC;AACpD,OAAO,EAAE,KAAK,EAAE,MAAM,iBAAiB,CAAC;AAExC,MAAM,MAAM,GACX,yLAAyL,CAAC;AAE3L,SAAS,OAAO,CAAC,IAAa;IAC7B,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,KAAK,CAAC;AAC3H,CAAC;AAED,SAAS,YAAY,CAAC,IAAa;IAClC,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,IAAI,KAAK,GAAG,KAAK,CAAC;IAClB,KAAK,IAAI,MAAM,GAAG,IAAI,CAAC,MAAM,EAAE,MAAM,KAAK,SAAS,EAAE,MAAM,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC;QAC7E,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC,oBAAoB,CAAC,MAAM,CAAC,EAAE,CAAC;YAC/C,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,IAAI,EAAE,CAAC,eAAe,CAAC,MAAM,CAAC,EAAE,CAAC;YAChC,IAAI,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,aAAa,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC;gBACnF,OAAO,SAAS,CAAC;YAClB,CAAC;YACD,KAAK,GAAG,IAAI,CAAC;QACd,CAAC;QACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,iBAAiB,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC;YAC1H,MAAM;QACP,CAAC;QACD,MAAM,KAAK,OAAO,CAAC,MAAM,CAAC,CAAC;IAC5B,CAAC;IACD,OAAO,KAAK,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;AACvC,CAAC;AAED,MAAM,CAAC,MAAM,eAAe,GAAG,UAAU,CAAC;IACzC,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,EAAE,CACtB,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACxB,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC;QAC3B,MAAM,QAAQ,GAAc,EAAE,CAAC;QAC/B,SAAS,KAAK,CAAC,IAAa;YAC3B,IAAI,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,uBAAuB,CAAC,EAAE,CAAC;gBAC5I,MAAM,OAAO,GAAG,YAAY,CAAC,IAAI,CAAC,CAAC;gBACnC,IAAI,OAAO,KAAK,SAAS,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;oBACnD,QAAQ,CAAC,IAAI,CAAC;wBACb,IAAI,EAAE,IAAI,CAAC,IAAI;wBACf,IAAI,EAAE,MAAM,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC;wBAC1E,OAAO,EAAE,6CAA6C,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,oFAAoF,CAAC,CAAC,CAAC,EAAE,EAAE;qBAC3K,CAAC,CAAC;gBACJ,CAAC;YACF,CAAC;YACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QAC9B,CAAC;QACD,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,KAAK,CAAC,MAAM,CAAC,CAAC;QACf,CAAC;QACD,OAAO,QAAQ,CAAC;IACjB,CAAC,CAAC;IACH,WAAW,EAAE,uDAAuD,MAAM,qGAAqG;IAC/K,EAAE,EAAE,wBAAwB;IAC5B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"engineOf.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AA2DpD,wBAAgB,QAAQ,CAAC,QAAQ,EAAE,QAAQ,GAAG,MAAM,GAAG,SAAS,
|
|
1
|
+
{"version":3,"file":"engineOf.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AA2DpD,wBAAgB,QAAQ,CAAC,QAAQ,EAAE,QAAQ,GAAG,MAAM,GAAG,SAAS,CAM/D"}
|
|
@@ -54,7 +54,8 @@ function names(prefix, specifier) {
|
|
|
54
54
|
return prefix.endsWith("/") ? specifier.startsWith(prefix) : specifier === prefix || specifier.startsWith(`${prefix}/`);
|
|
55
55
|
}
|
|
56
56
|
export function engineOf(endpoint) {
|
|
57
|
-
|
|
57
|
+
// HttpStatus only maps names to numbers; importing it acquires no network services.
|
|
58
|
+
if (endpoint.kind === "file" || endpoint.specifier === "effect/http/HttpStatus") {
|
|
58
59
|
return undefined;
|
|
59
60
|
}
|
|
60
61
|
return ENGINES.find(([, prefixes]) => prefixes.some((prefix) => names(prefix, endpoint.specifier) || names(prefix, endpoint.package)))?.[0];
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"engineOf.js","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAEA,MAAM,OAAO,GAAwD;IACpE,CAAC,iBAAiB,EAAE,CAAC,SAAS,CAAC,CAAC;IAChC;QACC,aAAa;QACb;YACC,YAAY;YACZ,UAAU;YACV,WAAW;YACX,YAAY;YACZ,YAAY;YACZ,UAAU;YACV,UAAU;YACV,aAAa;YACb,eAAe;YACf,0BAA0B;YAC1B,sBAAsB;YACtB,uBAAuB;YACvB,8BAA8B;YAC9B,cAAc;YACd,cAAc;YACd,SAAS;YACT,SAAS;YACT,MAAM;YACN,QAAQ;YACR,IAAI;SACJ;KACD;IACD,CAAC,WAAW,EAAE,CAAC,oBAAoB,EAAE,cAAc,EAAE,cAAc,EAAE,eAAe,EAAE,gBAAgB,EAAE,aAAa,CAAC,CAAC;IACvH,CAAC,UAAU,EAAE,CAAC,qBAAqB,EAAE,gBAAgB,CAAC,CAAC;IACvD;QACC,YAAY;QACZ;YACC,aAAa;YACb,oBAAoB;YACpB,YAAY;YACZ,aAAa;YACb,gBAAgB;YAChB,yBAAyB;YACzB,sBAAsB;YACtB,gBAAgB;YAChB,eAAe;YACf,aAAa;YACb,gBAAgB;YAChB,QAAQ;YACR,IAAI;YACJ,SAAS;YACT,UAAU;SACV;KACD;IACD,CAAC,SAAS,EAAE,CAAC,aAAa,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,WAAW,EAAE,OAAO,EAAE,YAAY,EAAE,WAAW,CAAC,CAAC;IACtH,CAAC,gBAAgB,EAAE,CAAC,qBAAqB,EAAE,2BAA2B,EAAE,uBAAuB,CAAC,CAAC;CACjG,CAAC;AAEF,SAAS,KAAK,CAAC,MAAc,EAAE,SAAiB;IAC/C,OAAO,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,KAAK,MAAM,IAAI,SAAS,CAAC,UAAU,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC;AACzH,CAAC;AAED,MAAM,UAAU,QAAQ,CAAC,QAAkB;IAC1C,IAAI,QAAQ,CAAC,IAAI,KAAK,MAAM,EAAE,CAAC;
|
|
1
|
+
{"version":3,"file":"engineOf.js","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAEA,MAAM,OAAO,GAAwD;IACpE,CAAC,iBAAiB,EAAE,CAAC,SAAS,CAAC,CAAC;IAChC;QACC,aAAa;QACb;YACC,YAAY;YACZ,UAAU;YACV,WAAW;YACX,YAAY;YACZ,YAAY;YACZ,UAAU;YACV,UAAU;YACV,aAAa;YACb,eAAe;YACf,0BAA0B;YAC1B,sBAAsB;YACtB,uBAAuB;YACvB,8BAA8B;YAC9B,cAAc;YACd,cAAc;YACd,SAAS;YACT,SAAS;YACT,MAAM;YACN,QAAQ;YACR,IAAI;SACJ;KACD;IACD,CAAC,WAAW,EAAE,CAAC,oBAAoB,EAAE,cAAc,EAAE,cAAc,EAAE,eAAe,EAAE,gBAAgB,EAAE,aAAa,CAAC,CAAC;IACvH,CAAC,UAAU,EAAE,CAAC,qBAAqB,EAAE,gBAAgB,CAAC,CAAC;IACvD;QACC,YAAY;QACZ;YACC,aAAa;YACb,oBAAoB;YACpB,YAAY;YACZ,aAAa;YACb,gBAAgB;YAChB,yBAAyB;YACzB,sBAAsB;YACtB,gBAAgB;YAChB,eAAe;YACf,aAAa;YACb,gBAAgB;YAChB,QAAQ;YACR,IAAI;YACJ,SAAS;YACT,UAAU;SACV;KACD;IACD,CAAC,SAAS,EAAE,CAAC,aAAa,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,WAAW,EAAE,OAAO,EAAE,YAAY,EAAE,WAAW,CAAC,CAAC;IACtH,CAAC,gBAAgB,EAAE,CAAC,qBAAqB,EAAE,2BAA2B,EAAE,uBAAuB,CAAC,CAAC;CACjG,CAAC;AAEF,SAAS,KAAK,CAAC,MAAc,EAAE,SAAiB;IAC/C,OAAO,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,KAAK,MAAM,IAAI,SAAS,CAAC,UAAU,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC;AACzH,CAAC;AAED,MAAM,UAAU,QAAQ,CAAC,QAAkB;IAC1C,oFAAoF;IACpF,IAAI,QAAQ,CAAC,IAAI,KAAK,MAAM,IAAI,QAAQ,CAAC,SAAS,KAAK,wBAAwB,EAAE,CAAC;QACjF,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,OAAO,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,QAAQ,CAAC,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,SAAS,CAAC,IAAI,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;AAC7I,CAAC"}
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
import ts from "typescript";
|
|
2
2
|
import { defineRule } from "#rule.ts";
|
|
3
3
|
import { isSpec, memberName, nodesWhere, numericValue, syntaxFindings, unwrapped } from "./syntax.js";
|
|
4
|
-
const MESSAGE =
|
|
4
|
+
const MESSAGE = 'Passes a numeric literal or a matcher-only spec-local numeric const to toBe or toHaveLength. Assert the observed items, write the literal where accepted (zero or a process exitCode), or derive the value from the story\'s inputs. For HTTP statuses, import * as HttpStatus from "effect/http/HttpStatus" and use HttpStatus.fromLiteral("NotFound"), for example.';
|
|
5
5
|
function matcherCall(node) {
|
|
6
6
|
return ts.isCallExpression(node) && ["toBe", "toHaveLength"].includes(memberName(node.expression) ?? "");
|
|
7
7
|
}
|
|
@@ -41,7 +41,7 @@ function matcherAliases(source) {
|
|
|
41
41
|
.filter((references) => references.every((reference) => matcherCall(reference.parent) && reference.parent.arguments.includes(reference)))
|
|
42
42
|
.flatMap((references) => references.map((reference) => reference.parent)));
|
|
43
43
|
}
|
|
44
|
-
function
|
|
44
|
+
function exitCodeSubject(expression) {
|
|
45
45
|
const value = unwrapped(expression);
|
|
46
46
|
if (!(ts.isPropertyAccessExpression(value) || ts.isElementAccessExpression(value))) {
|
|
47
47
|
return false;
|
|
@@ -61,11 +61,11 @@ function codeSubject(expression) {
|
|
|
61
61
|
return false;
|
|
62
62
|
}
|
|
63
63
|
const subject = unwrapped(argument);
|
|
64
|
-
return
|
|
64
|
+
return (ts.isIdentifier(subject) ? subject.text : memberName(subject)) === "exitCode";
|
|
65
65
|
}
|
|
66
66
|
function numericAssertion(node) {
|
|
67
67
|
return (matcherCall(node)
|
|
68
|
-
&& !
|
|
68
|
+
&& !exitCodeSubject(node.expression)
|
|
69
69
|
&& node.arguments.some((argument) => {
|
|
70
70
|
const value = numericValue(argument);
|
|
71
71
|
return value !== undefined && value !== 0;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"namedValues.js","sourceRoot":"","sources":["../../../src/rules/stories/namedValues.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,UAAU,EAAE,YAAY,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEtG,MAAM,OAAO,GACZ,
|
|
1
|
+
{"version":3,"file":"namedValues.js","sourceRoot":"","sources":["../../../src/rules/stories/namedValues.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,UAAU,EAAE,YAAY,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEtG,MAAM,OAAO,GACZ,uWAAuW,CAAC;AAEzW,SAAS,WAAW,CAAC,IAAa;IACjC,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,cAAc,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC;AAC1G,CAAC;AAED,SAAS,cAAc,CAAC,MAAqB;IAC5C,MAAM,YAAY,GAAG,UAAU,CAC9B,MAAM,EACN,CAAC,IAAI,EAAE,EAAE,CACR,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;WAC3B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;WAC1B,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,MAAM,CAAC;WACzC,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC;WAC9C,IAAI,CAAC,WAAW,KAAK,SAAS;WAC9B,YAAY,CAAC,IAAI,CAAC,WAAW,CAAC,KAAK,SAAS,CAChD,CAAC,MAAM,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC;IACnC,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC/B,OAAO,IAAI,GAAG,EAAE,CAAC;IAClB,CAAC;IACD,MAAM,OAAO,GAAuB,EAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;IAC/F,MAAM,IAAI,GAAG,EAAE,CAAC,kBAAkB,CAAC,OAAO,CAAC,CAAC;IAC5C,IAAI,CAAC,aAAa,GAAG,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,IAAI,KAAK,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IAC/E,MAAM,OAAO,GAAG,EAAE,CAAC,aAAa,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,EAAE,OAAO,EAAE,IAAI,CAAC,CAAC,cAAc,EAAE,CAAC;IACpF,MAAM,OAAO,GAAG,IAAI,GAAG,EAA8B,CAAC;IACtD,KAAK,MAAM,WAAW,IAAI,YAAY,EAAE,CAAC;QACxC,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;QAC7D,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;QACzB,CAAC;IACF,CAAC;IACD,KAAK,MAAM,IAAI,IAAI,UAAU,CAAC,MAAM,EAAE,EAAE,CAAC,YAAY,CAAC,EAAE,CAAC;QACxD,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;YACpG,SAAS;QACV,CAAC;QACD,MAAM,MAAM,GAAG,EAAE,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,CAAC;YAC3D,CAAC,CAAC,OAAO,CAAC,iCAAiC,CAAC,IAAI,CAAC,MAAM,CAAC;YACxD,CAAC,CAAC,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QACrC,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,CAAC;IACF,CAAC;IACD,OAAO,IAAI,GAAG,CACb,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC;SACnB,MAAM,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,WAAW,CAAC,SAAS,CAAC,MAAM,CAAC,IAAI,SAAS,CAAC,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC;SACxI,OAAO,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAC1E,CAAC;AACH,CAAC;AAED,SAAS,eAAe,CAAC,UAAyB;IACjD,MAAM,KAAK,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC;IACpC,IAAI,CAAC,CAAC,EAAE,CAAC,0BAA0B,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;QACpF,OAAO,KAAK,CAAC;IACd,CAAC;IACD,IAAI,IAAI,GAAG,SAAS,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;IACvC,OAAO,CAAC,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,KAAK,KAAK,EAAE,CAAC;QAClH,IAAI,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACnC,CAAC;IACD,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;QAChC,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;IAC/F,MAAM,MAAM,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,IAAI,KAAK,QAAQ,IAAI,CAAC,QAAQ,KAAK,MAAM,IAAI,UAAU,CAAC,MAAM,CAAC,KAAK,MAAM,CAAC,CAAC;IACjI,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IACnC,IAAI,CAAC,MAAM,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QACvC,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,SAAS,CAAC,QAAQ,CAAC,CAAC;IACpC,OAAO,CAAC,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,KAAK,UAAU,CAAC;AACvF,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAa;IACtC,OAAO,CACN,WAAW,CAAC,IAAI,CAAC;WACd,CAAC,eAAe,CAAC,IAAI,CAAC,UAAU,CAAC;WACjC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE;YACnC,MAAM,KAAK,GAAG,YAAY,CAAC,QAAQ,CAAC,CAAC;YACrC,OAAO,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,CAAC,CAAC;QAC3C,CAAC,CAAC,CACF,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,WAAW,GAAG,UAAU,CAAC;IACrC,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,EAAE,CACtB,OAAO;SACL,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;SACnC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CACjB,cAAc,CACb,IAAI,EACJ,CAAC,MAAM,EAAE,EAAE;QACV,MAAM,OAAO,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;QACvC,OAAO,UAAU,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;IAClF,CAAC,EACD,OAAO,CACP,CACD;IACH,WAAW,EAAE,mFAAmF;IAChG,EAAE,EAAE,oBAAoB;CACxB,CAAC,CAAC"}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@shivaedev/quality",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.43.0",
|
|
4
4
|
"description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
|
|
5
5
|
"homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
|
|
6
6
|
"bugs": {
|
|
@@ -59,7 +59,7 @@
|
|
|
59
59
|
"dependencies": {
|
|
60
60
|
"@biomejs/biome": "2.5.15",
|
|
61
61
|
"@shivaedev/types": "0.3.0",
|
|
62
|
-
"ignore": "7.0.
|
|
62
|
+
"ignore": "7.0.13",
|
|
63
63
|
"sort-package-json": "4.1.0",
|
|
64
64
|
"typescript": "npm:@typescript/typescript6@6.0.2"
|
|
65
65
|
},
|
|
@@ -93,7 +93,7 @@
|
|
|
93
93
|
"scripts": {
|
|
94
94
|
"build": "node --eval \"import('node:fs').then(({ rmSync }) => rmSync('dist', { force: true, recursive: true }))\" && tsc --project tsconfig.build.json",
|
|
95
95
|
"ready": "pnpm typecheck && pnpm test && pnpm build",
|
|
96
|
-
"test": "vitest run",
|
|
96
|
+
"test": "vitest run --configLoader native",
|
|
97
97
|
"typecheck": "tsc --noEmit"
|
|
98
98
|
}
|
|
99
99
|
}
|
package/src/rules/builtIn.ts
CHANGED
|
@@ -5,6 +5,8 @@ import { noJsdoc } from "#rules/comments/noJsdoc.ts";
|
|
|
5
5
|
import { noLineReference } from "#rules/comments/noLineReference.ts";
|
|
6
6
|
import { noPrReference } from "#rules/comments/noPrReference.ts";
|
|
7
7
|
import { noTodo } from "#rules/comments/noTodo.ts";
|
|
8
|
+
import { effectBoundary } from "#rules/effect/boundary.ts";
|
|
9
|
+
import { serviceParameters } from "#rules/effect/serviceParameters.ts";
|
|
8
10
|
import { distinctCase } from "#rules/files/distinctCase.ts";
|
|
9
11
|
import { folderNames } from "#rules/files/folderNames.ts";
|
|
10
12
|
import { namedAfterExport } from "#rules/files/namedAfterExport.ts";
|
|
@@ -16,6 +18,7 @@ import { importsManifest } from "#rules/imports/manifest.ts";
|
|
|
16
18
|
import { noTestCode } from "#rules/imports/noTestCode.ts";
|
|
17
19
|
import { importsResolvable } from "#rules/imports/resolvable.ts";
|
|
18
20
|
import { importsRuntime } from "#rules/imports/runtime.ts";
|
|
21
|
+
import { jsxConditionals } from "#rules/react/jsxConditionals.ts";
|
|
19
22
|
import { authSql } from "#rules/stories/authSql.ts";
|
|
20
23
|
import { storyEngine } from "#rules/stories/engine.ts";
|
|
21
24
|
import { httpStatus } from "#rules/stories/httpStatus.ts";
|
|
@@ -43,6 +46,9 @@ import { maxLines } from "./maxLines.ts";
|
|
|
43
46
|
import { noBarrel } from "./noBarrel.ts";
|
|
44
47
|
|
|
45
48
|
export const builtInRules = [
|
|
49
|
+
effectBoundary,
|
|
50
|
+
serviceParameters,
|
|
51
|
+
jsxConditionals,
|
|
46
52
|
maxLines,
|
|
47
53
|
maxDepth,
|
|
48
54
|
noBarrel,
|