@shivaedev/quality 0.41.1 → 0.43.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (120) hide show
  1. package/CHANGELOG.md +47 -0
  2. package/README.md +56 -8
  3. package/biome/declarations.json +5 -0
  4. package/biome/plugins/ambient-runtime.grit +3 -1
  5. package/biome/plugins/effect-test-bodies.grit +1 -1
  6. package/biome/preset.json +2 -2
  7. package/dist/appTestConfig.js +1 -1
  8. package/dist/appTestConfig.js.map +1 -1
  9. package/dist/biome/withoutEntryPointImports.d.ts +4 -0
  10. package/dist/biome/withoutEntryPointImports.d.ts.map +1 -0
  11. package/dist/biome/withoutEntryPointImports.js +46 -0
  12. package/dist/biome/withoutEntryPointImports.js.map +1 -0
  13. package/dist/imports/pnpmWorkspacePatterns.d.ts +1 -0
  14. package/dist/imports/pnpmWorkspacePatterns.d.ts.map +1 -1
  15. package/dist/imports/pnpmWorkspacePatterns.js +28 -22
  16. package/dist/imports/pnpmWorkspacePatterns.js.map +1 -1
  17. package/dist/imports/runtime.d.ts +6 -0
  18. package/dist/imports/runtime.d.ts.map +1 -1
  19. package/dist/imports/runtime.js +54 -8
  20. package/dist/imports/runtime.js.map +1 -1
  21. package/dist/manifests/entryPoints.d.ts +15 -0
  22. package/dist/manifests/entryPoints.d.ts.map +1 -0
  23. package/dist/manifests/entryPoints.js +60 -0
  24. package/dist/manifests/entryPoints.js.map +1 -0
  25. package/dist/rules/biome.d.ts.map +1 -1
  26. package/dist/rules/biome.js +4 -2
  27. package/dist/rules/biome.js.map +1 -1
  28. package/dist/rules/builtIn.d.ts +2 -2
  29. package/dist/rules/builtIn.d.ts.map +1 -1
  30. package/dist/rules/builtIn.js +8 -0
  31. package/dist/rules/builtIn.js.map +1 -1
  32. package/dist/rules/effect/boundary.d.ts +2 -0
  33. package/dist/rules/effect/boundary.d.ts.map +1 -0
  34. package/dist/rules/effect/boundary.js +66 -0
  35. package/dist/rules/effect/boundary.js.map +1 -0
  36. package/dist/rules/effect/layerConstructor.d.ts +3 -0
  37. package/dist/rules/effect/layerConstructor.d.ts.map +1 -0
  38. package/dist/rules/effect/layerConstructor.js +35 -0
  39. package/dist/rules/effect/layerConstructor.js.map +1 -0
  40. package/dist/rules/effect/ownsParameters.d.ts +3 -0
  41. package/dist/rules/effect/ownsParameters.d.ts.map +1 -0
  42. package/dist/rules/effect/ownsParameters.js +45 -0
  43. package/dist/rules/effect/ownsParameters.js.map +1 -0
  44. package/dist/rules/effect/program.d.ts +4 -0
  45. package/dist/rules/effect/program.d.ts.map +1 -0
  46. package/dist/rules/effect/program.js +24 -0
  47. package/dist/rules/effect/program.js.map +1 -0
  48. package/dist/rules/effect/publicFunctions.d.ts +3 -0
  49. package/dist/rules/effect/publicFunctions.d.ts.map +1 -0
  50. package/dist/rules/effect/publicFunctions.js +68 -0
  51. package/dist/rules/effect/publicFunctions.js.map +1 -0
  52. package/dist/rules/effect/serviceCatalog.d.ts +8 -0
  53. package/dist/rules/effect/serviceCatalog.d.ts.map +1 -0
  54. package/dist/rules/effect/serviceCatalog.js +56 -0
  55. package/dist/rules/effect/serviceCatalog.js.map +1 -0
  56. package/dist/rules/effect/serviceFindings.d.ts +5 -0
  57. package/dist/rules/effect/serviceFindings.d.ts.map +1 -0
  58. package/dist/rules/effect/serviceFindings.js +88 -0
  59. package/dist/rules/effect/serviceFindings.js.map +1 -0
  60. package/dist/rules/effect/serviceOrigin.d.ts +3 -0
  61. package/dist/rules/effect/serviceOrigin.d.ts.map +1 -0
  62. package/dist/rules/effect/serviceOrigin.js +85 -0
  63. package/dist/rules/effect/serviceOrigin.js.map +1 -0
  64. package/dist/rules/effect/serviceParameters.d.ts +2 -0
  65. package/dist/rules/effect/serviceParameters.d.ts.map +1 -0
  66. package/dist/rules/effect/serviceParameters.js +33 -0
  67. package/dist/rules/effect/serviceParameters.js.map +1 -0
  68. package/dist/rules/effect/serviceTypes.d.ts +8 -0
  69. package/dist/rules/effect/serviceTypes.d.ts.map +1 -0
  70. package/dist/rules/effect/serviceTypes.js +94 -0
  71. package/dist/rules/effect/serviceTypes.js.map +1 -0
  72. package/dist/rules/imports/fences.d.ts +1 -1
  73. package/dist/rules/imports/manifest.d.ts.map +1 -1
  74. package/dist/rules/imports/manifest.js +27 -14
  75. package/dist/rules/imports/manifest.js.map +1 -1
  76. package/dist/rules/imports/runtime.d.ts.map +1 -1
  77. package/dist/rules/imports/runtime.js +10 -4
  78. package/dist/rules/imports/runtime.js.map +1 -1
  79. package/dist/rules/manifestsApplication.d.ts +2 -0
  80. package/dist/rules/manifestsApplication.d.ts.map +1 -0
  81. package/dist/rules/manifestsApplication.js +99 -0
  82. package/dist/rules/manifestsApplication.js.map +1 -0
  83. package/dist/rules/manifestsExportsShape.d.ts.map +1 -1
  84. package/dist/rules/manifestsExportsShape.js +5 -2
  85. package/dist/rules/manifestsExportsShape.js.map +1 -1
  86. package/dist/rules/react/jsxConditionals.d.ts +2 -0
  87. package/dist/rules/react/jsxConditionals.d.ts.map +1 -0
  88. package/dist/rules/react/jsxConditionals.js +54 -0
  89. package/dist/rules/react/jsxConditionals.js.map +1 -0
  90. package/dist/rules/stories/engineOf.d.ts.map +1 -1
  91. package/dist/rules/stories/engineOf.js +3 -2
  92. package/dist/rules/stories/engineOf.js.map +1 -1
  93. package/dist/rules/stories/namedValues.js +4 -4
  94. package/dist/rules/stories/namedValues.js.map +1 -1
  95. package/package.json +3 -3
  96. package/src/appTestConfig.ts +1 -1
  97. package/src/biome/withoutEntryPointImports.ts +52 -0
  98. package/src/imports/pnpmWorkspacePatterns.ts +29 -22
  99. package/src/imports/runtime.ts +69 -9
  100. package/src/manifests/entryPoints.ts +87 -0
  101. package/src/rules/biome.ts +4 -2
  102. package/src/rules/builtIn.ts +8 -0
  103. package/src/rules/effect/boundary.ts +75 -0
  104. package/src/rules/effect/layerConstructor.ts +40 -0
  105. package/src/rules/effect/ownsParameters.ts +46 -0
  106. package/src/rules/effect/program.ts +26 -0
  107. package/src/rules/effect/publicFunctions.ts +70 -0
  108. package/src/rules/effect/serviceCatalog.ts +57 -0
  109. package/src/rules/effect/serviceFindings.ts +96 -0
  110. package/src/rules/effect/serviceOrigin.ts +94 -0
  111. package/src/rules/effect/serviceParameters.ts +35 -0
  112. package/src/rules/effect/serviceTypes.ts +101 -0
  113. package/src/rules/imports/manifest.ts +42 -14
  114. package/src/rules/imports/runtime.ts +10 -4
  115. package/src/rules/manifestsApplication.ts +117 -0
  116. package/src/rules/manifestsExportsShape.ts +6 -2
  117. package/src/rules/react/jsxConditionals.ts +59 -0
  118. package/src/rules/stories/engineOf.ts +3 -2
  119. package/src/rules/stories/namedValues.ts +4 -4
  120. package/tsconfig/package.json +2 -0
@@ -0,0 +1,2 @@
1
+ export declare const manifestsApplication: import("#rule.ts").Rule<"manifests/application", undefined>;
2
+ //# sourceMappingURL=manifestsApplication.d.ts.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"manifestsApplication.d.ts","sourceRoot":"","sources":["../../src/rules/manifestsApplication.ts"],"names":[],"mappings":"AA8FA,eAAO,MAAM,oBAAoB,6DAsB/B,CAAC"}
@@ -0,0 +1,99 @@
1
+ import { dirname, posix, relative, resolve, sep } from "node:path";
2
+ import { pnpmWorkspaceList } from "#imports/pnpmWorkspacePatterns.ts";
3
+ import { workspacePackages } from "#imports/workspace.ts";
4
+ import { DEPENDENCY_FIELDS, dependencyNames, entryPointsOf, isApplication, PLATFORM } from "#manifests/entryPoints.ts";
5
+ import { defineRule } from "#rule.ts";
6
+ const HOISTED = "@shivaedev/*";
7
+ const HOIST_KEY = "publicHoistPattern";
8
+ const HOIST_LINE = `${HOIST_KEY}: ["${HOISTED}"]`;
9
+ const PROBE = "@shivaedev/probe";
10
+ function hoists(pattern) {
11
+ const source = pattern.replaceAll(/[.+?^${}()|[\]\\]/gu, "\\$&").replaceAll("*", ".*");
12
+ return new RegExp(`^${source}$`, "u").test(PROBE);
13
+ }
14
+ function parsed(text) {
15
+ if (text === undefined) {
16
+ return undefined;
17
+ }
18
+ try {
19
+ return JSON.parse(text);
20
+ }
21
+ catch {
22
+ return undefined;
23
+ }
24
+ }
25
+ function ancestors(root, directory) {
26
+ const start = resolve(root, directory);
27
+ const parent = dirname(start);
28
+ return parent === start ? [start] : [start, ...ancestors(root, relative(root, parent))];
29
+ }
30
+ async function nearestWorkspace(inputs, directory) {
31
+ for (const candidate of ancestors(inputs.root, directory)) {
32
+ const path = posix.join(relative(inputs.root, candidate).split(sep).join("/") || ".", "pnpm-workspace.yaml");
33
+ const text = await inputs.readText(path);
34
+ if (text !== undefined) {
35
+ return { path, text };
36
+ }
37
+ }
38
+ return undefined;
39
+ }
40
+ async function hoistFindings(inputs, manifestPath, directory) {
41
+ const workspace = await nearestWorkspace(inputs, directory);
42
+ const target = workspace?.path ?? posix.join(directory, "pnpm-workspace.yaml");
43
+ const repair = `Add \`${HOIST_LINE}\` to ${target} so the pieces platform brings resolve by their own names.`;
44
+ if (workspace === undefined) {
45
+ return [{ file: manifestPath, message: `Depends on "${PLATFORM}" without a pnpm-workspace.yaml. ${repair}`, subject: HOIST_KEY }];
46
+ }
47
+ let patterns;
48
+ try {
49
+ patterns = pnpmWorkspaceList(workspace.text, HOIST_KEY);
50
+ }
51
+ catch (cause) {
52
+ return [{ file: workspace.path, message: `${cause instanceof Error ? cause.message : String(cause)}. Write ${HOIST_LINE}.`, subject: HOIST_KEY }];
53
+ }
54
+ const included = patterns.some((pattern) => !pattern.startsWith("!") && hoists(pattern));
55
+ const excluded = patterns.some((pattern) => pattern.startsWith("!") && hoists(pattern.slice(1)));
56
+ if (included && !excluded) {
57
+ return [];
58
+ }
59
+ return [
60
+ { file: manifestPath, message: `Depends on "${PLATFORM}", but ${workspace.path} does not hoist ${HOISTED}. ${repair}`, subject: HOIST_KEY },
61
+ ];
62
+ }
63
+ async function duplicateFindings(inputs, manifestPath, directory, manifest, workspace) {
64
+ const entryPoints = (await entryPointsOf(inputs, directory, manifest, workspace)).filter((entry) => entry.declared !== undefined);
65
+ return DEPENDENCY_FIELDS.flatMap((field) => dependencyNames(manifest, field).flatMap((name) => {
66
+ const entry = entryPoints.find((candidate) => candidate.provides.has(name));
67
+ return entry === undefined
68
+ ? []
69
+ : [
70
+ {
71
+ file: manifestPath,
72
+ message: `Lists "${name}" in ${field} beside "${entry.name}", which already brings it. Remove "${name}" from ${field} and keep importing it by its own name.`,
73
+ subject: name,
74
+ },
75
+ ];
76
+ }));
77
+ }
78
+ export const manifestsApplication = defineRule({
79
+ check: async (inputs) => {
80
+ const packages = await workspacePackages(inputs);
81
+ const workspace = new Map(packages.map((owner) => [owner.name, owner.directory]));
82
+ const directories = [".", ...packages.map((owner) => owner.directory)];
83
+ const findings = await Promise.all(directories.map(async (directory) => {
84
+ const manifestPath = posix.join(directory, "package.json");
85
+ const manifest = parsed(await inputs.readText(manifestPath));
86
+ if (!isApplication(manifest)) {
87
+ return [];
88
+ }
89
+ return [
90
+ ...(await hoistFindings(inputs, manifestPath, directory)),
91
+ ...(await duplicateFindings(inputs, manifestPath, directory, manifest, workspace)),
92
+ ];
93
+ }));
94
+ return findings.flat();
95
+ },
96
+ description: `An application, a package that depends on ${PLATFORM}, hoists ${HOISTED} in its nearest pnpm-workspace.yaml and lists no package beside the entry point that already brings it.`,
97
+ id: "manifests/application",
98
+ });
99
+ //# sourceMappingURL=manifestsApplication.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"manifestsApplication.js","sourceRoot":"","sources":["../../src/rules/manifestsApplication.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,GAAG,EAAE,MAAM,WAAW,CAAC;AACnE,OAAO,EAAE,iBAAiB,EAAE,MAAM,mCAAmC,CAAC;AACtE,OAAO,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAC1D,OAAO,EAAE,iBAAiB,EAAE,eAAe,EAAE,aAAa,EAAE,aAAa,EAAE,QAAQ,EAAE,MAAM,2BAA2B,CAAC;AACvH,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AAErE,MAAM,OAAO,GAAG,cAAc,CAAC;AAE/B,MAAM,SAAS,GAAG,oBAAoB,CAAC;AAEvC,MAAM,UAAU,GAAG,GAAG,SAAS,OAAO,OAAO,IAAI,CAAC;AAElD,MAAM,KAAK,GAAG,kBAAkB,CAAC;AAEjC,SAAS,MAAM,CAAC,OAAe;IAC9B,MAAM,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,qBAAqB,EAAE,MAAM,CAAC,CAAC,UAAU,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC;IACvF,OAAO,IAAI,MAAM,CAAC,IAAI,MAAM,GAAG,EAAE,GAAG,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;AACnD,CAAC;AAED,SAAS,MAAM,CAAC,IAAwB;IACvC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,IAAI,CAAC;QACJ,OAAO,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACzB,CAAC;IAAC,MAAM,CAAC;QACR,OAAO,SAAS,CAAC;IAClB,CAAC;AACF,CAAC;AAED,SAAS,SAAS,CAAC,IAAY,EAAE,SAAiB;IACjD,MAAM,KAAK,GAAG,OAAO,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC;IACvC,MAAM,MAAM,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC;IAC9B,OAAO,MAAM,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,EAAE,GAAG,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC;AACzF,CAAC;AAED,KAAK,UAAU,gBAAgB,CAAC,MAA6C,EAAE,SAAiB;IAC/F,KAAK,MAAM,SAAS,IAAI,SAAS,CAAC,MAAM,CAAC,IAAI,EAAE,SAAS,CAAC,EAAE,CAAC;QAC3D,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,GAAG,EAAE,qBAAqB,CAAC,CAAC;QAC7G,MAAM,IAAI,GAAG,MAAM,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;QACzC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;YACxB,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QACvB,CAAC;IACF,CAAC;IACD,OAAO,SAAS,CAAC;AAClB,CAAC;AAED,KAAK,UAAU,aAAa,CAAC,MAA6C,EAAE,YAAoB,EAAE,SAAiB;IAClH,MAAM,SAAS,GAAG,MAAM,gBAAgB,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC;IAC5D,MAAM,MAAM,GAAG,SAAS,EAAE,IAAI,IAAI,KAAK,CAAC,IAAI,CAAC,SAAS,EAAE,qBAAqB,CAAC,CAAC;IAC/E,MAAM,MAAM,GAAG,SAAS,UAAU,SAAS,MAAM,4DAA4D,CAAC;IAC9G,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;QAC7B,OAAO,CAAC,EAAE,IAAI,EAAE,YAAY,EAAE,OAAO,EAAE,eAAe,QAAQ,oCAAoC,MAAM,EAAE,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,CAAC;IACnI,CAAC;IACD,IAAI,QAA2B,CAAC;IAChC,IAAI,CAAC;QACJ,QAAQ,GAAG,iBAAiB,CAAC,SAAS,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC;IACzD,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QAChB,OAAO,CAAC,EAAE,IAAI,EAAE,SAAS,CAAC,IAAI,EAAE,OAAO,EAAE,GAAG,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,WAAW,UAAU,GAAG,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,CAAC;IACnJ,CAAC;IACD,MAAM,QAAQ,GAAG,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC;IACzF,MAAM,QAAQ,GAAG,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IACjG,IAAI,QAAQ,IAAI,CAAC,QAAQ,EAAE,CAAC;QAC3B,OAAO,EAAE,CAAC;IACX,CAAC;IACD,OAAO;QACN,EAAE,IAAI,EAAE,YAAY,EAAE,OAAO,EAAE,eAAe,QAAQ,UAAU,SAAS,CAAC,IAAI,mBAAmB,OAAO,KAAK,MAAM,EAAE,EAAE,OAAO,EAAE,SAAS,EAAE;KAC3I,CAAC;AACH,CAAC;AAED,KAAK,UAAU,iBAAiB,CAC/B,MAAoC,EACpC,YAAoB,EACpB,SAAiB,EACjB,QAAiB,EACjB,SAAsC;IAEtC,MAAM,WAAW,GAAG,CAAC,MAAM,aAAa,CAAC,MAAM,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;IAClI,OAAO,iBAAiB,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE,CAC1C,eAAe,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACjD,MAAM,KAAK,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;QAC5E,OAAO,KAAK,KAAK,SAAS;YACzB,CAAC,CAAC,EAAE;YACJ,CAAC,CAAC;gBACA;oBACC,IAAI,EAAE,YAAY;oBAClB,OAAO,EAAE,UAAU,IAAI,QAAQ,KAAK,YAAY,KAAK,CAAC,IAAI,uCAAuC,IAAI,UAAU,KAAK,yCAAyC;oBAC7J,OAAO,EAAE,IAAI;iBACb;aACD,CAAC;IACL,CAAC,CAAC,CACF,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,oBAAoB,GAAG,UAAU,CAAC;IAC9C,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,EAAE;QACvB,MAAM,QAAQ,GAAG,MAAM,iBAAiB,CAAC,MAAM,CAAC,CAAC;QACjD,MAAM,SAAS,GAAG,IAAI,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QAClF,MAAM,WAAW,GAAG,CAAC,GAAG,EAAE,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC;QACvE,MAAM,QAAQ,GAAG,MAAM,OAAO,CAAC,GAAG,CACjC,WAAW,CAAC,GAAG,CAAC,KAAK,EAAE,SAAS,EAAE,EAAE;YACnC,MAAM,YAAY,GAAG,KAAK,CAAC,IAAI,CAAC,SAAS,EAAE,cAAc,CAAC,CAAC;YAC3D,MAAM,QAAQ,GAAG,MAAM,CAAC,MAAM,MAAM,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC,CAAC;YAC7D,IAAI,CAAC,aAAa,CAAC,QAAQ,CAAC,EAAE,CAAC;gBAC9B,OAAO,EAAE,CAAC;YACX,CAAC;YACD,OAAO;gBACN,GAAG,CAAC,MAAM,aAAa,CAAC,MAAM,EAAE,YAAY,EAAE,SAAS,CAAC,CAAC;gBACzD,GAAG,CAAC,MAAM,iBAAiB,CAAC,MAAM,EAAE,YAAY,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS,CAAC,CAAC;aAClF,CAAC;QACH,CAAC,CAAC,CACF,CAAC;QACF,OAAO,QAAQ,CAAC,IAAI,EAAE,CAAC;IACxB,CAAC;IACD,WAAW,EAAE,6CAA6C,QAAQ,YAAY,OAAO,yGAAyG;IAC9L,EAAE,EAAE,uBAAuB;CAC3B,CAAC,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"manifestsExportsShape.d.ts","sourceRoot":"","sources":["../../src/rules/manifestsExportsShape.ts"],"names":[],"mappings":"AA2DA,eAAO,MAAM,qBAAqB,+DAmBhC,CAAC"}
1
+ {"version":3,"file":"manifestsExportsShape.d.ts","sourceRoot":"","sources":["../../src/rules/manifestsExportsShape.ts"],"names":[],"mappings":"AA8DA,eAAO,MAAM,qBAAqB,+DAoBhC,CAAC"}
@@ -36,7 +36,10 @@ function findingsIn(file, exports) {
36
36
  }
37
37
  const entries = Object.entries(exports);
38
38
  const patterns = entries.filter(([key, value]) => key.includes("*") && value !== null);
39
- const count = patterns.length === 1 ? [] : [finding(file, "exports", `The exports field needs exactly one non-null wildcard; found ${patterns.length}.`)];
39
+ const exportsModules = entries.some(([key, value]) => value !== null && !exactAsset(key, value));
40
+ const count = patterns.length === 1 || (patterns.length === 0 && !exportsModules)
41
+ ? []
42
+ : [finding(file, "exports", `The exports field needs exactly one non-null wildcard; found ${patterns.length}.`)];
40
43
  return [
41
44
  ...count,
42
45
  ...entries.flatMap(([key, value]) => value === null || key === "." || exactAsset(key, value) || standardPattern(key, value)
@@ -58,7 +61,7 @@ export const manifestsExportsShape = defineRule({
58
61
  }));
59
62
  return findings.flat();
60
63
  },
61
- description: "Workspace packages export modules through one file-preserving wildcard, with optional root, exact non-code assets and null blocks.",
64
+ description: "Workspace packages export modules through one file-preserving wildcard, with optional root, exact non-code assets and null blocks; a package without modules exports only exact assets.",
62
65
  id: "manifests/exports-shape",
63
66
  registrable: false,
64
67
  });
@@ -1 +1 @@
1
- {"version":3,"file":"manifestsExportsShape.js","sourceRoot":"","sources":["../../src/rules/manifestsExportsShape.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAgB,MAAM,UAAU,CAAC;AAEpD,MAAM,OAAO,GAAG,QAAQ,CAAC;AAEzB,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC,CAAC,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,CAAC,CAAC;AAEhG,SAAS,KAAK,CAAC,KAAc;IAC5B,OAAO,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;AAC7E,CAAC;AAED,SAAS,eAAe,CAAC,GAAW,EAAE,KAAc;IACnD,IAAI,CAAC,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,GAAG,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,IAAI,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;QACpG,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACvC,MAAM,IAAI,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC;IAC7C,MAAM,UAAU,GAAG,EAAE,OAAO,EAAE,UAAU,IAAI,KAAK,EAAE,MAAM,EAAE,SAAS,OAAO,EAAE,EAAE,KAAK,EAAE,UAAU,IAAI,OAAO,EAAE,CAAC;IAC9G,OAAO,CACN,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,MAAM;WACzD,MAAM,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,EAAE,MAAM,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,CAAC,KAAK,MAAM,CAAC,CACzF,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,GAAW,EAAE,KAAc;IAC9C,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;IACrC,OAAO,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,KAAK,GAAG,IAAI,SAAS,KAAK,EAAE,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;AAC3H,CAAC;AAED,SAAS,OAAO,CAAC,IAAY,EAAE,OAAe,EAAE,MAAc;IAC7D,OAAO;QACN,IAAI;QACJ,OAAO,EAAE,GAAG,MAAM,2DAA2D,OAAO,iRAAiR;QACrW,OAAO;KACP,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,IAAY,EAAE,OAAgB;IACjD,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;QAC3B,OAAO,EAAE,CAAC;IACX,CAAC;IACD,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC;QACrB,OAAO,CAAC,OAAO,CAAC,IAAI,EAAE,SAAS,EAAE,0CAA0C,CAAC,CAAC,CAAC;IAC/E,CAAC;IACD,MAAM,OAAO,GAAG,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;IACxC,MAAM,QAAQ,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,GAAG,EAAE,KAAK,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,KAAK,IAAI,CAAC,CAAC;IACvF,MAAM,KAAK,GACV,QAAQ,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,EAAE,SAAS,EAAE,gEAAgE,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAC7I,OAAO;QACN,GAAG,KAAK;QACR,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,GAAG,EAAE,KAAK,CAAC,EAAE,EAAE,CACnC,KAAK,KAAK,IAAI,IAAI,GAAG,KAAK,GAAG,IAAI,UAAU,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,eAAe,CAAC,GAAG,EAAE,KAAK,CAAC;YACrF,CAAC,CAAC,EAAE;YACJ,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,EAAE,WAAW,GAAG,6CAA6C,CAAC,CAAC,CACpF;KACD,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,qBAAqB,GAAG,UAAU,CAAC;IAC/C,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,EAAE;QACvB,MAAM,QAAQ,GAAG,MAAM,iBAAiB,CAAC,MAAM,CAAC,CAAC;QACjD,MAAM,KAAK,GAAG,CAAC,cAAc,EAAE,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,EAAE,cAAc,CAAC,CAAC,CAAC,CAAC;QACxG,MAAM,QAAQ,GAAG,MAAM,OAAO,CAAC,GAAG,CACjC,KAAK,CAAC,GAAG,CAAC,KAAK,EAAE,IAAI,EAAE,EAAE;YACxB,MAAM,IAAI,GAAG,MAAM,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;YACzC,IAAI,IAAI,KAAK,cAAc,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;gBACnD,OAAO,EAAE,CAAC;YACX,CAAC;YACD,MAAM,QAAQ,GAAY,IAAI,CAAC,KAAK,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC;YACjD,OAAO,UAAU,CAAC,IAAI,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;QACzE,CAAC,CAAC,CACF,CAAC;QACF,OAAO,QAAQ,CAAC,IAAI,EAAE,CAAC;IACxB,CAAC;IACD,WAAW,EAAE,oIAAoI;IACjJ,EAAE,EAAE,yBAAyB;IAC7B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
1
+ {"version":3,"file":"manifestsExportsShape.js","sourceRoot":"","sources":["../../src/rules/manifestsExportsShape.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAgB,MAAM,UAAU,CAAC;AAEpD,MAAM,OAAO,GAAG,QAAQ,CAAC;AAEzB,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC,CAAC,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,CAAC,CAAC;AAEhG,SAAS,KAAK,CAAC,KAAc;IAC5B,OAAO,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;AAC7E,CAAC;AAED,SAAS,eAAe,CAAC,GAAW,EAAE,KAAc;IACnD,IAAI,CAAC,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,GAAG,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,IAAI,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;QACpG,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACvC,MAAM,IAAI,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC;IAC7C,MAAM,UAAU,GAAG,EAAE,OAAO,EAAE,UAAU,IAAI,KAAK,EAAE,MAAM,EAAE,SAAS,OAAO,EAAE,EAAE,KAAK,EAAE,UAAU,IAAI,OAAO,EAAE,CAAC;IAC9G,OAAO,CACN,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,MAAM;WACzD,MAAM,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,EAAE,MAAM,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,CAAC,KAAK,MAAM,CAAC,CACzF,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,GAAW,EAAE,KAAc;IAC9C,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;IACrC,OAAO,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,KAAK,GAAG,IAAI,SAAS,KAAK,EAAE,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;AAC3H,CAAC;AAED,SAAS,OAAO,CAAC,IAAY,EAAE,OAAe,EAAE,MAAc;IAC7D,OAAO;QACN,IAAI;QACJ,OAAO,EAAE,GAAG,MAAM,2DAA2D,OAAO,iRAAiR;QACrW,OAAO;KACP,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,IAAY,EAAE,OAAgB;IACjD,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;QAC3B,OAAO,EAAE,CAAC;IACX,CAAC;IACD,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC;QACrB,OAAO,CAAC,OAAO,CAAC,IAAI,EAAE,SAAS,EAAE,0CAA0C,CAAC,CAAC,CAAC;IAC/E,CAAC;IACD,MAAM,OAAO,GAAG,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;IACxC,MAAM,QAAQ,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,GAAG,EAAE,KAAK,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,KAAK,IAAI,CAAC,CAAC;IACvF,MAAM,cAAc,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,EAAE,KAAK,CAAC,EAAE,EAAE,CAAC,KAAK,KAAK,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,EAAE,KAAK,CAAC,CAAC,CAAC;IACjG,MAAM,KAAK,GACV,QAAQ,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,cAAc,CAAC;QAClE,CAAC,CAAC,EAAE;QACJ,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,EAAE,SAAS,EAAE,gEAAgE,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IACnH,OAAO;QACN,GAAG,KAAK;QACR,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,GAAG,EAAE,KAAK,CAAC,EAAE,EAAE,CACnC,KAAK,KAAK,IAAI,IAAI,GAAG,KAAK,GAAG,IAAI,UAAU,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,eAAe,CAAC,GAAG,EAAE,KAAK,CAAC;YACrF,CAAC,CAAC,EAAE;YACJ,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,EAAE,WAAW,GAAG,6CAA6C,CAAC,CAAC,CACpF;KACD,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,qBAAqB,GAAG,UAAU,CAAC;IAC/C,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,EAAE;QACvB,MAAM,QAAQ,GAAG,MAAM,iBAAiB,CAAC,MAAM,CAAC,CAAC;QACjD,MAAM,KAAK,GAAG,CAAC,cAAc,EAAE,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,EAAE,cAAc,CAAC,CAAC,CAAC,CAAC;QACxG,MAAM,QAAQ,GAAG,MAAM,OAAO,CAAC,GAAG,CACjC,KAAK,CAAC,GAAG,CAAC,KAAK,EAAE,IAAI,EAAE,EAAE;YACxB,MAAM,IAAI,GAAG,MAAM,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;YACzC,IAAI,IAAI,KAAK,cAAc,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;gBACnD,OAAO,EAAE,CAAC;YACX,CAAC;YACD,MAAM,QAAQ,GAAY,IAAI,CAAC,KAAK,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC;YACjD,OAAO,UAAU,CAAC,IAAI,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;QACzE,CAAC,CAAC,CACF,CAAC;QACF,OAAO,QAAQ,CAAC,IAAI,EAAE,CAAC;IACxB,CAAC;IACD,WAAW,EACV,yLAAyL;IAC1L,EAAE,EAAE,yBAAyB;IAC7B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
@@ -0,0 +1,2 @@
1
+ export declare const jsxConditionals: import("#rule.ts").Rule<"react/jsx-conditionals", undefined>;
2
+ //# sourceMappingURL=jsxConditionals.d.ts.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"jsxConditionals.d.ts","sourceRoot":"","sources":["../../../src/rules/react/jsxConditionals.ts"],"names":[],"mappings":"AAgCA,eAAO,MAAM,eAAe,8DA0B1B,CAAC"}
@@ -0,0 +1,54 @@
1
+ import ts from "typescript";
2
+ import { defineRule } from "#rule.ts";
3
+ import { parse } from "#rules/parse.ts";
4
+ const REPAIR = "Decide before the JSX with an if and early return, or a variable computed above the return; or extract a component that receives the data and returns null when it has nothing to show.";
5
+ function mapCall(node) {
6
+ return ts.isCallExpression(node) && ts.isPropertyAccessExpression(node.expression) && node.expression.name.text === "map";
7
+ }
8
+ function childContext(node) {
9
+ let mapped = false;
10
+ let child = false;
11
+ for (let parent = node.parent; parent !== undefined; parent = parent.parent) {
12
+ if (!child && ts.isJsxSpreadAttribute(parent)) {
13
+ return undefined;
14
+ }
15
+ if (ts.isJsxExpression(parent)) {
16
+ if (!(child || ts.isJsxElement(parent.parent) || ts.isJsxFragment(parent.parent))) {
17
+ return undefined;
18
+ }
19
+ child = true;
20
+ }
21
+ if (ts.isVariableDeclaration(parent) || (ts.isStatement(parent) && !ts.isReturnStatement(parent) && !ts.isBlock(parent))) {
22
+ break;
23
+ }
24
+ mapped ||= mapCall(parent);
25
+ }
26
+ return child ? { mapped } : undefined;
27
+ }
28
+ export const jsxConditionals = defineRule({
29
+ check: ({ sources }) => sources.flatMap((file) => {
30
+ const source = parse(file);
31
+ const findings = [];
32
+ function visit(node) {
33
+ if (ts.isConditionalExpression(node) || (ts.isBinaryExpression(node) && node.operatorToken.kind === ts.SyntaxKind.AmpersandAmpersandToken)) {
34
+ const context = childContext(node);
35
+ if (context !== undefined && source !== undefined) {
36
+ findings.push({
37
+ file: file.path,
38
+ line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1,
39
+ message: `Conditional rendering inside a JSX child. ${REPAIR}${context.mapped ? " Inside .map, extract the item into its own component that makes its own decision." : ""}`,
40
+ });
41
+ }
42
+ }
43
+ ts.forEachChild(node, visit);
44
+ }
45
+ if (source !== undefined) {
46
+ visit(source);
47
+ }
48
+ return findings;
49
+ }),
50
+ description: `Components decide what to render outside their JSX. ${REPAIR} Inside .map, extract an item component that makes its own decision. Attribute values are accepted.`,
51
+ id: "react/jsx-conditionals",
52
+ registrable: false,
53
+ });
54
+ //# sourceMappingURL=jsxConditionals.js.map
@@ -0,0 +1 @@
1
+ {"version":3,"file":"jsxConditionals.js","sourceRoot":"","sources":["../../../src/rules/react/jsxConditionals.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAgB,MAAM,UAAU,CAAC;AACpD,OAAO,EAAE,KAAK,EAAE,MAAM,iBAAiB,CAAC;AAExC,MAAM,MAAM,GACX,yLAAyL,CAAC;AAE3L,SAAS,OAAO,CAAC,IAAa;IAC7B,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,KAAK,CAAC;AAC3H,CAAC;AAED,SAAS,YAAY,CAAC,IAAa;IAClC,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,IAAI,KAAK,GAAG,KAAK,CAAC;IAClB,KAAK,IAAI,MAAM,GAAG,IAAI,CAAC,MAAM,EAAE,MAAM,KAAK,SAAS,EAAE,MAAM,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC;QAC7E,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC,oBAAoB,CAAC,MAAM,CAAC,EAAE,CAAC;YAC/C,OAAO,SAAS,CAAC;QAClB,CAAC;QACD,IAAI,EAAE,CAAC,eAAe,CAAC,MAAM,CAAC,EAAE,CAAC;YAChC,IAAI,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,aAAa,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC;gBACnF,OAAO,SAAS,CAAC;YAClB,CAAC;YACD,KAAK,GAAG,IAAI,CAAC;QACd,CAAC;QACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,iBAAiB,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC;YAC1H,MAAM;QACP,CAAC;QACD,MAAM,KAAK,OAAO,CAAC,MAAM,CAAC,CAAC;IAC5B,CAAC;IACD,OAAO,KAAK,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;AACvC,CAAC;AAED,MAAM,CAAC,MAAM,eAAe,GAAG,UAAU,CAAC;IACzC,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,EAAE,CACtB,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACxB,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC;QAC3B,MAAM,QAAQ,GAAc,EAAE,CAAC;QAC/B,SAAS,KAAK,CAAC,IAAa;YAC3B,IAAI,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,uBAAuB,CAAC,EAAE,CAAC;gBAC5I,MAAM,OAAO,GAAG,YAAY,CAAC,IAAI,CAAC,CAAC;gBACnC,IAAI,OAAO,KAAK,SAAS,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;oBACnD,QAAQ,CAAC,IAAI,CAAC;wBACb,IAAI,EAAE,IAAI,CAAC,IAAI;wBACf,IAAI,EAAE,MAAM,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC;wBAC1E,OAAO,EAAE,6CAA6C,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,oFAAoF,CAAC,CAAC,CAAC,EAAE,EAAE;qBAC3K,CAAC,CAAC;gBACJ,CAAC;YACF,CAAC;YACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QAC9B,CAAC;QACD,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,KAAK,CAAC,MAAM,CAAC,CAAC;QACf,CAAC;QACD,OAAO,QAAQ,CAAC;IACjB,CAAC,CAAC;IACH,WAAW,EAAE,uDAAuD,MAAM,qGAAqG;IAC/K,EAAE,EAAE,wBAAwB;IAC5B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
@@ -1 +1 @@
1
- {"version":3,"file":"engineOf.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AA2DpD,wBAAgB,QAAQ,CAAC,QAAQ,EAAE,QAAQ,GAAG,MAAM,GAAG,SAAS,CAK/D"}
1
+ {"version":3,"file":"engineOf.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AA2DpD,wBAAgB,QAAQ,CAAC,QAAQ,EAAE,QAAQ,GAAG,MAAM,GAAG,SAAS,CAM/D"}
@@ -48,13 +48,14 @@ const ENGINES = [
48
48
  ],
49
49
  ],
50
50
  ["the DOM", ["@happy-dom/", "@playwright/test", "@testing-library/", "happy-dom", "jsdom", "playwright", "react-dom"]],
51
- ["a story engine", ["@shivaedev/effect-test-sql", "@shivaedev/local-postgres", "@shivaedev/test-story"]],
51
+ ["a story engine", ["@shivaedev/test-sql", "@shivaedev/local-postgres", "@shivaedev/test-story"]],
52
52
  ];
53
53
  function names(prefix, specifier) {
54
54
  return prefix.endsWith("/") ? specifier.startsWith(prefix) : specifier === prefix || specifier.startsWith(`${prefix}/`);
55
55
  }
56
56
  export function engineOf(endpoint) {
57
- if (endpoint.kind === "file") {
57
+ // HttpStatus only maps names to numbers; importing it acquires no network services.
58
+ if (endpoint.kind === "file" || endpoint.specifier === "effect/http/HttpStatus") {
58
59
  return undefined;
59
60
  }
60
61
  return ENGINES.find(([, prefixes]) => prefixes.some((prefix) => names(prefix, endpoint.specifier) || names(prefix, endpoint.package)))?.[0];
@@ -1 +1 @@
1
- {"version":3,"file":"engineOf.js","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAEA,MAAM,OAAO,GAAwD;IACpE,CAAC,iBAAiB,EAAE,CAAC,SAAS,CAAC,CAAC;IAChC;QACC,aAAa;QACb;YACC,YAAY;YACZ,UAAU;YACV,WAAW;YACX,YAAY;YACZ,YAAY;YACZ,UAAU;YACV,UAAU;YACV,aAAa;YACb,eAAe;YACf,0BAA0B;YAC1B,sBAAsB;YACtB,uBAAuB;YACvB,8BAA8B;YAC9B,cAAc;YACd,cAAc;YACd,SAAS;YACT,SAAS;YACT,MAAM;YACN,QAAQ;YACR,IAAI;SACJ;KACD;IACD,CAAC,WAAW,EAAE,CAAC,oBAAoB,EAAE,cAAc,EAAE,cAAc,EAAE,eAAe,EAAE,gBAAgB,EAAE,aAAa,CAAC,CAAC;IACvH,CAAC,UAAU,EAAE,CAAC,qBAAqB,EAAE,gBAAgB,CAAC,CAAC;IACvD;QACC,YAAY;QACZ;YACC,aAAa;YACb,oBAAoB;YACpB,YAAY;YACZ,aAAa;YACb,gBAAgB;YAChB,yBAAyB;YACzB,sBAAsB;YACtB,gBAAgB;YAChB,eAAe;YACf,aAAa;YACb,gBAAgB;YAChB,QAAQ;YACR,IAAI;YACJ,SAAS;YACT,UAAU;SACV;KACD;IACD,CAAC,SAAS,EAAE,CAAC,aAAa,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,WAAW,EAAE,OAAO,EAAE,YAAY,EAAE,WAAW,CAAC,CAAC;IACtH,CAAC,gBAAgB,EAAE,CAAC,4BAA4B,EAAE,2BAA2B,EAAE,uBAAuB,CAAC,CAAC;CACxG,CAAC;AAEF,SAAS,KAAK,CAAC,MAAc,EAAE,SAAiB;IAC/C,OAAO,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,KAAK,MAAM,IAAI,SAAS,CAAC,UAAU,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC;AACzH,CAAC;AAED,MAAM,UAAU,QAAQ,CAAC,QAAkB;IAC1C,IAAI,QAAQ,CAAC,IAAI,KAAK,MAAM,EAAE,CAAC;QAC9B,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,OAAO,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,QAAQ,CAAC,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,SAAS,CAAC,IAAI,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;AAC7I,CAAC"}
1
+ {"version":3,"file":"engineOf.js","sourceRoot":"","sources":["../../../src/rules/stories/engineOf.ts"],"names":[],"mappings":"AAEA,MAAM,OAAO,GAAwD;IACpE,CAAC,iBAAiB,EAAE,CAAC,SAAS,CAAC,CAAC;IAChC;QACC,aAAa;QACb;YACC,YAAY;YACZ,UAAU;YACV,WAAW;YACX,YAAY;YACZ,YAAY;YACZ,UAAU;YACV,UAAU;YACV,aAAa;YACb,eAAe;YACf,0BAA0B;YAC1B,sBAAsB;YACtB,uBAAuB;YACvB,8BAA8B;YAC9B,cAAc;YACd,cAAc;YACd,SAAS;YACT,SAAS;YACT,MAAM;YACN,QAAQ;YACR,IAAI;SACJ;KACD;IACD,CAAC,WAAW,EAAE,CAAC,oBAAoB,EAAE,cAAc,EAAE,cAAc,EAAE,eAAe,EAAE,gBAAgB,EAAE,aAAa,CAAC,CAAC;IACvH,CAAC,UAAU,EAAE,CAAC,qBAAqB,EAAE,gBAAgB,CAAC,CAAC;IACvD;QACC,YAAY;QACZ;YACC,aAAa;YACb,oBAAoB;YACpB,YAAY;YACZ,aAAa;YACb,gBAAgB;YAChB,yBAAyB;YACzB,sBAAsB;YACtB,gBAAgB;YAChB,eAAe;YACf,aAAa;YACb,gBAAgB;YAChB,QAAQ;YACR,IAAI;YACJ,SAAS;YACT,UAAU;SACV;KACD;IACD,CAAC,SAAS,EAAE,CAAC,aAAa,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,WAAW,EAAE,OAAO,EAAE,YAAY,EAAE,WAAW,CAAC,CAAC;IACtH,CAAC,gBAAgB,EAAE,CAAC,qBAAqB,EAAE,2BAA2B,EAAE,uBAAuB,CAAC,CAAC;CACjG,CAAC;AAEF,SAAS,KAAK,CAAC,MAAc,EAAE,SAAiB;IAC/C,OAAO,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,KAAK,MAAM,IAAI,SAAS,CAAC,UAAU,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC;AACzH,CAAC;AAED,MAAM,UAAU,QAAQ,CAAC,QAAkB;IAC1C,oFAAoF;IACpF,IAAI,QAAQ,CAAC,IAAI,KAAK,MAAM,IAAI,QAAQ,CAAC,SAAS,KAAK,wBAAwB,EAAE,CAAC;QACjF,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,OAAO,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,QAAQ,CAAC,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,SAAS,CAAC,IAAI,KAAK,CAAC,MAAM,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;AAC7I,CAAC"}
@@ -1,7 +1,7 @@
1
1
  import ts from "typescript";
2
2
  import { defineRule } from "#rule.ts";
3
3
  import { isSpec, memberName, nodesWhere, numericValue, syntaxFindings, unwrapped } from "./syntax.js";
4
- const MESSAGE = "Passes a numeric literal or a matcher-only spec-local numeric const to toBe or toHaveLength. Assert the observed items, write the literal where accepted (zero, or a status or exit code), or derive the value from the story's inputs.";
4
+ const MESSAGE = 'Passes a numeric literal or a matcher-only spec-local numeric const to toBe or toHaveLength. Assert the observed items, write the literal where accepted (zero or a process exitCode), or derive the value from the story\'s inputs. For HTTP statuses, import * as HttpStatus from "effect/http/HttpStatus" and use HttpStatus.fromLiteral("NotFound"), for example.';
5
5
  function matcherCall(node) {
6
6
  return ts.isCallExpression(node) && ["toBe", "toHaveLength"].includes(memberName(node.expression) ?? "");
7
7
  }
@@ -41,7 +41,7 @@ function matcherAliases(source) {
41
41
  .filter((references) => references.every((reference) => matcherCall(reference.parent) && reference.parent.arguments.includes(reference)))
42
42
  .flatMap((references) => references.map((reference) => reference.parent)));
43
43
  }
44
- function codeSubject(expression) {
44
+ function exitCodeSubject(expression) {
45
45
  const value = unwrapped(expression);
46
46
  if (!(ts.isPropertyAccessExpression(value) || ts.isElementAccessExpression(value))) {
47
47
  return false;
@@ -61,11 +61,11 @@ function codeSubject(expression) {
61
61
  return false;
62
62
  }
63
63
  const subject = unwrapped(argument);
64
- return ["status", "code", "exitCode"].includes(ts.isIdentifier(subject) ? subject.text : (memberName(subject) ?? ""));
64
+ return (ts.isIdentifier(subject) ? subject.text : memberName(subject)) === "exitCode";
65
65
  }
66
66
  function numericAssertion(node) {
67
67
  return (matcherCall(node)
68
- && !codeSubject(node.expression)
68
+ && !exitCodeSubject(node.expression)
69
69
  && node.arguments.some((argument) => {
70
70
  const value = numericValue(argument);
71
71
  return value !== undefined && value !== 0;
@@ -1 +1 @@
1
- {"version":3,"file":"namedValues.js","sourceRoot":"","sources":["../../../src/rules/stories/namedValues.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,UAAU,EAAE,YAAY,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEtG,MAAM,OAAO,GACZ,yOAAyO,CAAC;AAE3O,SAAS,WAAW,CAAC,IAAa;IACjC,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,cAAc,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC;AAC1G,CAAC;AAED,SAAS,cAAc,CAAC,MAAqB;IAC5C,MAAM,YAAY,GAAG,UAAU,CAC9B,MAAM,EACN,CAAC,IAAI,EAAE,EAAE,CACR,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;WAC3B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;WAC1B,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,MAAM,CAAC;WACzC,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC;WAC9C,IAAI,CAAC,WAAW,KAAK,SAAS;WAC9B,YAAY,CAAC,IAAI,CAAC,WAAW,CAAC,KAAK,SAAS,CAChD,CAAC,MAAM,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC;IACnC,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC/B,OAAO,IAAI,GAAG,EAAE,CAAC;IAClB,CAAC;IACD,MAAM,OAAO,GAAuB,EAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;IAC/F,MAAM,IAAI,GAAG,EAAE,CAAC,kBAAkB,CAAC,OAAO,CAAC,CAAC;IAC5C,IAAI,CAAC,aAAa,GAAG,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,IAAI,KAAK,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IAC/E,MAAM,OAAO,GAAG,EAAE,CAAC,aAAa,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,EAAE,OAAO,EAAE,IAAI,CAAC,CAAC,cAAc,EAAE,CAAC;IACpF,MAAM,OAAO,GAAG,IAAI,GAAG,EAA8B,CAAC;IACtD,KAAK,MAAM,WAAW,IAAI,YAAY,EAAE,CAAC;QACxC,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;QAC7D,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;QACzB,CAAC;IACF,CAAC;IACD,KAAK,MAAM,IAAI,IAAI,UAAU,CAAC,MAAM,EAAE,EAAE,CAAC,YAAY,CAAC,EAAE,CAAC;QACxD,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;YACpG,SAAS;QACV,CAAC;QACD,MAAM,MAAM,GAAG,EAAE,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,CAAC;YAC3D,CAAC,CAAC,OAAO,CAAC,iCAAiC,CAAC,IAAI,CAAC,MAAM,CAAC;YACxD,CAAC,CAAC,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QACrC,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,CAAC;IACF,CAAC;IACD,OAAO,IAAI,GAAG,CACb,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC;SACnB,MAAM,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,WAAW,CAAC,SAAS,CAAC,MAAM,CAAC,IAAI,SAAS,CAAC,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC;SACxI,OAAO,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAC1E,CAAC;AACH,CAAC;AAED,SAAS,WAAW,CAAC,UAAyB;IAC7C,MAAM,KAAK,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC;IACpC,IAAI,CAAC,CAAC,EAAE,CAAC,0BAA0B,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;QACpF,OAAO,KAAK,CAAC;IACd,CAAC;IACD,IAAI,IAAI,GAAG,SAAS,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;IACvC,OAAO,CAAC,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,KAAK,KAAK,EAAE,CAAC;QAClH,IAAI,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACnC,CAAC;IACD,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;QAChC,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;IAC/F,MAAM,MAAM,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,IAAI,KAAK,QAAQ,IAAI,CAAC,QAAQ,KAAK,MAAM,IAAI,UAAU,CAAC,MAAM,CAAC,KAAK,MAAM,CAAC,CAAC;IACjI,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IACnC,IAAI,CAAC,MAAM,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QACvC,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,SAAS,CAAC,QAAQ,CAAC,CAAC;IACpC,OAAO,CAAC,QAAQ,EAAE,MAAM,EAAE,UAAU,CAAC,CAAC,QAAQ,CAAC,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;AACvH,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAa;IACtC,OAAO,CACN,WAAW,CAAC,IAAI,CAAC;WACd,CAAC,WAAW,CAAC,IAAI,CAAC,UAAU,CAAC;WAC7B,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE;YACnC,MAAM,KAAK,GAAG,YAAY,CAAC,QAAQ,CAAC,CAAC;YACrC,OAAO,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,CAAC,CAAC;QAC3C,CAAC,CAAC,CACF,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,WAAW,GAAG,UAAU,CAAC;IACrC,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,EAAE,CACtB,OAAO;SACL,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;SACnC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CACjB,cAAc,CACb,IAAI,EACJ,CAAC,MAAM,EAAE,EAAE;QACV,MAAM,OAAO,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;QACvC,OAAO,UAAU,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;IAClF,CAAC,EACD,OAAO,CACP,CACD;IACH,WAAW,EAAE,mFAAmF;IAChG,EAAE,EAAE,oBAAoB;CACxB,CAAC,CAAC"}
1
+ {"version":3,"file":"namedValues.js","sourceRoot":"","sources":["../../../src/rules/stories/namedValues.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,UAAU,EAAE,YAAY,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAEtG,MAAM,OAAO,GACZ,uWAAuW,CAAC;AAEzW,SAAS,WAAW,CAAC,IAAa;IACjC,OAAO,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,cAAc,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC;AAC1G,CAAC;AAED,SAAS,cAAc,CAAC,MAAqB;IAC5C,MAAM,YAAY,GAAG,UAAU,CAC9B,MAAM,EACN,CAAC,IAAI,EAAE,EAAE,CACR,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;WAC3B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;WAC1B,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,MAAM,CAAC;WACzC,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC;WAC9C,IAAI,CAAC,WAAW,KAAK,SAAS;WAC9B,YAAY,CAAC,IAAI,CAAC,WAAW,CAAC,KAAK,SAAS,CAChD,CAAC,MAAM,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC;IACnC,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC/B,OAAO,IAAI,GAAG,EAAE,CAAC;IAClB,CAAC;IACD,MAAM,OAAO,GAAuB,EAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;IAC/F,MAAM,IAAI,GAAG,EAAE,CAAC,kBAAkB,CAAC,OAAO,CAAC,CAAC;IAC5C,IAAI,CAAC,aAAa,GAAG,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,IAAI,KAAK,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IAC/E,MAAM,OAAO,GAAG,EAAE,CAAC,aAAa,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,EAAE,OAAO,EAAE,IAAI,CAAC,CAAC,cAAc,EAAE,CAAC;IACpF,MAAM,OAAO,GAAG,IAAI,GAAG,EAA8B,CAAC;IACtD,KAAK,MAAM,WAAW,IAAI,YAAY,EAAE,CAAC;QACxC,MAAM,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;QAC7D,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;QACzB,CAAC;IACF,CAAC;IACD,KAAK,MAAM,IAAI,IAAI,UAAU,CAAC,MAAM,EAAE,EAAE,CAAC,YAAY,CAAC,EAAE,CAAC;QACxD,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;YACpG,SAAS;QACV,CAAC;QACD,MAAM,MAAM,GAAG,EAAE,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,CAAC;YAC3D,CAAC,CAAC,OAAO,CAAC,iCAAiC,CAAC,IAAI,CAAC,MAAM,CAAC;YACxD,CAAC,CAAC,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;QACrC,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,CAAC;IACF,CAAC;IACD,OAAO,IAAI,GAAG,CACb,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC;SACnB,MAAM,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,WAAW,CAAC,SAAS,CAAC,MAAM,CAAC,IAAI,SAAS,CAAC,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC;SACxI,OAAO,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAC1E,CAAC;AACH,CAAC;AAED,SAAS,eAAe,CAAC,UAAyB;IACjD,MAAM,KAAK,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC;IACpC,IAAI,CAAC,CAAC,EAAE,CAAC,0BAA0B,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;QACpF,OAAO,KAAK,CAAC;IACd,CAAC;IACD,IAAI,IAAI,GAAG,SAAS,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;IACvC,OAAO,CAAC,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,KAAK,KAAK,EAAE,CAAC;QAClH,IAAI,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACnC,CAAC;IACD,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;QAChC,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,MAAM,QAAQ,GAAG,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;IAC/F,MAAM,MAAM,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,IAAI,KAAK,QAAQ,IAAI,CAAC,QAAQ,KAAK,MAAM,IAAI,UAAU,CAAC,MAAM,CAAC,KAAK,MAAM,CAAC,CAAC;IACjI,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IACnC,IAAI,CAAC,MAAM,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;QACvC,OAAO,KAAK,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,SAAS,CAAC,QAAQ,CAAC,CAAC;IACpC,OAAO,CAAC,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,KAAK,UAAU,CAAC;AACvF,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAa;IACtC,OAAO,CACN,WAAW,CAAC,IAAI,CAAC;WACd,CAAC,eAAe,CAAC,IAAI,CAAC,UAAU,CAAC;WACjC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE;YACnC,MAAM,KAAK,GAAG,YAAY,CAAC,QAAQ,CAAC,CAAC;YACrC,OAAO,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,CAAC,CAAC;QAC3C,CAAC,CAAC,CACF,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,WAAW,GAAG,UAAU,CAAC;IACrC,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,EAAE,CACtB,OAAO;SACL,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;SACnC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CACjB,cAAc,CACb,IAAI,EACJ,CAAC,MAAM,EAAE,EAAE;QACV,MAAM,OAAO,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC;QACvC,OAAO,UAAU,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;IAClF,CAAC,EACD,OAAO,CACP,CACD;IACH,WAAW,EAAE,mFAAmF;IAChG,EAAE,EAAE,oBAAoB;CACxB,CAAC,CAAC"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@shivaedev/quality",
3
- "version": "0.41.1",
3
+ "version": "0.43.0",
4
4
  "description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
5
5
  "homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
6
6
  "bugs": {
@@ -59,7 +59,7 @@
59
59
  "dependencies": {
60
60
  "@biomejs/biome": "2.5.15",
61
61
  "@shivaedev/types": "0.3.0",
62
- "ignore": "7.0.12",
62
+ "ignore": "7.0.13",
63
63
  "sort-package-json": "4.1.0",
64
64
  "typescript": "npm:@typescript/typescript6@6.0.2"
65
65
  },
@@ -93,7 +93,7 @@
93
93
  "scripts": {
94
94
  "build": "node --eval \"import('node:fs').then(({ rmSync }) => rmSync('dist', { force: true, recursive: true }))\" && tsc --project tsconfig.build.json",
95
95
  "ready": "pnpm typecheck && pnpm test && pnpm build",
96
- "test": "vitest run",
96
+ "test": "vitest run --configLoader native",
97
97
  "typecheck": "tsc --noEmit"
98
98
  }
99
99
  }
@@ -5,6 +5,6 @@ export function appTestConfig(conditions: string[] = []) {
5
5
  return defineConfig({
6
6
  resolve: { conditions: [...conditions, "module", "browser", "development|production"] },
7
7
  ssr: { resolve: { conditions: [...conditions, "node", "development|production"] } },
8
- test: { ...testProjects(), server: { deps: { inline: ["@shivaedev/platform"] } } },
8
+ test: { ...testProjects(), server: { deps: { inline: [/^@shivaedev\//u] } } },
9
9
  });
10
10
  }
@@ -0,0 +1,52 @@
1
+ import { posix } from "node:path";
2
+ import { isTooling } from "#imports/isTooling.ts";
3
+ import { entryPointsOf, isApplication, provider } from "#manifests/entryPoints.ts";
4
+ import { isTestCode } from "#naming/testName.ts";
5
+ import type { RuleInputs } from "#rule.ts";
6
+ import type { Diagnostic } from "./report.ts";
7
+
8
+ const UNDECLARED = "lint/correctness/noUndeclaredDependencies";
9
+
10
+ const DEPENDENCY = /^Dependency (?<name>\S+) isn't specified in /u;
11
+
12
+ function parsed(text: string | undefined): unknown {
13
+ if (text === undefined) {
14
+ return undefined;
15
+ }
16
+ try {
17
+ return JSON.parse(text);
18
+ } catch {
19
+ return undefined;
20
+ }
21
+ }
22
+
23
+ async function ownerOf(readText: RuleInputs["readText"], path: string) {
24
+ let directory = posix.dirname(path);
25
+ for (;;) {
26
+ const manifest = parsed(await readText(posix.join(directory, "package.json")));
27
+ if (manifest !== undefined || directory === ".") {
28
+ return { directory, manifest };
29
+ }
30
+ directory = posix.dirname(directory);
31
+ }
32
+ }
33
+
34
+ async function brought(readText: RuleInputs["readText"], diagnostic: Diagnostic): Promise<boolean> {
35
+ const name = DEPENDENCY.exec(diagnostic.message)?.groups?.name;
36
+ const path = diagnostic.location.path;
37
+ if (diagnostic.category !== UNDECLARED || name === undefined || path === undefined) {
38
+ return false;
39
+ }
40
+ const owner = await ownerOf(readText, path);
41
+ if (!isApplication(owner.manifest)) {
42
+ return false;
43
+ }
44
+ const entryPoints = await entryPointsOf({ readText }, owner.directory, owner.manifest, new Map());
45
+ const development = isTestCode(path) || isTooling(owner.directory, path);
46
+ return provider(entryPoints, name, development, true) !== undefined;
47
+ }
48
+
49
+ export async function withoutEntryPointImports(readText: RuleInputs["readText"], diagnostics: readonly Diagnostic[]): Promise<readonly Diagnostic[]> {
50
+ const covered = await Promise.all(diagnostics.map((diagnostic) => brought(readText, diagnostic)));
51
+ return diagnostics.filter((_, index) => !covered[index]);
52
+ }
@@ -1,4 +1,6 @@
1
- const KEY = /^(?:packages|"packages"|'packages')\s*:/u;
1
+ function keyPattern(key: string): RegExp {
2
+ return new RegExp(`^(?:${key}|"${key}"|'${key}')\\s*:`, "u");
3
+ }
2
4
 
3
5
  const ITEM = "-";
4
6
 
@@ -25,20 +27,20 @@ function withoutComment(line: string): string {
25
27
  return line.trimEnd();
26
28
  }
27
29
 
28
- function scalar(raw: string): string {
30
+ function scalar(raw: string, key: string): string {
29
31
  const value = raw.trim();
30
32
  if (value.startsWith('"') && value.endsWith('"') && value.length > 1) {
31
33
  try {
32
34
  return String(JSON.parse(value));
33
35
  } catch (error) {
34
- throw failure(`cannot read "${value}" in packages`, error);
36
+ throw failure(`cannot read "${value}" in ${key}`, error);
35
37
  }
36
38
  }
37
39
  if (value.startsWith("'") && value.endsWith("'") && value.length > 1) {
38
40
  return value.slice(1, -1).replaceAll("''", "'");
39
41
  }
40
42
  if (value === "" || value.includes(": ") || value.endsWith(":") || ["[", "{", "'", '"'].some((opening) => value.startsWith(opening))) {
41
- throw failure(`cannot read "${value}" in packages`);
43
+ throw failure(`cannot read "${value}" in ${key}`);
42
44
  }
43
45
  return value;
44
46
  }
@@ -51,20 +53,20 @@ interface FlowScan {
51
53
  quote: string | undefined;
52
54
  }
53
55
 
54
- function flowScalar(raw: string): string {
56
+ function flowScalar(raw: string, key: string): string {
55
57
  const value = raw.trim();
56
58
  const quoted = value.startsWith('"') || value.startsWith("'");
57
59
  if (!quoted && FLOW_INDICATOR.test(value)) {
58
- throw failure(`cannot read "${value}" in packages; quote a pattern that holds { } [ ] or ,`);
60
+ throw failure(`cannot read "${value}" in ${key}; quote a pattern that holds { } [ ] or ,`);
59
61
  }
60
- return scalar(value);
62
+ return scalar(value, key);
61
63
  }
62
64
 
63
- function closed(scan: FlowScan, rest: string): readonly string[] {
65
+ function closed(scan: FlowScan, rest: string, key: string): readonly string[] {
64
66
  if (rest.trim() !== "") {
65
- throw failure(`cannot read "${rest.trim()}" after the packages list`);
67
+ throw failure(`cannot read "${rest.trim()}" after the ${key} list`);
66
68
  }
67
- return [...scan.entries, scan.current].filter((entry) => entry.trim() !== "").map(flowScalar);
69
+ return [...scan.entries, scan.current].filter((entry) => entry.trim() !== "").map((entry) => flowScalar(entry, key));
68
70
  }
69
71
 
70
72
  function scanned(scan: FlowScan, char: string): "close" | undefined {
@@ -83,20 +85,20 @@ function scanned(scan: FlowScan, char: string): "close" | undefined {
83
85
  return undefined;
84
86
  }
85
87
 
86
- function flowList(lines: readonly string[]): readonly string[] {
88
+ function flowList(lines: readonly string[], key: string): readonly string[] {
87
89
  const scan: FlowScan = { current: "", entries: [], quote: undefined };
88
90
  for (const [number, line] of lines.map(withoutComment).entries()) {
89
91
  for (let index = number === 0 ? 1 : 0; index < line.length; index += 1) {
90
92
  if (scanned(scan, line[index] ?? "") === "close") {
91
- return closed(scan, line.slice(index + 1));
93
+ return closed(scan, line.slice(index + 1), key);
92
94
  }
93
95
  }
94
96
  scan.current += " ";
95
97
  }
96
- throw failure("the packages list never closes");
98
+ throw failure(`the ${key} list never closes`);
97
99
  }
98
100
 
99
- function blockList(lines: readonly string[]): readonly string[] {
101
+ function blockList(lines: readonly string[], key: string): readonly string[] {
100
102
  const patterns: string[] = [];
101
103
  for (const line of lines.map(withoutComment)) {
102
104
  const trimmed = line.trim();
@@ -108,27 +110,32 @@ function blockList(lines: readonly string[]): readonly string[] {
108
110
  break;
109
111
  }
110
112
  if (!item) {
111
- throw failure(`cannot read "${trimmed}" in packages`);
113
+ throw failure(`cannot read "${trimmed}" in ${key}`);
112
114
  }
113
- patterns.push(scalar(trimmed.slice(ITEM.length)));
115
+ patterns.push(scalar(trimmed.slice(ITEM.length), key));
114
116
  }
115
117
  return patterns;
116
118
  }
117
119
 
118
- export function pnpmWorkspacePatterns(text: string): readonly string[] {
120
+ export function pnpmWorkspaceList(text: string, key: string): readonly string[] {
121
+ const pattern = keyPattern(key);
119
122
  const lines = text.split(LINE_BREAK);
120
- const start = lines.findIndex((line) => KEY.test(line));
123
+ const start = lines.findIndex((line) => pattern.test(line));
121
124
  if (start === -1) {
122
125
  return [];
123
126
  }
124
127
  const rest = withoutComment(lines[start] ?? "")
125
- .replace(KEY, "")
128
+ .replace(pattern, "")
126
129
  .trim();
127
130
  if (rest.startsWith("[")) {
128
- return flowList([rest, ...lines.slice(start + 1)]);
131
+ return flowList([rest, ...lines.slice(start + 1)], key);
129
132
  }
130
133
  if (rest !== "") {
131
- throw failure(`cannot read "${rest}" in packages`);
134
+ throw failure(`cannot read "${rest}" in ${key}`);
132
135
  }
133
- return blockList(lines.slice(start + 1));
136
+ return blockList(lines.slice(start + 1), key);
137
+ }
138
+
139
+ export function pnpmWorkspacePatterns(text: string): readonly string[] {
140
+ return pnpmWorkspaceList(text, "packages");
134
141
  }