@shipi18n/core 2.11.0 → 2.11.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shipi18n/core",
-  "version": "2.11.0",
+  "version": "2.11.1",
   "description": "Translation QA for i18n locale files: placeholder and plural validation, key parity, coverage, and an LLM-as-judge semantic review. Also a structure-preserving translation engine — bring your own OpenAI or Anthropic key.",
   "type": "module",
   "main": "src/index.js",

package/src/placeholders.js

@@ -42,8 +42,29 @@ export function extractPlaceholders(str) {
   return found.sort()
 }
 
+// An ICU argument used with a function: {count, plural, …}, {gender, select, …},
+// {n, selectordinal, …}, {v, number}, {d, date}, … The bare `{count,` form does
+// not match the single-brace placeholder pattern, so a translation that upgrades
+// a plain {count} to an ICU plural would otherwise read as "dropped {count}".
+const ICU_ARG =
+  /\{\s*([a-zA-Z0-9_]+)\s*,\s*(?:plural|selectordinal|select|number|date|time|spellout|ordinal|duration)\b/g
+const SIMPLE_BRACE = /^\{([a-zA-Z0-9_.]+)\}$/ // a react-intl/ICU {name} placeholder token
+
+/** Names used as ICU function arguments in a string. */
+function icuArgNames(str) {
+  const set = new Set()
+  if (typeof str !== 'string') return set
+  ICU_ARG.lastIndex = 0
+  let m
+  while ((m = ICU_ARG.exec(str)) !== null) set.add(m[1])
+  return set
+}
+
 /**
  * Does the translation preserve exactly the placeholders of the source?
+ * A source `{x}` is considered present when the translation uses `x` as an ICU
+ * argument (`{x, plural|select|…}`) and vice-versa — upgrading a plain variable
+ * to an ICU plural is correct, not a dropped placeholder.
  * @param {string} source
  * @param {string} translation
  * @returns {{ ok: boolean, missing: string[], added: string[] }}
@@ -53,14 +74,20 @@ export function validatePlaceholders(source, translation) {
   const out = extractPlaceholders(translation)
   const outCounts = tally(out)
   const srcCounts = tally(src)
+  const srcIcu = icuArgNames(source)
+  const outIcu = icuArgNames(translation)
   const missing = []
   const added = []
   for (const [ph, n] of Object.entries(srcCounts)) {
-    const diff = n - (outCounts[ph] || 0)
+    let diff = n - (outCounts[ph] || 0)
+    const b = SIMPLE_BRACE.exec(ph)
+    if (diff > 0 && b && outIcu.has(b[1])) diff = 0 // used as an ICU arg in the translation
     for (let i = 0; i < diff; i++) missing.push(ph)
   }
   for (const [ph, n] of Object.entries(outCounts)) {
-    const diff = n - (srcCounts[ph] || 0)
+    let diff = n - (srcCounts[ph] || 0)
+    const b = SIMPLE_BRACE.exec(ph)
+    if (diff > 0 && b && srcIcu.has(b[1])) diff = 0 // source used it as an ICU arg
     for (let i = 0; i < diff; i++) added.push(ph)
   }
   return { ok: missing.length === 0 && added.length === 0, missing, added }

package/src/reporters.js

@@ -76,6 +76,12 @@ export const RULE_META = {
   'semantic-mistranslation': 'LLM judge (majority vote): the translation states something different from the source.',
   'semantic-omission': 'LLM judge (majority vote): meaningful source content is missing from the translation.',
   'semantic-addition': 'LLM judge (majority vote): the translation contains claims the source does not make.',
+  'jed-drift': 'A WordPress JED .json string is out of sync with the .po (re-run wp i18n make-json).',
+  'jed-orphan': 'A WordPress JED .json carries a string the .po no longer has.',
+  'secret-detected': 'A locale string contains a secret or PII (API key, private key, card, email).',
+  'secret-preflight': 'A string was withheld from the LLM because it held a secret or PII.',
+  'android-unescaped-apostrophe': "An Android strings.xml apostrophe is not escaped (\\') or double-quote-wrapped.",
+  'android-unbalanced-quote': 'An Android strings.xml has an unbalanced or unescaped double-quote.',
 }
 
 /** SARIF 2.1.0 — one run, one rule per finding type, one result per finding. */